[PATCH] D157251: [X86][regcall] Do not produce @ number suffix if it is regcall4

yubing updated this revision to Diff 548477. yubing added a comment. Herald added a subscriber: mstorsjo. add testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157251/new/ https://reviews.llvm.org/D157251 Files: clang/lib/AST/Mangle.cpp

[PATCH] D155858: Add a concept AST node.

cor3ntin added inline comments. Comment at: clang/include/clang/AST/ExprConcepts.h:140-143 SourceLocation getBeginLoc() const LLVM_READONLY { -if (auto QualifierLoc = getNestedNameSpecifierLoc()) +if (auto QualifierLoc = CR->getNestedNameSpecifierLoc()) return

[PATCH] D157485: [X86][RFC] Support new feature AVX10

pengfei created this revision. pengfei added reviewers: RKSimon, craig.topper, skan, e-kud. Herald added a subscriber: hiraditya. Herald added a project: All. pengfei requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang,

[PATCH] D157476: [RISCV] Fix wrong type prototype of RVVSlideOneBuiltinSet

eopXD added a comment. I guess we need to update the test cases too, are you able to generate them by modifying the the generator under `riscv-non-isa/rvv-intrinsic-doc`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157476/new/

[PATCH] D156866: [Clang][LoongArch] Use the ClangBuiltin class to automatically generate support for CBE and CFE

This revision was automatically updated to reflect the committed changes. Closed by commit rGea8d3b1f9f2d: [Clang][LoongArch] Use the ClangBuiltin class to automatically generate support… (authored by wangleiat). Changed prior to commit: https://reviews.llvm.org/D156866?vs=547072=548511#toc

[clang] ea8d3b1 - [Clang][LoongArch] Use the ClangBuiltin class to automatically generate support for CBE and CFE

Author: wanglei Date: 2023-08-09T16:04:09+08:00 New Revision: ea8d3b1f9f2d7385d97fcd34d14db0eb2cb2795c URL: https://github.com/llvm/llvm-project/commit/ea8d3b1f9f2d7385d97fcd34d14db0eb2cb2795c DIFF: https://github.com/llvm/llvm-project/commit/ea8d3b1f9f2d7385d97fcd34d14db0eb2cb2795c.diff LOG:

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

VitaNuo updated this revision to Diff 548540. VitaNuo added a comment. Address the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157395/new/ https://reviews.llvm.org/D157395 Files: clang-tools-extra/include-cleaner/lib/FindHeaders.cpp

[PATCH] D157251: [X86][regcall] Do not produce @ number suffix if it is regcall4

yubing updated this revision to Diff 548478. yubing added a comment. small fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157251/new/ https://reviews.llvm.org/D157251 Files: clang/lib/AST/Mangle.cpp

[PATCH] D157477: [clang-repl] Add test for disambiguation of templates

Hahnfeld created this revision. Hahnfeld added a reviewer: v.g.vassilev. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test case was fixed in commit rG2c4620c1

[PATCH] D157394: [clang][DeclPrinter] Improve AST print of function attributes

strimo378 updated this revision to Diff 548487. strimo378 edited the summary of this revision. strimo378 added a comment. Using Attr::getSyntax function (instead of unnecessarly added Attr::getVariety function) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt updated this revision to Diff 548502. RIscRIpt marked an inline comment as done. RIscRIpt added a comment. Updated comment; rebased onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153914/new/ https://reviews.llvm.org/D153914

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:2034-2035 + // StringToks is read-only, we need backstorage for expanded macros + std::vector ExpandedToks; + if (getLangOpts().MicrosoftExt) aaron.ballman wrote: > Thanks, that's

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 548534. koops added a comment. Pulling in latest changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/AST/OpenMPClause.h

[PATCH] D157188: [clang-tidy] Add bugprone-allocation-bool-conversion

PiotrZSL updated this revision to Diff 548554. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Rebase, add support for integer returnign functions, fixes in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157188/new/

[PATCH] D157384: [clang] Added Attr::getVariety function

strimo378 abandoned this revision. strimo378 added a comment. Unnecessary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157384/new/ https://reviews.llvm.org/D157384 ___ cfe-commits mailing list

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

tbaeder added a comment. In D156604#4572018 , @hazohelet wrote: > We need some tests for dtors because they are handled differently from other > functions. > I think the current ExprConstant part would not cover the explicitly-called > dtors because

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152770/new/ https://reviews.llvm.org/D152770 ___

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

asb added a comment. Putting this behind an attribute for now makes sense given that we don't seem to have consensus on https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/389 let alone how to manage any migration. I'm slightly wary of merging this with a generic attribute (currently

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

kadircet added a comment. i think we should also have some unittests in FindHeadersTest, some sample scenarios: foo.h #pragma once void foo(); export1.h #pragma once // IWYU pragma: private, include "public1.h" #include "foo.h" // IWYU pragma: export export2.h #pragma once //

[PATCH] D157474: [RISCV] Add missing Xsfvcp extension check in clang sema

4vtomat updated this revision to Diff 548509. 4vtomat added a comment. Add test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157474/new/ https://reviews.llvm.org/D157474 Files: clang/lib/Sema/SemaRISCVVectorLookup.cpp

[PATCH] D156704: [clang][HeaderSearch] Treat framework headers as System for suggestPath

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156704/new/ https://reviews.llvm.org/D156704

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

sandeepkosuri updated this revision to Diff 548518. sandeepkosuri added a comment. Used the python script `update_cc_test_checks.py` to generate the checks for the newly added tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152054/new/

[PATCH] D157477: [clang-repl] Add test for disambiguation of templates

v.g.vassilev added a comment. If you have not merged this patch please consider my comment. Comment at: clang/test/Interpreter/namespace-template-disambiguate.cpp:7 +namespace NS2 { struct A { public: using S = int; }; } +namespace NS2 { A::S f(A::S a); } + It

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. > Order of exporters is from outermost to innermost. FWIW, that's mostly a coincidence. all 3 exporters are private headers, hence they're penalized for it. Afterwards "export1.h" is

[PATCH] D157474: [RISCV] Add missing Xsfvcp extension check in clang sema

craig.topper added a comment. Is it possible to test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157474/new/ https://reviews.llvm.org/D157474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157384: [clang] Added Attr::getVariety function

strimo378 updated this revision to Diff 548482. strimo378 added a comment. Using Attr::getSyntax (instead of unnecessary added Attr::getVariety) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157384/new/ https://reviews.llvm.org/D157384 Files:

[PATCH] D157331: [clang] Implement C23

ZijunZhao added inline comments. Comment at: clang/test/Headers/stdckdint.cpp:1 +// RUN: %clang_cc1 -emit-llvm -fgnuc-version=4.2.1 -std=gnu++11 %s -o - | FileCheck %s + enh wrote: > ZijunZhao wrote: > > enh wrote: > > > ZijunZhao wrote: > > > > enh wrote: > >

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 548494. koops added a reviewer: thakis. koops added a comment. Making the CHECK pattern generic to match platforms tested after committing changes (especially MacOS). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/

[clang-tools-extra] 0a315be - [include-cleaner] Dont boost private headers beyond public ones

Author: Kadir Cetinkaya Date: 2023-08-09T09:36:48+02:00 New Revision: 0a315be2a46f35bb990dd6c8418a189daec15350 URL: https://github.com/llvm/llvm-project/commit/0a315be2a46f35bb990dd6c8418a189daec15350 DIFF:

[PATCH] D157400: [include-cleaner] Dont boost private headers beyond public ones

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a315be2a46f: [include-cleaner] Dont boost private headers beyond public ones (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157476: [RISCV] Fix wrong type prototype of RVVSlideOneBuiltinSet

eopXD added a comment. I mean vint8mf8_t test_vslide1up_vx_i8mf8(vint8mf8_t src, int8_t value, size_t vl) { return __riscv_vslide1up_vx_i8mf8(src, value, vl); } should change into vint8mf8_t test_vslide1up_vx_i8mf8(vint8mf8_t src, uint8_t value, size_t vl) { return

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

cor3ntin updated this revision to Diff 548503. cor3ntin added a comment. Add C tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156596/new/ https://reviews.llvm.org/D156596 Files: clang/include/clang/Basic/DiagnosticLexKinds.td

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

zixuan-wu added inline comments. Comment at: clang/test/Driver/debug-options.c:245 // // RUN: %clang -### -c -gsplit-dwarf -g -gno-pubnames %s 2>&1 | FileCheck -check-prefix=NOPUB %s // Here should add not or specify the target with x86 because it fails when

[PATCH] D157477: [clang-repl] Add test for disambiguation of templates

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Thanks, @Hahnfeld! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157477/new/ https://reviews.llvm.org/D157477

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

vhscampos created this revision. Herald added a project: All. vhscampos requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In cases where a structured binding declaration is made to a struct with bitfields: struct A { unsigned int x : 16;

[PATCH] D157480: [clang-repl] Disambiguate global namespace identifiers

v.g.vassilev added inline comments. Comment at: clang/test/Interpreter/global-namespace-disambiguate.cpp:6 +struct A { ~A(); }; +::A::~A() {} + Can we add this test to `disambiguate-decl-stmt.cpp` instead where we track these things? Repository: rG LLVM

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

sdesmalen updated this revision to Diff 548526. sdesmalen added a comment. Updated LLVM MC tests which were failing because smstart/smstop are no longer predicated by 'sme'. Sorry, I only just noticed that I hadn't run all the tests yet. @paulwalker-arm could you give this another look?

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

asb added a comment. @jacquesguan: I think this is good to go if you rebase now D156221 landed and add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547

[PATCH] D157476: [RISCV] Fix wrong type prototype of RVVSlideOneBuiltinSet

wangpc created this revision. wangpc added reviewers: kito-cheng, eopXD, craig.topper. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D157251: [X86][regcall] Do not produce @ number suffix if it is regcall4

yubing updated this revision to Diff 548479. yubing added a comment. small fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157251/new/ https://reviews.llvm.org/D157251 Files: clang/lib/AST/Mangle.cpp

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

hazohelet added a comment. We need some tests for dtors because they are handled differently from other functions. I think the current ExprConstant part would not cover the explicitly-called dtors because the `HandleDestructorImpl` only has access to `CallLoc` and not source range. Also new

[PATCH] D141714: Fix ast print of variables with attributes

strimo378 added a comment. @giulianobelinassi I provided a similar patch as you addressed here, see https://reviews.llvm.org/D157394 . It looks like we have the same requirement that we both need compilable ast-print code. Are you interested in a teams meeting to discuss the topic and align

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 548499. koops added a reviewer: thakis. koops added a comment. Making the CHECK pattern generic to match platforms tested after committing changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 Files:

[PATCH] D157476: [RISCV] Fix wrong type prototype of RVVSlideOneBuiltinSet

wangpc added a comment. In D157476#4572135 , @eopXD wrote: > I mean > > vint8mf8_t test_vslide1up_vx_i8mf8(vint8mf8_t src, int8_t value, size_t vl) > { > return __riscv_vslide1up_vx_i8mf8(src, value, vl); > } > > should change into > >

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

tbaeder updated this revision to Diff 548520. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156604/new/ https://reviews.llvm.org/D156604 Files: clang/lib/AST/ExprConstant.cpp clang/lib/AST/Interp/Frame.h clang/lib/AST/Interp/InterpFrame.cpp clang/lib/AST/Interp/InterpFrame.h

[PATCH] D157410: [Flang][Driver] Enable Rpass and other R family options.

kiranchandramohan accepted this revision. kiranchandramohan added a comment. LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157410/new/ https://reviews.llvm.org/D157410 ___ cfe-commits mailing list

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy planned changes to this revision. donat.nagy marked 5 inline comments as done. donat.nagy added a comment. I'll soon upload a refactored version. Comment at: clang/docs/analyzer/checkers.rst:44-50 +Moreover, if the pedantic mode is activated by +``-analyzer-config

[PATCH] D157480: [clang-repl] Disambiguate global namespace identifiers

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157480/new/ https://reviews.llvm.org/D157480 ___ cfe-commits mailing list

[PATCH] D157497: feat: Migrate isArch16Bit

Pivnoy created this revision. Herald added subscribers: s.egerton, simoncook, asb, fedor.sergeev, hiraditya, rampitec. Herald added a project: All. Pivnoy requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wangpc, aheejin. Herald added projects: clang, LLVM.

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4329-4330 if (Result) { +// Ambiguity means an initializer list constructor would not be called +// Or a deleted non-initializer-list constructor was to be called +if (CopyElisionPossible &&

[clang] d64c363 - [Clang][LoongArch] Add '-o /dev/null' to a test that does not care about the output

Author: Dmitri Gribenko Date: 2023-08-09T16:07:41+02:00 New Revision: d64c363f35b98ab9750a3c3a5828d8df011a4a45 URL: https://github.com/llvm/llvm-project/commit/d64c363f35b98ab9750a3c3a5828d8df011a4a45 DIFF:

[PATCH] D157410: [Flang][Driver] Enable Rpass and other R family options.

awarzynski accepted this revision. awarzynski added a comment. LG, with a small suggestion :) (in the spirit of cleaning up Options.td) Comment at: clang/include/clang/Driver/Options.td:819-831 +def Rpass_EQ : Joined<["-"], "Rpass=">, Group, Flags<[CC1Option, FlangOption,

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

awarzynski added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:173-174 +if (!result.Regex->isValid(regexError)) { + diags.Report(clang::diag::err_drv_optimization_remark_pattern) + << regexError << a->getAsString(args); + return

[PATCH] D157452: [RFC][Clang][Codegen] `std::type_info` needs special care with explicit address spaces

AlexVlx added a comment. In D157452#4573076 , @yaxunl wrote: > It is a little concerning how far the global address will spread further. > Compared to handling user-defined global variables, we keep the global > address to its definition in the IR and

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sdesmalen marked 4 inline comments as done. Closed by commit rG453c30e9e633: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions. (authored by

[clang] 453c30e - [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

Author: Sander de Smalen Date: 2023-08-09T12:37:41Z New Revision: 453c30e9e633f5b1e9bebed950592e3e51645a94 URL: https://github.com/llvm/llvm-project/commit/453c30e9e633f5b1e9bebed950592e3e51645a94 DIFF: https://github.com/llvm/llvm-project/commit/453c30e9e633f5b1e9bebed950592e3e51645a94.diff

[clang] 479955a - [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

Author: Ties Stuij Date: 2023-08-09T14:16:11+01:00 New Revision: 479955a42a71242e3577c639ca276c75f1a3c2b2 URL: https://github.com/llvm/llvm-project/commit/479955a42a71242e3577c639ca276c75f1a3c2b2 DIFF: https://github.com/llvm/llvm-project/commit/479955a42a71242e3577c639ca276c75f1a3c2b2.diff

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:1470 + SourceLocation FromLoc; + // C++ [over.ics.list]p6, per DR2137: + // If C is not an initializer-list constructor and the initializer list Can you specify an exact

[PATCH] D157452: [RFC][Clang][Codegen] `std::type_info` needs special care with explicit address spaces

yaxunl added a comment. It is a little concerning how far the global address will spread further. Compared to handling user-defined global variables, we keep the global address to its definition in the IR and any use of it will use the generic pointer addrcasted from its definition. This

[PATCH] D156866: [Clang][LoongArch] Use the ClangBuiltin class to automatically generate support for CBE and CFE

MaskRay added inline comments. Comment at: clang/test/CodeGen/LoongArch/intrinsic-la32-error.c:2 // RUN: %clang_cc1 -triple loongarch32 -emit-llvm -S -verify %s -o /dev/null +// RUN: not %clang_cc1 -triple loongarch32 -DFEATURE_CHECK -emit-llvm %s 2>&1 \ +// RUN: | FileCheck

[PATCH] D157331: [clang] Implement C23

aaron.ballman added reviewers: efriedma, jyknight, clang-language-wg, hubert.reinterpretcast. aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Thank you for working on this! Adding some more reviewers for more

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy updated this revision to Diff 548626. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156312/new/ https://reviews.llvm.org/D156312 Files: clang/docs/analyzer/checkers.rst clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy marked 6 inline comments as done. donat.nagy added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/BitwiseShiftChecker.cpp:94-98 +void BitwiseShiftValidator::run() { + if (isValidShift()) { +Ctx.addTransition(State, createNoteTag()); + } +}

[clang-tools-extra] c3ad4b7 - [include-cleaner] Follow `IWYU pragma: export` links transitively.

Author: Viktoriia Bakalova Date: 2023-08-09T12:10:13Z New Revision: c3ad4b7636022db387e33ab03247a93aa63d7488 URL: https://github.com/llvm/llvm-project/commit/c3ad4b7636022db387e33ab03247a93aa63d7488 DIFF: https://github.com/llvm/llvm-project/commit/c3ad4b7636022db387e33ab03247a93aa63d7488.diff

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3ad4b763602: [include-cleaner] Follow `IWYU pragma: export` links transitively. (authored by VitaNuo). Changed prior to commit:

[clang] ecb7b9c - [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

Author: Sander de Smalen Date: 2023-08-09T12:31:02Z New Revision: ecb7b9c5c589b693e8a7351461db5b520be0bc90 URL: https://github.com/llvm/llvm-project/commit/ecb7b9c5c589b693e8a7351461db5b520be0bc90 DIFF: https://github.com/llvm/llvm-project/commit/ecb7b9c5c589b693e8a7351461db5b520be0bc90.diff

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGecb7b9c5c589: [Clang][AArch64] Diagnostics for SME attributes when target doesnt have sme (authored by sdesmalen). Repository: rG LLVM Github

[clang] 90c1f51 - [clang][analyzer] Fix empty enum handling in EnumCastOutOfRange checker

Author: Endre Fülöp Date: 2023-08-09T15:12:09+02:00 New Revision: 90c1f51c4b3e7a38a5e1b75de75d15757fc861e4 URL: https://github.com/llvm/llvm-project/commit/90c1f51c4b3e7a38a5e1b75de75d15757fc861e4 DIFF: https://github.com/llvm/llvm-project/commit/90c1f51c4b3e7a38a5e1b75de75d15757fc861e4.diff

[PATCH] D153954: [clang][analyzer] Fix empty enum handling in EnumCastOutOfRange checker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90c1f51c4b3e: [clang][analyzer] Fix empty enum handling in EnumCastOutOfRange checker (authored by gamesh411). Repository: rG LLVM Github

[clang] da555f7 - [clang-repl] Additional test for disambiguation of templates

Author: Jonas Hahnfeld Date: 2023-08-09T16:15:14+02:00 New Revision: da555f750ab21d200ce486b45af75476662ca3b5 URL: https://github.com/llvm/llvm-project/commit/da555f750ab21d200ce486b45af75476662ca3b5 DIFF:

[PATCH] D157477: [clang-repl] Additional test for disambiguation of templates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda555f750ab2: [clang-repl] Additional test for disambiguation of templates (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D157251: [X86][regcall] Do not produce @ number suffix if it is regcall4

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157251/new/ https://reviews.llvm.org/D157251

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

yichi170 updated this revision to Diff 548632. yichi170 marked 4 inline comments as done. yichi170 added a comment. Applied the suggestions. Thanks for giving me feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157201/new/

[PATCH] D157477: [clang-repl] Additional test for disambiguation of templates

Hahnfeld added inline comments. Comment at: clang/test/Interpreter/namespace-template-disambiguate.cpp:7 +namespace NS2 { struct A { public: using S = int; }; } +namespace NS2 { A::S f(A::S a); } + v.g.vassilev wrote: > It might be a good idea to add this test

[PATCH] D157477: [clang-repl] Additional test for disambiguation of templates

Hahnfeld updated this revision to Diff 548558. Hahnfeld retitled this revision from "[clang-repl] Add test for disambiguation of templates" to "[clang-repl] Additional test for disambiguation of templates". Hahnfeld edited the summary of this revision. CHANGES SINCE LAST ACTION

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 548589. victorkingi added a comment. split the patch into 2. This is the implementation patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files:

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy marked 2 inline comments as done. donat.nagy added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/BitwiseShiftChecker.cpp:301-302 + pluralSuffix(MaximalAllowedShift)); +R->addNote(LeftNote, PathDiagnosticLocation{LHS,

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

aaron.ballman added reviewers: clang-language-wg, hubert.reinterpretcast, aaron.ballman. aaron.ballman added a comment. Adding some more reviewers to hopefully get this unstuck. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156032/new/

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

aaron.ballman added a comment. Btw, it looks like precommit CI may have found issues in libc++ related to your changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156032/new/ https://reviews.llvm.org/D156032

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Ping for review. If there are no comments on whether we should add `-lpthread` for platforms other than AIX, I will land this patch soon, and let the official buildbots check for problems. If there are problems, I will let the bots run a bit (probably a day or so)

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

tbaeder added a comment. While both of those suggestions are probably improvements (I haven't checked), they also seem out of scope for this patch. This is just adding source ranges. We can improve them later (and add better tests for them at that point). CHANGES SINCE LAST ACTION

[clang] adf8d6e - [Driver][test] Specify --target= for a -gsplit-dwarf test

Author: Fangrui Song Date: 2023-08-09T07:42:38-07:00 New Revision: adf8d6e7a4674b9149d69da7e1d53b3c3ba64ec8 URL: https://github.com/llvm/llvm-project/commit/adf8d6e7a4674b9149d69da7e1d53b3c3ba64ec8 DIFF: https://github.com/llvm/llvm-project/commit/adf8d6e7a4674b9149d69da7e1d53b3c3ba64ec8.diff

[PATCH] D157331: [clang] Implement C23

cor3ntin added inline comments. Comment at: clang/lib/Headers/stdckdint.h:13 + +#if defined(__GNUC__) +#define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R)) aaron.ballman wrote: > hiraditya wrote: > > enh wrote: > > > hiraditya wrote: > > > > xbolva00

[PATCH] D157485: [X86][RFC] Support new feature AVX10

goldstein.w.n added inline comments. Comment at: clang/lib/Basic/Targets/X86.h:99 + bool HasAVX10_1 = false; + bool HasAVX10_512BIT = false; bool HasAVX512CD = false; Maybe should be HasAVX10_1_512? As brought up the rfc, there might be an avx10.2-512

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

ABataev added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_simd_tl_codegen.cpp:4 + +// RUN: %clang_cc1 -fopenmp -fopenmp-version=51 -emit-llvm %s -o - | FileCheck --check-prefix=OMP51 %s + Add PCH serialization/desrialization checks in

[PATCH] D157394: [clang][DeclPrinter] Improve AST print of function attributes

giulianobelinassi added subscribers: erichkeane, giulianobelinassi. giulianobelinassi added a comment. This patch do not address attributes in variables nor the __declspec case, as D141714 do. His patch looks cleaner and I can surely coordinate with @strimo378

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

hazohelet accepted this revision. hazohelet added a comment. I think it would be helpful to point to the subobject source range when diagnosing errors in subobject dtors, so I left some suggestions. Otherwise this LGTM. Thanks! Comment at: clang/lib/AST/ExprConstant.cpp:6663

[clang] f6ee4e3 - [clang][ExprConst] Add RHS source range to div by zero diags

Author: Timm Bäder Date: 2023-08-09T15:48:50+02:00 New Revision: f6ee4e3f5562acfb11f3c36f555e37246aaeefea URL: https://github.com/llvm/llvm-project/commit/f6ee4e3f5562acfb11f3c36f555e37246aaeefea DIFF: https://github.com/llvm/llvm-project/commit/f6ee4e3f5562acfb11f3c36f555e37246aaeefea.diff

[PATCH] D157331: [clang] Implement C23

enh added a comment. > I try to grep "std>" in clang/test/Headers but find nothing, and nothing in > stdalign.h is about > grep for `__STDC_VERSION__` instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/

[PATCH] D157503: Silently accept -Wgnu-empty-initializer

aaron.ballman created this revision. aaron.ballman added reviewers: porglezomp, jyknight, nickdesaulniers. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang.

[PATCH] D157493: Revert "Revert "[Flang][Sema] Move directive sets to a shared location""

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LG. Please wait for the CI to pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157493/new/

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM but please wait for @hubert.reinterpretcast to confirm the new tests cover what he was looking for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

aidengrossman updated this revision to Diff 548473. aidengrossman added a comment. Reformat using arc as manually uploading patch messes up formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157334/new/ https://reviews.llvm.org/D157334

[PATCH] D157476: [RISCV] Fix wrong type prototype of RVVSlideOneBuiltinSet

wangpc added a comment. In D157476#4572073 , @eopXD wrote: > I guess we need to update the test cases too, are you able to generate them > by modifying the the generator under `riscv-non-isa/rvv-intrinsic-doc`? For this patch, we don't need to update

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

v.g.vassilev added inline comments. Comment at: clang/docs/ExecutionResultsHandling.rst:80 + +For example, the CPPYY code makes use of this feature to enable running +C++ within Python. It enables transporting values/information between C++ cppyy seems

[PATCH] D157480: [clang-repl] Disambiguate global namespace identifiers

Hahnfeld created this revision. Hahnfeld added reviewers: v.g.vassilev, aaron.ballman. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A double colon starts an identifier name in the global namespace

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher requested changes to this revision. QuillPusher added a comment. This revision now requires changes to proceed. added minor changes based on Vassil's review during docs meeting Comment at: clang/docs/ClangRepl.rst:220-230 + +:doc:`ExecutionResultsHandling` helps

[PATCH] D157410: [Flang] Enable Rpass flag

victorkingi updated this revision to Diff 548517. victorkingi added a comment. fixed comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157410/new/ https://reviews.llvm.org/D157410 Files: clang/include/clang/Driver/Options.td

[PATCH] D156027: [clang][Interp] Rework how initializers work

tbaeder updated this revision to Diff 548522. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156027/new/ https://reviews.llvm.org/D156027 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h

[PATCH] D156027: [clang][Interp] Rework how initializers work

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:545-547 + // TODO(perf): For int and bool types, we can probably just skip this + // since we memset our Block*s to 0 and so we have the desired value + // without this.

  1   2   3   >