[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

ABataev added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_simd_tl_codegen.cpp:30 +// OMP51-NEXT: entry: +// OMP51-NEXT:[[DOTGLOBAL_TID__ADDR_I:%.*]] = alloca i32, align 4 +// OMP51-NEXT:[[DOTPART_ID__ADDR_I:%.*]] = alloca ptr, align 8

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin added a comment. ping~ @hubert.reinterpretcast @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/ https://reviews.llvm.org/D153701 ___ cfe-commits mailing list

[PATCH] D158671: [NFC][Clang] Fix static analyzer concerns

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with some nits Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:195 SymbolReference Context; -auto Record = dyn_cast(Decl->getDeclContext()); +auto Record =

[clang] b9d78bd - [clang][modules] Use relative offsets for input files

Author: Jan Svoboda Date: 2023-08-24T09:16:04-07:00 New Revision: b9d78bdc730b2fcfe029a7579c24020536c3fa25 URL: https://github.com/llvm/llvm-project/commit/b9d78bdc730b2fcfe029a7579c24020536c3fa25 DIFF: https://github.com/llvm/llvm-project/commit/b9d78bdc730b2fcfe029a7579c24020536c3fa25.diff

[clang] 7d15657 - [clang][modules] Move `UNHASHED_CONTROL_BLOCK` up in the AST file

Author: Jan Svoboda Date: 2023-08-24T09:16:04-07:00 New Revision: 7d1565727dad3acb54fe76a908630843835d7bc8 URL: https://github.com/llvm/llvm-project/commit/7d1565727dad3acb54fe76a908630843835d7bc8 DIFF: https://github.com/llvm/llvm-project/commit/7d1565727dad3acb54fe76a908630843835d7bc8.diff

[PATCH] D158572: [clang][modules] Use relative offsets for input files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9d78bdc730b: [clang][modules] Use relative offsets for input files (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D158573: [clang][modules] Move `UNHASHED_CONTROL_BLOCK` up in the AST file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jansvoboda11 marked an inline comment as done. Closed by commit rG7d1565727dad: [clang][modules] Move `UNHASHED_CONTROL_BLOCK` up in the AST file (authored by

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam updated this revision to Diff 553179. saiislam marked 7 inline comments as done. saiislam added a comment. Updated test case to check internalization of newly inserted global variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8649-8650 + // code-object-version=X needs to be passed to clang-linker-wrapper to ensure + // that it is used by lld. + if (const Arg *A =

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

jhuber6 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h:49 -static_assert(sizeof(AMDGPUImplicitArgsTy) == 56, - "Unexpected size of implicit arguments"); +enum IMPLICITARGS : uint32_t { + COV4_SIZE = 56,

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h:49 -static_assert(sizeof(AMDGPUImplicitArgsTy) == 56, - "Unexpected size of implicit arguments"); +enum

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

jhuber6 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h:49 -static_assert(sizeof(AMDGPUImplicitArgsTy) == 56, - "Unexpected size of implicit arguments"); +enum IMPLICITARGS : uint32_t { + COV4_SIZE = 56,

[clang] bfbea45 - Revert "[clang] - Add missing builtin name to AtomicExpr JSON dump"

Author: Douglas Yung Date: 2023-08-24T10:11:59-07:00 New Revision: bfbea459af391266cf6a4611f0da4952930d7834 URL: https://github.com/llvm/llvm-project/commit/bfbea459af391266cf6a4611f0da4952930d7834 DIFF: https://github.com/llvm/llvm-project/commit/bfbea459af391266cf6a4611f0da4952930d7834.diff

[PATCH] D158755: Make "-fno-split-machine-functions" a valid flag for all archs.

shenhan created this revision. shenhan added a reviewer: MaskRay. Herald added a subscriber: pengfei. Herald added a project: All. shenhan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, when clang reports an error when

[PATCH] D158695: [clang] Fix missing contract flag in sqrt intrinsic

rjmccall added a comment. Code change LGTM; I'll let you hash out the test feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158695/new/ https://reviews.llvm.org/D158695 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D158730: [DebugMetadata][DwarfDebug] Don't retain local types with -fno-eliminate-unused-debug-types

dzhidzhoev created this revision. dzhidzhoev added reviewers: aprantl, dblaikie, jdoerfert, dexonsmith, rnk, nickdesaulniers. Herald added a subscriber: hiraditya. Herald added a project: All. dzhidzhoev requested review of this revision. Herald added projects: clang, LLVM. Herald added

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

aaron.ballman added a comment. In D157572#4612141 , @cjdb wrote: > I don't dislike it, but I am a bit concerned about misuse being noisy. So you're concerned that a library author uses `diagnose_if` to add a diagnostic to a warning group that makes the

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

MitalAshok updated this revision to Diff 553055. MitalAshok added a comment. enums now considered compatible with unsigned/signed versions of their underlying type for the purposes of -Wvarargs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

MitalAshok updated this revision to Diff 553056. MitalAshok added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156054/new/ https://reviews.llvm.org/D156054 Files: clang/docs/ReleaseNotes.rst

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

MitalAshok added inline comments. Comment at: clang/test/SemaCXX/varargs.cpp:34 enum Unscoped1 { One = 0x7FFF }; - (void)__builtin_va_arg(ap, Unscoped1); // ok + (void)__builtin_va_arg(ap, Unscoped1); // expected-warning {{second argument to 'va_arg' is of promotable

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

sandeepkosuri marked an inline comment as done. sandeepkosuri added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_simd_tl_codegen.cpp:30 +// OMP51-NEXT: entry: +// OMP51-NEXT:[[DOTGLOBAL_TID__ADDR_I:%.*]] = alloca i32, align 4 +// OMP51-NEXT:

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. +

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

ABataev added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_simd_tl_codegen.cpp:30 +// OMP51-NEXT: entry: +// OMP51-NEXT:[[DOTGLOBAL_TID__ADDR_I:%.*]] = alloca i32, align 4 +// OMP51-NEXT:[[DOTPART_ID__ADDR_I:%.*]] = alloca ptr, align 8

[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

miyengar updated this revision to Diff 553104. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158626/new/ https://reviews.llvm.org/D158626 Files: clang/include/clang/Basic/arm_neon.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

miyengar marked an inline comment as done. miyengar added a comment. Thank you for the feedback! I've added an amended patch using the pre-existing instruction. Also, I've tried to submit the patch with context this time. Comment at:

[clang] ff7d2fa - Update a broken link in documentation; NFC

Author: Aaron Ballman Date: 2023-08-24T09:52:30-04:00 New Revision: ff7d2fabe074d95cefb683d4a742eec172bd36d5 URL: https://github.com/llvm/llvm-project/commit/ff7d2fabe074d95cefb683d4a742eec172bd36d5 DIFF: https://github.com/llvm/llvm-project/commit/ff7d2fabe074d95cefb683d4a742eec172bd36d5.diff

[PATCH] D158733: [Clang] Fix a crash when an invalid immediate function call appears in a cast

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Fixes #64949 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158733 Files:

[PATCH] D158733: [Clang] Fix a crash when an invalid immediate function call appears in a cast

cor3ntin updated this revision to Diff 553109. cor3ntin added a comment. Remove accidentyally commited change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158733/new/ https://reviews.llvm.org/D158733 Files: clang/docs/ReleaseNotes.rst

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:911-915 if (X->getNumParams() != Y->getNumParams()) return false; for (unsigned I = 0; I < X->getNumParams(); ++I) if (!Ctx.hasSameUnqualifiedType(X->getParamDecl(I)->getType(),

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

kaz7 marked 3 inline comments as done. kaz7 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157813/new/ https://reviews.llvm.org/D157813 ___ cfe-commits mailing list

[clang] 158f4f3 - [Clang] Do not change the type of captured vars when checking lambda constraints

Author: Corentin Jabot Date: 2023-08-24T16:10:08+02:00 New Revision: 158f4f30adb4bfd390057742a32934e4344e8fd3 URL: https://github.com/llvm/llvm-project/commit/158f4f30adb4bfd390057742a32934e4344e8fd3 DIFF:

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

donat.nagy added a comment. Thanks for creating this commit, it's a useful improvement! I added some inline comments on minor implementation details; moreover, note that "Releted checkers:" (instead of "related") is a typo in the commit message. I also have a less concrete question about the

[PATCH] D158433: [Clang] Do not change the type of captured vars when checking lambda constraints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG158f4f30adb4: [Clang] Do not change the type of captured vars when checking lambda constraints (authored by cor3ntin). Repository: rG LLVM Github

[clang] 3f98cdc - [Clang] Always constant-evaluate operands of comparisons to nullptr

Author: Corentin Jabot Date: 2023-08-24T16:11:10+02:00 New Revision: 3f98cdc815bddd2b69e3298fa104c0305503292e URL: https://github.com/llvm/llvm-project/commit/3f98cdc815bddd2b69e3298fa104c0305503292e DIFF:

[PATCH] D158601: [Clang] Always constant-evaluate operands of comparisons to nullptr

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f98cdc815bd: [Clang] Always constant-evaluate operands of comparisons to nullptr (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158411: [clang] [MinGW] Pass LTO options to the linker

mati865 accepted this revision. mati865 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158411/new/ https://reviews.llvm.org/D158411

[PATCH] D158694: [libc++] Re-enable the __std_module test

ldionne updated this revision to Diff 553120. ldionne added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also touch a Clang file just to trigger their CI pipeline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151904: [clang-repl][CUDA] Add an unit test for interactive CUDA

v.g.vassilev added a comment. @argentite ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151904/new/ https://reviews.llvm.org/D151904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D158140: WIP: [clang-repl] Basic WebAssembly support for running inside a JS engine

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/WASM.cpp:79 + int Result = + lld::wasm::link(LinkerArgs, llvm::outs(), llvm::errs(), false, false); + if (!Result) sbc100 wrote: > v.g.vassilev wrote: > > sbc100 wrote: > > > argentite

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1495-1499 + DeclContext *DC = CurContext; + while (DC && !isa(DC) && !isa(DC) && + !isa(DC) && !isa(DC)) +DC = DC->getParent(); + return dyn_cast_or_null(DC); RIscRIpt wrote: >

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt updated this revision to Diff 553122. RIscRIpt marked an inline comment as done. RIscRIpt added a comment. Rebase onto main, address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/

[PATCH] D158641: [AArch64][Android][DRAFT] Fix FMV ifunc resolver usage on old Android APIs.

enh added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:1382 +return; +#if defined(__ANDROID__) + // ifunc resolvers don't have hwcaps in arguments on Android API lower ilinpv wrote: > MaskRay wrote: > > I am unfamiliar with how Android

[PATCH] D158666: [Clang] Fix linker error for function multiversioning

tahonermann added a comment. A couple of observations with regard to compatibility: gcc,, at least by default, emits the TC implementations as local functions, the resolver as a weak global function, and the undecorated name as an ifunc. When only a TC declaration (not a definition) is

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt updated this revision to Diff 553123. RIscRIpt marked an inline comment as done. RIscRIpt added a comment. Use isa<...> in getPredefinedExprDeclContext Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt added a comment. I missed this comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D158591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D158733: [Clang] Fix a crash when an invalid immediate function call appears in a cast

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 1 nit that the build bots caught, else I'm happy. Comment at: clang/lib/Sema/SemaExpr.cpp:18364 + +assert(FD && FD->isImmediateFunction && + "could not

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt added a comment. The current implementation of `getPredefinedExprDeclContext` could be easily moved to a static function inside `clang/lib/Sema/SemaExpr.cpp` as it depends only on `Sema::CurContext` WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f4c886b - [clang] Properly print unnamed members in diagnostics

Author: Podchishchaeva, Mariya Date: 2023-08-24T07:24:29-07:00 New Revision: f4c886b6aaeac0a48f3bdeda3103887599373842 URL: https://github.com/llvm/llvm-project/commit/f4c886b6aaeac0a48f3bdeda3103887599373842 DIFF:

[PATCH] D158526: [clang] Properly print unnamed members in diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4c886b6aaea: [clang] Properly print unnamed members in diagnostics (authored by Fznamznon). Changed prior to commit:

[PATCH] D158739: AIX: Issue an error when specifying an alias for a common symbol

stephenpeckham created this revision. stephenpeckham added reviewers: hubert.reinterpretcast, DiggerLin, jhenderson. Herald added subscribers: jeroen.dobbelaere, kbarton, hiraditya, nemanjai. Herald added a project: All. stephenpeckham requested review of this revision. Herald added projects:

[PATCH] D158666: [Clang] Fix linker error for function multiversioning

tahonermann added a comment. I think it would also be a good idea to exercise the test case for a target that lacks ifunc support to ensure that inter-TU calls work as expected. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158666/new/ https://reviews.llvm.org/D158666

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

sammccall added a comment. Aside: I've been doing some investigation into how modules+clangd could work in our huge monorepo (specifically bazel + distributed build cluster). It looks feasible (with some serious effort) to get all BMI/index/etc data we need for transitive modules to be

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

steakhal added a comment. Maybe its too early for the patch, but if a nonlocal change, like changing some Core functionality, we usually measure the real world implications and compare it against some baseline to get an idea how this affects the whole system. It also helps uncovering corner

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

danix800 added a comment. In D158707#4613743 , @donat.nagy wrote: > Thanks for creating this commit, it's a useful improvement! > > I added some inline comments on minor implementation details; moreover, note > that "Releted checkers:" (instead of

[PATCH] D158733: [Clang] Fix a crash when an invalid immediate function call appears in a cast

shafik added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:1120 + +void k() { (int)h{nullptr}; } +// expected-error@-1 {{call to consteval function 'GH64949::h::h' is not a constant expression}} Another variety maybe worthing adding a test

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

danix800 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:202-203 // CHECK UPPER BOUND - DefinedOrUnknownSVal Size = getDynamicExtent(state, Reg, svalBuilder); + SVal Size = svalBuilder.convertToArrayIndex( +

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

danix800 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp:180-183 + SVal CountReached = + SVB.evalBinOp(State, BO_GE, Idx, Count, ASTCtx.BoolTy); + if (!CountReached.isUndef() && +

[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1468-1477 std::optional getRangeForNegatedSymSym(const SymSymExpr *SSE) { return getRangeForNegatedExpr( [SSE, State = this->State]() -> SymbolRef {

[PATCH] D117929: [XRay] Add support for RISCV

ashwin98 updated this revision to Diff 553135. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117929/new/ https://reviews.llvm.org/D117929 Files: clang/lib/Driver/XRayArgs.cpp compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake compiler-rt/lib/xray/CMakeLists.txt

[PATCH] D117929: [XRay] Add support for RISCV

ashwin98 added inline comments. Comment at: compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake:83 set(ALL_XRAY_SUPPORTED_ARCH ${X86_64} ${ARM32} ${ARM64} ${MIPS32} ${MIPS64} - powerpc64le ${HEXAGON} ${LOONGARCH64}) + powerpc64le ${HEXAGON}

[clang] dbccf3c - [clang] - Add missing builtin name to AtomicExpr JSON dump

Author: serge-sans-paille Date: 2023-08-24T17:09:49+02:00 New Revision: dbccf3c6f13d2afeecec77136460c5e359164eae URL: https://github.com/llvm/llvm-project/commit/dbccf3c6f13d2afeecec77136460c5e359164eae DIFF:

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbccf3c6f13d: [clang] - Add missing builtin name to AtomicExpr JSON dump (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

danix800 added inline comments. Comment at: clang/test/Analysis/array-bound-v2-constraint-check.c:1 -// RUN: %clang_analyze_cc1 -analyzer-checker=core,alpha.security.ArrayBoundV2,debug.ExprInspection \ +// RUN: %clang_analyze_cc1

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

sandeepkosuri updated this revision to Diff 553139. sandeepkosuri added a comment. Edited the LIT test cases to use more script generated check lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152054/new/ https://reviews.llvm.org/D152054

[PATCH] D158695: [clang] Fix missing contract flag in sqrt intrinsic

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:501 if (CGF.Builder.getIsFPConstrained()) { CodeGenFunction::CGFPOptionsRAII FPOptsRAII(CGF, E); Function *F =

[PATCH] D158695: [clang] Fix missing contract flag in sqrt intrinsic

yaxunl updated this revision to Diff 553141. yaxunl marked 3 inline comments as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158695/new/ https://reviews.llvm.org/D158695 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D156624: [clang-tidy] Access checks not done classes derived of std::array

sousajo added a comment. @PiotrZSL @carlosgalvezp can you please recheck? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156624/new/ https://reviews.llvm.org/D156624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156624: [clang-tidy] Access checks not done classes derived of std::array

sousajo updated this revision to Diff 553062. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156624/new/ https://reviews.llvm.org/D156624 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp clang-tools-extra/docs/ReleaseNotes.rst

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

danix800 added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/DynamicExtent.cpp:92 + + return ElementCount.castAs(); +} donat.nagy wrote: > Are you sure that this cannot cause crashes? (E.g. did you check that there > is no corner case when

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D158558#4613139 , @serge-sans-paille wrote: > I don't have a strong opinion on the synchronization with `TextNodeDumper`. > I'm

[PATCH] D158140: WIP: [clang-repl] Basic WebAssembly support for running inside a JS engine

argentite added a comment. Yes, I think that's the simplest solution. `__EMSCRIPTEN__` probably won't work because somebody may want to build for Emscripten without lld. `STATICALLY_LINKED_LLD` would probably be better. But I could not figure out how to do that in the build system.

[PATCH] D158695: [clang] Fix missing contract flag in sqrt intrinsic

arsenm added inline comments. Comment at: clang/test/CodeGen/fp-contract-fast-pragma.cpp:77 +// CHECK: _Z13fp_contract_7f +// CHECK: tail call contract float @llvm.sqrt.f32(float %a) + return __builtin_sqrtf(a); This isn't demonstrating the strict support,

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

steakhal added a comment. As a general comment on requiring all extents to be of unsigned APSInts. Checkers, like the `MallocChecker`, binds the result of arbitrary expression's values (the argument of malloc, for example) as extents of some regions. Usually, that argument is of an `unsigned`

[clang] 86258bd - [ORC][clang-repl] Fix another unit test after 122ebe3b500.

Author: Lang Hames Date: 2023-08-24T08:20:07-07:00 New Revision: 86258bda2016323d32efbe6a298654cd77cde644 URL: https://github.com/llvm/llvm-project/commit/86258bda2016323d32efbe6a298654cd77cde644 DIFF: https://github.com/llvm/llvm-project/commit/86258bda2016323d32efbe6a298654cd77cde644.diff

[clang-tools-extra] 109bc02 - [clangd] Add --query-driver flag to clangd-indexer

Author: Nathan Ridge Date: 2023-08-24T11:51:59-04:00 New Revision: 109bc024c8d741e57fa6bb5a028d8a4ed4e64a61 URL: https://github.com/llvm/llvm-project/commit/109bc024c8d741e57fa6bb5a028d8a4ed4e64a61 DIFF: https://github.com/llvm/llvm-project/commit/109bc024c8d741e57fa6bb5a028d8a4ed4e64a61.diff

[PATCH] D157990: [clangd] Add --query-driver flag to clangd-indexer

This revision was automatically updated to reflect the committed changes. Closed by commit rG109bc024c8d7: [clangd] Add --query-driver flag to clangd-indexer (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157990/new/

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

ABataev accepted this revision. ABataev added a comment. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152054/new/ https://reviews.llvm.org/D152054 ___ cfe-commits mailing list

[PATCH] D157990: [clangd] Add --query-driver flag to clangd-indexer

nridge added a comment. Committed, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157990/new/ https://reviews.llvm.org/D157990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] a173edc - [NFC][Clang][RISCV] Move test case to its corret belonging

Author: eopXD Date: 2023-08-24T09:02:12-07:00 New Revision: a173edc987454927b95d6adefc4c36ccad294c97 URL: https://github.com/llvm/llvm-project/commit/a173edc987454927b95d6adefc4c36ccad294c97 DIFF: https://github.com/llvm/llvm-project/commit/a173edc987454927b95d6adefc4c36ccad294c97.diff LOG:

[PATCH] D158730: [DebugMetadata][DwarfDebug] Don't retain local types with -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. Seems fine to me, but please triple check as the presubmit tests are failing. Perhaps you meant to mark this as a parent or child revision in phab with your other change, so that the presubmit builds know to apply both? See the box in the top right; Edit

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

DmitryPolukhin added a comment. @ldionne could you please upstream 9edb9a711503d540cf3126c0fde11ce9a0d9a7aa (I don't know what it is)? Alternatively I can figure out what to do with this test (it is just copies of the same

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana updated this revision to Diff 553003. iana added a comment. Try rebasing one more time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157757/new/ https://reviews.llvm.org/D157757 Files: clang/lib/Headers/stddef.h

[PATCH] D158601: [Clang] Always constant-evaluate operands of comparisons to nullptr

ChuanqiXu added a comment. In D158601#4612908 , @cor3ntin wrote: > @ChuanqiXu Thanks. Do you think this needs to be backported for coroutine > support? For coroutine support, I don't think it is needed. It is a pretty corner case and Tobias had

[PATCH] D157810: [clang][ExtractAPI] Create extractapi::RecordLocation

dang added a comment. LGTM Comment at: clang/include/clang/ExtractAPI/API.h:137 -/// DocComment is a vector of RawComment::CommentLine. +/// Slightly cut down version of PresumedLoc to suite the needs of +/// ExtractAPI. s/suite/suit CHANGES SINCE LAST

[PATCH] D158706: [Driver] Remove Myriad.cpp

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2958 default: return getTriple().getVendor() != llvm::Triple::Myriad; } You might as well remove this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158616: To allow RAV to visit initializer when bitfield and initializer both given

NoumanAmir657 added a comment. The pre-commit checks passed now when I built again. Looking into test for this now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158616/new/ https://reviews.llvm.org/D158616

[PATCH] D158671: [NFC][Clang] Fix static analyzer concerns

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:195 SymbolReference Context; -auto Record = dyn_cast(Decl->getDeclContext()); +auto Record =

[clang] 09ccc55 - Fix [-Werror,-Wsign-compare] error. NFC.

Author: Kai Luo Date: 2023-08-24T07:56:43Z New Revision: 09ccc5563ebe70be2b5a5421df43cd5720ba1f5b URL: https://github.com/llvm/llvm-project/commit/09ccc5563ebe70be2b5a5421df43cd5720ba1f5b DIFF: https://github.com/llvm/llvm-project/commit/09ccc5563ebe70be2b5a5421df43cd5720ba1f5b.diff LOG: Fix

[PATCH] D158715: [Driver] Cleanup last vestiges of Minix / Contiki support

brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Cleanup what is left after https://reviews.llvm.org/D158461 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158715

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

owenpan accepted this revision. owenpan added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:389 auto *ClosingLine = AnnotatedLines.begin() + ClosingLineIndex + 1; - auto OutdentBy =

[PATCH] D158671: [NFC][Clang] Fix static analyzer concerns

Fznamznon added inline comments. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:610-612 if (isa(Method)) { Name = Method->getNameAsString(); +if (cast(Method)->isExplicit()) Maybe we can just do this, so we don't `isa` two times.

[clang] 547bce3 - Revert "[clang-format] Break long string literals in C#, etc."

Author: David Spickett Date: 2023-08-24T08:15:17Z New Revision: 547bce36132ae0d92226599b6b8702051571461f URL: https://github.com/llvm/llvm-project/commit/547bce36132ae0d92226599b6b8702051571461f DIFF: https://github.com/llvm/llvm-project/commit/547bce36132ae0d92226599b6b8702051571461f.diff

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

DavidSpickett added a comment. This was causing failures on a large number of Linaro's bots. Judging by how widespread it was, reproducing could be as simple as adding `-DLLVM_ENABLE_ASSERTIONS=True` to your CMake config. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158571: [clang-format][NFC] Replace !is() with isNot()

owenpan updated this revision to Diff 553032. owenpan added a comment. Rebased to 825cec2 and ran `git-clang-format`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158571/new/ https://reviews.llvm.org/D158571

[clang] 91c4db0 - [clang-format][NFC] Replace !is() with isNot()

Author: Owen Pan Date: 2023-08-24T01:27:24-07:00 New Revision: 91c4db00612b205c6d0f56990b657c5646ad2a3b URL: https://github.com/llvm/llvm-project/commit/91c4db00612b205c6d0f56990b657c5646ad2a3b DIFF: https://github.com/llvm/llvm-project/commit/91c4db00612b205c6d0f56990b657c5646ad2a3b.diff

[PATCH] D158571: [clang-format][NFC] Replace !is() with isNot()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91c4db00612b: [clang-format][NFC] Replace !is() with isNot() (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

serge-sans-paille added a comment. I don't have a strong opinion on the synchronization with `TextNodeDumper`. I'm pretty sure I didn't update it while adding fields for the Attribute nodes though... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158601: [Clang] Always constant-evaluate operands of comparisons to nullptr

cor3ntin added a comment. Gotcha. Given there are other stuffs I need to backport, this will have to wait clang 18! I don't want to give undue work to tobias and testers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158601/new/

[PATCH] D158601: [Clang] Always constant-evaluate operands of comparisons to nullptr

cor3ntin updated this revision to Diff 553038. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158601/new/ https://reviews.llvm.org/D158601 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ExprConstant.cpp

[clang] 0e63f1a - [clang-format] Annotate constructor/destructor names

Author: Owen Pan Date: 2023-08-24T01:32:52-07:00 New Revision: 0e63f1aacc0040e9a16fa2fab15a140b1686e2ab URL: https://github.com/llvm/llvm-project/commit/0e63f1aacc0040e9a16fa2fab15a140b1686e2ab DIFF: https://github.com/llvm/llvm-project/commit/0e63f1aacc0040e9a16fa2fab15a140b1686e2ab.diff

  1   2   3   >