[clang-tools-extra] [clang-tidy]Add new check bugprone-casting-through-void (PR #69465)

2023-10-18 Thread Congcong Cai via cfe-commits
@@ -0,0 +1,50 @@ +//===--- CastingThroughVoidCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] 7aa2491 - [clang] Expand invalid PCM diagnostic (#69489)

2023-10-18 Thread via cfe-commits
Author: Nuri Amari Date: 2023-10-18T16:19:54-07:00 New Revision: 7aa24915cb66c51bab7c15854877136930d3ed17 URL: https://github.com/llvm/llvm-project/commit/7aa24915cb66c51bab7c15854877136930d3ed17 DIFF: https://github.com/llvm/llvm-project/commit/7aa24915cb66c51bab7c15854877136930d3ed17.diff

[clang] [clang] Expand invalid PCM diagnostic (PR #69489)

2023-10-18 Thread via cfe-commits
https://github.com/kyulee-com closed https://github.com/llvm/llvm-project/pull/69489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang]Avoid to check created local variable multiple time when evaluating (PR #69106)

2023-10-18 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: > I test example in branch llvmorg-16.0.6,ExprConstant.cpp also has this > assertion but it will not result in crash. Have you find the exact commit to break this case? @mzyKi https://github.com/llvm/llvm-project/pull/69106 ___

[clang] [CodeGen] -fsanitize=alignment: add cl::opt sanitize-alignment-builtin to disable memcpy instrumentation (PR #69240)

2023-10-18 Thread Fangrui Song via cfe-commits
@@ -66,6 +66,11 @@ using namespace clang; using namespace CodeGen; using namespace llvm; +static llvm::cl::opt ClSanitizeAlignmentBuiltin( +"sanitize-alignment-builtin", llvm::cl::Hidden, +llvm::cl::desc("Instrument builtin functions for -fsanitize=alignment"), +

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

2023-10-18 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > Does MSVC have the delayed template parsing effects when using modules? If > not, perhaps we should just disable the flag/not allow it to be composed > together? As far as I can reach, (from the issue reports in MSVC community), MSVC don't have problems with the delayed

[clang] [OpenMP 5.2] Deprecate syntax of map modifiers without comma separators (PR #69534)

2023-10-18 Thread Fazlay Rabbi via cfe-commits
https://github.com/mdfazlay created https://github.com/llvm/llvm-project/pull/69534 The syntax of modifiers without comma separators in the map clause was deprecated in OpenMP 5.2. Reference: OpenMP 5.2 Spec, page 627, line 19 >From 4b21bd09b1f1e3d5c68bd3e0c4701d7cb912631e Mon Sep 17

[clang] [OpenMP 5.2] Deprecate syntax of map modifiers without comma separators (PR #69534)

2023-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fazlay Rabbi (mdfazlay) Changes The syntax of modifiers without comma separators in the map clause was deprecated in OpenMP 5.2. Reference: OpenMP 5.2 Spec, page 627, line 19 --- Patch is 26.39 KiB, truncated to 20.00 KiB below, full

[clang] [RISCV][GISel] Add ISel supports for SHXADD from Zba extension (PR #67863)

2023-10-18 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave updated https://github.com/llvm/llvm-project/pull/67863 >From 08f77d6a53dadd4c136b92fcb60700fd7389eeb3 Mon Sep 17 00:00:00 2001 From: Min-Yih Hsu Date: Fri, 29 Sep 2023 15:17:43 -0700 Subject: [PATCH 1/8] [RISCV][GISel] Add ISel supports for SHXADD from Zba

[clang-tools-extra] [RISCV][GISel] Add ISel supports for SHXADD from Zba extension (PR #67863)

2023-10-18 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave updated https://github.com/llvm/llvm-project/pull/67863 >From 08f77d6a53dadd4c136b92fcb60700fd7389eeb3 Mon Sep 17 00:00:00 2001 From: Min-Yih Hsu Date: Fri, 29 Sep 2023 15:17:43 -0700 Subject: [PATCH 1/8] [RISCV][GISel] Add ISel supports for SHXADD from Zba

[clang] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

2023-10-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/68878 >From b93096929aa98e17dfdb0240a9285d315fc95bfc Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 12 Oct 2023 19:31:08 +0800 Subject: [PATCH 1/2] [clang]Transform uninstantiated ExceptionSpec in

[clang-tools-extra] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

2023-10-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/68878 >From b93096929aa98e17dfdb0240a9285d315fc95bfc Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 12 Oct 2023 19:31:08 +0800 Subject: [PATCH 1/2] [clang]Transform uninstantiated ExceptionSpec in

[clang] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

2023-10-18 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: friendly ping @erichkeane https://github.com/llvm/llvm-project/pull/68878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

2023-10-18 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: friendly ping @erichkeane https://github.com/llvm/llvm-project/pull/68878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Hook up Haiku PowerPC support (PR #69134)

2023-10-18 Thread Brad Smith via cfe-commits
brad0 wrote: > Ah, I meant potential changes to `llvm/lib/Target` and `llvm/lib/MC`. But I > did search in backend using FreeBSD as keyword for example, few places need > to support it explicitly. If Haiku uses similar ABI and binary format to > Linux or FreeBSD, that makes sense. Yes, Haiku

[clang] [CodeGen] -fsanitize=alignment: add cl::opt sanitize-alignment-builtin to disable memcpy instrumentation (PR #69240)

2023-10-18 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/69240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] -fsanitize=alignment: add cl::opt sanitize-alignment-builtin to disable memcpy instrumentation (PR #69240)

2023-10-18 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/69240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] -fsanitize=alignment: add cl::opt sanitize-alignment-builtin to disable memcpy instrumentation (PR #69240)

2023-10-18 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/69240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Refactor matchFunnelShift to allow more pattern (NFC) (PR #68474)

2023-10-18 Thread via cfe-commits
https://github.com/HaohaiWen closed https://github.com/llvm/llvm-project/pull/68474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Expand invalid PCM diagnostic (PR #69489)

2023-10-18 Thread David Blaikie via cfe-commits
https://github.com/dwblaikie approved this pull request. Looks good. I wonder how this happened in the first place - that the author of the diagnostic was already adding the 3rd parameter into the arguments but there was no `%2` in the diagnostic text/template... It'd be great if we had

[clang] [RISCV][GISel] Add ISel supports for SHXADD from Zba extension (PR #67863)

2023-10-18 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave updated https://github.com/llvm/llvm-project/pull/67863 >From 08f77d6a53dadd4c136b92fcb60700fd7389eeb3 Mon Sep 17 00:00:00 2001 From: Min-Yih Hsu Date: Fri, 29 Sep 2023 15:17:43 -0700 Subject: [PATCH 1/7] [RISCV][GISel] Add ISel supports for SHXADD from Zba

[clang-tools-extra] [RISCV][GISel] Add ISel supports for SHXADD from Zba extension (PR #67863)

2023-10-18 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave updated https://github.com/llvm/llvm-project/pull/67863 >From 08f77d6a53dadd4c136b92fcb60700fd7389eeb3 Mon Sep 17 00:00:00 2001 From: Min-Yih Hsu Date: Fri, 29 Sep 2023 15:17:43 -0700 Subject: [PATCH 1/7] [RISCV][GISel] Add ISel supports for SHXADD from Zba

[clang] [RISCV][GISel] Add ISel supports for SHXADD from Zba extension (PR #67863)

2023-10-18 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave closed https://github.com/llvm/llvm-project/pull/67863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tidy]Add new check bugprone-casting-through-void (PR #69465)

2023-10-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/69465 >From 627f68e57b2526fb72285ef4831fc3c02a6ee6d0 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Wed, 18 Oct 2023 08:47:02 +0800 Subject: [PATCH 1/7] [clang-tidy]Add new check bugprone-casting-through-void

[clang] cfbf0a5 - [X86][RFC] Support AVX10 options (#67278)

2023-10-18 Thread via cfe-commits
Author: Phoebe Wang Date: 2023-10-19T07:52:50+08:00 New Revision: cfbf0a500f173b532f64fcb856af2fb0cb7ba725 URL: https://github.com/llvm/llvm-project/commit/cfbf0a500f173b532f64fcb856af2fb0cb7ba725 DIFF: https://github.com/llvm/llvm-project/commit/cfbf0a500f173b532f64fcb856af2fb0cb7ba725.diff

[clang] [Sema] Add check for bitfield assignments to integral types (PR #69049)

2023-10-18 Thread via cfe-commits
vabridgers wrote: > LGTM! Btw, if you're just repairing tests like you had to do here, you > generally are okay to not go through another round of review unless you want > an extra set of eyes on things. The original approval is fine so long as > you're not making substantial changes to the

[clang] 2172eea - [clang-format][NFC] Take a constant conjunct out of a loop condition

2023-10-18 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-10-18T17:37:41-07:00 New Revision: 2172eeaa52bec211b255e9cb4d8464a8908ff709 URL: https://github.com/llvm/llvm-project/commit/2172eeaa52bec211b255e9cb4d8464a8908ff709 DIFF: https://github.com/llvm/llvm-project/commit/2172eeaa52bec211b255e9cb4d8464a8908ff709.diff

[clang] 0913a2d - [Driver][DragonFly] Fixes for linker path and command-line option handling (#69095)

2023-10-18 Thread via cfe-commits
Author: Brad Smith Date: 2023-10-18T20:47:04-04:00 New Revision: 0913a2d07d06b66780e4a1e4361f9159ce0013f8 URL: https://github.com/llvm/llvm-project/commit/0913a2d07d06b66780e4a1e4361f9159ce0013f8 DIFF: https://github.com/llvm/llvm-project/commit/0913a2d07d06b66780e4a1e4361f9159ce0013f8.diff

[clang] [Driver][DragonFly] Fixes for linker path and command-line option handling (PR #69095)

2023-10-18 Thread Brad Smith via cfe-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/69095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2023-10-18 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Herald added subscribers: pmatos, asb. Herald added a project: All. In D108905#2975712 , @rsmith wrote: > No decision as yet, but so far it looks very likely that we'll settle on the > rule that exceptions cannot have

[clang] [InstCombine] Convert or concat to fshl if opposite or concat exists (PR #68502)

2023-10-18 Thread via cfe-commits
https://github.com/HaohaiWen updated https://github.com/llvm/llvm-project/pull/68502 >From 5b3b1bbb5b263bc5711adde031d85b1461ccbab6 Mon Sep 17 00:00:00 2001 From: Haohai Wen Date: Sat, 7 Oct 2023 13:48:32 +0800 Subject: [PATCH 1/2] [InstCombine] Refactor matchFunnelShift to allow more pattern

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2023-10-18 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. In D108905#4654403 , @ChuanqiXu wrote: > In D108905#4654393 , @smeenai wrote: > >> In D108905#2975712 , @rsmith wrote: >> >>> No decision as yet,

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2023-10-18 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D108905#4654410 , @smeenai wrote: > In D108905#4654403 , @ChuanqiXu > wrote: > >> In D108905#4654393 , @smeenai >> wrote: >> >>> In

[clang] [clang]Avoid to check created local variable multiple time when evaluating (PR #69106)

2023-10-18 Thread via cfe-commits
mzyKi wrote: > > I test example in branch llvmorg-16.0.6,ExprConstant.cpp also has this > > assertion but it will not result in crash. > > Have you find the exact commit to break this case? @mzyKi @HerrCai0907 after this commit 610ec954e1f81c0e8fcadedcd25afe643f5a094e , clang will crash in

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2023-10-18 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D108905#4654411 , @MaskRay wrote: > In D108905#4654410 , @smeenai wrote: > >> In D108905#4654403 , @ChuanqiXu >> wrote: >> >>> In

[clang] [libc++] Fix inconsistency between is_lock_free and is_always_lock_free (PR #68109)

2023-10-18 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/68109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Fix inconsistency between is_lock_free and is_always_lock_free (PR #68109)

2023-10-18 Thread Louis Dionne via cfe-commits
ldionne wrote: The CI failure is the bootstrapping build agent dying, definitely not related to this. Shipping. https://github.com/llvm/llvm-project/pull/68109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [libc++] Fix inconsistency between is_lock_free and is_always_lock_free (PR #68109)

2023-10-18 Thread Louis Dionne via cfe-commits
ldionne wrote: The CI failure is the bootstrapping build agent dying, definitely not related to this. Shipping. https://github.com/llvm/llvm-project/pull/68109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [libc++] Fix inconsistency between is_lock_free and is_always_lock_free (PR #68109)

2023-10-18 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/68109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

2023-10-18 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 created https://github.com/llvm/llvm-project/pull/69555 Close https://github.com/llvm/llvm-project/issues/68615. It is generally wrong to include in the module purview. Although there are cases to include files in the module purview, generally these use cases

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-18 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta created https://github.com/llvm/llvm-project/pull/69557 This fixes https://github.com/llvm/llvm-project/issues/64916. Patch by Scott McPeak >From 96f6b90ed4a70430f94eab2d9ca317dd8367022a Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Thu, 19 Oct 2023 09:06:43

[clang] [InstCombine] Refactor matchFunnelShift to allow more pattern (NFC) (PR #68474)

2023-10-18 Thread via cfe-commits
goldsteinn wrote: Rebase you other patch then I can review. https://github.com/llvm/llvm-project/pull/68474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Refactor matchFunnelShift to allow more pattern (NFC) (PR #68474)

2023-10-18 Thread via cfe-commits
goldsteinn wrote: Rebase you other patch then I can review. https://github.com/llvm/llvm-project/pull/68474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang]Transform uninstantiated ExceptionSpec in TemplateInstantiator (PR #68878)

2023-10-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/68878 >From b93096929aa98e17dfdb0240a9285d315fc95bfc Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 12 Oct 2023 19:31:08 +0800 Subject: [PATCH 1/3] [clang]Transform uninstantiated ExceptionSpec in

[clang] [clang-scan-deps] [P1689] Keep consistent behavior for make dependencies with clang (PR #69551)

2023-10-18 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 created https://github.com/llvm/llvm-project/pull/69551 Close https://github.com/llvm/llvm-project/issues/69439. This patch tries to reuse the codes to generate make style dependencies information with P1689 format directly. >From

[clang] [clang-scan-deps] [P1689] Keep consistent behavior for make dependencies with clang (PR #69551)

2023-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Chuanqi Xu (ChuanqiXu9) Changes Close https://github.com/llvm/llvm-project/issues/69439. This patch tries to reuse the codes to generate make style dependencies information with P1689 format directly. --- Full diff:

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

2023-10-18 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D108905#4654393 , @smeenai wrote: > In D108905#2975712 , @rsmith wrote: > >> No decision as yet, but so far it looks very likely that we'll settle on the >> rule that exceptions

[clang-tools-extra] [clang][dataflow]Use cast_or_null instead of cast to prevent crash (PR #68510)

2023-10-18 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/68510 >From a5c5fc7a17f57a0b6ae328f7138435b4aaf7f9b5 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Sun, 8 Oct 2023 16:00:29 +0800 Subject: [PATCH] [clang][analysis]Use dyn_cast_or_null instead of cast to prevent crash

[clang-tools-extra] [clang][dataflow]Use cast_or_null instead of cast to prevent crash (PR #68510)

2023-10-18 Thread Qizhi Hu via cfe-commits
jcsxky wrote: > Thanks, looks good! > > You can submit as is, but if you're up for it, it would actually be better to > add the new test case directly to the model's unittests. Something like this > test (though just one case is enough -- please put it in a separate TEST_P): > >

[clang] [libc++] Add assertions for potential OOB reads in std::nth_element (PR #67023)

2023-10-18 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/67023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Add assertions for potential OOB reads in std::nth_element (PR #67023)

2023-10-18 Thread Louis Dionne via cfe-commits
ldionne wrote: Thanks! https://github.com/llvm/llvm-project/pull/67023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Add assertions for potential OOB reads in std::nth_element (PR #67023)

2023-10-18 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/67023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Add assertions for potential OOB reads in std::nth_element (PR #67023)

2023-10-18 Thread Louis Dionne via cfe-commits
ldionne wrote: Thanks! https://github.com/llvm/llvm-project/pull/67023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

2023-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Chuanqi Xu (ChuanqiXu9) Changes Close https://github.com/llvm/llvm-project/issues/68615. It is generally wrong to include filename in the module purview. Although there are cases to include files in the module purview, generally these

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

2023-10-18 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/69555 >From 86663a35a7af039f9440af2cc1896e8b4cf33310 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 19 Oct 2023 11:28:01 +0800 Subject: [PATCH] [C++20] [Modules] Warn if we found #include in module purview

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Shivam Gupta (xgupta) Changes This fixes https://github.com/llvm/llvm-project/issues/64916. Patch by Scott McPeak --- Full diff: https://github.com/llvm/llvm-project/pull/69557.diff 3 Files Affected: - (modified)

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-18 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/69557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-18 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b858309ddc977d5e70de54f3fa3888915b5fbc0c 96f6b90ed4a70430f94eab2d9ca317dd8367022a --

[clang] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to visit the initializer of a bitfield (PR #69557)

2023-10-18 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/69557 >From 96f6b90ed4a70430f94eab2d9ca317dd8367022a Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Thu, 19 Oct 2023 09:06:43 +0530 Subject: [PATCH 1/2] [RecursiveASTVisitor] Fix RecursiveASTVisitor (RAV) fails to

[clang] [RISCV] Convert all floating point vector type operands to integer vector type (PR #69559)

2023-10-18 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 817519058a986794e6acc06e4386fa183c4472a0 c61f6fb37e5d8ad0b7dfa68803f5a0161d542867 --

[clang] [SVE ACLE] Allow default zero initialisation for svcount_t. (PR #69321)

2023-10-18 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm approved this pull request. https://github.com/llvm/llvm-project/pull/69321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-10-18 Thread Michal Paszkowski via cfe-commits
@@ -0,0 +1,637 @@ +//===--- IRNormalizer.cpp - IR Canonicalizer ---===// michalpaszkowski wrote: Canonicalizer -> Normalizer https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits

[clang-tools-extra] [clangd] Disable crashy unchecked-optional-access tidy check (PR #69427)

2023-10-18 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet created https://github.com/llvm/llvm-project/pull/69427 Fixes https://github.com/llvm/llvm-project/issues/69369. From e19bf2e40b79b5f65de91d566e675b560620517e Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Wed, 18 Oct 2023 09:34:21 +0200 Subject: [PATCH]

[clang] [Clang][Sema] Skip RecordDecl when checking scope of declarations (PR #69432)

2023-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Qiu Chaofan (ecnelises) Changes In non C++ mode, struct definitions does not create a scope for declaration. Fixes #41302 Fixes #44080 --- Full diff: https://github.com/llvm/llvm-project/pull/69432.diff 3 Files Affected: -

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-18 Thread Owen Pan via cfe-commits
@@ -3191,20 +3191,146 @@ TEST_F(FormatTestComments, DontAlignNamespaceComments) { "}\n" "// Comment"; -#if 0 - // FIXME: The following comment is aligned with the namespace comment. verifyFormat("namespace A {\n" " int Foo;\n"

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-18 Thread Owen Pan via cfe-commits
@@ -1118,16 +1121,35 @@ void WhitespaceManager::alignTrailingComments() { } } -// We don't want to align namespace end comments. -const bool DontAlignThisComment = -I > 0 && C.NewlinesBefore == 0 && -Changes[I -

[PATCH] D157331: [clang] Implement C23

2023-10-18 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. This change broke building a recent version of gettext. Gettext uses gnulib for polyfilling various utility functions. Since not long ago, these functions internally use ``,

[libunwind] [libunwind] Fix running tests with MSan (PR #67860)

2023-10-18 Thread Fangrui Song via cfe-commits
@@ -43,6 +43,12 @@ #define LIBUNWIND_AVAIL #endif +#if defined(__SANITIZE_MEMORY__) || \ MaskRay wrote: `__SANITIZE_MEMORY__` is a macro defined by the Linux kernel and copied to other projects. We can drop it.

[clang-tools-extra] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-10-18 Thread Michal Paszkowski via cfe-commits
@@ -42,7 +42,10 @@ Non-comprehensive list of changes in this release functionality, or simply have a lot to talk about), see the `NOTE` below for adding a new subsection. -* ... +* Added a new IRNormalizer pass which aims to transform LLVM modules into + a canonical

[clang] [X86][RFC] Support AVX10 options (PR #67278)

2023-10-18 Thread Phoebe Wang via cfe-commits
@@ -130,17 +131,35 @@ bool X86TargetInfo::initFeatureMap( continue; } -if (!HasAVX512F && Feature.substr(0, 7) == "+avx512") +if (Feature.substr(0, 7) == "+avx10.") { + HasAVX10 = true; HasAVX512F = true; -if (HasAVX512F && Feature ==

[clang-tools-extra] [clangd] Disable crashy unchecked-optional-access tidy check (PR #69427)

2023-10-18 Thread Nathan Ridge via cfe-commits
@@ -219,6 +219,9 @@ TidyProvider disableUnusableChecks(llvm::ArrayRef ExtraBadChecks) { "-bugprone-use-after-move", // Alias for bugprone-use-after-move. "-hicpp-invalid-access-moved", + // Check uses dataflow analysis, which might hang/crash

[clang] [Clang][Sema] Skip RecordDecl when checking scope of declarations (PR #69432)

2023-10-18 Thread Qiu Chaofan via cfe-commits
https://github.com/ecnelises created https://github.com/llvm/llvm-project/pull/69432 In non C++ mode, struct definitions does not create a scope for declaration. Fixes #41302 Fixes #44080 >From 6828025e788347f21a41d4a9aa138af032017b80 Mon Sep 17 00:00:00 2001 From: Qiu Chaofan Date: Wed,

[clang] [Clang][Sema] Skip RecordDecl when checking scope of declarations (PR #69432)

2023-10-18 Thread Qiu Chaofan via cfe-commits
https://github.com/ecnelises updated https://github.com/llvm/llvm-project/pull/69432 >From f97807afc177ab04c97d0c346081fc92d3e79e6c Mon Sep 17 00:00:00 2001 From: Qiu Chaofan Date: Wed, 18 Oct 2023 16:02:02 +0800 Subject: [PATCH] [Clang][Sema] Skip RecordDecl when checking scope of

[PATCH] D151199: [Clang][SVE2.1] Add pfalse builtin

2023-10-18 Thread Caroline via Phabricator via cfe-commits
CarolineConcatto updated this revision to Diff 557746. CarolineConcatto added a comment. -Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151199/new/ https://reviews.llvm.org/D151199 Files: clang/include/clang/Basic/arm_sve.td

[clang] [ARM] fix "+fp.dp" in multilib selection (PR #67412)

2023-10-18 Thread Dominik Wójt via cfe-commits
https://github.com/domin144 updated https://github.com/llvm/llvm-project/pull/67412 From e20234c6a73a2dded9e5a34e2900e7757ac9460f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominik=20W=C3=B3jt?= Date: Wed, 20 Sep 2023 16:39:27 +0200 Subject: [PATCH 1/2] [ARM] fix "+fp.dp" in multilib selection

[clang-tools-extra] [clangd] Disable crashy unchecked-optional-access tidy check (PR #69427)

2023-10-18 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet edited https://github.com/llvm/llvm-project/pull/69427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Disable crashy unchecked-optional-access tidy check (PR #69427)

2023-10-18 Thread kadir çetinkaya via cfe-commits
@@ -219,6 +219,9 @@ TidyProvider disableUnusableChecks(llvm::ArrayRef ExtraBadChecks) { "-bugprone-use-after-move", // Alias for bugprone-use-after-move. "-hicpp-invalid-access-moved", + // Check uses dataflow analysis, which might hang/crash

[clang] [clang] [unittest] Add a test for Generic_GCC::GCCVersion::Parse (PR #69078)

2023-10-18 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo updated https://github.com/llvm/llvm-project/pull/69078 From 1aac071988f66ccab67c7a6179841bb272b5684a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Sat, 14 Oct 2023 00:06:05 +0300 Subject: [PATCH] [clang] [unittest] Add a test for

[PATCH] D151307: [Clang][SVE2.1] Add svwhile (predicate-as-counter) builtins

2023-10-18 Thread Caroline via Phabricator via cfe-commits
CarolineConcatto updated this revision to Diff 557747. CarolineConcatto added a comment. -Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151307/new/ https://reviews.llvm.org/D151307 Files: clang/include/clang/Basic/arm_sve.td

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-18 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/69249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-18 Thread via cfe-commits
mydeveloperday wrote: Phyllis https://github.com/llvm/llvm-project/pull/69249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86][RFC] Support AVX10 options (PR #67278)

2023-10-18 Thread Phoebe Wang via cfe-commits
@@ -130,17 +131,35 @@ bool X86TargetInfo::initFeatureMap( continue; } -if (!HasAVX512F && Feature.substr(0, 7) == "+avx512") +if (Feature.substr(0, 7) == "+avx10.") { + HasAVX10 = true; HasAVX512F = true; -if (HasAVX512F && Feature ==

[clang] clang/OpenCL: set sqrt fp accuracy on call to Z4sqrt (PR #66651)

2023-10-18 Thread Romaric Jodin via cfe-commits
rjodinchr wrote: @arsenm could you have another look at this PR? Thank you https://github.com/llvm/llvm-project/pull/66651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-10-18 Thread Michal Paszkowski via cfe-commits
@@ -0,0 +1,637 @@ +//===--- IRNormalizer.cpp - IR Canonicalizer ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-18 Thread Jerin Philip via cfe-commits
https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 48a5350 - [clang][USR] Encode full decl-context also for anon namespaces (#68325)

2023-10-18 Thread via cfe-commits
Author: kadir çetinkaya Date: 2023-10-18T10:51:31+02:00 New Revision: 48a53509e851c93f352c967da1feb1c8fb2abd9a URL: https://github.com/llvm/llvm-project/commit/48a53509e851c93f352c967da1feb1c8fb2abd9a DIFF:

[clang] [clang][USR] Encode full decl-context also for anon namespaces (PR #68325)

2023-10-18 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet closed https://github.com/llvm/llvm-project/pull/68325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

2023-10-18 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 557745. nridge added a comment. Implement optimization to filter the refs stored in RevRefs to calls only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93829/new/ https://reviews.llvm.org/D93829 Files:

[clang] [X86][RFC] Support AVX10 options (PR #67278)

2023-10-18 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/67278 >From eaf36c8cac3fe6d9bb3dcb1387b0b4f1febf5ef7 Mon Sep 17 00:00:00 2001 From: Phoebe Wang Date: Mon, 25 Sep 2023 10:31:37 +0800 Subject: [PATCH 1/2] [X86][RFC] Support AVX10 options AVX10 Architecture

[libunwind] [X86][RFC] Support AVX10 options (PR #67278)

2023-10-18 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/67278 >From eaf36c8cac3fe6d9bb3dcb1387b0b4f1febf5ef7 Mon Sep 17 00:00:00 2001 From: Phoebe Wang Date: Mon, 25 Sep 2023 10:31:37 +0800 Subject: [PATCH 1/2] [X86][RFC] Support AVX10 options AVX10 Architecture

[clang-tools-extra] [X86][RFC] Support AVX10 options (PR #67278)

2023-10-18 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/67278 >From eaf36c8cac3fe6d9bb3dcb1387b0b4f1febf5ef7 Mon Sep 17 00:00:00 2001 From: Phoebe Wang Date: Mon, 25 Sep 2023 10:31:37 +0800 Subject: [PATCH 1/2] [X86][RFC] Support AVX10 options AVX10 Architecture

[clang] [AMDGPU] Remove Code Object V3 (PR #67118)

2023-10-18 Thread Tobias Burnus via cfe-commits
tob2 wrote: > V3 has been deprecated for a while as well, so it can safely be removed We are using v3 for (better) backward compatibility with the older gfx803 / fiji cards (GCN GFX8 (Volcanic Islands (VI))) — thus, this commit on Monday broke our tester for gfx803 / fiji cards :-( However,

[clang] fix usr rhs (PR #68329)

2023-10-18 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet updated https://github.com/llvm/llvm-project/pull/68329 From 80fa52f6efa36e04bf87c525013513d4429788ae Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Thu, 5 Oct 2023 18:05:11 +0200 Subject: [PATCH] [clang][Index] Improve USR generation for using-decls Make

[clang-tools-extra] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-10-18 Thread Michal Paszkowski via cfe-commits
@@ -543,6 +543,15 @@ variables with initializers are marked as internal. An interprocedural variant of :ref:`Sparse Conditional Constant Propagation `. +``ir-normalizer``: Transforms IR into a canonical form that's easier to diff

[clang] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-10-18 Thread Michal Paszkowski via cfe-commits
michalpaszkowski wrote: I added a couple more comments regarding the name change and formatting of the docs, but apart from these the patch looks good to me. https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list

[clang-tools-extra] [clangd] Disable crashy unchecked-optional-access tidy check (PR #69427)

2023-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: kadir çetinkaya (kadircet) Changes Fixes https://github.com/llvm/llvm-project/issues/69369. --- Full diff: https://github.com/llvm/llvm-project/pull/69427.diff 1 Files Affected: - (modified) clang-tools-extra/clangd/TidyProvider.cpp

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

2023-10-18 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 created https://github.com/llvm/llvm-project/pull/69431 There are already 3 issues about the broken state of -fdelayed-template-parsing and C++20 modules: - https://github.com/llvm/llvm-project/issues/61068 - https://github.com/llvm/llvm-project/issues/64810 -

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

2023-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Chuanqi Xu (ChuanqiXu9) Changes There are already 3 issues about the broken state of -fdelayed-template-parsing and C++20 modules: - https://github.com/llvm/llvm-project/issues/61068 -

[clang] [clang] [unittest] Add a test for Generic_GCC::GCCVersion::Parse (PR #69078)

2023-10-18 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: Thanks, I applied the suggested changes - will push in a little while. https://github.com/llvm/llvm-project/pull/69078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-10-18 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?=

  1   2   3   4   >