Re: [PATCH] D12921: clang-format: Support 'template<>' (no space).

djasper added a comment. This has come up before and the decision was that this is not important enough to meet the bar for an additional clang-format option. clang-format options have a certain cost and this specific space is so entirely unimportant that we don't want to pay it. We have

Re: [PATCH] D12832: [Driver] Add support for Windows 10 SDK

ikudrin marked 2 inline comments as done. ikudrin added a comment. http://reviews.llvm.org/D12832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12921: clang-format: Support 'template<>' (no space).

MyDeveloperDay added a subscriber: MyDeveloperDay. MyDeveloperDay added a comment. This looks like a good small change. What is interesting to me is that even the twiki page about template is inconsistent in its style (https://en.wikipedia.org/wiki/Template_(C%2B%2B)), so its not like there is

Re: [PATCH] D12832: [Driver] Added support for Windows 10 SDK

ikudrin updated this revision to Diff 34965. ikudrin added a comment. - reworked the conditional statement - formatting http://reviews.llvm.org/D12832 Files: cfe/trunk/lib/Driver/MSVCToolChain.cpp cfe/trunk/lib/Driver/ToolChains.h Index: cfe/trunk/lib/Driver/ToolChains.h

Re: [PATCH] D12774: createUniqueFile() is documented to create the file in the temporary directory unless it's supplied an absolute path.Make sure the output filepath supplied to createUniqueFile() in

vsk added a subscriber: vsk. vsk added a comment. Could you handle the error code coming out of make_absolute? It looks like it calls current_path(), which can fail in interesting ways. http://reviews.llvm.org/D12774 ___ cfe-commits mailing list

[PATCH] D12927: Using MD_invariant_group

Prazek created this revision. Prazek added reviewers: rsmith, nlewycky, majnemer. Prazek added a subscriber: cfe-commits. Using changes from http://reviews.llvm.org/D12926 http://reviews.llvm.org/D12927 Files: lib/CodeGen/CodeGenModule.cpp Index: lib/CodeGen/CodeGenModule.cpp

Re: [PATCH] D12921: clang-format: Support 'template<>' (no space).

MyDeveloperDay added a comment. Oh and we might want to run clang-format by the guys at http://cppreference.com seems they don't like the space either! just saying http://reviews.llvm.org/D12921 ___ cfe-commits mailing list

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054 @@ +3043,13 @@ + + if (auto *VAT = dyn_cast(ElementType.getTypePtr())) { +auto VATInfo = CGF.getVLASize(VAT); +Size = llvm::ConstantInt::get( +CGM.SizeTy, +

Re: [PATCH] D12921: clang-format: Support 'template<>' (no space).

The most important costs are: Maintenance and discoverability of options. The point here that it this space is utterly irrelevant, it doesn't make a readability difference ever. Most codebases are inconsistent about it anyway and I haven't seen a style guide even talking about this. We never

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

djasper added inline comments. Comment at: docs/ClangFormatStyleOptions.rst:221-235 @@ -220,3 +220,17 @@ -**AlwaysBreakAfterDefinitionReturnType** (``DefinitionReturnTypeBreakingStyle``) +**AlwaysBreakAfterDeclarationReturnType** (``ReturnTypeBreakingStyle``) + The function

Re: [PATCH] D12492: [Clang-Format] Add AlwaysBreakBeforeElse and AlwaysBreakBeforeCatch Style to avoid cuddled else/catch

djasper added a comment. Please upload a patch with full file context. Comment at: docs/ClangFormatStyleOptions.rst:247 @@ -246,1 +246,3 @@ +**AlwaysBreakBeforeElse** (``bool``) + If ``true``, always break before ``else``. Hm, I think these should be grouped

Re: [PATCH] D12492: [Clang-Format] Add AlwaysBreakBeforeElse and AlwaysBreakBeforeCatch Style to avoid cuddled else/catch

MyDeveloperDay updated this revision to Diff 34971. MyDeveloperDay added a comment. full file diff http://reviews.llvm.org/D12492 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/UnwrappedLineParser.cpp tools/CMakeLists.txt

Re: [PATCH] D12492: [Clang-Format] Add AlwaysBreakBeforeElse and AlwaysBreakBeforeCatch Style to avoid cuddled else/catch

djasper added a subscriber: djasper. djasper added a comment. The question is how all the other options should be called and how we can group them nicely so that we don't flood the options configuration page too much. Maybe it's time for nesting in the configuration class?

Re: [PATCH] D12492: [Clang-Format] Add AlwaysBreakBeforeElse and AlwaysBreakBeforeCatch Style to avoid cuddled else/catch

The question is how all the other options should be called and how we can group them nicely so that we don't flood the options configuration page too much. Maybe it's time for nesting in the configuration class? On Sep 17, 2015 11:50 AM, "Paul Hoad" wrote: >

Re: [PATCH] D12921: clang-format: Support 'template<>' (no space).

MyDeveloperDay added a comment. > The point here that it this space is utterly irrelevant So I totally take the point but if it doesn't matter then why does clang-format automatically add one to my "template<>" why not simply leave it alone? > We never intended clang-format to provide control

r247881 - [X86][AVX512DQ] add new intrinsics

Author: abadouh Date: Thu Sep 17 06:56:04 2015 New Revision: 247881 URL: http://llvm.org/viewvc/llvm-project?rev=247881=rev Log: [X86][AVX512DQ] add new intrinsics convert i64 to FP and vice versa reduceps & reducepd rangeps & rangepd all in their 512bit versions Differential Revision:

Re: [PATCH] D12903: Allow the -load option in the driver and pass it through to -cc1

rengolin added a comment. Hi John, Looks all right to me, but I don't want to approve without someone more familiar with the -load option to agree that this is not an exclusively internal option. Other than that, I'm happy with it. cheers, --renato Repository: rL LLVM

Re: [PATCH] D12903: Allow the -load option in the driver and pass it through to -cc1

john.brawn updated this revision to Diff 34977. john.brawn added a comment. Add a test. Repository: rL LLVM http://reviews.llvm.org/D12903 Files: include/clang/Driver/CC1Options.td include/clang/Driver/Options.td lib/Driver/Tools.cpp test/Driver/load.c Index: test/Driver/load.c

Re: [PATCH] D12571: [Analyzer] Fix assertions in commit r246345 (pr22954).

pgousseau added a comment. Ping ! http://reviews.llvm.org/D12571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12492: [Clang-Format] Add AlwaysBreakBeforeElse and AlwaysBreakBeforeCatch Style to avoid cuddled else/catch

MyDeveloperDay added inline comments. Comment at: docs/ClangFormatStyleOptions.rst:247 @@ -246,1 +246,3 @@ +**AlwaysBreakBeforeElse** (``bool``) + If ``true``, always break before ``else``. djasper wrote: > Hm, I think these should be grouped in some way and

Re: [PATCH] D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors

eastig updated this revision to Diff 34973. eastig added a comment. Added tests http://reviews.llvm.org/D12689 Files: include/ios src/iostream.cpp test/std/input.output/iostream.objects/narrow.stream.objects/cerr_init.pass.cpp

r247882 - Appease clang/test/CodeGen/avx512dq-builtins.c for -Asserts, for now.

Author: chapuni Date: Thu Sep 17 07:33:34 2015 New Revision: 247882 URL: http://llvm.org/viewvc/llvm-project?rev=247882=rev Log: Appease clang/test/CodeGen/avx512dq-builtins.c for -Asserts, for now. Modified: cfe/trunk/test/CodeGen/avx512dq-builtins.c Modified:

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

richard.barton.arm added a comment. Hi all I am uncomfortable with this patch for a number of reasons. These macros seem to me to be defined by the ACLE as describing the behaviour of the combination of library and compiler. For example, the __STDC_IEC_599__ macro would need some standards

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste marked 9 inline comments as done. Alexander_Droste added a comment. Thanks for the review! Comment at: tools/clang/lib/StaticAnalyzer/Checkers/Checkers.td:524 @@ +523,3 @@ +def MPIChecker : Checker<"MPI-Checker">, + HelpText<"Checks MPI code written in C">, +

r247892 - re-apply r.247881

Author: abadouh Date: Thu Sep 17 09:53:37 2015 New Revision: 247892 URL: http://llvm.org/viewvc/llvm-project?rev=247892=rev Log: re-apply r.247881 fixed the tests. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def cfe/trunk/lib/Headers/avx512dqintrin.h

Re: [PATCH] D12489: [clang-format] Fixed missing space between Obj-C for/in and a typecast

ksuther added a comment. Adding another comment in hopes of getting some visibility on this. Do I need to add other people as reviewers? http://reviews.llvm.org/D12489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12922: Add support for function attribute "notail"

I wonder if 'notailcall' be better, since it contains a verb (like 'noinline'). I don't have a strong opinion; just putting the alternative out there. > On 2015-Sep-16, at 19:21, Akira Hatanaka via cfe-commits > wrote: > > ahatanak created this revision. >

Re: [PATCH] D12922: Add support for function attribute "notail"

dexonsmith added a subscriber: dexonsmith. dexonsmith added a comment. I wonder if 'notailcall' be better, since it contains a verb (like 'noinline'). I don't have a strong opinion; just putting the alternative out there. http://reviews.llvm.org/D12922

Re: [PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. Other than minor comments, lgtm. Comment at: lib/Driver/ToolChains.cpp:3937 @@ +3936,3 @@ + default: +llvm_unreachable("Unsupported architecture"); + case

Re: [PATCH] D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key

djasper added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:377 @@ -376,1 +376,3 @@ +(!Contexts.back().ColonIsDictLiteral || + Style.Language != FormatStyle::LK_Cpp)) || Style.Language == FormatStyle::LK_Proto) &&

Re: [PATCH] D12832: [Driver] Add support for Windows 10 SDK

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks like I forgot to submit the comments I wrote. Anyway, looks good. Comment at: cfe/trunk/lib/Driver/MSVCToolChain.cpp:238 @@ +237,3 @@ + continue; +const StringRef

[PATCH] D12938: [ARM] Handle +t2dsp feature as an ArchExtKind in ARMTargetParser.def

tyomitch created this revision. tyomitch added reviewers: labrinea, rengolin. tyomitch added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. Currently, the availability of DSP instructions (ACLE 6.4.7) is handled in a hand-rolled tricky condition block in

Re: [PATCH] D12903: Allow the -load option in the driver and pass it through to -cc1

compnerd added a subscriber: compnerd. compnerd added a comment. While I agree that this makes the option much nicer to use, it collides with the -l flag. Since it was an internal only option until this point, we should rename it before exposing it at the driver level. Repository: rL LLVM

Re: [PATCH] D12903: Allow the -load option in the driver and pass it through to -cc1

john.brawn added a comment. In http://reviews.llvm.org/D12903#247934, @compnerd wrote: > While I agree that this makes the option much nicer to use, it collides with > the -l flag. Since it was an internal only option until this point, we > should rename it before exposing it at the driver

Re: [PATCH] D12832: [Driver] Add support for Windows 10 SDK

ikudrin added a comment. I found a new problem, after install WDK. I'll submit a new version in a moment. http://reviews.llvm.org/D12832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r247895 - Fix a typo.

Author: adrian Date: Thu Sep 17 10:58:54 2015 New Revision: 247895 URL: http://llvm.org/viewvc/llvm-project?rev=247895=rev Log: Fix a typo. Modified: cfe/trunk/docs/Modules.rst Modified: cfe/trunk/docs/Modules.rst URL:

r247887 - Update the 3.8 release notes with the breaking change information regarding AST matchers.

Author: aaronballman Date: Thu Sep 17 08:47:22 2015 New Revision: 247887 URL: http://llvm.org/viewvc/llvm-project?rev=247887=rev Log: Update the 3.8 release notes with the breaking change information regarding AST matchers. Modified: cfe/trunk/docs/ReleaseNotes.rst Modified:

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

This revision was automatically updated to reflect the committed changes. Closed by commit rL247890: [clang-tidy] install helper scripts (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D12700?vs=34953=34997#toc Repository: rL LLVM http://reviews.llvm.org/D12700

Re: [PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

dougk updated this revision to Diff 34998. dougk marked 3 inline comments as done. dougk added a comment. Use the same logic as Solaris::Solaris to die in the toolchain constructor if getArch() is unexpected. Also don't hardcode -EL in linker. http://reviews.llvm.org/D12541 Files:

Re: [PATCH] D12904: fix for assertion fail for pragma weak on typedef

amusman updated this revision to Diff 34987. amusman added a comment. Hi Aaron, Thank you for review. I've updated the warning for such cases. Regards, Alexander http://reviews.llvm.org/D12904 Files: lib/Sema/Sema.cpp lib/Sema/SemaDecl.cpp test/CodeGen/pragma-weak.c Index:

Re: [PATCH] D12921: clang-format: Support 'template<>' (no space).

On Thu, Sep 17, 2015 at 12:17 PM, Paul Hoad wrote: > MyDeveloperDay added a comment. > > > The point here that it this space is utterly irrelevant > > > So I totally take the point but if it doesn't matter then why does > clang-format automatically add one to my

Re: [PATCH] D12917: [CUDA] Allow parsing of host and device code simultaneously.

jpienaar added a comment. Nice, so this will allow parsing/AST construction with builtins from 2 architectures but will fail to compile if a builtin for the host/device is called from device/host. You mention this is not generally possible. Can you give some examples?

[PATCH] D12933: Add a test to modernize-loop-convert.

angelgarcia created this revision. angelgarcia added a reviewer: alexfh. angelgarcia added subscribers: klimek, cfe-commits. Add the test about replacements in several arguments of the same macro call, now that the problem has been fixed. http://reviews.llvm.org/D12933 Files:

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

alexfh added a comment. LG. Thanks! Repository: rL LLVM http://reviews.llvm.org/D12700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12797: Refactor LoopConvertCheck.

angelgarcia updated this revision to Diff 34985. angelgarcia added a comment. Split a function and several other small changes. http://reviews.llvm.org/D12797 Files: clang-tidy/modernize/LoopConvertCheck.cpp clang-tidy/modernize/LoopConvertCheck.h

[clang-tools-extra] r247886 - Refactors AST matching code to use the new AST matcher names. This patch correlates to r247885 which performs the AST matcher rename in Clang.

Author: aaronballman Date: Thu Sep 17 08:31:25 2015 New Revision: 247886 URL: http://llvm.org/viewvc/llvm-project?rev=247886=rev Log: Refactors AST matching code to use the new AST matcher names. This patch correlates to r247885 which performs the AST matcher rename in Clang. Modified:

Re: [cfe-commits] r171885 - in /cfe/trunk/www/analyzer: annotations.html available_checks.html dev_cxx.html index.html xcode.html

Sorry to resurrect an ancient commit, but... On Tue, Jan 8, 2013 at 2:29 PM, Jordan Rose wrote: > Author: jrose > Date: Tue Jan 8 13:29:37 2013 > New Revision: 171885 > > URL: http://llvm.org/viewvc/llvm-project?rev=171885=rev > Log: > Various tweaks and updates to the

[clang-tools-extra] r247889 - Add a test to modernize-loop-convert.

Author: angelgarcia Date: Thu Sep 17 09:25:39 2015 New Revision: 247889 URL: http://llvm.org/viewvc/llvm-project?rev=247889=rev Log: Add a test to modernize-loop-convert. Summary: Add the test about replacements in several arguments of the same macro call, now that the problem has been fixed.

Re: [PATCH] D12933: Add a test to modernize-loop-convert.

angelgarcia updated this revision to Diff 34993. angelgarcia added a comment. Done. http://reviews.llvm.org/D12933 Files: test/clang-tidy/modernize-loop-convert-extra.cpp Index: test/clang-tidy/modernize-loop-convert-extra.cpp

Re: [PATCH] D12904: fix for assertion fail for pragma weak on typedef

aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with one minor nit. Comment at: lib/Sema/Sema.cpp:729 @@ +728,3 @@ + Diag(WeakID.second.getLocation(),

Re: [PATCH] D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key

ksuther added a comment. Adding another comment in hopes of getting some visibility on this. Do I need to add other people as reviewers? http://reviews.llvm.org/D12501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

RE: r247882 - Appease clang/test/CodeGen/avx512dq-builtins.c for -Asserts, for now.

I’m working on revert the patch and fix it. Will take a moment. From: NAKAMURA Takumi [mailto:geek4ci...@gmail.com] Sent: Thursday, September 17, 2015 16:04 To: cfe-commits@lists.llvm.org Cc: Badouh, Asaf Subject: Re: r247882 - Appease clang/test/CodeGen/avx512dq-builtins.c for -Asserts, for

Re: [PATCH] D12933: Add a test to modernize-loop-convert.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a comment. Comment at: test/clang-tidy/modernize-loop-convert-extra.cpp:705 @@ -704,16 +704,3 @@ - // FIXME: Right now, clang-tidy does not allow to make

Re: [PATCH] D12797: Refactor LoopConvertCheck.

angelgarcia marked 9 inline comments as done. Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:494-495 @@ -493,4 +502,2 @@ } else { - if (Descriptor.DerefByConstRef) -AutoRefType = Context->getConstType(AutoRefType); AutoRefType =

Re: [PATCH] D12917: [CUDA] Allow parsing of host and device code simultaneously.

tra updated this revision to Diff 35015. tra marked an inline comment as done. tra added a comment. cosmetic fixes. http://reviews.llvm.org/D12917 Files: include/clang/AST/ASTContext.h include/clang/Basic/Builtins.h include/clang/Driver/CC1Options.td

Re: [PATCH] D11693: clang-format: Support generalized lambda captures.

djasper added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:1060-1061 @@ +1059,4 @@ + nextToken(); + while (!eof()) { +// FIXME: Once we have an expression parser in the UnwrappedLineParser, +// replace this by using

r247900 - createOutputFile should set Error to something if it returns null.

Author: dougk Date: Thu Sep 17 11:45:12 2015 New Revision: 247900 URL: http://llvm.org/viewvc/llvm-project?rev=247900=rev Log: createOutputFile should set Error to something if it returns null. This is not portably unit-testable because the only visible effect is a change from one random message

Re: [PATCH] D12917: [CUDA] Allow parsing of host and device code simultaneously.

tra marked an inline comment as done. tra added a comment. In http://reviews.llvm.org/D12917#247868, @jpienaar wrote: > Nice, so this will allow parsing/AST construction with builtins from 2 > architectures but will fail to compile if a builtin for the host/device is > called from device/host.

r247902 - Use the MSVC SEH personalities on Mingw

Author: rnk Date: Thu Sep 17 12:04:13 2015 New Revision: 247902 URL: http://llvm.org/viewvc/llvm-project?rev=247902=rev Log: Use the MSVC SEH personalities on Mingw Mingw generally wraps an old copy of msvcrt.dll which has these personalities, so things should work out, or so I hear. I haven't

r247912 - [CMake] Add install-clang target to install just the clang executable

Author: cbieneman Date: Thu Sep 17 13:30:20 2015 New Revision: 247912 URL: http://llvm.org/viewvc/llvm-project?rev=247912=rev Log: [CMake] Add install-clang target to install just the clang executable For the llvm-tools we're generating install-${tool} targets which are very useful. We should

Re: [PATCH] D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key

ksuther added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:377 @@ -376,1 +376,3 @@ +(!Contexts.back().ColonIsDictLiteral || + Style.Language != FormatStyle::LK_Cpp)) || Style.Language == FormatStyle::LK_Proto) &&

Re: [PATCH] D12832: [Driver] Add support for Windows 10 SDK

ikudrin marked an inline comment as done. ikudrin added a comment. http://reviews.llvm.org/D12832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12832: [Driver] Add support for Windows 10 SDK

ikudrin updated this revision to Diff 35013. ikudrin added a comment. Skip directories like C:\Program Files (x86)\Windows Kits\10\Include\wdf, which come from WDK installation, when looking for SDK version. Now, we detect directories even better than vsvars32.bat in that situation.

Re: [PATCH] D11693: clang-format: Support generalized lambda captures.

strager marked 2 inline comments as done. Comment at: lib/Format/UnwrappedLineParser.cpp:1060-1061 @@ +1059,4 @@ + nextToken(); + while (!eof()) { +// FIXME: Once we have an expression parser in the UnwrappedLineParser, +// replace this by using

r247926 - [Shave]: Rename test file from 'shave-' to 'myriad-'

Author: dougk Date: Thu Sep 17 15:00:09 2015 New Revision: 247926 URL: http://llvm.org/viewvc/llvm-project?rev=247926=rev Log: [Shave]: Rename test file from 'shave-' to 'myriad-' Added: cfe/trunk/test/Driver/myriad-toolchain.c - copied, changed from r247924,

Re: [PATCH] D12917: [CUDA] Allow parsing of host and device code simultaneously.

tra marked 2 inline comments as done. Comment at: lib/Frontend/CompilerInstance.cpp:82-87 @@ -84,6 +81,8 @@ +void CompilerInstance::setTarget(TargetInfo *Value) { Target = Value; } +void CompilerInstance::setAuxTarget(TargetInfo *Value) { AuxTarget = Value; } void

Re: [PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

This revision was automatically updated to reflect the committed changes. dougk marked 2 inline comments as done. Closed by commit rL247924: [Shave]: Drive sparc-myriad-elf-ld directly rather than via gcc. (authored by dougk). Changed prior to commit:

r247924 - [Shave]: Drive sparc-myriad-elf-ld directly rather than via gcc.

Author: dougk Date: Thu Sep 17 14:56:40 2015 New Revision: 247924 URL: http://llvm.org/viewvc/llvm-project?rev=247924=rev Log: [Shave]: Drive sparc-myriad-elf-ld directly rather than via gcc. Differential Revision: http://reviews.llvm.org/D12541 Added:

Re: [PATCH] D12927: Using MD_invariant_group

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D12927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12916: [Static Analyzer] Use generics related information to infer dynamic types.

xazax.hun marked an inline comment as done. Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:871 @@ +870,3 @@ + if (RetRegion && !State->get(RetRegion)) { +// TODO: we have duplicated information in DynamicTypeMap and +// MostSpecializedTypeArgsMap. We

Re: r247932 - Try to unbreak windows compiler after r247926.

On Thu, Sep 17, 2015 at 1:25 PM, Douglas Katzman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dougk > Date: Thu Sep 17 15:25:09 2015 > New Revision: 247932 > > URL: http://llvm.org/viewvc/llvm-project?rev=247932=rev > Log: > Try to unbreak windows compiler after r247926. > > It

Re: [PATCH] D1623: Support __builtin_ms_va_list.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I think this is ready. http://reviews.llvm.org/D1623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12917: [CUDA] Allow parsing of host and device code simultaneously.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Works for me. Thanks! -eric http://reviews.llvm.org/D12917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12921: clang-format: Support 'template<>' (no space).

Lets says this: I am not happy about it and wouldn't allow it if it was added now. However, *removing* it actually has additional costs, so I am not inclined to do so now. On Thu, Sep 17, 2015 at 9:52 PM, strager wrote: > strager added a comment. > > Should we remove

r247930 - Fixed the comment to match reality.

Author: tra Date: Thu Sep 17 15:19:33 2015 New Revision: 247930 URL: http://llvm.org/viewvc/llvm-project?rev=247930=rev Log: Fixed the comment to match reality. Modified: cfe/trunk/include/clang/Frontend/CompilerInstance.h Modified: cfe/trunk/include/clang/Frontend/CompilerInstance.h URL:

r247933 - Using MD_invariant_group

Author: prazek Date: Thu Sep 17 15:25:46 2015 New Revision: 247933 URL: http://llvm.org/viewvc/llvm-project?rev=247933=rev Log: Using MD_invariant_group http://reviews.llvm.org/D12927 Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp URL:

Re: [PATCH] D12917: [CUDA] Allow parsing of host and device code simultaneously.

tra updated this revision to Diff 35031. tra marked an inline comment as done. tra added a comment. Updated to address Eric's comments. http://reviews.llvm.org/D12917 Files: include/clang/AST/ASTContext.h include/clang/Basic/Builtins.h include/clang/Driver/CC1Options.td

Re: [PATCH] D12916: [Static Analyzer] Use generics related information to infer dynamic types.

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:871 @@ +870,3 @@ + if (RetRegion) { +State = setDynamicTypeInfo(State, RetRegion, ResultType, + /*CanBeSubclass=*/true); Would

Re: [PATCH] D12916: [Static Analyzer] Use generics related information to infer dynamic types.

xazax.hun updated this revision to Diff 35027. xazax.hun added a comment. Addressed the comments. http://reviews.llvm.org/D12916 Files: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp test/Analysis/DynamicTypePropagation.m Index: test/Analysis/DynamicTypePropagation.m

Re: [PATCH] D12921: clang-format: Support 'template<>' (no space).

strager added a comment. Should we remove `ObjCSpaceBeforeProtocolList`? It has the same problem as the `SpaceAfterTemplateKeyword` I am introducing. http://reviews.llvm.org/D12921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12917: [CUDA] Allow parsing of host and device code simultaneously.

echristo added a comment. One inline request and one inline comment, otherwise looks pretty good! Thanks :) -eric Comment at: include/clang/Frontend/CompilerInstance.h:355 @@ -350,3 +354,3 @@ - /// Replace the current diagnostics engine. + /// Replace the current Target.

r247932 - Try to unbreak windows compiler after r247926.

Author: dougk Date: Thu Sep 17 15:25:09 2015 New Revision: 247932 URL: http://llvm.org/viewvc/llvm-project?rev=247932=rev Log: Try to unbreak windows compiler after r247926. It might not like {} implicitly cast to an Arrayref. That's the theory, since I can't test it. Modified:

Re: [PATCH] D1623: Support __builtin_ms_va_list.

cdavis5x added a comment. Ping... http://reviews.llvm.org/D1623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D1623: Support __builtin_ms_va_list.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247941: Support __builtin_ms_va_list. (authored by cdavis). Changed prior to commit: http://reviews.llvm.org/D1623?vs=34728=35036#toc Repository: rL LLVM http://reviews.llvm.org/D1623 Files:

r247948 - [Myriad]: add "/include" to standard search path

Author: dougk Date: Thu Sep 17 16:20:16 2015 New Revision: 247948 URL: http://llvm.org/viewvc/llvm-project?rev=247948=rev Log: [Myriad]: add "/include" to standard search path Modified: cfe/trunk/lib/Driver/ToolChains.cpp cfe/trunk/lib/Driver/ToolChains.h

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

strager updated this revision to Diff 35038. strager added a comment. Fix missing IsDefinition check in ContinuationIndenter::canBreak. http://reviews.llvm.org/D10370 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp

[PATCH] D12945: [PATCH] Add checker for objects that should not be value types

aaron.ballman created this revision. aaron.ballman added reviewers: alexfh, klimek. aaron.ballman added a subscriber: cfe-commits. Some object types are not meant to be used as a value type in all circumstances, but the language (mainly C) does not provide facilities for marking these types as

r247941 - Support __builtin_ms_va_list.

Author: cdavis Date: Thu Sep 17 15:55:33 2015 New Revision: 247941 URL: http://llvm.org/viewvc/llvm-project?rev=247941=rev Log: Support __builtin_ms_va_list. Summary: This change adds support for `__builtin_ms_va_list`, a GCC extension for variadic `ms_abi` functions. The existing

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

strager added inline comments. Comment at: docs/ClangFormatStyleOptions.rst:221-235 @@ -220,3 +220,17 @@ -**AlwaysBreakAfterDefinitionReturnType** (``DefinitionReturnTypeBreakingStyle``) +**AlwaysBreakAfterDeclarationReturnType** (``ReturnTypeBreakingStyle``) + The function

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

zhengkai marked 2 inline comments as done. Comment at: lib/Frontend/DiagnosticRenderer.cpp:455 @@ -419,1 +454,3 @@ +static bool checkLocForMacroArgExpansion(SourceLocation Loc, + const SourceManager , Because the function

Re: [PATCH] D12903: Add -fplugin=name.so option to the driver

john.brawn retitled this revision from "Allow the -load option in the driver and pass it through to -cc1" to "Add -fplugin=name.so option to the driver". john.brawn updated the summary for this revision. john.brawn updated this revision to Diff 35014. john.brawn added a comment. Rename option

Re: [PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

zaks.anna added a comment. This new patch does not seem to build on top of http://reviews.llvm.org/D10305 but is an alternative way of generating the hash that reuses a lot of the building blocks from the other patch. What is the reason for that? (It also addresses your comment to this patch

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

zaks.anna added a comment. I see, Maybe we should add a new test file to test this instead of adding it to an existing test. http://reviews.llvm.org/D12119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Otherwise, LGTM. http://reviews.llvm.org/D12119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

xazax.hun added a comment. I was thinking a bit more, what would be the best way to determine what should we include in the hash. In order to determine that first we need to define the scope of the hash itself. There are several sensible choices such as: - identify bugs that were generated by

r247959 - clang/test/Driver/myriad-toolchain.c: Tweak for DOSish path.

Author: chapuni Date: Thu Sep 17 20:02:50 2015 New Revision: 247959 URL: http://llvm.org/viewvc/llvm-project?rev=247959=rev Log: clang/test/Driver/myriad-toolchain.c: Tweak for DOSish path. Modified: cfe/trunk/test/Driver/myriad-toolchain.c Modified: cfe/trunk/test/Driver/myriad-toolchain.c

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

zaks.anna added a comment. > > It's more user friendly to report this issue at the last point where the > > request is available rather than the last line of the function. > > > This looks similar to leak report checking. Is it? > > > Yes, that's not very common but possible. > Does

Re: [PATCH] D12571: [Analyzer] Fix assertions in commit r246345 (pr22954).

dcoughlin added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:198 @@ +197,3 @@ + + // Return true if the destination buffer of the copy function must/may be in + // bound. Since this returns true on unknown, it should be "may".

Re: [PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

xazax.hun added a comment. I can see two very differen directions on the two version of this patch. I think this is bad and we should pick one. In the other version we started to exclude some of the stuff (like filename) from the hash, since it is available already in the plist and gives the

  1   2   >