Re: Patch for Bug 26283: float.h is missing mandatory C11 fp macros like DBL_DECIMAL_DIG and LDBL_DECIMAL_DIG

Richard, Can you be more specific? I assume you mean something like my newly attached .h file that tests very basic implementation compliance (i.e., it's required, but not sufficient), but I would need a bit more guidance about the structure of the file, how to perform the tests, and where to

[PATCH] D17049: [CMake] don't build libLTO when LLVM_ENABLE_PIC is OFF

sugak created this revision. sugak added a reviewer: beanz. sugak added subscribers: hans, cfe-commits. Herald added a subscriber: joker.eph. When cmake is run with `-DLLVM_ENABLE_PIC=OFF`, build fails while linking shared library libLTO.so, because its dependencies are built with -fno-PIC. More

[PATCH] D17043: Check that the result of a library call w/o side effects is used

sidney created this revision. sidney added reviewers: mclow.lists, alexfh. sidney added a subscriber: cfe-commits. Currently has a whitelist of methods like std::vector::empty() which, in a standalone statement, likely won't do what the programmer wants. The whitelist is brittle (Did I misspell

Re: [clang-tools-extra] r260225 - [clang-tidy] Add -target in misc-misplaced-widening-cast test so it will work on various bots

On Wed, Feb 10, 2016 at 1:15 PM, Daniel Marjamäki < daniel.marjam...@evidente.se> wrote: > > Hello! > > That would make some sense to me. > > To catch portability issues users could use different relevant targets. Do > you know if some do that? > They could, but I'm not sure it's a widespread

Re: [PATCH] D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics.

hokein added a comment. LGTM, thanks for working on this! Ping @alexfh http://reviews.llvm.org/D16535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16535: [clang-tidy] Check to find unintended semicolons that changes the semantics.

alexfh accepted this revision. alexfh added a comment. LG. Thanks! Could you run the check on LLVM and post here a summary of results: how many warnings are generated, whether there are any false positives (based on a reasonably-sized random sample, if there are too many warnings to inspect

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

Anastasia added inline comments. Comment at: test/SemaOpenCL/unroll-hint-cl20.cl:1 @@ +1,2 @@ +//RUN: %clang_cc1 -O0 -cl-std=CL2.0 -fsyntax-only -verify %s + Could we just combine this with test/SemaOpenCL/unroll-hint.cl. You can have two RUN lines and pass

Re: [PATCH] D16308: clang-tidy Enhance readability-simplify-boolean-expr check to handle implicit conversions of integral types to bool and member pointers

On Wed, Feb 10, 2016 at 7:19 AM, Richard via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > [Please reply *only* to the list and do not include my email directly > in the To: or Cc: of your reply; otherwise I will not see your reply. > Thanks.] > > In article

Re: [PATCH] D17069: [clang-tidy] Fix an assert failure in 'readability-braces-around-statements' check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with one possible improvement. Thank you! Comment at: clang-tidy/readability/BracesAroundStatementsCheck.cpp:181 @@ +180,3 @@ + // IfStmt. Avoid triggering assert

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

congliu added a comment. The strategy has changed. Now this check does not ignore template in instantiation, instead, it generate a single warning for some instantiation and ignore others, so that fix is able to apply. We do this to walk around the function copied from ASTMatchFinder, since

[PATCH] D17072: Return immediatedly if Method is null, otherwise you'll get a crash when dyn_cast is called with a nullptr

hintonda created this revision. hintonda added reviewers: doug.gregor, rnk. hintonda added a subscriber: cfe-commits. Fixes crash referenced in PR25181 where dyn_cast is called on a null instance of LM.Method. http://reviews.llvm.org/D17072 Files: lib/Parse/ParseCXXInlineMethods.cpp Index:

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

alexfh added a comment. > The strategy has changed. Now this check does not ignore template in > instantiation, instead, it generate a > single warning for some instantiation and ignore others, so that fix is able > to apply. I'm not sure this is the right thing to do, since there might be

RE: [PATCH] D16310: new clang-tidy checker misc-long-cast

> You can get overflow with / and %. Consider: > > int i = INT_MIN / -1; // similar for % you are right, I did not think of that. imho overflow still seems unlikely for / and %. ..

[libcxx] r260381 - Limit catopen usage to unix-like OSes

Author: bcraig Date: Wed Feb 10 07:47:25 2016 New Revision: 260381 URL: http://llvm.org/viewvc/llvm-project?rev=260381=rev Log: Limit catopen usage to unix-like OSes Operating systems that are not unix-like are unlikely to have access to catopen. Instead of black-listing each one, we now filter

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

congliu updated this revision to Diff 47448. congliu marked 2 inline comments as done. congliu added a comment. - Generate a single warning for multiple template instantiations. http://reviews.llvm.org/D16922 Files: clang-tidy/misc/VirtualNearMissCheck.cpp

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

pxli168 updated this revision to Diff 47455. pxli168 marked 5 inline comments as done. http://reviews.llvm.org/D16040 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CodeGenFunction.cpp lib/Sema/SemaChecking.cpp lib/Sema/SemaDeclAttr.cpp

r260388 - [MS ABI] Never reference dllimport'd vtables

Author: majnemer Date: Wed Feb 10 11:40:47 2016 New Revision: 260388 URL: http://llvm.org/viewvc/llvm-project?rev=260388=rev Log: [MS ABI] Never reference dllimport'd vtables Referencing a dllimported vtable is impossible in a constexpr constructor. It would be friendlier to C++ programmers if

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

hubert.reinterpretcast added inline comments. Comment at: lib/Sema/SemaExpr.cpp:1169 @@ +1168,3 @@ + if (LHSElemType == S.Context.Float128Ty && + RHSElemType == S.Context.LongDoubleTy) +return true; nemanjai wrote: > hubert.reinterpretcast wrote: > > I

Re: [PATCH] D17061: [MS ABI] Never reference dllimport'd vtables

This revision was automatically updated to reflect the committed changes. Closed by commit rL260388: [MS ABI] Never reference dllimport'd vtables (authored by majnemer). Changed prior to commit: http://reviews.llvm.org/D17061?vs=47407=47473#toc Repository: rL LLVM

Re: [PATCH] D17072: Return immediatedly if Method is null, otherwise you'll get a crash when dyn_cast is called with a nullptr

This needs a testcase added to the tests directory. On Wednesday, February 10, 2016, don hinton via cfe-commits < cfe-commits@lists.llvm.org> wrote: > hintonda created this revision. > hintonda added reviewers: doug.gregor, rnk. > hintonda added a subscriber: cfe-commits. > > Fixes crash

Re: [PATCH] D17043: Check that the result of a library call w/o side effects is used

alexfh added a comment. Thank you for working on this check! I'd like to note that there is a library-side way to mitigate this issue using the `[[clang::warn_unused_result]]` attribute on `vector::empty()` and similar methods: $ cat q.cc #if defined(__clang__) # if __cplusplus >=

[PATCH] D17075: [AST] Added SubstTemplateTypeParm, DependentNameType, DependentSizedArrayType import functions in the ASTImporter.

esakella created this revision. esakella added reviewers: klimek, bkramer, rsmith, spyffe. esakella added subscribers: karies, cfe-commits. Herald added subscribers: rengolin, aemerson. Implemented the VisitSubstTemplateTypeParmType VisitDependentNameType VisitDependentSizedArrayType

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

yaxunl updated this revision to Diff 47460. yaxunl added a comment. merge two sema tests as one as Anastasia suggested. http://reviews.llvm.org/D16686 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticParseKinds.td

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

congliu updated this revision to Diff 47461. congliu marked 3 inline comments as done. congliu added a comment. - Allowed warnings but disallowed fix for template instantiations. - Updated tests. http://reviews.llvm.org/D16922 Files: clang-tidy/misc/VirtualNearMissCheck.cpp

[PATCH] D17076: [OPENMP] firstprivate clause for target

carlo.bertolli created this revision. carlo.bertolli added reviewers: ABataev, fraggamuffin, kkwli0. carlo.bertolli added subscribers: sfantao, arpith-jacob, cfe-commits. carlo.bertolli set the repository for this revision to rL LLVM. Very simple but necessary extension to target directive with

Re: [PATCH] D17043: Check that the result of a library call w/o side effects is used

sidney added a comment. In http://reviews.llvm.org/D17043#348525, @alexfh wrote: > I'd like to note that there is a library-side way to mitigate this issue > using the `[[clang::warn_unused_result]]` attribute on `vector::empty()` and > similar methods: Using an attribute sounds much better

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

In article , Daniel Marjamäki writes: > > You can get overflow with / and %. Consider: > > > > int i = INT_MIN / -1; // similar for % > > you are right, I did not think of that. > > imho overflow

Re: [PATCH] D16846: PR26449: Fixes for bugs in __builtin_classify_type implementation

andreybokhanko updated this revision to Diff 47475. andreybokhanko added a comment. John, thanks for the re-review! -- I did as you advised, and added *a lot* of switches. :-) Patch updated; please re-review again. http://reviews.llvm.org/D16846 Files: lib/AST/ExprConstant.cpp

Re: [PATCH] D17072: Return immediatedly if Method is null, otherwise you'll get a crash when dyn_cast is called with a nullptr

hintonda updated this revision to Diff 47456. hintonda added a comment. - Reformatted change with clang-format http://reviews.llvm.org/D17072 Files: lib/Parse/ParseCXXInlineMethods.cpp Index: lib/Parse/ParseCXXInlineMethods.cpp

Re: Need to use function "getAsCXXRecordDecl" of ASTMatchFinder.cpp in a clang-tidy check

Hi Richard, You are right. Actually I just need to consider the cases that there are full instantiations of the primary template. I have changed the strategy and not use that function. Thanks a lot! Cong On Wed, Feb 10, 2016 at 2:17 AM, Richard Smith wrote: > On Tue,

r260414 - Fix some Clang-tidy readability-redundant-control-flow warnings; other minor fixes.

Author: eugenezelenko Date: Wed Feb 10 13:11:58 2016 New Revision: 260414 URL: http://llvm.org/viewvc/llvm-project?rev=260414=rev Log: Fix some Clang-tidy readability-redundant-control-flow warnings; other minor fixes. Differential revision: http://reviews.llvm.org/D17060 Modified:

Re: [PATCH] D15040: [ARM] Add command-line options for ARMv8.2-A

t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. Looks reasonable to me now. Tim. http://reviews.llvm.org/D15040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17060: [Clang] Fix Clang-tidy readability-redundant-control-flow warnings; other minor fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL260414: Fix some Clang-tidy readability-redundant-control-flow warnings; other minor… (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D17060?vs=47415=47492#toc

r260420 - [analyzer] Windows: launch scan-build from an arbitrary location.

Author: ayartsev Date: Wed Feb 10 13:46:41 2016 New Revision: 260420 URL: http://llvm.org/viewvc/llvm-project?rev=260420=rev Log: [analyzer] Windows: launch scan-build from an arbitrary location. The following batch files allow to launch scan-build from an arbitrary location if path to

Re: [PATCH] D16971: Fixed crash when partial specialization is missing required parameters

hintonda updated this revision to Diff 47499. hintonda added a comment. - Added test for PR26077 http://reviews.llvm.org/D16971 Files: lib/Sema/SemaTemplate.cpp test/SemaCXX/pr26077-crash-on-invalid.cpp Index: test/SemaCXX/pr26077-crash-on-invalid.cpp

Re: [libcxx] r260337 - Fix overload sets of strchr, strpbrk, strrchr, memchr and strstr from

Hi Richard, On 9 February 2016 at 16:59, Richard Smith via cfe-commits wrote: > Fix overload sets of strchr, strpbrk, strrchr, memchr and strstr from > and wcschr, wcspbrk, wcsrchr, wmemchr, and wcsstr from to > provide a const-correct overload set even when the

Re: [PATCH] D17060: [Clang] Fix Clang-tidy readability-redundant-control-flow warnings; other minor fixes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rL LLVM http://reviews.llvm.org/D17060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17085: Test commit, fixed "clang" to "Clang" in docs

weimingz added a comment. LGTM http://reviews.llvm.org/D17085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r260411 - Silence some MSVC false positive warnings about integer zexts and falling off the end of a covered switch

Author: rnk Date: Wed Feb 10 13:09:15 2016 New Revision: 260411 URL: http://llvm.org/viewvc/llvm-project?rev=260411=rev Log: Silence some MSVC false positive warnings about integer zexts and falling off the end of a covered switch Modified: cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp

Re: [libcxx] r260012 - Cleanup node-type handling in the unordered containers

(Re-adding the list) Re-committed as r260431. Let me know if there is any more breakage. @Tim Are these tests in the clang test suite? Marshall and I were just talking about removing all together. Could you explain who still uses it? On Mon, Feb 8, 2016 at 4:52 PM, Eric Fiselier

r260435 - [clang-cl] /Z7 now generates normal debug info, not just line info

Author: rnk Date: Wed Feb 10 15:28:38 2016 New Revision: 260435 URL: http://llvm.org/viewvc/llvm-project?rev=260435=rev Log: [clang-cl] /Z7 now generates normal debug info, not just line info Previously LLVM could not process any debug info we produced, so it didn't make sense to spend time

Re: [PATCH] D5238: [analyzer] Detect duplicate [super dealloc] calls

dcoughlin updated this revision to Diff 47514. dcoughlin added a comment. Address more of Anna's comments. - Add a more explicit comment about checker in header comment - Changed the checker to always use the receiver symbol rather than the self symbol for clarity. - Rework

Re: [PATCH] D5238: [analyzer] Detect duplicate [super dealloc] calls

dcoughlin added a comment. In http://reviews.llvm.org/D5238#348199, @zaks.anna wrote: > Looks good, below are some comments which are mostly nits. > > What's the plan for bringing this out of alpha? Is it pending evaluation on > real code? I will first extend this checker to check for uses of

Re: [PATCH] D17072: Return immediatedly if Method is null, otherwise you'll get a crash when dyn_cast is called with a nullptr

hintonda added a comment. I don't have commit access, so if this patch is accepted, could someone please commit it for me? http://reviews.llvm.org/D17072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16971: Fixed crash when partial specialization is missing required parameters

hintonda added a comment. I don't have commit access, so if this patch is accepted, could someone please commit it for me? http://reviews.llvm.org/D16971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D17091: [analyzer][scan-build-py] Non-existing directory for scan-build output.

ayartsev created this revision. ayartsev added a reviewer: rizsotto.mailinglist. ayartsev added a subscriber: cfe-commits. Attached patch makes scan-build successfully accept non-existing output directories provided via "-o" option. The directory is created in this case. This behavior is

[libcxx] r260431 - Recommit r260012 - Cleanup node-type handling in the unordered containers.

Author: ericwf Date: Wed Feb 10 14:46:23 2016 New Revision: 260431 URL: http://llvm.org/viewvc/llvm-project?rev=260431=rev Log: Recommit r260012 - Cleanup node-type handling in the unordered containers. This time I kept working! This patch is the first in a series of patches that's meant to

Re: [libcxx] r260012 - Cleanup node-type handling in the unordered containers

On 10 February 2016 at 12:52, Eric Fiselier wrote: > @Tim Are these tests in the clang test suite? Yep, at http://llvm.org/git/test-suite.git. > Marshall and I were just talking about removing all together. > Could you explain who still uses it? In the test-suite, it looks like

Re: [PATCH] D16738: Fix invalid casts in .

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Thanks for putting up with my pickyness. It looks like there are exception safety issues with the order of `__f_ = __as_base(&__buf_)` and `__f->__f_..__clone(__f)` in a bunch of

Re: [PATCH] D15095: Accept "-Weverything" in pragma clang diagnostic ...

Sunil_Srivastava added a comment. Richard, Your comment and my concern about the getDiagnosticsInGroup is still visible in the greyed out area. Given that do you still want to modify getDiagnosticsInGroup ? I have removed the separate test and added the new tests to existing files, as you

Re: [libcxx] r260012 - Cleanup node-type handling in the unordered containers

> On Feb 10, 2016, at 12:59 PM, Tim Northover wrote: > > On 10 February 2016 at 12:52, Eric Fiselier wrote: >> @Tim Are these tests in the clang test suite? > > Yep, at http://llvm.org/git/test-suite.git. > >> Marshall and I were just talking about

Re: [PATCH] D17043: Check that the result of a library call w/o side effects is used

alexfh added a comment. In http://reviews.llvm.org/D17043#348569, @sidney wrote: > In http://reviews.llvm.org/D17043#348525, @alexfh wrote: > > > I'd like to note that there is a library-side way to mitigate this issue > > using the `[[clang::warn_unused_result]]` attribute on `vector::empty()`

Re: [PATCH] D17072: Return immediatedly if Method is null, otherwise you'll get a crash when dyn_cast is called with a nullptr

hintonda updated this revision to Diff 47501. hintonda added a comment. - Added test for PR25181 http://reviews.llvm.org/D17072 Files: lib/Parse/ParseCXXInlineMethods.cpp test/SemaCXX/pr25181-crash-on-invalid.cpp Index: test/SemaCXX/pr25181-crash-on-invalid.cpp

Re: [libcxx] r260337 - Fix overload sets of strchr, strpbrk, strrchr, memchr and strstr from

On Wed, Feb 10, 2016 at 10:32 AM, Tim Northover wrote: > Hi Richard, > > On 9 February 2016 at 16:59, Richard Smith via cfe-commits > wrote: >> Fix overload sets of strchr, strpbrk, strrchr, memchr and strstr from >> and wcschr, wcspbrk,

Re: [libcxx] r260337 - Fix overload sets of strchr, strpbrk, strrchr, memchr and strstr from

OK, got the build working. This should be fixed in r260425. Please let me know if you're still seeing failures. On Wed, Feb 10, 2016 at 11:59 AM, Richard Smith wrote: > On Wed, Feb 10, 2016 at 10:32 AM, Tim Northover > wrote: >> Hi Richard, >> >>

r260433 - Test commit, fixed "clang" to "Clang" in docs

Author: mgrang Date: Wed Feb 10 15:06:10 2016 New Revision: 260433 URL: http://llvm.org/viewvc/llvm-project?rev=260433=rev Log: Test commit, fixed "clang" to "Clang" in docs Reviewers: weimingz Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D17085 Modified:

Re: [PATCH] D15095: Accept "-Weverything" in pragma clang diagnostic ...

Sunil_Srivastava added a reviewer: rsmith. Sunil_Srivastava updated this revision to Diff 47509. Sunil_Srivastava added a comment. Changed the test, but the compiler code is still same, pending reply from Richard Smith http://reviews.llvm.org/D15095 Files: lib/Basic/Diagnostic.cpp

Re: [PATCH] D17085: Test commit, fixed "clang" to "Clang" in docs

This revision was automatically updated to reflect the committed changes. Closed by commit rL260433: Test commit, fixed "clang" to "Clang" in docs (authored by mgrang). Changed prior to commit: http://reviews.llvm.org/D17085?vs=47493=47510#toc Repository: rL LLVM

Re: [PATCH] D15095: Accept "-Weverything" in pragma clang diagnostic ...

rsmith added a comment. There seem to be two principled approaches here: 1. `DiagnosticsEngine` has a `Group` named `"everything"` (all of its interface supports that group, and from the point of view of someone using `DiagnosticsEngine` it behaves like any other group), or 2. There is no such

[libcxx] r260443 - Remove changes that snuck in within r260431

Author: ericwf Date: Wed Feb 10 15:58:36 2016 New Revision: 260443 URL: http://llvm.org/viewvc/llvm-project?rev=260443=rev Log: Remove changes that snuck in within r260431 Modified: libcxx/trunk/include/unordered_map Modified: libcxx/trunk/include/unordered_map URL:

[PATCH] D17104: [VFS] Drop path traversal assertion

bruno created this revision. bruno added reviewers: bogner, benlangmuir. bruno added subscribers: cfe-commits, dexonsmith. This patch removes the path traversals check/assertion related with the presence of ".." in paths. The rationale is that if source and destination paths in the YAML file

Re: [libcxx] r260337 - Fix overload sets of strchr, strpbrk, strrchr, memchr and strstr from

On 10 February 2016 at 12:06, Richard Smith wrote: > OK, got the build working. This should be fixed in r260425. Please let > me know if you're still seeing failures. Thanks Richard, that did it. Tim. ___ cfe-commits mailing

r260448 - Bail on compilation as soon as a job fails.

Author: jlebar Date: Wed Feb 10 16:17:00 2016 New Revision: 260448 URL: http://llvm.org/viewvc/llvm-project?rev=260448=rev Log: Bail on compilation as soon as a job fails. Previously we attempted to be smart; if one job failed, we'd run all jobs that didn't depend on the failing job. Problem

Re: [PATCH] D16514: Add -stop-on-failure driver option, and enable it by default for CUDA compiles.

This revision was automatically updated to reflect the committed changes. Closed by commit rL260448: Bail on compilation as soon as a job fails. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D16514?vs=47520=47525#toc Repository: rL LLVM

Re: [libcxx] r260012 - Cleanup node-type handling in the unordered containers

> Can we hold off a little longer? Yes we can. The entire point of the AFAIK was to encourage migration to libc++ so it makes some sense to keep them while they still serve this purpose. When you say "a little longer" what sort of timeline do you have in mind? It would be nice to get rid of

Re: [PATCH] D17043: Check that the result of a library call w/o side effects is used

sidney added a comment. In http://reviews.llvm.org/D17043#348982, @alexfh wrote: > The attribute can have arguments (e.g. `[[deprecated("use some other API")]] > void f();`), so if there is a good reason, an argument (e.g. a custom > message) can be added to the `warn_unused_result` attribute.

[libcxx] r260441 - Fix invalid casts in .

Author: eugenis Date: Wed Feb 10 15:53:28 2016 New Revision: 260441 URL: http://llvm.org/viewvc/llvm-project?rev=260441=rev Log: Fix invalid casts in . static_cast of a pointer to object before the start of the object's lifetime has undefined behavior. This code triggers CFI warnings. This

Re: [PATCH] D16738: Fix invalid casts in .

eugenis closed this revision. eugenis added a comment. Thanks for the review! Committed as r260441. Repository: rL LLVM http://reviews.llvm.org/D16738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16514: Add -stop-on-failure driver option, and enable it by default for CUDA compiles.

echristo accepted this revision. echristo added a reviewer: echristo. echristo added a comment. This works for me and I can't think of anything it's going to break so LGTM. Thanks! -eric http://reviews.llvm.org/D16514 ___ cfe-commits mailing list

r260449 - Revert r260388 "[MS ABI] Never reference dllimport'd vtables"

Author: hans Date: Wed Feb 10 16:18:37 2016 New Revision: 260449 URL: http://llvm.org/viewvc/llvm-project?rev=260449=rev Log: Revert r260388 "[MS ABI] Never reference dllimport'd vtables" This caused the compiler to fail with "invalid linkage type for global declaration" (PR26569). Modified:

[PATCH] D17103: [CUDA] Don't crash when trying to printf a non-scalar object.

jlebar created this revision. jlebar added reviewers: majnemer, rnk. jlebar added subscribers: tra, jhen, cfe-commits. We can't do the right thing, since there's no right thing to do, but at least we can not crash the compiler. http://reviews.llvm.org/D17103 Files:

Re: [libcxx] r260012 - Cleanup node-type handling in the unordered containers

> On 2016-Feb-10, at 13:25, Bob Wilson wrote: > > >> On Feb 10, 2016, at 12:59 PM, Tim Northover wrote: >> >> On 10 February 2016 at 12:52, Eric Fiselier wrote: >>> @Tim Are these tests in the clang test suite? >> >> Yep, at

[PATCH] D17100: Remove unused ToolChain arg from Driver::ConstructPhaseAction and BuildAction.

jlebar created this revision. jlebar added a reviewer: echristo. jlebar added a subscriber: cfe-commits. Actions don't depend on the toolchain; they get bound to a particular toolchain via BindArch. No functional changes. http://reviews.llvm.org/D17100 Files: include/clang/Driver/Driver.h

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

benlangmuir added a comment. Please clarify what you mean here: > The rationale is that if source and destination paths in the YAML file > contain ".." this is enough > for the file manager to retrieve the right file, meaning that it doesn't > matter how we write it > since the FileManager

Re: [PATCH] D17103: [CUDA] Don't crash when trying to printf a non-scalar object.

tra added a comment. Erasing an argument would only complicate the problem. I guess for consistency we need to match clang's behavior for regular C++ code. For optimized builds it just seems to pass NULL pointer instead. http://reviews.llvm.org/D17103

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Wow really? That's ... wow. OK http://reviews.llvm.org/D17111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

jlebar added inline comments. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); I think this

Re: [PATCH] D16808: [MCU] PR26438: Fix assertion failure on function returning an empty struct or union

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D16808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

echristo added inline comments. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); jlebar

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

tra added inline comments. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); hfinkel wrote: >

Re: [PATCH] D17103: [CUDA] Don't crash when trying to printf a non-scalar object.

hfinkel added a comment. In http://reviews.llvm.org/D17103#349280, @jlebar wrote: > > > I guess this is the part I'm unsure of. If it's legal to pass a struct > > > to printf in regular C++ (seems to be?), I'd guess it should be legal in > > > CUDA, too? I'm just not sure what it's supposed

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

hfinkel added a subscriber: hfinkel. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g");

r260496 - [Objective-c] Stop attaching section "datacoal_nt" to global variables.

Author: ahatanak Date: Thu Feb 11 00:36:35 2016 New Revision: 260496 URL: http://llvm.org/viewvc/llvm-project?rev=260496=rev Log: [Objective-c] Stop attaching section "datacoal_nt" to global variables. The current macho linker just copies symbols in section datacoal_nt to section data, so it

Re: [PATCH] D17130: Debloat some headers

craig.topper added a subscriber: craig.topper. craig.topper added a comment. What's complex about the SVal constructors? Comment at: llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h:143 @@ -144,3 +142,3 @@ void addAbortedBlock(const ExplodedNode

r260492 - [OPENMP] Rename OMPCapturedFieldDecl to OMPCapturedExprDecl, NFC.

Author: abataev Date: Wed Feb 10 23:35:55 2016 New Revision: 260492 URL: http://llvm.org/viewvc/llvm-project?rev=260492=rev Log: [OPENMP] Rename OMPCapturedFieldDecl to OMPCapturedExprDecl, NFC. OMPCapturedExprDecl allows caopturing not only of fielddecls, but also other expressions. It also

r260497 - clang-format: Make it more expensive to break template parameters.

Author: djasper Date: Thu Feb 11 00:43:01 2016 New Revision: 260497 URL: http://llvm.org/viewvc/llvm-project?rev=260497=rev Log: clang-format: Make it more expensive to break template parameters. In particular, make it more expensive than breaking after the return type of a function

Re: [PATCH] D16517: ClangTidy check to flag uninitialized builtin and pointer fields.

flx updated this revision to Diff 47594. flx added a comment. Added comment that we're returning early if this constructor simply delegates to another constructor. http://reviews.llvm.org/D16517 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

Re: [PATCH] D16517: ClangTidy check to flag uninitialized builtin and pointer fields.

flx added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:205 @@ +204,3 @@ + Diag << FixItHint::CreateInsertion( + Field->getSourceRange().getEnd().getLocWithOffset( + Field->getName().size()),

Re: [PATCH] D16517: ClangTidy check to flag uninitialized builtin and pointer fields.

flx updated this revision to Diff 47590. flx marked 3 inline comments as done. http://reviews.llvm.org/D16517 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp

Re: SV: [clang-tools-extra] r260225 - [clang-tidy] Add -target in misc-misplaced-widening-cast test so it will work on various bots

Makes sense. I wonder though whether the check should attempt to be platform-independent and warn regardless of whether int and long have the same bit width. What do you think? On Feb 10, 2016 9:35 AM, "Daniel Marjamäki" wrote: > > Hello! > > > I'm not sure this is

r260370 - Fix PR26543: add a check for definition in CXXRecordDecl.

Author: abataev Date: Wed Feb 10 04:50:12 2016 New Revision: 260370 URL: http://llvm.org/viewvc/llvm-project?rev=260370=rev Log: Fix PR26543: add a check for definition in CXXRecordDecl. Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp cfe/trunk/test/OpenMP/parallel_messages.cpp Modified:

r260373 - Fix assertion "Chunk.Kind == DeclaratorChunk::Function" with attributed type.

Author: dzobnin Date: Wed Feb 10 05:23:48 2016 New Revision: 260373 URL: http://llvm.org/viewvc/llvm-project?rev=260373=rev Log: Fix assertion "Chunk.Kind == DeclaratorChunk::Function" with attributed type. This patch is to upgrade FunctionTypeUnwrapper for correct processing of AttributedType.

Re: [PATCH] D15373: Fix for bug 25786 - Assertion "Chunk.Kind == DeclaratorChunk::Function" failed with regparm attribute.

This revision was automatically updated to reflect the committed changes. Closed by commit rL260373: Fix assertion "Chunk.Kind == DeclaratorChunk::Function" with attributed type. (authored by dzobnin). Changed prior to commit: http://reviews.llvm.org/D15373?vs=45179=47434#toc Repository: rL

r260374 - [OPENMP 4.5] Initial support for data members in 'firstprivate' clause.

Author: abataev Date: Wed Feb 10 05:29:16 2016 New Revision: 260374 URL: http://llvm.org/viewvc/llvm-project?rev=260374=rev Log: [OPENMP 4.5] Initial support for data members in 'firstprivate' clause. OpenMP 4.5 allows privatization of non-static data members of current class in non-static member

SV: [PATCH] D16310: new clang-tidy checker misc-long-cast

That is intentional.. you can't get overflow with / , % , & , | , etc... .. Daniel Marjamäki Senior Engineer Evidente ES East AB Warfvinges väg 34 SE-112 51 Stockholm Sweden

SV: [clang-tools-extra] r260225 - [clang-tidy] Add -target in misc-misplaced-widening-cast test so it will work on various bots

Hello! > I'm not sure this is a good fix. What was the specific issue (and on which > buildbots)? Ok. The buildbots said: FileCheck error: '/home/linaro/buildbot/clang-cmake-thumbv7-a15/stage1/tools/clang/tools/extra/test/clang-tidy/Output/misc-misplaced-widening-cast.cpp.tmp.cpp.msg' is

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

danielmarjamaki added inline comments. Comment at: clang-tools-extra/trunk/clang-tidy/misc/MisplacedWideningCastCheck.cpp:21-23 @@ +20,5 @@ +void MisplacedWideningCastCheck::registerMatchers(MatchFinder *Finder) { + auto Calc = expr(anyOf(binaryOperator(anyOf( +

Re: r260277 - Simplify and rename ASTMatchFinder's getCXXRecordDecl to make it more obvious

On Tue, Feb 9, 2016 at 10:03 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Tue Feb 9 14:59:05 2016 > New Revision: 260277 > > URL: http://llvm.org/viewvc/llvm-project?rev=260277=rev > Log: > Simplify and rename ASTMatchFinder's getCXXRecordDecl to

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

nemanjai added inline comments. Comment at: lib/Basic/TargetInfo.cpp:231 @@ +230,3 @@ +if (hasFloat128Type() && +() == ::APFloat::IEEEquad) + return Float128; hubert.reinterpretcast wrote: > Is it necessary to check that `__float128` is IEEE quad

Re: [PATCH] D15636: Reduce false positives in printf/scanf format checker

AndyG removed reviewers: dblaikie, rsmith. AndyG updated this revision to Diff 47426. AndyG added a comment. All strings matching the highest uncovered argument are now highlighted in the diagnostic. http://reviews.llvm.org/D15636 Files: include/clang/Sema/Sema.h lib/Sema/SemaChecking.cpp

  1   2   >