Re: [PATCH] D16797: Update clang support on recent Haiku

rjmccall added a comment. LGTM. Repository: rL LLVM http://reviews.llvm.org/D16797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17516: AMDGPU: Verify subtarget specific builtins

echristo added a comment. Replied inline, I hope this is helpful :) Comment at: lib/Basic/Targets.cpp:2059-2063 @@ +2058,7 @@ + + if (Has16BitInsts) +Features["16-bit-insts"] = true; + + if (hasSMemRealTime) +Features["s-memrealtime"] = true; + arsenm

[PATCH] D17983: Eliminate many benign instances of "potentially uninitialized local variable" warnings

ariccio created this revision. ariccio added subscribers: llvm-commits, cfe-commits. Herald added a reviewer: tstellarAMD. Herald added subscribers: joker.eph, dsanders, arsenm, MatzeB. Currently, the "potentially uninitialized local variable" & "potentially uninitialized local pointer variable"

Re: [PATCH] D16139: [MIPS] initFeatureMap() to handle empty string argument

On Sat, Mar 5, 2016 at 6:16 AM Daniel Sanders wrote: > dsanders added a comment. > > In http://reviews.llvm.org/D16139#368217, @echristo wrote: > > > This seems wrong. You should fix setCPU instead or set a default CPU. > > > We already set a default CPU in the

Re: [PATCH] D16797: Update clang support on recent Haiku

korli added a comment. Ping? Repository: rL LLVM http://reviews.llvm.org/D16797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17877: [OpenMP] Base support for target directive codegen on NVPTX device.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:69 @@ +68,3 @@ + /// evaluates to false. + void emitTargetOutlinedFunctionHelper(const OMPExecutableDirective , +StringRef ParentName, Missed

Re: [PATCH] D17979: [OPENMP] Add regression test for codegen of distribute pragma for NVPTX

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM http://reviews.llvm.org/D17979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17547: [OpenMP] Add support for multidimensional array sections in map clause SEMA.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D17547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17952: [Clang] Accept absolute paths in the -fuse-ld option

This revision was automatically updated to reflect the committed changes. Closed by commit rL262996: Accept absolute paths in the -fuse-ld option. (authored by whitequark). Repository: rL LLVM http://reviews.llvm.org/D17952 Files: cfe/trunk/lib/Driver/ToolChain.cpp

r262996 - Accept absolute paths in the -fuse-ld option.

Author: whitequark Date: Tue Mar 8 23:18:16 2016 New Revision: 262996 URL: http://llvm.org/viewvc/llvm-project?rev=262996=rev Log: Accept absolute paths in the -fuse-ld option. This patch extends the -fuse-ld option to accept a full path to an executable and use it verbatim to invoke the

Re: [PATCH] D17952: [Clang] Accept absolute paths in the -fuse-ld option

echristo accepted this revision. echristo added a reviewer: echristo. echristo added a comment. This revision is now accepted and ready to land. LGTM, thanks. -eric Repository: rL LLVM http://reviews.llvm.org/D17952 ___ cfe-commits mailing list

[PATCH] D17979: [OPENMP] Add regression test for codegen of distribute pragma for NVPTX

carlo.bertolli created this revision. carlo.bertolli added reviewers: ABataev, fraggamuffin, kkwli0. carlo.bertolli added subscribers: sfantao, arpith-jacob, caomhin, cfe-commits. carlo.bertolli set the repository for this revision to rL LLVM. The support for distribute pragma is the same on host

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin added a comment. Ping. http://reviews.llvm.org/D17815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r262991 - [index] Add a message for the assertion, NFC.

Author: akirtzidis Date: Tue Mar 8 20:53:12 2016 New Revision: 262991 URL: http://llvm.org/viewvc/llvm-project?rev=262991=rev Log: [index] Add a message for the assertion, NFC. Modified: cfe/trunk/lib/Index/IndexingContext.cpp Modified: cfe/trunk/lib/Index/IndexingContext.cpp URL:

Re: r262984 - [index] Fix assertion hit when indexing re-declarations of built-in functions.

> On Mar 8, 2016, at 6:12 PM, Argyrios Kyrtzidis via cfe-commits > wrote: > > Author: akirtzidis > Date: Tue Mar 8 20:12:40 2016 > New Revision: 262984 > > URL: http://llvm.org/viewvc/llvm-project?rev=262984=rev > Log: > [index] Fix assertion hit when indexing

r262984 - [index] Fix assertion hit when indexing re-declarations of built-in functions.

Author: akirtzidis Date: Tue Mar 8 20:12:40 2016 New Revision: 262984 URL: http://llvm.org/viewvc/llvm-project?rev=262984=rev Log: [index] Fix assertion hit when indexing re-declarations of built-in functions. Modified: cfe/trunk/lib/Index/IndexingContext.cpp

Re: [PATCH] D17952: [Clang] Accept absolute paths in the -fuse-ld option

whitequark updated this revision to Diff 50097. whitequark added a comment. Added a test Repository: rL LLVM http://reviews.llvm.org/D17952 Files: cfe/trunk/lib/Driver/ToolChain.cpp cfe/trunk/test/Driver/fuse-ld.c Index: cfe/trunk/test/Driver/fuse-ld.c

[PATCH] D17976: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

Forgot to add the mailing list when I created a patch.Begin forwarded message:From: Roman Levenstein Subject: [PATCH] D17976: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-endDate: March 8, 2016 at 5:17:02 PM PSTTo:

r262971 - Readd testcase accidentally removed in r262888.

Author: rsmith Date: Tue Mar 8 18:12:38 2016 New Revision: 262971 URL: http://llvm.org/viewvc/llvm-project?rev=262971=rev Log: Readd testcase accidentally removed in r262888. Modified: cfe/trunk/test/CXX/dcl.dcl/dcl.attr/dcl.attr.nodiscard/p1.cpp Modified:

Re: [PATCH] D15469: Expose cxx constructor and method properties through libclang and python bindings.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Sorry about the delay with this change. Thanks for removing the parameter. I think that this is fine as is. Do you have commit rights, or should I commit this on your behalf?

Re: [PATCH] D17952: [Clang] Accept absolute paths in the -fuse-ld option

echristo added a subscriber: echristo. echristo added a comment. Needs a testcase, but otherwise should be fine. Repository: rL LLVM http://reviews.llvm.org/D17952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17952: [Clang] Accept absolute paths in the -fuse-ld option

jroelofs added a subscriber: jroelofs. jroelofs added a comment. Testcases? Repository: rL LLVM http://reviews.llvm.org/D17952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r262966 - Fix crash in access check for aggregate initialization of base classes. It's

Author: rsmith Date: Tue Mar 8 17:17:35 2016 New Revision: 262966 URL: http://llvm.org/viewvc/llvm-project?rev=262966=rev Log: Fix crash in access check for aggregate initialization of base classes. It's not obvious how to access-check these, so pick a conservative rule until we get feedback

r262965 - Fix -Werror build.

Author: rsmith Date: Tue Mar 8 17:16:16 2016 New Revision: 262965 URL: http://llvm.org/viewvc/llvm-project?rev=262965=rev Log: Fix -Werror build. Modified: cfe/trunk/lib/CodeGen/CGExprAgg.cpp Modified: cfe/trunk/lib/CodeGen/CGExprAgg.cpp URL:

r262964 - AArch64: remove tests of intrinsics completely duplicated elsewhere.

Author: tnorthover Date: Tue Mar 8 17:10:58 2016 New Revision: 262964 URL: http://llvm.org/viewvc/llvm-project?rev=262964=rev Log: AArch64: remove tests of intrinsics completely duplicated elsewhere. Removed: cfe/trunk/test/CodeGen/arm64_neon_high_half.c

Re: [PATCH] D17764: Add attributes for AMD GPU Tools

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Attribute side of things LGTM, but I don't have the expertise to comment on the OpenCL functionality itself. http://reviews.llvm.org/D17764

r262963 - P0017R1: In C++1z, an aggregate class can have (public non-virtual) base classes; these are initialized as if they were data members.

Author: rsmith Date: Tue Mar 8 16:17:41 2016 New Revision: 262963 URL: http://llvm.org/viewvc/llvm-project?rev=262963=rev Log: P0017R1: In C++1z, an aggregate class can have (public non-virtual) base classes; these are initialized as if they were data members. Added:

Re: [PATCH] D17764: Add attributes for AMD GPU Tools

kzhuravl-AMD marked an inline comment as done. kzhuravl-AMD added a comment. http://reviews.llvm.org/D17764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17764: Add attributes for AMD GPU Tools

kzhuravl-AMD updated this revision to Diff 50067. kzhuravl-AMD added a comment. Aaron's Review Comments http://reviews.llvm.org/D17764 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def

r262960 - Silence duplicate diagnostics because parsing of a standards-based attribute triggers parsing diagnostics that may also be picked up during semantic analysis.

Author: aaronballman Date: Tue Mar 8 15:31:32 2016 New Revision: 262960 URL: http://llvm.org/viewvc/llvm-project?rev=262960=rev Log: Silence duplicate diagnostics because parsing of a standards-based attribute triggers parsing diagnostics that may also be picked up during semantic analysis.

Re: r262881 - P0188R1: add support for standard [[fallthrough]] attribute. This is almost

On Tue, Mar 8, 2016 at 2:10 PM, Richard Smith wrote: > On Tue, Mar 8, 2016 at 11:04 AM, Nico Weber wrote: > > On Tue, Mar 8, 2016 at 1:49 PM, Richard Smith > wrote: > >> > >> On Tue, Mar 8, 2016 at 9:05 AM, Nico Weber

Re: r262881 - P0188R1: add support for standard [[fallthrough]] attribute. This is almost

On Tue, Mar 8, 2016 at 11:04 AM, Nico Weber wrote: > On Tue, Mar 8, 2016 at 1:49 PM, Richard Smith wrote: >> >> On Tue, Mar 8, 2016 at 9:05 AM, Nico Weber wrote: >> > This causes clang to warn on >> > >> > default: assert

Re: r262881 - P0188R1: add support for standard [[fallthrough]] attribute. This is almost

On Tue, Mar 8, 2016 at 1:49 PM, Richard Smith wrote: > On Tue, Mar 8, 2016 at 9:05 AM, Nico Weber wrote: > > This causes clang to warn on > > > > default: assert (false); HB_FALLTHROUGH; > > What follows this? (A case label?) What warning is being

Re: r262881 - P0188R1: add support for standard [[fallthrough]] attribute. This is almost

On Tue, Mar 8, 2016 at 9:05 AM, Nico Weber wrote: > This causes clang to warn on > > default: assert (false); HB_FALLTHROUGH; What follows this? (A case label?) What warning is being produced? > The fallthrough needs to be there for release builds, but now it must not be

Re: [PATCH] D17947: [Driver] [Darwin] Fix linking libclang_rt.profile_*sim.a

beanz updated this revision to Diff 50055. beanz added a comment. Updates based on Anna's polite and restrained feedback that didn't include the appropriate comment "Why don't you fix your TODO?" (I did fix it this time). http://reviews.llvm.org/D17947 Files: lib/Driver/ToolChains.cpp

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

aaron.ballman added a comment. Missing some attribute-related tests like attaching the attribute to something other than a record, or passing arguments to the attribute. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8332 @@ +8331,3 @@ + "base %0 uses the stable

[PATCH] D17963: [OPENMP] Codegen for teams directive for NVPTX

carlo.bertolli created this revision. carlo.bertolli added reviewers: ABataev, fraggamuffin, kkwli0. carlo.bertolli added subscribers: sfantao, arpith-jacob, caomhin, cfe-commits. carlo.bertolli set the repository for this revision to rL LLVM. Herald added a subscriber: jholewinski. This patch

Re: [PATCH] D17959: Make it possible for AST plugins to enable themselves by default

john.brawn added a comment. Looking at http://reviews.llvm.org/D15729 I //think// there's no conflict between what this patch is doing and what that patch is doing. If a plugin returns AddBeforeMainAction or AddAfterMainAction then when ASTUnit in libclang loads that plugin it should get

Re: [PATCH] D16044: getVariableName() for MemRegion

Alexander_Droste added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:160 @@ -153,1 +159,3 @@ + /// \returns variable name for memory region + std::string getVariableName() const; }; dcoughlin wrote: > Alexander_Droste

Re: [Diffusion] rL244063: Add missing atomic libcall support.

dim resigned from this audit. Users: jyknight (Author, Auditor) 3.7-release (Auditor) cfe-commits (Auditor) tstellarAMD (Auditor) compnerd (Auditor) majnemer (Auditor) rsmith (Auditor) dim (Auditor) http://reviews.llvm.org/rL244063

Re: [Diffusion] rL244063: Add missing atomic libcall support.

dim accepted this commit. Users: jyknight (Author, Auditor) 3.7-release (Auditor) cfe-commits (Auditor) tstellarAMD (Auditor) compnerd (Auditor) majnemer (Auditor) rsmith (Auditor) dim (Auditor) http://reviews.llvm.org/rL244063 ___

Re: [PATCH] D17941: add fix-its for format-security warnings

bcraig added a comment. LGTM. I don't have a lot of authority over this code, so you may want to get a separate LGTM from someone else. http://reviews.llvm.org/D17941 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17941: add fix-its for format-security warnings

bob.wilson added a comment. In http://reviews.llvm.org/D17941#369698, @bcraig wrote: > What about wprintf? Do we currently warn for wprintf(str)? If so, then the > fixit probably needs to involve L"%ls". Darwin does not mark wprintf functions with an attribute. Linux (at least the version

Re: r262881 - P0188R1: add support for standard [[fallthrough]] attribute. This is almost

This causes clang to warn on default: assert (false); HB_FALLTHROUGH; The fallthrough needs to be there for release builds, but now it must not be there for debug builds. I suppose this means projects now need an UNREACHED_CASE macro that expands to assert(false) in debug and to fallthrough in

r262938 - Turning on the /bigobj flag for two more files that will not link with MSVC 2015 Win64 Debug due to the section limit.

Author: aaronballman Date: Tue Mar 8 10:34:37 2016 New Revision: 262938 URL: http://llvm.org/viewvc/llvm-project?rev=262938=rev Log: Turning on the /bigobj flag for two more files that will not link with MSVC 2015 Win64 Debug due to the section limit. Modified:

Re: [Diffusion] rL244063: Add missing atomic libcall support.

jyknight accepted this commit. jyknight added a comment. This issue was resolved; hopefully this will inform Phab of that. Users: jyknight (Author, Auditor) 3.7-release (Auditor) cfe-commits (Auditor) tstellarAMD (Auditor) compnerd (Auditor) majnemer (Auditor) rsmith (Auditor)

r262933 - Add Visual Studio native visualizers for several Clang types

Author: mps Date: Tue Mar 8 10:14:23 2016 New Revision: 262933 URL: http://llvm.org/viewvc/llvm-project?rev=262933=rev Log: Add Visual Studio native visualizers for several Clang types This is one of a series of changes to improve the MSVC visualization of Clang types. This one focuses on

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

sepavloff added a comment. I still cannot build project with your changes, now compiler cannot find symbol `hasSubStmt`. When committing the change please make sure that all prerequisites are committed and unit tests run successfully. I would recommend you to take tests from

[libcxx] r262932 - Remove a couple tabs that crept in

Author: marshall Date: Tue Mar 8 09:45:06 2016 New Revision: 262932 URL: http://llvm.org/viewvc/llvm-project?rev=262932=rev Log: Remove a couple tabs that crept in Modified: libcxx/trunk/test/std/strings/basic.string/string.ops/string.accessors/data.pass.cpp Modified:

[libcxx] r262931 - Implement P0272R1: Give 'std::string' a non-const '.data()' member function

Author: marshall Date: Tue Mar 8 09:44:30 2016 New Revision: 262931 URL: http://llvm.org/viewvc/llvm-project?rev=262931=rev Log: Implement P0272R1: Give 'std::string' a non-const '.data()' member function Modified: libcxx/trunk/include/string

Re: [PATCH] D17959: Make it possible for AST plugins to enable themselves by default

klimek added a reviewer: bkramer. klimek added a comment. +benjamin, who has done work in the area Repository: rL LLVM http://reviews.llvm.org/D17959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r262928 - Implement P0253R1: Fixing a design mistake in the searchers interface.

Author: marshall Date: Tue Mar 8 09:12:52 2016 New Revision: 262928 URL: http://llvm.org/viewvc/llvm-project?rev=262928=rev Log: Implement P0253R1: Fixing a design mistake in the searchers interface. Modified: libcxx/trunk/include/algorithm libcxx/trunk/include/experimental/algorithm

Re: [PATCH] D17955: [OpenCL] Fix pipe builtin bugs

Anastasia added a comment. Tests missing! http://reviews.llvm.org/D17955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D17959: Make it possible for AST plugins to enable themselves by default

john.brawn created this revision. john.brawn added reviewers: klimek, kfunk, milianw, rsmith. john.brawn added a subscriber: cfe-commits. john.brawn set the repository for this revision to rL LLVM. Currently when an AST plugin is loaded it must then be enabled by passing -plugin pluginname or

Re: [PATCH] D17955: [OpenCL] Fix piep builtin bug

MatsPetersson added a subscriber: MatsPetersson. MatsPetersson added a comment. Obvious typo in title. Pipe, not piep. http://reviews.llvm.org/D17955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17908: Add Visual Studio Visualizers for more Clang types

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM. thank you! http://reviews.llvm.org/D17908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D17955: [OpenCL] Fix piep builtin bug

pxli168 created this revision. pxli168 added reviewers: Anastasia, yaxunl. pxli168 added subscribers: cfe-commits, pekka.jaaskelainen. 1. Diag should be output if types are not the same. 2. Should compare using canonical type. 3. Refine the diag to be more clear. http://reviews.llvm.org/D17955

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki updated this revision to Diff 50032. danielmarjamaki added a comment. Updated documentation http://reviews.llvm.org/D15332 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/NonConstParameterCheck.cpp clang-tidy/readability/NonConstParameterCheck.h

r262922 - Bump libclang API version after r262318

Author: kfunk Date: Tue Mar 8 04:34:23 2016 New Revision: 262922 URL: http://llvm.org/viewvc/llvm-project?rev=262922=rev Log: Bump libclang API version after r262318 Modified: cfe/trunk/include/clang-c/Index.h Modified: cfe/trunk/include/clang-c/Index.h URL:

r262921 - Sema: Methods in unavailable classes are unavailable

Author: dexonsmith Date: Tue Mar 8 04:28:52 2016 New Revision: 262921 URL: http://llvm.org/viewvc/llvm-project?rev=262921=rev Log: Sema: Methods in unavailable classes are unavailable Similar to the template cases in r262050, when a C++ method in an unavailable struct/class calls unavailable

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki added inline comments. Comment at: test/clang-tidy/readability-non-const-parameter.cpp:3 @@ +2,3 @@ + +// Currently the checker only warns about pointer arguments. +// LegalizeAdulthood wrote: > danielmarjamaki wrote: > > LegalizeAdulthood wrote:

Re: [PATCH] D17226: libclang python bindings: Fix for bug 26394

skalinichev accepted this revision. skalinichev added a comment. This revision is now accepted and ready to land. Yes, I've seen that python tests segfaulted too, never had time to investigate it though. LGTM, great work! Repository: rL LLVM http://reviews.llvm.org/D17226

Re: [PATCH] D15469: Expose cxx constructor and method properties through libclang and python bindings.

skalinichev added a comment. Generally looks pretty good to me. Maybe it's worth to factor out duplicating code, but I guess it's not so important. Also the index-file.cpp test failing for me: test/Index/index-file.cpp:57:11: error: expected string not found in input // CHECK:

Re: [PATCH] D11797: [LIbClang] Report the named type for ElaboratedType

skalinichev updated the summary for this revision. skalinichev added reviewers: milianw, kfunk. skalinichev updated this revision to Diff 50027. skalinichev added a comment. Ok, after some more testing I found out that elaborated types can have cv specifiers attached, but after using