The patch'll need a test case (in clang/tests) - I've not looked at the
change/have much opinion there, just suggesting adding a test at minimum so
when someone does come to review it it's more complete/closer to/ready to
commit.
On Tue, May 17, 2016 at 9:23 PM, Taewook Oh via cfe-commits <
cfe-co
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good :-).
http://reviews.llvm.org/D19804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Author: rjmccall
Date: Wed May 18 00:21:18 2016
New Revision: 269880
URL: http://llvm.org/viewvc/llvm-project?rev=269880&view=rev
Log:
Various improvements to the public IRGen interface.
Modified:
cfe/trunk/include/clang/CodeGen/CodeGenABITypes.h
cfe/trunk/include/clang/CodeGen/ModuleBuil
apelete updated this revision to Diff 57560.
apelete added a comment.
[scan-build] fix dead store warnings emitted on clang code base
Changes since last revision:
- lib/Sema/SemaLookup.cpp: remove changes since they were already applied
upstream,
- lib/Sema/SemaExpr.cpp: move 'IsDereference' an
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20345
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
twoh created this revision.
twoh added reviewers: faisalv, rsmith.
twoh added a subscriber: cfe-commits.
(This is a fix for Bug 27797 https://llvm.org/bugs/show_bug.cgi?id=27797).
Currently when RebuildLambdaScopeInfo() function in lib/Sema/SemaDecl.cpp
observes lambda capturing 'this', it calls
Author: ctopper
Date: Tue May 17 23:11:25 2016
New Revision: 269879
URL: http://llvm.org/viewvc/llvm-project?rev=269879&view=rev
Log:
[Sema,CodeGen] Remove comment from SemaChecking about a builtin_shufflevector
form that it doesn't support. Remove CodeGen support for the same form since it
coul
Author: ctopper
Date: Tue May 17 22:18:12 2016
New Revision: 269878
URL: http://llvm.org/viewvc/llvm-project?rev=269878&view=rev
Log:
[X86] Add immediate range checks for many of the builtins.
This time allow -128 to 255 for builtins that use a char type immediate."
Modified:
cfe/trunk/inclu
On 17 May 2016 at 10:32, Renato Golin wrote:
> I don't think a small future ACLE builtin is on the same league as a whole
> new back-end. :)
Well yes, it's probably got orders of magnitude less bugs than the
backend for a start.
> Nor I think that having this when the docs are public, rather th
hintonda updated this revision to Diff 57555.
hintonda added a comment.
- Added another test.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/UseNoexcept
t.p.northover added a subscriber: t.p.northover.
t.p.northover accepted this revision.
t.p.northover added a reviewer: t.p.northover.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Looks pretty straightforward, go for it.
Tim.
http://reviews.llvm.org/D20283
_
hintonda updated this revision to Diff 57547.
hintonda added a comment.
- First cut on a simple parser for decls.
Successfully parses all the examples I've been given so far. Please
help me break it.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/mode
About to be away for a week, but I will take this up (and the other one) when I
get back.
--paulr
From: David Blaikie [mailto:dblai...@gmail.com]
Sent: Tuesday, May 17, 2016 3:05 PM
To: reviews+d19567+public+1ee0c82c0824b...@reviews.llvm.org; David Blaikie
Cc: Robinson, Paul; Aaron Ballman; Adria
jlebar added a comment.
> But people also don't expect IEEE compliance on GPUs
Is that true? You have a lot more experience with this than I do, but my
observation of nvidia's hardware is that it's moved to add *more* IEEE
compliance as it's matured. For example, older hardware didn't suppor
Author: chapuni
Date: Tue May 17 19:53:31 2016
New Revision: 269875
URL: http://llvm.org/viewvc/llvm-project?rev=269875&view=rev
Log:
findAllSymbols: Prune unused libdeps.
Modified:
clang-tools-extra/trunk/include-fixer/find-all-symbols/CMakeLists.txt
Modified: clang-tools-extra/trunk/includ
Author: chapuni
Date: Tue May 17 19:53:27 2016
New Revision: 269874
URL: http://llvm.org/viewvc/llvm-project?rev=269874&view=rev
Log:
FindAllSymbolsTests doesn't require clangToolingCore.
Modified:
clang-tools-extra/trunk/unittests/include-fixer/find-all-symbols/CMakeLists.txt
Modified:
cl
Author: chapuni
Date: Tue May 17 19:49:16 2016
New Revision: 269873
URL: http://llvm.org/viewvc/llvm-project?rev=269873&view=rev
Log:
include-fixer: They require clangLex.
Modified:
clang-tools-extra/trunk/include-fixer/find-all-symbols/CMakeLists.txt
clang-tools-extra/trunk/include-fixer
petarj created this revision.
petarj added a reviewer: atanasyan.
petarj added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
MIPS32 Android defaults to FPXX ("-fpxx").
MIPS32R6 Android defaults to FP64A ("-mfp64 -mno-odd-spreg").
http://reviews.llvm.org/D20
Author: chapuni
Date: Tue May 17 19:20:46 2016
New Revision: 269870
URL: http://llvm.org/viewvc/llvm-project?rev=269870&view=rev
Log:
IncludeFixerTest.cpp: Add explicit triple for some tests. They are failing for
targeting *-win32.
Modified:
clang-tools-extra/trunk/unittests/include-fixer/In
Author: rsmith
Date: Tue May 17 19:16:51 2016
New Revision: 269869
URL: http://llvm.org/viewvc/llvm-project?rev=269869&view=rev
Log:
Fix use-after-free ASan failures for modules / PCH files that deserialize
abi_tag or no_sanitize attributes.
Modified:
cfe/trunk/test/PCH/attrs.c
cfe/trunk
tra updated this revision to Diff 57541.
tra added a comment.
Added test case.
Is there a better way to test that correct options are passed to back-end?
This test resorts to checking assembly generated by back-end which is way too
far away from what actually needs testing.
http://reviews.llvm
tra updated this revision to Diff 57540.
tra added a comment.
Changed default to -ffp-contract=fast.
http://reviews.llvm.org/D20341
Files:
lib/Frontend/CompilerInvocation.cpp
Index: lib/Frontend/CompilerInvocation.cpp
===
--- li
tra added a comment.
OK. Consensus seems to be that -ffp-contract=fast is the way to go. I'll update
the patch.
I've just checked Steve's example with nvcc and indeed it fused mul+add.
http://reviews.llvm.org/D20341
___
cfe-commits mailing list
cfe
hfinkel added a comment.
In http://reviews.llvm.org/D20341#432525, @tra wrote:
> In http://reviews.llvm.org/D20341#432494, @hfinkel wrote:
>
> >
>
>
>
>
> > That having been said, is this change the equivalent of -ffp-contract=fast
> > or -ffp-contract=on? I think it is the latter and we want
scanon added a comment.
`-ffp-contract=on` obeys the semantics of C's FP_CONTRACT pragma. In
particular, it will not fuse:
float m = x*y;
float a = m + z;
Whereas you probably want that to fuse for your purposes. `-ffp-contract=fast`
seems more in line with your needs.
http://reviews.l
pcc added inline comments.
Comment at: test/CodeGenOpenCL/constant-addr-space-globals.cl:3
@@ -2,3 +2,3 @@
-// CHECK: @array = addrspace({{[0-9]+}}) constant
+// CHECK: @array = local_unnamed_addr addrspace({{[0-9]+}}) constant
__constant float array[2] = {0.0f, 1.0f};
tra added a comment.
In http://reviews.llvm.org/D20341#432494, @hfinkel wrote:
>
> That having been said, is this change the equivalent of -ffp-contract=fast or
> -ffp-contract=on? I think it is the latter and we want the former (i.e. where
> we let the backend be as aggressive as possible
tra added a subscriber: scanon.
tra added a comment.
Things are even more interesting. -ffp-contract=fast is *not* what this change
does. :-)
We have two places where we can fuse FP instructions -- in clang and in LLVM
back-end.
Clang fuses add+mul into llvm.fmuladd intrinsic if -ffp-contract=o
rsmith added a subscriber: rsmith.
Comment at: test/CodeGenOpenCL/constant-addr-space-globals.cl:3
@@ -2,3 +2,3 @@
-// CHECK: @array = addrspace({{[0-9]+}}) constant
+// CHECK: @array = local_unnamed_addr addrspace({{[0-9]+}}) constant
__constant float array[2] = {0.0f, 1.0f};
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Review comments resolved and committed as r269858.
Repository:
rL LLVM
http://reviews.llvm.org/D20302
___
cfe-commits mailing list
cfe-commits
hfinkel added a subscriber: hfinkel.
hfinkel added a comment.
In http://reviews.llvm.org/D20341#432461, @jlebar wrote:
> I am not sure we want this? Although it matches nvcc, it does not match our
> floating-point behavior for C++ in general -- it makes us non-IEEE-whatever
> compliant by defa
Forgot to mention in the commit message: this patch was collaboratively
produced by Vassil Vassilev and myself.
On Tue, May 17, 2016 at 3:44 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Tue May 17 17:44:15 2016
> New Revision: 269858
>
> URL: htt
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:39
@@ +38,3 @@
+
+ // FIXME: Add paren matching so we can parse more complex throw statements,
+ // e.g., (examples provided by Aaron Ballman):
aaron.ballman wrote:
> alexfh wrot
jlebar added a comment.
I am not sure we want this? Although it matches nvcc, it does not match our
floating-point behavior for C++ in general -- it makes us non-IEEE-whatever
compliant by default.
Although I agree that if we don't do this, lots of people are not going to pass
-fp-contract=fa
Author: rsmith
Date: Tue May 17 17:44:15 2016
New Revision: 269858
URL: http://llvm.org/viewvc/llvm-project?rev=269858&view=rev
Log:
PR27754: CXXRecordDecl::data() needs to perform an update even if it's called
on a declaration that already knows the location of the DefinitionData object.
Added:
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:39
@@ +38,3 @@
+
+ // FIXME: Add paren matching so we can parse more complex throw statements,
+ // e.g., (examples provided by Aaron Ballman):
alexfh wrote:
> aaron.ballm
tra created this revision.
tra added reviewers: jlebar, jingyue.
tra added a subscriber: cfe-commits.
This matches default nvcc behavior and gives substantial performance boost on
GPU where fmad is much cheaper compared to add+mul.
http://reviews.llvm.org/D20341
Files:
lib/Frontend/Compiler
There was an off list mail to me on this.
The 0-255 checks don't work for the builtins that take a char immediate and
char is signed. In that case the range change needs to be -128 to 127
instead of 0 to 255.
On Tue, May 17, 2016 at 3:09 PM, Sean Silva via cfe-commits <
cfe-commits@lists.llvm.org
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:39
@@ +38,3 @@
+
+ // FIXME: Add paren matching so we can parse more complex throw statements,
+ // e.g., (examples provided by Aaron Ballman):
aaron.ballman wrote:
> alexfh wrot
Author: rksimon
Date: Tue May 17 17:03:31 2016
New Revision: 269852
URL: http://llvm.org/viewvc/llvm-project?rev=269852&view=rev
Log:
[X86][SSE] Tidied up MMX/SSE/SSE2 builtin tests to the correct test file
Modified:
cfe/trunk/test/CodeGen/mmx-builtins.c
cfe/trunk/test/CodeGen/sse-builtin
On Tue, May 17, 2016 at 7:07 AM, Filipe Cabecinhas via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: filcab
> Date: Tue May 17 09:07:43 2016
> New Revision: 269765
>
> URL: http://llvm.org/viewvc/llvm-project?rev=269765&view=rev
> Log:
> Revert "[X86] Add immediate range checks for ma
On Tue, May 17, 2016 at 2:30 PM, Robinson, Paul
wrote:
> What you are describing is what testing literature refers to as criteria
> for equivalence classes. There is some level of judgment to that, yes.
>
>
>
> Yep yep, to be sure. I'm just generally trying to encourage the community
> behavior
ping
On Mon, May 2, 2016 at 11:51 AM, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> dblaikie added a comment.
>
> In http://reviews.llvm.org/D19567#414906, @probinson wrote:
>
> > Huh. There are strange interactions here, which makes me even more
> nervous about testing fe
pcc created this revision.
pcc added reviewers: rafael, majnemer.
pcc added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
http://reviews.llvm.org/D20339
Files:
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen
Author: rsmith
Date: Tue May 17 16:48:41 2016
New Revision: 269849
URL: http://llvm.org/viewvc/llvm-project?rev=269849&view=rev
Log:
Revert r269717. That change alone did not provide the intended benefit (which
would come from changing the type of ASTContext::DeclAttrs from
DenseMap to DenseMap),
cameron314 created this revision.
cameron314 added a reviewer: rsmith.
cameron314 added a subscriber: cfe-commits.
cameron314 set the repository for this revision to rL LLVM.
Remapped files would always cause the preamble's PCH to be invalidated (even if
they hadn't changed) because the file mana
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:39
@@ +38,3 @@
+
+ // FIXME: Add paren matching so we can parse more complex throw statements,
+ // e.g., (examples provided by Aaron Ballman):
alexfh wrote:
> hintonda wr
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:22
@@ +21,3 @@
+namespace {
+
+StringRef makeDynamicExceptionString(const SourceManager &SM,
It's much more common for LLVM code to use static functions:
http://llvm.org/docs/Codi
bcraig added a comment.
I'll be submitting this Friday morning, barring any objections (I'm out of the
office the next couple of days).
http://reviews.llvm.org/D17416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
bcraig updated this revision to Diff 57521.
bcraig marked 2 inline comments as done.
http://reviews.llvm.org/D17416
Files:
include/support/android/locale_bionic.h
include/support/newlib/xlocale.h
include/support/xlocale/__posix_l_fallback.h
include/support/xlocale/__strtonum_fallback.h
What you are describing is what testing literature refers to as criteria
for equivalence classes. There is some level of judgment to that, yes.
Yep yep, to be sure. I'm just generally trying to encourage the community
behavior towards being both selective & thorough about testing.
I have notice
bcraig updated this revision to Diff 57520.
http://reviews.llvm.org/D17416
Files:
include/support/android/locale_bionic.h
include/support/newlib/xlocale.h
include/support/xlocale/__posix_l_fallback.h
include/support/xlocale/__strtonum_fallback.h
include/support/xlocale/xlocale.h
Index:
Thanks Richard, I wouldn't have gotten that. One day I'll understand
locales.
On May 17, 2016 3:22 PM, "Richard Smith" wrote:
> Here's an istream_iterator test for this change:
>
> #include
> #include
> #include
>
> struct evil_traits : std::char_traits {
> template friend void operator&(T)
So, why are you doing this for more than just the avx512 headers? I
understand that you're unhappy with all of the intrinsics, but you've added
an incompatibility here for MS mode. Does MS use header guards locking off
particular intrinsics?
What "better intrinsic story" are you looking for? This
Here's an istream_iterator test for this change:
#include
#include
#include
struct evil_traits : std::char_traits {
template friend void operator&(T) = delete;
};
struct pointless_derived_class
: std::num_get> {};
int main() {
std::basic_stringstream ss("1 2 3");
ss.imbue(std::loca
kzhuravl retitled this revision from "[AMDGPU] Remove individual debugger
options" to "[AMDGPU] Remove individual debugger options + update features".
kzhuravl updated this revision to Diff 57518.
kzhuravl added a comment.
Update features
http://reviews.llvm.org/D20336
Files:
include/clang/D
alexfh added a comment.
In http://reviews.llvm.org/D19105#427046, @Prazek wrote:
> In http://reviews.llvm.org/D19105#426903, @alexfh wrote:
>
> > returning a bool from a function that is declared to return a typedef to an
> > integral type that contains `bool` in its name (e.g. `LLVMBool`), and
OK, I think I figured it out. I added tests for the ostream_iterator
constructors in r269838.
I'll follow that up with tests for the istream_iterator constructors, but
my current test is failing for reasons beyond me.
/Eric
On Tue, May 17, 2016 at 2:36 PM, Eric Fiselier wrote:
> Or maybe I'm st
Author: ericwf
Date: Tue May 17 16:01:20 2016
New Revision: 269838
URL: http://llvm.org/viewvc/llvm-project?rev=269838&view=rev
Log:
Test hijacking ADL for operator& in the stream iterator constructors.
Modified:
libcxx/trunk/test/std/iterators/stream.iterators/ostream.iterator/ostream.itera
kzhuravl created this revision.
kzhuravl added a reviewer: arsenm.
kzhuravl added subscribers: whchung, cfe-commits.
Herald added a reviewer: tstellarAMD.
Herald added a subscriber: kzhuravl.
http://reviews.llvm.org/D20336
Files:
include/clang/Driver/Options.td
test/Driver/amdgpu-features.c
Cool :) don't the sweat the time. I was just a little excited. Small patch
but it's nice to get started somewhere.
Best regards,
Mads Ravn
> On May 17, 2016, at 2:59 AM, Mads Ravn wrote:
>
> Hi guys,
>
> I just wanted to check up on this patch. I heard I could just reply to
this mail and see if
rsmith added a comment.
Please also add some testcases for the corresponding case for a friend function
template:
template void f();
template struct A {
template void f() {}
};
template struct B {
template void f() {}
};
A a;
B b; // ill-formed
Comment at
Or maybe I'm still wrong. I tried using a custom traits class to hijack ADL
for "operator&" but it doesn't seem to work.
Sorry for the spam.
/Eric
On Tue, May 17, 2016 at 2:25 PM, Eric Fiselier wrote:
> Woops. I was incorrect. It seems that user defined "operator&" overloads
> can be found in
Woops. I was incorrect. It seems that user defined "operator&" overloads
can be found in the constructor. From the LWG issue:
> Note that {i,o}stream_type are specializations of basic_{i,o}stream, but
the constructors might still pick up an overloaded & via the traits
template parameter.
At least
On Tue, May 17, 2016 at 10:17 AM, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, May 16, 2016 at 3:53 PM, Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rsmith
>> Date: Mon May 16 17:53:19 2016
>> New Revision: 269717
>>
>> URL: http
yaxunl added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7820
@@ +7819,3 @@
+def err_opencl_function_not_supported : Error<
+ "this function is not supported in this version of CL">;
+def err_opencl_enqueue_kernel_incorrect_args : Error<
--
The difference between "operator&" and "addressof" is inconsequential when
user defined overloads of "operator&" can't be found, which is the case for
the changes in the stream iterator constructors. We might as well keep it
consistent though. I don't see any value changing it back to use
"operato
If some parts are not testable & as you say, not meaningful, then it seems
OK to just not implement them & file a DR on the standard, no?
On Tue, May 17, 2016 at 1:00 PM, Eric Fiselier wrote:
> I added a test for operator->() in r269812. Marshall and I discussed
> offline about how not all parts
I added a test for operator->() in r269812. Marshall and I discussed
offline about how not all parts of this change are testable (and hence not
meaningful) but that's what the standard says to do.
On Tue, May 17, 2016 at 1:51 PM, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
Author: ericwf
Date: Tue May 17 14:52:32 2016
New Revision: 269812
URL: http://llvm.org/viewvc/llvm-project?rev=269812&view=rev
Log:
Add test for r269789
Modified:
libcxx/trunk/test/std/iterators/stream.iterators/istream.iterator/istream.iterator.ops/arrow.pass.cpp
Modified:
libcxx/trunk/t
Test coverage?
On Tue, May 17, 2016 at 10:44 AM, Marshall Clow via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: marshall
> Date: Tue May 17 12:44:40 2016
> New Revision: 269789
>
> URL: http://llvm.org/viewvc/llvm-project?rev=269789&view=rev
> Log:
> Implement LWG2576: istream_itera
Author: jvesely
Date: Tue May 17 14:44:01 2016
New Revision: 269807
URL: http://llvm.org/viewvc/llvm-project?rev=269807&view=rev
Log:
math: Use single precision fmax in sp path
Fixes fdim piglit on Turks
v2: use CL fmax instead of __builtin
Signed-off-by: Jan Vesely
Reviewed-by: Tom Stellard
Author: etienneb
Date: Tue May 17 14:36:09 2016
New Revision: 269804
URL: http://llvm.org/viewvc/llvm-project?rev=269804&view=rev
Log:
[clang-tidy] Lift common matchers to utils namespace
Summary:
This patch is lifting matchers used by more than one checkers
to the common namespace.
Reviewers: a
ahatanak created this revision.
ahatanak added reviewers: mclow.lists, EricWF, howard.hinnant.
ahatanak added a subscriber: cfe-commits.
The end pointer should point to one past the end of the newly allocated buffer.
Without this fix, asan reports an error when the following code is compiled and
rsmith added inline comments.
Comment at: include/clang/Basic/BuiltinsNVPTX.def:569-603
@@ -568,1 +568,37 @@
+// __ldg. This is not implemented as a builtin by nvcc.
+BUILTIN(__nvvm_ldg_c, "ccC*", "")
+BUILTIN(__nvvm_ldg_s, "ssC*", "")
+BUILTIN(__nvvm_ldg_i, "iiC*", "")
+BUILTI
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: docs/clang-tidy/checks/bugprone-bool-to-integer-conversion.rst:43
@@ +42,3 @@
+
+This is because z and ``true`` will be implicitly converted to int by
promotion.
+To get rid of t
Author: yrnkrn
Date: Tue May 17 14:01:16 2016
New Revision: 269801
URL: http://llvm.org/viewvc/llvm-project?rev=269801&view=rev
Log:
Teach clang to look for libcxx in /usr/local/include/c++ on Linux
As The default CMAKE install prefix is /usr/local (
https://cmake.org/cmake/help/v3.0/variable/CM
aaron.ballman added inline comments.
Comment at: clang-tidy/utils/Matchers.h:20
@@ -19,1 +19,3 @@
+AST_MATCHER_P(Expr, ignoringImplicit,
+ ast_matchers::internal::Matcher, InnerMatcher) {
alexfh wrote:
> Consider moving this to ASTMatchers.h in a fo
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thank you!
Comment at: clang-tidy/utils/Matchers.h:20
@@ -19,1 +19,3 @@
+AST_MATCHER_P(Expr, ignoringImplicit,
+ ast_matchers::internal::Matcher, InnerMatch
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24
@@ +23,3 @@
+// FIXME: Add a node matcher for UnresolvedLookupExpr in ASTMatcher.
+AST_MATCHER(CallExpr, hasUnresolvedLookupExpr) {
+
ashi1 added a comment.
Xiuli, are you OK with this patch?
http://reviews.llvm.org/D17578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269796: clang-rename: avoid StringRef members in
USRLocFindingASTVisitor (authored by vmiklos).
Changed prior to commit:
http://reviews.llvm.org/D20296?vs=57385&id=57503#toc
Repository:
rL LLVM
http
Author: vmiklos
Date: Tue May 17 13:17:16 2016
New Revision: 269796
URL: http://llvm.org/viewvc/llvm-project?rev=269796&view=rev
Log:
clang-rename: avoid StringRef members in USRLocFindingASTVisitor
Even if this is defined in the .cpp file and only used as part of the
function (so here it's safe)
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Thanks, lgtm!
http://reviews.llvm.org/D20171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: mren
Date: Tue May 17 13:04:38 2016
New Revision: 269794
URL: http://llvm.org/viewvc/llvm-project?rev=269794&view=rev
Log:
NFC: simplify logic.
Modified:
cfe/trunk/lib/Lex/HeaderSearch.cpp
Modified: cfe/trunk/lib/Lex/HeaderSearch.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trun
aaron.ballman added a comment.
The patch is missing semantic test cases. I would like to see tests of the
attribute being accepted, as well as rejected because the subject was
incorrect, args were provided, etc.
Also, I believe there are attributes which this attribute should not be
combined w
Author: marshall
Date: Tue May 17 12:44:40 2016
New Revision: 269789
URL: http://llvm.org/viewvc/llvm-project?rev=269789&view=rev
Log:
Implement LWG2576: istream_iterator and ostream_iterator should use
std::addressof
Modified:
libcxx/trunk/include/iterator
libcxx/trunk/www/cxx1z_status.
jlebar added a comment.
Friendly ping. This is a big help with some Tensorflow benchmarks.
http://reviews.llvm.org/D19990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:39
@@ +38,3 @@
+
+ // FIXME: Add paren matching so we can parse more complex throw statements,
+ // e.g., (examples provided by Aaron Ballman):
aaron.ballman wrote:
> @alexfh,
Author: rnk
Date: Tue May 17 12:33:31 2016
New Revision: 269787
URL: http://llvm.org/viewvc/llvm-project?rev=269787&view=rev
Log:
Fix line numbers in calling convention test
Modified:
cfe/trunk/test/Sema/callingconv-cast.c
Modified: cfe/trunk/test/Sema/callingconv-cast.c
URL:
http://llvm.or
> On May 17, 2016, at 2:59 AM, Mads Ravn wrote:
>
> Hi guys,
>
> I just wanted to check up on this patch. I heard I could just reply to this
> mail and see if I could 'ping' anyone in this regard. Hope it's OK.
Sorry for the delay! This looks good. Committed as r269786.
thanks,
vedant
>
>
rengolin added inline comments.
Comment at: include/clang/Basic/BuiltinsARM.def:55
@@ -54,3 +54,3 @@
BUILTIN(__builtin_arm_mrc2, "UiUIiUIiUIiUIiUIi", "")
-BUILTIN(__builtin_arm_cdp, "vUiUiUiUiUiUi", "")
-BUILTIN(__builtin_arm_cdp2, "vUiUiUiUiUiUi", "")
+BUILTIN(__builtin_arm_cdp,
Author: vedantk
Date: Tue May 17 12:26:02 2016
New Revision: 269786
URL: http://llvm.org/viewvc/llvm-project?rev=269786&view=rev
Log:
[clang-tidy] Skip misc-macro-parentheses for namespaces (Fix PR27400)
If a use of a macro argument is preceded by the `namespace` keyword, do
not warn that the use
rengolin added a comment.
In http://reviews.llvm.org/D20325#432086, @t.p.northover wrote:
> I don't think we need to wait until the document is public, necessarily. The
> entire AArch64 backend went in before the encodings were public outside ARM
> (except maybe in binutils source?) and releasi
t.p.northover added a subscriber: t.p.northover.
t.p.northover added a comment.
I don't think we need to wait until the document is public, necessarily. The
entire AArch64 backend went in before the encodings were public outside ARM
(except maybe in binutils source?) and releasing specifications
On Mon, May 16, 2016 at 3:53 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Mon May 16 17:53:19 2016
> New Revision: 269717
>
> URL: http://llvm.org/viewvc/llvm-project?rev=269717&view=rev
> Log:
> Switch from SmallVector to TinyPtrVector for the li
mprobst updated this revision to Diff 57497.
mprobst marked 8 inline comments as done.
mprobst added a comment.
- address review comments
http://reviews.llvm.org/D20198
Files:
include/clang/Format/Format.h
lib/Format/CMakeLists.txt
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Fo
mprobst added a comment.
PTAL.
Comment at: lib/Format/SortJavaScriptImports.cpp:45-46
@@ +44,4 @@
+
+struct JsImportExport {
+ bool IsExport;
+ // JS imports are sorted into these categories, in order.
klimek wrote:
> klimek wrote:
> > This is really weird - a
Author: rnk
Date: Tue May 17 11:54:40 2016
New Revision: 269781
URL: http://llvm.org/viewvc/llvm-project?rev=269781&view=rev
Log:
Fix calling convention test
Modified:
cfe/trunk/test/Sema/callingconv-cast.c
Modified: cfe/trunk/test/Sema/callingconv-cast.c
URL:
http://llvm.org/viewvc/llvm-pr
hokein marked an inline comment as done.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24
@@ +23,3 @@
+AST_MATCHER(CallExpr, hasUnresolvedLookupExpr) {
+ return isa(Node.getCallee());
+}
alexfh wrote:
> I think, we should use a node matcher for `Unresolve
1 - 100 of 155 matches
Mail list logo
