[PATCH] D21724: [RFC] Enhance synchscope representation (clang)

kzhuravl created this revision. kzhuravl added reviewers: tstellarAMD, arsenm, rampitec. kzhuravl added subscribers: cfe-commits, llvm-commits, resistor. As described in this proposal: https://groups.google.com/forum/#!topic/llvm-dev/GtWfCc5j-4U http://reviews.llvm.org/D21724 Files: lib/CodeG

Re: [gentoo-musl] Re: Add support for musl-libc on Linux

2016-06-24 16:02 GMT+08:00 Peter Smith : > Hello Lei, > > They look good enough for me. Unless anyone else has any objections I > think you are good to go. I just see them committed by r273735 in clang and r273726 in LLVM. Peter, thank you for the comments; and Rafael, thank you for committing th

Re: [PATCH] D21367: AMDGPU: Set amdgpu_kernel calling convention for OpenCL kernels.

tstellarAMD added a comment. This seems OK to me. http://reviews.llvm.org/D21367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21659: AMDGPU: Add builtin to read exec mask

tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D21659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D21718: [libcxx] [test] Make move_assign_noexcept.pass.cpp tests more portable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make move_assign_noexcept.pass.cpp tests more portable. Note that the relevant wording here was modified by C++17 N4258 "Cleaning-up noexcept in the Library (Rev 3)", which MS

[PATCH] D21717: [libcxx] [test] Make dtor_noexcept.pass.cpp tests more portable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make dtor_noexcept.pass.cpp tests more portable. They were static_asserting that in certain situations, the following things have throwing destructors: ordered/unordered asso

[PATCH] D21716: [libcxx] [test] Make move_noexcept.pass.cpp tests more portable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make move_noexcept.pass.cpp tests more portable. They were static_asserting that the following things are nothrow-move-constructible: ordered/unordered associative containers

[PATCH] D21715: [libcxx] [test] Make default_noexcept.pass.cpp tests more portable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make default_noexcept.pass.cpp tests more portable. They were static_asserting that the following things are nothrow-default-constructible: ordered/unordered associative cont

[PATCH] D21714: [libcxx] [test] In atomics.types.generic/address.pass.cpp, use T(0) for consistency.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. In atomics.types.generic/address.pass.cpp, use T(0) for consistency. Fixes MSVC "error C2593: 'operator ==' is ambiguous". There is almost certainly an MSVC compiler bug invol

[PATCH] D21713: [libcxx] [test] Use L"cat" L"dog" when concatenating string literals.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Use L"cat" L"dog" when concatenating string literals. MSVC dislikes seeing L"23" "\x65F6". It's actually unclear to me what the Standard says here - I suspect that MSVC is cor

[PATCH] D21712: [libcxx] [test] Avoid narrowing conversions in quoted.pass.cpp.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Avoid narrowing conversions in quoted.pass.cpp. According to the Standard, when char has a signed range and wchar_t has an unsigned range, brace-init has to reject the potenti

r273760 - Fix bad test expectation.

Author: pcc Date: Fri Jun 24 19:37:14 2016 New Revision: 273760 URL: http://llvm.org/viewvc/llvm-project?rev=273760&view=rev Log: Fix bad test expectation. Modified: cfe/trunk/test/CodeGenCXX/type-metadata.cpp Modified: cfe/trunk/test/CodeGenCXX/type-metadata.cpp URL: http://llvm.org/viewvc

r273757 - CodeGen: Start emitting checked loads when both trapping CFI and -fwhole-program-vtables are enabled.

Author: pcc Date: Fri Jun 24 19:24:06 2016 New Revision: 273757 URL: http://llvm.org/viewvc/llvm-project?rev=273757&view=rev Log: CodeGen: Start emitting checked loads when both trapping CFI and -fwhole-program-vtables are enabled. Differential Revision: http://reviews.llvm.org/D21122 Modified:

Re: [PATCH] D21122: CodeGen: Start emitting checked loads when both trapping CFI and -fwhole-program-vtables are enabled.

This revision was automatically updated to reflect the committed changes. Closed by commit rL273757: CodeGen: Start emitting checked loads when both trapping CFI and -fwhole… (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D21122?vs=60006&id=61864#toc Repository: rL LLVM

[PATCH] D21708: [libcxx] fix compiler warning of autological-constant-out-of-range-compare

weimingz created this revision. weimingz added a subscriber: cfe-commits. warning: comparison of constant -2147483648 with expression of type 'long' (range [-2147483648, 2147483647]) is always false [-Wtautological-constant-out-of-range-compare] As int and long maybe the same size on most archi

r273754 - Implement C++17 P0386R2, inline variables. (The 'inline' specifier gives a

Author: rsmith Date: Fri Jun 24 19:15:56 2016 New Revision: 273754 URL: http://llvm.org/viewvc/llvm-project?rev=273754&view=rev Log: Implement C++17 P0386R2, inline variables. (The 'inline' specifier gives a variable weak discardable linkage and partially-ordered initialization, and is implied for

Re: [PATCH] D21706: [libcxx] refactor for throw or assert

EricWF added a subscriber: EricWF. EricWF added reviewers: mclow.lists, EricWF. EricWF added a comment. We actually have a non-macro that does this. It's called `__libcpp_throw` and it lives in ``. Please use that instead. http://reviews.llvm.org/D21706 __

Re: [PATCH] D21706: [libcxx] refactor for throw or assert

weimingz added a comment. Before replacing all throw/assert to macros, let's first check if we're on the right path. http://reviews.llvm.org/D21706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D21706: [libcxx] refactor for throw or assert

weimingz created this revision. weimingz added reviewers: rmaprath, grandinj. weimingz added a subscriber: cfe-commits. Add macros to wrapper for throw or assert. http://reviews.llvm.org/D21706 Files: include/__config include/__locale include/array include/experimental/optional include

Re: [PATCH] D21542: CodeGen: Replace test/CodeGen/thinlto_backend.c with a functional test.

echristo added a comment. OK, that works for me. :) Repository: rL LLVM http://reviews.llvm.org/D21542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21705: Include debug info for nested structs and classes

amccarth created this revision. amccarth added a reviewer: rnk. amccarth added a subscriber: cfe-commits. This includes nested types in the member list, even if there are no members of that type. Note that structs and classes have themselves as an "implicit struct" as the first member, so we sk

Re: [PATCH] D21542: CodeGen: Replace test/CodeGen/thinlto_backend.c with a functional test.

pcc added a comment. This is testing a clang feature that reads IR and runs the ThinLTO backend. This feature is part of ThinLTO's distributed build support (search for "Distributed Build Support" in http://blog.llvm.org/2016/06/thinlto-scalable-and-incremental-lto.html). In a future change I

Re: [PATCH] D21337: [CUDA] Give templated device functions internal linkage, templated kernels external linkage.

jlebar added a comment. Friendly ping. http://reviews.llvm.org/D21337 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra updated this revision to Diff 61851. sivachandra added a comment. Improve global type handling. http://reviews.llvm.org/D21666 Files: include/clang/Tooling/Core/QualTypeNames.h lib/Tooling/Core/QualTypeNames.cpp unittests/Tooling/QualTypeNamesTest.cpp Index: unittests/Tooling

Re: [PATCH] D21542: CodeGen: Replace test/CodeGen/thinlto_backend.c with a functional test.

echristo added a subscriber: echristo. echristo added a comment. Why is this in clang rather than in llvm? Repository: rL LLVM http://reviews.llvm.org/D21542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: r273694 - clang-format: [JS] Fix build breakage.

Yes, test breakage. The problem was that with the change fields and interfaces would still get incorrectly formatted (see also the comment on the diff). Will include it in the commit message next time. Daniel Jasper schrieb am Fr., 24. Juni 2016 um 14:43 Uhr: > The patch description seems wrong

Re: r273694 - clang-format: [JS] Fix build breakage.

The patch description seems wrong as this doesn't fix a build breakage AFAICT. Do you mean a test failure? If so, it would be helpful to #include what's actually changing (before/after or calling out the failing test case or something). On Fri, Jun 24, 2016 at 7:45 PM, Martin Probst via cfe-commi

r273735 - Add support for musl-libc on ARM Linux.

Author: rafael Date: Fri Jun 24 16:35:06 2016 New Revision: 273735 URL: http://llvm.org/viewvc/llvm-project?rev=273735&view=rev Log: Add support for musl-libc on ARM Linux. Patch by Lei Zhang! Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/lib/CodeGen/TargetInfo.cpp cfe/trunk/li

Re: [PATCH] D19770: Add FixedSizeStorage to TrailingObjects; NFC

hubert.reinterpretcast added inline comments. Comment at: include/llvm/Support/TrailingObjects.h:363 @@ +362,3 @@ +template struct with_counts { + enum { Size = totalSizeToAlloc(Counts...) }; + typedef llvm::AlignedCharArray< @aaron.ballman; my atte

Re: [PATCH] D19770: Add FixedSizeStorage to TrailingObjects; NFC

hubert.reinterpretcast updated this revision to Diff 61844. hubert.reinterpretcast added a comment. Reapply r273664 with workaround for MSVC http://reviews.llvm.org/D19770 Files: include/llvm/Support/TrailingObjects.h Index: include/llvm/Support/TrailingObjects.h

Re: [PATCH] D19770: Add FixedSizeStorage to TrailingObjects; NFC

hubert.reinterpretcast marked 6 inline comments as done. hubert.reinterpretcast added a comment. http://reviews.llvm.org/D19770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21054: CodeGen: Update Clang to use the new type metadata.

This revision was automatically updated to reflect the committed changes. Closed by commit rL273730: CodeGen: Update Clang to use the new type metadata. (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D21054?vs=59821&id=61842#toc Repository: rL LLVM http://reviews.llvm.o

r273730 - CodeGen: Update Clang to use the new type metadata.

Author: pcc Date: Fri Jun 24 16:21:46 2016 New Revision: 273730 URL: http://llvm.org/viewvc/llvm-project?rev=273730&view=rev Log: CodeGen: Update Clang to use the new type metadata. Differential Revision: http://reviews.llvm.org/D21054 Added: cfe/trunk/test/CodeGenCXX/lto-visibility-inferenc

[PATCH] D21700: [SemaExpr] Support lax conversions in assignments with vector and scalars with same size

bruno created this revision. bruno added reviewers: rnk, rsmith. bruno added a subscriber: cfe-commits. Before r266366, clang used to support constructs like: typedef __attribute__((vector_size(8))) double float64x1_t; typedef __attribute__((vector_size(16))) double float64x2_t; float64x1_t

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra added a comment. PTAL Comment at: lib/Tooling/Core/QualTypeNames.cpp:435 @@ -399,1 +434,3 @@ + // Create a nested name specifier if needed. Prefix = createNestedNameSpecifierForScopeOf(Ctx, QT.getTypePtr(), + true /*F

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra updated this revision to Diff 61837. sivachandra added a comment. Address comments. http://reviews.llvm.org/D21666 Files: include/clang/Tooling/Core/QualTypeNames.h lib/Tooling/Core/QualTypeNames.cpp unittests/Tooling/QualTypeNamesTest.cpp Index: unittests/Tooling/QualTypeNam

Re: [PATCH] D21617: [OpenMP] Diagnose missing cases of statements between target and teams directives

davidsh updated this revision to Diff 61830. davidsh added a comment. Address a comment. http://reviews.llvm.org/D21617 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/nesting_of_regions.cpp Index: test/OpenMP/nesting_of_regions.cpp ==

[PATCH] D21698: [OpenCL] Allow user to add supported OpenCL extensions by pragma

yaxunl created this revision. yaxunl added a reviewer: Anastasia. yaxunl added subscribers: cfe-commits, bader, pxli168, tstellarAMD. Allow user to use pragma to add supported extensions: #pragma OPENCL EXTENSION the_new_extension_name : register After that, users can use #pragma OPENCL EXT

Re: [PATCH] D21676: clang-rename: add a -s (suffix) option

vmiklos updated this revision to Diff 61833. vmiklos added a comment. This version solves the problem outline in the commit message by implementing an -export-fixes commandline option, quite similar to clang-tidy's matching option. http://reviews.llvm.org/D21676 Files: clang-rename/tool/Cla

r273714 - [CMake] Remove CLANG_APPEND_VC_REV option

Author: cbieneman Date: Fri Jun 24 15:21:12 2016 New Revision: 273714 URL: http://llvm.org/viewvc/llvm-project?rev=273714&view=rev Log: [CMake] Remove CLANG_APPEND_VC_REV option I added this option in r257827 to try and add compatibility with autoconf. At the time I misunderstood the problem. O

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra added inline comments. Comment at: lib/Tooling/Core/QualTypeNames.cpp:405 @@ -398,3 +404,3 @@ // is not the global scope. Prefix = createNestedNameSpecifierForScopeOf(Ctx, QT.getTypePtr(), true /*FullyQualified*/);

Re: [PATCH] D21601: Make tooling::applyAllReplacements return llvm::Expected instead of empty string to indicate potential error.

ioeric updated this revision to Diff 61823. ioeric added a comment. - Addressed reviewer's comments http://reviews.llvm.org/D21601 Files: include/clang/Format/Format.h include/clang/Tooling/Core/Replacement.h lib/Format/Format.cpp lib/Tooling/Core/Replacement.cpp lib/Tooling/Refactori

Re: [PATCH] D21602: Changes related to tooling::applyAllReplacements interface change in D21601.

ioeric updated this revision to Diff 61824. ioeric added a comment. - Addressed reviewer's recomments in the other patch. http://reviews.llvm.org/D21602 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixer.h include-fixer/tool/ClangIncludeFixer.cpp unittests/clang-tidy/Clang

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra updated this revision to Diff 61821. sivachandra added a comment. A little adjustment. http://reviews.llvm.org/D21666 Files: include/clang/AST/NestedNameSpecifier.h include/clang/Tooling/Core/QualTypeNames.h lib/AST/NestedNameSpecifier.cpp lib/Tooling/Core/QualTypeNames.cpp

Re: [PATCH] D20428: Tracking exception specification source locations

On Fri, Jun 24, 2016 at 10:30 AM, Aaron Ballman wrote: > On Fri, Jun 24, 2016 at 8:39 AM, Richard Smith wrote: >> rsmith added a comment. >> >> Ah right, we were (intentionally, but unfortunately) making an assumption >> that the `TypeLoc` data layout doesn't change when the exception spec of a

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

Anastasia added inline comments. Comment at: include/clang/AST/BuiltinTypes.def:164 @@ +163,3 @@ +// Internal OpenCL sampler initializer type. +BUILTIN_TYPE(OCLSamplerInit, OCLSamplerInitTy) + yaxunl wrote: > Anastasia wrote: > > I can't get why is this necessary

Re: [PATCH] D20249: [OpenCL] Hierarchical/dynamic parallelism - enqueue kernel in OpenCL 2.0

Anastasia marked 4 inline comments as done. Comment at: lib/Sema/SemaChecking.cpp:145 @@ +144,3 @@ +} + +/// OpenCL v2.0, s6.13.17.1 - Check that sizes are provided for all I think the problem is that in C99 there are implicit casts among integer types, therefore

Re: [PATCH] D21289: [ubsan] Version names of handlers

filcab abandoned this revision. filcab added a comment. Replaced by http://reviews.llvm.org/D21695 http://reviews.llvm.org/D21289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21695: [clang] Version support for UBSan handlers

filcab created this revision. filcab added reviewers: kcc, samsonov, rsmith. filcab added a subscriber: cfe-commits. This adds a way for us to version any UBSan handler by itself. The patch overrides D21289 for a better implementation (we're able to rev up a single handler). After this, then we c

Re: [PATCH] D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 273705. Repository: rL LLVM http://reviews.llvm.org/D21564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D20249: [OpenCL] Hierarchical/dynamic parallelism - enqueue kernel in OpenCL 2.0

Anastasia updated this revision to Diff 61816. Anastasia added a comment. Addressed Alexey's comments: - Removed redundant checks; - Improved diagnostics of parameters to blocks and sizes of block parameters; - Handled casting of integer types for specifying sizes of block parameters; http://re

Re: LLVM buildmaster is not working currently

Hello, Master was down per hardware issues. Back to work now. Thanks Galina On Fri, Jun 24, 2016 at 10:35 AM, Galina Kistanova wrote: > Hello everyone, > > LLVM buildmaster is not working currently for not clear reason. > I try to restore it ASAP. > > Builders owners could use our public sile

Re: [llvm-dev] [RFC] Embedded bitcode and related upstream (Part II)

> On Jun 14, 2016, at 3:27 PM, Eric Christopher wrote: > > > > On Mon, Jun 13, 2016 at 9:37 AM Steven Wu > wrote: > Thanks for the feedback! Replies inline. > >> On Jun 12, 2016, at 11:44 PM, Eric Christopher > > wrote: >> >> Hi Steven,

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

rnk added inline comments. Comment at: lib/AST/NestedNameSpecifier.cpp:50 @@ +49,3 @@ + + NestedNameSpecifier *P = const_cast(Specifier); + while (P->getPrefix() != nullptr) { Doesn't this mutate the AST in place? We shouldn't be doing that. Co

Re: [PATCH] D21673: [libcxx] guard throw with exception enabling check

This revision was automatically updated to reflect the committed changes. Closed by commit rL273697: [libcxx] guard throw with exception enabling check (authored by weimingz). Changed prior to commit: http://reviews.llvm.org/D21673?vs=61755&id=61813#toc Repository: rL LLVM http://reviews.ll

[libcxx] r273697 - [libcxx] guard throw with exception enabling check

Author: weimingz Date: Fri Jun 24 13:02:27 2016 New Revision: 273697 URL: http://llvm.org/viewvc/llvm-project?rev=273697&view=rev Log: [libcxx] guard throw with exception enabling check Summary: this fixes build error when built with c++14 and no exceptions Reviewers: rmaprath Subscribers: weim

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

saugustine accepted this revision. saugustine added a comment. This revision is now accepted and ready to land. This looks good and useful to me on the Tooling/Core side, but someone more familiar with the internals of NestedNamesSpecifiers should sign off on that portion. Also, I would probabl

Re: [PATCH] D21691: clang-format: [JS] Fix build breakage.

mprobst added a comment. Sorry, my automated test run somehow didn't fail, and so I implemented your suggestion which actually did break formatting. Could you post-commit review this? It's already committed to fix the build. http://reviews.llvm.org/D21691 ___

[PATCH] D21691: clang-format: [JS] Fix build breakage.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. Checking Line.MustBeDeclaration does actually break the field and param initializer use case. http://reviews.llvm.org/D21691 Files: lib/Format/TokenAnn

r273694 - clang-format: [JS] Fix build breakage.

Author: mprobst Date: Fri Jun 24 12:45:13 2016 New Revision: 273694 URL: http://llvm.org/viewvc/llvm-project?rev=273694&view=rev Log: clang-format: [JS] Fix build breakage. Checking Line.MustBeDeclaration does actually break the field and param initializer use case. Modified: cfe/trunk/lib/

LLVM buildmaster is not working currently

Hello everyone, LLVM buildmaster is not working currently for not clear reason. I try to restore it ASAP. Builders owners could use our public silent master as temporally solution. Silent buildbot is currently copy of llvm buildbot, but does not sent any notifications. The both have the same set

Re: [PATCH] D20561: Warn when taking address of packed member

aaron.ballman added a comment. In http://reviews.llvm.org/D20561#466545, @rogfer01 wrote: > Ping? Any further comments, thoughts? > > Thank you very much. The usual practice is to ping after a week has gone by, btw. There were standards meetings this week, so that may be delaying some of the c

Re: [PATCH] D21682: DeadStoresChecker: Don't warn about dead stores into volatile variables

zaks.anna added a comment. Thanks!!! http://reviews.llvm.org/D21682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21673: [libcxx] guard throw with exception enabling check

rmaprath added a comment. In http://reviews.llvm.org/D21673#466544, @weimingz wrote: > It's a good idea. Currently, there are about 600+ "throws" being > guarded by _LIBCPP_NO_EXCEPTIONS macro. > > How about let's merge the patch now and I can do the conversion of > existing code to the wrap

Re: [PATCH] D21295: Add a negative TBAA test

rogfer01 added a comment. Ping? Thank you very much! http://reviews.llvm.org/D21295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 added a comment. Ping? Any further comments, thoughts? Thank you very much. http://reviews.llvm.org/D20561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21673: [libcxx] guard throw with exception enabling check

weimingz added a subscriber: weimingz. weimingz added a comment. It's a good idea. Currently, there are about 600+ "throws" being guarded by _LIBCPP_NO_EXCEPTIONS macro. How about let's merge the patch now and I can do the conversion of existing code to the wrapper in background? Weiming ht

Re: [PATCH] D21673: [libcxx] guard throw with exception enabling check

It's a good idea. Currently, there are about 600+ "throws" being guarded by _LIBCPP_NO_EXCEPTIONS macro. How about let's merge the patch now and I can do the conversion of existing code to the wrapper in background? Weiming On 6/24/2016 1:25 AM, Noel Grandin wrote: grandinj added a subscri

Re: [PATCH] D21682: DeadStoresChecker: Don't warn about dead stores into volatile variables

sberg closed this revision. sberg added a comment. Committed revision 273689. http://reviews.llvm.org/D21682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r273689 - DeadStoresChecker: Don't warn about dead stores into volatile variables

Author: sberg Date: Fri Jun 24 11:26:43 2016 New Revision: 273689 URL: http://llvm.org/viewvc/llvm-project?rev=273689&view=rev Log: DeadStoresChecker: Don't warn about dead stores into volatile variables Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp cfe/trunk/test/

Re: [PATCH] D21601: Make tooling::applyAllReplacements return llvm::Expected instead of empty string to indicate potential error.

klimek added a comment. In http://reviews.llvm.org/D21601#466513, @ioeric wrote: > Would EXPECTED_FALSE(!Code) be better? Not really. Can we at least use static_cast(...)? http://reviews.llvm.org/D21601 ___ cfe-commits mailing list cfe-commits@li

Re: [PATCH] D21601: Make tooling::applyAllReplacements return llvm::Expected instead of empty string to indicate potential error.

Would EXPECTED_FALSE(!Code) be better? On Fri, Jun 24, 2016, 17:42 Manuel Klimek wrote: > klimek added inline comments. > > > Comment at: unittests/Format/CleanupTest.cpp:258 > @@ +257,3 @@ > +auto CleanReplaces = cleanupAroundReplacements(Code, Replaces, Style); > +EXPE

Re: [PATCH] D21601: Make tooling::applyAllReplacements return llvm::Expected instead of empty string to indicate potential error.

klimek added inline comments. Comment at: unittests/Format/CleanupTest.cpp:258 @@ +257,3 @@ +auto CleanReplaces = cleanupAroundReplacements(Code, Replaces, Style); +EXPECT_TRUE((bool)CleanReplaces) +<< llvm::toString(CleanReplaces.takeError()) << "\n";

Re: [PATCH] D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'

Carlo, yes this is what I meant. Best regards, Alexey Bataev Отправлено с iPhone > 24 июня 2016 г., в 18:16, Carlo Bertolli написал(а): > > carlo.bertolli added a comment. > > Thanks for the hint - I have updated the diff to use Context.getSizeType(). > Please let me know if this is what yo

Re: [PATCH] D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'

carlo.bertolli added a comment. Thanks for the hint - I have updated the diff to use Context.getSizeType(). Please let me know if this is what you meant. Repository: rL LLVM http://reviews.llvm.org/D21564 ___ cfe-commits mailing list cfe-commits

Re: [PATCH] D20428: Tracking exception specification source locations

On Fri, Jun 24, 2016 at 8:39 AM, Richard Smith wrote: > rsmith added a comment. > > Ah right, we were (intentionally, but unfortunately) making an assumption > that the `TypeLoc` data layout doesn't change when the exception spec of a > function is updated. You'd need to make yourself a `TypeLoc

r273683 - Correct error in change description.

Author: rsmith Date: Fri Jun 24 09:23:32 2016 New Revision: 273683 URL: http://llvm.org/viewvc/llvm-project?rev=273683&view=rev Log: Correct error in change description. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/llvm-project/

[PATCH] D21683: [Sparc] Allow LEON cpu models to be selected with -mcpu

jacob_hansen created this revision. jacob_hansen added reviewers: jyknight, lero_chris. jacob_hansen added a subscriber: cfe-commits. Herald added a subscriber: jyknight. This change exposes the recently added LEON CPUs (D19359) in the LLVM Sparc backend to Clang, allowing the cpu's to be selecte

r273681 - Remaining motions pass.

Author: rsmith Date: Fri Jun 24 09:10:58 2016 New Revision: 273681 URL: http://llvm.org/viewvc/llvm-project?rev=273681&view=rev Log: Remaining motions pass. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/www

r273680 - Inline variables tentatively approved for C++17.

Author: rsmith Date: Fri Jun 24 09:04:07 2016 New Revision: 273680 URL: http://llvm.org/viewvc/llvm-project?rev=273680&view=rev Log: Inline variables tentatively approved for C++17. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/l

[PATCH] D21682: DeadStoresChecker: Don't warn about dead stores into volatile variables

sberg created this revision. sberg added a reviewer: zaks.anna. sberg added a subscriber: cfe-commits. http://reviews.llvm.org/D21682 Files: lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp test/Analysis/dead-stores.c Index: test/Analysis/dead-stores.c ==

Re: [PATCH] D21601: Make tooling::applyAllReplacements return llvm::Expected instead of empty string to indicate potential error.

ioeric updated this revision to Diff 61785. ioeric added a comment. - Addressed comments. http://reviews.llvm.org/D21601 Files: include/clang/Format/Format.h include/clang/Tooling/Core/Replacement.h lib/Format/Format.cpp lib/Tooling/Core/Replacement.cpp lib/Tooling/Refactoring.cpp t

Re: [PATCH] D21601: Make tooling::applyAllReplacements return llvm::Expected instead of empty string to indicate potential error.

ioeric marked 2 inline comments as done. Comment at: unittests/Format/CleanupTest.cpp:258 @@ +257,3 @@ +auto CleanReplaces = cleanupAroundReplacements(Code, Replaces, Style); +EXPECT_TRUE((bool)CleanReplaces) +<< llvm::toString(CleanReplaces.takeError()) << "\n"; -

Re: [PATCH] D21470: [clang-tidy] Don't run misc-definitions-in-headers check in failing TUs.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D21470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

r273676 - Updates from further motions.

Author: rsmith Date: Fri Jun 24 08:25:08 2016 New Revision: 273676 URL: http://llvm.org/viewvc/llvm-project?rev=273676&view=rev Log: Updates from further motions. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/llvm-project/cfe/tru

Re: [PATCH] D21601: Make tooling::applyAllReplacements return llvm::Expected instead of empty string to indicate potential error.

klimek added inline comments. Comment at: include/clang/Format/Format.h:780 @@ -778,2 +779,3 @@ /// \brief Returns the replacements corresponding to applying \p Replaces and -/// cleaning up the code after that. +/// cleaning up the code after that on success; otheriwse, return a

r273675 - Fix make-check issues

Author: spetrovic Date: Fri Jun 24 08:11:15 2016 New Revision: 273675 URL: http://llvm.org/viewvc/llvm-project?rev=273675&view=rev Log: Fix make-check issues Fixing build issue for test test/CodeGen/struct-union-BE.c. Modified: cfe/trunk/test/CodeGen/struct-union-BE.c Modified: cfe/trunk/te

Re: [PATCH] D19770: Add FixedSizeStorage to TrailingObjects; NFC

STL's not at the meeting this week. I'll try to catch someone at the meeting to see if we can figure out how to get the compiler to squint the right way at the code first. -- HT On Fri, Jun 24, 2016 at 3:47 PM, Aaron Ballman wrote: > On Fri, Jun 24, 2016 at 8:25 AM, Aaron Ballman > wrote: > >

Re: [PATCH] D19770: Add FixedSizeStorage to TrailingObjects; NFC

On Fri, Jun 24, 2016 at 8:25 AM, Aaron Ballman wrote: > On Fri, Jun 24, 2016 at 8:22 AM, Hubert Tong > wrote: >> Working to reverse the patch. I need someone with MSVC to help me. > > I'll help out with it when I get a moment (hopefully today or this weekend). I'm not certain there's a way *to*

Re: [PATCH] D21601: Make tooling::applyAllReplacements return llvm::Expected instead of empty string to indicate potential error.

ioeric marked 4 inline comments as done. ioeric added a comment. mark previous comments as done http://reviews.llvm.org/D21601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21602: Changes related to tooling::applyAllReplacements interface change in D21601.

ioeric updated this revision to Diff 61782. ioeric added a comment. - Changes corresponding to new interfaces: formatReplacements and cleanupAroundReplacements. http://reviews.llvm.org/D21602 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixer.h include-fixer/tool/ClangInclu

Re: [PATCH] D21601: Make tooling::applyAllReplacements return llvm::Expected instead of empty string to indicate potential error.

ioeric updated this revision to Diff 61780. ioeric added a comment. - fixed commenting. - Make formatReplacemnts and cleanupAroundReplacements return llvm::Exppected<...>. http://reviews.llvm.org/D21601 Files: include/clang/Format/Format.h include/clang/Tooling/Core/Replacement.h lib/For

Re: [PATCH] D20428: Tracking exception specification source locations

On Fri, Jun 24, 2016 at 8:39 AM, Richard Smith wrote: > rsmith added a comment. > > Ah right, we were (intentionally, but unfortunately) making an assumption > that the `TypeLoc` data layout doesn't change when the exception spec of a > function is updated. You'd need to make yourself a `TypeLoc

Re: [PATCH] D20428: Tracking exception specification source locations

rsmith added a comment. Ah right, we were (intentionally, but unfortunately) making an assumption that the `TypeLoc` data layout doesn't change when the exception spec of a function is updated. You'd need to make yourself a `TypeLocBuilder`, copy the relevant data, and update the exception spec

r273668 - More approved features for C++17.

Author: rsmith Date: Fri Jun 24 07:21:30 2016 New Revision: 273668 URL: http://llvm.org/viewvc/llvm-project?rev=273668&view=rev Log: More approved features for C++17. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/llvm-project/cfe

Re: [PATCH] D19770: Add FixedSizeStorage to TrailingObjects; NFC

On Fri, Jun 24, 2016 at 8:22 AM, Hubert Tong wrote: > Working to reverse the patch. I need someone with MSVC to help me. I'll help out with it when I get a moment (hopefully today or this weekend). ~Aaron > > -- HT > > On Fri, Jun 24, 2016 at 3:19 PM, Aaron Ballman > wrote: >> >> On Fri, Jun 2

r273667 - Dynamic memory allocation with alignment has been approved for C++17.

Author: rsmith Date: Fri Jun 24 07:16:11 2016 New Revision: 273667 URL: http://llvm.org/viewvc/llvm-project?rev=273667&view=rev Log: Dynamic memory allocation with alignment has been approved for C++17. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: htt

Re: [PATCH] D19770: Add FixedSizeStorage to TrailingObjects; NFC

Working to reverse the patch. I need someone with MSVC to help me. -- HT On Fri, Jun 24, 2016 at 3:19 PM, Aaron Ballman wrote: > On Fri, Jun 24, 2016 at 8:16 AM, Hubert Tong > wrote: > > On Fri, Jun 24, 2016 at 3:07 PM, Aaron Ballman > > wrote: > >> > >> On Fri, Jun 24, 2016 at 8:05 AM, Huber

r273666 - Using for attributes voted into C++17.

Author: rsmith Date: Fri Jun 24 07:15:12 2016 New Revision: 273666 URL: http://llvm.org/viewvc/llvm-project?rev=273666&view=rev Log: Using for attributes voted into C++17. Added: cfe/trunk/test/CXX/dcl.dcl/dcl.attr/dcl.attr.grammar/p2-1z.cpp Modified: cfe/trunk/include/clang/Basic/Diagnos

Re: [PATCH] D19770: Add FixedSizeStorage to TrailingObjects; NFC

On Fri, Jun 24, 2016 at 8:16 AM, Hubert Tong wrote: > On Fri, Jun 24, 2016 at 3:07 PM, Aaron Ballman > wrote: >> >> On Fri, Jun 24, 2016 at 8:05 AM, Hubert Tong >> wrote: >> > On Fri, Jun 24, 2016 at 3:00 PM, Aaron Ballman >> > wrote: >> >> >> >> aaron.ballman added a comment. >> >> >> >> Did R

  1   2   >