omtcyf0 added a comment.
Does it look good now?
http://reviews.llvm.org/D22091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275377: Use hasFlag instead of hasArg (authored by dberris).
Changed prior to commit:
http://reviews.llvm.org/D22338?vs=63922&id=63923#toc
Repository:
rL LLVM
http://reviews.llvm.org/D22338
Files:
Author: dberris
Date: Thu Jul 14 01:37:46 2016
New Revision: 275377
URL: http://llvm.org/viewvc/llvm-project?rev=275377&view=rev
Log:
Use hasFlag instead of hasArg
Summary: Fix the build to use hasFlag instead of hasArg for checking some flags.
Reviewers: echristo
Subscribers: mehdi_amini, cfe-
omtcyf0 added a comment.
Any other objections?
http://reviews.llvm.org/D22129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM.
-eric
http://reviews.llvm.org/D22338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
dberris created this revision.
dberris added a reviewer: echristo.
dberris added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
Fix the build to use hasFlag instead of hasArg for checking some flags.
http://reviews.llvm.org/D22338
Files:
lib/Driver/Tools.cpp
Index: lib/Dri
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275368: Add C++ dependencies to xray runtime (authored by
dberris).
Changed prior to commit:
http://reviews.llvm.org/D21983?vs=63917&id=63919#toc
Repository:
rL LLVM
http://reviews.llvm.org/D21983
Author: dberris
Date: Wed Jul 13 23:58:44 2016
New Revision: 275368
URL: http://llvm.org/viewvc/llvm-project?rev=275368&view=rev
Log:
Add C++ dependencies to xray runtime
Summary:
Depends on D21982 which implements the in-memory logging implementation of the
XRay runtime. These additional changes
dberris updated this revision to Diff 63917.
dberris added a comment.
- Undo unnecessary formatting change
http://reviews.llvm.org/D21983
Files:
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
===
--- lib/Driver/Tools.cpp
+++ l
dberris updated this revision to Diff 63916.
dberris added a comment.
Rebase
http://reviews.llvm.org/D21983
Files:
lib/CodeGen/CodeGenFunction.cpp
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
===
--- lib/Driver/Tools.cpp
+
mayurpandey created this revision.
mayurpandey added reviewers: george.burgess.iv, hfinkel.
mayurpandey added a subscriber: cfe-commits.
clang was crashing when no argument was provided to __builtin_signbit function.
Added a check to handle the error. No regressions on testing.
http://reviews.ll
pcc updated this revision to Diff 63908.
pcc added a comment.
Refresh
http://reviews.llvm.org/D21545
Files:
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CMakeLists.txt
Index: lib/CodeGen/CMakeLists.txt
===
--- lib/CodeGen/CMakeList
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D22075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
pcc added a comment.
Ping.
http://reviews.llvm.org/D21825
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl updated the summary for this revision.
yaxunl updated this revision to Diff 63897.
yaxunl marked 3 inline comments as done.
yaxunl added a comment.
Revised by Anastasia's comments. This fixes multiple function call of
`__translate_sampler_initializer` for function-scope sampler variables.
> On 2016-Jul-13, at 11:18, Vedant Kumar wrote:
>
>>
>> On Jul 13, 2016, at 10:30 AM, Duncan P. N. Exon Smith
>> wrote:
>>
>>
>>> On 2016-Jul-12, at 18:59, Vedant Kumar wrote:
>>>
On Jul 12, 2016, at 6:23 PM, Duncan P. N. Exon Smith
wrote:
> On 2016-Jul-1
spyffe updated this revision to Diff 63894.
spyffe added a comment.
Applied Manman's changes:
- `const auto*` instead of `const RecordType*`
- kept the if's separate because I...
- ...moved the `Index++` and `continue` in so that we only increment the
counter when we're really dealing with somet
Author: adrian
Date: Wed Jul 13 19:42:53 2016
New Revision: 275356
URL: http://llvm.org/viewvc/llvm-project?rev=275356&view=rev
Log:
Add a comment mirroring the one in LLVM's Dwarf.h
Modified:
cfe/trunk/include/clang/Sema/DeclSpec.h
Modified: cfe/trunk/include/clang/Sema/DeclSpec.h
URL:
htt
Hmm. I implied there were other regressions, but I just finished scanning
them. Shootout-C++/hash2 is the only major one. The others were small, and
only at -O0.
> On 2016-Jul-13, at 17:38, Duncan P. N. Exon Smith via cfe-commits
> wrote:
>
> We saw mixed results from this on LNT, includin
We saw mixed results from this on LNT, including some major regressions. For
example, on x86_64, SingleSource/Benchmarks/Shootout-C++/hash2 regressed 18.5%
at -O3 and over 20% at -Os.
Is this expected?
> On 2016-Jul-11, at 15:02, Eric Fiselier via cfe-commits
> wrote:
>
> Author: ericwf
> D
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/Driver/cuda_phases.cu:48
@@ +47,3 @@
+//
+// Test two gpu architecture with complete compilation.
+//
architecture*s*.
There are few more cop
sfantao marked an inline comment as done.
Comment at: test/Driver/cuda_phases.cu:2
@@ +1,3 @@
+// Tests the phases generated for a CUDA offloading target for different
+// combinations of:
+// - Number of gpu architectures;
Oh, ok. Thought that the registration of
sfantao updated this revision to Diff 63889.
sfantao added a comment.
- Add comments and REQUIRE directives to test.
http://reviews.llvm.org/D18171
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
lib/Driver/Action.cpp
lib/Driver/Dr
Author: rsmith
Date: Wed Jul 13 19:14:59 2016
New Revision: 275351
URL: http://llvm.org/viewvc/llvm-project?rev=275351&view=rev
Log:
www/cxx_status: give more precise links to initialization order wording
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
h
Author: rsmith
Date: Wed Jul 13 19:11:03 2016
New Revision: 275350
URL: http://llvm.org/viewvc/llvm-project?rev=275350&view=rev
Log:
P0305R0: Semantic analysis and code generation for C++17 init-statement for
'if' and 'switch':
if (stmt; condition) { ... }
Patch by Anton Bikineev! Some minor
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thank you again! I've fixed some over-long lines and committed this as r275350.
http://reviews.llvm.org/D21834
___
cfe-commits mailing list
cfe-c
mehdi_amini added a comment.
This is committed r275115 for the record.
Phabricator will automatically close it if the last line is "Differential
Revision: ..." (You put "Differential review: ..." instead).
http://reviews.llvm.org/D11360
___
cfe-co
tra added inline comments.
Comment at: test/Driver/cuda_phases.cu:1
@@ +1,2 @@
+// RUN: %clang -target powerpc64le-ibm-linux-gnu -ccc-print-phases
--cuda-gpu-arch=sm_30 %s 2>&1 \
+// RUN: | FileCheck -check-prefix=BIN %s
Few words describing the test would be nic
sfantao updated this revision to Diff 63880.
sfantao added a comment.
- Add test to check the generated phases for CUDA.
- Fix typo in comment.
http://reviews.llvm.org/D18171
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
lib/Driver
manmanren added a comment.
In http://reviews.llvm.org/D22270#483027, @spyffe wrote:
> Thank you very much for your review, Manman! I can implement all your
> individual fixes, those look fine. In answer to two of your bigger
> questions, though:
>
> - I see what you mean about the definition
aaron.ballman added a comment.
In http://reviews.llvm.org/D20352#482590, @dberris wrote:
> It looks like I was using `hasArg` instead of `hasFlag`. The dangerous part
> here is that OptSpecifier has an unsigned non-explicit argument, and I
> suspect `bool` is being promoted to `unsigned` silent
Author: aaronballman
Date: Wed Jul 13 17:32:15 2016
New Revision: 275330
URL: http://llvm.org/viewvc/llvm-project?rev=275330&view=rev
Log:
Add XRay flags to Clang. We implement two flags to control the XRay behaviour:
-fxray-instrument: enables XRay annotation of IR
-fxray-instruction-threshold:
tra added a comment.
The changes look good.
Now we just need some tests. Something along the lines of test/Driver/phases.c
should do.
http://reviews.llvm.org/D18171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: akirtzidis
Date: Wed Jul 13 17:03:47 2016
New Revision: 275324
URL: http://llvm.org/viewvc/llvm-project?rev=275324&view=rev
Log:
[test] Add 'env' to fix test failures in windows bots.
Modified:
cfe/trunk/test/Index/pch-warn-as-error-code-split.cpp
Modified: cfe/trunk/test/Index/pch-w
sfantao added inline comments.
Comment at: lib/Driver/Action.cpp:191-202
@@ +190,14 @@
+ auto I = getInputs().begin();
+ auto E = getInputs().end();
+ if (I == E)
+return;
+
+ // Skip host action
+ if (HostTC)
+++I;
+
+ auto TI = DevToolChains.begin();
+ for (; I !=
sfantao updated this revision to Diff 63865.
sfantao marked an inline comment as done.
sfantao added a comment.
- Modify assertion to check that sizes of input dependences and device
toolchains is consistent.
http://reviews.llvm.org/D18171
Files:
include/clang/Driver/Action.h
include/clang
Author: kli
Date: Wed Jul 13 16:51:49 2016
New Revision: 275323
URL: http://llvm.org/viewvc/llvm-project?rev=275323&view=rev
Log:
[OpenMP] remove duplicate code in ActOnOpenMPRegionStart
This patch is to remove duplicate code in ActOnOpenMPRegionStart. (NFC)
Differential Revision: http://reviews
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275318: [OpenCL] Fixes failures in test/Driver/opencl.cl.
(authored by yaxunl).
Changed prior to commit:
http://reviews.llvm.org/D22170?vs=63722&id=63862#toc
Repository:
rL LLVM
http://reviews.llvm.
Author: yaxunl
Date: Wed Jul 13 16:21:05 2016
New Revision: 275318
URL: http://llvm.org/viewvc/llvm-project?rev=275318&view=rev
Log:
[OpenCL] Fixes failures in test/Driver/opencl.cl.
Also fixes strict-aliasing option to only be allowed when OpenCL Version 1.0.
Added testcase in test/Frontend/ope
tra added inline comments.
Comment at: lib/Driver/Action.cpp:191-202
@@ +190,14 @@
+const OffloadActionWorkTy &Work) const {
+ auto I = getInputs().begin();
+ auto E = getInputs().end();
+ if (I == E)
+return;
+
+ // Skip host action
+ if (HostTC)
+++I;
+
+ auto
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275315: [OpenMP] add more tests for 'distribute parallel for
simd' pragma (authored by kli).
Changed prior to commit:
http://reviews.llvm.org/D22169?vs=63312&id=63855#toc
Repository:
rL LLVM
http://
Author: kli
Date: Wed Jul 13 15:40:32 2016
New Revision: 275315
URL: http://llvm.org/viewvc/llvm-project?rev=275315&view=rev
Log:
[OpenMP] add more tests for 'distribute parallel for simd' pragma
This patch is to add two additional tests for testing 'distribute parallel for
simd' pragma with dis
teemperor added inline comments.
Comment at: include/clang/AST/CloneDetection.h:131
@@ +130,3 @@
+ bool operator<(const StmtSequence &Other) const {
+return std::tie(S, StartIndex, EndIndex) <
+ std::tie(Other.S, Other.StartIndex, Other.EndIndex);
z
Author: akirtzidis
Date: Wed Jul 13 15:35:26 2016
New Revision: 275313
URL: http://llvm.org/viewvc/llvm-project?rev=275313&view=rev
Log:
[PCH/preamble] Make sure that if the preamble/PCH was serialized with errors
that we set diagnostic engine state appropriately.
Otherwise there can be a crash
sfantao added a comment.
Hi Art,
Thanks for the review! Addressed your comments in the last diff.
Thanks again,
Samuel
Comment at: lib/Driver/Action.cpp:191-202
@@ +190,14 @@
+const OffloadActionWorkTy &Work) const {
+ auto I = getInputs().begin();
+ auto E = getInputs()
teemperor updated this revision to Diff 63851.
teemperor marked 18 inline comments as done.
teemperor added a comment.
- Checker is now in the alpha package and hidden.
- MinGroupComplexity is now a parameter for the checker.
- StmtData is now called CloneSignature.
- Replaced the std::map inside
sfantao updated this revision to Diff 63852.
sfantao added a comment.
- Add one more assert.
http://reviews.llvm.org/D18171
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/To
yaxunl marked 11 inline comments as done.
Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:83
@@ +82,3 @@
+SamplerTy = llvm::PointerType::get(llvm::StructType::create(
+ CGM.getLLVMContext(), "__sampler"),
+ CGM.getContext().getTargetAddressSpace(
Anastas
sfantao updated this revision to Diff 63850.
sfantao marked 4 inline comments as done.
sfantao added a comment.
- Add assertions before accessing getInputs() when assumptions are made about
the number of elements.
- Add missing evaluations of end iterator in the beginning of loops.
- Address othe
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp:70
@@ +69,3 @@
+ if (IndexExpr->isValueDependent())
+return; // we check
aaron.ballman added a comment.
In http://reviews.llvm.org/D22196#481567, @ericLemanissier wrote:
> Well, C++ Core Guidelines advises in this case to correct function receiving
> __PRETTY_FUNCTION__: the parameter type should not be const char* (
> https://github.com/isocpp/CppCoreGuidelines/iss
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:3227
@@ -3226,1 +3226,3 @@
+def note_ovl_candidate_ambiguous_base_classes : Note<
+"candidate template ignored: ambiguous base classes of %0 match %1">;
ambiguous -> multipl
rsmith added inline comments.
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3861
@@ -3860,3 +3860,3 @@
// static data members until a definition of the variable is needed. We need
- // it right away if the type contains 'auto'.
+ // it right away if the type contains '
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275306: [OpenMP] add more tests for 'distribute simd' pragma
(authored by kli).
Changed prior to commit:
http://reviews.llvm.org/D22176?vs=63323&id=63845#toc
Repository:
rL LLVM
http://reviews.llvm.
Author: kli
Date: Wed Jul 13 14:16:56 2016
New Revision: 275306
URL: http://llvm.org/viewvc/llvm-project?rev=275306&view=rev
Log:
[OpenMP] add more tests for 'distribute simd' pragma
This patch is to add two additional tests for testing 'distribute simd' pragma
with disallowed clauses and loops.
Author: yrnkrn
Date: Wed Jul 13 14:04:51 2016
New Revision: 275303
URL: http://llvm.org/viewvc/llvm-project?rev=275303&view=rev
Log:
Implement FunctionDecl::getDefinition() to be consistent with
VarDecl, TagDecl, EnumDecl, RecordDecl, CXXRecordDecl.
Use getDefinition in two locations to make the
rjmccall added inline comments.
Comment at: lib/CodeGen/CGStmt.cpp:537
@@ +536,3 @@
+ llvm::LLVMContext::MD_noalias),
+ NewScopeList));
+
This is a very strange representation. Every memory
erik.pilkington created this revision.
erik.pilkington added reviewers: rsmith, faisalv.
erik.pilkington added a subscriber: cfe-commits.
Previously, clang would give a terrible diagnostic for the following:
```
template struct B {};
struct D : B<0>, B<1> {};
template int f(B) { return 0; } // e
pgousseau created this revision.
pgousseau added a reviewer: rsmith.
pgousseau added subscribers: cfe-commits, trybka, bruno, gbedwell, wristow,
probinson.
The test added in r275267 does not work on read-only checkouts because of the
use of touch -t.
Following Tom Rybka suggestion, the test file
Author: dergachev
Date: Wed Jul 13 13:07:26 2016
New Revision: 275290
URL: http://llvm.org/viewvc/llvm-project?rev=275290&view=rev
Log:
[analyzer] Implement a methond to discover origin region of a symbol.
This encourages checkers to make logical decisions depending on
value of which region was t
> On Jul 13, 2016, at 10:30 AM, Duncan P. N. Exon Smith
> wrote:
>
>
>> On 2016-Jul-12, at 18:59, Vedant Kumar wrote:
>>
>>>
>>> On Jul 12, 2016, at 6:23 PM, Duncan P. N. Exon Smith
>>> wrote:
>>>
>>>
On 2016-Jul-12, at 17:47, Vedant Kumar wrote:
> On Jul 12, 2016,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275290: [analyzer] Implement a methond to discover origin
region of a symbol. (authored by dergachev).
Changed prior to commit:
http://reviews.llvm.org/D22242?vs=63688&id=63828#toc
Repository:
rL LLV
spyffe added a comment.
I mean `findUntaggedStructOrUnionIndex`
Repository:
rL LLVM
http://reviews.llvm.org/D22270
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
davidsh updated this revision to Diff 63824.
davidsh added a comment.
Address formatting comment.
http://reviews.llvm.org/D22075
Files:
lib/Sema/SemaOpenMP.cpp
test/OpenMP/target_map_messages.cpp
Index: test/OpenMP/target_map_messages.cpp
===
spyffe added a comment.
Thank you very much for your review, Manman! I can implement all your
individual fixes, those look fine. In answer to two of your bigger questions,
though:
- I see what you mean about the definition of an anonymous structure. It looks
like our structure is an //untag
mgrang added a comment.
Thanks Renato for your comments. I guess I will not upstream my patches then.
--Mandeep
http://reviews.llvm.org/D22254
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
> On 2016-Jul-12, at 18:59, Vedant Kumar wrote:
>
>>
>> On Jul 12, 2016, at 6:23 PM, Duncan P. N. Exon Smith
>> wrote:
>>
>>
>>> On 2016-Jul-12, at 17:47, Vedant Kumar wrote:
>>>
>>>
On Jul 12, 2016, at 5:41 PM, Duncan P. N. Exon Smith
wrote:
> On 2016-Jul-12,
Author: cbertol
Date: Wed Jul 13 12:16:49 2016
New Revision: 275282
URL: http://llvm.org/viewvc/llvm-project?rev=275282&view=rev
Log:
[OpenMP] Initial implementation of parse+sema for OpenMP clause 'is_device_ptr'
of target
http://reviews.llvm.org/D22070
Added:
cfe/trunk/test/OpenMP/targe
aaron.ballman added a comment.
In http://reviews.llvm.org/D20561#482963, @rogfer01 wrote:
> If there are not any objections I will commit this tomorrow.
If @rsmith doesn't comment by tomorrow, then I think any feedback can be
handled post-commit instead.
http://reviews.llvm.org/D20561
___
Author: marshall
Date: Wed Jul 13 11:58:48 2016
New Revision: 275280
URL: http://llvm.org/viewvc/llvm-project?rev=275280&view=rev
Log:
Constuct a sentry object in istream::readsome, and handle failures
appropriately. Fixes PR#28217.
Modified:
libcxx/trunk/include/istream
Modified: libcxx/tr
weimingz added a comment.
In http://reviews.llvm.org/D22292#482750, @rmaprath wrote:
> In http://reviews.llvm.org/D22292#482560, @compnerd wrote:
>
> > Can you explain why the write back is needed? You are doing the write back
> > on r0, but then adjusting it back. So it is unclear why this ch
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275279: [include-fixer] Implement adding missing namespace
qualifiers in vim… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D22299?vs=63808&id=63818#toc
Repository:
rL LLVM
Author: hokein
Date: Wed Jul 13 11:43:54 2016
New Revision: 275279
URL: http://llvm.org/viewvc/llvm-project?rev=275279&view=rev
Log:
[include-fixer] Implement adding missing namespace qualifiers in vim
integration.
Summary:
The patch extends include-fixer's "-output-headers", and "-insert-header
rogfer01 added a comment.
If there are not any objections I will commit this tomorrow.
http://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erik.pilkington added a comment.
Ping!
http://reviews.llvm.org/D22053
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erik.pilkington added a comment.
Pong!
http://reviews.llvm.org/D21145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added inline comments.
Comment at: lib/AST/ExprConstant.cpp:5766
@@ +5765,3 @@
+if (CXXRecordDecl *CD = dyn_cast(
+E->getType()->castAs()->getDecl()))
+ CD->setNeedLocalVFTable();
Even better:
if (auto *CD = E->getType()->getAsCXXRecordD
majnemer added a comment.
Running your patch against the following:
struct __declspec(dllimport) S {
virtual void f() {}
};
S x;
constexpr S y;
results in:
> Global is marked as dllimport, but not external
> [2 x i8*]* @"\01??_7S@@6B@"
> fatal error: error in backend: Broken mod
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision 275271.
Repository:
rL LLVM
http://reviews.llvm.org/D21904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: cbertol
Date: Wed Jul 13 10:37:16 2016
New Revision: 275271
URL: http://llvm.org/viewvc/llvm-project?rev=275271&view=rev
Log:
[OpenMP] Initial implementation of parse+sema for clause use_device_ptr of
'target data'
http://reviews.llvm.org/D21904
This patch is similar to the implementati
hokein updated this revision to Diff 63808.
hokein marked an inline comment as done.
hokein added a comment.
Fix nits.
http://reviews.llvm.org/D22299
Files:
include-fixer/IncludeFixerContext.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/t
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D22170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
rengolin added a comment.
In http://reviews.llvm.org/D22254#481972, @mgrang wrote:
> Hi Tim/Renato,
>
> On a similar note, I have a patch which adds the breakpoint intrinsic (for
> ARM and Thumb):
>
> http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0491c/CJAHBCFH.html
Hi Mande
tavianator updated this revision to Diff 63806.
tavianator added a comment.
Make sure the tail of the list is null.
http://reviews.llvm.org/D21803
Files:
src/cxa_thread_atexit.cpp
test/CMakeLists.txt
test/cxa_thread_atexit_test.pass.cpp
test/libcxxabi/test/config.py
test/lit.site.cfg.
pgousseau abandoned this revision.
pgousseau added a comment.
Superseded by http://reviews.llvm.org/D20867
http://reviews.llvm.org/D20243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: pgousseau
Date: Wed Jul 13 09:21:11 2016
New Revision: 275267
URL: http://llvm.org/viewvc/llvm-project?rev=275267&view=rev
Log:
[PCH] Add a fno-pch-timestamp option to cc1 to disable inclusion of timestamps
in PCH files.
This is to allow distributed build systems, that do not preserve ti
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275263: [clang-tidy] Fix misc-definitions-in-headers
misplaced fixing to fully… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D22260?vs=63649&id=63802#toc
Repository:
rL LLVM
Author: hokein
Date: Wed Jul 13 08:55:29 2016
New Revision: 275263
URL: http://llvm.org/viewvc/llvm-project?rev=275263&view=rev
Log:
[clang-tidy] Fix misc-definitions-in-headers misplaced fixing to fully
templated function.
Reviewers: alexfh, aaron.ballman
Subscribers: cfe-commits
Differential
tavianator updated this revision to Diff 63801.
tavianator added a comment.
Update comments to mention that late-initialized thread_locals invoke undefined
behavior.
http://reviews.llvm.org/D21803
Files:
src/cxa_thread_atexit.cpp
test/CMakeLists.txt
test/cxa_thread_atexit_test.pass.cpp
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Patch LGTM, thank you!
http://reviews.llvm.org/D22260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
One nit, LGTM.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:277
@@ +276,3 @@
+//
+// Check whether all elements in HeaderInfos have the qualified name.
+
hokein added inline comments.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:252
@@ +251,3 @@
+assert(!HeaderInfos.empty());
+// Only accept an unique header.
+bool IsUniqueHeader = std::equal(
bkramer wrote:
> In that case adjacent_find was the
hokein updated this revision to Diff 63799.
hokein marked 2 inline comments as done.
hokein added a comment.
Add comments for std::equal.
http://reviews.llvm.org/D22299
Files:
include-fixer/IncludeFixerContext.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cp
I double checked and cannot reproduce, nor can I find the test breakage. I
think at the time the conditional-in-parameter-initializer test case failed
without the change. If all tests pass, more power to you :-)
Martin Probst schrieb am Di., 12. Juli 2016 um 07:32 Uhr:
> What do you mean by othe
bkramer added inline comments.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:252
@@ +251,3 @@
+assert(!HeaderInfos.empty());
+// Only accept an unique header.
+bool IsUniqueHeader = std::equal(
In that case adjacent_find was the right choice, bu
hokein marked an inline comment as done.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:252
@@ +251,3 @@
+// Only accept an unique header.
+bool IsUniqueHeader =
+std::adjacent_find(HeaderInfos.begin(), HeaderInfos.end(),
You are right. `adja
hokein updated this revision to Diff 63796.
hokein marked 6 inline comments as done.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D22299
Files:
include-fixer/IncludeFixerContext.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
mgehre updated this revision to Diff 63795.
mgehre added a comment.
Suppress diagnostics if index is value-dependent. Emit them in specializations.
http://reviews.llvm.org/D22190
Files:
clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp
test/clang-tidy/cppcoreguidelines-pro-b
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275261: [PCH] Fix timestamp check on windows hosts.
(authored by pgousseau).
Changed prior to commit:
http://reviews.llvm.org/D20867?vs=59887&id=63794#toc
Repository:
rL LLVM
http://reviews.llvm.org
Author: pgousseau
Date: Wed Jul 13 06:58:28 2016
New Revision: 275261
URL: http://llvm.org/viewvc/llvm-project?rev=275261&view=rev
Log:
[PCH] Fix timestamp check on windows hosts.
On Linux, if the timestamp of a header file, included in the pch, is modified,
then including the pch without regene
1 - 100 of 113 matches
Mail list logo
