[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

djasper added a comment. So sorry. Seems I forgot to hit "Submit" :(. If you don't like the ".first" and ".second" of the pair, you could introduce a struct for it and overload operator<. Might actually be more readable. > WhitespaceManager.cpp:73 > + Tok.NestingLevel, >

[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

bmharper added a comment. ping! https://reviews.llvm.org/D21279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24969: [Sema] Use the instantiated name of destructors in FindInstantiatedDecl and RebuildMemberExpr

ahatanak added inline comments. > rsmith wrote in SemaTemplateInstantiateDecl.cpp:4849 > Do we need to do this for conversion function names too? (Eg, `operator > C1*`) I added a definition of "operator C1*" and called it in C1::foo1. I didn't see any crashes or asserts. Calls to a

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris added a comment. In https://reviews.llvm.org/D24799#561106, @rSerge wrote: > My mistake was that initially I only enumerated the unsupported targets from > llvm\include\llvm\ADT\Triple.h . Now I've added also the cases from > llvm\lib\Support\Triple.cpp . > `XFAIL` requires a list of

[PATCH] D25264: Implement MS _BitScan intrinsics

majnemer added inline comments. > CGBuiltin.cpp:2640-2647 > +// Many of MSVC builtins are on both x64 and ARM; to avoid repeating code, we > +// handle them here. > +namespace MSVC { > + enum { > +_BitScanForward, > +_BitScanReverse > + }; This should be in an anonymous namespace.

[PATCH] D25264: Implement MS _BitScan intrinsics

agutowski created this revision. agutowski added reviewers: rnk, hans, thakis, majnemer. agutowski added a subscriber: cfe-commits. Herald added a subscriber: aemerson. _BitScan intrinsics (and some others, for example _Interlocked and _bittest) are supposed to work on both ARM and x86. This is

[PATCH] D1752: Implement aarch64 neon instruction class AdvSIMD (by element) - Clang

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL191945. https://reviews.llvm.org/D1752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D1753: Implement aarch64 neon instruction class AdvSIMD (by element) - LLVM

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL191944. https://reviews.llvm.org/D1753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D1801: Pass a SourceLocation down to ubsan's "load_invalid_value" handler.

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL191808. https://reviews.llvm.org/D1801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D19678: Annotated-source optimization reports (a.k.a. "listing" files)

hfinkel abandoned this revision. hfinkel added a comment. Abandoned in favor of https://reviews.llvm.org/D25225/https://reviews.llvm.org/D25262. https://reviews.llvm.org/D19678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D1816: Implement aarch64 neon instruction class SIMD Across - LLVM

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL192028. https://reviews.llvm.org/D1816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D1817: Implement aarch64 neon instruction class SIMD Across - Clang

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL192029. https://reviews.llvm.org/D1817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D1818: For clang-cl, implement additional compatibility arguments (/vm, /GF, /GF-, /Zm, /bigobj).

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL192141. https://reviews.llvm.org/D1818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D1854: Implement aarch64 neon instruction class SIMD copy - LLVM

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL192410. https://reviews.llvm.org/D1854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D1869: [AArch64] implement aarch64 neon vector load/store N-element structure class AdvSIMD (lselem)

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Obsoleted by https://reviews.llvm.org/D1885. https://reviews.llvm.org/D1869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25204: Register Calling Convention, Clang changes

erichkeane marked 16 inline comments as done. erichkeane added a comment. Commenting to save my comments (don't seem to survive a refresh). Still working on non-function mangling. > rnk wrote in ItaniumMangle.cpp:1203 > What mangling should happen for operator overloads and all other kinds

r283280 - [CUDA] Add missing ':' to noexcept.cu test.

Author: jlebar Date: Tue Oct 4 19:27:38 2016 New Revision: 283280 URL: http://llvm.org/viewvc/llvm-project?rev=283280=rev Log: [CUDA] Add missing ':' to noexcept.cu test. Modified: cfe/trunk/test/CodeGenCUDA/nothrow.cu Modified: cfe/trunk/test/CodeGenCUDA/nothrow.cu URL:

[PATCH] D2302: Add some missing intrinsics like vmull_high_n_s16 and friends - clang

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL196189. https://reviews.llvm.org/D2302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r283272 - [CUDA] Mark device functions as nounwind.

Author: jlebar Date: Tue Oct 4 18:41:49 2016 New Revision: 283272 URL: http://llvm.org/viewvc/llvm-project?rev=283272=rev Log: [CUDA] Mark device functions as nounwind. Summary: This prevents clang from emitting 'invoke's and catch statements. Things previously mostly worked thanks to

[PATCH] D25260: [CUDA] Destroy deferred diagnostics before destroying the ASTContext's PartialDiagnostic allocator.

This revision was automatically updated to reflect the committed changes. Closed by commit rL283271: [CUDA] Destroy deferred diagnostics before destroying the ASTContext's… (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D25260?vs=73578=73580#toc Repository: rL LLVM

[PATCH] D25258: [coroutines] Create allocation and deallocation sub-statements.

GorNishanov added inline comments. > majnemer wrote in CGCoroutine.cpp:68-69 > I think that's just `CGM.getContext().getTargetInfo().getSuitableAlign() / > CGM.getContext().getTargetInfo().getCharWidth()` Yay! One less FIXME. I think I will make it to match __STDCPP_DEFAULT_NEW_ALIGNMENT__:

r283271 - [CUDA] Destroy deferred diagnostics before destroying the ASTContext's PartialDiagnostic allocator.

Author: jlebar Date: Tue Oct 4 18:41:45 2016 New Revision: 283271 URL: http://llvm.org/viewvc/llvm-project?rev=283271=rev Log: [CUDA] Destroy deferred diagnostics before destroying the ASTContext's PartialDiagnostic allocator. Summary: This will let us (in a separate patch) allocate deferred

[PATCH] D2304: [AArch64] Add some missing intrinsics like vuqadd_s64 and friends - clang

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL196191. https://reviews.llvm.org/D2304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25166: [CUDA] Mark device functions as nounwind.

jlebar updated this revision to Diff 73579. jlebar marked an inline comment as done. jlebar added a comment. Update tests. https://reviews.llvm.org/D25166 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGException.cpp clang/test/CodeGenCUDA/convergent.cu

[PATCH] D25260: [CUDA] Destroy deferred diagnostics before destroying the ASTContext's PartialDiagnostic allocator.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D25260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25166: [CUDA] Mark device functions as nounwind.

rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. This revision is now accepted and ready to land. lgtm > nothrow.cu:16 > +// DEVICE: define void @_Z3foov() [[DEVICE_ATTR:#[0-9]+]] > +__device__ void foo() { f(); } > + I would check for `call void @_Z1fv` here, and

[PATCH] D25258: [coroutines] Create allocation and deallocation sub-statements.

majnemer added inline comments. > CGCoroutine.cpp:68-69 > +void CodeGenFunction::EmitCoroutineBody(const CoroutineBodyStmt ) { > + auto *NullPtr = llvm::ConstantPointerNull::get(Builder.getInt8PtrTy()); > + // FIXME: Instead of 0, pass an equivalent of alignas(maxalign_t). > + auto *CoroId =

[PATCH] D25260: [CUDA] Destroy deferred diagnostics before destroying the ASTContext's PartialDiagnostic allocator.

jlebar updated this revision to Diff 73578. jlebar added a comment. Update comment. https://reviews.llvm.org/D25260 Files: clang/include/clang/AST/ASTContext.h clang/lib/CodeGen/CodeGenModule.cpp Index: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D25166: [CUDA] Mark device functions as nounwind.

jlebar updated this revision to Diff 73577. jlebar added a comment. Move everything into codegen. https://reviews.llvm.org/D25166 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGException.cpp clang/test/CodeGenCUDA/convergent.cu clang/test/CodeGenCUDA/device-var-init.cu

[PATCH] D25260: [CUDA] Destroy deferred diagnostics before destroying the ASTContext's PartialDiagnostic allocator.

rnk added inline comments. > CodeGenModule.cpp:512-513 >} > + // Clear the deferred diags so they don't outlive the ASTContext from > whence > + // they're allocated. > + DeferredDiags.clear(); The ASTContext outlives CodeGenModule, but the diagnostic allocator in the ASTContext does

[PATCH] D2526: [OpenCL] Disallow casting between address spaces

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL199208. https://reviews.llvm.org/D2526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D22944: [Driver] Replace one-off uses of default triples with effective triples (NFCI)

Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D22944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22945: [Driver] Replace more uses of default triples with effective triples (NFCI)

Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D22945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25139: [CUDA] Add Sema::CUDADiagBuilder and Sema::CUDADiagIfDeviceCode().

jlebar updated this revision to Diff 73576. jlebar marked an inline comment as done. jlebar added a comment. Rebase atop https://reviews.llvm.org/D25260, which obviates the need for this ugly PD allocation dance. https://reviews.llvm.org/D25139 Files:

[PATCH] D25139: [CUDA] Add Sema::CUDADiagBuilder and Sema::CUDADiagIfDeviceCode().

jlebar added inline comments. > rnk wrote in Sema.h:9258 > The ASTContext should outlive IRgen, since the AST is allocated in its arena. > Is there a separate diagnostic memory pool that I don't know about? You're right, this is a silly bug. Fixed in a separate patch,

[PATCH] D23493: Fix PR28366: Teach the const-expression evaluator to be more fault tolerant with non-const enclosing local variables, or otherwise fold them if const.

Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D23493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

Eugene.Zelenko added a comment. Looks like patch was not committed. Repository: rL LLVM https://reviews.llvm.org/D23602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25258: [coroutines] Create allocation and deallocation sub-statements.

GorNishanov created this revision. GorNishanov added reviewers: rsmith, EricWF. GorNishanov added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. 1. Sema: Add allocation / deallocation substatements. 2. Sema: Add labels to final-suspend and deallocation substatements. 3. Sema:

[PATCH] D24598: Separate builtins for x84-64 and i386; implement __mulh and __umulh

This revision was automatically updated to reflect the committed changes. Closed by commit rL283264: Separate builtins for x84-64 and i386; implement __mulh and __umulh (authored by agutowski). Changed prior to commit: https://reviews.llvm.org/D24598?vs=73521=73570#toc Repository: rL LLVM

r283264 - Separate builtins for x84-64 and i386; implement __mulh and __umulh

Author: agutowski Date: Tue Oct 4 17:29:49 2016 New Revision: 283264 URL: http://llvm.org/viewvc/llvm-project?rev=283264=rev Log: Separate builtins for x84-64 and i386; implement __mulh and __umulh Summary: We need x86-64-specific builtins if we want to implement some of the MS intrinsics -

[PATCH] D24012: Fix strict-aliasing violation in typeinfo::hash_code()

rjmccall added a comment. LGTM, but I'm not a code owner here. https://reviews.llvm.org/D24012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24615: [OpenMP] clang doesnt diagnose if there is a lexical block around a for stmt for OpenMP loops. It is technically not allowed in the OpenMP standard

kkwli0 added a comment. Should we issue a warning message in this case? https://reviews.llvm.org/D24615 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25251: [libcxx] [test] Guard __has_include usage with a macro

EricWF added a comment. r283260. https://reviews.llvm.org/D25251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24598: Separate builtins for x84-64 and i386; implement __mulh and __umulh

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D24598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25251: [libcxx] [test] Guard __has_include usage with a macro

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Although I would have thought the first half of the conjunction would have prevented MSVC's PP from seeing the `__has_include`. I'll get to the rest of the patches tomorrow.

[libcxx] r283260 - [libcxx] [test] Guard __has_include usage with a macro

Author: ericwf Date: Tue Oct 4 16:25:51 2016 New Revision: 283260 URL: http://llvm.org/viewvc/llvm-project?rev=283260=rev Log: [libcxx] [test] Guard __has_include usage with a macro Summary: There's a macro scheme already being used for __has_feature etc. Use it for __has_include too, which

[PATCH] D25251: [libcxx] [test] Guard __has_include usage with a macro

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. There's a macro scheme already being used for __has_feature etc. Use it for __has_include too, which makes MSVC happy (it doesn't support __has_include yet, and unguarded use

[PATCH] D23236: When ARC is enabled, no warning will be generated when a method1. Returns 'nil' in a method that is attributed to return a 'nonnull'2. The return-statement is a ConditionalOperator, wh

parallaxe added a comment. In https://reviews.llvm.org/D23236#557898, @dcoughlin wrote: > Upon reflection, I don't think this is the right approach. > > Desugaring any AttributedType in the return type seems like a really, really > big hammer and could be an unexpected surprise for future

[PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

rmaprath added a comment. In https://reviews.llvm.org/D24562#561442, @Eugene.Zelenko wrote: > Looks like patch was not committed. Need to replicate this to as many tests as possible (~150). I was hoping to do all that and upload another diff for a final review, couldn't get to it I'm afraid.

r283258 - clang-cl: Make /Fo apply also when using -flto

Author: hans Date: Tue Oct 4 16:01:04 2016 New Revision: 283258 URL: http://llvm.org/viewvc/llvm-project?rev=283258=rev Log: clang-cl: Make /Fo apply also when using -flto Modified: cfe/trunk/lib/Driver/Driver.cpp cfe/trunk/test/Driver/cl-outputs.c Modified:

r283255 - clang-cl: Expose the -flto option

Author: hans Date: Tue Oct 4 16:00:57 2016 New Revision: 283255 URL: http://llvm.org/viewvc/llvm-project?rev=283255=rev Log: clang-cl: Expose the -flto option We could hook up /GL as an alias for -flto, but that might be confusing, as clang-cl in that mode would not be drop-in compatible with

r283257 - clang-cl: Use the .obj file extension also in LTO mode

Author: hans Date: Tue Oct 4 16:01:02 2016 New Revision: 283257 URL: http://llvm.org/viewvc/llvm-project?rev=283257=rev Log: clang-cl: Use the .obj file extension also in LTO mode Modified: cfe/trunk/lib/Driver/Types.cpp cfe/trunk/test/Driver/cl-outputs.c Modified:

r283256 - clang-cl: expose the -fuse-ld option

Author: hans Date: Tue Oct 4 16:01:00 2016 New Revision: 283256 URL: http://llvm.org/viewvc/llvm-project?rev=283256=rev Log: clang-cl: expose the -fuse-ld option Modified: cfe/trunk/include/clang/Driver/Options.td cfe/trunk/test/Driver/cl-link.c Modified:

[PATCH] D24488: Simplify Clang's version number configuration in CMake.

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL281666. https://reviews.llvm.org/D24488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24715: [OpenCL] Block captured variables in dynamic parallelism - OpenCL 2.0

Anastasia added a comment. > Regarding the improvement proposed by us which "flatten" captured variables > into invoke_function argument list and block_literal pointer wouldn't be > passed as first argument(to invoke_function) anymore. The reason why it > doesn't require global memory

r283253 - [analyzer] Add PostStmt callback for ArraySubscriptExpr

Author: zaks Date: Tue Oct 4 15:49:31 2016 New Revision: 283253 URL: http://llvm.org/viewvc/llvm-project?rev=283253=rev Log: [analyzer] Add PostStmt callback for ArraySubscriptExpr A patch by Jan Smets! Differential Revision: https://reviews.llvm.org/D25009 Modified:

[PATCH] D24703: [clang-format] BreakBeforeBinaryOperations and AlignAfterOpenBracket conflict, bug 30304

Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D24703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24712: Replace 'isProvablyNonNull' with existing utility llvm::IsKnownNonNull.

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL281979. https://reviews.llvm.org/D24712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r283251 - [clang] make reciprocal estimate codegen a function attribute

Author: spatel Date: Tue Oct 4 15:44:05 2016 New Revision: 283251 URL: http://llvm.org/viewvc/llvm-project?rev=283251=rev Log: [clang] make reciprocal estimate codegen a function attribute The motivation for the change is that we can't have pseudo-global settings for codegen living in

[PATCH] D24815: [clang] make reciprocal estimate codegen a function attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rL283251: [clang] make reciprocal estimate codegen a function attribute (authored by spatel). Changed prior to commit: https://reviews.llvm.org/D24815?vs=73364=73548#toc Repository: rL LLVM

r283249 - [ubsan] Disable bounds-check for flexible array ivars

Author: vedantk Date: Tue Oct 4 15:36:04 2016 New Revision: 283249 URL: http://llvm.org/viewvc/llvm-project?rev=283249=rev Log: [ubsan] Disable bounds-check for flexible array ivars This eliminates a class of false positives for -fsanitize=array-bounds on instrumented ObjC projects.

[PATCH] D24916: [analyzer] Extend bug reports with extra notes - CloneChecker

NoQ added inline comments. > chapuni wrote in CloneDetection.cpp:113 > You should update \param here. See also r283106. Thanks!! Will do. Repository: rL LLVM https://reviews.llvm.org/D24916 ___ cfe-commits mailing list

[PATCH] D22227: [ubsan] Disable bounds-check for flexible array ivars

vsk added a comment. Thanks for the review! I looked at the IR and confirmed that the ivars are laid out in the order they're defined, that the indirect ivar offsets make sense, and that the runtime ivar offsets match up with what we expect. E.g; @"OBJC_IVAR_$_FlexibleArray1.chars" = global

[PATCH] D24916: [analyzer] Extend bug reports with extra notes - CloneChecker

NoQ added a comment. In https://reviews.llvm.org/D24916#561369, @vitalybuka wrote: > Out of curiosity, how was MSVC crash solved? It wasn't, unfortunately; phabricator closed this revision by looking at the commit that was already reverted, with a delay (see

[PATCH] D22227: [ubsan] Disable bounds-check for flexible array ivars

This revision was automatically updated to reflect the committed changes. Closed by commit rL283249: [ubsan] Disable bounds-check for flexible array ivars (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D7?vs=73508=73547#toc Repository: rL LLVM

[PATCH] D24916: [analyzer] Extend bug reports with extra notes - CloneChecker

vitalybuka added a comment. Out of curiosity, how was MSVC crash solved? Repository: rL LLVM https://reviews.llvm.org/D24916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24961: [avx512] Add aliases to some missing avx512 intrinsics.

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL282488. https://reviews.llvm.org/D24961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r283246 - clang-format: Fix bad multi-variable for-loop formatting.

Author: djasper Date: Tue Oct 4 15:18:25 2016 New Revision: 283246 URL: http://llvm.org/viewvc/llvm-project?rev=283246=rev Log: clang-format: Fix bad multi-variable for-loop formatting. Before: for (int*p, *q; p != q; p = p->next) { After: for (int *p, *q; p != q; p = p->next) { Modified:

[PATCH] D25249: [libc++] Many any test fixes

CaseyCarter added a comment. I'll push a revision with the whitespace changes reverted soon. > .gitignore:59 > keep.lst > +.vscode/ This is an editor byproduct, I suppose, not "MSVC libraries test harness". Let me know if anyone cares and I'll add a comment. > any:553 > +

[PATCH] D25249: [libc++] Many any test fixes

CaseyCarter updated this revision to Diff 73538. CaseyCarter added a comment. Fix inadvertent whitespace changes. https://reviews.llvm.org/D25249 Files: .gitignore include/any test/libcxx/utilities/any/any.class/any.assign/value.pass.cpp

[PATCH] D24426: DebugInfo: Pass non-zero alignment to DIBuilder only if aligment was forced

vleschuk updated this revision to Diff 73537. vleschuk added a comment. Pass alignment in bits instead of bytes to backend (conversion is done when emitting DW_AT_alignment). https://reviews.llvm.org/D24426 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h

r283242 - [sancov] documentation update after r283241

Author: aizatsky Date: Tue Oct 4 14:19:16 2016 New Revision: 283242 URL: http://llvm.org/viewvc/llvm-project?rev=283242=rev Log: [sancov] documentation update after r283241 Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/SanitizerCoverage.rst URL:

[PATCH] D25249: [libc++] Many any test fixes

CaseyCarter created this revision. CaseyCarter added reviewers: EricWF, mclow.lists. CaseyCarter added a subscriber: cfe-commits. Changes to non-portable behavior in tests. Inline detailed description of each change is forthcoming. Changes are almost entirely in test code, with one behavioral

[PATCH] D25248: [libcxx] [test] Fix shadow warnings.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Fix MSVC shadow warnings in a newly added test, by renaming local variables. https://reviews.llvm.org/D25248 Files: test/std/utilities/utility/forward/move.pass.cpp

[PATCH] D23853: Assert in performTrivialCopy - Bug report and a possible solution

zaks.anna added a comment. Should this revision be closed? https://reviews.llvm.org/D23853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24598: Separate builtins for x84-64 and i386; implement __mulh and __umulh

agutowski added inline comments. > agutowski wrote in TargetBuiltins.h:100 > Nice, thanks! > As far as I see, it creates some inconsistency in usage of the word "last", > because it's used wrong everywhere else - LastTSBuiltin is the number of the > last target-specific builtin **plus one**,

[PATCH] D24598: Separate builtins for x84-64 and i386; implement __mulh and __umulh

agutowski added inline comments. > rnk wrote in TargetBuiltins.h:100 > I think this would be better with just one enum to reduce compilation time: > > /// \brief X86 builtins > namespace X86 { > enum { > LastTIBuiltin = clang::Builtin::FirstTSBuiltin - 1, > #define

[PATCH] D24615: [OpenMP] clang doesnt diagnose if there is a lexical block around a for stmt for OpenMP loops. It is technically not allowed in the OpenMP standard

davidsh updated this revision to Diff 73520. davidsh added a comment. Adding a parameter to IgnoreContainers instead of copying the logic. https://reviews.llvm.org/D24615 Files: include/clang/AST/Stmt.h lib/AST/Stmt.cpp lib/Sema/SemaOpenMP.cpp test/OpenMP/for_loop_messages.cpp Index:

Re: [PATCH] D25199: [ubsan] Sanitize deleted pointers

Hi Richard, Thanks for your analysis. This patch is intended to mitigate use-after-free bugs. In that context a “define strict behavior for invalid pointer values” we could deploy in production code would be very useful. Maybe calling this a sanitizer is misleading, and instead it could be

[PATCH] D24598: Separate builtins for x84-64 and i386; implement __mulh and __umulh

agutowski updated this revision to Diff 73521. agutowski added a comment. merge enums https://reviews.llvm.org/D24598 Files: include/clang/Basic/BuiltinsX86_64.def include/clang/Basic/TargetBuiltins.h lib/Basic/Targets.cpp lib/CodeGen/CGBuiltin.cpp lib/Headers/intrin.h

[PATCH] D25153: preprocessor supports `-dI` flag

elsteveogrande updated this revision to Diff 73518. elsteveogrande added a comment. - Fix a few more style nits according to LLVM style guide. - Further fixed w/ `clang-format -style=LLVM`, kept (most of) recommended changes. - Added more unit tests (more include cases: `#include_next`,

r283235 - Test what happens when tag lookup and redeclaration lookup disagree

Author: rnk Date: Tue Oct 4 13:10:23 2016 New Revision: 283235 URL: http://llvm.org/viewvc/llvm-project?rev=283235=rev Log: Test what happens when tag lookup and redeclaration lookup disagree Clang has a diagnostic for the what happens when an elaborated type implicitly creates a tag

[PATCH] D24598: Separate builtins for x84-64 and i386; implement __mulh and __umulh

rnk added a comment. Let's avoid the duplicate enum, otherwise looks good > TargetBuiltins.h:100 > + /// \brief X86-64 builtins > + namespace X86_64 { > + enum { I think this would be better with just one enum to reduce compilation time: /// \brief X86 builtins namespace X86 {

[PATCH] D22227: [ubsan] Disable bounds-check for flexible array ivars

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Can you double-check that the memory layout is actually what we think it is by inspecting the generated IR? Otherwise this LGTM. https://reviews.llvm.org/D7

[PATCH] D25204: Register Calling Convention, Clang changes

majnemer added inline comments. > ItaniumMangle.cpp:1234 > > - mangleSourceName(II); > + auto FD = dyn_cast(ND); > + bool isRegCall = (FD != nullptr) && `auto *` > ItaniumMangle.cpp:1235 > + auto FD = dyn_cast(ND); > + bool isRegCall = (FD != nullptr) && > +

[PATCH] D25153: preprocessor supports `-dI` flag

elsteveogrande added a comment. Thanks again @majnemer! Other vars are fixed, will send an update shortly. > majnemer wrote in PrintPreprocessedOutput.cpp:344 > Could this just return a StringRef? You could use an empty StringRef on > failure. I'll get rid of this in favor of

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge removed rL LLVM as the repository for this revision. rSerge updated this revision to Diff 73509. rSerge added a comment. My mistake was that initially I only enumerated the unsupported targets from llvm\include\llvm\ADT\Triple.h . Now I've added also the cases from

[PATCH] D25204: Register Calling Convention, Clang changes

majnemer added inline comments. > ItaniumMangle.cpp:1413-1414 > > -void CXXNameMangler::mangleSourceName(const IdentifierInfo *II) { > - // ::= > +void CXXNameMangler::mangleSourceName(const IdentifierInfo *II, > + bool isRegCall) { > + // ::=

[PATCH] D25241: [libcxx] Improve code generation for vector::clear().

mclow.lists added a comment. I had no idea that we had no tests for `vector::clear`. Oosps. This looks good to me, but I want to play with the codegen for a bit before approving it. Also, you should add `cfe-commits` to the subscribers. thanks for doing this! > clear.pass.cpp:25 > +

[PATCH] D25204: Register Calling Convention, Clang changes

rnk added inline comments. > erichkeane wrote in ItaniumMangle.cpp:1236-1237 > Right, good catch. I looked at Mangle.cpp which does something very similar, > and assumes that FunctionType is a valid cast here, so I've switched this > here too, please let me know if that is a wrong assumption.

[PATCH] D24815: [clang] make reciprocal estimate codegen a function attribute

spatel added inline comments. > mehdi_amini wrote in CGCall.cpp:1735 > I think I remember folks being against FMF on calls (Chris Lattner?), I'll > try to find the relevant discussion. > Otherwise your plan seems fine to me! Yes - Chris was opposed to FMF on intrinsics (preferring

[PATCH] D25153: preprocessor supports `-dI` flag

majnemer added inline comments. > majnemer wrote in PrintPreprocessedOutput.cpp:321-325 > Variables should start with uppercase characters. Please uppercase all your other variables too. > PrintPreprocessedOutput.cpp:344 > + */ > +bool tryGetTokenText(StringRef *text, const Token ) { > + if

[PATCH] D25204: Register Calling Convention, Clang changes

erichkeane added inline comments. > rnk wrote in TargetInfo.cpp:3742-3743 > But, if the return value is returned directly, it doesn't conflict with the > free parameter registers. In my example, the return value can use XMM0-3 and > the parameters can use XMM0-15. Can you add this test case

Re: [PATCH] D25199: [ubsan] Sanitize deleted pointers

On Mon, Oct 3, 2016 at 2:59 PM, Peter Collingbourne wrote: > pcc added a reviewer: rsmith. > pcc added a comment. > > It seems to me that this sanitizer would break the semantics of otherwise > well-defined programs. For example: > > int *x = nullptr; > delete x; > if (x

[PATCH] D25204: Register Calling Convention, Clang changes

rnk added inline comments. > erichkeane wrote in TargetInfo.cpp:3742-3743 > That was my intent, this should allow return values to be in registers as > well if I'm reading the spec correctly. The idea is that register use is > 'greedy'. But, if the return value is returned directly, it

[PATCH] D25204: Register Calling Convention, Clang changes

erichkeane updated this revision to Diff 73507. erichkeane marked an inline comment as done. erichkeane added a comment. Herald added a subscriber: dschuff. Fixes based on Alexey/Ried's feedback https://reviews.llvm.org/D25204 Files: include/clang-c/Index.h include/clang/AST/Type.h

[PATCH] D24815: [clang] make reciprocal estimate codegen a function attribute

echristo added inline comments. > mehdi_amini wrote in CGCall.cpp:1735 > I think I remember folks being against FMF on calls (Chris Lattner?), I'll > try to find the relevant discussion. > Otherwise your plan seems fine to me! Agreed. Also shouldn't hold up this patch :)

[PATCH] D22227: [ubsan] Disable bounds-check for flexible array ivars

vsk added a comment. The ivar list is set by all_declared_ivar_begin(), which accounts for ivars introduced by an implementation. Thanks for raising the point. Consider this test: @interface HasFlexibleArray { @public char chars[0]; } @implementation HasFlexibleArray { @public char

[PATCH] D25244: [clang-tidy] Add a whitelist option in google-runtime-references.

hokein created this revision. hokein added a reviewer: aaron.ballman. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D25244 Files: clang-tidy/google/NonConstReferences.cpp clang-tidy/google/NonConstReferences.h docs/clang-tidy/checks/google-runtime-references.rst

[PATCH] D24998: Add a new optimization option -Og

probinson added a comment. As Renato points out, this addresses the user experience of tripping over the lack of -Og, however it does not really address the intent of PR20765 which is to provide a mode of optimizations that don't particularly interfere with debugging. Eventually someone needs

  1   2   3   >