r289181 - [Headers] Add #include_next for tgmath.h on Darwin

2016-12-08 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Thu Dec 8 21:30:46 2016 New Revision: 289181 URL: http://llvm.org/viewvc/llvm-project?rev=289181=rev Log: [Headers] Add #include_next for tgmath.h on Darwin Allow darwin to provide additional definitions and implementation specifc values for tgmath.h on Apple platforms.

Re: r288866 - [c++17] P0135R1: Guaranteed copy elision.

2016-12-08 Thread Duncan P. N. Exon Smith via cfe-commits
> On 2016-Dec-08, at 19:29, Richard Smith wrote: > > On 8 Dec 2016 7:17 pm, "Duncan P. N. Exon Smith via cfe-commits" > wrote: > +Eric, Marshall > > I haven't looked, but: from the test name, "copy.fail.cpp", I suspect there > is a

Re: r288866 - [c++17] P0135R1: Guaranteed copy elision.

2016-12-08 Thread Duncan P. N. Exon Smith via cfe-commits
Hmm, never mind. The test seems to preclude copy elision if I'm looking in the right place: std::streambuf (); int main() { std::streambuf sb = get(); // expected-error } > On 2016-Dec-08, at 19:17, Duncan P. N. Exon Smith via cfe-commits > wrote: > >

Re: r288866 - [c++17] P0135R1: Guaranteed copy elision.

2016-12-08 Thread Richard Smith via cfe-commits
On 8 Dec 2016 7:17 pm, "Duncan P. N. Exon Smith via cfe-commits" < cfe-commits@lists.llvm.org> wrote: +Eric, Marshall I haven't looked, but: from the test name, "copy.fail.cpp", I suspect there is a bug/incompatibility in the test. It likely relies on the compiler trying (and failing) to copy

[libcxx] r289178 - fix misspelling in .clang-format

2016-12-08 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Dec 8 21:18:45 2016 New Revision: 289178 URL: http://llvm.org/viewvc/llvm-project?rev=289178=rev Log: fix misspelling in .clang-format Modified: libcxx/trunk/.clang-format Modified: libcxx/trunk/.clang-format URL:

[libcxx] r289177 - Turn off header sorting and comment formatting

2016-12-08 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Dec 8 21:17:25 2016 New Revision: 289177 URL: http://llvm.org/viewvc/llvm-project?rev=289177=rev Log: Turn off header sorting and comment formatting Modified: libcxx/trunk/.clang-format Modified: libcxx/trunk/.clang-format URL:

r289176 - [CrashReproducer] Provide a clean dir path for -fmodules-cache-path

2016-12-08 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Thu Dec 8 21:11:48 2016 New Revision: 289176 URL: http://llvm.org/viewvc/llvm-project?rev=289176=rev Log: [CrashReproducer] Provide a clean dir path for -fmodules-cache-path The most common workflow with module reproducers involves deleting the module cache before running

Re: r288866 - [c++17] P0135R1: Guaranteed copy elision.

2016-12-08 Thread Duncan P. N. Exon Smith via cfe-commits
+Eric, Marshall I haven't looked, but: from the test name, "copy.fail.cpp", I suspect there is a bug/incompatibility in the test. It likely relies on the compiler trying (and failing) to copy something in a context where r288866 guarantees that there is no copy. > On 2016-Dec-08, at 18:00,

r289174 - [CrashReproducer] Rewrite relative include paths

2016-12-08 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Thu Dec 8 20:22:47 2016 New Revision: 289174 URL: http://llvm.org/viewvc/llvm-project?rev=289174=rev Log: [CrashReproducer] Rewrite relative include paths When -fmodules is on, the reproducer invocation currently leave paths for include-like flags as is. If the path is

Re: [PATCH] D27545: Don't assert when redefining a built-in macro in a PCH, PR29119

2016-12-08 Thread Nico Weber via cfe-commits
(I replied to comments about 1h ago, looks like phab is not in the mood for sending a mail for that for some reason. I did use the "Leap into action" submit button.) On Wed, Dec 7, 2016 at 9:19 PM, Richard Smith via Phabricator < revi...@reviews.llvm.org> wrote: > rsmith added inline comments. >

Re: r288866 - [c++17] P0135R1: Guaranteed copy elision.

2016-12-08 Thread Adrian Prantl via cfe-commits
Hi Richard, at this point this is more a heads-up than anything actionable, but I wanted to let you know that I bisected this bot failure (http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/2721/consoleFull#10584592348254eaf0-7326-4999-85b0-388101f2d404) of

r289167 - Specify -std=gnu++98 on some Rewriter tests. NFC.

2016-12-08 Thread Paul Robinson via cfe-commits
Author: probinson Date: Thu Dec 8 19:20:40 2016 New Revision: 289167 URL: http://llvm.org/viewvc/llvm-project?rev=289167=rev Log: Specify -std=gnu++98 on some Rewriter tests. NFC. Rewriter tests rewrite Objective-C++ to C++, and then compile the result. The rewritten result sometimes doesn't

r289160 - [AST, ASTMatchers, Basic] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

2016-12-08 Thread Eugene Zelenko via cfe-commits
Author: eugenezelenko Date: Thu Dec 8 18:11:53 2016 New Revision: 289160 URL: http://llvm.org/viewvc/llvm-project?rev=289160=rev Log: [AST, ASTMatchers, Basic] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified:

r289159 - [DOXYGEN] Improved doxygen comments for xmmintrin.h intrinsics.

2016-12-08 Thread Ekaterina Romanova via cfe-commits
Author: kromanova Date: Thu Dec 8 17:58:39 2016 New Revision: 289159 URL: http://llvm.org/viewvc/llvm-project?rev=289159=rev Log: [DOXYGEN] Improved doxygen comments for xmmintrin.h intrinsics. Tagged parameter names with \a doxygen command to display parameters in italics. Formatted comments

[libcxx] r289158 - Fix PR27374 - Remove the implicit reduced-arity-extension in tuple.

2016-12-08 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Dec 8 17:57:08 2016 New Revision: 289158 URL: http://llvm.org/viewvc/llvm-project?rev=289158=rev Log: Fix PR27374 - Remove the implicit reduced-arity-extension in tuple. This patch removes libc++'s tuple extension which allowed it to be constructed from fewer

r289154 - [DOXYGEN] Improved doxygen comments.

2016-12-08 Thread Ekaterina Romanova via cfe-commits
Author: kromanova Date: Thu Dec 8 17:32:07 2016 New Revision: 289154 URL: http://llvm.org/viewvc/llvm-project?rev=289154=rev Log: [DOXYGEN] Improved doxygen comments. Improved doxygen comments for fxsrintrin.h and mmintrin.h intrinsics by taagging parameter names with \a doxygen command to

[PATCH] D21453: Add support for attribute "overallocated"

2016-12-08 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added inline comments. Comment at: include/clang/AST/Decl.h:3250 + /// This is true if this struct ends with an array marked 'flexible_array'. + bool HasFlexibleArrayAttr : 1; + rsmith wrote: > How is this different from `HasFlexibleArrayMember`? Do

[PATCH] D26267: [Modules] Include builtins with #include instead of #import for ObjC

2016-12-08 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno added a comment. Any thoughts on this @rsmith ? https://reviews.llvm.org/D26267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r289144 - [sanitizers] lsan+sancov doesn't need ubsanrt (multi def error)

2016-12-08 Thread Mike Aizatsky via cfe-commits
Author: aizatsky Date: Thu Dec 8 16:25:01 2016 New Revision: 289144 URL: http://llvm.org/viewvc/llvm-project?rev=289144=rev Log: [sanitizers] lsan+sancov doesn't need ubsanrt (multi def error) Reviewers: eugenis Differential Revision: https://reviews.llvm.org/D27594 Modified:

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

2016-12-08 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons added a comment. In https://reviews.llvm.org/D27166#617621, @Prazek wrote:. > Does it work for cases like? Yes; `replaceExpr()` checks that the variable has the same unqualified type as the initializer and the same canonical type as other variables in the declaration.

[PATCH] D27279: Store decls in prototypes on the declarator instead of in the AST

2016-12-08 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: include/clang/Sema/DeclSpec.h:1240 +/// in the prototype. These are generally tag types or enumerators. +unsigned NumDeclsInPrototype : 8; + rnk wrote: > rsmith wrote: > > It seems plausible that generated code

[PATCH] D27279: Store decls in prototypes on the declarator instead of in the AST

2016-12-08 Thread Reid Kleckner via Phabricator via cfe-commits
rnk updated this revision to Diff 80827. rnk marked an inline comment as done. rnk added a comment. - Reuse EH specifier storage in C - Revert dumper change https://reviews.llvm.org/D27279 Files: include/clang/AST/Decl.h include/clang/Sema/DeclSpec.h include/clang/Sema/Sema.h

r289116 - [DOXYGEN] Improved doxygen comments for emmintrin.h intrinsics.

2016-12-08 Thread Ekaterina Romanova via cfe-commits
Author: kromanova Date: Thu Dec 8 16:10:51 2016 New Revision: 289116 URL: http://llvm.org/viewvc/llvm-project?rev=289116=rev Log: [DOXYGEN] Improved doxygen comments for emmintrin.h intrinsics. Tagged parameter names with \a doxygen command to display parameters in italics. Formatted comments

[libcxx] r289109 - [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 5/7.

2016-12-08 Thread Stephan T. Lavavej via cfe-commits
Author: stl_msft Date: Thu Dec 8 15:38:32 2016 New Revision: 289109 URL: http://llvm.org/viewvc/llvm-project?rev=289109=rev Log: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 5/7. Instead of storing double in double and then truncating to int,

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

2016-12-08 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek added a reviewer: staronj. Prazek added a comment. gosh, I found it too late. Jakub started to work on the same problem and he have made initial check for it. One of the problems he got was multideclarations. Does it work for cases like? long a = lexical_cast(z), b = lexical_cast(y);

[libcxx] r289108 - [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 4/7.

2016-12-08 Thread Stephan T. Lavavej via cfe-commits
Author: stl_msft Date: Thu Dec 8 15:38:23 2016 New Revision: 289108 URL: http://llvm.org/viewvc/llvm-project?rev=289108=rev Log: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 4/7. Change char to long and remove some char casts. This preserves

[libcxx] r289107 - [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 3/7.

2016-12-08 Thread Stephan T. Lavavej via cfe-commits
Author: stl_msft Date: Thu Dec 8 15:38:14 2016 New Revision: 289107 URL: http://llvm.org/viewvc/llvm-project?rev=289107=rev Log: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 3/7. Add static_cast when constructing pair from

[libcxx] r289111 - [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 7/7.

2016-12-08 Thread Stephan T. Lavavej via cfe-commits
Author: stl_msft Date: Thu Dec 8 15:38:57 2016 New Revision: 289111 URL: http://llvm.org/viewvc/llvm-project?rev=289111=rev Log: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 7/7.

[libcxx] r289110 - [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 6/7.

2016-12-08 Thread Stephan T. Lavavej via cfe-commits
Author: stl_msft Date: Thu Dec 8 15:38:44 2016 New Revision: 289110 URL: http://llvm.org/viewvc/llvm-project?rev=289110=rev Log: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 6/7.

[libcxx] r289106 - [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 2/7.

2016-12-08 Thread Stephan T. Lavavej via cfe-commits
Author: stl_msft Date: Thu Dec 8 15:38:01 2016 New Revision: 289106 URL: http://llvm.org/viewvc/llvm-project?rev=289106=rev Log: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 2/7. These tests for some guy's transparent operator functors were

[libcxx] r289105 - [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 1/7.

2016-12-08 Thread Stephan T. Lavavej via cfe-commits
Author: stl_msft Date: Thu Dec 8 15:37:47 2016 New Revision: 289105 URL: http://llvm.org/viewvc/llvm-project?rev=289105=rev Log: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 1/7. Given `std::basic_streambuf::int_type __c`, `std::basic_string

[PATCH] D26196: Add support for non-zero null pointer for C and OpenCL

2016-12-08 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1532 + return llvm::ConstantInt::get(ConvertType(DestTy), + CGF.getContext().getTargetNullPtrValue(E->getType())); assert(!DestTy->isBooleanType() && "bool should use PointerToBool");

[PATCH] D27589: [DebugInfo] Relax test case for long double constants.

2016-12-08 Thread David Gross via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289103: [DebugInfo] Relax test case for long double constants. (authored by dgross). Changed prior to commit: https://reviews.llvm.org/D27589?vs=80815=80817#toc Repository: rL LLVM

r289103 - [DebugInfo] Relax test case for long double constants.

2016-12-08 Thread David Gross via cfe-commits
Author: dgross Date: Thu Dec 8 15:15:17 2016 New Revision: 289103 URL: http://llvm.org/viewvc/llvm-project?rev=289103=rev Log: [DebugInfo] Relax test case for long double constants. Summary: D27549 (partial fix for PR26619) emits a constant value in the debug metadata for a floating-point

[PATCH] D27589: [DebugInfo] Relax test case for long double constants.

2016-12-08 Thread David Gross via Phabricator via cfe-commits
dgross created this revision. dgross added reviewers: cfe-commits, probinson. https://reviews.llvm.org/D27549 (partial fix for PR26619) emits a constant value in the debug metadata for a floating-point static const that does not exceed 64 bits in size. The regression test accompanying that fix

[PATCH] D27535: [analyzer] Add ObjCPropertyChecker - check for autosynthesized copy-properties of mutable types.

2016-12-08 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 80811. NoQ added a comment. Don't yell at read-only properties (no -copy is performed). Single-quote 'copy' in the error messages. https://reviews.llvm.org/D27535 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D26626: [libcxx] [test] Fix an improper assumption about Null Forward Iterators.

2016-12-08 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT added a comment. I could mark these assertions as libcxx-specific, but I tend to believe that they should be removed outright (even if the natural implementation of a list without debug checks provides this behavior). https://reviews.llvm.org/D26626

[PATCH] D27541: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 4/7.

2016-12-08 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT added a comment. Responded to https://reviews.llvm.org/D27540. tuple is affected just like pair. https://reviews.llvm.org/D27541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27544: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 7/7.

2016-12-08 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT updated the summary for this revision. STL_MSFT updated this revision to Diff 80810. STL_MSFT marked an inline comment as done. STL_MSFT added a comment. Changed test/std/re/re.traits/value.pass.cpp to iterate with wchar_t as requested. https://reviews.llvm.org/D27544 Files:

[PATCH] D27544: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 7/7.

2016-12-08 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT marked an inline comment as done. STL_MSFT added inline comments. Comment at: test/std/re/re.traits/value.pass.cpp:119 } for (int c = 'g'; c < 0x; ++c) { EricWF wrote: > Can't we just make `c` a `wchar_t` like above? Yes

[PATCH] D27540: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 3/7.

2016-12-08 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Huh. Thanks for the analysis. LGTM. https://reviews.llvm.org/D27540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27540: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 3/7.

2016-12-08 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT added a comment. I checked, and Clang 3.8.0 behaves identically to C1XX in the pair scenario. Here's the test case: #include template struct Pair { A a; B b; template Pair(X&& x, Y&& y) : a(std::forward(x)), b(std::forward(y)) { } }; int

[PATCH] D27540: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 3/7.

2016-12-08 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT added a comment. I can't possibly defend C1XX's behavior in your foo() scenario - but the pair scenarios being fixed here are different. pair's constructor from (X&&, Y&&) is perfect forwarding, so while the compiler can see that literals are being passed to (int&&, int&&), when

[PATCH] D27549: [DebugInfo] Add support for __fp16, float, and double constants.

2016-12-08 Thread David Gross via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289094: [DebugInfo] Add support for __fp16, float, and double constants. (authored by dgross). Changed prior to commit: https://reviews.llvm.org/D27549?vs=80683=80806#toc Repository: rL LLVM

[PATCH] D26196: Add support for non-zero null pointer for C and OpenCL

2016-12-08 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated the summary for this revision. yaxunl updated this revision to Diff 80804. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by John's comments. Added source QualType parameter to performAddrSpaceCast. Changed linkage of tentative definition of global var

r289094 - [DebugInfo] Add support for __fp16, float, and double constants.

2016-12-08 Thread David Gross via cfe-commits
Author: dgross Date: Thu Dec 8 14:02:46 2016 New Revision: 289094 URL: http://llvm.org/viewvc/llvm-project?rev=289094=rev Log: [DebugInfo] Add support for __fp16, float, and double constants. Summary: Partial fix for PR26619. Prior to this change, a DIGlobalVariable corresponding to a static

[PATCH] D27555: [libcxx] [test] Fix MSVC warning C6001 "Using uninitialized memory".

2016-12-08 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT added a comment. It was debatable to me whether this was actually a compiler bug, but I suppose that it can see size()'s definition and should be able to notice that the elements aren't accessed. I've filed VSO#300037 "Bogus warning C6001 "Using uninitialized memory" for

[PATCH] D26750: [clang-tidy] Add modernize-use-default-member-init check

2016-12-08 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons added a comment. In https://reviews.llvm.org/D26750#617316, @Eugene.Zelenko wrote: > How does check handle bit fields? There is no warning for bit fields. I don't think the C++17 bit field initializer proposal has been accepted yet. > Will be also good idea to add test case

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

2016-12-08 Thread Artem Belevich via Phabricator via cfe-commits
tra marked an inline comment as done. tra added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7048 // target attributes into account, we perform target match check // here and reject candidates that have different target. if (LangOpts.CUDA &&

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

2016-12-08 Thread Artem Belevich via Phabricator via cfe-commits
tra updated this revision to Diff 80783. tra marked 3 inline comments as done. tra added a comment. Fixed comments. https://reviews.llvm.org/D25845 Files: include/clang/Sema/Sema.h lib/Sema/SemaCUDA.cpp lib/Sema/SemaDecl.cpp lib/Sema/SemaTemplate.cpp

[PATCH] D27580: [modules] Add optional out-param to ASTReader::ReadAST for imported submodules.

2016-12-08 Thread Doug Gregor via Phabricator via cfe-commits
doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D27580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27580: [modules] Add optional out-param to ASTReader::ReadAST for imported submodules.

2016-12-08 Thread Graydon Hoare via Phabricator via cfe-commits
graydon created this revision. graydon added reviewers: doug.gregor, manmanren, rsmith. graydon added a subscriber: cfe-commits. The Swift frontend is acquiring the ability to load non-module PCH files containing bridging definitions from C/ObjC. As part of this work, it needs to know which

[PATCH] D26750: [clang-tidy] Add modernize-use-default-member-init check

2016-12-08 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. How does check handle bit fields? I encountered problem on next code in ASTContext.h: struct TypeInfo { uint64_t Width; unsigned Align; bool AlignIsRequired : 1; TypeInfo() : Width(0), Align(0), AlignIsRequired(false) {} }; Will be also good idea to

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

2016-12-08 Thread Justin Lebar via Phabricator via cfe-commits
jlebar accepted this revision. jlebar added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaDecl.cpp:8415 +// specialization inherits its target attributes from its template +// in CheckFunctionTemplateSpecialization() call

r289083 - [DOXYGEN] Improved doxygen comments.

2016-12-08 Thread Ekaterina Romanova via cfe-commits
Author: kromanova Date: Thu Dec 8 11:57:23 2016 New Revision: 289083 URL: http://llvm.org/viewvc/llvm-project?rev=289083=rev Log: [DOXYGEN] Improved doxygen comments. Improved doxygen comments for __wmmintrin_pclmul.h and ammintrin.h intrinsics by taagging parameter names with \a doxygen

[PATCH] D27488: Fixing test to work when the compiler defaults to a different c++ standard version.

2016-12-08 Thread Douglas Yung via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289075: Fixing test to work when the compiler defaults to a different C++ standard… (authored by dyung). Changed prior to commit: https://reviews.llvm.org/D27488?vs=80496=80776#toc Repository: rL

r289075 - Fixing test to work when the compiler defaults to a different C++ standard version.

2016-12-08 Thread Douglas Yung via cfe-commits
Author: dyung Date: Thu Dec 8 11:27:20 2016 New Revision: 289075 URL: http://llvm.org/viewvc/llvm-project?rev=289075=rev Log: Fixing test to work when the compiler defaults to a different C++ standard version. Differential Revision: https://reviews.llvm.org/D27488 Modified:

[PATCH] D27206: [libcxx] Test support for the externally threaded libcxxabi variant

2016-12-08 Thread Asiri Rathnayake via Phabricator via cfe-commits
rmaprath abandoned this revision. rmaprath added a comment. Abandoning (replaced with https://reviews.llvm.org/D27575/https://reviews.llvm.org/D27576). https://reviews.llvm.org/D27206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25660: [Analyzer] Checker for iterators dereferenced beyond their range.

2016-12-08 Thread Anna Zaks via Phabricator via cfe-commits
zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:721 + +static bool inTopLevelNamespace(const Decl *D, IdentifierInfo *II) { + const auto *ND = dyn_cast(D->getDeclContext()); zaks.anna wrote: > Would

[PATCH] D27576: [libcxx] libc++ changes necessary for the externally threaded libcxxabi variant

2016-12-08 Thread Asiri Rathnayake via Phabricator via cfe-commits
rmaprath created this revision. rmaprath added reviewers: EricWF, mclow.lists. rmaprath added a subscriber: cfe-commits. Herald added a subscriber: mgorny. This patch adds support for https://reviews.llvm.org/D27575. A couple of new threading API calls has been introduced (libc++abi requires

[PATCH] D27204: [libcxxabi] Introduce an externally threaded libc++abi variant

2016-12-08 Thread Asiri Rathnayake via Phabricator via cfe-commits
rmaprath abandoned this revision. rmaprath added a comment. Abandoning as this has been replaced with https://reviews.llvm.org/D27575. https://reviews.llvm.org/D27204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27575: [libcxxabi] Introduce an externally threaded libc++abi variant (take-2)

2016-12-08 Thread Asiri Rathnayake via Phabricator via cfe-commits
rmaprath created this revision. rmaprath added reviewers: EricWF, mclow.lists. rmaprath added a subscriber: cfe-commits. Herald added a subscriber: mgorny. This is a replacement for https://reviews.llvm.org/D27204. Re-worked so that we use the threading API of `libcxx` instead of creating a

r289068 - [CodeCompletion][ObjC] Use a parameterized NSSet return type for

2016-12-08 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu Dec 8 10:49:05 2016 New Revision: 289068 URL: http://llvm.org/viewvc/llvm-project?rev=289068=rev Log: [CodeCompletion][ObjC] Use a parameterized NSSet return type for keyPathsForValuesAffecting* KVO completion results rdar://23791701 Modified:

[PATCH] D26137: [clang-tidy] Add check name to YAML export

2016-12-08 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Looks like compiler has found a couple of bugs: In file included from llvm.git/tools/clang/tools/extra/clang-tidy/ClangTidy.cpp:38:

[PATCH] D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value

2016-12-08 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Ping Repository: rL LLVM https://reviews.llvm.org/D27165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27053: [CodeCompletion] Provide Objective-C class property completion results

2016-12-08 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. arphaman marked an inline comment as done. Closed by commit rL289058: [CodeCompletion] Provide Objective-C class property completion results (authored by arphaman). Changed prior to commit:

r289058 - [CodeCompletion] Provide Objective-C class property completion results

2016-12-08 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu Dec 8 09:09:40 2016 New Revision: 289058 URL: http://llvm.org/viewvc/llvm-project?rev=289058=rev Log: [CodeCompletion] Provide Objective-C class property completion results This commit provides class property code completion results. It supports explicit and implicit

[PATCH] D26137: [clang-tidy] Add check name to YAML export

2016-12-08 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. The patch spans two repos, so I couldn't apply it using arcanist. Just made it "manually" (patch -p0 -i ...); now running tests... Repository: rL LLVM https://reviews.llvm.org/D26137 ___ cfe-commits mailing list

[PATCH] D27123: Add AVR target and toolchain to Clang

2016-12-08 Thread Jonathan Roelofs via Phabricator via cfe-commits
jroelofs added a subscriber: rengolin. jroelofs added a comment. In https://reviews.llvm.org/D27123#616887, @saaadhu wrote: > Make defines for CHAR16_TYPE, {U,}INT_{LEAST,FAST}16_TYPE use int instead of > short. > > {U,}INT16_TYPE still gets defined as short though - >

[PATCH] D27299: [Sema] C++11 opaque enums should avoid the "case value not in enumerated type" switch warning

2016-12-08 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289055: [Sema] Avoid "case value not in enumerated type" warning for C++11 opaque enums (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D27299?vs=79892=80757#toc Repository:

r289055 - [Sema] Avoid "case value not in enumerated type" warning for C++11 opaque enums

2016-12-08 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Thu Dec 8 08:46:05 2016 New Revision: 289055 URL: http://llvm.org/viewvc/llvm-project?rev=289055=rev Log: [Sema] Avoid "case value not in enumerated type" warning for C++11 opaque enums This commit ensures that the switch warning "case value not in enumerated type" isn't

Re: r285301 - Attempt to make clang-format.py python 3 - compatible.

2016-12-08 Thread Alexander Kornienko via cfe-commits
If this fixes the problem on python 3 (and it leaves the current behavior on python 2), then it looks good. Can you submit it? On Wed, Dec 7, 2016 at 6:59 AM, Vedant Kumar wrote: > Hi Alexander, > > I think this will cause an error if used with python3 (at least, it fails > on

[PATCH] D27535: [analyzer] Add ObjCPropertyChecker - check for autosynthesized copy-properties of mutable types.

2016-12-08 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 80756. NoQ added a comment. Don't construct a `StringRef` to a temporary `std::string`. https://reviews.llvm.org/D27535 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt

[PATCH] D27535: [analyzer] Add ObjCPropertyChecker - check for autosynthesized copy-properties of mutable types.

2016-12-08 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ObjCPropertyChecker.cpp:68 +return; + + BR.EmitBasicReport( dcoughlin wrote: > You'll also want to make sure to not warn on the following idiom, in which > programmers use @synthesize to

[PATCH] D27535: [analyzer] Add ObjCPropertyChecker - check for autosynthesized copy-properties of mutable types.

2016-12-08 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 80751. NoQ marked an inline comment as done. NoQ added a comment. - Address comments - Richer warning message (is it in good shape?) - Add tests for lack of implementation https://reviews.llvm.org/D27535 Files:

[PATCH] D27409: [analyzer] RetainCountChecker: The callback in dispatch_data_create() doesn't free the return symbol.

2016-12-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289047: [analyzer] Add dispatch_data_create as a special case in RetainCountChecker. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D27409?vs=80606=80750#toc Repository:

r289047 - [analyzer] Add dispatch_data_create as a special case in RetainCountChecker.

2016-12-08 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Thu Dec 8 08:05:48 2016 New Revision: 289047 URL: http://llvm.org/viewvc/llvm-project?rev=289047=rev Log: [analyzer] Add dispatch_data_create as a special case in RetainCountChecker. This function receives a callback block. The analyzer suspects that this block may be

r289042 - [ASTMatcher] Add hasReplacementType matcher for SubstTemplateTypeParmType

2016-12-08 Thread Malcolm Parsons via cfe-commits
Author: malcolm.parsons Date: Thu Dec 8 05:46:22 2016 New Revision: 289042 URL: http://llvm.org/viewvc/llvm-project?rev=289042=rev Log: [ASTMatcher] Add hasReplacementType matcher for SubstTemplateTypeParmType Summary: Needed for https://reviews.llvm.org/D27166 Reviewers: sbenza, bkramer,

[PATCH] D27447: [ASTMatcher] Add hasReplacementType matcher for SubstTemplateTypeParmType

2016-12-08 Thread Malcolm Parsons via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289042: [ASTMatcher] Add hasReplacementType matcher for SubstTemplateTypeParmType (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D27447?vs=80465=80741#toc Repository:

[PATCH] D27447: [ASTMatcher] Add hasReplacementType matcher for SubstTemplateTypeParmType

2016-12-08 Thread Manuel Klimek via Phabricator via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. Looks good. Thanks! https://reviews.llvm.org/D27447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D21075: Correct invalid end location in diagnostics for some identifiers.

2016-12-08 Thread Erik Verbruggen via Phabricator via cfe-commits
erikjv updated this revision to Diff 80735. https://reviews.llvm.org/D21075 Files: lib/Parse/ParseDecl.cpp lib/Sema/SemaExpr.cpp test/Index/diagnostic-ranges.cpp Index: test/Index/diagnostic-ranges.cpp === --- /dev/null +++

[PATCH] D26750: [clang-tidy] Add modernize-use-default-member-init check

2016-12-08 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons updated this revision to Diff 80734. malcolm.parsons added a comment. Herald added a subscriber: JDevlieghere. Handle unary operators. https://reviews.llvm.org/D26750 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp

[PATCH] D27501: clang-format-vsix: add command to format document

2016-12-08 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76 + + Clang Format Document + hans wrote: > amaiorano wrote: > > hans wrote: > > > I think File would be better than Document when referring to

[PATCH] D27569: [OpenCL] Enabling the usage of CLK_NULL_QUEUE as compare operand.

2016-12-08 Thread Egor Churaev via Phabricator via cfe-commits
echuraev created this revision. echuraev added a reviewer: Anastasia. echuraev added subscribers: bader, yaxunl, cfe-commits. Enabling the compression of CLK_NULL_QUEUE to variable of type queue_t. https://reviews.llvm.org/D27569 Files: lib/Sema/SemaExpr.cpp

[libcxx] r289034 - Add more test cases to packaged_task copyability test

2016-12-08 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Dec 8 04:02:04 2016 New Revision: 289034 URL: http://llvm.org/viewvc/llvm-project?rev=289034=rev Log: Add more test cases to packaged_task copyability test Modified: libcxx/trunk/test/std/thread/futures/futures.task/futures.task.members/ctor1.fail.cpp Modified:

[PATCH] D26137: [clang-tidy] Add check name to YAML export

2016-12-08 Thread Alpha Abdoulaye via Phabricator via cfe-commits
Alpha updated this revision to Diff 80732. Alpha added a comment. Rebase on top of HEAD. Ping. Repository: rL LLVM https://reviews.llvm.org/D26137 Files: include/clang/Tooling/Core/Diagnostic.h include/clang/Tooling/Core/Replacement.h include/clang/Tooling/DiagnosticsYaml.h

[PATCH] D27202: [analyzer] Do not conjure a symbol for return value of a conservatively evaluated function

2016-12-08 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware added a comment. Could you please remove the IteratorPastEndChecker file differences from this patch and make https://reviews.llvm.org/D25660 dependent on this one? https://reviews.llvm.org/D27202 ___ cfe-commits mailing list

[libcxx] r289033 - Avoid C++17 guaranteed copy elision when testing for non-copyability

2016-12-08 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Dec 8 03:57:00 2016 New Revision: 289033 URL: http://llvm.org/viewvc/llvm-project?rev=289033=rev Log: Avoid C++17 guaranteed copy elision when testing for non-copyability Modified:

[PATCH] D25660: [Analyzer] Checker for iterators dereferenced beyond their range.

2016-12-08 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware added a comment. https://reviews.llvm.org/D27202 is now a dependency, but cannot add it. Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:166 +IteratorPastEndChecker::IteratorPastEndChecker() { + PastEndBugType.reset(new BugType(this,

[PATCH] D25660: [Analyzer] Checker for iterators dereferenced beyond their range.

2016-12-08 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware updated this revision to Diff 80728. baloghadamsoftware marked 4 inline comments as done. baloghadamsoftware added a comment. Minor corrections, comments, some new tests, test input headers merged. https://reviews.llvm.org/D25660 Files:

[PATCH] D27345: [OpenMP] Sema and parsing for 'teams distribute parallel for' pragma

2016-12-08 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D27345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27488: Fixing test to work when the compiler defaults to a different c++ standard version.

2016-12-08 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D27488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org