[PATCH] D28231: -Wunreachable-code: Avoid multiple diagnostics that are triggered by the same source range and fix the unary operator fixit source range

2017-01-11 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rL LLVM https://reviews.llvm.org/D28231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28512: [libc++] Pair _aligned_malloc with _aligned_free

2017-01-11 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL291743: [libc++] Pair _aligned_malloc with _aligned_free (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D28512?vs=83783=84075#toc Repository: rL LLVM

[libcxx] r291743 - [libc++] Pair _aligned_malloc with _aligned_free

2017-01-11 Thread Shoaib Meenai via cfe-commits
Author: smeenai Date: Thu Jan 12 00:22:36 2017 New Revision: 291743 URL: http://llvm.org/viewvc/llvm-project?rev=291743=rev Log: [libc++] Pair _aligned_malloc with _aligned_free Attempting to pair an `_aligned_malloc` with a regular free causes heap corruption. Pairing with `_aligned_free` is

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

2017-01-11 Thread Pekka Jääskeläinen via Phabricator via cfe-commits
pekka.jaaskelainen added inline comments. Comment at: docs/UsersManual.rst:2120 + that can be used across GPU toolchains. The implementation follows `the SPIR + specification `_. There are two flavors available + for 32 and 64 bits.

[libcxx] r291742 - disable use of __builtin_memcmp temporarily to get the tests passing again

2017-01-11 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Jan 11 23:40:58 2017 New Revision: 291742 URL: http://llvm.org/viewvc/llvm-project?rev=291742=rev Log: disable use of __builtin_memcmp temporarily to get the tests passing again Modified: libcxx/trunk/include/__string Modified: libcxx/trunk/include/__string URL:

[libcxx] r291741 - Implement P0426: Constexpr for std::char_traits

2017-01-11 Thread Marshall Clow via cfe-commits
Author: marshall Date: Wed Jan 11 22:37:14 2017 New Revision: 291741 URL: http://llvm.org/viewvc/llvm-project?rev=291741=rev Log: Implement P0426: Constexpr for std::char_traits Modified: libcxx/trunk/include/__string

[PATCH] D28473: Implement http://wg21.link/P0426 Constexpr for std::char_traits

2017-01-11 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists accepted this revision. mclow.lists added a reviewer: mclow.lists. mclow.lists added a comment. This revision is now accepted and ready to land. revision 291741 https://reviews.llvm.org/D28473 ___ cfe-commits mailing list

[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

2017-01-11 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D28588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28592: [libcxx] [test] Fix MSVC warning C4127 "conditional expression is constant".

2017-01-11 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4127 "conditional expression is constant". MSVC has a compiler warning (enabled at /https://reviews.llvm.org/W4) that's potentially useful,

[PATCH] D28591: [libcxx] [test] Don't ask whether Incomplete& can be assigned to.

2017-01-11 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Don't ask whether Incomplete& can be assigned to. This is the subject of an active NB comment. Regardless of what the Working Paper currently says, asking this

r291737 - Remove redundant passing around of a "ContainsAutoType" flag.

2017-01-11 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Jan 11 20:27:38 2017 New Revision: 291737 URL: http://llvm.org/viewvc/llvm-project?rev=291737=rev Log: Remove redundant passing around of a "ContainsAutoType" flag. This flag serves no purpose other than to prevent us walking through a type to check whether it contains

[PATCH] D28590: [Sema] Restrict explicit instantation definition dllexport

2017-01-11 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai created this revision. smeenai added reviewers: hans, rnk. smeenai added subscribers: cfe-commits, steveire. In the case where the template class itself is already `dllexport`, the implicit instantiation will have already emitted all members. When we check the explicit instantiation

[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

2017-01-11 Thread Dehao Chen via Phabricator via cfe-commits
danielcdh created this revision. danielcdh added reviewers: tejohnson, mehdi_amini. danielcdh added a subscriber: cfe-commits. LTO backend will not invoke SampleProfileLoader pass even if -fprofile-sample-use is specified. This patch passes the flag down so that pass manager can add the

[libcxx] r291727 - Revert "[CMake][libcxx] Do not rely on the existence of c++abi or unwind targets"

2017-01-11 Thread Petr Hosek via cfe-commits
Author: phosek Date: Wed Jan 11 17:56:31 2017 New Revision: 291727 URL: http://llvm.org/viewvc/llvm-project?rev=291727=rev Log: Revert "[CMake][libcxx] Do not rely on the existence of c++abi or unwind targets" This reverts commit 94fc5a96f58071703d81d14690094dcd266a5e17. Modified:

[libcxx] r291726 - Revert "[CMake][libcxx] Check that we have libcxxabi before using it"

2017-01-11 Thread Petr Hosek via cfe-commits
Author: phosek Date: Wed Jan 11 17:56:29 2017 New Revision: 291726 URL: http://llvm.org/viewvc/llvm-project?rev=291726=rev Log: Revert "[CMake][libcxx] Check that we have libcxxabi before using it" This reverts commit 8c91834411b322ab360eb1f193f489327e719652. Modified:

[libcxx] r291728 - Revert "[CMake][libcxx] Move Python check to main CMake file"

2017-01-11 Thread Petr Hosek via cfe-commits
Author: phosek Date: Wed Jan 11 17:56:33 2017 New Revision: 291728 URL: http://llvm.org/viewvc/llvm-project?rev=291728=rev Log: Revert "[CMake][libcxx] Move Python check to main CMake file" This reverts commit 39441fe9f00a58ffc2fdff92a4b0e8a280a5f444. Modified: libcxx/trunk/CMakeLists.txt

[PATCH] D28512: [libc++] Pair _aligned_malloc with _aligned_free

2017-01-11 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Hah, can't believe we missed that. https://reviews.llvm.org/D28512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

2017-01-11 Thread CJ DiMeglio via Phabricator via cfe-commits
lethalantidote updated this revision to Diff 84045. lethalantidote added a comment. Moves check in IsTracked(). https://reviews.llvm.org/D28543 Files: clang/lib/Analysis/UninitializedValues.cpp clang/lib/Sema/AnalysisBasedWarnings.cpp clang/test/Sema/uninit-variables.c Index:

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

2017-01-11 Thread CJ DiMeglio via Phabricator via cfe-commits
lethalantidote added a comment. So I tried the update you suggested (moving it up into IsTracked) and it seems to work and the reasoning makes sense to me. https://reviews.llvm.org/D28543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r291723 - [CMake][libcxx] Check that we have libcxxabi before using it

2017-01-11 Thread Petr Hosek via cfe-commits
Author: phosek Date: Wed Jan 11 17:11:40 2017 New Revision: 291723 URL: http://llvm.org/viewvc/llvm-project?rev=291723=rev Log: [CMake][libcxx] Check that we have libcxxabi before using it When doing standalone build, check that we actually have libcxxabi before attempting to use it.

[PATCH] D27680: [CodeGen] Move lifetime.start of a variable when goto jumps back past its declaration

2017-01-11 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. In https://reviews.llvm.org/D27680#642770, @rjmccall wrote: > Interesting. That's a pretty heavyweight solution, and you're still missing > switches, which have exactly the same "can jump into an arbitrary variable's > scope" behavior. In addition to missing the

[PATCH] D27486: Correct class-template deprecation behavior

2017-01-11 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. Thanks for the feedback Richard! I'll look into whether instantiating the full attribute set upon creation is a possibility. Comment at: include/clang/Basic/Attr.td:301 bit DuplicatesAllowedWhileMerging = 0; + // Set to true if this attribute

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

2017-01-11 Thread Katya Romanova via Phabricator via cfe-commits
kromanova updated this revision to Diff 84038. kromanova added a comment. Changed the instruction name from VMOVSD to VMOVQ for _mm_loadu_si64 Repository: rL LLVM https://reviews.llvm.org/D28503 Files: avxintrin.h emmintrin.h mmintrin.h pmmintrin.h xmmintrin.h Index:

Proposal for clang-format -r option

2017-01-11 Thread mateusz janek via cfe-commits
Hello, First of all, I want to say 'Hello' to everyone, I'm new in llvm/clang dev community. Today I want to present you a small clang-format proposal. I want to propose a '-r' option, with which, clang-format will search for files, which will match regex[s] passed like normal files, down in

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

2017-01-11 Thread Katya Romanova via Phabricator via cfe-commits
kromanova added inline comments. Comment at: emmintrin.h:1607 +/// +/// This intrinsic corresponds to the VMOVSD / MOVSD instruction. +/// RKSimon wrote: > kromanova wrote: > > kromanova wrote: > > > kromanova wrote: > > > > probinson wrote: > > > > > should

[PATCH] D27486: Correct class-template deprecation behavior

2017-01-11 Thread Richard Smith via Phabricator via cfe-commits
rsmith added inline comments. Comment at: include/clang/Basic/Attr.td:301 bit DuplicatesAllowedWhileMerging = 0; + // Set to true if this attribute should apply to template declarations, + // remains false if this should only be applied to the definition. I

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

2017-01-11 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: emmintrin.h:1607 +/// +/// This intrinsic corresponds to the VMOVSD / MOVSD instruction. +/// kromanova wrote: > kromanova wrote: > > kromanova wrote: > > > probinson wrote: > > > > should this be VMOVQ/MOVQ instead?

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

2017-01-11 Thread Katya Romanova via Phabricator via cfe-commits
kromanova added inline comments. Comment at: emmintrin.h:1607 +/// +/// This intrinsic corresponds to the VMOVSD / MOVSD instruction. +/// probinson wrote: > should this be VMOVQ/MOVQ instead? Probably yes. Let me know if you have a different opinion. If I

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

2017-01-11 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Thanks, this is looking pretty good! From clicking around a bit on cs, do you think it's better to put the check where you have it, or is maybe http://llvm-cs.pcc.me.uk/tools/clang/lib/Analysis/UninitializedValues.cpp#36 more appropriate? I think having it where you

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

2017-01-11 Thread CJ DiMeglio via Phabricator via cfe-commits
lethalantidote updated this revision to Diff 84026. lethalantidote marked an inline comment as done. lethalantidote added a comment. Addresses moving check further up, during analysis. Adds test to check for sometimes branch. Please review. https://reviews.llvm.org/D28543 Files:

LLVM buildmaster will be updated and restarted tonight

2017-01-11 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 5 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r291689 - Module: Do not add any link flags when an implementation TU of a module imports

2017-01-11 Thread Richard Smith via cfe-commits
Thank you! On 11 January 2017 at 10:47, Manman Ren via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mren > Date: Wed Jan 11 12:47:38 2017 > New Revision: 291689 > > URL: http://llvm.org/viewvc/llvm-project?rev=291689=rev > Log: > Module: Do not add any link flags when an

[PATCH] D20428: Tracking exception specification source locations

2017-01-11 Thread don hinton via Phabricator via cfe-commits
hintonda added a comment. If you want this included in the 4.0 release, it needs to get in before they branch tomorrow. https://reviews.llvm.org/D20428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r291707 - [index] Introduce symbol subkinds to mark an accessor getter or setter.

2017-01-11 Thread Argyrios Kyrtzidis via cfe-commits
Author: akirtzidis Date: Wed Jan 11 15:42:48 2017 New Revision: 291707 URL: http://llvm.org/viewvc/llvm-project?rev=291707=rev Log: [index] Introduce symbol subkinds to mark an accessor getter or setter. Modified: cfe/trunk/include/clang/Index/IndexSymbol.h

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

2017-01-11 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Thanks for the test! Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:907 else DiagUninitUse(S, VD, Use, true); } lethalantidote wrote: > thakis wrote: > > Should the check be in DiagUninitUse()? Or is there a reason

[PATCH] D21675: New ODR checker for modules

2017-01-11 Thread Richard Smith via Phabricator via cfe-commits
rsmith added a comment. Thanks! I assume there's still no measurable performance impact? Comment at: include/clang/AST/ODRHash.h:54 + // in Pointers. + size_type NextFreeIndex; + Is this always the same as `Pointers.size()`? Comment at:

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

2017-01-11 Thread CJ DiMeglio via Phabricator via cfe-commits
lethalantidote added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:907 else DiagUninitUse(S, VD, Use, true); } thakis wrote: > Should the check be in DiagUninitUse()? Or is there a reason this one should > happen for

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

2017-01-11 Thread CJ DiMeglio via Phabricator via cfe-commits
lethalantidote updated this revision to Diff 84016. lethalantidote marked an inline comment as done. lethalantidote added a comment. Addresses thakis' comments and adds a test. https://reviews.llvm.org/D28543 Files: clang/lib/Sema/AnalysisBasedWarnings.cpp

r291705 - [index] Ignore invalid ObjC categories.

2017-01-11 Thread Argyrios Kyrtzidis via cfe-commits
Author: akirtzidis Date: Wed Jan 11 15:08:31 2017 New Revision: 291705 URL: http://llvm.org/viewvc/llvm-project?rev=291705=rev Log: [index] Ignore invalid ObjC categories. We currently are unable to get a USR for those and it doesn't seem useful to try to index them. Modified:

r291703 - [index] Add 'IBTypeOf' relation for ObjC methods marked with IBAction and properties with IBOutletCollection.

2017-01-11 Thread Argyrios Kyrtzidis via cfe-commits
Author: akirtzidis Date: Wed Jan 11 15:01:07 2017 New Revision: 291703 URL: http://llvm.org/viewvc/llvm-project?rev=291703=rev Log: [index] Add 'IBTypeOf' relation for ObjC methods marked with IBAction and properties with IBOutletCollection. Modified:

r291702 - [PowerPC] Fix the wrong implementation of builtin vec_rlnm.

2017-01-11 Thread Tony Jiang via cfe-commits
Author: jtony Date: Wed Jan 11 14:59:42 2017 New Revision: 291702 URL: http://llvm.org/viewvc/llvm-project?rev=291702=rev Log: [PowerPC] Fix the wrong implementation of builtin vec_rlnm. Modified: cfe/trunk/lib/Headers/altivec.h cfe/trunk/test/CodeGen/builtins-ppc-p9vector.c Modified:

r291700 - [index] Add 'contained-by' relation between references and their lexical container.

2017-01-11 Thread Argyrios Kyrtzidis via cfe-commits
Author: akirtzidis Date: Wed Jan 11 14:51:10 2017 New Revision: 291700 URL: http://llvm.org/viewvc/llvm-project?rev=291700=rev Log: [index] Add 'contained-by' relation between references and their lexical container. Modified: cfe/trunk/include/clang/Index/IndexSymbol.h

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

2017-01-11 Thread Paul Robinson via Phabricator via cfe-commits
probinson added inline comments. Comment at: emmintrin.h:1607 +/// +/// This intrinsic corresponds to the VMOVSD / MOVSD instruction. +/// should this be VMOVQ/MOVQ instead? Repository: rL LLVM https://reviews.llvm.org/D28503

[PATCH] D28528: [PowerPC] Fix the wrong implementation of builtin vec_rlnm.

2017-01-11 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. Please fix the minor issue with the test case and then commit. LGTM. Comment at: test/CodeGen/builtins-ppc-p9vector.c:871 vector unsigned int test77(void) { +//

[PATCH] D24991: Inline hot functions in libcxx shared_ptr implementation.

2017-01-11 Thread Kevin Hu via Phabricator via cfe-commits
hxy9243 updated this revision to Diff 84004. hxy9243 added a comment. Minor changes on function names. Rename __libcpp_atomic_* to __libcpp_atomic_refcount_*. Repository: rL LLVM https://reviews.llvm.org/D24991 Files: libcxx/include/memory libcxx/src/memory.cpp Index:

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

2017-01-11 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. @rsmith could you say whether it seems reasonable to have a LangOpts flag that basically means "`pragma clang optimize off` is always in effect." I think it would make the other optnone-related logic simpler. It would not be the only sort-of-codegen-related flag in

r291689 - Module: Do not add any link flags when an implementation TU of a module imports

2017-01-11 Thread Manman Ren via cfe-commits
Author: mren Date: Wed Jan 11 12:47:38 2017 New Revision: 291689 URL: http://llvm.org/viewvc/llvm-project?rev=291689=rev Log: Module: Do not add any link flags when an implementation TU of a module imports a header of that same module. This fixes a regression caused by r280409.

r291688 - This reverts r291628. As suggested by Richard, we can simply

2017-01-11 Thread Manman Ren via cfe-commits
Author: mren Date: Wed Jan 11 12:32:30 2017 New Revision: 291688 URL: http://llvm.org/viewvc/llvm-project?rev=291688=rev Log: This reverts r291628. As suggested by Richard, we can simply filter out the implicilty imported modules at CodeGen instead of removing the implicit ImportDecl when an

[PATCH] D26015: Correctly classify main file includes if there is a prefix added

2017-01-11 Thread Julian Bangert via Phabricator via cfe-commits
jbangert updated this revision to Diff 84001. jbangert updated the summary for this revision. jbangert added a comment. - Add header to unit test fixture. https://reviews.llvm.org/D26015 Files: clang-tidy/utils/IncludeSorter.cpp unittests/clang-tidy/IncludeInserterTest.cpp Index:

[PATCH] D27689: Module: hash the pcm content and use it as SIGNATURE for implicit modules.

2017-01-11 Thread Manman Ren via Phabricator via cfe-commits
manmanren updated this revision to Diff 83999. manmanren added a comment. Rebase on top of r291686. https://reviews.llvm.org/D27689 Files: include/clang/AST/ExternalASTSource.h include/clang/Basic/Module.h include/clang/Frontend/PCHContainerOperations.h

[PATCH] D28297: [StaticAnalyzer] Fix crash in CastToStructChecker

2017-01-11 Thread Anna Zaks via Phabricator via cfe-commits
zaks.anna added a comment. Please, subscribe cfe-commits list on the patches as described in http://llvm.org/docs/Phabricator.html. Thanks! Anna Repository: rL LLVM https://reviews.llvm.org/D28297 ___ cfe-commits mailing list

r291681 - Unbreak the clang-fuzzer build after r291184.

2017-01-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Jan 11 10:42:26 2017 New Revision: 291681 URL: http://llvm.org/viewvc/llvm-project?rev=291681=rev Log: Unbreak the clang-fuzzer build after r291184. Modified: cfe/trunk/tools/clang-fuzzer/ClangFuzzer.cpp Modified: cfe/trunk/tools/clang-fuzzer/ClangFuzzer.cpp URL:

[PATCH] D28058: [OpenCL] Correct ndrange_t implementation

2017-01-11 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. I am thinking whether we should restrict ndrange_t to be struct type only, otherwise a user could typedef anything as ndrange_t and we may lose the ndrange_t type in the IR, which will cause issue if we want to translate the IR to SPIRV.

[PATCH] D27257: [CodeCompletion] Ensure that ObjC root class completes instance methods from protocols and categories as well

2017-01-11 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Ping. Repository: rL LLVM https://reviews.llvm.org/D27257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

2017-01-11 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. Great work. LGTM. Thanks! https://reviews.llvm.org/D28080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27680: [CodeGen] Move lifetime.start of a variable when goto jumps back past its declaration

2017-01-11 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Interesting. That's a pretty heavyweight solution, and you're still missing switches, which have exactly the same "can jump into an arbitrary variable's scope" behavior. I think maybe an easier solution would be to just remove the begin-lifetime marker completely

[PATCH] D27700: [clang-tidy] refactor ExprSequence out of misc-use-after-move check

2017-01-11 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. One late comment. Comment at: clang-tools-extra/trunk/clang-tidy/utils/ExprSequence.cpp:154-155 +const Stmt *ExprSequence::resolveSyntheticStmt(const Stmt *S) const { + if (SyntheticStmtSourceMap.count(S)) +return SyntheticStmtSourceMap.lookup(S);

[PATCH] D28058: [OpenCL] Correct ndrange_t implementation

2017-01-11 Thread Dmitry Borisenkov via Phabricator via cfe-commits
dmitry added a comment. Ping! https://reviews.llvm.org/D28058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

2017-01-11 Thread Alexey Bader via Phabricator via cfe-commits
bader accepted this revision. bader added a comment. LGTM. Thanks! https://reviews.llvm.org/D28080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22452: [libcxx] Fix last_write_time tests for filesystems that don't support negative and very large times.

2017-01-11 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. @EricWF ? https://reviews.llvm.org/D22452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28315: Update tools to use new getStyle API

2017-01-11 Thread Antonio Maiorano via Phabricator via cfe-commits
amaiorano added inline comments. Comment at: change-namespace/ChangeNamespace.cpp:892 + llvm::errs() << llvm::toString(Style.takeError()) << "\n"; + continue; +} amaiorano wrote: > ioeric wrote: > > I'd still like to apply replacements that are not

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

2017-01-11 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia marked 16 inline comments as done. Anastasia added inline comments. Comment at: docs/UsersManual.rst:2013 +to perform machine code generation. + +Clang currently supports OpenCL standards up to v2.0. pekka.jaaskelainen wrote: > I'd like to add a

Re: Patch for Bug 22877

2017-01-11 Thread Arthur Eubanks via cfe-commits
Test updated. patch.diff Description: Binary data On 9 Jan 2017, at 3:48 PM, Akira Hatanaka wrote:Perhaps you can check more explicitly that the destructor is called inside the loop?// CHECK: [[regex for LOOP_BODY]]:// CHECK: call void @_ZN3fooC1Ev// CHECK-NOT: br// CHECK:

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

2017-01-11 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia updated this revision to Diff 83962. Anastasia added a comment. Addressed comments from Alexey, Pekka, and Sam! https://reviews.llvm.org/D28080 Files: docs/UsersManual.rst www/index.html Index: www/index.html ===

[PATCH] D28315: Update tools to use new getStyle API

2017-01-11 Thread Antonio Maiorano via Phabricator via cfe-commits
amaiorano updated this revision to Diff 83952. amaiorano added a comment. Fixed code in ClangApplyReplacementsMain.cpp so that we only handle the

[PATCH] D28081: Make GetStyle return Expected instead of FormatStyle

2017-01-11 Thread Antonio Maiorano via Phabricator via cfe-commits
amaiorano updated this revision to Diff 83949. amaiorano added a comment. Fixed Format/style-on-command-line.cpp test to match new expected output. https://reviews.llvm.org/D28081 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Tooling/Refactoring.cpp

[clang-tools-extra] r291669 - [find-all-symbols] Index partial template specializations.

2017-01-11 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Jan 11 05:47:44 2017 New Revision: 291669 URL: http://llvm.org/viewvc/llvm-project?rev=291669=rev Log: [find-all-symbols] Index partial template specializations. Summary: Fix no std::function index. Previously, we don't index all the template specialization declarations

[PATCH] D27920: [find-all-symbols] Index partial template specializations.

2017-01-11 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL291669: [find-all-symbols] Index partial template specializations. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D27920?vs=83944=83951#toc Repository: rL LLVM

[PATCH] D26015: Correctly classify main file includes if there is a prefix added

2017-01-11 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. Tests don't pass with this patch applied: $ ninja check-clang-tools [22/23] Running the Clang extra tools' regression tests FAIL: Extra Tools Unit Tests ::

[PATCH] D27918: [analyzer] OStreamChecker

2017-01-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Hello, Thanks for the patch, and for the impressing amount of work you put into this. Because the patch is huge, so it's going to take some time for somebody to understand how everything works. I'd probably like to learn a bit more about the motivation behind the checker.

[PATCH] D27920: [find-all-symbols] Index partial template specializations.

2017-01-11 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 83944. hokein marked an inline comment as done. hokein added a comment. Fix code style nit. https://reviews.llvm.org/D27920 Files: include-fixer/find-all-symbols/FindAllSymbols.cpp unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp

r291667 - Remove repeated word in comment (NFC)

2017-01-11 Thread Malcolm Parsons via cfe-commits
Author: malcolm.parsons Date: Wed Jan 11 05:23:22 2017 New Revision: 291667 URL: http://llvm.org/viewvc/llvm-project?rev=291667=rev Log: Remove repeated word in comment (NFC) Modified: cfe/trunk/lib/Parse/ParseExprCXX.cpp Modified: cfe/trunk/lib/Parse/ParseExprCXX.cpp URL:

[PATCH] D28297: [StaticAnalyzer] Fix crash in CastToStructChecker

2017-01-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a subscriber: zaks.anna. NoQ added a comment. Looks good. I assume the crash is in `getTypeInfo()`; do you have any idea what are exact prerequisites for using this method? So that there were no more crashes here. Repository: rL LLVM https://reviews.llvm.org/D28297

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

2017-01-11 Thread Hamza Sood via Phabricator via cfe-commits
hamzasood updated this revision to Diff 83943. hamzasood added a comment. Uploaded the correct diff this time (yes, really)... Not sure how to delete the previous one, but it's very incorrect. https://reviews.llvm.org/D28365 Files: include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D28467: [Sema] Add warning for unused lambda captures

2017-01-11 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons updated this revision to Diff 83942. malcolm.parsons marked 9 inline comments as done. malcolm.parsons added a comment. Change warning message. Check for side effects. Add tests for side effects. Add tests for decltype. Use const reference. Add . to comment. Remove unrelated

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

2017-01-11 Thread Hamza Sood via Phabricator via cfe-commits
hamzasood updated this revision to Diff 83941. hamzasood added a comment. - Rephrased the diagnostic message (and fixed an embarrassing typo). - Reverted the linker environment change for now; building for x86 with VS2017 won't work in the meantime. I'll submit it for review separately after

[PATCH] D28548: Improve include fixer's ranking by taking the paths into account.

2017-01-11 Thread Manuel Klimek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL291664: Improve include fixer's ranking by taking the paths into account. (authored by klimek). Changed prior to commit: https://reviews.llvm.org/D28548?vs=83930=83937#toc Repository: rL LLVM

[clang-tools-extra] r291664 - Improve include fixer's ranking by taking the paths into account.

2017-01-11 Thread Manuel Klimek via cfe-commits
Author: klimek Date: Wed Jan 11 04:32:47 2017 New Revision: 291664 URL: http://llvm.org/viewvc/llvm-project?rev=291664=rev Log: Improve include fixer's ranking by taking the paths into account. Instead of just using popularity, we also take into account how similar the path of the current file

[PATCH] D28235: [clang-format cleanup] merge continuous deleted lines into one deletion.

2017-01-11 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. post-vacation ping :) https://reviews.llvm.org/D28235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26082: Support for Python 3 in libclang python bindings

2017-01-11 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe added a comment. @MathieuDuponchelle I'm still keen to get to the bottom of this failure. I've not had time to reproduce it yet. I'm thankful for you taking a look at this and reporting the issue. We need to get this working well for everyone. Repository: rL LLVM

[PATCH] D27920: [find-all-symbols] Index partial template specializations.

2017-01-11 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. The reason why we disallowed specializations is that there are type-trait classes that get specialized all over the place (DenseMapInfo in LLVM is one example). I think we can get away with

[PATCH] D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts.

2017-01-11 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a comment. @yaron.keren, it seems that http://llvm.org/pr30994 concerns friend function declarations. My current patch focuses on friend class templates. Perhaps we should open another review item for a fix of http://llvm.org/pr30994. https://reviews.llvm.org/D28399

[PATCH] D28467: [Sema] Add warning for unused lambda captures

2017-01-11 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons added inline comments. Comment at: test/SemaCXX/warn-unused-lambda-capture.cpp:17 + auto explicit_by_value_unused = [i] {}; // expected-warning{{lambda capture 'i' is not used}} + auto explicit_by_value_unused_sizeof = [i] { return sizeof(i); }; //

[PATCH] D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts.

2017-01-11 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev removed rL LLVM as the repository for this revision. v.g.vassilev updated this revision to Diff 83936. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Address comments. https://reviews.llvm.org/D28399 Files: include/clang/AST/DeclTemplate.h

[PATCH] D28148: [Sema] Suppress warnings for C's zero initializer

2017-01-11 Thread Daniel Marjamäki via Phabricator via cfe-commits
danielmarjamaki accepted this revision. danielmarjamaki added a reviewer: danielmarjamaki. danielmarjamaki added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D28148 ___ cfe-commits mailing list

[PATCH] D28467: [Sema] Add warning for unused lambda captures

2017-01-11 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added inline comments. Comment at: test/SemaCXX/warn-unused-lambda-capture.cpp:17 + auto explicit_by_value_unused = [i] {}; // expected-warning{{lambda capture 'i' is not used}} + auto explicit_by_value_unused_sizeof = [i] { return sizeof(i); }; //

[PATCH] D28548: Improve include fixer's ranking by taking the paths into account.

2017-01-11 Thread Manuel Klimek via Phabricator via cfe-commits
klimek created this revision. klimek added a reviewer: bkramer. klimek added a subscriber: cfe-commits. Instead of just using popularity, we also take into account how similar the path of the current file is to the path of the header. Our first approach is to get popularity into a reasonably

[PATCH] D28467: [Sema] Add warning for unused lambda captures

2017-01-11 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons marked an inline comment as done. malcolm.parsons added inline comments. Comment at: include/clang/Sema/ScopeInfo.h:457 +/// lambda. +bool Used = false; + aaron.ballman wrote: > arphaman wrote: > > malcolm.parsons wrote: > > > Should this

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

2017-01-11 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. Thanks for working on this! Looks good, except a few pedantic notes. Comment at: docs/UsersManual.rst:44 - :ref:`Objective C++ Language ` +- :ref:`OpenCL Language `: v1.0, v1.1, v1.2, v2.0. It should and to be perfectly clear we

[PATCH] D26082: Support for Python 3 in libclang python bindings

2017-01-11 Thread Mathieu Duponchelle via Phabricator via cfe-commits
MathieuDuponchelle added a comment. In https://reviews.llvm.org/D26082#621496, @jbcoe wrote: > Hi Mathieu, > What platform did you run the tests on? How did you run them? I don't get > any failures when running tests on macOS 10.12.1. Hey @jbcoe, do you think you can have a look at this

[PATCH] D26015: Correctly classify main file includes if there is a prefix added

2017-01-11 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you for the fix! https://reviews.llvm.org/D26015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org