NoQ added a comment.
Thanks! Because LLVM's Illinois license is rather permissive than copyleft, we
try to avoid stuff copied from GPL/LGPL software (such as Qt or K3B) in our
codebase. The code doesn't seem to have been copy-pasted from a copyleft
project, but I guess it's better to rename the
xiangzhai updated this revision to Diff 97047.
xiangzhai added a subscriber: cfe-commits.
xiangzhai added a comment.
Hi Artem,
Please review my updated patch, I use SourceManager's getFilename and add some
testcases, thanks a lot!
Regards,
Leslie Zhai
Repository:
rL LLVM
https://reviews.ll
Author: chapuni
Date: Fri Apr 28 00:02:52 2017
New Revision: 301619
URL: http://llvm.org/viewvc/llvm-project?rev=301619&view=rev
Log:
clang/test/ARCMT/remap-applying.c: Use %/s on the command line of echo(1).
Modified:
cfe/trunk/test/ARCMT/remap-applying.c
cfe/trunk/test/ARCMT/remap-apply
xiangzhai updated this revision to Diff 97042.
xiangzhai added a comment.
Hi Artem,
Please review my updated patch, thanks a lot!
Regards,
Leslie Zhai
Repository:
rL LLVM
https://reviews.llvm.org/D31868
Files:
lib/StaticAnalyzer/Checkers/CStringChecker.cpp
test/Analysis/null-deref-ps-r
Thanks!!
On Thu, Apr 27, 2017 at 9:17 PM, NAKAMURA Takumi via cfe-commits
wrote:
> Author: chapuni
> Date: Thu Apr 27 23:17:31 2017
> New Revision: 301613
>
> URL: http://llvm.org/viewvc/llvm-project?rev=301613&view=rev
> Log:
> clang/test/Index/index-module.m: Relax expressions to satisfy DOSish
On Thu, Apr 27, 2017 at 6:49 PM, Richard Smith via cfe-commits
wrote:
> Author: rsmith
> Date: Thu Apr 27 20:49:42 2017
> New Revision: 301610
>
> URL: http://llvm.org/viewvc/llvm-project?rev=301610&view=rev
> Log:
> Move functionality for handling module maps as inputs from the -emit-module
> act
Author: chapuni
Date: Thu Apr 27 23:17:31 2017
New Revision: 301613
URL: http://llvm.org/viewvc/llvm-project?rev=301613&view=rev
Log:
clang/test/Index/index-module.m: Relax expressions to satisfy DOSish path
separator \\, since r301597.
Modified:
cfe/trunk/test/Index/index-module.m
Modified
Hi Bruno,
I don’t know if you are still trying to figure out the problem here, but if you
are, I believe the problem is that the forward slashes need to changed to
search for either a forward slash or a backward slash since Windows will change
them to a backslash.
Locally I can get the test to
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: test/Preprocessor/macro_paste_commaext.c:4
+// In the following tests, note that the output is sensitive to the
+// whitespace *preceeding* the varargs argum
Author: rsmith
Date: Thu Apr 27 20:49:42 2017
New Revision: 301610
URL: http://llvm.org/viewvc/llvm-project?rev=301610&view=rev
Log:
Move functionality for handling module maps as inputs from the -emit-module
action to the general FrontendAction infrastructure.
This permits applying -E, -ast-dump
This is breaking a non related test in some windows bots.
Takumi & other with windows access, can you help me figure why?
For instance:
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/3846
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/4379
On Thu, Apr 27, 2017
Author: akirtzidis
Date: Thu Apr 27 19:25:06 2017
New Revision: 301602
URL: http://llvm.org/viewvc/llvm-project?rev=301602&view=rev
Log:
[ARCMigrate] When applying changes from remap files, disable the
'adjustRemovals' functionality of EditedSource
'adjustRemovals' is used to avoid situation whe
Author: gbiv
Date: Thu Apr 27 18:59:45 2017
New Revision: 301601
URL: http://llvm.org/viewvc/llvm-project?rev=301601&view=rev
Log:
Use a consistent style. NFC
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/tru
tstellar added a comment.
In https://reviews.llvm.org/D32595#740222, @chapuni wrote:
> Let me know steps for testing that you suppose.
> I guess;
>
> - Use installed version of lit via virtualenv.
Not necessarily via virtualenv, either by installing the lit pypi package or
using a distro pack
yamaguchi updated this revision to Diff 97019.
yamaguchi added a comment.
Add testcase
https://reviews.llvm.org/D32341
Files:
lib/Driver/ToolChains/Clang.cpp
test/Driver/m_and_mm.c
Index: test/Driver/m_and_mm.c
===
--- test/D
chapuni added a comment.
Let me know steps for testing that you suppose.
I guess;
- Use installed version of lit via virtualenv.
- Use out-of-tree version of gtest.
- Use another build tree to use FileCheck &c.
I know the clause CLANG_BUILT_STANDALONE would be made simpler if we could
abandon t
yamaguchi updated this revision to Diff 97013.
yamaguchi added a comment.
show warnings with -M and -MD
https://reviews.llvm.org/D32341
Files:
lib/Driver/ToolChains/Clang.cpp
test/Driver/m_and_mm.c
Index: test/Driver/m_and_mm.c
=
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301597: [Modules] Improve diagnostics for incomplete
umbrella (authored by bruno).
Changed prior to commit:
https://reviews.llvm.org/D32576?vs=96857&id=97007#toc
Repository:
rL LLVM
https://reviews.
Author: bruno
Date: Thu Apr 27 17:29:14 2017
New Revision: 301597
URL: http://llvm.org/viewvc/llvm-project?rev=301597&view=rev
Log:
[Modules] Improve diagnostics for incomplete umbrella
One of the -Wincomplete-umbrella warnings diagnoses when a header is present in
the directory but it's not pres
Author: bruno
Date: Thu Apr 27 17:29:10 2017
New Revision: 301596
URL: http://llvm.org/viewvc/llvm-project?rev=301596&view=rev
Log:
[Modules] Refactor logic for incomplete umbrella warnings. NFC
Modified:
cfe/trunk/include/clang/Lex/Preprocessor.h
cfe/trunk/lib/Lex/PPLexerChange.cpp
Modi
dexonsmith added a comment.
rsmith: I just noticed you still have a red "X" here (since Phab won't let me
"close"). I think I addressed your comments, but let me know if you want me to
revert until you have time to look.
https://reviews.llvm.org/D31856
_
dexonsmith accepted this revision.
dexonsmith added a comment.
Thanks for the reviews! Committed in r301593.
https://reviews.llvm.org/D31856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: dexonsmith
Date: Thu Apr 27 16:49:45 2017
New Revision: 301593
URL: http://llvm.org/viewvc/llvm-project?rev=301593&view=rev
Log:
Headers: Make the type of SIZE_MAX the same as size_t
size_t is usually defined as unsigned long, but on 64-bit platforms,
stdint.h currently defines SIZE_MAX u
Some of builders lost connection with master recently due to network glitch.
Thank you for understanding.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dexonsmith closed this revision.
dexonsmith added a comment.
Fixed in r301592.
https://reviews.llvm.org/D32263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dexonsmith
Date: Thu Apr 27 16:41:51 2017
New Revision: 301592
URL: http://llvm.org/viewvc/llvm-project?rev=301592&view=rev
Log:
Preprocessor: Suppress -Wnonportable-include-path for header maps
If a file search involves a header map, suppress
-Wnonportable-include-path. It's firing lots
aprantl accepted this revision.
aprantl added a comment.
This revision now requires changes to proceed.
I think I may haved screwed up the phabricator process for this one.
This landed as r300523.
https://reviews.llvm.org/D31440
___
cfe-commits mail
Author: tnorthover
Date: Thu Apr 27 15:22:40 2017
New Revision: 301585
URL: http://llvm.org/viewvc/llvm-project?rev=301585&view=rev
Log:
libclang: remove unused variable.
Modified:
cfe/trunk/tools/libclang/CXCursor.cpp
Modified: cfe/trunk/tools/libclang/CXCursor.cpp
URL:
http://llvm.org/vie
Prazek accepted this revision.
Prazek added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D32395
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
phosek created this revision.
Several improvements to the Fuchsia driver:
- Search for C++ library headers and libraries in directories that are part of
the toolchain distribution rather than sysroot.
- Use LLVM support utlities to construct paths to make sure the driver is also
usable
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
I agree, this seems reasonable. LGTM.
https://reviews.llvm.org/D32601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
aprantl added a comment.
> It would simplify fallout, reverting, triaging issues, understanding compile
> time impact, etc., if the debug info change was left for a separate commit
> (maybe waiting a day). Thoughts?
Sounds like a good plan.
https://reviews.llvm.org/D32603
_
Author: spyffe
Date: Thu Apr 27 13:10:29 2017
New Revision: 301573
URL: http://llvm.org/viewvc/llvm-project?rev=301573&view=rev
Log:
Added an Importer test for in-class member initializers.
Added:
cfe/trunk/test/Import/in-class-initializer/
cfe/trunk/test/Import/in-class-initializer/Input
v.g.vassilev added a comment.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D25113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai added a comment.
Ping.
https://reviews.llvm.org/D32329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aprantl updated this revision to Diff 96952.
aprantl added a comment.
Address review feedback.
https://reviews.llvm.org/D32603
Files:
cmake/caches/Apple-stage2.cmake
Index: cmake/caches/Apple-stage2.cmake
===
--- cmake/caches/A
dexonsmith added a comment.
(Both changes SGTM, but I doubt you're looking for my advice on the CMake
logic.)
Comment at: cmake/caches/Apple-stage2.cmake:31-32
set(CMAKE_CXX_FLAGS "-fno-stack-protector -fno-common
-Wno-profile-instr-unprofiled" CACHE STRING "")
-set(CMAKE_C_
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
SWEET! this is great to see! One small comment inline, otherwise LGTM.
Comment at: cmake/caches/Apple-stage2.cmake:33
+set(CMAKE_C_FLAGS_RELWITHDEBINFO "-O2 -g -DNDEBUG" CACHE
aprantl added a comment.
@beanz: Would sorting all these set() commands alphabetically break anything?
Repository:
rL LLVM
https://reviews.llvm.org/D32603
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
tstellar created this revision.
You can still specify an llvm-config to use by configuring with
-DLLVM_CONFIG=/path/to/llvm/config, but this method is now deprecated
and may be remove.
Users should be setting CMAKE_PREFIX_PATH to the install prefix
for their llvm install. Unless you are using th
aprantl created this revision.
Herald added subscribers: mehdi_amini, mgorny.
Green dragon had a green stage2 modules bot for a long time now[1] and it is
time to retire it and make a modules build the default for Apple-style stage2
builds.
This patch turns on `LLVM_ENABLE_MODULES` and switches
ahatanak added a comment.
There is a comment in test/CodeGenObjC/arc-foreach.m that states the variable
introduced by fast enumeration should be retained, but I don't think that is
needed?
https://reviews.llvm.org/D32601
___
cfe-commits mailing li
ahatanak created this revision.
When a block captures an ObjC object pointer, clang emits a retain/release pair
to prevent prematurely destroying the object the pointer points to before the
block is called or copied.
When the captured object pointer is const-qualified, we can avoid emitting the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301570: [Profile] Add off-by-default -Wprofile-instr-missing
warning (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D28867?vs=96847&id=96945#toc
Repository:
rL LLVM
https:/
Author: vedantk
Date: Thu Apr 27 12:30:58 2017
New Revision: 301570
URL: http://llvm.org/viewvc/llvm-project?rev=301570&view=rev
Log:
[Profile] Add off-by-default -Wprofile-instr-missing warning
Clang warns that a profile is out-of-date if it can't find a profile
record for any function in a TU.
v.g.vassilev closed this revision.
v.g.vassilev added a comment.
Landed in r301569.
https://reviews.llvm.org/D32342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: akirtzidis
Date: Thu Apr 27 12:23:04 2017
New Revision: 301568
URL: http://llvm.org/viewvc/llvm-project?rev=301568&view=rev
Log:
[libclang] Enhance clang_Cursor_isDynamicCall and clang_Cursor_getReceiverType
to handle ObjC property references
Also enhance clang_Cursor_getReceiverType to
Author: hans
Date: Thu Apr 27 12:19:07 2017
New Revision: 301567
URL: http://llvm.org/viewvc/llvm-project?rev=301567&view=rev
Log:
clang-cl: Alias /d1reportAllClassLayout to -fdump-record-layouts (PR32826)
Modified:
cfe/trunk/include/clang/Driver/CLCompatOptions.td
cfe/trunk/test/Driver/c
lebedev.ri abandoned this revision.
lebedev.ri added a comment.
Thank you all!
After some thought, i have come to conclusion that it is best to start with
something less controversial, and simpler.
https://reviews.llvm.org/D31252
___
cfe-commits ma
Author: hans
Date: Thu Apr 27 12:02:25 2017
New Revision: 301564
URL: http://llvm.org/viewvc/llvm-project?rev=301564&view=rev
Log:
Fix -Wpedantic about extra semicolons in CGStmtOpenMP.cpp
Modified:
cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
URL:
v.g.vassilev closed this revision.
v.g.vassilev added a comment.
Landed in r301563.
https://reviews.llvm.org/D32486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vvassilev
Date: Thu Apr 27 11:58:33 2017
New Revision: 301563
URL: http://llvm.org/viewvc/llvm-project?rev=301563&view=rev
Log:
Remove leaking UnknownPragmaHandlers right after we are done with them.
The UnknownPragmaHandlers added by DoPrintPreprocessedInput conflict with the
real Pragma
MatzeB added a comment.
In https://reviews.llvm.org/D22045#739627, @MatzeB wrote:
> Just out of interested: I can see how `__attribute__ ((interrupt))` is
> useful, but in what situations would you use `no_caller_saved_registers`?
Actually please answer this question by documenting the attribu
v.g.vassilev added a comment.
I think you will see the issue if you add a negative test case, too. I.e. as
Raphael said in `-MD` and `-MMD` mode we should be able to see warnings.
https://reviews.llvm.org/D32341
___
cfe-commits mailing list
cfe-com
MatzeB added a comment.
Just out of interested: I can see how `__attribute__ ((interrupt))` is useful,
but in what situations would you use `no_caller_saved_registers`?
https://reviews.llvm.org/D22045
___
cfe-commits mailing list
cfe-commits@lists.
xur added a comment.
Looks good to me.
https://reviews.llvm.org/D28867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar created this revision.
clang was using LLVM_MAIN_SRC_DIR to search for lit.py to use for
running clang's lit tests. This was dangerous though, because
LLVM_MAIN_SRC_DIR was determined by using llvm-config --src-root
and this directory may have been modified since llvm-config was
built (e
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Looks good, thanks!
Did you evaluate this on a large codebase - were warnings plentiful and were
there any false positives known?
I'd like to summon Anna here for a little bit because that's a new
xiangzhai added a comment.
Hi Artem,
Thank you so much! you are my mentor teach me patiently and carefully, I will
update my patch tomorrow, good night from my timezone:)
Regards,
Leslie Zhai
Repository:
rL LLVM
https://reviews.llvm.org/D31868
___
NoQ added a comment.
I've a feeling we need to roll this back a little bit.
The `memset()` function does the following:
1. Accesses pointers in range R = [first argument, first argument + third
argument] and crashes when accessing an invalid pointer.
2. Writes second argument to all bytes in ra
Author: abataev
Date: Thu Apr 27 10:10:33 2017
New Revision: 301549
URL: http://llvm.org/viewvc/llvm-project?rev=301549&view=rev
Log:
[OPENMP] Add a check for iterator not reached the end of stack, NFC.
Add an extra check for the iterator during checks of the data-sharing
attributes.
Modified:
Author: akirtzidis
Date: Thu Apr 27 10:05:18 2017
New Revision: 301548
URL: http://llvm.org/viewvc/llvm-project?rev=301548&view=rev
Log:
[index] Mark the ObjC implicit accessor method definitions as 'dynamic' as well
Modified:
cfe/trunk/lib/Index/IndexDecl.cpp
cfe/trunk/test/Index/Core/in
NoQ added a comment.
Thank you very much!
I think you might have forgotten to include the newly added files in this
review(?)><
https://reviews.llvm.org/D32592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
NoQ added a comment.
I've seen the new reviews. A lot of thanks for working on the patch split. I
believe it'd eventually benefit everyone, similarly to how everybody benefits
from code quality or something like that. I'd try to keep up with the "to split
or not to split" discussion a bit below
Author: abataev
Date: Thu Apr 27 09:46:26 2017
New Revision: 301547
URL: http://llvm.org/viewvc/llvm-project?rev=301547&view=rev
Log:
[OPENMP] Improve performance of the hasDSA() function, NFC.
Remove some unneccesary code from the function after the fix for ASAN
buildbots.
Modified:
cfe/tru
JDevlieghere added a comment.
Looks good, nothing to add from my side.
https://reviews.llvm.org/D31887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malaperle-ericsson added a comment.
Ping. Any more objections?
https://reviews.llvm.org/D31887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arphaman
Date: Thu Apr 27 08:47:03 2017
New Revision: 301542
URL: http://llvm.org/viewvc/llvm-project?rev=301542&view=rev
Log:
[libclang] Pass in the -fallow-editor-placeholders option
This will suppress any live diagnostics caused by editor placeholders in Xcode.
rdar://31833579
Added:
baloghadamsoftware created this revision.
Herald added a subscriber: mgorny.
This is the first part of the new Iterator Checker. This part contains the very
core infrastructure. It only checks for out-of-range iterators in a very simple
case.
https://reviews.llvm.org/D32592
Files:
include/c
emilio added a comment.
I'm personally fine with this behavior in particular, given you can check the
cursor you're querying to know if it's a typedef or alias specialization. Of
course I'm not the only one using libclang, though, so I'd be interested in
hearing other people's opinion.
I think
Author: chapuni
Date: Thu Apr 27 08:08:48 2017
New Revision: 301539
URL: http://llvm.org/viewvc/llvm-project?rev=301539&view=rev
Log:
clang/test/Modules/malformed-overload.m: Make sure module cache is clean.
Modified:
cfe/trunk/test/Modules/malformed-overload.m
Modified: cfe/trunk/test/Modul
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301538: clang-format: [JS] parse async function
declarations. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D32590?vs=96908&id=96909#toc
Repository:
rL LLVM
https://review
mprobst updated this revision to Diff 96908.
mprobst added a comment.
- capitalization
https://reviews.llvm.org/D32590
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
=
Author: mprobst
Date: Thu Apr 27 08:07:24 2017
New Revision: 301538
URL: http://llvm.org/viewvc/llvm-project?rev=301538&view=rev
Log:
clang-format: [JS] parse async function declarations.
Summary:
Previously, clang-format would accidentally parse an async function
declaration as a function expres
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: lib/Format/UnwrappedLineParser.cpp:1043
- // Parse function literal unless 'function' is the first token in a line
- // in which case th
mprobst created this revision.
Herald added a subscriber: klimek.
Previously, clang-format would accidentally parse an async function
declaration as a function expression, and thus not insert an unwrapped
line for async functions, causing subsequent functions to run into the
function:
async fun
Hi Ahmed, thanks for the info. Will fix it ASAP.
Best regards,
Alexey Bataev
26 апр. 2017 г., в 22:00, Ahmed Bougacha
mailto:ahmed.bouga...@gmail.com>> написал(а):
Hey Alexey,
This is causing asan errors, e.g.:
==4735==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x61f00e70
a
Author: hokein
Date: Thu Apr 27 07:22:33 2017
New Revision: 301536
URL: http://llvm.org/viewvc/llvm-project?rev=301536&view=rev
Log:
Fix asan failures on OpenMP.
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp
URL:
http://llvm.org/viewvc/llvm-project/
danielmarjamaki added inline comments.
Comment at: lib/StaticAnalyzer/Core/CheckerHelpers.cpp:116
+return false;
+ ConstraintManager &CM = State->getConstraintManager();
+ ProgramStateRef StTrue, StFalse;
xazax.hun wrote:
> Any reason why do you get the con
Author: orenb
Date: Thu Apr 27 07:01:00 2017
New Revision: 301535
URL: http://llvm.org/viewvc/llvm-project?rev=301535&view=rev
Log:
[X86] Support of no_caller_saved_registers attribute
Implements the Clang part for no_caller_saved_registers attribute as appears
here:
https://gcc.gnu.org/git/?p=
yaron.keren added a comment.
OK
https://reviews.llvm.org/D32486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
v.g.vassilev added a comment.
Yaron, I can take care of this. Thanks for asking. Raphael and I are working
together.
https://reviews.llvm.org/D32486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
kuhar added a comment.
I run clang-tidy with this version of modernize-use-emplace on the whole llvm +
clang + clang tools extra tree and it emitted ~500 fixits, ~100 of them were
make_pair ones.
The whole codebase compiled fine and there were no new test failures with
check-all.
https://revi
Prazek added a comment.
In https://reviews.llvm.org/D32401#738513, @rjmccall wrote:
> In https://reviews.llvm.org/D32401#735127, @Prazek wrote:
>
> > In https://reviews.llvm.org/D32401#734921, @rjmccall wrote:
> >
> > > I continue to be really uncomfortable with the entire design of this
> > > o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301532: [ObjC] Disallow vector parameters and return values
in Objective-C methods (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D28670?vs=95099&id=96892#toc
Repository:
r
Author: arphaman
Date: Thu Apr 27 05:43:48 2017
New Revision: 301532
URL: http://llvm.org/viewvc/llvm-project?rev=301532&view=rev
Log:
[ObjC] Disallow vector parameters and return values in Objective-C methods
for iOS < 9 and OS X < 10.11 X86 targets
This commit adds a new error that disallows me
yaron.keren added a comment.
Raphael , do you have commit access? should I commit this?
https://reviews.llvm.org/D32486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: yrnkrn
Date: Thu Apr 27 04:56:39 2017
New Revision: 301526
URL: http://llvm.org/viewvc/llvm-project?rev=301526&view=rev
Log:
Constify SourceManager input to MacroInfo::getDefinitionLengthSlow, NFC.
Modified:
cfe/trunk/include/clang/Lex/MacroInfo.h
cfe/trunk/lib/Lex/MacroInfo.cpp
Author: hokein
Date: Thu Apr 27 04:20:46 2017
New Revision: 301525
URL: http://llvm.org/viewvc/llvm-project?rev=301525&view=rev
Log:
Don't hard-code "modules-cache-path" in the test.
Modified:
cfe/trunk/test/Modules/malformed-overload.m
Modified: cfe/trunk/test/Modules/malformed-overload.m
U
Author: nicholas
Date: Thu Apr 27 02:27:36 2017
New Revision: 301522
URL: http://llvm.org/viewvc/llvm-project?rev=301522&view=rev
Log:
In the expression evaluator, visit the index of an ArraySubscriptExpr even if
we can't evaluate the base, if the evaluation mode tells us to continue
evaluation.
rsmith added a comment.
I'm OK with this from a mechanical perspective. But there's also a libclang
design question here: what should the libclang methods to query template
arguments for a type cursor representing an alias template specialization
actually do? Should there be some way for a libc
Author: nicholas
Date: Thu Apr 27 02:11:09 2017
New Revision: 301520
URL: http://llvm.org/viewvc/llvm-project?rev=301520&view=rev
Log:
In the expression evaluator, descend into both the true and false expressions
of a ConditionalOperator when the condition can't be evaluated and we're in an
eval
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D32405
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
rsmith added inline comments.
Comment at: lib/AST/ExprConstant.cpp:4469-4470
{ return StmtVisitorTy::Visit(E->getSubExpr()); }
+ bool VisitObjCBoxedExpr(const ObjCBoxedExpr *E)
+{ return StmtVisitorTy::Visit(E->getSubExpr()); }
bool VisitChooseExpr(const ChooseExpr *
AndreiGrischenko added a comment.
In https://reviews.llvm.org/D32543#738595, @ahatanak wrote:
> Do you need a front-end test? Since the changes are in the backend, I think
> it's better to add the test to the backend (using llc).
Yes, changes are in the backend, but they fix interface between
95 matches
Mail list logo
