[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

frej added a comment. In https://reviews.llvm.org/D32745#744280, @rnk wrote: > The REQUIRES tag is unnecessary. Clang can emit IR for any target without a > registered backed. So should I drop it? It doesn't hurt does it? https://reviews.llvm.org/D32745 ___

[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

rnk added a comment. The REQUIRES tag is unnecessary. Clang can emit IR for any target without a registered backed. https://reviews.llvm.org/D32745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

r302000 - Revert rL301998: "Fix a bug that -isysroot is completely ignored on Unix"

Author: yamaguchi Date: Wed May 3 01:02:45 2017 New Revision: 302000 URL: http://llvm.org/viewvc/llvm-project?rev=302000&view=rev Log: Revert rL301998: "Fix a bug that -isysroot is completely ignored on Unix" This reverts commit because it broke sanitizer-x86_64-linux-autoconf bot and clang-ppc6

[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

frej updated this revision to Diff 97544. frej added a comment. Added missing "REQUIRES: mips-registered-target". https://reviews.llvm.org/D32745 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/mips-debug-info-bitfield.c Index: clang/test/CodeGen/mips-debug-info-bitfield.c ===

[PATCH] D31495: Fix a bug that -isysroot is completely ignored on Unix

This revision was automatically updated to reflect the committed changes. Closed by commit rL301998: Fix a bug that -isysroot is completely ignored on Unix (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D31495?vs=95402&id=97543#toc Repository: rL LLVM https://rev

r301994 - [sanitizer-coverage] add a deprecation warning to the old sanitizer-coverage flag combinations

Author: kcc Date: Tue May 2 20:27:28 2017 New Revision: 301994 URL: http://llvm.org/viewvc/llvm-project?rev=301994&view=rev Log: [sanitizer-coverage] add a deprecation warning to the old sanitizer-coverage flag combinations Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp cfe/trunk/test

First patch (Missing commas diagnostics)

This is my first patch. It's targeted at the parser/diagnostics. The goal of the patch is to anticipate missing commas in initializer lists and report them appropriately as errors, instead of the current "expected '}' to match '}'" errors. In summary, It detects missing commas only when successfu

Re: [llvm-dev] Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

I'm definitely in favor of efforts to defragment our many CI systems, but I also don't want to stop people from doing more testing. :) If AppVeyor is providing free testing resource to OSS projects, then great, let's try using it and see how it goes. On Fri, Apr 21, 2017 at 6:56 AM, Mike Edwards

[PATCH] D32778: [libcxx] [test] Conditionally workaround C1XX/EDG bugs

CaseyCarter added inline comments. Comment at: test/support/archetypes.hpp:20 protected: +#endif // !TEST_WORKAROUND_C1XX_BROKEN_ZA_CTOR_CHECK NullBase() = default; STL_MSFT wrote: > I think that this comment doesn't match the ifndef check, but it's a style

[PATCH] D32778: [libcxx] [test] Conditionally workaround C1XX/EDG bugs

STL_MSFT accepted this revision. STL_MSFT added inline comments. This revision is now accepted and ready to land. Comment at: test/support/archetypes.hpp:20 protected: +#endif // !TEST_WORKAROUND_C1XX_BROKEN_ZA_CTOR_CHECK NullBase() = default; I think that th

[PATCH] D32778: [libcxx] [test] Conditionally workaround C1XX/EDG bugs

CaseyCarter created this revision. Test support machinery changes needed to parse with EDG and compile with C1XX's /Za flag that disables MS extensions. I try to make changes to `` and the `optional`/`variant` tests simultaneously in the MS STL and in libc++, which realistically requires that I

r301992 - [modules] Round-trip -Werror flag through explicit module build.

Author: rsmith Date: Tue May 2 19:28:49 2017 New Revision: 301992 URL: http://llvm.org/viewvc/llvm-project?rev=301992&view=rev Log: [modules] Round-trip -Werror flag through explicit module build. The intent for an explicit module build is that the diagnostics produced within the module are thos

r301989 - [ODRHash] Add support for array and decayed types, and parameter names and types.

Author: rtrieu Date: Tue May 2 18:58:52 2017 New Revision: 301989 URL: http://llvm.org/viewvc/llvm-project?rev=301989&view=rev Log: [ODRHash] Add support for array and decayed types, and parameter names and types. Modified: cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td c

r301988 - [ubsan] Skip overflow checks on safe arithmetic (fixes PR32874)

Author: vedantk Date: Tue May 2 18:46:56 2017 New Revision: 301988 URL: http://llvm.org/viewvc/llvm-project?rev=301988&view=rev Log: [ubsan] Skip overflow checks on safe arithmetic (fixes PR32874) Currently, ubsan emits overflow checks for arithmetic that is known to be safe at compile-time, e.g

[PATCH] D32770: [X86][LWP] Add clang support for LWP instructions.

RKSimon added a comment. llvm patch: https://reviews.llvm.org/D32769 Repository: rL LLVM https://reviews.llvm.org/D32770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32770: [X86][LWP] Add clang support for LWP instructions.

RKSimon created this revision. Herald added a subscriber: mgorny. This patch adds support for the the LightWeight Profiling (LWP) instructions which are available on all AMD Bulldozer class CPUs (bdver1 to bdver4). Repository: rL LLVM https://reviews.llvm.org/D32770 Files: include/clang/B

[PATCH] D32767: [clang-tidy] Fix PR32896: detect initializer lists in modernize-use-empalce

kuhar created this revision. kuhar added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. This patch fixes PR32896 . The problem was that modernize-use-emplace incorrectly removed changed push_back into emplace_back, removing explic

r301981 - Re-land r301697 "[IR] Make add/remove Attributes use AttrBuilder instead of AttributeList"

Author: rnk Date: Tue May 2 17:07:37 2017 New Revision: 301981 URL: http://llvm.org/viewvc/llvm-project?rev=301981&view=rev Log: Re-land r301697 "[IR] Make add/remove Attributes use AttrBuilder instead of AttributeList" This time, I fixed, built, and tested clang. This reverts r301712. Modifi

[PATCH] D32759: Fix errored return value in CheckFunctionReturnType and add a fixit hint

erichkeane added a comment. In https://reviews.llvm.org/D32759#743860, @rnk wrote: > On cfe-dev you said "There IS a case in our tests where it would hit such an > assertion". Does "our tests" here refer to the existing clang tests or Intel > tests? I just want to make sure we have coverage of

[PATCH] D32759: Fix errored return value in CheckFunctionReturnType and add a fixit hint

rnk added a comment. On cfe-dev you said "There IS a case in our tests where it would hit such an assertion". Does "our tests" here refer to the existing clang tests or Intel tests? I just want to make sure we have coverage of this codepath in the test suite. I don't care that much about crafti

[PATCH] D32761: Fix bugs checking va_start in lambdas and erroneous contexts

rnk created this revision. First, getCurFunction looks through blocks and lambdas, which is wrong. Inside a lambda, va_start should refer to the lambda call operator prototype. This fixes PR32737. Second, we shouldn't use any of the getCur* methods, because they look through contexts that we don'

[PATCH] D32613: [Driver] Update Fuchsia driver path handling

mcgrathr added a comment. Perhaps use llvm::sys::path::parent_path instead of explicit "..". Perhaps put the getDriver.Dir() + .. + getTriple().str() logic into a shared subroutine. Use default rather that CST_Libstdcxx in the switches on GetCXXStdlibType. Repository: rL LLVM https://review

r301973 - [NFC] Add original test that triggered crash post r301735

Author: faisalv Date: Tue May 2 16:02:46 2017 New Revision: 301973 URL: http://llvm.org/viewvc/llvm-project?rev=301973&view=rev Log: [NFC] Add original test that triggered crash post r301735 - this is added just for completeness sake (though the general case should be represented by the test ad

r301972 - Fix PR32831 (Try Again): 'this' capture while instantiating generic lambda call operator specialization

Author: faisalv Date: Tue May 2 15:56:34 2017 New Revision: 301972 URL: http://llvm.org/viewvc/llvm-project?rev=301972&view=rev Log: Fix PR32831 (Try Again): 'this' capture while instantiating generic lambda call operator specialization When computing the appropriate cv-qualifiers for the 'this

[PATCH] D32759: Fix errored return value in CheckFunctionReturnType and add a

erichkeane created this revision. https://reviews.llvm.org/D32759 Files: lib/Sema/SemaType.cpp Index: lib/Sema/SemaType.cpp === --- lib/Sema/SemaType.cpp +++ lib/Sema/SemaType.cpp @@ -2285,8 +2285,9 @@ // Methods cannot return

Re: r301963 - Revert r301822 (and dependent r301825), which tried to improve the

On 2 May 2017 at 12:21, Daniel Jasper via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: djasper > Date: Tue May 2 14:21:42 2017 > New Revision: 301963 > > URL: http://llvm.org/viewvc/llvm-project?rev=301963&view=rev > Log: > Revert r301822 (and dependent r301825), which tried to impr

r301970 - [Sema] Update function doc; NFC

Author: gbiv Date: Tue May 2 15:24:56 2017 New Revision: 301970 URL: http://llvm.org/viewvc/llvm-project?rev=301970&view=rev Log: [Sema] Update function doc; NFC Modified: cfe/trunk/lib/Sema/SemaExpr.cpp Modified: cfe/trunk/lib/Sema/SemaExpr.cpp URL: http://llvm.org/viewvc/llvm-project/cfe

r301968 - Simplify some va_start checking logic

Author: rnk Date: Tue May 2 15:10:03 2017 New Revision: 301968 URL: http://llvm.org/viewvc/llvm-project?rev=301968&view=rev Log: Simplify some va_start checking logic Combine the logic doing the ms_abi/sysv_abi checks into one function so that each check and its logical opposite are near each ot

r301963 - Revert r301822 (and dependent r301825), which tried to improve the

Author: djasper Date: Tue May 2 14:21:42 2017 New Revision: 301963 URL: http://llvm.org/viewvc/llvm-project?rev=301963&view=rev Log: Revert r301822 (and dependent r301825), which tried to improve the handling of constexprs with unknown bounds. This triggers a corner case of the language where it

r301960 - Revert "[docs] UBSan: Mention that print_stacktrace=1 is unsupported on Darwin"

Author: vedantk Date: Tue May 2 13:51:41 2017 New Revision: 301960 URL: http://llvm.org/viewvc/llvm-project?rev=301960&view=rev Log: Revert "[docs] UBSan: Mention that print_stacktrace=1 is unsupported on Darwin" This reverts commit r300295. It's no longer true, print_stacktrace=1 is supported

[PATCH] D32690: [clang-tidy] modernize-use-emplace: Remove unnecessary make_tuple calls

JonasToth added a comment. i like the generalization. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:115 unless(isInTemplateInstantiation())) .bind("call"), this); i t

[PATCH] D32743: [clang-tidy] Add new cert-dcl21-cpp check.

Eugene.Zelenko added a comment. We have misc-unconventional-assign-operator and google-runtime-operator checks already. Form user perspective, I think will be good idea to have single check for different operators. Comment at: docs/ReleaseNotes.rst:63 + + Checks if the overl

[PATCH] D32743: [clang-tidy] Add new cert-dcl21-cpp check.

JonasToth added inline comments. Comment at: clang-tidy/cert/PostfixOperatorCheck.cpp:27 +hasOverloadedOperatorName("--"))) + .bind("decl"), + this); could the `,this);` be on thi

[PATCH] D32751: [ASTImporter] Support new kinds of declarations (mostly Using*)

a.sidorin created this revision. Herald added subscribers: rengolin, aemerson. Support new AST nodes: - UnresolvedUsingType - EmptyDecl - NamespaceAliasDecl - UsingDecl - UsingShadowDecl - UsingDirectiveDecl - UnresolvedUsingValueDecl - UnresolvedUsingTypenameDecl Refactor error handling in Imp

[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Doesn't the test need some kind of `REQUIRES: mips` line? Otherwise looks fine. https://reviews.llvm.org/D32745 ___ cfe-commits mailing list cf

Re: r301846 - Fix initial diagnostic state setup for an explicit module with no diagnostic pragmas.

On 1 May 2017 10:29 pm, "NAKAMURA Takumi" wrote: It didn't pass for targeting *-win32, since MicrosoftRecordLayoutBuilder doesn't have ability of -Wpadded. Tweaked in r301898. Thank you! I guess other diag would be available here but I have no good idea. On Tue, May 2, 2017 at 7:23 AM Richard

r301928 - [CodeGen] remove/fix checks that will fail when r301923 is recommitted

Author: spatel Date: Tue May 2 10:20:18 2017 New Revision: 301928 URL: http://llvm.org/viewvc/llvm-project?rev=301928&view=rev Log: [CodeGen] remove/fix checks that will fail when r301923 is recommitted Don't test the optimizer as part of front-end verification. Modified: cfe/trunk/test/Cod

[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

frej created this revision. Herald added subscribers: arichardson, aprantl. The change "[CodeView] Implement support for bit fields in Clang" (r274201, https://reviews.llvm.org/rL274201) broke the calculation of bit offsets for the debug info describing bitfields on big-endian targets. Prior to c

Re: r301916 - Revert r301735 (and subsequent r301786).

I forgot the () in the lambda definition, this should be: .. auto l = [this] { auto l = []() EXCLUSIVE_LOCKS_REQUIRED(mu_) {}; }; .. Doesn't change the fact that clang segfaults without this revert, though. On Tue, May 2, 2017 at 2:38 PM, Daniel Jasper via cfe-commits < cfe-commits@lists.l

r301916 - Revert r301735 (and subsequent r301786).

Author: djasper Date: Tue May 2 07:38:27 2017 New Revision: 301916 URL: http://llvm.org/viewvc/llvm-project?rev=301916&view=rev Log: Revert r301735 (and subsequent r301786). It leads to clang crashing, e.g. on this short code fragment (added to test/SemaCXX/warn-thread-safety-parsing.cpp): cl

Re: r301735 - Fix PR32831: 'this capture while instantiating generic lambda call operator specialization

I'll revert this as it makes the following snippet makes clang crash: class SomeClass { public: void foo() { auto l = [this] { auto l = [] EXCLUSIVE_LOCKS_REQUIRED(mu_) {}; }; } Mutex mu_; }; (e.g. this can be added to test/SemaCXX/warn-thread-safety-parsing.cpp) >From a brief look at

[PATCH] D32741: [clang-move] Find template class forward declarations more precisely.

This revision was automatically updated to reflect the committed changes. Closed by commit rL301914: [clang-move] Find template class forward declarations more precisely. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D32741?vs=97427&id=97434#toc Repository: rL LLVM

[clang-tools-extra] r301914 - [clang-move] Find template class forward declarations more precisely.

Author: hokein Date: Tue May 2 07:15:11 2017 New Revision: 301914 URL: http://llvm.org/viewvc/llvm-project?rev=301914&view=rev Log: [clang-move] Find template class forward declarations more precisely. Reviewers: ioeric Reviewed By: ioeric Subscribers: cfe-commits Differential Revision: https

Re: [PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

On 5/1/2017 6:17 PM, Hal Finkel wrote: However, the example can also be written as: struct X { int a, b; }; X x { 50, 100 }; X *o = (X*) &x.b; int a_is_b = o->a; // This is UB (or so we say)? and then the pointer arithmetic considerations don't seem to apply. I kn

[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Core/CheckerHelpers.cpp:116 +return false; + ConstraintManager &CM = State->getConstraintManager(); + ProgramStateRef StTrue, StFalse; danielmarjamaki wrote: > xazax.hun wrote: > > Any reason w

[PATCH] D31650: [Analyzer] Detect when function pointer is freed

This revision was automatically updated to reflect the committed changes. Closed by commit rL301913: [analyzer] Detect bad free of function pointers (authored by danielmarjamaki). Changed prior to commit: https://reviews.llvm.org/D31650?vs=95929&id=97432#toc Repository: rL LLVM https://revi

r301913 - [analyzer] Detect bad free of function pointers

Author: danielmarjamaki Date: Tue May 2 06:46:12 2017 New Revision: 301913 URL: http://llvm.org/viewvc/llvm-project?rev=301913&view=rev Log: [analyzer] Detect bad free of function pointers Differential Revision: https://reviews.llvm.org/D31650 Modified: cfe/trunk/lib/StaticAnalyzer/Checkers

[PATCH] D32741: [clang-move] Find template class forward declarations more precisely.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lgtm. Looks like the test case should already be covered. https://reviews.llvm.org/D32741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32741: [clang-move] Find template class forward declarations more precisely.

ioeric added a comment. Could you add the following test case for dumping all decls? template class Foo { public: Foo() {} }; typedef Foo Foo_i; https://reviews.llvm.org/D32741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32743: [clang-tidy] Add new cert-dcl21-cpp check.

xazax.hun created this revision. xazax.hun added a project: clang-tools-extra. Herald added subscribers: whisperity, mgorny. This check flags postfix ``operator++`` and ``operator--`` declarations, where the return type is not a const value type. It also attempt to fix the error. This rule is de

[PATCH] D32741: [clang-move] Find template class forward declarations more precisely.

hokein created this revision. https://reviews.llvm.org/D32741 Files: clang-move/ClangMove.cpp unittests/clang-move/ClangMoveTests.cpp Index: unittests/clang-move/ClangMoveTests.cpp === --- unittests/clang-move/ClangMoveTests.cp

[PATCH] D32700: [clang-tidy] Add misc-suspicious-memset-usage check.

malcolm.parsons added a comment. > The destination is a this pointer within a class that has a virtual function. > It might reset the virtual pointer. Can you change this to match any pointer to a class with a virtual function? I'd also like a warning for a pointer to a class with a constructor

[PATCH] D32566: Revert rL301328 and add tests for the regressions introduced.

emilio added a comment. I sent http://lists.llvm.org/pipermail/cfe-dev/2017-May/053703.html Repository: rL LLVM https://reviews.llvm.org/D32566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

r301906 - Remove leftover test expectation from rL301902.

Author: emilio Date: Tue May 2 04:57:30 2017 New Revision: 301906 URL: http://llvm.org/viewvc/llvm-project?rev=301906&view=rev Log: Remove leftover test expectation from rL301902. Modified: cfe/trunk/test/Index/print-type.cpp Modified: cfe/trunk/test/Index/print-type.cpp URL: http://llvm.o

r301902 - [libclang] Revert rL301328 and add tests for the regressions introduced.

Author: emilio Date: Tue May 2 03:32:15 2017 New Revision: 301902 URL: http://llvm.org/viewvc/llvm-project?rev=301902&view=rev Log: [libclang] Revert rL301328 and add tests for the regressions introduced. Differential Revision: https://reviews.llvm.org/D32566 Modified: cfe/trunk/test/Index

[PATCH] D32566: Revert rL301328 and add tests for the regressions introduced.

This revision was automatically updated to reflect the committed changes. Closed by commit rL301902: [libclang] Revert rL301328 and add tests for the regressions introduced. (authored by emilio). Changed prior to commit: https://reviews.llvm.org/D32566?vs=96838&id=97407#toc Repository: rL LL

[PATCH] D32733: [clang-format] Convert AlignEscapedNewlinesLeft to an enum, adding DontAlign

jtbandes added a comment. In https://reviews.llvm.org/D32733#743116, @djasper wrote: > This is an edge case in actual C++. An escaped newline literally gets > expanded to nothing. So what this reads is > > #define Onetwo \ > ... Yeah, I noticed that, but nonetheless it shouldn't break the ali

[PATCH] D32733: [clang-format] Convert AlignEscapedNewlinesLeft to an enum, adding DontAlign

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. This is an edge case in actual C++. An escaped newline literally gets expanded to nothing. So what this reads is #define Onetwo \ ... https://reviews.llvm.org/D32733 ___

[PATCH] D32733: [clang-format] Convert AlignEscapedNewlinesLeft to an enum, adding DontAlign

jtbandes marked an inline comment as done. jtbandes added a comment. This seems to work fine. Separately I noticed a strange edge case, which I think is an existing bug: #define One\ two \ three;

[PATCH] D32733: [clang-format] Convert AlignEscapedNewlinesLeft to an enum, adding DontAlign

jtbandes updated this revision to Diff 97404. jtbandes added a comment. Modified `appendNewlineText` so we can simply `return` in the DontAlign case. https://reviews.llvm.org/D32733 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/WhitespaceManager.cpp unittests/For

[PATCH] D32736: [libcxx][CMake] Set library dir when built under runtimes/

Hahnfeld created this revision. Herald added a subscriber: mgorny. This will put libraries into the build root's lib/ directory by default. https://reviews.llvm.org/D32736 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMa

[PATCH] D32735: [libcxxabi][CMake] Set library dir when built under runtimes/

Hahnfeld created this revision. Herald added a subscriber: mgorny. Herald added a reviewer: EricWF. This will put libraries into the build root's lib/ directory by default. https://reviews.llvm.org/D32735 Files: CMakeLists.txt Index: CMakeLists.txt ==