[PATCH] D34512: Add preliminary Cross Translation Unit support library

dcoughlin added a comment. > The importing alters the ASTContext, so the only way to choose between the > definitions would be via a callback that is triggered before the import is > done. What do you think? I think that could work. Another possibility would be to have a two step process. The

[PATCH] D37231: Add half load and store builtins

jvesely updated this revision to Diff 113190. jvesely added a comment. restrict builtins to OCLC langauges Repository: rL LLVM https://reviews.llvm.org/D37231 Files: include/clang/Basic/Builtins.def include/clang/Basic/Builtins.h lib/Basic/Builtins.cpp lib/CodeGen/CGBuiltin.cpp

[PATCH] D33852: Enable __declspec(selectany) on linux

Prazek updated this revision to Diff 113189. Prazek added a comment. - Add documentation https://reviews.llvm.org/D33852 Files: include/clang/Basic/Attr.td test/Sema/attr-selectany.c test/SemaCXX/attr-selectany.cpp Index: test/SemaCXX/attr-selectany.cpp

[PATCH] D33852: Enable __declspec(selectany) on linux

Prazek added a comment. In https://reviews.llvm.org/D33852#854213, @aaron.ballman wrote: > In https://reviews.llvm.org/D33852#854176, @Prazek wrote: > > > In https://reviews.llvm.org/D33852#853982, @aaron.ballman wrote: > > > > > In https://reviews.llvm.org/D33852#853410, @Prazek wrote: > > > >

[PATCH] D33719: Add _Float16 as a C/C++ source language type

rsmith added inline comments. Comment at: lib/Sema/SemaExpr.cpp:727-728 + // promote to double. + // Note that there is default argument promotion for '_Float16'; this + // applies to the standard floating types only. const BuiltinType *BTy = Ty->getAs();

[PATCH] D37023: [analyzer] Fix bugreporter::getDerefExpr() again.

dcoughlin added a comment. This seems like it is on the right track, but I think the emphasis here on lvalue-to-rvalue casts is a bit misplaced. The logic for "what is the pointer being dereferenced" and "what is the lvalue that holds the pointer being dereferenced" is mixed together in a way

r312085 - Give a better error if auto deduction fails due to inconsistent element types in a braced initializer list.

Author: rsmith Date: Tue Aug 29 17:44:08 2017 New Revision: 312085 URL: http://llvm.org/viewvc/llvm-project?rev=312085=rev Log: Give a better error if auto deduction fails due to inconsistent element types in a braced initializer list. Modified:

[PATCH] D37038: Replace temp MD nodes with unique/distinct before cloning

probinson added a comment. In https://reviews.llvm.org/D37038#89, @aprantl wrote: > This may have gotten lost earlier: Would it be possible to instruct > CloneFunction to not clone any temporary MDNodes via one of the flags that > are passed to the ValueMapper? I tried that. Basically,

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

efriedma added inline comments. Comment at: lib/Sema/SemaExpr.cpp:8808 +Context.getTypeSize(pointerType) == +Context.getTypeSize(IExp->getType())) + IsGNUIdiom = true; andrew.w.kaylor wrote: > efriedma wrote: > > rsmith wrote: > > >

[PATCH] D35216: [analyzer] Escape symbols when creating std::initializer_list.

rsmith added a comment. The `CXXStdInitializerListExpr` node has pretty simple evaluation semantics: it takes a glvalue array expression, and constructs a `std::initializer_list` from it as if by filling in the two members with a pointer to the array and either the size of the array or a

[PATCH] D37156: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer

morehouse updated this revision to Diff 113177. morehouse added a comment. - Only enable stack depth tracking on Linux. - Ignore __sancov_lowest_stack in interface symbols tests. https://reviews.llvm.org/D37156 Files: clang/lib/Driver/SanitizerArgs.cpp

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

andrew.w.kaylor added inline comments. Comment at: lib/Sema/SemaExpr.cpp:8808 +Context.getTypeSize(pointerType) == +Context.getTypeSize(IExp->getType())) + IsGNUIdiom = true; efriedma wrote: > rsmith wrote: > > andrew.w.kaylor wrote: >

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

efriedma added inline comments. Comment at: lib/Sema/SemaExpr.cpp:8808 +Context.getTypeSize(pointerType) == +Context.getTypeSize(IExp->getType())) + IsGNUIdiom = true; rsmith wrote: > andrew.w.kaylor wrote: > > efriedma wrote: > > >

r312084 - Driver: refactor SSP argument handling (NFC)

Author: compnerd Date: Tue Aug 29 16:59:08 2017 New Revision: 312084 URL: http://llvm.org/viewvc/llvm-project?rev=312084=rev Log: Driver: refactor SSP argument handling (NFC) Out-of-line the SSP argument handling for the sake of readability. Pass along some state information to avoid

r312083 - Driver: refactor OpenCL argument forwarding

Author: compnerd Date: Tue Aug 29 16:59:07 2017 New Revision: 312083 URL: http://llvm.org/viewvc/llvm-project?rev=312083=rev Log: Driver: refactor OpenCL argument forwarding Extract the argument forwarding for OpenCL arguments. Make this more data driven as we are just repeating the argument

r312082 - Driver: reuse existing `D` variable (NFC)

Author: compnerd Date: Tue Aug 29 16:59:06 2017 New Revision: 312082 URL: http://llvm.org/viewvc/llvm-project?rev=312082=rev Log: Driver: reuse existing `D` variable (NFC) Change the rest of the function to use the `D` variable for the driver instance. NFC. Modified:

r312081 - Driver: hoist a local variable (NFC)

Author: compnerd Date: Tue Aug 29 16:59:05 2017 New Revision: 312081 URL: http://llvm.org/viewvc/llvm-project?rev=312081=rev Log: Driver: hoist a local variable (NFC) Hoist the `getToolChain().getTriple()` to a variable rather than re-fetching it every time. NFC. Modified:

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

rsmith added inline comments. Comment at: lib/Sema/SemaExpr.cpp:8808 +Context.getTypeSize(pointerType) == +Context.getTypeSize(IExp->getType())) + IsGNUIdiom = true; andrew.w.kaylor wrote: > efriedma wrote: > > Please make sure you use

[libunwind] r312080 - Creating release candidate rc4 from release_500 branch

Author: hans Date: Tue Aug 29 16:49:14 2017 New Revision: 312080 URL: http://llvm.org/viewvc/llvm-project?rev=312080=rev Log: Creating release candidate rc4 from release_500 branch Added: libunwind/tags/RELEASE_500/rc4/ (props changed) - copied from r312079,

[libcxx] r312073 - Creating release candidate rc4 from release_500 branch

Author: hans Date: Tue Aug 29 16:49:07 2017 New Revision: 312073 URL: http://llvm.org/viewvc/llvm-project?rev=312073=rev Log: Creating release candidate rc4 from release_500 branch Added: libcxx/tags/RELEASE_500/rc4/ (props changed) - copied from r312072, libcxx/branches/release_50/

[libcxxabi] r312074 - Creating release candidate rc4 from release_500 branch

Author: hans Date: Tue Aug 29 16:49:07 2017 New Revision: 312074 URL: http://llvm.org/viewvc/llvm-project?rev=312074=rev Log: Creating release candidate rc4 from release_500 branch Added: libcxxabi/tags/RELEASE_500/rc4/ - copied from r312073, libcxxabi/branches/release_50/

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

andrew.w.kaylor added inline comments. Comment at: lib/Sema/SemaExpr.cpp:8808 +Context.getTypeSize(pointerType) == +Context.getTypeSize(IExp->getType())) + IsGNUIdiom = true; efriedma wrote: > Please make sure you use exactly the same

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

lhames added a comment. I've added an optional ErrMsg argument to cantFail in r312066 - you can now use this to preserve your explanatory text. https://reviews.llvm.org/D36806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. Hi Eric, thank you for your reply. Both these triples are currently broken, with my change and without. The attribute functionality in WinX86_64TargetCodeGenInfo mirrors one in X86_64TargetCodeGenInfo and it should work the same way. It is done intentionally as

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

andrew.w.kaylor added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6032 +def ext_gnu_null_ptr_arith : Extension< + "inttoptr casting using arithmetic on a null pointer is a GNU extension">, + InGroup; rsmith wrote: > efriedma wrote:

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

rnk added a comment. In https://reviews.llvm.org/D26764#855791, @eugenis wrote: > IMHO it was a very bad idea to include the "architecture name" (not even a > target triple!) in the library path in the first place. No one else does > that. GCC made the right choice and called theirs

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

erichkeane added a comment. In https://reviews.llvm.org/D36272#855957, @anatol.pomozov wrote: > The function-attributes.c test does not pass at Windows > even without my patch. Unfortunately > I am not familiar with clang enough to debug this issue.

r312049 - PR10147: When substituting a template template argument, substitute in the most

Author: rsmith Date: Tue Aug 29 15:14:43 2017 New Revision: 312049 URL: http://llvm.org/viewvc/llvm-project?rev=312049=rev Log: PR10147: When substituting a template template argument, substitute in the most recent (non-friend) declaration to pick up the right set of default template arguments.

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

eugenis added a comment. I've landed the android special case in r312048 Repository: rL LLVM https://reviews.llvm.org/D26764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37278: Restore clang_rt library name on i686-android.

This revision was automatically updated to reflect the committed changes. Closed by commit rL312048: Restore clang_rt library name on i686-android. (authored by eugenis). Changed prior to commit: https://reviews.llvm.org/D37278?vs=113167=113170#toc Repository: rL LLVM

r312048 - Restore clang_rt library name on i686-android.

Author: eugenis Date: Tue Aug 29 15:12:31 2017 New Revision: 312048 URL: http://llvm.org/viewvc/llvm-project?rev=312048=rev Log: Restore clang_rt library name on i686-android. Summary: Recent changes canonicalized clang_rt library names to refer to "i386" on all x86 targets. Android historically

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. The function-attributes.c test does not pass at Windows even without my patch. Unfortunately I am not familiar with clang enough to debug this issue. https://reviews.llvm.org/D36272

[PATCH] D37278: Restore clang_rt library name on i686-android.

eugenis updated this revision to Diff 113167. eugenis added a comment. +comment https://reviews.llvm.org/D37278 Files: clang/lib/Driver/ToolChain.cpp clang/test/Driver/sanitizer-ld.c compiler-rt/cmake/Modules/AddCompilerRT.cmake Index: compiler-rt/cmake/Modules/AddCompilerRT.cmake

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

erichkeane added a comment. Did you figure out why this doesn't work on windows? Not having the windows-specific x64 test seems like a mistake, unless we're going to make this a linux-only attribute. In which case, you'll have to remove this attribute in the 32-bit windows case.

r312047 - Revert "[SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer"

Author: morehouse Date: Tue Aug 29 14:56:56 2017 New Revision: 312047 URL: http://llvm.org/viewvc/llvm-project?rev=312047=rev Log: Revert "[SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer" This reverts r312026 due to bot breakage. Modified:

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov updated this revision to Diff 113166. anatol.pomozov edited the summary of this revision. https://reviews.llvm.org/D36272 Files: include/clang/Basic/Attr.td lib/CodeGen/TargetInfo.cpp test/CodeGen/function-attributes.c Index: test/CodeGen/function-attributes.c

[PATCH] D37278: Restore clang_rt library name on i686-android.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Thanks! Looks good to me. Comment at: clang/lib/Driver/ToolChain.cpp:308 + if (TC.getArch() == llvm::Triple::x86 && Triple.isAndroid()) +return "i686";

[PATCH] D37278: Restore clang_rt library name on i686-android.

eugenis created this revision. Herald added a subscriber: srhines. Recent changes canonicalized clang_rt library names to refer to "i386" on all x86 targets. Android historically uses i686. This change adds a special case to keep i686 in all clang_rt libraries when targeting Android.

r312037 - Re-enable stack depth instrumentation on Windows.

Author: morehouse Date: Tue Aug 29 14:15:33 2017 New Revision: 312037 URL: http://llvm.org/viewvc/llvm-project?rev=312037=rev Log: Re-enable stack depth instrumentation on Windows. Specified tls_model attribute properly. Should compile on Windows now. Modified:

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

hans added a comment. In https://reviews.llvm.org/D26764#855791, @eugenis wrote: > IMHO it was a very bad idea to include the "architecture name" (not even a > target triple!) in the library path in the first place. No one else does > that. GCC made the right choice and called theirs

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

rsmith added a comment. In https://reviews.llvm.org/D37042#855713, @efriedma wrote: > I didn't think of this earlier, but strictly speaking, I think > "(char*)nullptr+0" isn't undefined in C++? Yes, that's correct. (C++'s model is basically equivalent to having an object of size zero at the

r312032 - Disable stack depth tracking on Windows.

Author: morehouse Date: Tue Aug 29 13:44:41 2017 New Revision: 312032 URL: http://llvm.org/viewvc/llvm-project?rev=312032=rev Log: Disable stack depth tracking on Windows. Windows doesn't support the tls_model attribute. Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp Modified:

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

eugenis added a comment. IMHO it was a very bad idea to include the "architecture name" (not even a target triple!) in the library path in the first place. No one else does that. GCC made the right choice and called theirs "libasan.so". My plan is to tweak the code that sets the library name

r312029 - Minimal runtime for UBSan.

Author: eugenis Date: Tue Aug 29 13:03:51 2017 New Revision: 312029 URL: http://llvm.org/viewvc/llvm-project?rev=312029=rev Log: Minimal runtime for UBSan. Summary: An implementation of ubsan runtime library suitable for use in production. Minimal attack surface. * No stack traces. * Definitely

[PATCH] D37156: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer

This revision was automatically updated to reflect the committed changes. Closed by commit rL312026: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer (authored by morehouse). Changed prior to commit: https://reviews.llvm.org/D37156?vs=113133=113136#toc Repository: rL

r312026 - [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer

Author: morehouse Date: Tue Aug 29 12:48:12 2017 New Revision: 312026 URL: http://llvm.org/viewvc/llvm-project?rev=312026=rev Log: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer Summary: - Don't sanitize __sancov_lowest_stack. - Don't instrument leaf functions. - Add

[PATCH] D37156: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer

kcc accepted this revision. kcc added a comment. LGTM https://reviews.llvm.org/D37156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r312024 - [OPENMP] Capture global variables in all target executable regions.

Author: abataev Date: Tue Aug 29 12:30:57 2017 New Revision: 312024 URL: http://llvm.org/viewvc/llvm-project?rev=312024=rev Log: [OPENMP] Capture global variables in all target executable regions. Capturing of the global variables occurs only in target regions. Patch fixes it and allows

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

efriedma added a reviewer: rsmith. efriedma added a comment. I didn't think of this earlier, but strictly speaking, I think "(char*)nullptr+0" isn't undefined in C++? But probably worth emitting the warning anyway; anyone writing out arithmetic on null is probably doing something suspicious,

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

andrew.w.kaylor updated this revision to Diff 113134. andrew.w.kaylor added a comment. Added warnings for null pointer arithmetic. https://reviews.llvm.org/D37042 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CGExprScalar.cpp

[PATCH] D37156: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer

morehouse updated this revision to Diff 113133. morehouse added a comment. - Eliminate "#if". - Replace uintptr_t with uptr. https://reviews.llvm.org/D37156 Files: clang/lib/Driver/SanitizerArgs.cpp compiler-rt/lib/sanitizer_common/sanitizer_coverage_libcdep_new.cc

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

aaron.ballman added a comment. In https://reviews.llvm.org/D36272#851709, @erichkeane wrote: > Aaron would likely know better than me... but could it be the spelling type > should be GCC instead of GNU? Yes, this should be spelled with `GCC` rather than `GNU`, as it's a documented GCC

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

mgorny added a comment. I'm happy to help with whatever needs to be done to keep breakage to the minimum, provided that we determine some clear path forward that doesn't involve regressing to the half-broken state for non-Android Linux systems and it's doable in the free time I can spare.

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

eugenis added a comment. I may have underestimated the number of places that will need to be patched because of this change. Perhaps we should restore the special case in the android library name? Repository: rL LLVM https://reviews.llvm.org/D26764

[PATCH] D37156: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer

kcc added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:297 CoverageTraceCmp | CoveragePCTable; +#if !defined(__APPLE__) +// Due to TLS differences, stack depth tracking is disabled on Mac. please use

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. Another fact: gcc 7.2.0 supports this attribute at x86_64. It would be great if two major compilers were feature compatible and worked in a similar way. https://reviews.llvm.org/D36272 ___ cfe-commits mailing list

[PATCH] D37156: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer

morehouse updated this revision to Diff 113129. morehouse added a comment. - Disable stack depth tracking on Mac. https://reviews.llvm.org/D37156 Files: clang/lib/Driver/SanitizerArgs.cpp compiler-rt/lib/sanitizer_common/sanitizer_coverage_libcdep_new.cc

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

hans added inline comments. Comment at: compiler-rt/trunk/lib/asan/scripts/asan_device_setup:98 if [[ $_ABI == x86* ]]; then -_ARCH=i686 +_ARCH=i386 elif [[ $_ABI == armeabi* ]]; then There are lots of copies of this script in various

[PATCH] D37038: Replace temp MD nodes with unique/distinct before cloning

probinson added a comment. In https://reviews.llvm.org/D37038#89, @aprantl wrote: > This may have gotten lost earlier: Would it be possible to instruct > CloneFunction to not clone any temporary MDNodes via one of the flags that > are passed to the ValueMapper? I did look at that, sorry

[PATCH] D37249: [Bash-autocomplete] Refactor autocomplete code into own function

This revision was automatically updated to reflect the committed changes. Closed by commit rL312018: [Bash-autocomplete] Refactor autocomplete code into own function (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D37249?vs=113027=113118#toc Repository: rL LLVM

r312018 - [Bash-autocomplete] Refactor autocomplete code into own function

Author: yamaguchi Date: Tue Aug 29 10:46:46 2017 New Revision: 312018 URL: http://llvm.org/viewvc/llvm-project?rev=312018=rev Log: [Bash-autocomplete] Refactor autocomplete code into own function Summary: We wrote many codes in HandleImediateArgs, so I've refactored it into

r312017 - [ms] Fix vbtable index for covariant overrides of vbase methods

Author: rnk Date: Tue Aug 29 10:40:04 2017 New Revision: 312017 URL: http://llvm.org/viewvc/llvm-project?rev=312017=rev Log: [ms] Fix vbtable index for covariant overrides of vbase methods Overriding a method from a virtual base with a covariant return type consumes a slot from the vftable in

Re: r311823 - Add flag to request Clang is ABI-compatible with older versions of itself

Merged in r312013. On Fri, Aug 25, 2017 at 6:06 PM, Richard Smith wrote: > Hi Hans, > > We should get this into Clang 5 so that people can opt out of the ABI bugfix > for passing C++ class types by value. > > On 25 August 2017 at 18:04, Richard Smith via cfe-commits >

[PATCH] D37038: Replace temp MD nodes with unique/distinct before cloning

aprantl added a comment. This may have gotten lost earlier: Would it be possible to instruct CloneFunction to not clone any temporary MDNodes via one of the flags that are passed to the ValueMapper? https://reviews.llvm.org/D37038 ___

[PATCH] D36750: [analyzer] RetainCount: When diagnosing overrelease, mention if it's coming from a nested block.

NoQ updated this revision to Diff 113102. NoQ marked an inline comment as done. NoQ added a comment. Avoid creating a new `RefVal` kind. In https://reviews.llvm.org/D36750#843427, @dcoughlin wrote: > > By the way, plist-based tests in retain-release.m are disabled since > > r163536 (~2012),

[PATCH] D33719: Add _Float16 as a C/C++ source language type

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. Thanks @SjoerdMeijer This LGTM now. Wait a couple of days in case @rsmith has more comments. https://reviews.llvm.org/D33719 ___

[PATCH] D37001: [clang-diff] Use data collectors for node comparison

arphaman added inline comments. Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:537 + +#include "../../AST/DeclDataCollectors.inc" + I didn't realize that you're including files from within `lib`. That's not ideal. You should add a pre-commit that moves the *.inc

[PATCH] D33719: Add _Float16 as a C/C++ source language type

SjoerdMeijer updated this revision to Diff 113100. SjoerdMeijer added a comment. No changes were needed to make the conversions work, the existing logic is taking care of that, but I agree it doesn't hurt to add a few test cases. So I've added tests to both files, and cleaned up that comment.

[PATCH] D35216: [analyzer] Escape symbols when creating std::initializer_list.

NoQ updated this revision to Diff 113101. NoQ added a comment. Fix a bit of ObjCBoxedExpr behavior. https://reviews.llvm.org/D35216 Files: lib/StaticAnalyzer/Core/ExprEngine.cpp test/Analysis/initializer.cpp test/Analysis/objc-boxing.m Index: test/Analysis/objc-boxing.m

[PATCH] D35216: [analyzer] Escape symbols when creating std::initializer_list.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:1104 +// expression classes separately. +if (!isa(Ex)) + for (auto Child : Ex->children()) { dcoughlin wrote: > What is special about ObjCBoxedExpr here?

r312007 - [modules-ts] Omit submodule semantics for TS modules

Author: borisk Date: Tue Aug 29 08:30:18 2017 New Revision: 312007 URL: http://llvm.org/viewvc/llvm-project?rev=312007=rev Log: [modules-ts] Omit submodule semantics for TS modules If a TS module name has more than one component (e.g., foo.bar) then we erroneously activated the submodule

[PATCH] D35678: Omit sumbodule semantics for TS modules

This revision was automatically updated to reflect the committed changes. Closed by commit rL312007: [modules-ts] Omit submodule semantics for TS modules (authored by borisk). Changed prior to commit: https://reviews.llvm.org/D35678?vs=110875=113098#toc Repository: rL LLVM

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

koldaniel updated this revision to Diff 113094. koldaniel added a comment. Renaming the unsafe checker, updating tests. https://reviews.llvm.org/D35068 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/Driver/Tools.cpp lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp

[PATCH] D37263: [clang-format] Ignore case when sorting using-declarations

krasimir updated this revision to Diff 113092. krasimir added a comment. - Actually add a test https://reviews.llvm.org/D37263 Files: lib/Format/UsingDeclarationsSorter.cpp unittests/Format/UsingDeclarationsSorterTest.cpp Index: unittests/Format/UsingDeclarationsSorterTest.cpp

[PATCH] D33719: Add _Float16 as a C/C++ source language type

rogfer01 added a comment. There are a few tests checking the precise interaction between `__fp16` and `_Float16` values but I don't see tests interacting `_Float16` and the other standard floating types `float`, `double` and `long double`. Do you reckon it is worth adding them as well?

[PATCH] D37263: [clang-format] Ignore case when sorting using-declarations

krasimir created this revision. This ignores case while sorting using-declarations, fixing the wierd case in the last test case added. https://reviews.llvm.org/D37263 Files: lib/Format/UsingDeclarationsSorter.cpp unittests/Format/UsingDeclarationsSorterTest.cpp Index:

[PATCH] D37249: [Bash-autocomplete] Refactor autocomplete code into own function

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D37249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34512: Add preliminary Cross Translation Unit support library

xazax.hun updated this revision to Diff 113088. xazax.hun marked 2 inline comments as done. xazax.hun added a comment. - Updates according to review comments. https://reviews.llvm.org/D34512 Files: include/clang/Basic/AllDiagnostics.h include/clang/Basic/CMakeLists.txt

r312000 - [clang-format] Refactor likely xml a bit, NFC

Author: krasimir Date: Tue Aug 29 06:57:31 2017 New Revision: 312000 URL: http://llvm.org/viewvc/llvm-project?rev=312000=rev Log: [clang-format] Refactor likely xml a bit, NFC Modified: cfe/trunk/lib/Format/Format.cpp Modified: cfe/trunk/lib/Format/Format.cpp URL:

[PATCH] D37136: [clang-format] Do not format likely xml

This revision was automatically updated to reflect the committed changes. Closed by commit rL311999: [clang-format] Do not format likely xml (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D37136?vs=113085=113087#toc Repository: rL LLVM

[PATCH] D37136: [clang-format] Do not format likely xml

krasimir updated this revision to Diff 113085. krasimir marked 3 inline comments as done. krasimir added a comment. - Address review comments https://reviews.llvm.org/D37136 Files: lib/Format/Format.cpp unittests/Format/FormatTest.cpp unittests/Format/SortIncludesTest.cpp Index:

[PATCH] D37132: [clang-format] Add support for C++17 structured bindings.

curdeius updated this revision to Diff 113084. curdeius added a comment. Fix: use do-while loop. https://reviews.llvm.org/D37132 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D37143: [clang-format] Fixed typedef enum brace wrapping

PriMee added a comment. Could you change the "Contributed by" section? Wrong account is assigned. Full name would be more satisfying. Thank You in advance :) Repository: rL LLVM https://reviews.llvm.org/D37143 ___ cfe-commits mailing list

[PATCH] D37143: [clang-format] Fixed typedef enum brace wrapping

This revision was automatically updated to reflect the committed changes. Closed by commit rL311998: [clang-format] Fixed typedef enum brace wrapping (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D37143?vs=113062=113081#toc Repository: rL LLVM

r311998 - [clang-format] Fixed typedef enum brace wrapping

Author: krasimir Date: Tue Aug 29 06:32:30 2017 New Revision: 311998 URL: http://llvm.org/viewvc/llvm-project?rev=311998=rev Log: [clang-format] Fixed typedef enum brace wrapping Summary: Bug: https://bugs.llvm.org/show_bug.cgi?id=34016 - **Typedef enum part** **Problem:** Clang format does

[PATCH] D37132: [clang-format] Add support for C++17 structured bindings.

curdeius updated this revision to Diff 113079. curdeius added a comment. Extract method. https://reviews.llvm.org/D37132 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D37005: [clang-diff] Initial implementation of patching

johannes added inline comments. Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:73 public: + /// Empty (invalid) SyntaxTree. + SyntaxTree(); arphaman wrote: > Why do you need to create an empty tree? What about using llvm::Optional > instead? ok, i use

[PATCH] D37005: [clang-diff] Initial implementation of patching

johannes updated this revision to Diff 113078. johannes added a comment. fixes https://reviews.llvm.org/D37005 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTPatch.h lib/Tooling/ASTDiff/ASTDiff.cpp lib/Tooling/ASTDiff/ASTPatch.cpp

[PATCH] D37132: [clang-format] Add support for C++17 structured bindings.

curdeius updated this revision to Diff 113077. curdeius added a comment. Fix line endings again. https://reviews.llvm.org/D37132 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D37231: Add half load and store builtins

jvesely added inline comments. Comment at: include/clang/Basic/Builtins.def:1427 +// OpenCL half load/store builtin +BUILTIN(__builtin_store_half, "vdh*", "n") +BUILTIN(__builtin_store_halff, "vfh*", "n") Anastasia wrote: > I think this should be a language

[PATCH] D37140: [clang-format] Fixed one-line if statement

PriMee updated this revision to Diff 113074. PriMee added a comment. Unit tests added. https://reviews.llvm.org/D37140 Files: lib/Format/UnwrappedLineFormatter.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D36998: [AST] Traverse templates in LexicallyOrderedRecursiveASTVisitor

johannes added a comment. This is currently broken, if a user provides a TraverseClassTemplateDecl, then the same method in this class will not be called, I think I will add a flag (probably not user visible) in RecursiveASTVisitor.h to switch the order for templates

[PATCH] D37132: [clang-format] Add support for C++17 structured bindings.

curdeius updated this revision to Diff 113073. curdeius added a comment. Fix line endings. https://reviews.llvm.org/D37132 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D37143: [clang-format] Fixed typedef enum brace wrapping

PriMee added a comment. I am glad to hear that. Would be great if someone could commit it. Thank You :) https://reviews.llvm.org/D37143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36410: [OpenCL] Handle taking address of block captures

bader added a comment. In https://reviews.llvm.org/D36410#855282, @Anastasia wrote: > Ok, I will update it to be implicitly generic then. Just to be sure, @bader > do you agree on this too? > An alternative approached could be (in case we want to allow this code) to > **assume captures are

[PATCH] D37005: [clang-diff] Initial implementation of patching

arphaman added inline comments. Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:73 public: + /// Empty (invalid) SyntaxTree. + SyntaxTree(); Why do you need to create an empty tree? What about using llvm::Optional instead? Comment at:

[PATCH] D37005: [clang-diff] Initial implementation of patching

arphaman added inline comments. Comment at: include/clang/Tooling/ASTDiff/ASTPatch.h:1 +//===- ASTDiff.h - Structural patching based on ASTDiff ---*- C++ -*- -===// +// Please update the file name in the comment Comment at:

[PATCH] D37200: [AST] Traverse CXXOperatorCallExpr in LexicallyOrderedRecursiveASTVisitor

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Lgtm with two requests below Comment at: include/clang/AST/RecursiveASTVisitor.h:354 +protected: + bool TraverseStmtBase(Stmt *S, DataRecursionQueue *Queue) { +

[PATCH] D37136: [clang-format] Do not format likely xml

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Just a few minor comments, otherwise looks good. Comment at: lib/Format/Format.cpp:1542 +bool likelyXml(StringRef Code) { + return Code.ltrim().startswith("<");

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

koldaniel updated this revision to Diff 113065. koldaniel added a comment. Updated checker name, minor modifications https://reviews.llvm.org/D35068 Files: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp Index: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp

  1   2   >