Author: chapuni
Date: Wed Oct 11 23:39:44 2017
New Revision: 315566
URL: http://llvm.org/viewvc/llvm-project?rev=315566&view=rev
Log:
clang/module.modulemap: Create Clang_Frontend_CodeGenOptions to remove some
dependencies in clangBasic.
- Clang_Analysis
- Clang_C
- Clang_Frontend
- Clang_Lex
-
nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D38770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
arphaman created this revision.
Repository:
rL LLVM
https://reviews.llvm.org/D38835
Files:
include/clang/Tooling/Refactoring/ASTSelection.h
lib/Tooling/Refactoring/ASTSelection.cpp
unittests/Tooling/ASTSelectionTest.cpp
Index: unittests/Tooling/ASTSelectionTest.cpp
=
mstorsjo added a comment.
In https://reviews.llvm.org/D38821#895527, @compnerd wrote:
> Don't you need a change to the intrinsics to actually map the builtin?
Apparently, this change is all that's needed since the tests pass. I can of
course try to look closer and see what actually makes it wo
mstorsjo added inline comments.
Comment at: src/libunwind.cpp:188
+ co->getInfo(&info);
+ pint_t orgArgSize = (pint_t)info.gp;
+ uint64_t orgFuncStart = info.start_ip;
rnk wrote:
> I think it makes sense to have this here: the contract is that if t
compnerd added a comment.
Don't you need a change to the intrinsics to actually map the builtin?
https://reviews.llvm.org/D38821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ctopper
Date: Wed Oct 11 19:06:17 2017
New Revision: 315547
URL: http://llvm.org/viewvc/llvm-project?rev=315547&view=rev
Log:
[X86] Remove a few unnecessary check lines from the predefined-arch-macros test.
These were testing OS macros and clang/llvm macros.
Modified:
cfe/trunk/test/
rsmith added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:8667-8679
+ bool Result; // The result of the comparison
+ if ((Op == BO_GT && ValueType == LimitType::Max && ConstOnRight) ||
+ (Op == BO_GT && ValueType == LimitType::Min && !ConstOnRight) ||
+ (Op
Author: zturner
Date: Wed Oct 11 16:54:34 2017
New Revision: 315536
URL: http://llvm.org/viewvc/llvm-project?rev=315536&view=rev
Log:
Revert "[ADT] Make Twine's copy constructor private."
This reverts commit 4e4ee1c507e2707bb3c208e1e1b6551c3015cbf5.
This is failing due to some code that isn't bu
K-ballo created this revision.
Introduce a new form of `result_of` without function type encoding.
Rename and split `is_callable/is_nothrow_callable` into
`is_invocable/is_nothrow_invocable/is_invocable_r/is_nothrow_invocable_r` (and
associated types accordingly)
Change function type encoding
Hello everyone,
Below are some buildbot numbers for the last week of 10/1/2017 - 10/7/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed
Hello everyone,
Below are some buildbot numbers for the week of 09/24/2017 - 09/30/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to
Author: lhames
Date: Wed Oct 11 16:35:27 2017
New Revision: 315532
URL: http://llvm.org/viewvc/llvm-project?rev=315532&view=rev
Log:
Update cc1as_main for MCCodeEmitter ownership change in r315531.
Modified:
cfe/trunk/tools/driver/cc1as_main.cpp
Modified: cfe/trunk/tools/driver/cc1as_main.cp
Author: zturner
Date: Wed Oct 11 16:33:06 2017
New Revision: 315530
URL: http://llvm.org/viewvc/llvm-project?rev=315530&view=rev
Log:
[ADT] Make Twine's copy constructor private.
There's a lot of misuse of Twine scattered around LLVM. This
ranges in severity from benign (returning a Twine from a
danalbert abandoned this revision.
danalbert added a comment.
nbjoerg and zygoloid got me pointed in the right direction. Both `Base` and
`BaseImpl` are missing their key functions, and that's the problem here. Patch
should be unnecessary.
https://reviews.llvm.org/D38599
___
danalbert abandoned this revision.
danalbert added a comment.
zygoloid and nbjoerg got me pointed in the right direction on this. Looks like
the user didn't have a key function defined for one of their classes, which was
actually the root of the problem.
Repository:
rL LLVM
https://reviews.
george.karpenkov added a comment.
@mgorny I've replied via email, but the message didn't seem to appear here.
From my (maybe limited) understanding, running tests on standalone compiler-rt
builds was never something which was supported, as that required a fresh
compiler.
I've just tried running
chandlerc added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:844-845
-// FIXME: Historically, we defined this legacy name, it would be nice to
-// remove it at some point. We've never exposed fine-grained names for
-// recent primary x86 CPUs, and we should
On 22 September 2017 at 18:00, Volodymyr Sapsai via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
>
> On Sep 21, 2017, at 15:17, Richard Smith wrote:
>
> On 15 September 2017 at 12:51, Volodymyr Sapsai via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: vsapsai
>> Date: Fri S
jroelofs added a comment.
Needs a docs entry for the new flag (in libcxx's BuildingLibcxx.rst). Other
than that, all the stuff I've asked you to add LGTM. I'd still appreciate
@EricWF/@mclow's opinion on the meat of the functional change part of this
though... I don't know all the implications
danalbert planned changes to this revision.
danalbert added a comment.
In https://reviews.llvm.org/D38599#894041, @jroelofs wrote:
> (possibly renamed to _LIBCXXABI_DYNAMIC_FALLBACK)
I opted for adding this switch to libc++ instead. Like @rprichard points out,
we'll need to do this in `std::ty
craig.topper added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:844-845
-// FIXME: Historically, we defined this legacy name, it would be nice to
-// remove it at some point. We've never exposed fine-grained names for
-// recent primary x86 CPUs, and we shou
danalbert planned changes to this revision.
danalbert added a comment.
Actually, I was wrong. This is implemented. Will update to set the flag the
configures this and add a test.
Repository:
rL LLVM
https://reviews.llvm.org/D38827
___
cfe-commit
danalbert created this revision.
Herald added a subscriber: mgorny.
libc++ doesn't yet have the code for this, but libc++abi does. Adding
the switch to libc++ since the flag in libc++abi is
`_LIBCXX_DYNAMIC_FALLBACK`, not `_LIBCXXABI_DYNAMIC_FALLBACK`, and it
will be needed here as well.
Reposit
danalbert updated this revision to Diff 118711.
danalbert added a comment.
Herald added a subscriber: mgorny.
Update the test with an XFAIL when _LIBCXX_DYNAMIC_FALLBACK is not set.
https://reviews.llvm.org/D38827 adds this cmake option to libc++.
https://reviews.llvm.org/D38599
Files:
CMake
chandlerc added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:844-845
-// FIXME: Historically, we defined this legacy name, it would be nice to
-// remove it at some point. We've never exposed fine-grained names for
-// recent primary x86 CPUs, and we should
mgrang added a comment.
LGTM.
https://reviews.llvm.org/D38821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
In https://reviews.llvm.org/D35082#895230, @rjmccall wrote:
> It sounds like there's agreement about the basic technical direction of
> introducing LangAS::opencl_private. Please introduce
> isAddressSpaceImplicit() in a differen
Author: vedantk
Date: Wed Oct 11 14:54:09 2017
New Revision: 315518
URL: http://llvm.org/viewvc/llvm-project?rev=315518&view=rev
Log:
[Driver] Export symbols needed to use profile runtime
Apple's API verification tool (tapi) checks that the symbols exported
from a program match a whitelist. When
rnk added inline comments.
Comment at: src/libunwind.cpp:188
+ co->getInfo(&info);
+ pint_t orgArgSize = (pint_t)info.gp;
+ uint64_t orgFuncStart = info.start_ip;
I think it makes sense to have this here: the contract is that if the
personality se
Author: ctopper
Date: Wed Oct 11 14:42:02 2017
New Revision: 315517
URL: http://llvm.org/viewvc/llvm-project?rev=315517&view=rev
Log:
[X86] Add support for 'amdfam17h' to __builtin_cpu_is to match gcc.
The compiler-rt implementation already supported it, it just wasn't exposed.
Modified:
cfe
jlebar added a comment.
> The only reason I added this namespace is that I wasn't sure whether having
> those functions in the clang namespace is acceptable.
Maybe someone else will object, or suggest an existing namespace they should be
in. FWIW I think it's fine.
> Not quite sure what to ca
arichardson added inline comments.
Comment at: include/clang/Basic/AddressSpaces.h:51
+namespace LanguageAS {
/// The type of a lookup table which maps from language-specific address spaces
jlebar wrote:
> I wonder if you need this namespace? LangAS right nex
arphaman added inline comments.
Comment at: lib/Basic/DiagnosticIDs.cpp:46
unsigned WarnShowInSystemHeader : 1;
- unsigned Category : 5;
+ unsigned Category : 6;
hokein wrote:
> just curious: is this change needed?
I get a build warning without this change
arphaman updated this revision to Diff 118701.
arphaman marked 2 inline comments as done.
arphaman added a comment.
- rename the common consumer class.
Repository:
rL LLVM
https://reviews.llvm.org/D38772
Files:
include/clang/Basic/AllDiagnostics.h
include/clang/Basic/CMakeLists.txt
inc
craig.topper created this revision.
Herald added a subscriber: krytarowski.
We were using corei7 for a large swatch of Intel CPUs. gcc has a different
defines that more closely match the march flags. This updates to match. It
also fixes skylake-avx512 and adds silvermont in addition to slm.
h
rjmccall added a comment.
It sounds like there's agreement about the basic technical direction of
introducing LangAS::opencl_private. Please introduce isAddressSpaceImplicit()
in a different patch and make this patch just about the introduction of
LangAS::opencl_private. You can have the pret
mstorsjo created this revision.
Herald added subscribers: kristof.beyls, javed.absar, aemerson.
This is an update to https://reviews.llvm.org/D36111 by @mgrang, taking over
finishing of this patch. Compared to his version, this makes the intrinsics
conditional to ALL_MS_LANGUAGES.
https://revi
Nebiroth marked an inline comment as done.
Nebiroth added inline comments.
Comment at: clangd/ClangdUnit.cpp:784
+/// Finds declarations locations that a given source location refers to.
+class TargetDeclarationFinder : public index::IndexDataConsumer {
+ std::vector Declaration
Author: george.karpenkov
Date: Wed Oct 11 13:53:01 2017
New Revision: 315508
URL: http://llvm.org/viewvc/llvm-project?rev=315508&view=rev
Log:
[Analyzer] Support bodyfarming libstdc++ implementation of std::call_once.
Differential Revision: https://reviews.llvm.org/D38810
Modified:
cfe/trunk
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315508: [Analyzer] Support bodyfarming libstdc++
implementation of std::call_once. (authored by george.karpenkov).
Changed prior to commit:
https://reviews.llvm.org/D38810?vs=118644&id=118686#toc
Repos
mstorsjo added a comment.
As further explanation/justification - libcxxabi and libunwind don't support
SEH exceptions yet.
https://reviews.llvm.org/D38819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Author: morehouse
Date: Wed Oct 11 13:45:10 2017
New Revision: 315506
URL: http://llvm.org/viewvc/llvm-project?rev=315506&view=rev
Log:
[clang-fuzzer] Build with newer protobuf-mutator.
Modified:
cfe/trunk/cmake/modules/ProtobufMutator.cmake
Modified: cfe/trunk/cmake/modules/ProtobufMutator.
eugenis added a comment.
ping
https://reviews.llvm.org/D38430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar added a comment.
My only regret is that I have but one +1 to give to this patch.
Comment at: include/clang/Basic/AddressSpaces.h:51
+namespace LanguageAS {
/// The type of a lookup table which maps from language-specific address spaces
I wonder if you
Carrot created this revision.
In function GetIntrinsic, not all types are covered. Types double and long long
are missed, type long is wrongly treated same as int, it should be same as long
long. These problems cause compiler crashes when compiling code in PR31161.
This patch fixed the problem.
yaxunl added a comment.
If there is no other issues. May I commit this patch now? Thanks.
https://reviews.llvm.org/D35082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo created this revision.
Herald added a subscriber: aprantl.
Clang doesn't currently support building for windows/x86_64 with dwarf by
setting command line parameters, but if manually modified to use dwarf, we can
make libunwind work in this configuration as well.
Even if support for thi
yaxunl updated this revision to Diff 118677.
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
Revised by Anastasia's comments. Get block invoke function by API instead of
iterate through IR's. Pass the block kernel directly to `__enqueu_kernel
functions`.
https://reviews.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315498: Support DWARF unwinding on i386 windows (authored by
mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D38679?vs=118263&id=118673#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Author: mstorsjo
Date: Wed Oct 11 13:06:18 2017
New Revision: 315498
URL: http://llvm.org/viewvc/llvm-project?rev=315498&view=rev
Log:
Support DWARF unwinding on i386 windows
In practice, with code built with clang, there are still unresolved
issues with DW_CFA_GNU_args_size though.
Differential
arichardson created this revision.
Herald added subscribers: Anastasia, nhaehnle, jholewinski.
Currently both clang AST address spaces and target specific address spaces
are represented as unsigned which can lead to subtle errors if the wrong
type is passed. It is especially confusing in the CodeG
mstorsjo added a comment.
In https://reviews.llvm.org/D36111#895084, @mgrang wrote:
> Sorry, I never got to complete this as I moved to other priorities. I do not
> think I have cycles to do this now. Please feel free to take over this patch
> :)
Ok - will do! Thanks for letting me know!
ht
On Wed, Oct 11, 2017 at 3:29 PM, Alexander Kornienko wrote:
> On Fri, Oct 6, 2017 at 3:27 PM, Aaron Ballman via cfe-commits
> wrote:
>>
>> Author: aaronballman
>> Date: Fri Oct 6 06:27:59 2017
>> New Revision: 315060
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=315060&view=rev
>> Log:
>> R
mgrang added a comment.
In https://reviews.llvm.org/D36111#894604, @mstorsjo wrote:
> @mgrang, did you ever get to completing this? I've got a need for this now
> (only `__dmb` so far), and if you don't have time, I can try to finish it.
Sorry, I never got to complete this as I moved to other
mstorsjo added a comment.
In https://reviews.llvm.org/D38679#894668, @jroelofs wrote:
> LGTM
Thanks, will push this one without the docs update since it's still buggy in
practice on windows until https://reviews.llvm.org/D38680 gets resolved.
https://reviews.llvm.org/D38679
__
On Fri, Oct 6, 2017 at 3:27 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: aaronballman
> Date: Fri Oct 6 06:27:59 2017
> New Revision: 315060
>
> URL: http://llvm.org/viewvc/llvm-project?rev=315060&view=rev
> Log:
> Renaming a test to start with the name of the
Author: george.karpenkov
Date: Wed Oct 11 12:13:15 2017
New Revision: 315492
URL: http://llvm.org/viewvc/llvm-project?rev=315492&view=rev
Log:
[Analyzer] Fix introduced regression: properly check for nullable attribute.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/NonnullStringConstantsChe
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
OK. Seems reasonable!
https://reviews.llvm.org/D23963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Sure.
https://reviews.llvm.org/D38733
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Nebiroth added a comment.
Bumping this.
I've worked on a patch for this feature that currently supports showing the
declaration of whatever is being hovered on instead of the raw source code. It
also has basic support to distinguish declarations in types ( class/struct,
namespace, global varia
Author: george.karpenkov
Date: Wed Oct 11 11:42:39 2017
New Revision: 315489
URL: http://llvm.org/viewvc/llvm-project?rev=315489&view=rev
Log:
[Analyzer] Remove dead code from testing scripts
Differential Revision: https://reviews.llvm.org/D38488
Modified:
cfe/trunk/utils/analyzer/SATestBuil
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315488: [Analyzer] Assume that string-like const globals are
non-nil. (authored by george.karpenkov).
Changed prior to commit:
https://reviews.llvm.org/D38764?vs=118657&id=118660#toc
Repository:
rL L
Author: george.karpenkov
Date: Wed Oct 11 11:39:40 2017
New Revision: 315488
URL: http://llvm.org/viewvc/llvm-project?rev=315488&view=rev
Log:
[Analyzer] Assume that string-like const globals are non-nil.
Differential Revision: https://reviews.llvm.org/D38764
Added:
cfe/trunk/lib/StaticAnaly
george.karpenkov updated this revision to Diff 118657.
george.karpenkov marked 2 inline comments as done.
https://reviews.llvm.org/D38764
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/NonnullStringConstantsChe
george.karpenkov marked 9 inline comments as done.
george.karpenkov added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/NonnullStringConstantsChecker.cpp:22
+// Checker uses are defined in the test file:
+// - test/Analysis/nonnull-string-constants.mm
+//
--
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
This looks good to me.
https://reviews.llvm.org/D38797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315486: [clang-fuzzer] Allow linking with any fuzzing
engine. (authored by morehouse).
Changed prior to commit:
https://reviews.llvm.org/D38812?vs=118651&id=118655#toc
Repository:
rL LLVM
https://re
Author: morehouse
Date: Wed Oct 11 11:29:24 2017
New Revision: 315486
URL: http://llvm.org/viewvc/llvm-project?rev=315486&view=rev
Log:
[clang-fuzzer] Allow linking with any fuzzing engine.
Summary:
Makes clang-[proto-]fuzzer compatible with flags specified by OSS-Fuzz.
https://llvm.org/pr34314
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM with the dyn_cast mentioned inline changed.
Comment at: lib/Analysis/BodyFarm.cpp:359
+ ValueDecl *FieldDecl = dyn_cast(FoundDecl);
bool isLambdaCall = Callb
kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D38812
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
morehouse created this revision.
Herald added a subscriber: mgorny.
Makes clang-[proto-]fuzzer compatible with flags specified by OSS-Fuzz.
https://llvm.org/pr34314
https://reviews.llvm.org/D38812
Files:
clang/tools/clang-fuzzer/CMakeLists.txt
Index: clang/tools/clang-fuzzer/CMakeLists.txt
danielmarjamaki added a comment.
In https://reviews.llvm.org/D37897#892667, @dcoughlin wrote:
> Apologies for the delay reviewing! As I noted inline, I'm pretty worried
> about the performance impact of this. Is it possible to do the analysis in a
> single traversal of the translation unit?
I
erichkeane updated this revision to Diff 118648.
erichkeane added a comment.
Craig noticed a pair of ordering issues in the TargetArray list, so fixed htose.
https://reviews.llvm.org/D38596
Files:
include/clang/AST/Decl.h
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds
george.karpenkov created this revision.
Herald added subscribers: szepet, kristof.beyls, xazax.hun, javed.absar,
aemerson.
https://reviews.llvm.org/D38810
Files:
lib/Analysis/BodyFarm.cpp
test/Analysis/call_once.cpp
Index: test/Analysis/call_once.cpp
jlebar added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9733
+ return nullptr;
+bool isColMajor = isColMajorArg.getZExtValue();
+unsigned IID;
tra wrote:
> jlebar wrote:
> > Urg, this isn't a bool? Do we want it to be?
> There are
bsdjhb updated this revision to Diff 118638.
bsdjhb added a comment.
- Add more soft-float checks.
https://reviews.llvm.org/D38110
Files:
include/__libunwind_config.h
include/libunwind.h
src/Registers.hpp
src/UnwindCursor.hpp
src/UnwindRegistersRestore.S
src/UnwindRegistersSave.S
Nebiroth marked 3 inline comments as done.
Nebiroth added inline comments.
Comment at: clangd/ClangdUnit.cpp:1017
+
+ auto DeclLocationsFinder = std::make_shared(
+ llvm::errs(), SourceLocationBeg, AST.getASTContext(),
ilya-biryukov wrote:
> I wonder if we
tra added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9726
+ case NVPTX::BI__hmma_m16n16k16_ld_c_f16:
+case NVPTX::BI__hmma_m16n16k16_ld_c_f32:{
+Address Dst = EmitPointerWithAlignment(E->getArg(0));
jlebar wrote:
> weird indentation?
My
tra updated this revision to Diff 118636.
tra marked 6 inline comments as done.
tra added a comment.
Addressed Justin's comments.
https://reviews.llvm.org/D38742
Files:
clang/include/clang/Basic/BuiltinsNVPTX.def
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeGen/builtins-nvptx-sm_70.cu
jlebar accepted this revision.
jlebar added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9726
+ case NVPTX::BI__hmma_m16n16k16_ld_c_f16:
+case NVPTX::BI__hmma_m16n16k16_ld_c_f32:{
+Address Dst = EmitPointer
hokein added inline comments.
Comment at: cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp:113
Rules.push_back(createRefactoringActionRule(
-SymbolSelectionRequirement()));
+SymbolSelectionRequirement(), OptionRequirement()));
return Rules;
--
Author: ctopper
Date: Wed Oct 11 09:06:08 2017
New Revision: 315470
URL: http://llvm.org/viewvc/llvm-project?rev=315470&view=rev
Log:
[X86] Correct type for argument to clflushopt intrinsic.
Summary: According to Intel docs this should take void const *. We had char*.
The lack of const is the ma
Author: abataev
Date: Wed Oct 11 08:56:38 2017
New Revision: 315467
URL: http://llvm.org/viewvc/llvm-project?rev=315467&view=rev
Log:
[OPENMP] Remove extra if, NFC.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
URL:
http://llvm.org/v
Author: morehouse
Date: Wed Oct 11 08:51:12 2017
New Revision: 315465
URL: http://llvm.org/viewvc/llvm-project?rev=315465&view=rev
Log:
Reland "[clang-fuzzer] Allow building without coverage instrumentation."
This relands r315336 after fixing bot breakage.
Added:
cfe/trunk/tools/clang-fuzzer
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM - thanks!
https://reviews.llvm.org/D38757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
rwols accepted this revision.
rwols added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D38720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: abataev
Date: Wed Oct 11 08:29:40 2017
New Revision: 315464
URL: http://llvm.org/viewvc/llvm-project?rev=315464&view=rev
Log:
[OPENMP] Fix PR34916: Crash on mixing taskloop|tasks directives.
If both taskloop and task directives are used at the same time in one
program, we may ran into the
NoQ updated this revision to Diff 118625.
NoQ added a comment.
Herald added a subscriber: szepet.
Because i didn't get back to this in a while, and similar crashes keep coming,
i decided to leave this refactoring as a FIXME.
https://reviews.llvm.org/D23963
Files:
lib/StaticAnalyzer/Core/Regi
Author: morehouse
Date: Wed Oct 11 08:13:53 2017
New Revision: 315463
URL: http://llvm.org/viewvc/llvm-project?rev=315463&view=rev
Log:
[clang-fuzzer] Fix shared library dependencies.
Modified:
cfe/trunk/tools/clang-fuzzer/CMakeLists.txt
cfe/trunk/tools/clang-fuzzer/handle-cxx/CMakeLists.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315462: [Analyzer] Clarify error messages for undefined
result (authored by danielmarjamaki).
Changed prior to commit:
https://reviews.llvm.org/D30295?vs=116865&id=118620#toc
Repository:
rL LLVM
htt
Author: danielmarjamaki
Date: Wed Oct 11 07:49:35 2017
New Revision: 315462
URL: http://llvm.org/viewvc/llvm-project?rev=315462&view=rev
Log:
[Analyzer] Clarify error messages for undefined result
Differential Revision: https://reviews.llvm.org/D30295
Modified:
cfe/trunk/include/clang/Stati
arphaman added a comment.
In https://reviews.llvm.org/D37856#894638, @hokein wrote:
> Sorry for the delay. I saw you have reverted this commit somehow. A post
> commit.
I had some issues with ppc64/s390x bots for some reason, so I had to revert.
I'm still trying to investigate what went wrong
szdominik added inline comments.
Comment at: clang-tidy/misc/CopyConstructorInitCheck.cpp:37
+
+ // We match here because we want one warning (and FixIt) for every ctor.
+ const auto Matches = match(
aaron.ballman wrote:
> Wouldn't registering this matcher achi
szdominik updated this revision to Diff 118617.
szdominik marked 4 inline comments as done.
szdominik added a comment.
Small changes after aaron.ballman's comments.
https://reviews.llvm.org/D33722
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/CopyConstructorInitCheck.cpp
clang-tid
NoQ created this revision.
Herald added a subscriber: szepet.
In https://reviews.llvm.org/D38358, we ended up believing that reading the
first byte of the void pointer is not the intended behavior of
`ProgramState::getSVal(Loc)`. Hence the fix.
Additionally, allow specifying the type in the `Pr
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D38679
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
grokos created this revision.
grokos added a project: clang.
This patch completes the support for the "declare target" directive in Sema.
With this patch Sema handles implicitly used functions (i.e. functions which
are used inside a target region without having been "declared target")
including
Author: hokein
Date: Wed Oct 11 07:00:42 2017
New Revision: 315459
URL: http://llvm.org/viewvc/llvm-project?rev=315459&view=rev
Log:
[clang-rename] Add more unittest.
Modified:
cfe/trunk/unittests/Rename/RenameClassTest.cpp
Modified: cfe/trunk/unittests/Rename/RenameClassTest.cpp
URL:
http:
hokein added a comment.
Sorry for the delay. I saw you have reverted this commit somehow. A post commit.
Comment at: cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp:113
Rules.push_back(createRefactoringActionRule(
-SymbolSelectionRequirement()));
+
1 - 100 of 125 matches
Mail list logo
