[PATCH] D37954: Try to shorten system header paths when using -MD depfiles

Lekensteyn added a comment. ping? I'll push it next week if there is no new feedback. https://reviews.llvm.org/D37954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

This revision was automatically updated to reflect the committed changes. Closed by commit rL315668: [OpenCL] Add LangAS::opencl_private to represent private address space in AST (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D35082?vs=118813=118882#toc Repository:

r315668 - [OpenCL] Add LangAS::opencl_private to represent private address space in AST

Author: yaxunl Date: Thu Oct 12 20:37:48 2017 New Revision: 315668 URL: http://llvm.org/viewvc/llvm-project?rev=315668=rev Log: [OpenCL] Add LangAS::opencl_private to represent private address space in AST Currently Clang uses default address space (0) to represent private address space for

r315665 - [clang] Enable clang build with LLVM_BUILD_INSTRUMENTED without setting LLVM_PROFTDATA

Author: alexshap Date: Thu Oct 12 20:21:39 2017 New Revision: 315665 URL: http://llvm.org/viewvc/llvm-project?rev=315665=rev Log: [clang] Enable clang build with LLVM_BUILD_INSTRUMENTED without setting LLVM_PROFTDATA At the moment if LLVM_BUILD_INSTRUMENTED is set to True one has to set

[PATCH] D38859: [clang] Enable clang build with LLVM_BUILD_INSTRUMENTED without setting LLVM_PROFTDATA

This revision was automatically updated to reflect the committed changes. Closed by commit rL315665: [clang] Enable clang build with LLVM_BUILD_INSTRUMENTED without setting… (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D38859?vs=118869=118881#toc Repository: rL

[PATCH] D38773: [Sema] Add support for flexible array members in Obj-C.

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15055 } + // If it is the last field is checked elsewhere. } vsapsai wrote: > rjmccall wrote: > > "Whether" rather than "If", please. You should also leave a

r315662 - Support for destroying operator delete, per C++2a proposal P0722.

Author: rsmith Date: Thu Oct 12 18:55:36 2017 New Revision: 315662 URL: http://llvm.org/viewvc/llvm-project?rev=315662=rev Log: Support for destroying operator delete, per C++2a proposal P0722. This feature is not (yet) approved by the C++ committee, so this is liable to be reverted or

r315661 - Recommit r315087 "[refactor] add support for refactoring options"

Author: arphaman Date: Thu Oct 12 18:53:13 2017 New Revision: 315661 URL: http://llvm.org/viewvc/llvm-project?rev=315661=rev Log: Recommit r315087 "[refactor] add support for refactoring options" The recommit fixes a UB bug that occurred only on a small number of bots. Original message: This

[PATCH] D38861: [CodeGen] Error on unsupported checked multiplies early

vsk added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:2263 + } +} + joerg wrote: > vsk wrote: > > rjmccall wrote: > > > Is there a reason this only fails on x86? If LLVM doesn't have generic > > > wide-operation lowering, this probably

[PATCH] D38861: [CodeGen] Error on unsupported checked multiplies early

joerg added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:2263 + } +} + vsk wrote: > rjmccall wrote: > > Is there a reason this only fails on x86? If LLVM doesn't have generic > > wide-operation lowering, this probably needs to be a target

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

yaxunl added inline comments. Comment at: tools/libclang/CXType.cpp:402 + ASTContext = cxtu::getASTUnit(GetTU(CT))->getASTContext(); + return Ctx.getTargetAddressSpace(T); } arichardson wrote: > yaxunl wrote: > > Is this function suppose to return AST

[PATCH] D38773: [Sema] Add support for flexible array members in Obj-C.

vsapsai added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5226 +def err_objc_variable_sized_type_not_at_end : Error< + "field %0 with variable sized type %1 is not at the end of class">; +def note_next_field_declaration : Note<

Re: r298369 - [OpenCL] Added diagnostic for checking length of vector

On Thu, Oct 12, 2017 at 8:39 AM, Anastasia Stulova wrote: > > I think this bit is a bit confusing to us. Some of our original OpenCL > checks were removed in some places because in some cases OpenCL semantic was > adopted elsewhere. It's confusing indeed. We should

[PATCH] D38859: [clang] Enable clang build with LLVM_BUILD_INSTRUMENTED without setting LLVM_PROFTDATA

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks! Repository: rL LLVM https://reviews.llvm.org/D38859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38868: [OpenCL] Restrict swizzle length check to OpenCL mode

bruno created this revision. Herald added a subscriber: yaxunl. Change behavior introduced in r298369 and only error out on vector component invalid length access on OpenCL mode. https://reviews.llvm.org/D38868 Files: lib/Sema/SemaExprMember.cpp test/SemaOpenCL/vector_swizzle_length.cl

r315656 - [MS] Don't bail on replacing dllimport vbase dtors with base dtors

Author: rnk Date: Thu Oct 12 17:53:02 2017 New Revision: 315656 URL: http://llvm.org/viewvc/llvm-project?rev=315656=rev Log: [MS] Don't bail on replacing dllimport vbase dtors with base dtors Fix PR32990 by effectively reverting r283063 and solving it a different way. We want to limit the hack

r315655 - [Analyzer] Assume that CFBooleanRef const globals are non-null

Author: george.karpenkov Date: Thu Oct 12 17:51:41 2017 New Revision: 315655 URL: http://llvm.org/viewvc/llvm-project?rev=315655=rev Log: [Analyzer] Assume that CFBooleanRef const globals are non-null Differential Revision: https://reviews.llvm.org/D38867 Added:

[PATCH] D38859: [clang] Enable clang build with LLVM_BUILD_INSTRUMENTED without setting LLVM_PROFTDATA

alexshap updated this revision to Diff 118869. alexshap added a comment. Update the wording Repository: rL LLVM https://reviews.llvm.org/D38859 Files: utils/perf-training/CMakeLists.txt Index: utils/perf-training/CMakeLists.txt

[PATCH] D38859: [clang] Enable clang build with LLVM_BUILD_INSTRUMENTED without setting LLVM_PROFTDATA

alexshap updated this revision to Diff 118868. Repository: rL LLVM https://reviews.llvm.org/D38859 Files: utils/perf-training/CMakeLists.txt Index: utils/perf-training/CMakeLists.txt === --- utils/perf-training/CMakeLists.txt

r315652 - Typos in tutorial

Author: jkorous Date: Thu Oct 12 17:31:07 2017 New Revision: 315652 URL: http://llvm.org/viewvc/llvm-project?rev=315652=rev Log: Typos in tutorial Modified: cfe/trunk/www/hacking.html Modified: cfe/trunk/www/hacking.html URL:

[PATCH] D38859: [clang] Enable clang build with LLVM_BUILD_INSTRUMENTED without setting LLVM_PROFTDATA

vsk added a comment. In https://reviews.llvm.org/D38859#896517, @alexshap wrote: > yeah, i agree, this is not a good idea. My thoughts were different - right > now it's not particularly convenient that one has to specify LLVM_PROFDATA > when it's not actually used by the build. > Maybe we can

[PATCH] D38859: [clang] Enable clang build with LLVM_BUILD_INSTRUMENTED without setting LLVM_PROFTDATA

alexshap added a comment. yeah, i agree, this is not a good idea. My thoughts were different - right now it's not particularly convenient that one has to specify LLVM_PROFDATA when it's not actually used by the build. Maybe we can create the target "generate-profdata" only if LLVM_PROFDATA is

[PATCH] D38863: Typos in tutorial

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. You generally don't need a pre-commit review for such a change. https://reviews.llvm.org/D38863 ___ cfe-commits mailing list

[PATCH] D38859: [clang] Enable clang build with LLVM_BUILD_INSTRUMENTED without setting LLVM_PROFTDATA

vsk added a comment. llvm-profdata is tightly coupled with the host compiler: while this setup may work if you get lucky, I don't think it's resilient to changes in libProfData. Also, using the instrumented llvm-profdata will be slow and create extra profiles. As an alternative, have you

r315643 - Handle/assert on DK_Remark

Author: anemet Date: Thu Oct 12 16:56:54 2017 New Revision: 315643 URL: http://llvm.org/viewvc/llvm-project?rev=315643=rev Log: Handle/assert on DK_Remark We don't generate remarks during inline assembly parsing so no need to handle these for now. Modified:

Re: [PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

On 12 October 2017 at 15:41, Roman Lebedev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri, Oct 13, 2017 at 1:22 AM, Richard Smith > wrote: > > On 12 October 2017 at 15:11, Roman Lebedev via Phabricator via > cfe-commits > >

r315639 - [Sema][ObjC] Complete merging ObjC methods before checking their

Author: ahatanak Date: Thu Oct 12 16:24:38 2017 New Revision: 315639 URL: http://llvm.org/viewvc/llvm-project?rev=315639=rev Log: [Sema][ObjC] Complete merging ObjC methods before checking their overriding methods. This should fix test case Analysis/retain-release.m that was failing on the

[PATCH] D38861: [CodeGen] Error on unsupported checked multiplies early

vsk added a comment. In https://reviews.llvm.org/D38861#896435, @rjmccall wrote: > Okay. Sounds good to me. > > We intend to actually implement the generic lowering, I hope? Yes, I'll make a note of that in PR34920, and am tracking the bug internally in rdar://problem/34963321.

[PATCH] D38700: [Sema][Crash] Correctly handle an non-dependent noexcept expr in function template

This revision was automatically updated to reflect the committed changes. Closed by commit rL315638: [Sema][Crash] Correctly handle an non-dependent noexcept expr in function… (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D38700?vs=118245=118858#toc Repository:

[PATCH] D38861: [CodeGen] Error on unsupported checked multiplies early

rjmccall added a comment. Okay. Sounds good to me. We intend to actually implement the generic lowering, I hope? https://reviews.llvm.org/D38861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r315638 - [Sema][Crash] Correctly handle an non-dependent noexcept expr in function template

Author: erichkeane Date: Thu Oct 12 16:01:53 2017 New Revision: 315638 URL: http://llvm.org/viewvc/llvm-project?rev=315638=rev Log: [Sema][Crash] Correctly handle an non-dependent noexcept expr in function template It seems that all of the other templated cases are handled correctly, however

[PATCH] D38861: [CodeGen] Error on unsupported checked multiplies early

vsk added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:2263 + } +} + rjmccall wrote: > Is there a reason this only fails on x86? If LLVM doesn't have generic > wide-operation lowering, this probably needs to be a target whitelist rather >

[PATCH] D38861: [CodeGen] Error on unsupported checked multiplies early

vsk updated this revision to Diff 118857. vsk added a comment. Herald added a subscriber: aheejin. - Update to check against a whitelist of supported targets. https://reviews.llvm.org/D38861 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins-overflow-unsupported.c

[PATCH] D38863: Typos in tutorial

jkorous-apple created this revision. https://reviews.llvm.org/D38863 Files: www/hacking.html Index: www/hacking.html === --- www/hacking.html +++ www/hacking.html @@ -246,9 +246,9 @@ For example: - python

[PATCH] D38773: [Sema] Add support for flexible array members in Obj-C.

rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5226 +def err_objc_variable_sized_type_not_at_end : Error< + "field %0 with variable sized type %1 is not at the end of class">; +def note_next_field_declaration : Note<

Re: [PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

On Fri, Oct 13, 2017 at 1:22 AM, Richard Smith wrote: > On 12 October 2017 at 15:11, Roman Lebedev via Phabricator via cfe-commits > wrote: >> >> lebedev.ri reopened this revision. >> lebedev.ri added a comment. >> This revision is now accepted

[PATCH] D38794: [CodeGen] getNaturalTypeAlignment() to generate TBAA info along with LValue base info

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This function feels increasingly poorly-named, but let's leave that alone for now. Repository: rL LLVM https://reviews.llvm.org/D38794

[PATCH] D38796: [CodeGen] EmitPointerWithAlignment() to generate TBAA info along with LValue base info

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Yes, thank for you handling the cast case well. Repository: rL LLVM https://reviews.llvm.org/D38796 ___ cfe-commits mailing list

[PATCH] D38795: [CodeGen] emitOMPArraySectionBase() to generate TBAA info along with LValue base info

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D38795 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38793: [CodeGen] EmitLoadOfReference() to generate TBAA info along with LValue base info

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D38793 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38791: [CodeGen] EmitLoadOfPointer() to generate TBAA info along with LValue base info

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D38791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38788: [CodeGen] EmitCXXMemberDataPointerAddress() to generate TBAA info along with LValue base info

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D38788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38861: [CodeGen] Error on unsupported checked multiplies early

rjmccall added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:2263 + } +} + Is there a reason this only fails on x86? If LLVM doesn't have generic wide-operation lowering, this probably needs to be a target whitelist rather than a blacklist.

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

arichardson planned changes to this revision. arichardson added inline comments. Comment at: include/clang/Basic/AddressSpaces.h:66 +inline LangAS LangASFromTargetAS(unsigned TargetAS) { + return static_cast((TargetAS) + yaxunl wrote: > how about

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

rjmccall added a comment. A few minor comments; feel free to commit after addressing them. Comment at: include/clang/Basic/AddressSpaces.h:34 // OpenCL specific address spaces. opencl_global, yaxunl wrote: > rjmccall wrote: > > I think you need a real

[PATCH] D38861: [CodeGen] Error on unsupported checked multiplies early

vsk created this revision. LLVM's smul.with.overflow intrinsic isn't supported on X86 for bit widths larger than 64, or on X86-64 for bit widths larger than 128. The failure mode is either a linker error ("the __muloti4 builtin isn't available for this target") or an assertion failure

Re: [PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

On 12 October 2017 at 15:11, Roman Lebedev via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > lebedev.ri reopened this revision. > lebedev.ri added a comment. > This revision is now accepted and ready to land. > > Reverted due to http://bb9.pgr.jp/#/builders/20/builds/59 that

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

lebedev.ri reopened this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Reverted due to http://bb9.pgr.jp/#/builders/20/builds/59 that i don't currently know how to deal with. It is really sad that i failed to encounter it during testing. Repository:

[PATCH] D38700: [Sema][Crash] Correctly handle an non-dependent noexcept expr in function template

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good, thanks! https://reviews.llvm.org/D38700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r315631 - Revert "[Sema] Diagnose tautological comparison with type's min/max values"

Author: lebedevri Date: Thu Oct 12 15:03:20 2017 New Revision: 315631 URL: http://llvm.org/viewvc/llvm-project?rev=315631=rev Log: Revert "[Sema] Diagnose tautological comparison with type's min/max values" This reverts r315614,r315615,r315621,r315622 Breaks

r315630 - [cmake] Rename LIB_FUZZING_ENGINE to LLVM_LIB_FUZZING_ENGINE.

Author: morehouse Date: Thu Oct 12 15:00:09 2017 New Revision: 315630 URL: http://llvm.org/viewvc/llvm-project?rev=315630=rev Log: [cmake] Rename LIB_FUZZING_ENGINE to LLVM_LIB_FUZZING_ENGINE. Modified: cfe/trunk/tools/clang-format/CMakeLists.txt

r315627 - [lit] Raise the logic for enabling clang & lld substitutions to llvm.

Author: zturner Date: Thu Oct 12 14:56:05 2017 New Revision: 315627 URL: http://llvm.org/viewvc/llvm-project?rev=315627=rev Log: [lit] Raise the logic for enabling clang & lld substitutions to llvm. This paves the way for other projects which might /use/ clang or lld but not necessarily need to

Re: r315614 - [Sema] Diagnose tautological comparison with type's min/max values

On Fri, Oct 13, 2017 at 12:12 AM, Nico Weber wrote: > Huh, I consider clang not warning on this a feature, not a bug. Why are we > trying to match what gcc does here? Because i have been bitten by this more than once. It did result in big amount of wasted time, and this

[PATCH] D38742: [CUDA] Added __hmma_m16n16k16_* builtins to support mma instructions in sm_70

This revision was automatically updated to reflect the committed changes. Closed by commit rL315624: [CUDA] Added __hmma_m16n16k16_* builtins to support mma instructions on sm_70 (authored by tra). Changed prior to commit: https://reviews.llvm.org/D38742?vs=118636=118848#toc Repository: rL

r315624 - [CUDA] Added __hmma_m16n16k16_* builtins to support mma instructions on sm_70

Author: tra Date: Thu Oct 12 14:32:19 2017 New Revision: 315624 URL: http://llvm.org/viewvc/llvm-project?rev=315624=rev Log: [CUDA] Added __hmma_m16n16k16_* builtins to support mma instructions on sm_70 Differential Revision: https://reviews.llvm.org/D38742 Added:

r315622 - [Analysis] Un-silence -Wtautological-unsigned-zero-compare in null-deref-ps.c

Author: lebedevri Date: Thu Oct 12 14:15:26 2017 New Revision: 315622 URL: http://llvm.org/viewvc/llvm-project?rev=315622=rev Log: [Analysis] Un-silence -Wtautological-unsigned-zero-compare in null-deref-ps.c Stage-2 builds failed: error: 'warning' diagnostics expected but not seen: File

Re: r315614 - [Sema] Diagnose tautological comparison with type's min/max values

Huh, I consider clang not warning on this a feature, not a bug. Why are we trying to match what gcc does here? Say you have code like this: int64_t aligned_start = 0; int64_t aligned_size = 0; CalculateVMAlignedBoundaries(region.offset, region.size,

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mstorsjo added a comment. This one can be abandoned now. https://reviews.llvm.org/D36111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r315621 - [SemaChecking] Suppress a GCC warning. NFCI.

Author: davide Date: Thu Oct 12 14:08:29 2017 New Revision: 315621 URL: http://llvm.org/viewvc/llvm-project?rev=315621=rev Log: [SemaChecking] Suppress a GCC warning. NFCI. Modified: cfe/trunk/lib/Sema/SemaChecking.cpp Modified: cfe/trunk/lib/Sema/SemaChecking.cpp URL:

[PATCH] D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size

rnk accepted this revision. rnk added a comment. lgtm Comment at: src/libunwind.cpp:188 + co->getInfo(); + pint_t orgArgSize = (pint_t)info.gp; + uint64_t orgFuncStart = info.start_ip; mstorsjo wrote: > rnk wrote: > > I think it makes sense to

[PATCH] D38840: [compiler-rt] [cmake] [asan] Remove unnecessary gtest dep from dynamic tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL315620: [cmake] [asan] Remove unnecessary gtest dep from dynamic tests (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D38840?vs=118826=118842#toc Repository: rL LLVM

[PATCH] D38425: [clangd] Document highlights for clangd

Nebiroth updated this revision to Diff 118838. Nebiroth marked an inline comment as done. Nebiroth added a comment. Addressed review comments. Fixed some tests not having updated providers. Removed TargetDeclarationFinder for less code reuse. DocumentHighlight struct is now unparsed correctly.

r315615 - [Analysis] Silence -Wtautological-constant-compare in two tests

Author: lebedevri Date: Thu Oct 12 13:27:41 2017 New Revision: 315615 URL: http://llvm.org/viewvc/llvm-project?rev=315615=rev Log: [Analysis] Silence -Wtautological-constant-compare in two tests Yes, did not check that. Need to do better :( I do not believe it makes sense to do expect that

[PATCH] D38840: [compiler-rt] [cmake] [asan] Remove unnecessary gtest dep from dynamic tests

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. LGTM, provided tests pass both in standalone and "normal" modes. https://reviews.llvm.org/D38840 ___ cfe-commits mailing

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

yaxunl added inline comments. Comment at: include/clang/Basic/AddressSpaces.h:66 +inline LangAS LangASFromTargetAS(unsigned TargetAS) { + return static_cast((TargetAS) + how about `getLangASFromTargetAS` ? It is preferred to start with small letters.

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

This revision was automatically updated to reflect the committed changes. Closed by commit rL315614: [Sema] Diagnose tautological comparison with type's min/max values (authored by lebedevri). Changed prior to commit: https://reviews.llvm.org/D38101?vs=118833=118835#toc Repository: rL LLVM

r315614 - [Sema] Diagnose tautological comparison with type's min/max values

Author: lebedevri Date: Thu Oct 12 13:16:51 2017 New Revision: 315614 URL: http://llvm.org/viewvc/llvm-project?rev=315614=rev Log: [Sema] Diagnose tautological comparison with type's min/max values Summary: Currently, clang only diagnoses completely out-of-range comparisons (e.g. `char` and

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

lebedev.ri updated this revision to Diff 118833. lebedev.ri added a comment. Getting really weird problems when trying to use arc patch, maybe re-updating the differential helps Repository: rL LLVM https://reviews.llvm.org/D38101 Files: docs/ReleaseNotes.rst

r315611 - [OPENMP] Fix PR34927: Emit initializer for reduction array with declare

Author: abataev Date: Thu Oct 12 13:03:39 2017 New Revision: 315611 URL: http://llvm.org/viewvc/llvm-project?rev=315611=rev Log: [OPENMP] Fix PR34927: Emit initializer for reduction array with declare reduction. If the reduction is an array or an array section and reduction operation is declare

[PATCH] D38859: [clang] Enable clang build with LLVM_BUILD_INSTRUMENTED without setting LLVM_PROFTDATA

alexshap created this revision. Herald added a subscriber: mgorny. At the moment if LLVM_BUILD_INSTRUMENTED is set to True one has to set LLVM_PROFTDATA even if it's not necessary (because of message(FATAL_ERROR ...)). Building instrumented Clang is useful even if one doesn't plan to use the

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

lebedev.ri added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8930 +// We only care about expressions where just one side is literal +if (IsRHSIntegralLiteral ^ IsLHSIntegralLiteral) { + // Is the constant on the RHS or LHS? rsmith wrote:

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

lebedev.ri updated this revision to Diff 118829. lebedev.ri marked an inline comment as done. Repository: rL LLVM https://reviews.llvm.org/D38101 Files: docs/ReleaseNotes.rst include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp

[PATCH] D38840: [compiler-rt] [cmake] [asan] Remove unnecessary gtest dep from dynamic tests

mgorny updated this revision to Diff 118826. mgorny retitled this revision from "[compiler-rt] [cmake] [asan] Reuse generate_asan_tests for dynamic tests" to "[compiler-rt] [cmake] [asan] Remove unnecessary gtest dep from dynamic tests". mgorny edited the summary of this revision. mgorny added a

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, this looks great. Comment at: lib/Sema/SemaChecking.cpp:8940 + } else if (!T->hasUnsignedIntegerRepresentation()) +IsComparisonConstant =

r315607 - [X86] Add CLWB intrinsic. clang part

Author: ctopper Date: Thu Oct 12 11:57:15 2017 New Revision: 315607 URL: http://llvm.org/viewvc/llvm-project?rev=315607=rev Log: [X86] Add CLWB intrinsic. clang part Reviewers: RKSimon, zvi, igorb Reviewed By: RKSimon Subscribers: cfe-commits Differential Revision:

[PATCH] D38781: [X86] Add CLWB intrinsic. clang part

This revision was automatically updated to reflect the committed changes. Closed by commit rL315607: [X86] Add CLWB intrinsic. clang part (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D38781?vs=118816=118822#toc Repository: rL LLVM https://reviews.llvm.org/D38781

[PATCH] D38839: [compiler-rt] [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS

This revision was automatically updated to reflect the committed changes. Closed by commit rL315605: [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D38839?vs=118754=118821#toc Repository: rL LLVM

[PATCH] D38838: [compiler-rt] [cmake] Fix skipping DEPS (typo) in sanitizer_test_compile()

This revision was automatically updated to reflect the committed changes. Closed by commit rL315604: [cmake] Fix skipping DEPS (typo) in sanitizer_test_compile() (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D38838?vs=118752=118820#toc Repository: rL LLVM

[PATCH] D38857: [OpenCL] Improve printing and semantic check related to implicit addr space

yaxunl created this revision. There are two issues: 1. only (void*)0 should be treated as nullptr 2. only explicit addr space should be printed This patch introduces a flag in Qualifier to indicating a non-default address space qualifier is deduced by context. Only non-implicit address space

[PATCH] D38781: [X86] Add CLWB intrinsic. clang part

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - one minor Comment at: lib/Headers/clwbintrin.h:42 +/// +/// \param __p +///A pointer to the memory location used to identify the cache line to be

[PATCH] D38853: [clang-format] Allow building fuzzer with OSS-Fuzz flags.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315603: [clang-format] Allow building fuzzer with OSS-Fuzz flags. (authored by morehouse). Changed prior to commit: https://reviews.llvm.org/D38853?vs=118805=118819#toc Repository: rL LLVM

r315603 - [clang-format] Allow building fuzzer with OSS-Fuzz flags.

Author: morehouse Date: Thu Oct 12 11:39:10 2017 New Revision: 315603 URL: http://llvm.org/viewvc/llvm-project?rev=315603=rev Log: [clang-format] Allow building fuzzer with OSS-Fuzz flags. Reviewers: kcc, bogner Reviewed By: kcc Subscribers: cfe-commits, mgorny Differential Revision:

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

yaxunl updated this revision to Diff 118813. yaxunl marked 7 inline comments as done. yaxunl edited the summary of this revision. yaxunl added a comment. Separate implicit addr space flag to another patch as John suggested. This patch only introduces the private addr space but does not print it.

[PATCH] D38781: [X86] Add CLWB intrinsic. clang part

craig.topper updated this revision to Diff 118816. craig.topper added a comment. Address review feedback https://reviews.llvm.org/D38781 Files: include/clang/Basic/BuiltinsX86.def lib/Headers/CMakeLists.txt lib/Headers/clwbintrin.h lib/Headers/immintrin.h test/CodeGen/builtin-clwb.c

[PATCH] D38853: [clang-format] Allow building fuzzer with OSS-Fuzz flags.

kcc added a reviewer: bogner. kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM +Justin FYI Please also take a look at llvm-isel-fuzzer, which I've just added to oss-fuzz https://reviews.llvm.org/D38853

[PATCH] D38853: [clang-format] Allow building fuzzer with OSS-Fuzz flags.

morehouse created this revision. Herald added a subscriber: mgorny. https://reviews.llvm.org/D38853 Files: clang/tools/clang-format/CMakeLists.txt clang/tools/clang-format/fuzzer/CMakeLists.txt Index: clang/tools/clang-format/fuzzer/CMakeLists.txt

r315594 - [X86] Use -ffreestanding instead of using the mm_malloc.h include guard hack on more of the builtin tests.

Author: ctopper Date: Thu Oct 12 10:21:01 2017 New Revision: 315594 URL: http://llvm.org/viewvc/llvm-project?rev=315594=rev Log: [X86] Use -ffreestanding instead of using the mm_malloc.h include guard hack on more of the builtin tests. Modified: cfe/trunk/test/CodeGen/adc-builtins.c

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. @arichardson, great work! Thanks a lot! https://reviews.llvm.org/D38816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38840: [compiler-rt] [cmake] [asan] Reuse generate_asan_tests for dynamic tests

george.karpenkov requested changes to this revision. george.karpenkov added a comment. This revision now requires changes to proceed. @mgorny so this one actually changes semantics. The previous one reused generated object files, and with the change it will start recompiling all the tests again.

[PATCH] D38838: [compiler-rt] [cmake] Fix skipping DEPS (typo) in sanitizer_test_compile()

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. Yep, thanks! Good to go provided tests run. Looks like we haven't spotted it due to other bug you have fixed cancelling this one out. https://reviews.llvm.org/D38838

[PATCH] D38839: [compiler-rt] [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. Yep, thanks! This was probably the root cause of the failure. https://reviews.llvm.org/D38839 ___ cfe-commits mailing list

Re: [PATCH] D38464: [clangd] less boilerplate in RPC dispatch

I mention it only out of interest of deduplication of functionality/code within the LLVM project as a whole. Be nice not to maintain two things if one would suffice. On Thu, Oct 12, 2017 at 6:21 AM Sam McCall wrote: > Interesting - this is pretty primitive, and still

[PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM Comment at: include/clang/Frontend/CodeGenOptions.def:182 CODEGENOPT(SoftFloat , 1, 0) ///< -soft-float. +CODEGENOPT(FineGrainedBitfieldAccesses, 1, 0) ///<

[PATCH] D38852: [Hexagon] Handling of new HVX flags and target-features

sgundapa created this revision. Herald added a subscriber: eraman. This patch has the following changes 1. A new flag "-mhvx-length={64B|128B}" is introduced to specify the length of the vector. Previously we have used "-mhvx-double" for 128 Bytes. This adds the target-feature

[PATCH] D37897: [StaticAnalyzer] Fix ProgramState for static variables that are not written

danielmarjamaki added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:123 + // Is variable changed anywhere in TU? + for (const Decl *D : AMgr.getASTContext().getTranslationUnitDecl()->decls()) { +if (isChanged(D, VD)) danielmarjamaki

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

arichardson added inline comments. Comment at: lib/AST/TypePrinter.cpp:1323 OS << "address_space("; -OS << T->getEquivalentType().getAddressSpace(); +OS << T->getEquivalentType() + .getQualifiers() Anastasia wrote: > Why do we need this

[PATCH] D38700: [Sema][Crash] Correctly handle an non-dependent noexcept expr in function template

erichkeane added a comment. Bump! I realize the two of you are super busy, but if anyone else on cfe-commits wants to take a look, I'd apprecate it! -Erich https://reviews.llvm.org/D38700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38781: [X86] Add CLWB intrinsic. clang part

RKSimon added inline comments. Comment at: lib/Headers/clwbintrin.h:34 + +static __inline__ void __DEFAULT_FN_ATTRS +_mm_clwb(void const *__m) { Worth adding the doxygen description? You can probably just copy+paste+modify the _mm_clflush documentation.

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

lebedev.ri added a comment. In https://reviews.llvm.org/D36836#889375, @aaron.ballman wrote: > Adding @dberlin for licensing discussion questions. Ping. Yes, i agree that what i have added is not a directory, and not a proper license. That is more of a template to hopefully stat moving

[PATCH] D37897: [StaticAnalyzer] Fix ProgramState for static variables that are not written

danielmarjamaki added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:123 + // Is variable changed anywhere in TU? + for (const Decl *D : AMgr.getASTContext().getTranslationUnitDecl()->decls()) { +if (isChanged(D, VD)) dcoughlin wrote:

  1   2   >