[libcxx] r318622 - Fix min/max usage in variant

Author: ericwf Date: Sat Nov 18 20:57:22 2017 New Revision: 318622 URL: http://llvm.org/viewvc/llvm-project?rev=318622&view=rev Log: Fix min/max usage in variant Modified: libcxx/trunk/include/variant Modified: libcxx/trunk/include/variant URL: http://llvm.org/viewvc/llvm-project/libcxx/tru

[libcxx] r318621 - [libc++] Shrink variant's index type when possible

Author: ericwf Date: Sat Nov 18 20:19:44 2017 New Revision: 318621 URL: http://llvm.org/viewvc/llvm-project?rev=318621&view=rev Log: [libc++] Shrink variant's index type when possible Summary: Currently `std::variant` always uses an unsigned int to store the variant index. However this isn't nes

r318620 - [X86] Make sure 'knm' is accepted by -target-cpu

Author: ctopper Date: Sat Nov 18 20:12:35 2017 New Revision: 318620 URL: http://llvm.org/viewvc/llvm-project?rev=318620&view=rev Log: [X86] Make sure 'knm' is accepted by -target-cpu Modified: cfe/trunk/test/Frontend/x86-target-cpu.c Modified: cfe/trunk/test/Frontend/x86-target-cpu.c URL: h

r318619 - [X86] Make sure 'knm' and 'cannonlake' are accepted by builtin_cpu_is

Author: ctopper Date: Sat Nov 18 20:12:33 2017 New Revision: 318619 URL: http://llvm.org/viewvc/llvm-project?rev=318619&view=rev Log: [X86] Make sure 'knm' and 'cannonlake' are accepted by builtin_cpu_is Modified: cfe/trunk/test/CodeGen/target-builtin-noerror.c Modified: cfe/trunk/test/CodeG

[libcxx] r318618 - Fix nodiscard test when modules are enabled

Author: ericwf Date: Sat Nov 18 19:50:35 2017 New Revision: 318618 URL: http://llvm.org/viewvc/llvm-project?rev=318618&view=rev Log: Fix nodiscard test when modules are enabled Modified: libcxx/trunk/test/libcxx/diagnostics/nodiscard.pass.cpp Modified: libcxx/trunk/test/libcxx/diagnostics/no

[PATCH] D40210: [libc++] Shrink variant's index type when possible

EricWF updated this revision to Diff 123492. EricWF added a comment. - Address inline comments. https://reviews.llvm.org/D40210 Files: include/__config include/variant test/libcxx/utilities/variant/variant.variant/variant_size.pass.cpp Index: test/libcxx/utilities/variant/variant.variant

[PATCH] D40210: [libc++] Shrink variant's index type when possible

EricWF marked 4 inline comments as done. EricWF added inline comments. Comment at: include/variant:300-303 + std::tuple_element_t< + __choose_index_type(_NumElem), + std::tuple + >; mpark wrote: > Could we inline the whole thing and also avoid using t

[PATCH] D40210: [libc++] Shrink variant's index type when possible

mpark added inline comments. Comment at: include/variant:295 + +template +using __variant_index_t = `s/_NumElem/_NumAlts/` Comment at: include/variant:300-303 + std::tuple_element_t< + __choose_index_type(_NumElem), + std::tuple +

[PATCH] D40221: [clang-format] Parse blocks in braced lists

strager created this revision. Herald added a subscriber: klimek. clang-format completely ruins the formatting of block literal expressions which appear inside inside braced initializer lists. For example: int main() { foo({ ^() { return nil; } });

[PATCH] D38824: [X86] Synchronize the existing CPU predefined macros with the cases that gcc defines them

craig.topper abandoned this revision. craig.topper added a comment. All skylake-avx512 and cannonlake now set __corei7__ as of r318616. Abandoning this. https://reviews.llvm.org/D38824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

r318616 - [X86] Set __corei7__ preprocessor defines for skylake server and cannonlake.

Author: ctopper Date: Sat Nov 18 18:55:14 2017 New Revision: 318616 URL: http://llvm.org/viewvc/llvm-project?rev=318616&view=rev Log: [X86] Set __corei7__ preprocessor defines for skylake server and cannonlake. This is the resolution we came to in D38824. Modified: cfe/trunk/lib/Basic/Target

r318617 - [X86] Add icelake CPU support for -march.

Author: ctopper Date: Sat Nov 18 18:55:15 2017 New Revision: 318617 URL: http://llvm.org/viewvc/llvm-project?rev=318617&view=rev Log: [X86] Add icelake CPU support for -march. Modified: cfe/trunk/include/clang/Basic/X86Target.def cfe/trunk/lib/Basic/Targets/X86.cpp cfe/trunk/test/Driv

[PATCH] D40115: Driver: remove `SupportsObjCGC`

compnerd closed this revision. compnerd added a comment. SVN r318609 Repository: rL LLVM https://reviews.llvm.org/D40115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40127: [Driver][ARM] For assembler files recognize -Xassembler or -Wa, -mthumb

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Would be nice to rename the variable prior to commit. Comment at: lib/Driver/ToolChain.cpp:549-556 +bool IsIntegratedAssemblerThumb = false; +for (const Arg *A :

[PATCH] D39930: [CMake] Use libc++ and compiler-rt as default libraries in Fuchsia toolchain

phosek added a comment. This is something I was already thinking about. Ideally, in our toolchain, we would build runtimes for all host and target platforms we support, i.e. on every host (Linux, macOS and Windows) we would build runtimes for i386, x86_64 and aarch64 Linux, x86_64 macOS, x86_64

[PATCH] D40073: [Analyzer] Non-determinism: don't sort indirect goto LabelDecl's by addresses

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Thanks for finding and fixing this! This looks good, but since the nondeterminism is in CFG construction, I think it makes sense to create and dump the CFG rather than running the whole

r318609 - Driver: remove `SupportsObjCGC` (NFC)

Author: compnerd Date: Sat Nov 18 16:45:33 2017 New Revision: 318609 URL: http://llvm.org/viewvc/llvm-project?rev=318609&view=rev Log: Driver: remove `SupportsObjCGC` (NFC) This option is not used in the frontend. Remove the method. Modified: cfe/trunk/include/clang/Driver/ToolChain.h c

[PATCH] D39588: Distro: initial support for alpine

This revision was automatically updated to reflect the committed changes. Closed by commit rL318608: [Driver] add initial support for alpine linux (authored by martell). Changed prior to commit: https://reviews.llvm.org/D39588?vs=121462&id=123488#toc Repository: rL LLVM https://reviews.llvm

r318608 - [Driver] add initial support for alpine linux

Author: martell Date: Sat Nov 18 16:08:12 2017 New Revision: 318608 URL: http://llvm.org/viewvc/llvm-project?rev=318608&view=rev Log: [Driver] add initial support for alpine linux set -pie as default for musl linux targets add detection of alpine linux append appropriate compile flags for alpine

[PATCH] D40217: [LIT] Fix testing out-of-tree Clang builds

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Accepting for post-commit review. I don't want to be carrying this patch locally. https://reviews.llvm.org/D40217 ___ cfe-commits mailing list c

[PATCH] D40144: Implement `std::launder`

EricWF added a comment. I've made an attempt to add `__builtin_launder` to clang in D40218 . https://reviews.llvm.org/D40144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D37187: [Analyzer] Fix Bug 25609 - Assertion UNREACHABLE: 'Unexpected ProgramPoint' with widen-loops=true

dcoughlin added inline comments. Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:694 + } else if (Optional BE = P.getAs()) { +CFGElement BlockFront = BE->getBlock()->front(); +if (BlockFront.getKind() == CFGElement::Statement) { MTC wrote: > szepe

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

martell requested review of this revision. martell added a comment. Thanks for the review @rnk . I addressed the comment nit you had. @mstorsjo I updated this to also handle thumb on arm. When doing that I noticed there is something really strange about the existing macro defines. I assume they

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

martell updated this revision to Diff 123486. martell added a comment. Herald added subscribers: JDevlieghere, javed.absar. updated to handle dwarf exceptions on arm. Repository: rL LLVM https://reviews.llvm.org/D39673 Files: docs/ClangCommandLineReference.rst include/clang/Basic/LangOpt

[PATCH] D40217: [LIT] Fix testing out-of-tree Clang builds

EricWF updated this revision to Diff 123485. EricWF added a comment. - Use style suggested by @mgorny. https://reviews.llvm.org/D40217 Files: utils/lit/lit/llvm/config.py Index: utils/lit/lit/llvm/config.py === --- utils/lit/li

[PATCH] D39937: [Sema] Improve diagnostics for const- and ref-qualified member functions

aaron.ballman added a comment. In https://reviews.llvm.org/D39937#929514, @jtbandes wrote: > Thanks, will do. Is there an automated system that can run all the tests > //before// I merge rather than waiting for a potential build failure after > the fact? You can run the tests locally using ll

[PATCH] D40218: [Clang] Add __builtin_launder

EricWF updated this revision to Diff 123484. EricWF added a comment. - Remove incorrect FIXME comment. https://reviews.llvm.org/D40218 Files: include/clang/Basic/Builtins.def include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CGBuiltin.cpp lib/Sema/SemaChecking.cpp test/CodeGen/bu

[PATCH] D40218: [Clang] Add __builtin_launder

EricWF created this revision. Herald added a subscriber: Prazek. This patch adds `__builtin_launder`, which is required to implement `std::launder`. Additionally GCC provides `__builtin_launder`, so thing brings Clang in-line with GCC. I'm not exactly sure what magic `__builtin_launder` require

[PATCH] D39937: [Sema] Improve diagnostics for const- and ref-qualified member functions

jtbandes added a comment. Thanks, will do. Is there an automated system that can run all the tests //before// I merge rather than waiting for a potential build failure after the fact? https://reviews.llvm.org/D39937 ___ cfe-commits mailing list cf

[PATCH] D39937: [Sema] Improve diagnostics for const- and ref-qualified member functions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM, but you should wait for a few days before committing in case @rsmith has comments. https://reviews.llvm.org/D39937 ___

[PATCH] D40217: [LIT] Fix testing out-of-tree Clang builds

mgorny added a comment. Or even more abstract (if we assume we don't have to check for presence of `llvm_tools_dir`): path_vars = ['clang_tools_dir', 'llvm_tools_dir'] paths = [getattr(self.config, k) for k in path_vars if hasattr(self.config, k)] (untested) https://reviews.llvm.org/D402

[PATCH] D40217: [LIT] Fix testing out-of-tree Clang builds

mgorny added a comment. To be honest, as I said before, I'm entirely confused by the logic there, with all the prepending, appending and shuffling around. But if you believe it gives the correct result, I'm all for it. However, if that wouldn't be too much of a hassle, would you mind also renam

Re: [PATCH] D40217: [LIT] Fix testing out-of-tree Clang builds

+mgorny On Sat, Nov 18, 2017 at 2:24 PM Eric Fiselier via Phabricator < revi...@reviews.llvm.org> wrote: > EricWF created this revision. > Herald added a reviewer: modocache. > > Currently, LIT configures the LLVM binary path before the Clang binary > path. However this breaks testing out-of-tree

[PATCH] D39937: [Sema] Improve diagnostics for const- and ref-qualified member functions

jtbandes updated this revision to Diff 123481. jtbandes added a comment. - spell out full diagnostic the first time https://reviews.llvm.org/D39937 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaOverload.cpp test/CXX/over/over.match/over.match.funcs/p4-0x.cpp test/SemaCX

[PATCH] D39937: [Sema] Improve diagnostics for const- and ref-qualified member functions

aaron.ballman added inline comments. Comment at: test/CXX/over/over.match/over.match.funcs/p4-0x.cpp:85 +void test_diagnostics(const volatile X0 &__restrict__ cvr) { + cvr.g(); // expected-error {{not marked const or volatile}} + cvr.c(); // expected-error {{not marked volatile

[PATCH] D40217: [LIT] Fix testing out-of-tree Clang builds

EricWF created this revision. Herald added a reviewer: modocache. Currently, LIT configures the LLVM binary path before the Clang binary path. However this breaks testing out-of-tree Clang builds (where the LLVM binary path includes a copy of Clang). This patch reverses the order of the paths w

[PATCH] D39937: [Sema] Improve diagnostics for const- and ref-qualified member functions

jtbandes updated this revision to Diff 123476. jtbandes added a comment. - feedback from review & more tests https://reviews.llvm.org/D39937 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaOverload.cpp test/CXX/over/over.match/over.match.funcs/p4-0x.cpp test/SemaCXX/copy-

[PATCH] D39027: [docs][refactor] Add a new tutorial that talks about how one can implement refactoring actions

JonasToth added inline comments. Comment at: docs/RefactoringActionTutorial.rst:236 + class NestedIfSelectionRequirement final + : final CodeRangeSelectionRequirement { + public: i think the `final` after the colon should be `public` instead.

[PATCH] D39505: [OpenMP] Show error if VLAs are not supported

This revision was automatically updated to reflect the committed changes. Hahnfeld marked an inline comment as done. Closed by commit rL318601: [OpenMP] Show error if VLAs are not supported (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D39505?vs=123364&id=123473#toc

r318601 - [OpenMP] Show error if VLAs are not supported

Author: hahnfeld Date: Sat Nov 18 13:00:46 2017 New Revision: 318601 URL: http://llvm.org/viewvc/llvm-project?rev=318601&view=rev Log: [OpenMP] Show error if VLAs are not supported Some target devices (e.g. Nvidia GPUs) don't support dynamic stack allocation and hence no VLAs. Print errors with d

[PATCH] D40210: [libc++] Shrink varient's index type when possible

EricWF created this revision. Currently `std::variant` always uses an unsigned int to store the variant index. However this isn't nessesary and causes `std::variant` to be larger than it needs to be in most cases. This patch changes the index type to be `unsigned char` when possible, and `unsi

[PATCH] D40144: Implement `std::launder`

EricWF added a comment. I think we may want a `__launder` function that we can use internally in all dialects. Comment at: include/__config:458 +#if __has_builtin(__builtin_launder) +#define_LIBCPP_COMPILER_HAS_BUILTIN_LAUNDER +#endif These macros shou

[PATCH] D39937: [Sema] Improve diagnostics for const- and ref-qualified member functions

lebedev.ri added inline comments. Comment at: test/CXX/over/over.match/over.match.funcs/p4-0x.cpp:22-24 + void lvalue() &; // expected-note 2 {{'lvalue' declared here}} + void const_lvalue() const&; + void rvalue() &&; // expected-note {{'rvalue' declared here}} --

Re: r318556 - Loosen -Wempty-body warning

We're still seeing some in macro-related code. From Chromium: ../../third_party/ffmpeg/libavcodec/bitstream.c(169,5): error: if statement has empty body [-Werror,-Wempty-body] ff_dlog(NULL, "new table index=%d size=%d\n", table_index, table_size); ^ ../../third_party/ffmpeg\libavutil/inte

[PATCH] D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches

This revision was automatically updated to reflect the committed changes. Closed by commit rL318600: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches (authored by JonasToth). Repository: rL LLVM https://reviews.llvm.org/D37808 Files: clang-tools-extra/trunk/clang

[clang-tools-extra] r318600 - [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches

Author: jonastoth Date: Sat Nov 18 11:48:33 2017 New Revision: 318600 URL: http://llvm.org/viewvc/llvm-project?rev=318600&view=rev Log: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches Summary: This check searches for missing `else` branches in `if-else if`-chains and

[PATCH] D39937: [Sema] Improve diagnostics for const- and ref-qualified member functions

aaron.ballman added inline comments. Comment at: test/CXX/over/over.match/over.match.funcs/p4-0x.cpp:22-24 + void lvalue() &; // expected-note 2 {{'lvalue' declared here}} + void const_lvalue() const&; + void rvalue() &&; // expected-note {{'rvalue' declared here}} ---

[PATCH] D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches

JonasToth added a comment. finalize https://reviews.llvm.org/D37808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches

JonasToth updated this revision to Diff 123468. JonasToth marked 3 inline comments as done. JonasToth added a comment. - fix nits https://reviews.llvm.org/D37808 Files: clang-tidy/hicpp/CMakeLists.txt clang-tidy/hicpp/HICPPTidyModule.cpp clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp cl

[PATCH] D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from some minor commenting nits, LGTM Comment at: clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp:41 + switchStmt(hasCondition(allOf( +

[PATCH] D39665: Support __has_c_attribute

aaron.ballman added a comment. Ping https://reviews.llvm.org/D39665 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39611: [CodeGen] change const-ness of complex calls

This revision was automatically updated to reflect the committed changes. Closed by commit rL318598: [CodeGen] change const-ness of complex calls (authored by spatel). Changed prior to commit: https://reviews.llvm.org/D39611?vs=122474&id=123467#toc Repository: rL LLVM https://reviews.llvm.o

r318598 - [CodeGen] change const-ness of complex calls

Author: spatel Date: Sat Nov 18 11:31:57 2017 New Revision: 318598 URL: http://llvm.org/viewvc/llvm-project?rev=318598&view=rev Log: [CodeGen] change const-ness of complex calls After clarification about the C standard, POSIX, and implementations: The C standard allows errno-setting, and it's (un

[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

sabel83 updated this revision to Diff 123465. Herald added a subscriber: rnkovacs. https://reviews.llvm.org/D5767 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/FrontendActions.h include/clang/Frontend/FrontendOptions.h include/clang/FrontendTool/Utils.h include/clang/

[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Thank you for the explanation about what is driving this and the documentation. I don't think google-* is the correct module for this as it's too general of an umbrella

[PATCH] D39430: [clangd] formatting: don't ignore style

rwols added inline comments. Comment at: clangd/ClangdServer.h:289 + llvm::Expected> + formatRange(llvm::StringRef Code, PathRef File, Range Rng); + rwols wrote: > ilya-biryukov wrote: > > rwols wrote: > > > ilya-biryukov wrote: > > > > Why do we accept `Code`

[PATCH] D39430: [clangd] formatting: don't ignore style

rwols added inline comments. Comment at: clangd/ClangdServer.h:289 + llvm::Expected> + formatRange(llvm::StringRef Code, PathRef File, Range Rng); + ilya-biryukov wrote: > rwols wrote: > > ilya-biryukov wrote: > > > Why do we accept `Code` as a parameter here i

[PATCH] D39955: [Driver] Add a cc1 flag for the new TBAA metadata format

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D39955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D39627: Fix vtable not receiving hidden visibility when using push(visibility)

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Looks great, thanks! Repository: rL LLVM https://reviews.llvm.org/D39627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D39505: [OpenMP] Show error if VLAs are not supported

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, seems fine. Thanks for putting up with my questions. https://reviews.llvm.org/D39505 ___ cfe-commits mailing list cfe-commits@lists.ll