[PATCH] D43429: [clangd] Add missing library (clangLex) in a few places

malaperle created this revision. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov, mgorny, klimek. Fixes undefined reference to 'clang::Preprocessor::addCommentHandler' when building with -DBUILD_SHARED_LIBS. Signed-off-by: Marc-Andre Laperle Repository: rCTE Clan

[PATCH] D16403: Add scope information to CFG

NoQ added a comment. In https://reviews.llvm.org/D16403#1010096, @szepet wrote: > In https://reviews.llvm.org/D16403#992454, @NoQ wrote: > > > @szepet: so i see that `LoopExit` goes in the beginning of the cleanup > > block after the loop, while various `ScopeEnd`s go after the `LoopExit`. > >

[PATCH] D42266: [analyzer] Prevent AnalyzerStatsChecker from crash

NoQ accepted this revision. NoQ added a subscriber: george.karpenkov. NoQ added a comment. This revision is now accepted and ready to land. Herald added a reviewer: george.karpenkov. LGTM! @george.karpenkov has also tested that when he was gathering statistics about his traversal order improvemen

[PATCH] D43428: [CFG] NFC: Allow more complicated construction contexts.

NoQ updated this revision to Diff 134785. NoQ added a comment. Fix comment. https://reviews.llvm.org/D43428 Files: include/clang/Analysis/CFG.h lib/Analysis/CFG.cpp Index: lib/Analysis/CFG.cpp === --- lib/Analysis/CFG.cpp +++

[PATCH] D43428: [CFG] NFC: Allow more complicated construction contexts.

NoQ created this revision. NoQ added reviewers: rsmith, dcoughlin, xazax.hun, a.sidorin. Herald added subscribers: cfe-commits, rnkovacs, kristof.beyls, mehdi_amini. `ConstructionContext`s introduced in https://reviews.llvm.org/D42672 are an additional piece of information included with `CFGConst

[PATCH] D43423: [SimplifyCFG] Create flag to disable simplifyCFG.

davide added subscribers: chandlerc, davide. davide added a comment. Some high level comments: 1. This is something that GCC does relatively frequently (adding frontend options to control optimization passes), but LLVM tends to not expose these details. FWIW, I'd very much prefer the details o

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Quuxplusone updated this revision to Diff 134779. Quuxplusone added a comment. Add fixits. Repository: rC Clang https://reviews.llvm.org/D43322 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaExprCXX.cpp

[PATCH] D43105: [RISCV] Enable __int128_t and uint128_t through clang flag

efriedma added inline comments. Comment at: include/clang/Driver/Options.td:843 +def fforce_enable_int128 : Flag<["-"], "fforce-enable-int128">, Group, + Flags<[CC1Option]>, HelpText<"Enable support for int128_t type">; We should have an inverse flag -fno-forc

[PATCH] D40284: [Sema] Improve diagnostics for template arg deduction

jtbandes added a comment. Please take another look when you get a chance :) Repository: rC Clang https://reviews.llvm.org/D40284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43423: [SimplifyCFG] Create flag to disable simplifyCFG.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:109 static cl::opt MergeCondStores( "simplifycfg-merge-cond-stores", cl::Hidden, cl::init(true), why metadata instead of cl:opt like these? https://reviews.llvm.org/

[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

juliehockett created this revision. juliehockett added reviewers: klimek, jakehehrlich, sammccall. juliehockett added a project: clang-tools-extra. Herald added subscribers: mgrang, mgorny. juliehockett added a dependency: D43341: [clang-doc] Implement reducer portion of the frontend framework. I

[PATCH] D43203: [Driver] Generate .eh_frame_hdr for static executables too.

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Agreed. Repository: rC Clang https://reviews.llvm.org/D43203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D42676: Add support for LLVM_REPOSITORY_STRING.

srhines abandoned this revision. srhines added a comment. I'm going to solve this a different way. Repository: rC Clang https://reviews.llvm.org/D42676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D43423: [SimplifyCFG] Create flag to disable simplifyCFG.

morehouse created this revision. morehouse added a reviewer: kcc. Herald added a subscriber: hiraditya. When building with libFuzzer, simplifyCFG reduces the coverage signal available to libFuzzer when trying to find new inputs. This patch provides a way to disable simplifyCFG when building with

r325412 - [Basic] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Fri Feb 16 15:40:07 2018 New Revision: 325412 URL: http://llvm.org/viewvc/llvm-project?rev=325412&view=rev Log: [Basic] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/Basic/Diagnostic.h

[PATCH] D42995: [ThinLTO] Allow indexing to request backend to ignore the module

This revision was automatically updated to reflect the committed changes. Closed by commit rC325411: [ThinLTO] Allow indexing to request backend to ignore the module (authored by vitalybuka, committed by ). Changed prior to commit: https://reviews.llvm.org/D42995?vs=134657&id=134755#toc Reposi

r325411 - [ThinLTO] Allow indexing to request backend to ignore the module

Author: vitalybuka Date: Fri Feb 16 15:38:22 2018 New Revision: 325411 URL: http://llvm.org/viewvc/llvm-project?rev=325411&view=rev Log: [ThinLTO] Allow indexing to request backend to ignore the module Summary: Gold plugin does not add pass to ThinLTO modules without useful symbols. In this case

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

This revision was automatically updated to reflect the committed changes. Closed by commit rL325410: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set (authored by vitalybuka, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

This revision was automatically updated to reflect the committed changes. Closed by commit rC325410: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set (authored by vitalybuka, committed by ). Changed prior to commit: https://reviews.llvm.org/D42680?vs=134752&id=13

r325410 - [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

Author: vitalybuka Date: Fri Feb 16 15:34:16 2018 New Revision: 325410 URL: http://llvm.org/viewvc/llvm-project?rev=325410&view=rev Log: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set Summary: ThinLTO compilation may decide not to split module and keep at as regu

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 134752. vitalybuka marked an inline comment as done. vitalybuka added a comment. use count 0 https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp cl

[PATCH] D43105: [RISCV] Enable __int128_t and uint128_t through clang flag

mgrang updated this revision to Diff 134745. mgrang edited the summary of this revision. Repository: rC Clang https://reviews.llvm.org/D43105 Files: include/clang/Basic/TargetInfo.h include/clang/Basic/TargetOptions.h include/clang/Driver/Options.td lib/Basic/Targets/Mips.h lib/Drive

[PATCH] D43394: [X86] Add 'sahf' CPU feature, and emit __LAHFSAHF__ for it

dim updated this revision to Diff 134746. dim added a comment. Added the `sahf` feature for knm, knl and amdfam10 too. Repository: rC Clang https://reviews.llvm.org/D43394 Files: include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h test/CodeGen/attr-targe

Re: [PATCH] D43394: [X86] Add 'sahf' CPU feature, and emit __LAHFSAHF__ for it

On 17 Feb 2018, at 00:12, Craig Topper via Phabricator wrote: > > craig.topper added inline comments. > > > > Comment at: lib/Basic/Targets/X86.cpp:1049 > > + if (HasLAHFSAHF) > +Builder.defineMacro("__LAHFSAHF__"); > > dim wrote: >> craig.topper wrote:

[PATCH] D43411: [clangd] Rename some protocol field to lower case

This revision was automatically updated to reflect the committed changes. Closed by commit rL325409: [clangd] Rename some protocol field to lower case (authored by malaperle, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43411 Files:

[clang-tools-extra] r325409 - [clangd] Rename some protocol field to lower case

Author: malaperle Date: Fri Feb 16 15:12:26 2018 New Revision: 325409 URL: http://llvm.org/viewvc/llvm-project?rev=325409&view=rev Log: [clangd] Rename some protocol field to lower case Summary: Also fixes a GCC compilation error. Signed-off-by: Marc-Andre Laperle Subscribers: klimek, ilya-bir

[PATCH] D43394: [X86] Add 'sahf' CPU feature, and emit __LAHFSAHF__ for it

craig.topper added inline comments. Comment at: lib/Basic/Targets/X86.cpp:1049 + if (HasLAHFSAHF) +Builder.defineMacro("__LAHFSAHF__"); dim wrote: > craig.topper wrote: > > Does gcc define this? It's such a low level instruction I have a hard time > > bel

[PATCH] D43394: [X86] Add 'sahf' CPU feature, and emit __LAHFSAHF__ for it

dim added inline comments. Comment at: lib/Basic/Targets/X86.cpp:1049 + if (HasLAHFSAHF) +Builder.defineMacro("__LAHFSAHF__"); craig.topper wrote: > Does gcc define this? It's such a low level instruction I have a hard time > believing this define would b

[PATCH] D43411: [clangd] Rename some protocol field to lower case

malaperle created this revision. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov, klimek. Also fixes a GCC compilation error. Signed-off-by: Marc-Andre Laperle Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43411 Files: clangd/Protocol.cpp cla

[PATCH] D43394: [X86] Add 'sahf' CPU feature, and emit __LAHFSAHF__ for it

craig.topper added inline comments. Comment at: lib/Basic/Targets/X86.cpp:295 setFeatureEnabledImpl(Features, "xsave", true); setFeatureEnabledImpl(Features, "movbe", true); break; KNM and KNL should both have sahf Comment at: li

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

jakehehrlich added inline comments. Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:68 + diag(MatchedDecl->getLocStart(), + "visibility attribute not set for specified function") + << MatchedDecl aaron.ballman wrote: > How about: "fu

[PATCH] D35894: [clangd] Code hover for Clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rL325395: [clangd] Implement textDocument/hover (authored by malaperle, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D35894 Files: clang-tools-

[PATCH] D35894: [clangd] Code hover for Clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE325395: [clangd] Implement textDocument/hover (authored by malaperle, committed by ). Changed prior to commit: https://reviews.llvm.org/D35894?vs=134708&id=134712#toc Repository: rCTE Clang Tools E

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle accepted this revision. malaperle added a comment. This revision is now accepted and ready to land. Works well and code looks good. There were only minor tweaks since the last approval. I'll land this since there are some issues with Simon's svn account. Repository: rCTE Clang Tools

[clang-tools-extra] r325395 - [clangd] Implement textDocument/hover

Author: malaperle Date: Fri Feb 16 13:38:15 2018 New Revision: 325395 URL: http://llvm.org/viewvc/llvm-project?rev=325395&view=rev Log: [clangd] Implement textDocument/hover Summary: Implemention of textDocument/hover as described in LSP definition. This patch adds a basic Hover implementation.

r325391 - [OPENMP] Do not emit messages for templates in declare target

Author: abataev Date: Fri Feb 16 13:23:23 2018 New Revision: 325391 URL: http://llvm.org/viewvc/llvm-project?rev=325391&view=rev Log: [OPENMP] Do not emit messages for templates in declare target constructs. The compiler may emit some extra warnings for functions, that are implicit specialization

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

aaron.ballman added inline comments. Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:36-39 + StringRef(Options.get("Names", "")).split(NamesRefs, ","); + for (const auto &Name : NamesRefs) { +if (!Name.empty()) Names.push_back(Name); + } Rather than

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle updated this revision to Diff 134708. malaperle added a comment. Add a missing std::move, fix some formatting. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D35894 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/Clangd

Re: r325321 - [Sema] Take into account the current context when checking the

Thanks for taking care of it. It looks like I had to traverse the chain of Scopes upwards until Scope::getEntity() returns something that is not null. This is a reduced test case. clang doesn’t crash if I remove “if (true)”. $ cat test1.cpp struct CmapSubtable {}; struct A { protected: typ

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGen/thinlto_backend.ll:27 +; RUN: %clang -target x86_64-unknown-linux-gnu -O2 -o %t4.o -x ir %t5.o -c -fthinlto-index=%t.thinlto.bc +; RUN: llvm-nm

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle updated this revision to Diff 134692. malaperle added a comment. Rebase. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D35894 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/Protocol.cpp clang

[PATCH] D43371: [clang-include-fixer] Use add_clang_tool instead of add_clang_executable

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE325381: [clang-include-fixer] Use add_clang_tool instead add_clang_executable (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D43371?vs=134559&id=134691#toc Rep

[PATCH] D43404: [Fuchsia] Include libClang and clang-include-fixer in the toolchain

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. libClang is used by other Clang based tools such as cquery while clang-include-fixer is generally a useful tool. Repository: rC Clang https://reviews.llvm.org/D43404 F

[clang-tools-extra] r325381 - [clang-include-fixer] Use add_clang_tool instead add_clang_executable

Author: phosek Date: Fri Feb 16 12:25:45 2018 New Revision: 325381 URL: http://llvm.org/viewvc/llvm-project?rev=325381&view=rev Log: [clang-include-fixer] Use add_clang_tool instead add_clang_executable This makes it possible to include clang-include-fixer as distribution component when building

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

juliehockett updated this revision to Diff 134684. juliehockett marked 7 inline comments as done. juliehockett edited the summary of this revision. juliehockett added a comment. 1. Added visibility parameter 2. Updated Name parameter to be a list of names, as opposed to a single name 3. Fixed comm

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

jakehehrlich added a comment. > I'd like a test for #pragma GCC visibility push(hidden) which should cause > each symbol to be treated as though it were explicitly hidden. To clarify, this check should still give a warning if the specified variable doesn't actually have that in source code. e.g

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

jakehehrlich added a comment. I'd like a test for #pragma GCC visibility push(hidden) which should cause each symbol to be treated as though it were explicitly hidden. Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:32 + if (Name.empty()) return; + Finder->addMatcher(f

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen added a comment. In https://reviews.llvm.org/D43378#1010464, @emaste wrote: > LGTM with one small note. > > What will it take for us to enable this on the rest of the platforms > Clang/FreeBSD supports? As I see only x86_64 arch implements everything (e.g. custom event), making thing

r325375 - [MS] Make constexpr static data members implicitly inline

Author: rnk Date: Fri Feb 16 11:44:47 2018 New Revision: 325375 URL: http://llvm.org/viewvc/llvm-project?rev=325375&view=rev Log: [MS] Make constexpr static data members implicitly inline This handles them exactly the same way that we handle const integral static data members with inline definiti

[clang-tools-extra] r325374 - [Documentation] Fix Sphinx error. Limit text width to 80 characters.

Author: eugenezelenko Date: Fri Feb 16 11:31:28 2018 New Revision: 325374 URL: http://llvm.org/viewvc/llvm-project?rev=325374&view=rev Log: [Documentation] Fix Sphinx error. Limit text width to 80 characters. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/readability-simd-intrinsic

[PATCH] D42995: [ThinLTO] Allow indexing to request backend to ignore the module

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D42995 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:60 +- New `fuchsia-add-visibility + `_ check Please move into new checks section. Comment at

r325373 - [OPENMP] Fix PR35873: Fix data-sharing attributes for const variables.

Author: abataev Date: Fri Feb 16 11:16:54 2018 New Revision: 325373 URL: http://llvm.org/viewvc/llvm-project?rev=325373&view=rev Log: [OPENMP] Fix PR35873: Fix data-sharing attributes for const variables. Compiler erroneously returned wrong data-sharing attributes for the constant variables if th

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen updated this revision to Diff 134659. https://reviews.llvm.org/D43378 Files: lib/Driver/ToolChains/FreeBSD.cpp lib/Driver/XRayArgs.cpp test/Driver/XRay/lit.local.cfg test/Driver/XRay/xray-instrument-os.c test/Driver/XRay/xray-shared-noxray.cpp Index: lib/Driver/XRayArgs.cpp ==

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka added a comment. @pcc Could you please take a look? https://reviews.llvm.org/D42680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42995: [ThinLTO] Allow indexing to request backend to ignore the module

vitalybuka updated this revision to Diff 134657. vitalybuka marked 6 inline comments as done. vitalybuka added a comment. addressed comments https://reviews.llvm.org/D42995 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/Inputs/thinlto-distributed-backend-skip.bc clang/test/Co

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

emaste added a comment. LGTM with one small note. What will it take for us to enable this on the rest of the platforms Clang/FreeBSD supports? Comment at: test/Driver/XRay/lit.local.cfg:7-8 supported_targets = [ 'x86_64', 'x86_64h', 'arm', 'aarch64', 'arm64', 'powerpc64

r325369 - [OPENMP] Fix parsing of the directives with inner directives.

Author: abataev Date: Fri Feb 16 10:36:44 2018 New Revision: 325369 URL: http://llvm.org/viewvc/llvm-project?rev=325369&view=rev Log: [OPENMP] Fix parsing of the directives with inner directives. The parsing may lead to compiler hanging because of the incorrect processing of inner OpenMP pragmas.

[PATCH] D42922: [CUDA] Register relocatable GPU binaries

Hahnfeld marked an inline comment as done. Hahnfeld added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:330-331 // the GPU side. for (const std::string &GpuBinaryFileName : CGM.getCodeGenOpts().CudaGpuBinaryFileNames) { llvm::ErrorOr> GpuBinaryOrErr = -

[PATCH] D42922: [CUDA] Register relocatable GPU binaries

tra added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:330-331 // the GPU side. for (const std::string &GpuBinaryFileName : CGM.getCodeGenOpts().CudaGpuBinaryFileNames) { llvm::ErrorOr> GpuBinaryOrErr = Hahnfeld wrote: > tra wrote: > >

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:182 + // it would always be false. + string DisallowImplicitThisParamName = disallowImplicitThisParamName; +} jdenny wrote: > aaron.ballman wrote: > > jdenny wrote: > > > aaron.ballman

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

jdenny added inline comments. Comment at: include/clang/Basic/Attr.td:182 + // it would always be false. + string DisallowImplicitThisParamName = disallowImplicitThisParamName; +} aaron.ballman wrote: > jdenny wrote: > > aaron.ballman wrote: > > > jdenny wrote:

[PATCH] D42922: [CUDA] Register relocatable GPU binaries

Hahnfeld added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:330-331 // the GPU side. for (const std::string &GpuBinaryFileName : CGM.getCodeGenOpts().CudaGpuBinaryFileNames) { llvm::ErrorOr> GpuBinaryOrErr = tra wrote: > Hahnfeld wrote

[PATCH] D43181: [CodeGen] Initialize large arrays by copying from a global

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D43181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:182 + // it would always be false. + string DisallowImplicitThisParamName = disallowImplicitThisParamName; +} jdenny wrote: > aaron.ballman wrote: > > jdenny wrote: > > > jdenny wrote:

[PATCH] D42922: [CUDA] Register relocatable GPU binaries

tra added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:330-331 // the GPU side. for (const std::string &GpuBinaryFileName : CGM.getCodeGenOpts().CudaGpuBinaryFileNames) { llvm::ErrorOr> GpuBinaryOrErr = Hahnfeld wrote: > Can we actuall

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. ping Repository: rC Clang https://reviews.llvm.org/D42645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

aaron.ballman added inline comments. Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:32 + if (Name.empty()) return; + Finder->addMatcher(functionDecl(allOf(hasName(Name), isDefinition(), +unless(hasVisibilityAttr( --

[PATCH] D43359: Clean up 'target' attribute diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rC325364: Clean up 'target' attribute diagnostics (authored by erichkeane, committed by ). Changed prior to commit: https://reviews.llvm.org/D43359?vs=134643&id=134648#toc Repository: rC Clang https:/

r325364 - Clean up 'target' attribute diagnostics

Author: erichkeane Date: Fri Feb 16 09:31:59 2018 New Revision: 325364 URL: http://llvm.org/viewvc/llvm-project?rev=325364&view=rev Log: Clean up 'target' attribute diagnostics There were a few issues previously with the target attribute diagnostics implementation that lead to the attribute being

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

miyuki added a comment. Herald added a subscriber: christof. ping https://reviews.llvm.org/D41629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

krytarowski added inline comments. Comment at: lib/Driver/XRayArgs.cpp:54 +if (Triple.getArch() != llvm::Triple::x86_64) { + D.Diag(diag::err_drv_clang_unsupported) + << (std::string(XRayInstrumentOption) + " on " + Triple.str()); de

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen added inline comments. Comment at: lib/Driver/XRayArgs.cpp:54 +if (Triple.getArch() != llvm::Triple::x86_64) { + D.Diag(diag::err_drv_clang_unsupported) + << (std::string(XRayInstrumentOption) + " on " + Triple.str()); kryta

[PATCH] D43359: Clean up 'target' attribute diagnostics

aaron.ballman accepted this revision. aaron.ballman added a comment. Aside from a minor wording nit, LGTM! Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2448-2449 def warn_unsupported_target_attribute -: Warning<"ignoring %select{unsupported|duplicate}0" -

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

krytarowski added inline comments. Comment at: lib/Driver/XRayArgs.cpp:54 +if (Triple.getArch() != llvm::Triple::x86_64) { + D.Diag(diag::err_drv_clang_unsupported) + << (std::string(XRayInstrumentOption) + " on " + Triple.str()); Mi

[PATCH] D43359: Clean up 'target' attribute diagnostics

erichkeane updated this revision to Diff 134643. erichkeane added a comment. Do as @aaron.ballman suggested for the message. Also, removed properties from the new file. https://reviews.llvm.org/D43359 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDeclAttr.cpp test/Sema/

[PATCH] D43394: [X86] Add 'sahf' CPU feature, and emit __LAHFSAHF__ for it

dim created this revision. dim added reviewers: craig.topper, coby, efriedma, rsmith. Make clang accept `-msahf` (and `-mno-sahf`) flags to activate the `+sahf` feature for the backend, for bug 36028 (Incorrect use of pushf/popf enables/disables interrupts on amd64 kernels). This was originally s

[PATCH] D43232: clang-format: use AfterControlStatement to format ObjC control blocks

Typz updated this revision to Diff 134641. Typz added a comment. Fix bug which was lingering: prevent inlining of ObjC special control blocks. Repository: rC Clang https://reviews.llvm.org/D43232 Files: include/clang/Format/Format.h lib/Format/UnwrappedLineFormatter.cpp lib/Format/Unwr

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. Looks good to me now. Wait a couple of days before submitting it just in case the other reviewers have more comments. Do you plan to submit (in another change) the unscoped enum → integer

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

jdenny added inline comments. Comment at: include/clang/Basic/Attr.td:182 + // it would always be false. + string DisallowImplicitThisParamName = disallowImplicitThisParamName; +} aaron.ballman wrote: > jdenny wrote: > > jdenny wrote: > > > aaron.ballman wrote:

Re: [PATCH] D42640: [clangd] collect symbol #include & insert #include in global code completion.

Hi Carlos, did this fail on a Windows build bot? Would you mind pointing me to the broken test? Thanks! On Fri, Feb 16, 2018 at 4:23 PM Carlos Alberto Enciso via Phabricator < revi...@reviews.llvm.org> wrote: > CarlosAlbertoEnciso added a comment. > > Hi @ioeric: > > Just to let you know that you

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, alexfh. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adding a checker to find a function given its name and add a visibility attribute if none is present (i.e.

[clang-tools-extra] r325357 - [clangd] Include timestamps in log messages.

Author: sammccall Date: Fri Feb 16 08:41:42 2018 New Revision: 325357 URL: http://llvm.org/viewvc/llvm-project?rev=325357&view=rev Log: [clangd] Include timestamps in log messages. Modified: clang-tools-extra/trunk/clangd/JSONRPCDispatcher.cpp Modified: clang-tools-extra/trunk/clangd/JSONRPC

[PATCH] D43359: Clean up 'target' attribute diagnostics

aaron.ballman added inline comments. Comment at: test/Sema/attr-target.c:9-10 int __attribute__((target("fpmath=387"))) walrus() { return 4; } //expected-warning {{ignoring unsupported 'fpmath=' in the target attribute string}} +// expected-warning@+1 {{'target' attribute igno

[PATCH] D43359: Clean up 'target' attribute diagnostics

erichkeane added inline comments. Comment at: test/Sema/attr-target-ast.c:1 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -ast-dump %s | FileCheck %s + aaron.ballman wrote: > Can you drop the svn props from this file? Absolutely, I'll do that on commit.

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen updated this revision to Diff 134634. https://reviews.llvm.org/D43378 Files: lib/Driver/ToolChains/FreeBSD.cpp lib/Driver/XRayArgs.cpp test/Driver/XRay/lit.local.cfg test/Driver/XRay/xray-instrument-os.c test/Driver/XRay/xray-shared-noxray.cpp Index: test/Driver/XRay/xray-shar

[PATCH] D36701: Use Token::isOneOf method in Parser.

This revision was automatically updated to reflect the committed changes. Closed by commit rL325352: Use Token::isOneOf method in Parser. (authored by marsupial, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D36701?vs=111034&id=134629

r325352 - Use Token::isOneOf method in Parser.

Author: marsupial Date: Fri Feb 16 08:07:33 2018 New Revision: 325352 URL: http://llvm.org/viewvc/llvm-project?rev=325352&view=rev Log: Use Token::isOneOf method in Parser. Summary: Easier to read and possibly optimize. Reviewers: rsmith, sepavloff Reviewed By: sepavloff Subscribers: sepavloff

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen updated this revision to Diff 134628. devnexen added a comment. Herald added a subscriber: srhines. Enabling one test for FreeBSD https://reviews.llvm.org/D43378 Files: lib/Driver/ToolChains/FreeBSD.cpp lib/Driver/XRayArgs.cpp test/Driver/XRay/lit.local.cfg test/Driver/XRay/xra

[PATCH] D43372: [ARM] Add tests for the vcvtr builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL325351: [ARM] Add tests for the vcvtr builtins (authored by SjoerdMeijer, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43372?vs=134570&id=1

[PATCH] D43372: [ARM] Add tests for the vcvtr builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rC325351: [ARM] Add tests for the vcvtr builtins (authored by SjoerdMeijer, committed by ). Repository: rL LLVM https://reviews.llvm.org/D43372 Files: test/CodeGen/builtins-arm.c test/Sema/builtins-

r325351 - [ARM] Add tests for the vcvtr builtins

Author: sjoerdmeijer Date: Fri Feb 16 08:01:08 2018 New Revision: 325351 URL: http://llvm.org/viewvc/llvm-project?rev=325351&view=rev Log: [ARM] Add tests for the vcvtr builtins This adds Sema and Codegen tests for the vcvtr builtins (because they were missing). Differential Revision: https://re

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

krytarowski added a comment. Please add a clang test to verify that we can pass xray flags, as requested by @dberris. https://reviews.llvm.org/D43378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen updated this revision to Diff 134622. devnexen added a comment. Reusing generic message/reformating. https://reviews.llvm.org/D43378 Files: lib/Driver/ToolChains/FreeBSD.cpp lib/Driver/XRayArgs.cpp Index: lib/Driver/XRayArgs.cpp ===

[PATCH] D43372: [ARM] Add tests for the vcvtr builtins

SjoerdMeijer added a comment. Thanks for reviewing! https://reviews.llvm.org/D43372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen added inline comments. Comment at: lib/Driver/XRayArgs.cpp:56 +<< (std::string(XRayInstrumentOption) + " only on " +"FreeBSD x86_64"); +} krytarowski wrote: > krytarowski wrote: > > I think it's better to not h

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

krytarowski added inline comments. Comment at: lib/Driver/XRayArgs.cpp:56 +<< (std::string(XRayInstrumentOption) + " only on " +"FreeBSD x86_64"); +} krytarowski wrote: > I think it's better to not hardcode `x86_64` her

[PATCH] D43388: [clangd] Tracing: name worker threads, and enforce naming scheduled async tasks

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, klimek. This has a bit of a blast radius, but I think there's enough value in "forcing" us to give names to these async tasks for debugging. Guessing about what

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/DeprecatedFunctionalCheck.cpp:33 + this); + Finder->addMatcher(callExpr(callee(functionDecl(hasName("std::mem_fun" + .bind("mem_fun_call"), mass

[PATCH] D41880: Adding nocf_check attribute for cf-protection fine tuning

aaron.ballman added inline comments. Comment at: test/Sema/attr-nocf_check.c:18-20 + FuncPointerWithNoCfCheck fNoCfCheck = f; // no-warning + (*fNoCfCheck)(); // no-warning + f = fNoCfCheck;// no-warning aaron.ball

  1   2   >