Author: ctopper
Date: Thu Jun 28 22:43:33 2018
New Revision: 335945
URL: http://llvm.org/viewvc/llvm-project?rev=335945&view=rev
Log:
[X86] Remove masking from the avx512 packed sqrt builtins. Use select builtins
instead.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
cfe/trunk/
rjmccall added inline comments.
Comment at: include/clang/Basic/FixedPoint.h:31
+ SatNoPadding,
+};
+
I figured you'd want this to be a struct which include the scale, width,
signed-ness, and saturating-ness; and then `APFixedPoint` can just store one of
these
mclow.lists updated this revision to Diff 153432.
mclow.lists marked 3 inline comments as done.
mclow.lists added a comment.
Update in response to comments.
https://reviews.llvm.org/D48616
Files:
include/memory
include/string
test/std/strings/basic.string/string.cons/copy_assignment.pass.
vsapsai added a comment.
In https://reviews.llvm.org/D48753#1147500, @Quuxplusone wrote:
> I'm pretty sure that the C++03 standard doesn't permit the implementation to
> call any `construct` method here, even if it wanted to. And this adds a
> couple hundred LOC to get that (non-standard) behav
Quuxplusone added a comment.
I'm pretty sure that the C++03 standard doesn't permit the implementation to
call any `construct` method here, even if it wanted to. And this adds a couple
hundred LOC to get that (non-standard) behavior. Is there a specific use-case
that you're trying to enable by
mclow.lists marked 5 inline comments as done.
mclow.lists added inline comments.
Comment at: include/string:836
_LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS
-basic_string(const _Tp& __t, size_type __pos, size_type __n,
- const allocator_
vsapsai added inline comments.
Comment at: libcxx/include/memory:1479
+struct __has_construct_missing
+: false_type
+{
vsapsai wrote:
> erik.pilkington wrote:
> > vsapsai wrote:
> > > erik.pilkington wrote:
> > > > Shouldn't this be true_type?
> > > I see thi
vsapsai updated this revision to Diff 153431.
vsapsai added a comment.
Try to exclude changes available in parent review from this review.
https://reviews.llvm.org/D48342
Files:
libcxx/include/memory
libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter_alloc.pass.cpp
vsapsai updated this revision to Diff 153430.
vsapsai added a comment.
Herald added a subscriber: dexonsmith.
- Don't check `!__has_construct` for `__construct_range_forward`.
Incompatible types will cause a lack of `construct` but it doesn't mean we
should use memcpy instead. And missing `_Alloc
vsapsai created this revision.
vsapsai added reviewers: mclow.lists, EricWF, erik.pilkington.
Herald added a subscriber: dexonsmith.
Can use `decltype` in C++03 because `include/__config` defines a macro when
`decltype` is not available.
https://reviews.llvm.org/D48753
Files:
libcxx/include/m
leonardchan updated this revision to Diff 153426.
leonardchan marked 8 inline comments as done.
leonardchan added a comment.
Herald added a subscriber: mgorny.
- Renamed to APFixedPoint
- Added `FixedPointSemantics` to represent saturation and whether or not
padding is involved. Similar to `APFlo
leonardchan added inline comments.
Comment at: include/clang/Basic/FixedPoint.h:23
+
+class FixedPointNumber {
+ public:
rjmccall wrote:
> ebevhan wrote:
> > rjmccall wrote:
> > > The established naming convention here — as seen in `APInt`, `APFloat`,
> > > `APV
rsmith added a comment.
This is not specific to the `ASTImporter`; any change to the AST after a call
to `getParents` would have similar problems. Generally, responsibility for
dealing with this must lie with the consumer of the parent map, not with the
`ASTContext`, since the `ASTContext` gene
deepak2427 added a subscriber: shenhan.
deepak2427 added a comment.
I had based it on the other tests in clang/test/CodeGen.
Do we not need the `-o` to output to standard output?
Or did you mean something else?
Repository:
rC Clang
https://reviews.llvm.org/D48721
__
I had based it on the other tests in clang/test/CodeGen.
Do we not need the `-o` to output to standard output?
Or did you mean something else?
On Thu, Jun 28, 2018 at 10:25 PM Roman Lebedev via Phabricator <
revi...@reviews.llvm.org> wrote:
> lebedev.ri added a comment.
>
> I'm not sure we can us
Author: arphaman
Date: Thu Jun 28 16:23:45 2018
New Revision: 335940
URL: http://llvm.org/viewvc/llvm-project?rev=335940&view=rev
Log:
[frontend] Don't include the C++ stdlib for -x assembler-with-cpp
The new C++ stdlib warning added in r335081 gets
triggered when compiling an assembly file with
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335940: [frontend] Don't include the C++ stdlib for -x
assembler-with-cpp (authored by arphaman, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48736?vs=153368&id=153420#toc
Reposit
apazos updated this revision to Diff 153419.
apazos added a comment.
Updated tests and removed Subjects from Attr.td
https://reviews.llvm.org/D48412
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/TargetInfo.cpp
apazos added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5301
+
+ if (!isFunctionOrMethod(D)) {
+S.Diag(D->getLocation(), diag::warn_attribute_wrong_decl_type)
aaron.ballman wrote:
> apazos wrote:
> > aaron.ballman wrote:
> > > I don't think you n
Author: dblaikie
Date: Thu Jun 28 15:58:04 2018
New Revision: 335938
URL: http://llvm.org/viewvc/llvm-project?rev=335938&view=rev
Log:
DebugInfo: Add -gno-gnu-pubnames to allow disabling gnu-pubnames later in the
command line
Modified:
cfe/trunk/include/clang/Driver/Options.td
cfe/trunk/
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Frontend/InitHeaderSearch.cpp:474
+ if (Lang.CPlusPlus && !Lang.AsmPreprocessor &&
+ HSOpts.UseStandardCXXIncludes && HSOpts.UseStandardSystemInclude
arphaman added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:474
+ if (Lang.CPlusPlus && !Lang.AsmPreprocessor &&
+ HSOpts.UseStandardCXXIncludes && HSOpts.UseStandardSystemIncludes) {
if (HSOpts.UseLibcxx) {
bruno wrote:
> Since you a
ldionne added a comment.
I guess I'm echoing some of Eric's comments, but does it make sense to build
libc++abi against a system-installed libc++? If not, this change makes sense.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D48694
___
c
ldionne added inline comments.
Comment at: include/string:856
+_LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS
+explicit basic_string(const _Tp& __t, const allocator_type& __a);
+
tcanens wrote:
> ldionne wrote:
> > I think this `explicit` shou
Author: mramalho
Date: Thu Jun 28 15:08:44 2018
New Revision: 335932
URL: http://llvm.org/viewvc/llvm-project?rev=335932&view=rev
Log:
[analyzer] fix test case expected warning
After r335814, the constraint manager is no longer generating a false bug report
about the division by zero in the test
bruno added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:474
+ if (Lang.CPlusPlus && !Lang.AsmPreprocessor &&
+ HSOpts.UseStandardCXXIncludes && HSOpts.UseStandardSystemIncludes) {
if (HSOpts.UseLibcxx) {
Since you added `HSOpts.UseSt
pirama created this revision.
pirama added reviewers: mstorsjo, EricWF, srhines, danalbert.
Herald added subscribers: ldionne, christof.
_is_chartype_l (needed for isxdigit_l) in MinGW compares locale_t and NULL.
NULL is 'long long' for 64-bit, and this results in ambiguous overloads when
compiled
Author: mramalho
Date: Thu Jun 28 14:39:41 2018
New Revision: 335929
URL: http://llvm.org/viewvc/llvm-project?rev=335929&view=rev
Log:
[analyzer] Move test to the correct directory
It was accidentaly pushed in r335926
Added:
cfe/trunk/test/Analysis/PR37855.c
- copied, changed from r335
george.burgess.iv added a comment.
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D47840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335927: [Parse] Make -Wgcc-compat complain about for loop
inits in C89 (authored by gbiv, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D4784
Author: gbiv
Date: Thu Jun 28 14:36:00 2018
New Revision: 335927
URL: http://llvm.org/viewvc/llvm-project?rev=335927&view=rev
Log:
[Parse] Make -Wgcc-compat complain about for loop inits in C89
While clang allows declarations in for loop init statements in c89 and
gnu89, gcc does not. So, we shou
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: llvm/docs/LangRef.rst:12928
+established by ``invariant.group`` metadata no longer holds, to obtain a new
pointer
+value that does carries fresh invariant gr
pirama created this revision.
pirama added reviewers: EricWF, srhines, danalbert.
Herald added subscribers: ldionne, christof.
Add the _LIBCPP_TLS_DESTRUCTOR_CC attribute to the __at_exit parameter
for the pthread definition of __libcpp_get_tls. This makes it
consistent with the rest (the non-pth
pirama created this revision.
pirama added reviewers: EricWF, srhines, danalbert.
Herald added subscribers: ldionne, christof.
This function is passed as the __at_exit parameter to
__libcpp_tls_create. This parameter is marked with the
_LIBCPP_TLS_DESTRUCTOR_CC attribute. The macro is empty for
Author: mramalho
Date: Thu Jun 28 14:26:52 2018
New Revision: 335926
URL: http://llvm.org/viewvc/llvm-project?rev=335926&view=rev
Log:
[analyzer] Fix wrong comparison generation of the ranges generated by the
refutation manager
The refutation manager is removing a true bug from the test in this
lebedev.ri added a comment.
I'm not sure we can use `-O` in tests at all, and i'm not sure it is even
needed here since you are only testing codegen.
Repository:
rC Clang
https://reviews.llvm.org/D48721
___
cfe-commits mailing list
cfe-commits@l
Author: rsmith
Date: Thu Jun 28 14:17:55 2018
New Revision: 335925
URL: http://llvm.org/viewvc/llvm-project?rev=335925&view=rev
Log:
PR37979: integral promotions in C++ treat enum bit-fields like enums,
not like bit-fields.
We used to get this right "by accident", because conversions for the
sele
deepak2427 updated this revision to Diff 153393.
deepak2427 added a comment.
Add tests and the patch.
https://reviews.llvm.org/D48721
Files:
lib/CodeGen/CGStmt.cpp
test/CodeGen/pragma-do-while-unroll.cpp
test/CodeGen/pragma-do-while.cpp
Index: test/CodeGen/pragma-do-while.cpp
===
deepak2427 updated this revision to Diff 153392.
deepak2427 added a comment.
Herald added a subscriber: zzheng.
Add tests.
https://reviews.llvm.org/D48721
Files:
test/CodeGen/pragma-do-while-unroll.cpp
test/CodeGen/pragma-do-while.cpp
Index: test/CodeGen/pragma-do-while.cpp
==
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
> I'm not 100% thrilled that we're emitting two warnings about the same thing
> for slightly different reasons; alternatives welcome. :)
Me either, but given our policy that warning flags just
george.burgess.iv added a comment.
Ping :)
Repository:
rC Clang
https://reviews.llvm.org/D47840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malaperle added inline comments.
Comment at: clangd/XRefs.cpp:559
+ //- auto& i = 1;
+ bool VisitDeclaratorDecl(DeclaratorDecl *D) {
+if (!D->getTypeSourceInfo() ||
klimek wrote:
> sammccall wrote:
> > malaperle wrote:
> > > sammccall wrote:
> > > > out of
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335919: [CMake] Don't build Linux targets on Darwin in
Fuchsia toolchain (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48710?vs=153275&id=153385#toc
Repository
Author: phosek
Date: Thu Jun 28 13:33:18 2018
New Revision: 335919
URL: http://llvm.org/viewvc/llvm-project?rev=335919&view=rev
Log:
[CMake] Don't build Linux targets on Darwin in Fuchsia toolchain
This is currently breaking because Linux target sysroots rely on
case sensitive filesystem which is
mikhail.ramalho abandoned this revision.
mikhail.ramalho added a comment.
We won't need this patch anymore because we'll try another approach in
https://reviews.llvm.org/D48565.
Repository:
rC Clang
https://reviews.llvm.org/D48561
___
cfe-commit
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335917: [CMake] Build static runtimes for host in Fuchsia
first stage (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48707?vs=153270&id=153383#toc
Repository:
Author: phosek
Date: Thu Jun 28 13:19:11 2018
New Revision: 335917
URL: http://llvm.org/viewvc/llvm-project?rev=335917&view=rev
Log:
[CMake] Build static runtimes for host in Fuchsia first stage
First stage build is only a minimal build where we don't need
a complete multiarch support, but we nee
juliehockett accepted this revision.
juliehockett added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D48710
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX335916: Configure ELAST for MinGW (authored by pirama,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48731?vs=153352&id=153381#toc
Repository:
rCXX libc++
https://reviews.llvm
Author: pirama
Date: Thu Jun 28 13:16:45 2018
New Revision: 335916
URL: http://llvm.org/viewvc/llvm-project?rev=335916&view=rev
Log:
Configure ELAST for MinGW
Summary:
Use _LIBCPP_MSVCRT_LIKE while configuring ELAST, so MinGW gets the same
configuration as MSVC.
Reviewers: compnerd, srhines, dan
mstorsjo accepted this revision.
mstorsjo added a comment.
LGTM, test built it and it seems to work fine.
Repository:
rCXX libc++
https://reviews.llvm.org/D48731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335911: [OPENMP] Fix incomplete type check for array
reductions (authored by jdenny, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48735?vs=153366&id=153374#toc
Repository:
rC Cl
Author: jdenny
Date: Thu Jun 28 12:54:49 2018
New Revision: 335911
URL: http://llvm.org/viewvc/llvm-project?rev=335911&view=rev
Log:
[OPENMP] Fix incomplete type check for array reductions
A reduction for an incomplete array type used to produce an assert
fail during codegen. Now it produces a d
Author: jdenny
Date: Thu Jun 28 12:54:27 2018
New Revision: 335910
URL: http://llvm.org/viewvc/llvm-project?rev=335910&view=rev
Log:
Revert r335907: [OPENMP] Fix incomplete type check for array reductions
Sorry, forgot to add commit log attributes again.
Removed:
cfe/trunk/test/OpenMP/parall
tcanens added inline comments.
Comment at: include/string:856
+_LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS
+explicit basic_string(const _Tp& __t, const allocator_type& __a);
+
ldionne wrote:
> I think this `explicit` shouldn't be there, too
Author: jdenny
Date: Thu Jun 28 12:46:10 2018
New Revision: 335907
URL: http://llvm.org/viewvc/llvm-project?rev=335907&view=rev
Log:
[OPENMP] Fix incomplete type check for array reductions
A reduction for an incomplete array type used to produce an assert
fail during codegen. Now it produces a d
arphaman created this revision.
arphaman added a reviewer: bruno.
Herald added a subscriber: dexonsmith.
The new C++ stdlib warning added in https://reviews.llvm.org/D48297 gets
triggered when compiling an assembly file with -x assembler-with-cpp.
This commit ensures that the C++ stdlib is not in
craig.topper added inline comments.
Comment at: clang/lib/Headers/avx512vlintrin.h:33
+typedef short __v2hi __attribute__((__vector_size__(4)));
+typedef char __v4qi __attribute__((__vector_size__(4)));
Can you just do a local typedef in the functions that need
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
https://reviews.llvm.org/D48735
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
jdenny created this revision.
jdenny added a reviewer: ABataev.
Herald added a subscriber: guansong.
A reduction for an incomplete array type used to produce an assert
fail during codegen. Now it produces a diagnostic.
Repository:
rC Clang
https://reviews.llvm.org/D48735
Files:
clang/lib/
Meinersbur added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:5534
+ if (!IsFirst)
+return CommonResult;
+
Not sure what should be returned here; To minimize surprises, this returns what
the current version would have returned.
Repositor
Meinersbur created this revision.
Meinersbur added reviewers: dlj, rsmith, Jean-Daniel.
If a function has multiple format_arg attributes, clang only considers the
first it finds (because AttributeLists are in reverse order, it is textual
last) and ignores all others.
Loop over all FormatArgAttr
rupprecht created this revision.
rupprecht added a reviewer: saugustine.
Herald added subscribers: cfe-commits, chrib, christof.
Repository:
rUNW libunwind
https://reviews.llvm.org/D48733
Files:
src/AddressSpace.hpp
Index: src/AddressSpace.hpp
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335899: [CMake] Rename cxx_headers back to cxx-headers.
(authored by ab, committed by ).
Herald added subscribers: llvm-commits, christof.
Changed prior to commit:
https://reviews.llvm.org/D48701?vs=153
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335898: [CMake] Make bootstrap and compiler-rt depend on
cxx-headers. (authored by ab, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48700?v
Author: ab
Date: Thu Jun 28 11:35:35 2018
New Revision: 335899
URL: http://llvm.org/viewvc/llvm-project?rev=335899&view=rev
Log:
[CMake] Rename cxx_headers back to cxx-headers.
r334477 renamed the cxx-headers target to cxx_headers, but various
pieces sort-of expect the target names to match the c
Author: ab
Date: Thu Jun 28 11:35:25 2018
New Revision: 335898
URL: http://llvm.org/viewvc/llvm-project?rev=335898&view=rev
Log:
[CMake] Make bootstrap and compiler-rt depend on cxx-headers.
Since r334468, we no longer always copy the libcxx headers by virtue of
their presence when cmake runs.
T
GBuella added inline comments.
Comment at: test/CodeGen/avx-builtins.c:1423
-
-__m256 test_mm256_cmp_ps_true(__m256 a, __m256 b) {
- // CHECK-LABEL: @test_mm256_cmp_ps_true
spatel wrote:
> GBuella wrote:
> > spatel wrote:
> > > Why are we deleting tests instead
enyquist added a comment.
@klimek fair point. To be honest, I've pretty much lost interest / momentum on
this feature, I very much doubt I will ever go back and re-implement from
scratch as you suggest.
Not meaning to sound rude, I just don't want to waste anyone's time who is
waiting for this
rsmith added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1647
+ }
+}
+
Prazek wrote:
> rjmccall wrote:
> > Prazek wrote:
> > > rjmccall wrote:
> > > > Incidentally, how do you protect against code like this?
> > > >
> > > > A *ptr;
ldionne added inline comments.
Comment at: include/string:836
_LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS
-basic_string(const _Tp& __t, size_type __pos, size_type __n,
- const allocator_type& __a = allocator_type(),
-
Author: aaronballman
Date: Thu Jun 28 11:03:00 2018
New Revision: 335896
URL: http://llvm.org/viewvc/llvm-project?rev=335896&view=rev
Log:
Set the line ending of clang.natvis to CRLF.
This corresponds to r335889, which does the same thing for llvm.natvis.
Modified:
cfe/trunk/utils/ClangVisua
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks for working on this, LGTM
https://reviews.llvm.org/D48367
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
Author: vedantk
Date: Thu Jun 28 10:53:35 2018
New Revision: 335890
URL: http://llvm.org/viewvc/llvm-project?rev=335890&view=rev
Log:
[Darwin] Remove _VPMergeHook from the auto-export list
Remove _VPMergeHook from Darwin's automatically-exported symbol list for
PGO. As of r328987 this symbol is n
RKeelan added a comment.
My team is waiting for this feature, too.
Repository:
rL LLVM
https://reviews.llvm.org/D28462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pirama created this revision.
pirama added reviewers: compnerd, srhines, danalbert, mstorsjo.
Herald added subscribers: cfe-commits, ldionne, christof.
Use _LIBCPP_MSVCRT_LIKE while configuring ELAST, so MinGW gets the same
configuration as MSVC.
Repository:
rCXX libc++
https://reviews.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335880: [CUDA] Place all CUDA sections in __NV_CUDA segment
on Mac. (authored by tra, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48615?vs
Author: tra
Date: Thu Jun 28 10:15:52 2018
New Revision: 335880
URL: http://llvm.org/viewvc/llvm-project?rev=335880&view=rev
Log:
[CUDA] Place all CUDA sections in __NV_CUDA segment on Mac.
That's where CUDA binaries appear to put them.
Differential Revision: https://reviews.llvm.org/D48615
Mod
craig.topper added inline comments.
Comment at: clang/lib/Headers/avx512vlintrin.h:7421
+ __builtin_convertvector((__v4si)__A, __v4qi), (__v4qi){0, 0, 0, 0}, 0, 1,
+ 2, 3, 4, 5, 6, 7, 7, 7, 7, 7, 7, 7, 7, 7);
}
If you need to add more zeroes than the w
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a small documentation nit.
Comment at: docs/clang-tidy/checks/cert-msc51-cpp.rst:39
+
+ A comma-separated list of the type names which are disallowe
JonasToth marked an inline comment as not done.
JonasToth added inline comments.
Comment at:
test/clang-tidy/cppcoreguidelines-pro-bounds-pointer-arithmetic-pr36489.cpp:4
+
+// Fix PR36489 and detect auto-deduced value correctly.
+char *getPtr();
aaron.ballman w
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335876: [clang-format] Do not format raw string literals
inside a recognized function… (authored by krasimir, committed by
JonasToth updated this revision to Diff 153341.
JonasToth added a comment.
- address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48717
Files:
clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.cpp
test/clang-tidy/cppcoreguidelines-pro-bounds-poi
JonasToth marked 3 inline comments as done.
JonasToth added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.cpp:24
+ const auto AllPointerTypes = anyOf(
+ hasType(pointerType()),
hasType(autoType(hasDeducedType(pointerType();
Author: krasimir
Date: Thu Jun 28 09:58:24 2018
New Revision: 335876
URL: http://llvm.org/viewvc/llvm-project?rev=335876&view=rev
Log:
[clang-format] Do not format raw string literals inside a recognized function
with a non-recognized delimiter
Summary:
This stops clang-format from touching raw
krasimir created this revision.
Herald added a subscriber: cfe-commits.
This stops clang-format from touching raw string contents with unrecognized
delimiters inside recognized functions.
Unrecognized delimiters signal that the string might be special.
Repository:
rC Clang
https://reviews.ll
Sorry for the breakage. All issues should be fixed by now.
On Thu, Jun 28, 2018 at 8:26 AM Mikael Holmén
wrote:
> Hi,
>
> I get the same compilation error when I compile with clang 3.6.0.
>
> Revert?
>
> Regards,
> Mikael
>
> On 06/28/2018 03:16 AM, via cfe-commits wrote:
> > Hi, this commit al
Author: ioeric
Date: Thu Jun 28 09:51:12 2018
New Revision: 335874
URL: http://llvm.org/viewvc/llvm-project?rev=335874&view=rev
Log:
[clangd] Use log10 instead of the natural logrithm for usage boost.
Modified:
clang-tools-extra/trunk/clangd/Quality.cpp
clang-tools-extra/trunk/unittests/c
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D48727#1146873, @leonardchan wrote:
> Oh, having the same number of fractional bits is what leads to unsigned types
> having one bit of padding, and vice versa.
leonardchan added a comment.
Oh, having the same number of fractional bits is what leads to unsigned types
having one bit of padding, and vice versa.
If this flag is set to false, then the integral and fractional parts of the
unsigned types take up the whole bit width of the underlying scaled i
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
> It looks like the diagnostic options and few others were moved out from the
> control block in r297655 by Manman Ren. The header files are still part of
> the control block. The best I can d
rjmccall added a comment.
This all looks reasonable except that I think the interpretation is exactly
backwards, no? From the documentation on the option,
`-fpadding-on-unsigned-fixed-point` causes there to be padding, i.e. the
inverse of the old `SameFBits`; but the default value, comments, a
rjmccall added inline comments.
Comment at: include/clang/Basic/FixedPoint.h:23
+
+class FixedPointNumber {
+ public:
ebevhan wrote:
> rjmccall wrote:
> > The established naming convention here — as seen in `APInt`, `APFloat`,
> > `APValue`, etc. — would call th
leonardchan updated this revision to Diff 153335.
leonardchan added a comment.
Formatting and forgot to get rid of `Group` and `Flags`
Repository:
rC Clang
https://reviews.llvm.org/D48727
Files:
include/clang/Basic/LangOptions.def
include/clang/Basic/TargetInfo.h
include/clang/Driver/C
leonardchan added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:90
+ // by default.
+ bool SameFBits;
+
rjmccall wrote:
> Sorry for the extremely late review, but this really needs to be renamed.
> Please remember that other compiler maintaine
leonardchan created this revision.
leonardchan added reviewers: phosek, mcgrathr, jakehehrlich, rjmccall, ebevhan,
rsmith.
leonardchan added a project: clang.
- Rename the `-fsame-fbits` flag to `-fpadding-on-unsigned-fixed-point`
- Move the flag from a driver option to a cc1 option
- Rename the
simark added a comment.
FYI, I have uploaded my attempt at writing a unit test here:
https://reviews.llvm.org/D48726
I tried to make it as close as possible to the example in the bug report, but
don't manage to reproduce the bug.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/
v.g.vassilev added a comment.
It looks like the diagnostic options and few others were moved out from the
control block in r297655 by Manman Ren. The header files are still part of the
control block. The best I can do is buffer that information and print it out
last. Is that what we want?
Rep
simark created this revision.
Herald added subscribers: cfe-commits, jkorous, ioeric, ilya-biryukov.
This is not intended to be merged, it is my attempt at reproducing this:
https://bugs.llvm.org/show_bug.cgi?id=37963
using a unit test. However, I can't manage to get the faulty result
like this
1 - 100 of 202 matches
Mail list logo
