[PATCH] D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context.

rjmccall added a comment. In D55662#1346059 , @ahatanak wrote: > In D55662#1346055 , @rjmccall wrote: > > > I think you could just disable the diagnostic in an unevaluated context. > > > The call to `isUnevaluatedCo

[PATCH] D56241: expose a control flag for interger to pointer ext warning

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. ok, LGTM. Comment at: test/Sema/ext-typecheck-comparison-of-pointer-integer.c:1 +// RUN: %clang_cc1 -triple x86_64-apple-darwin -fsyntax-only -verify -Wpointer-inte

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny added a comment. For the record, another option is to actually fix other software not to call LD directly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56215/new/ https://reviews.llvm.org/D56215 ___ cfe-commits mailing list cfe-com

[PATCH] D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context.

ahatanak added a comment. In D55662#1346055 , @rjmccall wrote: > I think you could just disable the diagnostic in an unevaluated context. The call to `isUnevaluatedContext` in `ObjCPropertyOpBuilder::complete` returns false when the type of `auto __weak

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

erik.pilkington updated this revision to Diff 180196. erik.pilkington marked 3 inline comments as done. erik.pilkington added a comment. Mention `__has_attribute` and the ignored without -fobjc-arc thing. @aaron.ballman: Do you have any more thoughts here? CHANGES SINCE LAST ACTION https://re

[PATCH] D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context.

rjmccall added a comment. I think you could just disable the diagnostic in an unevaluated context. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55662/new/ https://reviews.llvm.org/D55662 ___ cfe-commits mailing list

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

rjmccall added a comment. Sorry, I keep coming up with small tweaks to the documentation. These should be the last of them, so if Aaron's also satisfied, feel free to commit with those modifications. Comment at: clang/docs/AutomaticReferenceCounting.rst:1788 +// ... + }

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader marked 2 inline comments as done. Kader added inline comments. Comment at: test/Sema/ext-typecheck-comparison-of-pointer-integer.c:1 +// RUN: %clang_cc1 -triple x86_64-apple-darwin -fsyntax-only -verify -Wpointer-integer-compare %s + lebedev.ri wrote: >

[PATCH] D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context.

ahatanak updated this revision to Diff 180186. ahatanak marked an inline comment as done. ahatanak added a comment. Do not record use of weak variables when the type of an auto variable is being deduced. I'm not sure creating an RAII class is the best way to silence the warning, but I haven't b

[PATCH] D56303: Handle case/default statements when simplifying boolean expressions

LegalizeAdulthood updated this revision to Diff 180184. LegalizeAdulthood added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56303/new/ https://reviews.llvm.org/D56303 Files: clang-tidy/readability/SimplifyBooleanExprCheck.cpp clang-tidy/readability/Simplif

[PATCH] D56303: Handle case/default statements when simplifying boolean expressions

LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: cfe-commits. LegalizeAdulthood added a project: clang-tools-extra. Structure this similarly to the way replaceCompoundReturnWithCondition works. - Add readability-simplify-boolean-expr test cases for case stmt - Add read

[PATCH] D52847: [clang-doc] Handle anonymous namespaces

juliehockett updated this revision to Diff 180182. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52847/new/ https://reviews.llvm.org/D52847 Files: clang-tools-extra/clang-doc/Representation.cpp clang-tools-extra/clang-doc/Representation.h clang-tools-extra/clang-doc/Serialize.cpp

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. In D56215#1345845 , @ruiu wrote: > Not sure what I understand the point, but as to make lld work on/for NetBSD, > I wonder if you can just add -L to the command line in the compiler > driver. Isn't a NetBSD triple passed to t

[PATCH] D56299: [OpenMP] Refactor const restriction for linear

jdenny created this revision. jdenny added a reviewer: ABataev. Herald added a subscriber: guansong. As discussed in D56113 , this patch refactors the implementation of the const restriction for linear to reuse a function introduced by D56113

[PATCH] D56188: Adopt SwiftABIInfo for WebAssembly.

This revision was automatically updated to reflect the committed changes. Closed by commit rC350372: Adopt SwiftABIInfo for WebAssembly. (authored by ddunbar, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56188/new/ https://reviews.llvm.org/D56188

r350372 - Adopt SwiftABIInfo for WebAssembly.

Author: ddunbar Date: Thu Jan 3 15:24:50 2019 New Revision: 350372 URL: http://llvm.org/viewvc/llvm-project?rev=350372&view=rev Log: Adopt SwiftABIInfo for WebAssembly. Summary: - This adopts SwiftABIInfo as the base class for WebAssemblyABIInfo, which is in keeping with what is done for other

r350371 - Fix MSVC visualizations for ActionResult and OpaquePtr

Author: mps Date: Thu Jan 3 15:24:39 2019 New Revision: 350371 URL: http://llvm.org/viewvc/llvm-project?rev=350371&view=rev Log: Fix MSVC visualizations for ActionResult and OpaquePtr Mainly just fixing buggy code. Also removed unnecessary visualizers for specializations of OpaquePtr Modified:

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

ruiu added a comment. Not sure what I understand the point, but as to make lld work on/for NetBSD, I wonder if you can just add -L to the command line in the compiler driver. Isn't a NetBSD triple passed to the compiler driver? If so, I wonder if you can add a few extra options when invoking th

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

erik.pilkington updated this revision to Diff 180154. erik.pilkington marked an inline comment as done. erik.pilkington added a comment. Remove support for parameter indices. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55865/new/ https://reviews.llvm.org/D55865 Files: clang/docs/Au

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. Actually I think that we can handle two cases witch a combination of proposals: - native mode - cross mode For the native mode we go for something like: #if defined(__NetBSD__) #define NATIVE_TARGET LLD_NETBSD #else ... and for cross mode read `argv[0]` to

r350363 - Fix check-hwasan with LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

Author: eugenis Date: Thu Jan 3 14:50:45 2019 New Revision: 350363 URL: http://llvm.org/viewvc/llvm-project?rev=350363&view=rev Log: Fix check-hwasan with LLVM_BUILD_EXTERNAL_COMPILER_RT=ON Add a forwarding target for check-hwasan in clang. Modified: cfe/trunk/runtime/CMakeLists.txt Modifi

[PATCH] D55955: Properly diagnose [[nodiscard]] on the body of a range-based for loop

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, this looks great. A couple of the changes to the tests look like the diagnostic output is slightly worse in some error recovery conditions, but generally this is a nice improvement.

r350361 - [cmake] Fix monorepo + LLVM_BUILD_EXTERNAL_COMPILER_RT=ON.

Author: eugenis Date: Thu Jan 3 14:41:10 2019 New Revision: 350361 URL: http://llvm.org/viewvc/llvm-project?rev=350361&view=rev Log: [cmake] Fix monorepo + LLVM_BUILD_EXTERNAL_COMPILER_RT=ON. In cmake 3.10.2, if (${VARIABLE_NAME}) seems to always be false no matter what documentation says (or ma

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. In D56215#1345695 , @ruiu wrote: > In D56215#1345417 , @joerg wrote: > > > Talking from the perspective of having had to deal with thousands of > > packages in pkgsrc over the years: it

[PATCH] D56288: [ELF] Do not enable 'new dtags' on NetBSD by default

ruiu added a comment. The compiler driver should pass -disable-new-tags to the linker, but let's discuss that in https://reviews.llvm.org/D56215 instead of here. Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56288/new/ https://reviews.llvm.org/D56288

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader updated this revision to Diff 180143. Kader added a comment. remove typo Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56241/new/ https://reviews.llvm.org/D56241 Files: include/clang/Basic/DiagnosticSemaKinds.td test/Misc/warning-flags.c test/Sema/ex

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader updated this revision to Diff 180142. Kader added a comment. address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56241/new/ https://reviews.llvm.org/D56241 Files: include/clang/Basic/DiagnosticSemaKinds.td test/Misc/warning-flags.c test/Se

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Thu, Jan 03, 2019 at 10:26:38PM +, Rui Ueyama via Phabricator via cfe-commits wrote: > I see there are pros and cons to not have host-specific config in ld. > That said, if other operating systems can live without host-specific > config in lld, why can't NetBSD do? I really don't like to be

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

ruiu added a comment. In D56215#1345417 , @joerg wrote: > Talking from the perspective of having had to deal with thousands of packages > in pkgsrc over the years: it is naive to believe that there isn't a lot of > software that calls the linker directly

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

jdenny added a comment. In D56113#1345529 , @jdenny wrote: > In D56113#1345238 , @ABataev wrote: > > > >>> By the way, is there any value to keeping the predetermined shared for > > >>> const if -openmp-version=3.1

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. On 03.01.2019 23:15, Joerg Sonnenberger wrote: > On Thu, Jan 03, 2019 at 09:38:49PM +, Kamil Rytarowski via Phabricator via cfe-commits wrote: >> I think that this place is not the right place to bash GNU ld for performance issues. > > I didn't. >

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Thu, Jan 03, 2019 at 09:38:49PM +, Kamil Rytarowski via Phabricator via cfe-commits wrote: > I think that this place is not the right place to bash GNU ld for performance > issues. I didn't. > I will refer just to slides and paper from Ian Lance Taylor to get overview > why it is unacce

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

erik.pilkington marked an inline comment as done. erik.pilkington added inline comments. Comment at: clang/docs/AutomaticReferenceCounting.rst:1779 +externally-retained, unless the variable was explicitly qualified with +``__strong``. For instance, ``first_param`` is externally-r

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

rjmccall added inline comments. Comment at: clang/docs/AutomaticReferenceCounting.rst:1749 +instance, capturing an externally-retained variable in a block will retain the +value when capturing it, and release it when the block is destroyed. + Nit-picks: `it's` sh

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. On Thu, Jan 03, 2019 at 08:31:53PM +, Kamil Rytarowski via Phabricator via cfe-commits wrote: > krytarowski added a comment. > > On 03.01.2019 21:19, Joerg Sonnenberger wrote: > >> On Thu, Jan 03, 2019 at 06:34:22PM +, Kamil Rytarowski via Phabrica

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

erik.pilkington updated this revision to Diff 180131. erik.pilkington marked 4 inline comments as done. erik.pilkington added a comment. Address John's comments. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55865/new/ https://reviews.llvm.org/D55865 Files: clang/docs/Automat

[PATCH] D56188: Adopt SwiftABIInfo for WebAssembly.

rjmccall added a comment. I don't mind you committing it like this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56188/new/ https://reviews.llvm.org/D56188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. I think that ifdefining the linker options with `__NetBSD__` is no-go. In D56215#1345563 , @mgorny wrote: > We've discussed this a bit and given other changes we need to do, and I see > pretty much three options here: > > 1.

[PATCH] D54450: Get the correct range of tokens for preprocessor conditions

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. To me this looks like a reasonably straight-forward refactoring. I'm guessing the initial code had good test coverage, and none of those tests break; and the new code appears to have re

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

alexey.lapshin added a comment. Thank you! Aaron, Could you integrate this patch, please? I do not have commit access yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55710/new/ https://reviews.llvm.org/D55710 ___ cfe-commits mailing li

[PATCH] D54450: Get the correct range of tokens for preprocessor conditions

vmiklos added a comment. Could you please review this one? It would be especially helpful, due to the depending other review. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54450/new/ https://reviews.llvm.org/D54450 ___ cfe-commits

[PATCH] D56188: Adopt SwiftABIInfo for WebAssembly.

ddunbar added a comment. In D56188#1343667 , @rjmccall wrote: > ...although it might be reasonable to extract the method implementations on > `DefaultABIInfo` as helper functions so that the code can be reused without > requiring a particular inheritance

[PATCH] D56241: expose a control flag for interger to pointer ext warning

lebedev.ri added inline comments. Comment at: test/Sema/ext-typecheck-comparison-of-pointer-integer.c:1 +// RUN: %clang_cc1 -triple x86_64-apple-darwin -fsyntax-only -verify -Wpointer-integer-compare %s + I guess you want a run-line with no flag, this runline,

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added a comment. In D56113#1345588 , @jdenny wrote: > In D56113#1345578 , @ABataev wrote: > > > >>> By the way, LangOpts.OpenMP currently defaults to 0. Should it? > > >> > > >> Yes, it means it is disable

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

jdenny added a comment. In D56113#1345578 , @ABataev wrote: > >>> By the way, LangOpts.OpenMP currently defaults to 0. Should it? > >> > >> Yes, it means it is disabled by default. > > > > Ah, it becomes 1 when we have `-fopenmp` but not `-fopenmp-versi

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Thu, Jan 03, 2019 at 08:31:53PM +, Kamil Rytarowski via Phabricator via cfe-commits wrote: > krytarowski added a comment. > > On 03.01.2019 21:19, Joerg Sonnenberger wrote: > > > On Thu, Jan 03, 2019 at 06:34:22PM +, Kamil Rytarowski via Phabricator > > via cfe-commits wrote: > > >

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

On Thu, Jan 03, 2019 at 05:01:00PM +, Ximin Luo via cfe-commits wrote: > My patch that Roman quoted in the email below was an additional > mechanism to set -fmacro-prefix-map and -fdebug-prefix-map via an > environment variable. This was not accepted into GCC because they are > (in summary) all

[PATCH] D56288: [ELF] Do not enable 'new dtags' on NetBSD by default

krytarowski added a comment. We want to keep it disabled by default on NetBSD.. but it would be to keep dynamic detection of target NetBSD rather than hardcoded ifdef. GNU ld sets it by default to false, following it would be the easiest option. Repository: rLLD LLVM Linker CHANGES SINCE LA

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added a comment. In D56113#1345564 , @jdenny wrote: > In D56113#1345535 , @ABataev wrote: > > > In D56113#1345529 , @jdenny wrote: > > > > > In D56113#1345238

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader updated this revision to Diff 180125. Kader added a comment. added missing test file Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56241/new/ https://reviews.llvm.org/D56241 Files: include/clang/Basic/DiagnosticSemaKinds.td test/Misc/warning-flags.c

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader added a comment. @lebedev.ri Thanks for the quick review ; > Perhaps there should be a test for this flag specifically? I am not really familiar with this part of the code base, but it seems that the warnings is already tested in both test/Sema/Compare.c and test/SemaCXX/compare.cpp. I

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

jdenny added a comment. In D56113#1345535 , @ABataev wrote: > In D56113#1345529 , @jdenny wrote: > > > In D56113#1345238 , @ABataev wrote: > > > > > >>> By the way, is there

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny added a comment. We've discussed this a bit and given other changes we need to do, and I see pretty much three options here: 1. We hardcode stuff under `defined(__NetBSD__)` which kinda solves the problem, except lld won't be very cross-friendly. 2. We try to do conditionals based on tri

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader updated this revision to Diff 180124. Kader added a comment. Added test case for C_lang Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56241/new/ https://reviews.llvm.org/D56241 Files: include/clang/Basic/DiagnosticSemaKinds.td test/Misc/warning-flags.c

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. On 03.01.2019 21:19, Joerg Sonnenberger wrote: > On Thu, Jan 03, 2019 at 06:34:22PM +, Kamil Rytarowski via Phabricator > via cfe-commits wrote: > >> krytarowski added a comment. >> >> Actually I find it frustrating and unfair as GNU ld doesn't have builtin >>

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Thu, Jan 03, 2019 at 06:58:41PM +, Kamil Rytarowski via Phabricator wrote: > But the result is that we don't have GNU gold either and are stuck with > 40min linking times of LLVM. It's destructive to productivity and > damages any LLVM related development. The reason noone cared much about

Re: [PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

On Thu, Jan 03, 2019 at 06:34:22PM +, Kamil Rytarowski via Phabricator via cfe-commits wrote: > krytarowski added a comment. > > Actually I find it frustrating and unfair as GNU ld doesn't have builtin > knowledge either.. it's passed with gross 'super hack' comments from build > scripts...

[PATCH] D56288: [ELF] Do not enable 'new dtags' on NetBSD by default

mgorny created this revision. mgorny added reviewers: ruiu, krytarowski, joerg. Herald added subscribers: llvm-commits, arichardson, emaste. Herald added a reviewer: espindola. NetBSD strongly prefers using 'old' dtag (RPATH) over Linux-specific RUNPATH, and did not support the latter until very r

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: test/Sema/pragma-pipeline.cpp:3 + +#pragma clang loop pipeline(disable) /* expected-error {{expected unqualified-id}} */ +int main() { --

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added a comment. In D56113#1345529 , @jdenny wrote: > In D56113#1345238 , @ABataev wrote: > > > >>> By the way, is there any value to keeping the predetermined shared for > > >>> const if -openmp-version=3.

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny updated this revision to Diff 180121. mgorny edited the summary of this revision. mgorny added a comment. Removed non-x86. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56215/new/ https://reviews.llvm.org/D56215 Files: ELF/Driver.cpp ELF/Driver.h Index: ELF/Driver.h ==

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

jdenny added a comment. In D56113#1345238 , @ABataev wrote: > >>> By the way, is there any value to keeping the predetermined shared for > >>> const if -openmp-version=3.1 or earlier? > >> > >> Yes, you can check for the value of `LangOpts.OpenMP`. For O

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: ELF/Driver.cpp:369 +void LinkerDriver::appendDefaultSearchPaths() { +#if defined(__NetBSD__) + // NetBSD driver relies on the linker knowing the default search paths. krytarowski

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added inline comments. Comment at: ELF/Driver.cpp:369 +void LinkerDriver::appendDefaultSearchPaths() { +#if defined(__NetBSD__) + // NetBSD driver relies on the linker knowing the default search paths. is it possible to use some Triple NetBSD target

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added inline comments. Comment at: ELF/Driver.cpp:377 + break; +case EM_MIPS: + if (Config->EKind == ELF64LEKind || Config->EKind == ELF64BEKind) Please drop MIPS/PPC for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56215

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

alexey.lapshin marked an inline comment as done. alexey.lapshin added inline comments. Comment at: test/Sema/pragma-pipeline.cpp:3 + +#pragma clang loop pipeline(disable) /* expected-error {{expected unqualified-id}} */ +int main() { aaron.ballman wrote: > I thi

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny updated this revision to Diff 180114. mgorny edited the summary of this revision. mgorny added a comment. Herald added subscribers: atanasyan, sdardis. Updated to use clang's libdir logic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56215/new/ https://reviews.llvm.org/D56215 F

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. We will prepare a patch for i386 x86_64 only for now. Until we will get lld fully functional on NetBSD/amd64 we will skip other architectures. Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56215/new/ https://reviews.llvm.org/

[PATCH] D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends

arphaman updated this revision to Diff 180110. arphaman added a comment. Do not annotate one token `[ ]` expressions as Objective-C message sends as suggested by Duncan. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56226/new/ https://reviews.llvm.org/D56226 Files: lib/Format/T

[PATCH] D17741: adds __FILE_BASENAME__ builtin macro

kristina added a comment. I should add that this is not just about reproducible builds but about code size as mentioned by @NSProgrammer. There are ways to cheat with builtins but the problem is, entire __FILE__ string is still emitted into read-only data, despite the constexpressiveness of the

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

joerg added a comment. Talking from the perspective of having had to deal with thousands of packages in pkgsrc over the years: it is naive to believe that there isn't a lot of software that calls the linker directly for various reasons. As such, it is very important to have a useful configurati

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay added a comment. let me look further into that, it works for std::function but not for const std::function or std::function &, const std::function & CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55433/new/ https://reviews.llvm.org/D55433 _

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. In D56215#1345400 , @ruiu wrote: > Joerg, what is special about NetBSD? Nothing. But the result is that we don't have GNU gold either and are stuck with 40min linking times of LLVM. It's destructive to productivity and dama

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

ruiu added a comment. I sympathize and understand your frustration, but I don't know what I can do to you. The thing that lld doesn't have host-specific config is a policy matter we've been maintaining so far for all operating systems. I don't think NetBSD should be the only exception of the po

[PATCH] D56271: [SemaCXX] Fix ICE for unexpanded parameter pack

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good, thank you! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56271/new/ https://reviews.llvm.org/D56271

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added a comment. In D56113#1345372 , @jdenny wrote: > In D56113#1345337 , @ABataev wrote: > > > > In D56113#1345238 , @ABataev > > > wrote: > > > > > >> In D56113#1

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

jdenny added a comment. In D56113#1345337 , @ABataev wrote: > > In D56113#1345238 , @ABataev wrote: > > > >> In D56113#1345232 , @jdenny wrote: > >> > >> > In D56113#1345047

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. Actually I find it frustrating and unfair as GNU ld doesn't have builtin knowledge either.. it's passed with gross 'super hack' comments from build scripts... but we are forced to push it to lld in order to move on. Repository: rLLD LLVM Linker CHANGES SINCE LAS

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. It's an option but Joerg insists on using lld standalone. Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56215/new/ https://reviews.llvm.org/D56215 ___ cfe-commits mailing list cfe

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

ruiu added a comment. As you can see, lld doesn't really have any host-dependent knowledge so far, even though there are a few OSes that use lld as the default linker. We've added host-dependent knowledge to the compiler driver instead of to the linker for various operating systems. I guess tha

[PATCH] D56273: Validate -add-plugin arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rC350340: Validate -add-plugin arguments. (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D56273?vs=180085&id=180099#toc Repository: rC Clang CHANGES SINCE LAST AC

r350340 - Validate -add-plugin arguments.

Author: nico Date: Thu Jan 3 10:26:06 2019 New Revision: 350340 URL: http://llvm.org/viewvc/llvm-project?rev=350340&view=rev Log: Validate -add-plugin arguments. -plugin already prints an error if the name of an unknown plugin is passed. -add-plugin used to silently ignore that, now it errors to

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added a comment. In D56113#1345336 , @jdenny wrote: > In D56113#1345238 , @ABataev wrote: > > > >>> By the way, is there any value to keeping the predetermined shared for > > >>> const if -openmp-version=3.

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

jdenny added a comment. In D56113#1345238 , @ABataev wrote: > >>> By the way, is there any value to keeping the predetermined shared for > >>> const if -openmp-version=3.1 or earlier? > >> > >> Yes, you can check for the value of `LangOpts.OpenMP`. For O

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. In D56215#1345326 , @ruiu wrote: > In D56215#1344279 , @krytarowski > wrote: > > > In D56215#1344233 , @ruiu wrote: > > > > > lld's driver is in

[PATCH] D56273: Validate -add-plugin arguments.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56273/new/ https://reviews.llvm.org/D56273 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

ruiu added a comment. In D56215#1344279 , @krytarowski wrote: > In D56215#1344233 , @ruiu wrote: > > > lld's driver is intentionally designed to be agnostic of the host that the > > linker is running for the reason

[PATCH] D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds

ArnaudBienner added a comment. OK, thanks Serge! :) For the record, I updated the patch one last time after it was accepted to remove my change to constant-expression-cxx1y.cpp since someone else did the same change in a separate commit meanwhile. Repository: rC Clang CHANGES SINCE LAST AC

[PATCH] D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds

This revision was automatically updated to reflect the committed changes. Closed by commit rC350335: Make -Wstring-plus-int warns even if when the result is not out of bounds (authored by abien, committed by ). Changed prior to commit: https://reviews.llvm.org/D55382?vs=180075&id=180093#toc Re

r350335 - Make -Wstring-plus-int warns even if when the result is not out of bounds

Author: abien Date: Thu Jan 3 09:45:28 2019 New Revision: 350335 URL: http://llvm.org/viewvc/llvm-project?rev=350335&view=rev Log: Make -Wstring-plus-int warns even if when the result is not out of bounds Summary: Patch by Arnaud Bienner Reviewers: sylvestre.ledru, thakis, serge-sans-paille Re

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

aaron.ballman added inline comments. Comment at: test/Sema/pragma-pipeline.cpp:3 + +#pragma clang loop pipeline(disable) /* expected-error {{expected unqualified-id}} */ +int main() { I think this error is pretty unfortunate -- it doesn't really help the user to

[PATCH] D56090: Add a matcher for members of an initializer list expression

aaron.ballman added a reviewer: klimek. aaron.ballman added a comment. Adding Manuel for the `hasArg()` questions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56090/new/ https://reviews.llvm.org/D56090 ___ cfe-commits mailing list cfe-com

[PATCH] D56090: Add a matcher for members of an initializer list expression

aaron.ballman added a subscriber: klimek. aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3527 + return N < Node.getNumInits() && + InnerMatcher.matches(*Node.getInit(N)->IgnoreParenImpCasts(), Finder, +

[PATCH] D56090: Add a matcher for members of an initializer list expression

hwright added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3527 + return N < Node.getNumInits() && + InnerMatcher.matches(*Node.getInit(N)->IgnoreParenImpCasts(), Finder, + Builder); aaron.ballman wr

[PATCH] D56090: Add a matcher for members of an initializer list expression

hwright updated this revision to Diff 180089. hwright marked an inline comment as done. hwright added a comment. Added tests, update docs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56090/new/ https://reviews.llvm.org/D56090 Files: docs/LibASTMatchersReference.html include/clang

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

Hi all, more strict interpretations of reproducible builds want build paths to not appear in the final output *regardless of the build location* and so /tmp/build would not be appropriate. Rough justification is that we want different people building under different starting conditions to be abl

[PATCH] D55932: [Sema] Simplfy static_assert diagnostic code.

aaron.ballman added inline comments. Comment at: test/SemaCXX/static-assert.cpp:130 static_assert(std::is_same()), int>::value, "message"); -// expected-error@-1{{static_assert failed due to requirement 'std::is_same, int>::value' "message"}} +// expected-error@-1{{static_asse

[PATCH] D55933: [Sema] Do not print default template parameters.

Quuxplusone added inline comments. Comment at: lib/AST/TypePrinter.cpp:179 +// `X` gets canonicalized to `X`. We disable +// canonicalization so that `printTag()`` can see the template parameters as +// written. Nit: there's an extra ` on this line.

[PATCH] D47817: [compiler-rt] [sanitizer_common] Remove support for tirpc/rpc/xdr.h

mgorny added a comment. @ygribov, ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47817/new/ https://reviews.llvm.org/D47817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

  1   2   >