[PATCH] D60455: [SYCL] Add support for SYCL device attributes

keryell added a comment. In D60455#1470402 , @Anastasia wrote: > > In the interest of speeding up the upstreaming work, would you be able to > highlight the differences and similarity at least for SYCL and OpenCL kernel > modes? Not sure if you are f

r358733 - Fix overly-long line after r358731.

Author: rsmith Date: Thu Apr 18 19:46:50 2019 New Revision: 358733 URL: http://llvm.org/viewvc/llvm-project?rev=358733&view=rev Log: Fix overly-long line after r358731. Modified: cfe/trunk/lib/AST/Decl.cpp Modified: cfe/trunk/lib/AST/Decl.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/tru

r358731 - Fix typo in function name [NFC]

Author: tamur Date: Thu Apr 18 19:15:57 2019 New Revision: 358731 URL: http://llvm.org/viewvc/llvm-project?rev=358731&view=rev Log: Fix typo in function name [NFC] Modified: cfe/trunk/lib/AST/Decl.cpp Modified: cfe/trunk/lib/AST/Decl.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/li

r358729 - [analyzer] Fix -Wunused-local-typedef after rC358695

Author: maskray Date: Thu Apr 18 18:54:36 2019 New Revision: 358729 URL: http://llvm.org/viewvc/llvm-project?rev=358729&view=rev Log: [analyzer] Fix -Wunused-local-typedef after rC358695 Modified: cfe/trunk/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp Modified: cfe/trunk/lib/StaticAnalyze

[PATCH] D60899: [analyzer] Unbreak body farms in presence of multiple declarations.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, jfb, a.sidorin, JDevlieghere, szepet, kristof.beyls, javed.absar. Herald added a project:

[PATCH] D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function.

NoQ updated this revision to Diff 195851. NoQ marked an inline comment as done. NoQ added a comment. Add space before `\`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60808/new/ https://reviews.llvm.org/D60808 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/PathDiagnosti

[PATCH] D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function.

NoQ updated this revision to Diff 195850. NoQ added a comment. Separate the canonicalization change that unbreaks body farms into a separate patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60808/new/ https://reviews.llvm.org/D60808 Files: clang/include/clang/StaticAnalyzer/Core

r358724 - Add header guard to Reusables.h [NFC]

Author: tamur Date: Thu Apr 18 17:42:54 2019 New Revision: 358724 URL: http://llvm.org/viewvc/llvm-project?rev=358724&view=rev Log: Add header guard to Reusables.h [NFC] Modified: cfe/trunk/unittests/StaticAnalyzer/Reusables.h Modified: cfe/trunk/unittests/StaticAnalyzer/Reusables.h URL: ht

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

hfinkel added a comment. In D59712#1472544 , @jdenny wrote: > In D59712#1472358 , @hfinkel wrote: > > > > I've never tried running the other tests you mention, for any patch. I > > > thought people normally left t

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny added a comment. In D59712#1472358 , @hfinkel wrote: > > I've never tried running the other tests you mention, for any patch. I > > thought people normally left those to the bots. Should this patch be > > handled differently? > > We have a lot o

[PATCH] D41284: [Concepts] Associated constraints infrastructure.

rsmith added inline comments. Comment at: include/clang/AST/DeclTemplate.h:177 + /// conjunction ("and"). + llvm::SmallVector getAssociatedConstraints() const; + Returning a `SmallVector` by value is not idiomatic. If you need to make a copy here, you should t

[PATCH] D44352: [Concepts] Constrained template parameters

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. This needs revision to reflect changes between the Concepts TS and C++20. In particular, only the name of a //type-concept// can be used to declare a //template-parameter// in the ne

[PATCH] D60742: [analyzer] RegionStore: Enable loading default bindings from variables.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358722: [analyzer] Make default bindings to variables actually work. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D60742?vs=195500&id=195842#toc Repository:

r358722 - [analyzer] Make default bindings to variables actually work.

Author: dergachev Date: Thu Apr 18 16:35:56 2019 New Revision: 358722 URL: http://llvm.org/viewvc/llvm-project?rev=358722&view=rev Log: [analyzer] Make default bindings to variables actually work. Default RegionStore bindings represent values that can be obtained by loading from anywhere within t

[PATCH] D60739: [analyzer] NFC: Re-use reusable unittest mocks.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358720: [analyzer] NFC: Make reusable unittest mocks reusable. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

r358720 - [analyzer] NFC: Make reusable unittest mocks reusable.

Author: dergachev Date: Thu Apr 18 16:24:50 2019 New Revision: 358720 URL: http://llvm.org/viewvc/llvm-project?rev=358720&view=rev Log: [analyzer] NFC: Make reusable unittest mocks reusable. Put them in a header for other Analyzer unittests to include. Differential Revision: https://reviews.llvm

[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358719: [analyzer] NFC: MoveChecker: Refactor tests to use -verify=prefix. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

r358719 - [analyzer] NFC: MoveChecker: Refactor tests to use -verify=prefix.

Author: dergachev Date: Thu Apr 18 16:17:58 2019 New Revision: 358719 URL: http://llvm.org/viewvc/llvm-project?rev=358719&view=rev Log: [analyzer] NFC: MoveChecker: Refactor tests to use -verify=prefix. This -verify=prefix feature is quite underrated. Differential Revision: https://reviews.llvm.

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

NoQ updated this revision to Diff 195835. NoQ added a comment. Fall back to the previous `std::vector>` approach. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58367/new/ https://reviews.llvm.org/D58367 Files: clang/include/clang/Analysis/ProgramPoint.h clang/include/clang/StaticAn

[PATCH] D60892: Modules: Search for a visible definition of the decl context when computing visibility of a default template parameter

dblaikie created this revision. dblaikie added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. The code is/was already correct for the case where a parameter is a parameter of its enclosing lexical DeclContext (functions and classes). But for other templa

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

hfinkel added a comment. In D59712#1472318 , @jdenny wrote: > In D59712#1469760 , @lebedev.ri > wrote: > > > In D59712#1469693 , @jdenny wrote: > > > > > In D59712#1469392 <

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm with a minor whitespace issue Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1972 } - CI->setMetadata("heapallocsite", node); Please revert the white spa

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny added a comment. In D59712#1472342 , @lebedev.ri wrote: > In D59712#1472318 , @jdenny wrote: > > > For me, check-all's success is not affected by the current patch. I built > > all subprojects except llgo,

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: llvm/test/CodeGen/X86/label-heapallocsite.ll:1 +; RUN: llc -O0 < %s | FileCheck %s +; FIXME: Add test for llc with optimizations once it is implemented. hans wrote: > Does llc ha

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

lebedev.ri resigned from this revision. lebedev.ri added a comment. In D59712#1472318 , @jdenny wrote: > In D59712#1469760 , @lebedev.ri > wrote: > > > In D59712#1469693 , @

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang updated this revision to Diff 195821. akhuang marked 2 inline comments as done. akhuang added a comment. - Changed test case back to original Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60800/new/ https://reviews.llvm.org/D60800 Files:

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny added a comment. In D59712#1469760 , @lebedev.ri wrote: > In D59712#1469693 , @jdenny wrote: > > > In D59712#1469392 , @lebedev.ri > > wrote: > > > > > In D59712#1469

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

NoQ added a comment. In D58367#1462026 , @Szelethus wrote: > Hmmm, interesting. Could there be an issue with `NoteTag` not being trivially > destructible? Yeah, i think you're right. Which means we cannot allocate it in a `BumpPtrAllocator`. Reposito

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang updated this revision to Diff 195818. akhuang marked 2 inline comments as done. akhuang added a comment. - Pass void metadata as null DIType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60800/new/ https://reviews.llvm.org/D60800 Files:

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

jdenny added a comment. In D60845#1472291 , @rsmith wrote: > In D60845#1471741 , @jdenny wrote: > > > In D60845#1471002 , @rsmith wrote: > > > > > I've seen a few projects ou

r358713 - [c++2a] Add semantic support for private module fragments.

Author: rsmith Date: Thu Apr 18 14:12:54 2019 New Revision: 358713 URL: http://llvm.org/viewvc/llvm-project?rev=358713&view=rev Log: [c++2a] Add semantic support for private module fragments. Added: cfe/trunk/test/CXX/basic/basic.link/p2.cpp cfe/trunk/test/CXX/module/module.interface/

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

rsmith added a comment. In D60845#1471741 , @jdenny wrote: > In D60845#1471002 , @rsmith wrote: > > > I've seen a few projects outside of clang use `-verify` mode for their own > > testing of various things. > > >

[PATCH] D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

sammccall added inline comments. Comment at: clang-tools-extra/unittests/clangd/HeadersTests.cpp:220 + BarHeader = testPath("sub/bar.h"); + EXPECT_EQ(calculate(BarHeader), "\"sub/bar.h\""); } ormris wrote: > sammccall wrote: > > ormris wrote: > > > Quick nit:

[PATCH] D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function.

NoQ added a comment. (also fix typo in the function name) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60808/new/ https://reviews.llvm.org/D60808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function.

NoQ updated this revision to Diff 195810. NoQ added a comment. This revision is now accepted and ready to land. Don't canonicalize the decl in the body farm. The decl supplied by the AnalysisDeclContext is already the correct one (and not necessarily the canonical one). Keep the defensive behav

[PATCH] D60886: [OpenMP][NFC] Fix requires target test.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC358711: [OpenMP][NFC] Fix requires target test. (authored by gbercea, committed by ). Repository: rC Clang CHANGES SIN

r358711 - [OpenMP][NFC] Fix requires target test.

Author: gbercea Date: Thu Apr 18 13:34:43 2019 New Revision: 358711 URL: http://llvm.org/viewvc/llvm-project?rev=358711&view=rev Log: [OpenMP][NFC] Fix requires target test. Summary: Fix requires target test. Reviewers: ABataev Subscribers: guansong, jdoerfert, cfe-commits Tags: #clang Diffe

[PATCH] D60886: [OpenMP][NFC] Fix requires target test.

gtbercea created this revision. gtbercea added a reviewer: ABataev. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. Fix requires target test. Repository: rC Clang https://reviews.llvm.org/D60886 Files: test/OpenMP/requires_target_messages.cpp In

[PATCH] D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

ormris added inline comments. Comment at: clang-tools-extra/unittests/clangd/HeadersTests.cpp:220 + BarHeader = testPath("sub/bar.h"); + EXPECT_EQ(calculate(BarHeader), "\"sub/bar.h\""); } sammccall wrote: > ormris wrote: > > Quick nit: This test won't work on

[PATCH] D60853: clang-format converts a keyword macro definition to a macro function

This revision was automatically updated to reflect the committed changes. Closed by commit rL358710: [clang-format] Fix incorrect formatting of keyword macro definition (authored by owenpan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

rnk added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1966 + QualType PointeeTy = D.getTypePtr()->getPointeeType(); + llvm::DIType *DI = getOrCreateType(PointeeTy, getOrCreateFile(Loc)); + CI->setMetadata("heapallocsite", DI); akhuang wrote:

r358710 - [clang-format] Fix incorrect formatting of keyword macro definition

Author: owenpan Date: Thu Apr 18 13:17:08 2019 New Revision: 358710 URL: http://llvm.org/viewvc/llvm-project?rev=358710&view=rev Log: [clang-format] Fix incorrect formatting of keyword macro definition See PR39719 Differential Revision: https://reviews.llvm.org/D60853 Modified: cfe/trunk/li

[PATCH] D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

sammccall added inline comments. Comment at: clang-tools-extra/unittests/clangd/HeadersTests.cpp:220 + BarHeader = testPath("sub/bar.h"); + EXPECT_EQ(calculate(BarHeader), "\"sub/bar.h\""); } ormris wrote: > Quick nit: This test won't work on Windows as it onl

r358709 - [OpenMP] Add checks for requires and target directives.

Author: gbercea Date: Thu Apr 18 12:53:43 2019 New Revision: 358709 URL: http://llvm.org/viewvc/llvm-project?rev=358709&view=rev Log: [OpenMP] Add checks for requires and target directives. Summary: The requires directive containing target related clauses must appear before any target region in

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358709: [OpenMP] Add checks for requires and target directives. (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D60875?vs=195793&id=195803#toc Repository: rC C

[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:7956 +// If using unified memory, no need to do the mappings. +if (CGF.CGM.getOpenMPRuntime().hasUnifiedAddressingSupport()) + return; Hmm, what about regular declare target d

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: test/OpenMP/openmp_offload_registration.cpp:40 +// CHECK: ret void +// CHECK: declare void @__tgt_register_requires(i64) + ABataev wrote: > Why do you need this check? Again, this check is not required

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

jdenny added a comment. In D59168#1470578 , @phosek wrote: > In D59168#1469186 , @jdenny wrote: > > > > > > I was also thinking about alternative names for the library path, > specifically for headers we use `inclu

r358705 - [LibTooling] Fix build breakage from commit 7b7ce6683ee.

Author: ymandel Date: Thu Apr 18 12:19:01 2019 New Revision: 358705 URL: http://llvm.org/viewvc/llvm-project?rev=358705&view=rev Log: [LibTooling] Fix build breakage from commit 7b7ce6683ee. On configurations with -Werror,-Wmissing-field-initializers, the commit does not compile. This commit fix

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 ___ cfe-commits ma

[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. This patch avoids the emission of maps for target link variables when unified memory is present. Repository: rC Clang https:/

[PATCH] D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

ormris added inline comments. Comment at: clang-tools-extra/unittests/clangd/HeadersTests.cpp:220 + BarHeader = testPath("sub/bar.h"); + EXPECT_EQ(calculate(BarHeader), "\"sub/bar.h\""); } Quick nit: This test won't work on Windows as it only tests for POSIX-s

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea updated this revision to Diff 195793. gtbercea added a comment. - Lower case. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaOpenMP.cpp test/O

[PATCH] D60872: Add new warning knob for unknown attribute namespaces

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Seems pretty good to me - if you'd like to wait for more/other feedback from @rsmith or the like, that's OK too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60872/new/ https://

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang updated this revision to Diff 195791. axzhang added a comment. Simplify tests and fix issues with Options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/modernize/MakeSmartPt

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang marked 3 inline comments as done. axzhang added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:69 + IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)), + IgnoreListInit(Options.get("IgnoreListInit", false)) {} ---

[PATCH] D60163: [ThinLTO] Handle -fno-builtin* options for distributed backends

tejohnson added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60163/new/ https://reviews.llvm.org/D60163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D60872: Add new warning knob for unknown attribute namespaces

aaron.ballman updated this revision to Diff 195790. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60872/new/ https://reviews.llvm.org/D60872 Files: include/clang/Basic/Dia

[PATCH] D60872: Add new warning knob for unknown attribute namespaces

aaron.ballman marked 7 inline comments as done. aaron.ballman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:8623 + } else if (A.hasScope()) { +#define ATTR(A) +#define ATTR_NAMESPACE(A) .Case(#A, false) dblaikie wrote: > dblaikie wrote: > > Not su

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

hintonda added inline comments. Comment at: clang-tidy/abseil/AbseilTidyModule.cpp:77 +Opts["abseil-make-unique.MakeSmartPtrFunction"] = "absl::make_unique"; +Opts["abseil-make-unique.IgnoreListInit"] = true; +return Options; This is defined as `typed

[PATCH] D60872: Add new warning knob for unknown attribute namespaces

dblaikie added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:8623 + } else if (A.hasScope()) { +#define ATTR(A) +#define ATTR_NAMESPACE(A) .Case(#A, false) dblaikie wrote: > Not sure how it's done elsewhere - but I'd sink these #defines down to > immed

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

This revision was automatically updated to reflect the committed changes. ymandel marked 2 inline comments as done. Closed by commit rL358697: [LibTooling] Extend Transformer to support multiple simultaneous changes. (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added

r358697 - [LibTooling] Extend Transformer to support multiple simultaneous changes.

Author: ymandel Date: Thu Apr 18 10:52:24 2019 New Revision: 358697 URL: http://llvm.org/viewvc/llvm-project?rev=358697&view=rev Log: [LibTooling] Extend Transformer to support multiple simultaneous changes. Summary: This revision allows users to specify independent changes to multiple (related)

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1966 + QualType PointeeTy = D.getTypePtr()->getPointeeType(); + llvm::DIType *DI = getOrCreateType(PointeeTy, getOrCreateFile(Loc)); + CI->setMetadata("heapallocsite", DI); hans wrote

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang updated this revision to Diff 195783. akhuang marked 4 inline comments as done. akhuang added a comment. Removed extraneous information from test; changed type to DIType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60800/new/ https://revie

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

richard.townsend.arm added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1090 +FI.getReturnInfo().setSRetAfterThis(isInstanceMethod); +FI.getReturnInfo().setInReg(isAArch64 && isIndirectReturn); Based on https://reviews.llvm.org/D60348 -

[PATCH] D59459: [analyzer][NFC] Prefer binary searches in CheckerRegistry

This revision was automatically updated to reflect the committed changes. Closed by commit rL358695: [analyzer][NFC] Prefer binary searches in CheckerRegistry (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r358696 - [CodeComplete] Remove obsolete isOutputBinary().

Author: sammccall Date: Thu Apr 18 10:35:55 2019 New Revision: 358696 URL: http://llvm.org/viewvc/llvm-project?rev=358696&view=rev Log: [CodeComplete] Remove obsolete isOutputBinary(). Summary: It's never set to true. Its only effect would be to set stdout to binary mode. Hopefully we have better

[PATCH] D59458: [analyzer][NFC] Clang-format CheckerRegistry

This revision was automatically updated to reflect the committed changes. Closed by commit rC358694: [analyzer][NFC] Clang-format CheckerRegistry (authored by Szelethus, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59458/new/ https://reviews.llvm.

[clang-tools-extra] r358696 - [CodeComplete] Remove obsolete isOutputBinary().

Author: sammccall Date: Thu Apr 18 10:35:55 2019 New Revision: 358696 URL: http://llvm.org/viewvc/llvm-project?rev=358696&view=rev Log: [CodeComplete] Remove obsolete isOutputBinary(). Summary: It's never set to true. Its only effect would be to set stdout to binary mode. Hopefully we have better

r358694 - [analyzer][NFC] Clang-format CheckerRegistry

Author: szelethus Date: Thu Apr 18 10:32:51 2019 New Revision: 358694 URL: http://llvm.org/viewvc/llvm-project?rev=358694&view=rev Log: [analyzer][NFC] Clang-format CheckerRegistry Differential Revision: https://reviews.llvm.org/D59458 Modified: cfe/trunk/include/clang/StaticAnalyzer/Fronten

r358695 - [analyzer][NFC] Prefer binary searches in CheckerRegistry

Author: szelethus Date: Thu Apr 18 10:34:45 2019 New Revision: 358695 URL: http://llvm.org/viewvc/llvm-project?rev=358695&view=rev Log: [analyzer][NFC] Prefer binary searches in CheckerRegistry Differential Revision: https://reviews.llvm.org/D59459 Modified: cfe/trunk/include/clang/StaticAna

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358691: [LibTooling] Add Stencil library for format-string style codegen. (authored by ymandel, committed by ). Changed prior to commit: https://reviews.llvm.org/D59371?vs=195606&id=195778#toc Reposito

r358691 - [LibTooling] Add Stencil library for format-string style codegen.

Author: ymandel Date: Thu Apr 18 10:23:01 2019 New Revision: 358691 URL: http://llvm.org/viewvc/llvm-project?rev=358691&view=rev Log: [LibTooling] Add Stencil library for format-string style codegen. Summary: This file defines the *Stencil* abstraction: a code-generating object, parameterized by

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195775. gtbercea added a comment. - Move error check in sema. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Well done! I never managed to track this one down, this was really annoying. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60873/new/ http

[PATCH] D60558: [clang-format] Fix indent of trailing raw string param after newline

This revision was automatically updated to reflect the committed changes. Closed by commit rC358689: [clang-format] Fix indent of trailing raw string param after newline (authored by krasimir, committed by ). Changed prior to commit: https://reviews.llvm.org/D60558?vs=194654&id=195772#toc Repo

r358689 - [clang-format] Fix indent of trailing raw string param after newline

Author: krasimir Date: Thu Apr 18 10:14:05 2019 New Revision: 358689 URL: http://llvm.org/viewvc/llvm-project?rev=358689&view=rev Log: [clang-format] Fix indent of trailing raw string param after newline Summary: Currently clang-format uses ContinuationIndent to indent the contents of a raw strin

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

ABataev added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9136 +def err_omp_target_before_requires : Error < + "Target region encountered before requires directive with '%0' clause">; +def note_omp_requires_encountered_target : Note <

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea updated this revision to Diff 195771. gtbercea added a comment. - Fix. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaOpenMP.cpp test/OpenMP/r

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea updated this revision to Diff 195770. gtbercea marked an inline comment as done. gtbercea added a comment. - Fix. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 Files: include/clang/Basic/DiagnosticSemaKinds.t

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:4207 +DSAStack->hasRequiresDeclWithClause()) && + !CurContext->isDependentContext()) { +// Register target to DSA Stack. ABataev wrote: > Better to check for the dependent context

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea updated this revision to Diff 195768. gtbercea marked an inline comment as done. gtbercea added a comment. - Fix test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 Files: include/clang/Basic/DiagnosticSemaKi

[PATCH] D60853: clang-format converts a keyword macro definition to a macro function

owenpan marked 2 inline comments as done. owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:808 - if (FormatTok->Tok.getKind() != tok::identifier) { + if (!FormatTok->Tok.getIdentifierInfo()) { IncludeGuard = IG_Rejected; ---

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea updated this revision to Diff 195762. gtbercea added a comment. Fix test, Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60875/new/ https://reviews.llvm.org/D60875 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaOpenMP.cpp test/Ope

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

ABataev added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9136 +def err_omp_target_before_requires : Error < + "Target region encountered before requires directive with %0 clause">; +def note_omp_requires_encountered_target : Note < E

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

gtbercea created this revision. gtbercea added reviewers: ABataev, AlexEichenberger, caomhin. Herald added subscribers: cfe-commits, jdoerfert, jfb, guansong. Herald added a project: clang. The requires directive containing target related clauses must appear before any target region in the compil

r358679 - [Sema][NFC] Mark DR1563 as done (List-initialization and overloaded function disambiguation)

Author: brunoricci Date: Thu Apr 18 08:45:08 2019 New Revision: 358679 URL: http://llvm.org/viewvc/llvm-project?rev=358679&view=rev Log: [Sema][NFC] Mark DR1563 as done (List-initialization and overloaded function disambiguation) It has been supported since at least clang 3.1 so just mark it as

r358678 - [Sema][NFC] Mark DR705 (Suppressing argument-dependent lookup via parentheses) as done

Author: brunoricci Date: Thu Apr 18 08:34:03 2019 New Revision: 358678 URL: http://llvm.org/viewvc/llvm-project?rev=358678&view=rev Log: [Sema][NFC] Mark DR705 (Suppressing argument-dependent lookup via parentheses) as done It was supported since at least clang 3 so just mark it as done. Modif

[PATCH] D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, ioeric, ilya-biryukov. Herald added a project: clang. Include insertion in clangd was inserting absolute paths when the include directory was an absolute path with a doub

r358676 - [analyzer][NFC] Use capital variable names, move methods out-of-line, rename some in CheckerRegistry

Author: szelethus Date: Thu Apr 18 08:19:16 2019 New Revision: 358676 URL: http://llvm.org/viewvc/llvm-project?rev=358676&view=rev Log: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename some in CheckerRegistry There are barely any lines I haven't changed in these files

[PATCH] D59457: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename some in CheckerRegistry

This revision was automatically updated to reflect the committed changes. Closed by commit rL358676: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename… (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D60267: [clangd] Support relatedInformation in diagnostics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358675: [clangd] Support relatedInformation in diagnostics. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SI

[clang-tools-extra] r358675 - [clangd] Support relatedInformation in diagnostics.

Author: sammccall Date: Thu Apr 18 08:17:07 2019 New Revision: 358675 URL: http://llvm.org/viewvc/llvm-project?rev=358675&view=rev Log: [clangd] Support relatedInformation in diagnostics. Summary: We already have the structure internally, we just need to expose it. Reviewers: ilya-biryukov Subs

[PATCH] D60835: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap

This revision was automatically updated to reflect the committed changes. Closed by commit rL358674: [Serialization] Stable serialization order for OpenCLTypeExtMap and… (authored by brunoricci, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

r358674 - [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap

Author: brunoricci Date: Thu Apr 18 08:13:27 2019 New Revision: 358674 URL: http://llvm.org/viewvc/llvm-project?rev=358674&view=rev Log: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap Sort the elements of Sema::OpenCLTypeExtMap and Sema::OpenCLDeclExtMap by

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

jdenny added a comment. Thanks for the accepts. In D60845#1470986 , @NoQ wrote: > In D60845#1470980 , @Charusso wrote: > > > I really like live working examples, I hope not just me. Could you link > > https://gith

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

jdenny updated this revision to Diff 195742. jdenny added a comment. Clarify the behavior of multiple -verify options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60845/new/ https://reviews.llvm.org/D60845 Files: clang/include/clang/Frontend/VerifyDiagnosticConsumer.h Index: clan

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9135 "%0 clause previously used here">; +def err_omp_target_before_requires : Error < + "Target region encountered before requires directive with %0 clause.">; Split the pat

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195739. gtbercea added a comment. - Add const. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/C

  1   2   >