[PATCH] D64850: Remove use of malloc in PPC mm_malloc.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366406: [PowerPC][Clang] Remove use of malloc in mm_malloc (authored by chaofan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

r366406 - [PowerPC][Clang] Remove use of malloc in mm_malloc

Author: chaofan Date: Wed Jul 17 23:20:12 2019 New Revision: 366406 URL: http://llvm.org/viewvc/llvm-project?rev=366406&view=rev Log: [PowerPC][Clang] Remove use of malloc in mm_malloc Remove dependency of malloc in implementation of mm_malloc function in PowerPC intrinsics and alignment assumpti

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

rsmith added a comment. In D64799#1589557 , @ilya-biryukov wrote: > I tried to find a good place to emit unresolved typos earlier (to make sure > CodeGen does not ever get `TypoExpr`), but couldn't find one. > Please let me know if there's some obvious

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

craig.topper added a comment. In D63638#1581973 , @chandlerc wrote: > Just to make sure we're on the same page (and sorry I didn't jump in > sooner)... > > With the old PM, *anything* that is `always_inline` *gets* `instsimplify` run > on it, even at -O0

[clang-tools-extra] r366400 - [clangd] Fix Fix -Wunused-lambda-capture after r366339

Author: maskray Date: Wed Jul 17 21:23:54 2019 New Revision: 366400 URL: http://llvm.org/viewvc/llvm-project?rev=366400&view=rev Log: [clangd] Fix Fix -Wunused-lambda-capture after r366339 Modified: clang-tools-extra/trunk/clangd/QueryDriverDatabase.cpp Modified: clang-tools-extra/trunk/clan

[PATCH] D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression

rsmith added a comment. I don't think this problem really has anything to do with statement expressions; consider: struct Widget a = (init2(&a), a); ... which has the same behaviour and presumably produces the same warning. It's just a C / C++ difference. In C++, these examples are undefined

[PATCH] D64900: [WebAssembly] Implement __builtin_wasm_tls_base intrinsic

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. What does this return when `__wasm_init_tls` has not been called? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64900/new/ https://reviews.llv

[PATCH] D64900: [WebAssembly] Implement __builtin_wasm_tls_base intrinsic

quantum created this revision. quantum added reviewers: tlively, aheejin, sbc100. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, dschuff. Herald added projects: clang, LLVM. Add `__builtin_wasm_tls_base` so that LeakSanitizer can find the thread-local b

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

NoQ added a comment. /me has just noticed that it's not D34812 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63279/new/ https://reviews.llvm.org/D63279 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D64680: [analyzer] MallocChecker: Prevent Integer Set Library false positives

This revision was automatically updated to reflect the committed changes. Closed by commit rL366391: [analyzer] MallocChecker: Prevent Integer Set Library false positives (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r366391 - [analyzer] MallocChecker: Prevent Integer Set Library false positives

Author: charusso Date: Wed Jul 17 17:03:55 2019 New Revision: 366391 URL: http://llvm.org/viewvc/llvm-project?rev=366391&view=rev Log: [analyzer] MallocChecker: Prevent Integer Set Library false positives Summary: Integer Set Library using retain-count based allocation which is not modeled in Mal

[PATCH] D64680: [analyzer] MallocChecker: Prevent Integer Set Library false positives

Charusso added a comment. In D64680#1590619 , @NoQ wrote: > Great, thanks! Thanks for the review! I like that new name. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64680/new/ https://reviews.llvm.org/D64680 ___

[PATCH] D64680: [analyzer] MallocChecker: Prevent Integer Set Library false positives

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great, thanks! Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:363-364 + /// Check whether we do not model the memory allocation. + bool isNotModeled(const Call

[PATCH] D64889: [OPENMP] getDSA(): handle loop control variables

Prince781 updated this revision to Diff 210459. Prince781 added a comment. Added a lit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64889/new/ https://reviews.llvm.org/D64889 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/loop_c

[PATCH] D64680: [analyzer] MallocChecker: Prevent Integer Set Library false positives

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2549-2552 + FunctionStr = Lexer::getSourceText( + CharSourceRange::getTokenRange( + {FD->getBeginLoc(), FD->getBody()->getBeginLoc()}), + C.getSourc

[PATCH] D64680: [analyzer] MallocChecker: Prevent Integer Set Library false positives

Charusso updated this revision to Diff 210458. Charusso marked 4 inline comments as done. Charusso added a comment. - More fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64680/new/ https://reviews.llvm.org/D64680 Files: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp clang/

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great to me once @Szelethus's comments are addressed. Thanks!! Comment at: lib/StaticAnalyzer/Checkers/Yaml.h:34 +std::string(Conf

[PATCH] D64680: [analyzer] MallocChecker: Prevent Integer Set Library false positives

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2549-2552 + FunctionStr = Lexer::getSourceText( + CharSourceRange::getTokenRange( + {FD->getBeginLoc(), FD->getBody()->getBeginLoc()}), + C.getSourceMana

[PATCH] D64272: [analyzer] Note last writes to a condition only in a nested stackframe

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1447-1454 // If we have an expression that provided the value, try to track where it // came from. if (InitE) { if (!IsParam) InitE = InitE->IgnoreParenCasts();

[PATCH] D64775: [Format/ObjC] Avoid breaking between unary operators and ObjC method invocations

benhamilton marked an inline comment as done. benhamilton added a comment. Any more thoughts on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64775/new/ https://reviews.llvm.org/D64775 ___ cfe-co

[PATCH] D64270: [analyzer][NFC] Prepare visitors for different tracking kinds

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:81 + +bool bugreporter::trackExpressionValue(const ExplodedNode *InputNode, + const Expr *E, BugReport &report, Szelethus wrote: > x

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh added a comment. In D59474#1589464 , @ABataev wrote: > In D59474#1561161 , @lildmh wrote: > > > Change the type of size from `size_t` to `int64_t`, and rebase > > > Lingda, could you rebase it again? Thanks.

[PATCH] D64843: hwasan: Initialize the pass only once.

pcc added a comment. The instrumentation for globals is coming in a separate patch. It seems more important to achieve implementation simplicity for the sanitizer passes rather than data locality because they make fundamental changes to the IR that touch the whole module (unlike other passes th

[PATCH] D64843: hwasan: Initialize the pass only once.

leonardchan added subscribers: fedor.sergeev, philip.pfaffe, leonardchan. leonardchan added a comment. cc: @fedor.sergeev @philip.pfaffe on this I think one of the things we want in the new PM is the data locality that we see from iterating only specific IR units (functions in this case). This w

[PATCH] D64889: [OPENMP] getDSA(): handle loop control variables

lebedev.ri added a comment. Needs a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64889/new/ https://reviews.llvm.org/D64889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D64889: [OPENMP] getDSA(): handle loop control variables

Prince781 created this revision. Prince781 added reviewers: ABataev, rsmith. Prince781 added projects: clang, OpenMP. Herald added subscribers: cfe-commits, jdoerfert, guansong. The following example compiles incorrectly since at least clang 8.0.0: #include #include #define N 100

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

eandrews added a comment. ping I just realized I modified the summary when I uploaded a new patch, but did not add a comment about the changes I made. Based on feedback from the bug report (https://bugs.llvm.org/show_bug.cgi?id=40982), I changed my approach for this crash. This patch changes t

[PATCH] D61452: [WebAssembly] Always include /lib in library path

sbc100 added a comment. In D61452#1488789 , @sunfish wrote: > If "$sysroot/lib" ends up coming to mean "wasm32" because people come to > depend on that, then wasm64 may end up needing to be different in a > gratuitous way, which I'd like to avoid. > > I'

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi updated this revision to Diff 210431. plotfi marked 10 inline comments as done. plotfi added a comment. Updated to address @aaron.ballman 's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64098/new/ https://reviews.llvm.org/D64098 F

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2217 public: -typedef llvm::SmallVector PhasesTy; +typedef const std::vector PhasesTy; aaron.ballman wrote: > Why are you changing this to an STL type? I changed it because it didn

[PATCH] D64780: Disallow most calling convention attributes on PS4.

Sunil_Srivastava added a comment. Pre-commit to change the wording and ID of warn_cconv_ignore has gone in in r366368. I will be shortly updating this review to account for that, and for other points raised here. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64

[PATCH] D64843: hwasan: Initialize the pass only once.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366379: hwasan: Initialize the pass only once. (authored by pcc, committed by ). Changed prior to commit: https://reviews.llvm.org/D64843?vs=210227&id=210429#toc Repository: rL LLVM CHANGES SINCE LA

r366379 - hwasan: Initialize the pass only once.

Author: pcc Date: Wed Jul 17 14:45:19 2019 New Revision: 366379 URL: http://llvm.org/viewvc/llvm-project?rev=366379&view=rev Log: hwasan: Initialize the pass only once. This will let us instrument globals during initialization. This required making the new PM pass a module pass, which should stil

[PATCH] D63852: [Clang] Move assembler into a separate file

aykevl added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63852/new/ https://reviews.llvm.org/D63852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D64883: Add new warning -Walloca for use of builtin alloca function

george.burgess.iv added a comment. Thanks for this! Mostly just nitpicking the warning's wording. :) Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2776 +def warn_alloca : Warning< + "use of builtin function %0">, + InGroup>, DefaultIgnore; nit

[PATCH] D64883: Add new warning -Walloca for use of builtin alloca function

ziyig created this revision. ziyig added reviewers: gbiv, aaron.ballman. Herald added a reviewer: george.burgess.iv. Herald added subscribers: cfe-commits, kristina. Herald added a project: clang. Add new warning -Walloca for use of builtin alloca function. Also warns the use of __builtin_alloca_

r366368 - Renamed and changed the wording of warn_cconv_ignored

Author: ssrivastava Date: Wed Jul 17 13:41:26 2019 New Revision: 366368 URL: http://llvm.org/viewvc/llvm-project?rev=366368&view=rev Log: Renamed and changed the wording of warn_cconv_ignored As discussed in D64780 the wording of this warning message is being changed to say 'is not supported' ins

[PATCH] D64843: hwasan: Initialize the pass only once.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. OK, sure. As I understand functon passes also have better data locality by running a sequence of passes over a single function. Not sure how important that is. LGTM Repository: rG LLVM Gi

[PATCH] D64270: [analyzer][NFC] Prepare visitors for different tracking kinds

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:110 + ConditionTracking +}; + Charusso wrote: > What about the following? > ``` > enum class Track

[PATCH] D64287: [analyzer] Track the right hand side of the last store regardless of its value

Szelethus added a comment. In D64287#1589941 , @xazax.hun wrote: > LGTM! > > Since we allow new kinds of SVals to be tracked it would be great to test > this first on a larger corpus of projects just to see if there is a crash > (due to an unhandled SVal

[PATCH] D61838: [Sema] Suppress additional warnings for C's zero initializer

al3xtjames added a comment. Thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61838/new/ https://reviews.llvm.org/D61838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[PATCH] D64603: [Target] Use IEEE quad format for long double on Fuchsia x86_64

mcgrathr added inline comments. Comment at: clang/lib/Basic/Targets/X86.h:858 + : FuchsiaTargetInfo(Triple, Opts) { +LongDoubleFormat = &llvm::APFloat::IEEEquad(); + } Can we just do this in FuchsiaTargetInfo generically? I think we'd like to make our c

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

DiegoAstiazaran updated this revision to Diff 210394. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Herald added a subscriber: mgorny. Move the CSS file to share/clang and read it from there, instead of trying to read it from the file that's with the source

[PATCH] D64843: hwasan: Initialize the pass only once.

pcc added a comment. IIUC the reason was to work around the lack of analysis availability from module passes, which is no longer a concern with the new PM. I would personally prefer to see the other sanitizers re-architected this way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D64843: hwasan: Initialize the pass only once.

eugenis added a subscriber: chandlerc. eugenis added a comment. I don't know what is the best practice here. Other sanitizers have both module and function passes, is there a reason to do things differently here? @chandlerc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D63648: [Preprocessor] Honor absolute paths in diagnostics

thakis added a comment. > So maybe `Driver::IsCLMode()` should take precedence over > `-fdiagnostics-absolute-paths` when using `/showIncludes`? Definitely not. We want builds to be deterministic; this includes them being independent of the build directory. (This matters for distributed compila

[PATCH] D64878: [OpenMP] Fix sema check for unified memory case NFC

ABataev added a comment. It does not look like NFC patch, the functionality has changed. Rename it, please, and a test case that reveals why we need this patch. Also, add a better description of the logic. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64878/new/

[PATCH] D64563: Updated the signature for some stack related intrinsics (CLANG)

arsenm added a comment. Can you add AMDGPU tests for these showing the correct address space is used CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64563/new/ https://reviews.llvm.org/D64563 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D64878: [OpenMP] Fix sema check for unified memory case NFC

gtbercea created this revision. gtbercea added a reviewer: ABataev. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. This patch fixes a condition introduced in patch D60883 . Repository: rC Clang https://reviews.llvm.

[PATCH] D64592: [OpenMP] Fix unified memory implementation for multiple compilation units

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2610 + auto *GV = cast(Ptr); + GV->setLinkage(llvm::GlobalValue::WeakAnyLinkage); + ABataev wrote: > Better to fix the link clause pro

[PATCH] D64592: [OpenMP] Fix unified memory implementation for multiple compilation units

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2610 + auto *GV = cast(Ptr); + GV->setLinkage(llvm::GlobalValue::WeakAnyLinkage); + Better to fix the link clause processing in a different patch, it has nothing to do with the

[PATCH] D64592: [OpenMP] Fix unified memory implementation for multiple compilation units

gtbercea updated this revision to Diff 210386. gtbercea added a comment. - Fix tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64592/new/ https://reviews.llvm.org/D64592 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/declare_target_codegen.cpp tes

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

rjmccall added a comment. LGTM with one minor request. Comment at: clang/lib/AST/DeclCXX.cpp:2267 QualType ClassTy = C.getTypeDeclType(Decl); - ClassTy = C.getQualifiedType(ClassTy, FPT->getMethodQuals()); - return C.getPointerType(ClassTy); + return C.getQualifiedType(Cl

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

aaron.ballman added inline comments. Comment at: clang/include/clang/Driver/Types.h:100 /// done for type 'Id'. - void getCompilationPhases( -ID Id, -llvm::SmallVectorImpl &Phases); + const std::vector getCompilationPhases(ID Id); Please drop the t

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1052 +// to return that every time. +if (N->getCFG().isLinear()) + WouldEventBeMeaningless = true; NoQ wrote: > This time i'd rather go for

[PATCH] D64270: [analyzer][NFC] Prepare visitors for different tracking kinds

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:81 + +bool bugreporter::trackExpressionValue(const ExplodedNode *InputNode, + const Expr *E, BugReport &report, Do we need thi

[PATCH] D64287: [analyzer] Track the right hand side of the last store regardless of its value

xazax.hun accepted this revision. xazax.hun added a comment. LGTM! Since we allow new kinds of SVals to be tracked it would be great to test this first on a larger corpus of projects just to see if there is a crash (due to an unhandled SVal type). CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D64867: [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL mode

Anastasia updated this revision to Diff 210381. Anastasia edited the summary of this revision. Anastasia added a comment. - Updated comments - Added motivation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64867/new/ https://reviews.llvm.org/D64867 Files: include/clang/Basic/Diagnost

[PATCH] D63648: [Preprocessor] Honor absolute paths in diagnostics

aganea added a comment. The problem is that it is not `cl.exe`'s behavior - it always makes paths absolute: F:\svn\test>cl /c test.cc /showIncludes Microsoft (R) C/C++ Optimizing Compiler Version 19.16.27031.1 for x64 Copyright (C) Microsoft Corporation. All rights reserved. test.cc

[PATCH] D64272: [analyzer] Note last writes to a condition only in a nested stackframe

xazax.hun added a comment. I have one small question otherwise looks good. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1457 + if (TKind == TrackingKind::ConditionTracking && + StoreSite->getStackFrame() == OriginSFC) +return nullptr;

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia reopened this revision. Anastasia added a comment. This revision is now accepted and ready to land. Reopening to continue reviews. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64418/new/ https://reviews.llvm.org/D64418 ___

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi added a comment. @aaron.ballman Any thoughts on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64098/new/ https://reviews.llvm.org/D64098 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D64874: Improve handling of function pointer conversions

Mordante created this revision. Mordante added a reviewer: rsmith. Mordante added a project: clang. Starting with C++17 the `noexcept` is part of the function signature but a `noexcept` function can be converted to a `noexcept(false)` function. The overload resolution code handles it properly bu

[PATCH] D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions

ilya-biryukov added a comment. In D64518#1589857 , @ymandel wrote: > In D64518#1589768 , @ilya-biryukov > wrote: > > > In D64518#1588092 , @ymandel wrote: > > > > > This see

[PATCH] D64780: Disallow most calling convention attributes on PS4.

Sunil_Srivastava marked an inline comment as done. Sunil_Srivastava added inline comments. Comment at: test/Sema/no_callconv.cpp:1 +// RUN: %clang_cc1 %s -triple x86_64-scei-ps4 -DPS4 -fsyntax-only -verify +// RUN: %clang_cc1 %s -triple x86_64-unknown-linux-gnu -fsyntax-only -ver

r366357 - [OPENMP]Fix PR42632: crash on the analysis of the OpenMP constructs.

Author: abataev Date: Wed Jul 17 11:03:39 2019 New Revision: 366357 URL: http://llvm.org/viewvc/llvm-project?rev=366357&view=rev Log: [OPENMP]Fix PR42632: crash on the analysis of the OpenMP constructs. Fixed processing of the CapturedStmt children to fix the crash of the OpenMP constructs during

[PATCH] D64780: Disallow most calling convention attributes on PS4.

aaron.ballman added inline comments. Comment at: test/Sema/no_callconv.cpp:1 +// RUN: %clang_cc1 %s -triple x86_64-scei-ps4 -DPS4 -fsyntax-only -verify +// RUN: %clang_cc1 %s -triple x86_64-unknown-linux-gnu -fsyntax-only -verify Does this really need an svn:exec

[PATCH] D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions

ymandel added a comment. In D64518#1589768 , @ilya-biryukov wrote: > In D64518#1588092 , @ymandel wrote: > > > This seems like a good candidate for configuration -- the user could then > > choose which mode to run

r366355 - Revert [AArch64] Add support for Transactional Memory Extension (TME)

Author: chill Date: Wed Jul 17 10:43:32 2019 New Revision: 366355 URL: http://llvm.org/viewvc/llvm-project?rev=366355&view=rev Log: Revert [AArch64] Add support for Transactional Memory Extension (TME) This reverts r366322 (git commit 4b8da3a503e434ddbc08ecf66582475765f449bc) Removed: cfe/tr

Re: [PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

Thanks, I've reverted it for now. From: Simon Pilgrim via Phabricator Sent: 17 July 2019 18:23:29 To: Momchil Velikov; oliver.stann...@linaro.org; t.p.northo...@gmail.com; jdoerf...@anl.gov Cc: llvm-...@redking.me.uk; notst...@gmail.com; cfe-commits@lists.llvm.or

[PATCH] D64813: [clang-tidy] Exclude forward decls from fuchsia-multiple-inheritance

This revision was automatically updated to reflect the committed changes. Closed by commit rL366354: [clang-tidy] Exclude forward decls from fuchsia-multiple-inheritance (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[clang-tools-extra] r366354 - [clang-tidy] Exclude forward decls from fuchsia-multiple-inheritance

Author: juliehockett Date: Wed Jul 17 10:40:53 2019 New Revision: 366354 URL: http://llvm.org/viewvc/llvm-project?rev=366354&view=rev Log: [clang-tidy] Exclude forward decls from fuchsia-multiple-inheritance Addresses b39770. Differential Revision: https://reviews.llvm.org/D64813 Modified:

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

lebedev.ri added a comment. In D64695#1589740 , @Manikishan wrote: > In D64695#1589508 , @lebedev.ri > wrote: > > > Is there sufficient test coverage as to what happens if `SortPriority` is > > not set? > > > If S

[PATCH] D63648: [Preprocessor] Honor absolute paths in diagnostics

thakis added a comment. >> Those aren't diagnostics, so that's not surprising. > > What would suggest in that case? Add a new `-fpreprocessor-absolute-paths` > option? Or change the name of `-fdiagnostics-absolute-paths` for another name > that applies to both diagnostics and the preprocessor o

[PATCH] D64867: [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL mode

svenvh added a comment. It would be good if you could provide some motivation for this change in the description of this review. Comment at: include/clang/Basic/DiagnosticParseKinds.td:1157 -// OpenCL C++. +// C++ for OpenCL. def err_openclcxx_virtual_function : Error<

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

RKSimon added a comment. @chill This is failing on buildbots with EXPENSIVE_CHECKS enabled: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/18684/steps/test-check-all/logs/stdio Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64416/ne

[clang-tools-extra] r366353 - [clang-tidy] Fix crash on end location inside macro

Author: nathan-huckleberry Date: Wed Jul 17 10:22:43 2019 New Revision: 366353 URL: http://llvm.org/viewvc/llvm-project?rev=366353&view=rev Log: [clang-tidy] Fix crash on end location inside macro Summary: Lexer::getLocForEndOfToken is defined to return an invalid location if the given location i

[PATCH] D64607: [clang-tidy] Fix crash on end location inside macro

This revision was automatically updated to reflect the committed changes. Closed by commit rL366353: [clang-tidy] Fix crash on end location inside macro (authored by Nathan-Huckleberry, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL366351: [Docs][OpenCL] Documentation of C++ for OpenCL mode (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D64780: Disallow most calling convention attributes on PS4.

wristow added reviewers: rnk, rjmccall. wristow added inline comments. Comment at: include/clang/Basic/TargetInfo.h:1271 CCCR_Ignore, +CCCR_Error, }; rnk wrote: > I feel like perhaps a cleaner way of implementing this would be to have the > driver pa

r366351 - [Docs][OpenCL] Documentation of C++ for OpenCL mode

Author: stulova Date: Wed Jul 17 10:21:31 2019 New Revision: 366351 URL: http://llvm.org/viewvc/llvm-project?rev=366351&view=rev Log: [Docs][OpenCL] Documentation of C++ for OpenCL mode Added documentation of C++ for OpenCL mode into Clang User Manual and Language Extensions document. Differenti

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

Nathan-Huckleberry added a comment. The main problem that we have is that the `__attribute__` token always causes the parser to read the line as a declaration. Then the declaration parser handles reading the attributes list. This case demonstrates the problem: void foo() { __attribute__(

[PATCH] D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions

ilya-biryukov added a comment. In D64518#1588092 , @ymandel wrote: > This seems like a good candidate for configuration -- the user could then > choose which mode to run in. But, I'm also open to just reporting these > conditions as errors. It's alread

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:170 +return; + Loc = SM.getSpellingLoc(Loc); +} hokein wrote: > hokein wrote: > > jvikstrom wrote: > > > hokein wrote: > > > > The Loc here maybe not i

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan updated this revision to Diff 210358. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 Files: include/clang/Tooling/Inclusions/HeaderIncludes.h include/clang/Tooling/Inclusions/IncludeStyle.h lib/Format/Form

[PATCH] D64780: Disallow most calling convention attributes on PS4.

Sunil_Srivastava removed reviewers: wristow, rnk, rjmccall. Sunil_Srivastava marked an inline comment as done. Sunil_Srivastava added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2961 +def error_cconv_unsupported : Error< + "%0 calling convention not s

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

jvikstrom updated this revision to Diff 210359. jvikstrom marked 2 inline comments as done. jvikstrom added a comment. Ignore tokens outside of main file. Added testcase for assert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64741/new/ https://r

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In D64695#1589508 , @lebedev.ri wrote: > Is there sufficient test coverage as to what happens if `SortPriority` is not > set? If SortPriority is not set, the Includes will be grouped without sorting, For example: #include

[PATCH] D64860: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase

kadircet updated this revision to Diff 210354. kadircet marked 5 inline comments as done. kadircet added a comment. - Add removeDots helper to FS.h - Revert changes in getFallbackCommands. - Add comments for the reasoning behind removeDots calls. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D64860: [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase

kadircet added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:77 GlobalCompilationDatabase::getFallbackCommand(PathRef File) const { + llvm::SmallString<128> CanonPath(File); + llvm::sys::path::remove_dots(CanonPath, true);

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan updated this revision to Diff 210353. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 Files: include/clang/Tooling/Inclusions/HeaderIncludes.h include/clang/Tooling/Inclusions/IncludeStyle.h lib/Format/Form

[PATCH] D60335: Use -fomit-frame-pointer when optimizing PowerPC code

jhibbits accepted this revision. jhibbits added a comment. This revision is now accepted and ready to land. Herald added a subscriber: shchenz. Looks fine to me. Since it can be turned off, I don't see a problem if it causes issues. Repository: rC Clang CHANGES SINCE LAST ACTION https://r

[PATCH] D63648: [Preprocessor] Honor absolute paths in diagnostics

aganea added a comment. Thanks for getting back Hans! In D63648#1589119 , @hans wrote: > Are you saying the diagnostics were not using absolute paths in those cases > and this patch fixes that? Yes. >> , or --show-includes, or -E > > Those aren't dia

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62584/new/ https://reviews.llvm.org/D62584 ___ cfe-commits mailing list cfe-co

[PATCH] D64680: [analyzer] MallocChecker: Prevent Integer Set Library false positives

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2549-2552 + FunctionStr = Lexer::getSourceText( + CharSourceRange::getTokenRange( + {FD->getBeginLoc(), FD->getBody()->getBeginLoc()}), + C.getSourc

[PATCH] D52193: RFC: [clang] Multithreaded compilation support -- NOT FOR SUBMIT

angushewlett added a comment. In D52193#1589657 , @aganea wrote: > > In D52193#1589150 , @angushewlett > wrote: > >> They're issued in the right order, but the second doesn't wait for the first >> to complete

[PATCH] D64739: [SVE][Inline-Asm] Add support to clang for SVE inline assembly

sdesmalen added a comment. Functionally the patch looks good, but the title suggests this adds full inline-asm support for SVE (which would require the ACLE types proposed in D62960 , as well as other changes), where this patch only adds support to specify SVE r

[PATCH] D64680: [analyzer] MallocChecker: Prevent Integer Set Library false positives

Charusso updated this revision to Diff 210347. Charusso marked 9 inline comments as done. Charusso added a comment. - Fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64680/new/ https://reviews.llvm.org/D64680 Files: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp clang/test/

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

martong added a comment. Jenkins looks okay: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/31160/ .The build is red but the the previous run has the very same failing test case: expression_command/weak_symbols/TestWeakSymbols.py Repository: rL LLVM CHANGES SINCE LAST ACTION htt

[PATCH] D52193: RFC: [clang] Multithreaded compilation support -- NOT FOR SUBMIT

aganea added a comment. In D52193#1589096 , @yurybura wrote: > Do you have any plans to make this PR compatible with trunk? Now MSVC with > /MP builds much faster than clang-cl (at least 2x faster for our project)... I'll get back to this after the vaca

  1   2   3   >