[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan added a comment. Final review ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D65130: [clang][OpenMP] Add clang-offload-wrapper tool

sdmitriev created this revision. sdmitriev added reviewers: hfinkel, ABataev. Herald added subscribers: cfe-commits, guansong, mgorny. Herald added a reviewer: jdoerfert. Herald added a project: clang. This is the first set of changes for eliminating OpenMP linker script that adds new clang-offlo

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan updated this revision to Diff 211245. ziangwan added a comment. Update diff 1. Fix trailing whitespaces. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaChe

[PATCH] D64883: Add new warning -Walloca for use of builtin alloca function

george.burgess.iv added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2776 +def warn_alloca : Warning< + "use of builtin function %0">, + InGroup>, DefaultIgnore; aaron.ballman wrote: > george.burgess.iv wrote: > > aaron.ballman

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

xazax.hun created this revision. xazax.hun added reviewers: gribozavr, rsmith, mgehre. xazax.hun added a project: clang. Herald added subscribers: cfe-commits, Charusso, gamesh411, Szelethus, dkrupp, rnkovacs. xazax.hun added a parent revision: D65120: More warnings regarding gsl::Pointer and gsl

[PATCH] D65120: More warnings regarding gsl::Pointer and gsl::Owner attributes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6564 +static bool shouldTrackImplicitObjectArg(const CXXMethodDecl *Callee, + const CXXMemberCallExpr *MCE) { + if (auto *

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3564 +ArgStringList DummyArgs; +CollectArgsForIntegratedAssembler(C, Args, DummyArgs, D, + TC.useIntegratedAs());

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

alexfh added a comment. LessClangTidyError only compares location and message, but it could also compare other things like notes, fixes, etc. For the problem outlined in the description of this patch we can probably include the checker name into the key. WDYT? Repository: rCTE Clang Tools E

[PATCH] D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression

Nathan-Huckleberry updated this revision to Diff 211230. Nathan-Huckleberry added a comment. - Disable self reference checking for C Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64678/new/ https://reviews.llvm.org/D64678 Files: clang/lib/Sema/S

[PATCH] D65125: clang-format: Fix namespace end comments for namespaces with attributes and macros

thakis created this revision. thakis added reviewers: klimek, sammccall. Fixes PR39247. While here, also make C++20 `namespace A::inline B::inline C` nested inline namespaced definitions work. Before: #define DEPRECATE_WOOF [[deprecated("meow")]] namespace DEPRECATE_WOOF woof { void f(

[PATCH] D63889: Check possible warnings on global initializers for reachability

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:2009 +AnalysisDeclContext &AC, +SmallVector PUDs) { + is `clang` namespace required here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

xbolva00 added a comment. I think we should warn in that case even if GCC does not warn. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366761: [NFC][clang] Refactor getCompilationPhases()+Types.def step 1. (authored by zer0, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan added a comment. In D64666#1596512 , @xbolva00 wrote: > @jfb’s comment is not addressed yet. > > In D64666#1583629 , @jfb wrote: > > > I think you want to default-ignore the "may lose precision" warnings, b

[PATCH] D63889: Check possible warnings on global initializers for reachability

Nathan-Huckleberry updated this revision to Diff 211224. Nathan-Huckleberry added a comment. - Style fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63889/new/ https://reviews.llvm.org/D63889 Files: clang/include/clang/Parse/Parser.h clang

r366761 - [NFC][clang] Refactor getCompilationPhases()+Types.def step 1.

Author: zer0 Date: Mon Jul 22 16:10:10 2019 New Revision: 366761 URL: http://llvm.org/viewvc/llvm-project?rev=366761&view=rev Log: [NFC][clang] Refactor getCompilationPhases()+Types.def step 1. Moves list of phases into Types.def table: Currently Types.def contains a table of strings that are use

[PATCH] D63889: Check possible warnings on global initializers for reachability

Nathan-Huckleberry updated this revision to Diff 211221. Nathan-Huckleberry added a comment. - Style fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63889/new/ https://reviews.llvm.org/D63889 Files: clang/include/clang/Parse/Parser.h clang

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

aaron.ballman added a comment. In D64666#1596619 , @xbolva00 wrote: > I think @jfb wanted to say that if we know we always lose the precision, we > should warn even without -Wxyz, no? Oh, good catch! I hadn't noticed that *both* diagnostics were `Defaul

[PATCH] D64883: Add new warning -Walloca for use of builtin alloca function

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2776 +def warn_alloca : Warning< + "use of builtin function %0">, + InGroup>, DefaultIgnore; george.burgess.iv wrote: > aaron.ballman wrote: > > george.burgess.iv

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

xbolva00 added a comment. I think @jfb wanted to say that if we know we always lose the precision, we should warn even without -Wxyz, no? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-comm

[PATCH] D63889: Check possible warnings on global initializers for reachability

nickdesaulniers added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1698 +} +return nullptr; + } Does: `return DeclForInitializer.empty() ? DeclForInitializer.back() : nullptr;` fit on one line? Comment at: clang/lib/Sem

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

aaron.ballman accepted this revision. aaron.ballman added a comment. In D64666#1583629 , @jfb wrote: > I think you want to default-ignore the "may lose precision" warnings, but not > the ones that you know always lose precision. We don't often add off-b

[PATCH] D63889: Check possible warnings on global initializers for reachability

nickdesaulniers added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1689 + void popDeclForInitializer() { +DeclForInitializer.pop_back(); + } might be nice to return the result, but maybe YAGNI? Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D65120: More warnings regarding gsl::Pointer and gsl::Owner attributes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/inner-pointer.cpp:2 // RUN: %clang_analyze_cc1 -analyzer-checker=cplusplus.InnerPointer \ -// RUN: %s -analyzer-output=text -verify I had to disable

[PATCH] D65120: More warnings regarding gsl::Pointer and gsl::Owner attributes

xazax.hun created this revision. xazax.hun added reviewers: gribozavr, rsmith, mgehre. xazax.hun added a project: clang. Herald added subscribers: cfe-commits, Charusso, gamesh411, Szelethus, dkrupp, rnkovacs. This patch extends the warnings for additional cases: 1. When the temporary is the res

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman added a comment. In D62648#1596535 , @rsmith wrote: > Thanks, LGTM. Do you need someone to commit this for you? Nope, I can commit it. There's still one outstanding issue though: typo-correction-cxx11.cpp is still failing with the `DelayedTypos

[PATCH] D63889: Check possible warnings on global initializers for reachability

Nathan-Huckleberry updated this revision to Diff 211213. Nathan-Huckleberry added a comment. - Add tracking of declaration of initializers in Sema. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63889/new/ https://reviews.llvm.org/D63889 Files: c

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

rsmith added a comment. Thanks, LGTM. Do you need someone to commit this for you? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D65050: [SemaTemplate] Mark a function type as dependent when its parameter list contains pack expansion

efriedma edited reviewers, added: aaron.ballman; removed: doug.gregor, eli.friedman, lvoufo. efriedma added a comment. Is this the only place where a compound type can contain a PackExpansionType? The code could probably use a brief comment explaining why we need to check this explicitly, even

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

xbolva00 added a comment. @jfb’s comment seems to be not addressed. In D64666#1583629 , @jfb wrote: > I think you want to default-ignore the "may lose precision" warnings, but not > the ones that you know always lose precision. CHANGES SINCE LAST AC

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hi Gabor, Thank you again for working on this patch. I think it can be committed after minor stylish issues are fixed. Comment at: clang/lib/AST/ASTImporter.cpp:1677 +

[PATCH] D65107: [clang-doc] Fix html entities in rendered text

DiegoAstiazaran updated this revision to Diff 211201. DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Use printHTMLEscaped() in ADT/StringExtras.h to write HTML entities. CHANGES SINCE LAST ACTION https://r

[PATCH] D65116: [Driver] Set the default win32-macho debug format to DWARF

This revision was automatically updated to reflect the committed changes. Closed by commit rL366744: [Driver] Set the default win32-macho debug format to DWARF (authored by vedantk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

r366744 - [Driver] Set the default win32-macho debug format to DWARF

Author: vedantk Date: Mon Jul 22 14:46:45 2019 New Revision: 366744 URL: http://llvm.org/viewvc/llvm-project?rev=366744&view=rev Log: [Driver] Set the default win32-macho debug format to DWARF rdar://53267670 Differential Revision: https://reviews.llvm.org/D65116 Modified: cfe/trunk/lib/Dri

[PATCH] D64241: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Looks good! Sorry for the delay :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64241/new/ https://reviews.llvm.org/D64241 ___

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

nathanchance added a comment. I tested this patch on top of r366728 and saw no regressions in my set of kernel builds. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65108/new/ https://reviews.llvm.org/D65108 ___ cfe-commits mailing list cf

[PATCH] D65116: [Driver] Set the default win32-macho debug format to DWARF

JDevlieghere added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.h:81 /// Set CodeView as the default debug info format. Users can use -gcodeview /// and -gdwarf to override the default. Let's update the comment. CHANGES SINCE LAST ACTI

[PATCH] D65116: [Driver] Set the default win32-macho debug format to DWARF

davide accepted this revision. davide added a comment. Minor otherwise LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65116/new/ https://reviews.llvm.org/D65116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan added a comment. Ping. I am going to submit this patch if nobody objects. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D65116: [Driver] Set the default win32-macho debug format to DWARF

vsk created this revision. vsk added reviewers: ahatanak, JDevlieghere, friss. Herald added a subscriber: dexonsmith. rdar://53267670 https://reviews.llvm.org/D65116 Files: clang/lib/Driver/ToolChains/MSVC.h clang/test/Misc/win32-macho.c Index: clang/test/Misc/win32-macho.c ==

[libunwind] r366734 - [runtimes] Don't depend on libpthread on Android

Author: kongyi Date: Mon Jul 22 13:41:03 2019 New Revision: 366734 URL: http://llvm.org/viewvc/llvm-project?rev=366734&view=rev Log: [runtimes] Don't depend on libpthread on Android r362048 added support for ELF dependent libraries, but broke Android build since Android does not have libpthread.

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 211184. dgoldman added a comment. - Bug fixes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-correction-recursive.cpp Index: test

[PATCH] D65104: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor

aaron.ballman added inline comments. Comment at: clang-tidy/performance/NoexceptMoveConstructorCheck.cpp:57 + assert(Decl->getNumParams() > 0); + SourceLocation NoexceptLoc = Decl->getParamDecl(Decl->getNumParams() - 1) + ->getSourc

[PATCH] D65107: [clang-doc] Fix html entities in rendered text

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:181 +std::string TextNode::getHTMLEntity(const char &C) { + switch (C) { There is printHTMLEscaped() in ADT/StringExtras.h. May b it could be used or common code m

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

leonardchan added a comment. I created D65110 if we're ok with just using the new PM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63638/new/ https://reviews.llvm.org/D63638 ___ cfe-commits mailing list c

[PATCH] D65110: [NewPM] Run avx*-builtins.c tests under the new pass manager only

leonardchan created this revision. leonardchan added reviewers: chandlerc, craig.topper, spatel, RKSimon. leonardchan added a project: clang. This patch changes the following tests to run under the new pass manager only: Clang :: CodeGen/avx512-reduceMinMaxIntrin.c (1 of 4) Clang :: CodeGen/a

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

Szelethus added a comment. In D64991#1596292 , @NoQ wrote: > In D64991#1595853 , @Szelethus wrote: > > > `CFGElementRef` > > > Wait, is it a thing already?? Did i miss anything??? Oh, yea, I have it locally, still

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

NoQ added a comment. In D64991#1595853 , @Szelethus wrote: > `CFGElementRef` Wait, is it a thing already?? Did i miss anything??? > This analysis isn't conservative enough yet, I really should include function > calls with non-const references into the

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

rnk added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3564 +ArgStringList DummyArgs; +CollectArgsForIntegratedAssembler(C, Args, DummyArgs, D, + TC.useIntegratedAs()); I think it would be better

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2051 + // Claim flags for the integrated assembler only if it's being used. + if (IsIntegratedAs) { +if (UseRelaxAll(C, Args)) thakis wrote: > nickdesaulniers wrote: >

[PATCH] D64883: Add new warning -Walloca for use of builtin alloca function

george.burgess.iv added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2776 +def warn_alloca : Warning< + "use of builtin function %0">, + InGroup>, DefaultIgnore; aaron.ballman wrote: > george.burgess.iv wrote: > > nit: I'd just

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2051 + // Claim flags for the integrated assembler only if it's being used. + if (IsIntegratedAs) { +if (UseRelaxAll(C, Args)) thakis wrote: > (This just wraps all the

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2051 + // Claim flags for the integrated assembler only if it's being used. + if (IsIntegratedAs) { +if (UseRelaxAll(C, Args)) nickdesau

[PATCH] D64655: [Clang][Driver] don't error for unsupported as options for -no-integrated-as

thakis added a comment. I think https://reviews.llvm.org/D65108 is a better fix, for the reason rnk gave above. I think this one can be abandoned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64655/new/ https://reviews.llvm.org/D64655

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2051 + // Claim flags for the integrated assembler only if it's being used. + if (IsIntegratedAs) { +if (UseRelaxAll(C, Args)) (This jus

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis added a comment. Note to self: Check https://github.com/ClangBuiltLinux/linux/issues/598 before landing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65108/new/ https://reviews.llvm.org/D65108 ___ cfe-commits mailing list cfe-

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis created this revision. thakis added a reviewer: rnk. This relands r365703 (and r365714), originally reviewed at https://reviews.llvm.org/D64527. The problem with the old approach was that clang would now warn about -Wa flags that the integrated assembler didn't understand even when -fno-in

[PATCH] D65107: [clang-doc] Fix html entities in rendered text

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Replace <, > and " with its corresponding html entities before rendering text nodes. https://reviews.llvm.org/D65107 Files: clang-tools-extr

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

klimek requested changes to this revision. klimek added inline comments. This revision now requires changes to proceed. Comment at: clang/docs/LibASTMatchersReference.html:5277 +MatcherCXXRecordDecl>isDirectlyDe

[PATCH] D65106: [OPENMP]Add support for analysis of reduction variables.

ABataev created this revision. ABataev added a reviewer: NoQ. Herald added subscribers: jdoerfert, guansong. Herald added a project: clang. Reduction variables are the variables, for which the private copies must be created in the OpenMP regions. Then they are initialized with the predefined value

[PATCH] D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366719: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM… (authored by benhamilton, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Ch

r366719 - Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM.

Author: benhamilton Date: Mon Jul 22 11:20:01 2019 New Revision: 366719 URL: http://llvm.org/viewvc/llvm-project?rev=366719&view=rev Log: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM. Summary: Addresses the formatting of NS_CLOSED_ENUM and CF_CLOSED

Re: [clang-tools-extra] r366455 - [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase

Merged this and r366559 to the 9 branch in r366718. On Thu, Jul 18, 2019 at 9:13 AM Kadir Cetinkaya via cfe-commits wrote: > > Author: kadircet > Date: Thu Jul 18 09:13:23 2019 > New Revision: 366455 > > URL: http://llvm.org/viewvc/llvm-project?rev=366455&view=rev > Log: > [clangd] Get rid of dot

Re: r366448 - [ASTUnit] Fix a regression in cached completions

Merged together with r366457 to Clang 9 in r366717. On Thu, Jul 18, 2019 at 8:21 AM Ilya Biryukov via cfe-commits wrote: > > Author: ibiryukov > Date: Thu Jul 18 08:21:34 2019 > New Revision: 366448 > > URL: http://llvm.org/viewvc/llvm-project?rev=366448&view=rev > Log: > [ASTUnit] Fix a regressi

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun updated this revision to Diff 211150. xazax.hun added a comment. - Fix a false positive from previous change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64256/new/ https://reviews.llvm.org/D64256 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/Se

Re: [clang-tools-extra] r366451 - [Clangd] Changed ExtractVariable to only work on non empty selections

Merged to the 9 branch in r366714 On Thu, Jul 18, 2019 at 8:37 AM Shaurya Gupta via cfe-commits wrote: > > Author: sureyeaah > Date: Thu Jul 18 08:38:03 2019 > New Revision: 366451 > > URL: http://llvm.org/viewvc/llvm-project?rev=366451&view=rev > Log: > [Clangd] Changed ExtractVariable to only w

Re: [clang-tools-extra] r366443 - [clangd] Disable DumpRecordLayout by default per https://bugs.llvm.org/show_bug.cgi?id=42670

Merged to the 9 branch in r366713. On Thu, Jul 18, 2019 at 8:00 AM Sam McCall via cfe-commits wrote: > > Author: sammccall > Date: Thu Jul 18 08:00:38 2019 > New Revision: 366443 > > URL: http://llvm.org/viewvc/llvm-project?rev=366443&view=rev > Log: > [clangd] Disable DumpRecordLayout by default

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev updated this revision to Diff 211148. AntonBikineev added a comment. Manuel, I left some cases which deviated from the isDerivedFrom matcher. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65092/new/ https://reviews.llvm.org/D65092 Files: clang/do

Re: r366699 - [X86] Remove const from some intrinsics that shouldn't have them

Merged to clang 9 in r366711. On Mon, Jul 22, 2019 at 9:13 AM Paul Robinson via cfe-commits wrote: > > Author: probinson > Date: Mon Jul 22 09:14:09 2019 > New Revision: 366699 > > URL: http://llvm.org/viewvc/llvm-project?rev=366699&view=rev > Log: > [X86] Remove const from some intrinsics that s

[PATCH] D65104: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor

zinovy.nis updated this revision to Diff 211147. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65104/new/ https://reviews.llvm.org/D65104 Files: clang-tidy/performance/NoexceptMoveConstructorCheck.cpp test/clang-tidy/performance-noexcept-move-constructor-fix.cpp Index: test/clang-ti

[PATCH] D65104: [clang-tidy] Add FixItHint for performance-noexcept-move-constructor

zinovy.nis created this revision. zinovy.nis added reviewers: alexfh, rsmith, aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D65104 Files: clang-tidy/performance/NoexceptMoveConstruct

Re: r366483 - [OPENMP]Fix sharing of threadprivate variables with TLS support.

Merged to Clang 9 in r366706. On Thu, Jul 18, 2019 at 12:39 PM Alexey Bataev via cfe-commits wrote: > > Author: abataev > Date: Thu Jul 18 12:40:24 2019 > New Revision: 366483 > > URL: http://llvm.org/viewvc/llvm-project?rev=366483&view=rev > Log: > [OPENMP]Fix sharing of threadprivate variables

Re: r366474 - [OPENMP]Provide correct data sharing attributes for loop control

Merged to Clang 9 in r366705. On Thu, Jul 18, 2019 at 10:48 AM Alexey Bataev via cfe-commits wrote: > > Author: abataev > Date: Thu Jul 18 10:49:13 2019 > New Revision: 366474 > > URL: http://llvm.org/viewvc/llvm-project?rev=366474&view=rev > Log: > [OPENMP]Provide correct data sharing attributes

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

klimek added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2637 internal::Matcher, Base) { - return Finder->classIsDerivedFrom(&Node, Base, Builder); + return Finder->classIsDerivedFrom(&Node, Base, Builder, false); } ---

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun updated this revision to Diff 211142. xazax.hun added a comment. - Fix a TODO and add some more tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64256/new/ https://reviews.llvm.org/D64256 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaInit.

[PATCH] D64416: [AArch64] Add support for Transactional Memory Extension (TME)

chill updated this revision to Diff 211140. This revision is now accepted and ready to land. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64416/new/ https://reviews.llvm.org/D64416 Files: clang/include/clang/Basic/BuiltinsAArch64.def clang/lib/Basic/Targets/AArch64.cpp clang/lib/B

[PATCH] D65102: [OpenCL] Rename lang mode flag for C++ mode

Anastasia created this revision. Anastasia added reviewers: svenvh, neil.hickey, kpet. Herald added subscribers: ebevhan, yaxunl. This suggestion was made in https://reviews.llvm.org/D64418?id=210101#inline-579453 but I am changing this standalone here. I see two benefits for this rename: - Al

[PATCH] D65101: [clangd] SelectionTree treats TranslationUnitDecl consistently with other containers.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Previously TranslationUnitDecl would never be selected. This means root() and commonAncestor() are now ne

[PATCH] D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM.

heijink updated this revision to Diff 211137. heijink added a comment. Fixed formatting of Format.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65012/new/ https://reviews.llvm.org/D65012 Files: clang/lib/Format/Format.cpp clang/lib/Format

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

rsmith added a comment. In D64799#1592263 , @rnk wrote: > In D64799#1591732 , @ilya-biryukov > wrote: > > > @rsmith, I'll look into emitting the typos when we pop expression > > evaluation context, but do we expec

r366702 - [OPENMP][MSVC]Enable /openmp[:experimental] to compile OpenMP.

Author: abataev Date: Mon Jul 22 09:49:59 2019 New Revision: 366702 URL: http://llvm.org/viewvc/llvm-project?rev=366702&view=rev Log: [OPENMP][MSVC]Enable /openmp[:experimental] to compile OpenMP. Mapped /openmp[:experimental] to -fopenmp option and /openmp- option to -fno-openmp Modified: c

[PATCH] D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM.

heijink updated this revision to Diff 211135. heijink added a comment. Adds NS_CLOSED_ENUM to the keywords that cause LLVM to detect Objective-C. Changed NSInteger to int in the unit tests, because NSInteger also signals Objective-C. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[libunwind] r366701 - [libunwind][ARM] Fix types in _Unwind_VRS_Get.

Author: miyuki Date: Mon Jul 22 09:43:03 2019 New Revision: 366701 URL: http://llvm.org/viewvc/llvm-project?rev=366701&view=rev Log: [libunwind][ARM] Fix types in _Unwind_VRS_Get. This is a small fix for https://reviews.llvm.org/D64996. The types of w0 and w1 in _Unwind_VRS_Get must be uint64_t,

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio marked an inline comment as done. dnsampaio added a comment. True. Thx again. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 ___ cfe-commits mailing list cfe-commit

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio updated this revision to Diff 211132. dnsampaio added a comment. - Joined assignments for default alignments and neon_vector alignment - Added missing align 8 test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000

[PATCH] D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM.

benhamilton added a comment. Oh, I forgot there's one more place you should touch — the Objective-C style guesser for headers will need to be updated to understand that `NS_CLOSED_ENUM` indicates Objective-C: https://reviews.llvm.org/source/llvm-github/browse/master/clang/lib/Format/Format.cpp$

[PATCH] D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM.

benhamilton accepted this revision. benhamilton added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65012/new/ https://reviews.llvm.org/D65012

[PATCH] D65000: [ARM] Set default alignment to 64bits

peter.smith added a comment. test case missing A8 aside this looks ok to me. Would like to see if there are any comments from the Pacific time zone. Comment at: test/CodeGen/ARM/exception-alignment.cpp:8 +// A16-NEXT: store <2 x i64> , <2 x i64>* [[BC]], align 16 +#include +

[PATCH] D65100: [clangd] Fix SelectionTree traversal of qualified types

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. QualifiedTypeLoc isn't treated like a regular citizen by RecursiveASTVisitor. This meant we weren't inter

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

xazax.hun updated this revision to Diff 211127. xazax.hun marked 5 inline comments as done. xazax.hun added a comment. - Address the rest of the review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64256/new/ https://reviews.llvm.org/D64256 Files: clang/include/clang/Basic/

r366699 - [X86] Remove const from some intrinsics that shouldn't have them

Author: probinson Date: Mon Jul 22 09:14:09 2019 New Revision: 366699 URL: http://llvm.org/viewvc/llvm-project?rev=366699&view=rev Log: [X86] Remove const from some intrinsics that shouldn't have them Modified: cfe/trunk/lib/Headers/emmintrin.h Modified: cfe/trunk/lib/Headers/emmintrin.h URL

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

Szelethus updated this revision to Diff 29. Szelethus added a comment. I plan to split this patch up eventually, but here's where I'm standing right now: - Correct the algorithm that by accident did this: `GEN[B] = GEN[B] union (IN[B] - KILL[B])` instead of this: `OUT[B] = GEN[B] union (IN[

[clang-tools-extra] r366698 - [clangd] Add dlog()s for SelectionTree, enabling -debug-only=SelectionTree.cpp

Author: sammccall Date: Mon Jul 22 08:55:53 2019 New Revision: 366698 URL: http://llvm.org/viewvc/llvm-project?rev=366698&view=rev Log: [clangd] Add dlog()s for SelectionTree, enabling -debug-only=SelectionTree.cpp Summary: SelectionTree is a RecursiveASTVisitor which processes getSourceRange() f

r366698 - [clangd] Add dlog()s for SelectionTree, enabling -debug-only=SelectionTree.cpp

Author: sammccall Date: Mon Jul 22 08:55:53 2019 New Revision: 366698 URL: http://llvm.org/viewvc/llvm-project?rev=366698&view=rev Log: [clangd] Add dlog()s for SelectionTree, enabling -debug-only=SelectionTree.cpp Summary: SelectionTree is a RecursiveASTVisitor which processes getSourceRange() f

[PATCH] D64739: [SVE][Inline-Asm] Add support to specify SVE registers in the clobber list

kmclaughlin updated this revision to Diff 24. kmclaughlin added a comment. - Updated test to remove unused variable 't' CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64739/new/ https://reviews.llvm.org/D64739 Files: clang/lib/Basic/Targets/AArch64.cpp clang/test/CodeGen/aarch64

[PATCH] D64241: [ASTImporter] Fix inequivalence of ClassTemplateInstantiations

martong added a comment. @a_sidorin This is a polite Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64241/new/ https://reviews.llvm.org/D64241 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D65000: [ARM] Set default alignment to 64bits

dnsampaio updated this revision to Diff 211103. dnsampaio added a comment. - Joined assignments for default alignments and neon_vector alignment Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 Files: lib/Basic/Targets/A

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini added a comment. FYI In order to fix buildbot test failures, I've pushed https://reviews.llvm.org/rG1b2da771f561affe36eb5eb0c7a3d2862c5a5c1c. I'll keep an eye on buildbots for additional fallout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

r366694 - [NFC] Relaxed regression tests for PR42665

Author: mantognini Date: Mon Jul 22 07:47:36 2019 New Revision: 366694 URL: http://llvm.org/viewvc/llvm-project?rev=366694&view=rev Log: [NFC] Relaxed regression tests for PR42665 Following up on the buildbot failures, this commits relaxes some tests: instead of checking for specific IR output, i

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong added a comment. @a_sidorin, @shafik This is a polite Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44100/new/ https://reviews.llvm.org/D44100 ___ cfe-commits mailing list cfe-commits@lis

  1   2   >