[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

aheejin updated this revision to Diff 218834. aheejin added a comment. - Remove a blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67208/new/ https://reviews.llvm.org/D67208 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

aheejin created this revision. aheejin added reviewers: dschuff, tlively. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, aprantl. Herald added a project: clang. This adds `-fwasm-exceptions` (in similar fashion with `-fdwarf-exceptions` or `-fsjlj-exceptions`) that

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

zsrkmyn updated this revision to Diff 218830. zsrkmyn retitled this revision from "[clang][CodeGen] Add alias for cpu_dispatch function with IFunc" to "[clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type". CHANGES SINCE LAST ACTION

[PATCH] D66198: AMDGPU: Add builtins for is_local/is_private

arsenm closed this revision. arsenm added a comment. r371010 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66198/new/ https://reviews.llvm.org/D66198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r371010 - AMDGPU: Add builtins for is_shared/is_private

Author: arsenm Date: Wed Sep 4 20:00:43 2019 New Revision: 371010 URL: http://llvm.org/viewvc/llvm-project?rev=371010=rev Log: AMDGPU: Add builtins for is_shared/is_private Added: cfe/trunk/test/SemaOpenCL/builtins-amdgcn-error-flat-address-space.cl Modified:

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc

zsrkmyn added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2957 +if (!AliasFunc) { + auto *IFunc = cast(GetOrCreateLLVMFunction( + AliasName, DeclTy, GD, /*ForVTable=*/false, /*DontDefer=*/true, erichkeane wrote: >

[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

ahatanak added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11176 for (const FieldDecl *FD : RD->fields()) - asDerived().visit(FD->getType(), FD, InNonTrivialUnion); + if (!FD->hasAttr()) +asDerived().visit(FD->getType(), FD, InNonTrivialUnion);

[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

ahatanak updated this revision to Diff 218826. ahatanak marked 2 inline comments as done. ahatanak added a comment. Address review comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65256/new/ https://reviews.llvm.org/D65256 Files:

r371004 - [c++20] Fix some ambiguities in our mangling of lambdas with explicit

Author: rsmith Date: Wed Sep 4 18:23:47 2019 New Revision: 371004 URL: http://llvm.org/viewvc/llvm-project?rev=371004=rev Log: [c++20] Fix some ambiguities in our mangling of lambdas with explicit template parameters. This finishes the implementation of the proposal described in

[PATCH] D67127: [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization

arphaman updated this revision to Diff 218821. arphaman added a comment. restructure the code to perform skipping directly in the preprocessor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67127/new/ https://reviews.llvm.org/D67127 Files:

[PATCH] D66569: [analyzer] ccc-analyzer: handle --sysroot=/path in addition to --sysroot /path

This revision was automatically updated to reflect the committed changes. Closed by commit rL371002: [analyzer] scan-build: handle --sysroot=/path in addition to --sysroot /path. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

r371002 - [analyzer] scan-build: handle --sysroot=/path in addition to --sysroot /path.

Author: dergachev Date: Wed Sep 4 17:44:56 2019 New Revision: 371002 URL: http://llvm.org/viewvc/llvm-project?rev=371002=rev Log: [analyzer] scan-build: handle --sysroot=/path in addition to --sysroot /path. Current code assumes flags in CompilerLinkerOptionMap don't use =, which isn't always

[PATCH] D67202: Implement Microsoft-compatible mangling for decomposition declarations.

thakis added a comment. Does this pass `ninja check-clang`? If so, can you add a test for the new mangling, based on the manglings in the godbolt example? See `clang/test/CodeGenCXX/mangle-ms-*` for many examples; a new file mangle-ms-cxx20.cpp might be appropriate here. You can run

[PATCH] D67202: Implement Microsoft-compatible mangling for decomposition declarations.

thakis added a comment. ps: Thanks for the patch, this is great :) pps: Since this uses struct mangling, `llvm-undname` can already demangle these names, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67202/new/

Re: r369943 - FileManager: Use llvm::Expected in new getFileRef API

On Mon, Aug 26, 2019 at 11:28 AM Duncan P. N. Exon Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dexonsmith > Date: Mon Aug 26 11:29:51 2019 > New Revision: 369943 > > URL: http://llvm.org/viewvc/llvm-project?rev=369943=rev > Log: > FileManager: Use llvm::Expected in new

[PATCH] D67202: Implement Microsoft-compatible mangling for decomposition declarations.

epastor created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Match cl.exe's mangling for decomposition declarations. Decomposition declarations are considered to be anonymous structs, and use the same convention as for anonymous struct/union

[PATCH] D67077: [libclang] Refactored SharedParsedRegionsStorage

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. Thanks for polishing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67077/new/ https://reviews.llvm.org/D67077

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood updated this revision to Diff 218812. dgatwood marked 22 inline comments as done. dgatwood added a comment. Incorporated additional feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65917/new/ https://reviews.llvm.org/D65917 Files:

[PATCH] D67200: Add -static-openmp driver option

pirama created this revision. pirama added reviewers: Hahnfeld, danalbert, srhines, joerg. Herald added a subscriber: guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. This option forces linking with the static OpenMP host runtime (similar to -static-libgcc and

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11067 + + // Do not diagnose 2 ^ 64, but allow special case (2 ^ 64) - 1. + if (SubLHS && SubRHS && (LeftSideValue != 2 || RightSideValue != 64))

[PATCH] D67159: [clang] New __attribute__((__clang_builtin)).

aaron.ballman added a comment. I share in the discomfort expressed for this attribute, but I don't have a better solution in mind just yet, so I'm giving some other review feedback in the meantime. Comment at: clang/include/clang/Basic/Attr.td:596 } +def

r370991 - For PR43213, track whether template parameters are implicit through

Author: rsmith Date: Wed Sep 4 15:14:50 2019 New Revision: 370991 URL: http://llvm.org/viewvc/llvm-project?rev=370991=rev Log: For PR43213, track whether template parameters are implicit through template instantiation so we know whether to mangle them in lambda-expressions. Modified:

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang updated this revision to Diff 218795. akhuang added a comment. - Change existing tests so they still pass - Fix so that it parses all the __ptr32/64 attributes instead of just the last one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

jfb added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11067 + + // Do not diagnose 2 ^ 64, but allow special case (2 ^ 64) - 1. + if (SubLHS && SubRHS && (LeftSideValue != 2 || RightSideValue != 64)) xbolva00 wrote: > xbolva00 wrote: > > aaron.ballman

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp:76 + else if (TypePtr->isFloatingType()) { +InitializationString = " = NAN"; +AddMathInclude = true; jpakkane wrote: > aaron.ballman

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

majnemer added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1718 QualType PointeeType) { - if (PointersAre64Bit && - (PointeeType.isNull() || !PointeeType->isFunctionType())) + // Check if this

[PATCH] D66569: [analyzer] ccc-analyzer: handle --sysroot=/path in addition to --sysroot /path

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks!! I wish i had time to fix D55683 so that i could have you write tests for it :) Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. Ok, I will fix it as you suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66569: [analyzer] ccc-analyzer: handle --sysroot=/path in addition to --sysroot /path

chris.laplante added a comment. Correct, no access so please commit for me. This is my first contribution. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66569/new/ https://reviews.llvm.org/D66569 ___ cfe-commits

[PATCH] D66919: Warn about zero-parameter K definitions in -Wstrict-prototypes

aaronpuchert added a comment. In D66919#1658355 , @aaron.ballman wrote: > We do have numerous warnings that are default errors, you can look for > `DefaultError` in the diagnostic .td files to see the uses. Thanks, I hadn't seen that before. It seems

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

aaron.ballman added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11067 + + // Do not diagnose 2 ^ 64, but allow special case (2 ^ 64) - 1. + if (SubLHS && SubRHS && (LeftSideValue != 2 || RightSideValue != 64)) jfb wrote: > xbolva00 wrote: > > xbolva00

[PATCH] D66569: [analyzer] ccc-analyzer: handle --sysroot=/path in addition to --sysroot /path

chris.laplante added a comment. In D66569#1658413 , @NoQ wrote: > I wish i had time to fix D55683 so that i > could have you write tests for it :) I just subscribed to it, so if/when you do, I'll add some tests :)

[PATCH] D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths.

vsapsai updated this revision to Diff 218794. vsapsai added a comment. Herald added a subscriber: ributzka. - Rebase the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58094/new/ https://reviews.llvm.org/D58094 Files: clang/include/clang/Lex/DirectoryLookup.h

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11067 + + // Do not diagnose 2 ^ 64, but allow special case (2 ^ 64) - 1. + if (SubLHS && SubRHS && (LeftSideValue != 2 || RightSideValue != 64))

[PATCH] D66569: [analyzer] ccc-analyzer: handle --sysroot=/path in addition to --sysroot /path

NoQ added a comment. You don't have commit access, right? Do you want me to commit this patch for you? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66569/new/ https://reviews.llvm.org/D66569 ___ cfe-commits

[PATCH] D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58094/new/ https://reviews.llvm.org/D58094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

aaron.ballman added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11067 + + // Do not diagnose 2 ^ 64, but allow special case (2 ^ 64) - 1. + if (SubLHS && SubRHS && (LeftSideValue != 2 || RightSideValue != 64)) xbolva00 wrote: > xbolva00 wrote: > >

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/google/RequireCategoryMethodPrefixesCheck.cpp:16 +namespace { +const char *kCustomCategoryMethodIdentifier = "ThisIsACategoryMethod"; +} // anonymous namespace Eugene.Zelenko wrote: >

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4538 + llvm::Value * /*OffsetOverflows*/> +EmitGEPOffsetInBytes(Value *BasePtr, Value *GEPVal, + llvm::LLVMContext , CodeGenModule , vsk wrote: >

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

lebedev.ri updated this revision to Diff 218792. lebedev.ri marked 25 inline comments as done. lebedev.ri added a comment. @vsk thank you for taking a look! I believe i have addressed or replied to all the comments. Other than the optimization comment, i currently don't believe that is a sound

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11067 + + // Do not diagnose 2 ^ 64, but allow special case (2 ^ 64) - 1. + if (SubLHS && SubRHS && (LeftSideValue != 2 || RightSideValue != 64))

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11067 + + // Do not diagnose 2 ^ 64, but allow special case (2 ^ 64) - 1. + if (SubLHS && SubRHS && (LeftSideValue != 2 || RightSideValue != 64))

r370987 - [www] Fix hyperlink syntax in attribute reference.

Author: rsmith Date: Wed Sep 4 14:31:22 2019 New Revision: 370987 URL: http://llvm.org/viewvc/llvm-project?rev=370987=rev Log: [www] Fix hyperlink syntax in attribute reference. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/include/clang/Basic/AttrDocs.td URL:

r370986 - [www] Update attribute reference for 'constinit'.

Author: rsmith Date: Wed Sep 4 14:31:21 2019 New Revision: 370986 URL: http://llvm.org/viewvc/llvm-project?rev=370986=rev Log: [www] Update attribute reference for 'constinit'. Modified: cfe/trunk/include/clang/Basic/Attr.td cfe/trunk/include/clang/Basic/AttrDocs.td Modified:

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

aaron.ballman added a comment. In D67140#1658353 , @gribozavr wrote: > In D67140#1658315 , @aaron.ballman > wrote: > > > In D67140#1656831 , @NoQ wrote: > > > > > Honestly,

[PATCH] D66919: Warn about zero-parameter K definitions in -Wstrict-prototypes

aaron.ballman added a comment. In D66919#1655052 , @aaronpuchert wrote: > In D66919#1655048 , @dexonsmith > wrote: > > > I went back to read notes from when we deployed `-Wstrict-prototypes` > > (which we have

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

aaron.ballman added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11067 + + // Do not diagnose 2 ^ 64, but allow special case (2 ^ 64) - 1. + if (SubLHS && SubRHS && (LeftSideValue != 2 || RightSideValue != 64)) aaron.ballman wrote: > This comment

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

gribozavr added a comment. In D67140#1658315 , @aaron.ballman wrote: > In D67140#1656831 , @NoQ wrote: > > > Honestly, i'm much more worried about message capitalization :) > > > Likewise. I wish the static

[PATCH] D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field

congliu updated this revision to Diff 218789. congliu added a comment. Uploaded the correct diff... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67135/new/ https://reviews.llvm.org/D67135 Files: clang-tools-extra/clang-tidy/performance/InefficientVectorOperationCheck.cpp

[PATCH] D64644: [Sema] Fixes an assertion failure while instantiation a template with an incomplete typo corrected type

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:727 return DependentScopeDeclRefExpr::Create( - Context, SS.getWithLocInContext(Context), TemplateKWLoc, NameInfo, - TemplateArgs); + Context, std::move(QualifierLoc),

r370982 - Diagnose _Atomic as a C11 extension.

Author: aaronballman Date: Wed Sep 4 14:01:57 2019 New Revision: 370982 URL: http://llvm.org/viewvc/llvm-project?rev=370982=rev Log: Diagnose _Atomic as a C11 extension. Modified: cfe/trunk/lib/Parse/ParseDecl.cpp cfe/trunk/test/Parser/atomic.c cfe/trunk/test/SemaCXX/atomic-type.cpp

[PATCH] D67141: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator.

ychen added a comment. In D67141#1658238 , @rnk wrote: > lgtm, thanks! Thank you! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67141/new/ https://reviews.llvm.org/D67141

[PATCH] D67141: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370981: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator. (authored by yuanfang, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D67127: [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization

Bigcheese added a comment. Looking more into this I'm not sure you need the PPCallbacks. The Preprocessor should just own the PreprocessorSkippedMappings data structure and the dependency scanner can update it live. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7460 + // the initializing expression type during the type deduction. + (T->isUndeducedAutoType() && IsPointee) || // OpenCL spec v2.0 s6.9.b: Okay, I understand why you're

[PATCH] D67023: Diagnose use of ATOMIC_VAR_INIT

aaron.ballman added a comment. In D67023#1656453 , @jfb wrote: > In D67023#1654704 , @aaron.ballman > wrote: > > > In D67023#1654070 , @jfb wrote: > > > > > I refer you to

r370981 - [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator.

Author: yuanfang Date: Wed Sep 4 13:58:15 2019 New Revision: 370981 URL: http://llvm.org/viewvc/llvm-project?rev=370981=rev Log: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator. This essentially reverts changes from r361400 while keeping behavior for CodeView.

[PATCH] D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field

congliu added a comment. In D67135#1657034 , @lebedev.ri wrote: > I'm not sure this is the correct approach. > I'd think the check instead should be parametrized, so this patch should > become just extending the config. Could you elaborate how the

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

aaron.ballman added a comment. In D67140#1656831 , @NoQ wrote: > Honestly, i'm much more worried about message capitalization :) Likewise. I wish the static analyzer would follow the usual conventions followed by clang and clang-tidy. ;-) In

[PATCH] D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field

congliu updated this revision to Diff 218782. congliu added a comment. Updated option descriptions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67135/new/ https://reviews.llvm.org/D67135 Files: clang-tools-extra/docs/clang-tidy/checks/performance-inefficient-vector-operation.rst

[PATCH] D66988: [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes

This revision was automatically updated to reflect the committed changes. Closed by commit rL370971: [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes (authored by leonardchan, committed by ). Changed prior to commit: https://reviews.llvm.org/D66988?vs=218008=218781#toc

r370972 - [c++20] P1143R2: Add support for the C++20 'constinit' keyword.

Author: rsmith Date: Wed Sep 4 13:30:37 2019 New Revision: 370972 URL: http://llvm.org/viewvc/llvm-project?rev=370972=rev Log: [c++20] P1143R2: Add support for the C++20 'constinit' keyword. This is mostly the same as the [[clang::require_constant_initialization]] attribute, but has a couple of

r370970 - Generate parent context id from Decl* instead of DeclContext*.

Author: aaronballman Date: Wed Sep 4 13:30:00 2019 New Revision: 370970 URL: http://llvm.org/viewvc/llvm-project?rev=370970=rev Log: Generate parent context id from Decl* instead of DeclContext*. Because of multiple inheritance, a DeclContext pointer does not produce the same pointer

r370971 - [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes

Author: leonardchan Date: Wed Sep 4 13:30:29 2019 New Revision: 370971 URL: http://llvm.org/viewvc/llvm-project?rev=370971=rev Log: [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes This patch merges the sancov module and funciton passes into one module pass. The reason for this is

[PATCH] D67057: [AST][JSON] Generate parent context id from Decl* instead of DeclContext*

aaron.ballman closed this revision. aaron.ballman added a comment. In D67057#1658217 , @piscisaureus wrote: > Fixed nit, this is ready to land IMO. Thanks! I've commit on your behalf in r370970. CHANGES SINCE LAST ACTION

[PATCH] D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm with the GlobalArrayDestructor name. Comment at: include/clang/AST/GlobalDecl.h:34 AtExit, + GlobalDestructor }; Maybe we should rename this

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44 -#include -#include -#include -#include Hahnfeld wrote: > sdmitriev wrote: > > Hahnfeld wrote: > > >

[PATCH] D67127: [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization

arphaman added inline comments. Comment at: clang/include/clang/Frontend/CompilerInstance.h:256 + /// preprocessor. + void setAdditionalPPCallbacks(std::unique_ptr PPC); + Bigcheese wrote: > This kinda sounds like it can be called multiple times. Is there any

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev updated this revision to Diff 218776. sdmitriev edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 Files: clang/test/Driver/clang-offload-bundler.c

[PATCH] D67127: [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization

arphaman updated this revision to Diff 218778. arphaman marked 2 inline comments as done. arphaman added a comment. Add support for chained PP callbacks in setAdditionalPPCallbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67127/new/

[PATCH] D67141: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67141/new/ https://reviews.llvm.org/D67141

[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

rjmccall added inline comments. Comment at: include/clang/AST/ASTContext.h:2060 + /// attr::ObjCOwnership implies an ownership qualifier was explicitly + /// specified rather than being added implicitly by the compiler. + bool isObjCOwnershipAttributedType(QualType Ty) const;

[PATCH] D67057: [AST][JSON] Generate parent context id from Decl* instead of DeclContext*

piscisaureus marked an inline comment as done. piscisaureus added a comment. Fixed nit, this is ready to land IMO. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67057/new/ https://reviews.llvm.org/D67057 ___ cfe-commits mailing list

[PATCH] D67057: [AST][JSON] Generate parent context id from Decl* instead of DeclContext*

piscisaureus updated this revision to Diff 218770. piscisaureus added a comment. fix nit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67057/new/ https://reviews.llvm.org/D67057 Files: clang/lib/AST/JSONNodeDumper.cpp clang/test/AST/ast-dump-decl-context-json.cpp

[PATCH] D67141: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator.

ychen updated this revision to Diff 218769. ychen added a comment. - address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67141/new/ https://reviews.llvm.org/D67141 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/enum2.c

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

Hahnfeld added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44 -#include -#include -#include -#include sdmitriev wrote: > Hahnfeld wrote: > > sdmitriev wrote: > > > Hahnfeld wrote: > > > > sdmitriev wrote: > > > >

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44 -#include -#include -#include -#include Hahnfeld wrote: > sdmitriev wrote: > > Hahnfeld wrote: > > >

[PATCH] D67185: [RISCV] Add support for -ffixed-xX flags

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/RISCV/reserved-regs.ll:71 + +; X1-NOT: lw ra, +; X1-NOT: ld ra, lenary wrote: > These tests aren't going to test what you think they are, or at least aren't > going to fail when you hope they are, as

[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

ahatanak added inline comments. Comment at: include/clang/AST/ASTContext.h:2060 + /// attr::ObjCOwnership implies an ownership qualifier was explicitly + /// specified rather than being added implicitly by the compiler. + bool isObjCOwnershipAttributedType(QualType Ty) const;

[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

ahatanak updated this revision to Diff 218767. ahatanak marked 3 inline comments as done. ahatanak added a comment. Address review comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65256/new/ https://reviews.llvm.org/D65256 Files:

[PATCH] D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

rnk added a comment. I'm trying to figure out what exactly the new GlobalDestructor thing is. :) It's not clear to me why we ever emit `__cxx_global_array_dtor` in the MS ABI. We always call it directly from the `?__F` atexit helper stub instead of registering it, so we really don't need it at

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

vsk added a subscriber: dtzWill. vsk added a comment. Thanks, this is looking pretty good. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4538 + llvm::Value * /*OffsetOverflows*/> +EmitGEPOffsetInBytes(Value *BasePtr, Value *GEPVal, +

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

Hahnfeld added a comment. Also, there should be a summary of the changes in here. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44 -#include -#include -#include -#include sdmitriev wrote: > Hahnfeld wrote: > > sdmitriev wrote: >

[PATCH] D67141: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator.

rnk added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4441-4462 + // Use global variables for enums in CodeView, use DW_TAG_enumeration_type for + // enums for non-CodeView. if (const auto *ECD = dyn_cast(VD)) { const auto *ED =

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev updated this revision to Diff 218755. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp Index:

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

nand added a reviewer: rnk. nand added a subscriber: rnk. nand added a comment. @jfb suggested I add @rnk: I was wondering if you have any suggestions on how to fix the msvc warnings/errors? I'd be grateful if I had some feedback on what features of C++ I should avoid using and what I should

[PATCH] D67141: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator.

akhuang added a comment. What is the reason for this change? The test case and comment changes don't seem related to the actual code change, which would affect `DIGlobalVariable`s. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67141/new/

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44 -#include -#include -#include -#include Hahnfeld wrote: > sdmitriev wrote: > > Hahnfeld wrote: > > > The

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

Hahnfeld added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44 -#include -#include -#include -#include sdmitriev wrote: > Hahnfeld wrote: > > The code still uses (in the order of marked includes) > > *

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev marked an inline comment as done. sdmitriev added a comment. Any comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument.

xyb marked 2 inline comments as done. xyb added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp:28 + IgnoreSingleArgument( + Options.getLocalOrGlobal("IgnoreSingleArgument", 0) != 0),

[PATCH] D67174: Rename of constants in ASTImporterVisibilityTest. NFC.

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. Thank you! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67174/new/ https://reviews.llvm.org/D67174

[PATCH] D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument.

xyb updated this revision to Diff 218741. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67056/new/ https://reviews.llvm.org/D67056 Files: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.h

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

This revision was automatically updated to reflect the committed changes. jdoerfert marked an inline comment as done. Closed by commit rL370930: [OpenMP][Docs] Provide implementation status details (authored by jdoerfert, committed by ). Herald added a project: LLVM. Herald added a subscriber:

r370930 - [OpenMP][Docs] Provide implementation status details

Author: jdoerfert Date: Wed Sep 4 10:15:37 2019 New Revision: 370930 URL: http://llvm.org/viewvc/llvm-project?rev=370930=rev Log: [OpenMP][Docs] Provide implementation status details This adds a more fine-grained list of OpenMP features with their implementation status and associated

[PATCH] D65527: Avoid assemble step in verbose-output-quoting.c

This revision was automatically updated to reflect the committed changes. Closed by commit rL370928: Avoid assemble step in verbose-output-quoting.c (authored by yuanfang, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r370928 - Avoid assemble step in verbose-output-quoting.c

Author: yuanfang Date: Wed Sep 4 10:10:18 2019 New Revision: 370928 URL: http://llvm.org/viewvc/llvm-project?rev=370928=rev Log: Avoid assemble step in verbose-output-quoting.c Reviewers: hans Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D65527

[PATCH] D67185: [RISCV] Add support for -ffixed-xX flags

lenary added a comment. I don't quite understand all the details of this patch. I understand reserving registers that the compiler would otherwise be using as general-purpose registers. But what do we do about using registers within the calling convention when someone says they should be

[PATCH] D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked.

alexfh added a comment. In D67084#1657534 , @xyb wrote: > Thanks. BTW, I can't commit the patch by myself. The patch doesn't apply cleanly. Please rebase it against current HEAD. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67084/new/

[PATCH] D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument.

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp:28 + IgnoreSingleArgument( + Options.getLocalOrGlobal("IgnoreSingleArgument", 0) != 0),

  1   2   3   >