[PATCH] D66862: Make lround builtin constexpr (and others)

zoecarver added a comment. Ping. Anything else I am missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66862/new/ https://reviews.llvm.org/D66862 ___ cfe-commits mailing list

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

This revision was automatically updated to reflect the committed changes. Closed by commit rL371708: [WebAssembly] Add -fwasm-exceptions for wasm EH (authored by aheejin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r371708 - [WebAssembly] Add -fwasm-exceptions for wasm EH

Author: aheejin Date: Wed Sep 11 21:01:37 2019 New Revision: 371708 URL: http://llvm.org/viewvc/llvm-project?rev=371708=rev Log: [WebAssembly] Add -fwasm-exceptions for wasm EH Summary: This adds `-fwasm-exceptions` (in similar fashion with `-fdwarf-exceptions` or `-fsjlj-exceptions`) that turns

[PATCH] D67473: [clang-tidy] Fix build with -DBUILD_SHARED_LIB=ON

This revision was automatically updated to reflect the committed changes. Closed by commit rL371706: [clang-tidy] Fix build with -DBUILD_SHARED_LIB=ON (authored by aheejin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D67473: [clang-tidy] Fix build with -DBUILD_SHARED_LIB=ON

aheejin added a comment. I think that's it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67473/new/ https://reviews.llvm.org/D67473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r371706 - [clang-tidy] Fix build with -DBUILD_SHARED_LIB=ON

Author: aheejin Date: Wed Sep 11 20:10:57 2019 New Revision: 371706 URL: http://llvm.org/viewvc/llvm-project?rev=371706=rev Log: [clang-tidy] Fix build with -DBUILD_SHARED_LIB=ON Summary: This fixes build failures with `-DBUILD_SHARED_LIB=ON` after D67419. Reviewers: NoQ Subscribers: mgorny,

[PATCH] D67463: [MS] Warn when shadowing template parameters under -fms-compatibility

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Nice! Hopefully this is rare enough that putting it under an existing warning flag won't be too inconvenient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#1666924 , @JonChesterfield wrote: > In D64943#1666849 , @sdmitriev wrote: > > > In D64943#136 , > > @JonChesterfield wrote: > > >

[PATCH] D67473: [clang-tidy] Fix build with -DBUILD_SHARED_LIB=ON

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Aha, nice, thank you!! Is this http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage/builds/10728 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

r371697 - [clang-scan-deps] Add dependency targets

Author: jkorous Date: Wed Sep 11 17:48:45 2019 New Revision: 371697 URL: http://llvm.org/viewvc/llvm-project?rev=371697=rev Log: [clang-scan-deps] Add dependency targets Differential Revision: https://reviews.llvm.org/D67475 Modified:

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

poelmanc added a comment. Wow, thanks for the super-quick testing, feedback and a new test case! I added a slightly enhanced version of your test case to the modernize-use-using.cpp test file and got it passing by treating tok::less and tok::right as AngleBrackets //only when ParenLevel ==

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

poelmanc updated this revision to Diff 219834. poelmanc edited the summary of this revision. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67460/new/ https://reviews.llvm.org/D67460 Files: clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp

Buildbot numbers for the week of 08/18/2019 - 08/24/2019

Hello everyone, Below are some buildbot numbers for the week of 08/18/2019 - 08/24/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

Buildbot numbers for the week of 08/25/2019 - 08/31/2019

Hello everyone, Below are some buildbot numbers for the week of 08/25/2019 - 08/31/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D67473: [clang-tidy] Fix build with -DBUILD_SHARED_LIB=ON

aheejin created this revision. aheejin added a reviewer: NoQ. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. This fixes build failures with `-DBUILD_SHARED_LIB=ON` after D67419 . Repository: rG LLVM Github Monorepo

r371694 - [X86] Enable -mprefer-vector-width=256 by default for Skylake-avx512 and later Intel CPUs.

Author: ctopper Date: Wed Sep 11 16:54:36 2019 New Revision: 371694 URL: http://llvm.org/viewvc/llvm-project?rev=371694=rev Log: [X86] Enable -mprefer-vector-width=256 by default for Skylake-avx512 and later Intel CPUs. AVX512 instructions can cause a frequency drop on these CPUs. This can

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ updated this revision to Diff 219829. NoQ added a comment. Herald added a subscriber: mgorny. Unforget to actually move the consumer implementations to `libAnalysis`, not just their headers. Casually rename

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

phosek added a comment. @dankm do you still plan to work on this? We would really like to see this landed and we could help if needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466

[PATCH] D67249: [Modules][PCH] Hash input files content

ributzka added a comment. Did you try xxHash64? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67249/new/ https://reviews.llvm.org/D67249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

NoQ updated this revision to Diff 219826. NoQ added a comment. Clean up a tiny bit of dead code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67420/new/ https://reviews.llvm.org/D67420 Files: clang/include/clang/Analysis/PathDiagnostic.h

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

jonathanmeier added a comment. With non-type template parameters we can have expressions inside template arguments, including comparison operators like `<`, `<=`, `>` and `>=`, which lets us write typedefs like this: template struct S {}; typedef S<(0 < 0)> S_t, *S_p; Unfortunately,

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

NoQ updated this revision to Diff 219824. NoQ added a comment. Rename `BugType` to `WarningMessage`, add comments. Get rid of an unnecessary `SourceManager` parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67421/new/ https://reviews.llvm.org/D67421 Files:

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

NoQ updated this revision to Diff 219821. NoQ added a comment. Unforget to do the same for the text consumer. As a side effect, the factory function for the text consumer is no longer special, which will be less confusing when put in libAnalysis. Address minor comments, don't address major

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

erik.pilkington added a comment. In D66856#116 , @aaron.ballman wrote: > The reflector discussion is still happening and there are issues with > ambiguities that we are pretty sure we want to correct. I've got a paper out > that touches on some of

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

erik.pilkington updated this revision to Diff 219815. erik.pilkington marked 6 inline comments as done. erik.pilkington added a comment. Update the diagnostic text. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66856/new/ https://reviews.llvm.org/D66856 Files:

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 5PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67467: [ARM] Update clang for removal of vfp2d16 and vfp2d16sp

efriedma created this revision. efriedma added a reviewer: ostannard. Herald added a subscriber: kristof.beyls. Herald added a project: clang. Matching fix for https://reviews.llvm.org/D67375 . Repository: rC Clang https://reviews.llvm.org/D67467 Files: lib/Basic/Targets/ARM.cpp

r371665 - Fix up a test updated in r371655 - require case-insensitive file system.

Author: vsapsai Date: Wed Sep 11 14:19:27 2019 New Revision: 371665 URL: http://llvm.org/viewvc/llvm-project?rev=371665=rev Log: Fix up a test updated in r371655 - require case-insensitive file system. On case-sensitive file systems include with wrong case is not found instead of showing a

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

JonChesterfield added a comment. In D64943#1666849 , @sdmitriev wrote: > In D64943#136 , @JonChesterfield > wrote: > > > I'm not sure copying the crtbegin/crtend mechanism from the early days of C > > runtime

r371664 - [clang-scan-deps] cast Result to ErrorOr> explicitly to avoid s390x-linux buildbot failure

Author: arphaman Date: Wed Sep 11 14:00:13 2019 New Revision: 371664 URL: http://llvm.org/viewvc/llvm-project?rev=371664=rev Log: [clang-scan-deps] cast Result to ErrorOr> explicitly to avoid s390x-linux buildbot failure Modified:

[PATCH] D67454: Start porting ivfsoverlay tests to Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL371663: Start porting ivfsoverlay tests to Windows (authored by rnk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r371663 - Start porting ivfsoverlay tests to Windows

Author: rnk Date: Wed Sep 11 13:56:25 2019 New Revision: 371663 URL: http://llvm.org/viewvc/llvm-project?rev=371663=rev Log: Start porting ivfsoverlay tests to Windows Part of PR43272, the changes are: 1. Use @ as the sed pattern delimiter instead of : so that the drive letter in lit

[PATCH] D67382: [analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371659: [analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D67418: [analyzer] NFC: Move PathDiagnostic::resetDiagnosticLocationToMainFile to bug reporter.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371660: [analyzer] NFC: Move resetDiagnosticLocationToMainFile() to BugReporter. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D67381: [analyzer] NFC: Move stack hints to a side map.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371658: [analyzer] NFC: Re-implement stack hints as a side map in BugReport. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D67419: [analyzer] NFC: Move PathDiagnostic to libAnalysis.

NoQ marked 2 inline comments as done. NoQ added a comment. In D67419#1665993 , @Szelethus wrote: > Looks great! Are we sure that `PathDiagnostic.h` is a good header name? Not really, but i haven't come up with a better name yet (see also the summary of

[PATCH] D67381: [analyzer] NFC: Move stack hints to a side map.

NoQ marked 2 inline comments as done. NoQ added a comment. In D67381#1665930 , @Szelethus wrote: > Side note, now that you had to work with the freshly rewritten file, do you > have any feedback on it? Dunno, i'm a very functional / pure / stateless

[clang-tools-extra] r371661 - [analyzer] NFC: Move PathDiagnostic classes to libAnalysis.

Author: dergachev Date: Wed Sep 11 13:54:27 2019 New Revision: 371661 URL: http://llvm.org/viewvc/llvm-project?rev=371661=rev Log: [analyzer] NFC: Move PathDiagnostic classes to libAnalysis. At this point the PathDiagnostic, PathDiagnosticLocation, PathDiagnosticPiece structures no longer rely

r371659 - [analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic.

Author: dergachev Date: Wed Sep 11 13:54:21 2019 New Revision: 371659 URL: http://llvm.org/viewvc/llvm-project?rev=371659=rev Log: [analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic. These static functions deal with ExplodedNodes which is something we don't want the

r371660 - [analyzer] NFC: Move resetDiagnosticLocationToMainFile() to BugReporter.

Author: dergachev Date: Wed Sep 11 13:54:24 2019 New Revision: 371660 URL: http://llvm.org/viewvc/llvm-project?rev=371660=rev Log: [analyzer] NFC: Move resetDiagnosticLocationToMainFile() to BugReporter. This method of PathDiagnostic is a part of Static Analyzer's particular path diagnostic

r371658 - [analyzer] NFC: Re-implement stack hints as a side map in BugReport.

Author: dergachev Date: Wed Sep 11 13:54:17 2019 New Revision: 371658 URL: http://llvm.org/viewvc/llvm-project?rev=371658=rev Log: [analyzer] NFC: Re-implement stack hints as a side map in BugReport. That's one of the few random entities in the PathDiagnostic interface that are specific to the

[PATCH] D67455: [Clang][CodeGen] support alias attribute w/ gnu_inline

nickdesaulniers updated this revision to Diff 219790. nickdesaulniers added a comment. - adjust parens Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67455/new/ https://reviews.llvm.org/D67455 Files: clang/lib/AST/Decl.cpp

[PATCH] D67127: [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization

This revision was automatically updated to reflect the committed changes. Closed by commit rL371656: [clang-scan-deps] add skip excluded conditional preprocessor block… (authored by arphaman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371655: Fix -Wnonportable-include-path suppression for header maps with absolute paths. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

r371656 - [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization

Author: arphaman Date: Wed Sep 11 13:40:31 2019 New Revision: 371656 URL: http://llvm.org/viewvc/llvm-project?rev=371656=rev Log: [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization This commit adds an optimization to clang-scan-deps and clang's

r371655 - Fix -Wnonportable-include-path suppression for header maps with absolute paths.

Author: vsapsai Date: Wed Sep 11 13:39:04 2019 New Revision: 371655 URL: http://llvm.org/viewvc/llvm-project?rev=371655=rev Log: Fix -Wnonportable-include-path suppression for header maps with absolute paths. In `DirectoryLookup::LookupFile` parameter `HasBeenMapped` doesn't cover the case when

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#136 , @JonChesterfield wrote: > I'm not sure copying the crtbegin/crtend mechanism from the early days of C > runtime is ideal. Since the data is stored in a common section anyway, please > could we rename it to

[PATCH] D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths.

vsapsai marked 2 inline comments as done. vsapsai added a comment. Thanks for the review. Comment at: clang/lib/Lex/HeaderSearch.cpp:892-902 +IsInHeaderMap, MappedName); +if (!MappedName.empty()) { + assert(IsInHeaderMap && "MappedName should come from a

[PATCH] D67425: [WebAssembly] Narrowing and widening SIMD ops

tlively updated this revision to Diff 219784. tlively added a comment. - Make narrows binary ops Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67425/new/ https://reviews.llvm.org/D67425 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def

RE: [PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

Microsoft linker does not support linker script. We need to solution that works with all linkers. The begin/end is supported by most linker of interest. -Original Message- From: Jon Chesterfield via Phabricator [mailto:revi...@reviews.llvm.org] Sent: Wednesday, September 11, 2019

[PATCH] D67454: Start porting ivfsoverlay tests to Windows

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67454/new/ https://reviews.llvm.org/D67454

[PATCH] D67463: [MS] Warn when shadowing template parameters under -fms-compatibility

rnk created this revision. rnk added reviewers: thakis, hans. Herald added a project: clang. C++ does not allow shadowing template parameters, but previously we allowed it under -fms-extensions. Now this behavior is controlled by -fms-compatibility, and we emit a -Wmicrosoft-template warning when

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. In D64943#193 , @JonChesterfield wrote: > In D64943#179 , @ABataev wrote: > > > In D64943#178 , > > @JonChesterfield wrote: > > > >

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

poelmanc created this revision. poelmanc added reviewers: alexfh, alexfh_. poelmanc added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-tidy's modernize-use-using feature is great! But if it finds any commas that are not within

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

JonChesterfield added a comment. In D64943#179 , @ABataev wrote: > In D64943#178 , @JonChesterfield > wrote: > > > In D64943#173 , @ABataev wrote: > > > > > In

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

ABataev added a comment. In D64943#178 , @JonChesterfield wrote: > In D64943#173 , @ABataev wrote: > > > In D64943#158 , > > @JonChesterfield wrote: > > > > >

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

JonChesterfield added a comment. In D64943#173 , @ABataev wrote: > In D64943#158 , @JonChesterfield > wrote: > > > > OpenMP linker script is known to cause problems for gold and lld linkers > > > on Linux

[PATCH] D52524: Add -Wpoison-system-directories warning

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a minor nit, this LGTM. However, I'm not the most familiar with how cross-compiling works in the first place, so I may be the wrong one to approve this.

[PATCH] D67382: [analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic.

NoQ marked 2 inline comments as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExplodedGraph.cpp:302-303 // Find the node's current statement in the CFG. - if (const Stmt *S = PathDiagnosticLocation::getStmt(this)) + // FIXME:

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

ABataev added a comment. In D64943#158 , @JonChesterfield wrote: > > OpenMP linker script is known to cause problems for gold and lld linkers on > > Linux and it will also cause problems for Windows enabling in future > > What are the known problems

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

JonChesterfield added a comment. > OpenMP linker script is known to cause problems for gold and lld linkers on > Linux and it will also cause problems for Windows enabling in future What are the known problems with the linker script? I'm wondering if they can be resolved without the overhead

[PATCH] D67429: Improve code generation for thread_local variables:

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67429/new/ https://reviews.llvm.org/D67429 ___

[PATCH] D47358: : Implement {un,}synchronized_pool_resource.

Quuxplusone updated this revision to Diff 219758. Quuxplusone added a comment. Rebased on master. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47358/new/ https://reviews.llvm.org/D47358 Files: include/experimental/memory_resource

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

JonChesterfield added a comment. I'm not sure copying the crtbegin/crtend mechanism from the early days of C runtime is ideal. Since the data is stored in a common section anyway, please could we rename it to __omp_offloading_entries in which case the linker will provide start/end symbols

[PATCH] D66121: Debug Info: Nest Objective-C property function decls inside their container.

rjmccall added a comment. Right, that sounds reasonable. You should be making them link up exactly like a normal method implementation, so if SemaObjC doesn't consider normal method implementations to be redeclarations, then I guess these aren't either. And if we want to change that in the

[PATCH] D47111: : Implement monotonic_buffer_resource.

Quuxplusone updated this revision to Diff 219756. Quuxplusone added a comment. Herald added a subscriber: dexonsmith. Rebased on master. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47111/new/ https://reviews.llvm.org/D47111 Files:

Re: r371605 - [Diagnostics] Add -Wsizeof-array-div

Thanks, Reproduced with -triple armv7–. Added triple to run line, hopefully it will fix the bots. I will check this buildbot if all ok. rL371646 Dňa 11. 9. 2019 o 20:35 užívateľ Yvan Roux napísal: > Hi David, > > This commit broken ARMv7 bots, logs are available here: > >

r371646 - [NFC] Added triple to test file to avoid arm buildbots failures

Author: xbolva00 Date: Wed Sep 11 11:55:56 2019 New Revision: 371646 URL: http://llvm.org/viewvc/llvm-project?rev=371646=rev Log: [NFC] Added triple to test file to avoid arm buildbots failures Modified: cfe/trunk/test/Sema/div-sizeof-array.cpp Modified:

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ added a comment. Hmm, does anybody want me to write an example tool that emits path diagnostics but doesn't link to `libStaticAnalyzer*`? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67422/new/ https://reviews.llvm.org/D67422

[PATCH] D67455: [Clang][CodeGen] support alias attribute w/ gnu_inline

andrewrk requested changes to this revision. andrewrk added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/AST/Decl.cpp:3352 + assert((doesThisDeclarationHaveABody() || willHaveBody()) || + hasAttr() && "Must be a function

[PATCH] D52524: Add -Wpoison-system-directories warning

denik added a comment. Ping @aaron.ballman , please verify the change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

aaron.ballman added a comment. In D66856#1650803 , @aaron.ballman wrote: > To me, actual problems at runtime belong in -Wformat and logical > inconsistencies that don't cause runtime problems belong in > -Wformat-pedantic. However, I think it's a

[PATCH] D67455: [Clang][CodeGen] support alias attribute w/ gnu_inline

nickdesaulniers created this revision. nickdesaulniers added reviewers: aaron.ballman, rsmith, erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. r369705 did not consider the addition of gnu_inline on function declarations of alias attributed functions. This

[PATCH] D65130: [clang][OpenMP] Add clang-offload-wrapper tool

sdmitriev updated this revision to Diff 219750. sdmitriev added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65130/new/ https://reviews.llvm.org/D65130 Files: clang/test/Driver/clang-offload-wrapper.c clang/tools/CMakeLists.txt

[PATCH] D67454: Start porting ivfsoverlay tests to Windows

rnk created this revision. rnk added a reviewer: amccarth. Herald added a subscriber: arphaman. Herald added a project: clang. Part of PR43272, the changes are: 1. Use @ as the sed pattern delimiter instead of : so that the drive letter in lit substitutions isn't an issue. 2. Use the %/t and

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

NoQ added a comment. In D67420#1666050 , @gribozavr wrote: > Are you planning to move users of these options -- like `PlistDiagnostics` -- > to libAnalysis? Yup, i was supposed to do that in D67422 :) Repository:

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

NoQ added a comment. In D67420#1666141 , @Szelethus wrote: > - For these select 4 options that suffer compatibility issues, manually check > `AnalyzerOptions::ConfigTable`. *3 options. `ToolInvocation` is not really an option that you're ever supposed

Re: r371605 - [Diagnostics] Add -Wsizeof-array-div

Hi David, This commit broken ARMv7 bots, logs are available here: http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/10203/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Adiv-sizeof-array.cpp Thanks, Yvan On Wed, 11 Sep 2019 at 12:58, David Bolvansky via cfe-commits wrote: >

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

NoQ added a comment. In D67420#1666141 , @Szelethus wrote: > I do! Hmm, it sounds like you want to force both Clang frontend and Clang-Tidy to use the same set of flags to control these options (?) Much like `-analyzer-config`, these flags will have

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/include/clang/Analysis/PathDiagnosticConsumers.h:37 const cross_tu::CrossTranslationUnitContext ); -#include "clang/StaticAnalyzer/Core/Analyses.def" +#include

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

NoQ added a comment. In D67421#1666058 , @gribozavr wrote: > The "bugtype" in IssueHash is specific to Static Analyzer (or at least not > documented sufficiently abstractly). Yeah, i'll need to document this. That's basically the warning message; it

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

aaron.ballman added a comment. Thank you for doing all this work -- in general, this is looking great and really cleans things up! Comment at: clang/include/clang/Basic/Attr.td:2266 let Spellings = [CXX11<"", "maybe_unused", 201603>, GCC<"unused">, -

[PATCH] D67382: [analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2185 } else { -assert(ErrorNode); -hash.AddPointer(GetCurrentOrPreviousStmt(ErrorNode)); NoQ wrote: > Szelethus wrote: > > Why

[PATCH] D47956: [MS] Consder constexpr globals to be inline, as in C++17

This revision was automatically updated to reflect the committed changes. Closed by commit rL371642: [MS] Consder constexpr globals to be inline, as in C++17 (authored by rnk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r371642 - [MS] Consder constexpr globals to be inline, as in C++17

Author: rnk Date: Wed Sep 11 11:09:10 2019 New Revision: 371642 URL: http://llvm.org/viewvc/llvm-project?rev=371642=rev Log: [MS] Consder constexpr globals to be inline, as in C++17 Summary: Microsoft seems to do this regardless of the language mode, so we must also do it in order to be ABI

[PATCH] D67382: [analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2185 } else { -assert(ErrorNode); -hash.AddPointer(GetCurrentOrPreviousStmt(ErrorNode)); Szelethus wrote: > Why delete the

[PATCH] D67381: [analyzer] NFC: Move stack hints to a side map.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/PathDiagnostic.cpp:34 #include "clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h" -#include "clang/StaticAnalyzer/Core/PathSensitive/SVals.h" #include

[PATCH] D67246: clang-format: Add support for formatting lambdas with explicit template parameters.

thakis added a comment. Do you think this should land with the comment FIXME for now? It improves formatting of this language feature when that heuristic is not used, and changing the heuristic is independent of the rest of this patch. CHANGES SINCE LAST ACTION

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev updated this revision to Diff 219742. sdmitriev added a reviewer: Hahnfeld. sdmitriev added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 Files: clang/test/Driver/clang-offload-bundler.c

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added a comment. Up :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61446/new/ https://reviews.llvm.org/D61446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67452: [clang] [unittest] Import LLVMTestingSupport if necessary

mgorny created this revision. mgorny added reviewers: sammccall, gribozavr, compnerd. Herald added subscribers: kadircet, ilya-biryukov. Add LLVMTestingSupport directory from LLVM_MAIN_SRC_DIR when building clang stand-alone and LLVMTestingSupport library is not present. This is needed to fix

r371637 - [Clang][Bundler] Replace std::vector by SmallVector [NFC]

Author: sdmitriev Date: Wed Sep 11 09:28:47 2019 New Revision: 371637 URL: http://llvm.org/viewvc/llvm-project?rev=371637=rev Log: [Clang][Bundler] Replace std::vector by SmallVector [NFC] Differential Revision: https://reviews.llvm.org/D67413 Modified:

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rL371635: Reland clang-misexpect: Profile Guided Validation of Performance Annotations… (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D66324?vs=219728=219733#toc

r371635 - Reland "clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM"

Author: phosek Date: Wed Sep 11 09:19:50 2019 New Revision: 371635 URL: http://llvm.org/viewvc/llvm-project?rev=371635=rev Log: Reland "clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM" This patch contains the basic functionality for reporting potentially incorrect

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 219728. paulkirth added a comment. Revert mismerge when landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth added a comment. In D66324#1665784 , @lebedev.ri wrote: > In D66324#1665773 , @gribozavr wrote: > > > Reverted in r371598. > > > > Another concern that I have is cross-compilation. LLVM's ADT is not set

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

phosek added inline comments. Comment at: compiler-rt/trunk/lib/profile/xxhash.h:41-42 + +#include "llvm/ADT/ArrayRef.h" +#include "llvm/ADT/StringRef.h" + paulkirth wrote: > chandlerc wrote: > > Sorry folks, but you can't do this. > > > > You can't depend on

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth marked an inline comment as done. paulkirth added inline comments. Comment at: compiler-rt/trunk/lib/profile/xxhash.h:41-42 + +#include "llvm/ADT/ArrayRef.h" +#include "llvm/ADT/StringRef.h" + chandlerc wrote: > Sorry folks, but you can't do this. > >

r371633 - [Clang][Bundler] Fix for a potential memory leak [NFC]

Author: sdmitriev Date: Wed Sep 11 09:03:21 2019 New Revision: 371633 URL: http://llvm.org/viewvc/llvm-project?rev=371633=rev Log: [Clang][Bundler] Fix for a potential memory leak [NFC] Bundler leaks memory if it is called with -type=o but given input isn't an object file (though it has to have

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb added a comment. @dnsampaio, many thanks for committing this! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https://reviews.llvm.org/D66018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >