[PATCH] D68413: [clang] [cmake] Add distribution install targets for remaining components

This revision was automatically updated to reflect the committed changes. Closed by commit rL373695: [clang] [cmake] Add distribution install targets for remaining components (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D68429: [clang] [cmake] Use add_clang_tool() to install all tools

mgorny added a comment. Well, they were installed for me, and all of them certainly have `install()` command right now. Not sure if there's some high magic making `install()` implicitly not install stuff here ;-). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68429/new/

r373695 - [clang] [cmake] Add distribution install targets for remaining components

Author: mgorny Date: Thu Oct 3 22:43:20 2019 New Revision: 373695 URL: http://llvm.org/viewvc/llvm-project?rev=373695=rev Log: [clang] [cmake] Add distribution install targets for remaining components Add install targets as necessary to install bash-autocomplete, scan-build and scan-view via

[PATCH] D68423: [clang-tools-extra] [cmake] Use add_clang_tool() to install tools

This revision was automatically updated to reflect the committed changes. Closed by commit rL373694: [clang-tools-extra] [cmake] Use add_clang_tool() to install tools (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[clang-tools-extra] r373694 - [clang-tools-extra] [cmake] Use add_clang_tool() to install tools

Author: mgorny Date: Thu Oct 3 22:40:29 2019 New Revision: 373694 URL: http://llvm.org/viewvc/llvm-project?rev=373694=rev Log: [clang-tools-extra] [cmake] Use add_clang_tool() to install tools Replace add_clang_executable() calls with add_clang_tool() that takes care of creating correct,

[PATCH] D67775: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic

erik.pilkington added inline comments. Comment at: clang/test/Sema/format-strings-pedantic.c:1 -// RUN: %clang_cc1 -fsyntax-only -verify -Wformat -Wformat-pedantic -isystem %S/Inputs %s +// RUN: %clang_cc1 -fsyntax-only -verify -Wformat -Wformat-type-confusion %s

[PATCH] D67775: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic

erik.pilkington updated this revision to Diff 223136. erik.pilkington marked 6 inline comments as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67775/new/ https://reviews.llvm.org/D67775 Files:

[PATCH] D68410: [AttrDocs] document always_inline

kristina added a comment. Just linking relevant bug for the record: https://bugs.llvm.org/show_bug.cgi?id=43517 Also, I'm fairly certain `__forceinline` and `always_inline`, confusingly enough differ in semantics, with `__forceinline` only being a stronger hint on MSVC. Repository: rG

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

apazos added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:631 + MachineBasicBlock::iterator NewMI = + BuildMI(MBB, MI, DL, TII.get(RISCV::PseudoCALL)) + .add(MI->getOperand(0)); apazos wrote: > Where are we

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge marked an inline comment as done. nridge added a comment. In D67536#1691107 , @hokein wrote: > Could you add tests for this? Certainly, I just wanted to discuss the general approach first, as it will affect what the tests look like.

[PATCH] D68436: [clang-scan-deps] Improve string/character literal skipping

kousikk added inline comments. Comment at: clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp:205 + return; +if (*First == '\\') { + if (++First == End) Should you also check if the character right after a backslash is equal to Terminator and

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk added a comment. One last idea is that we could teach LLD to automatically add this directory to library search path, but then users who link with Visual C++ (not many anymore) will run into this as a corner case issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk added a comment. In D65543#1691819 , @mstorsjo wrote: > Another slightly related thread, regarding libs from the clang resource dir > and how they are specified to the linker (regarding the builtins library): > https://reviews.llvm.org/D51440 I

[PATCH] D68430: Don't use object libraries with Xcode

beanz added a comment. In D68430#1693964 , @jordan_rose wrote: > I'm not quite sure //what// it's doing. The executable targets end up trying > to link against the static libraries anyway, which of course haven't been > built. It's possible that this is

r373685 - Properly handle instantiation-dependent array bounds.

Author: rsmith Date: Thu Oct 3 18:25:59 2019 New Revision: 373685 URL: http://llvm.org/viewvc/llvm-project?rev=373685=rev Log: Properly handle instantiation-dependent array bounds. We previously failed to treat an array with an instantiation-dependent but not value-dependent bound as being an

[PATCH] D68430: Don't use object libraries with Xcode

jordan_rose added a comment. I'm not quite sure //what// it's doing. The executable targets end up trying to link against the static libraries anyway, which of course haven't been built. It's possible that this is because the LIBTYPE is both STATIC and OBJECT and if it were just OBJECT we

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk updated this revision to Diff 223128. rnk added a comment. Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. - Fix PGO build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/ https://reviews.llvm.org/D65543

[PATCH] D68436: [clang-scan-deps] Improve string/character literal skipping

arphaman created this revision. arphaman added reviewers: dexonsmith, Bigcheese, aganea, kousikk. Herald added subscribers: ributzka, tschuett, jkorous. Herald added a project: clang. The existing string/character literal skipping code in the dependency directives source minimizer has two

Buildbot numbers for the week of 09/15/2019 - 09/21/2019

Hello everyone, Below are some buildbot numbers for the week of 09/15/2019 - 09/21/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

Buildbot numbers for the week of 09/22/2019 - 09/28/2019

Hello everyone, Below are some buildbot numbers for the last week of 09/22/2019 - 09/28/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

[PATCH] D68429: [clang] [cmake] Use add_clang_tool() to install all tools

beanz added a comment. Are these tools intended to be installed? I thought they were developer focused tools. I don't think we should make install targets for things that the project doesn't want to support publicly. This also changes the behavior of the `install` target to include these extra

[PATCH] D68413: [clang] [cmake] Add distribution install targets for remaining components

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68413/new/ https://reviews.llvm.org/D68413 ___ cfe-commits mailing list

[PATCH] D68430: Don't use object libraries with Xcode

beanz added a comment. This has the side-effect of making `libclang_cpp` effectively empty when you build with Xcode. What exactly does Xcode do with `OBJECT` libraries? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68430/new/

[PATCH] D68114: Fix for expanding __pragmas in macro arguments

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Nice, the solution was right in front of us the whole time. :) lgtm, but please share the TokenCollector class. Comment at: clang/lib/Lex/Pragma.cpp:169 struct

[PATCH] D67541: [ClangFormat] Future-proof Standard option, allow floating or pinning to arbitrary lang version

thakis added a comment. This broke the sphinx bot: http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/48207 Warning, treated as error: /home/buildbot/llvm-build-dir/clang-sphinx-docs/llvm/src/tools/clang/docs/ClangFormatStyleOptions.rst:2295: WARNING: Explicit markup ends without

[PATCH] D68423: [clang-tools-extra] [cmake] Use add_clang_tool() to install tools

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68423/new/ https://reviews.llvm.org/D68423 ___ cfe-commits mailing list

[PATCH] D68410: [AttrDocs] document always_inline

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4399-4400 + let Content = [{ +Hint that inline substitution should be attempted when optimizations are +disabled. Does not guarantee that

[PATCH] D67723: [CodeView] Add option to disable inline line tables.

rnk added inline comments. Comment at: clang/include/clang/Driver/Options.td:1943 +def gno_inline_line_tables : Flag<["-"], "gno-inline-line-tables">, + Flags<[CC1Option, CoreOption]>, HelpText<"Don't emit inline line tables">; aprantl wrote: > As a DWARF

[PATCH] D68321: Fix clang Visual Studio build instructions

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68321/new/ https://reviews.llvm.org/D68321 ___ cfe-commits mailing

[PATCH] D68430: Don't use object libraries with Xcode

jordan_rose created this revision. jordan_rose added a reviewer: beanz. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Undoes some of the effects of D61909 when using the Xcode CMake generator—it doesn't handle object libraries

Re: r373661 - [OPENMP50]Codegen support for scores in context selectors.

Committed the fix for the test. Best regards, Alexey Bataev 3 окт. 2019 г., в 17:48, Nico Weber написал(а):  Looks like this fails on Windows: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/11207/steps/stage%201%20check/logs/stdio On Thu, Oct 3, 2019 at 4:47 PM Alexey

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/Builtins.def:483 BUILTIN(__builtin_memcpy, "v*v*vC*z", "nF") +BUILTIN(__builtin_memccpy, "v*v*vC*iz", "nF") BUILTIN(__builtin_memmove, "v*v*vC*z", "nF")

r373672 - [OPENMP]Fix the test on Windows, NFC.

Author: abataev Date: Thu Oct 3 15:10:33 2019 New Revision: 373672 URL: http://llvm.org/viewvc/llvm-project?rev=373672=rev Log: [OPENMP]Fix the test on Windows, NFC. Modified: cfe/trunk/test/OpenMP/declare_variant_implementation_vendor_codegen.cpp Modified:

[PATCH] D68429: [clang] [cmake] Use add_clang_tool() to install all tools

mgorny created this revision. mgorny added reviewers: compnerd, phosek, smeenai, beanz, tstellar. Switch clang-check, clang-extdef-mapping and clang-offload-bundler to use add_clang_tool() rather than add_clang_executable() with a custom install rule. This makes them

[PATCH] D68413: [clang] [cmake] Add distribution install targets for remaining components

mgorny updated this revision to Diff 223109. mgorny added a comment. Include hmaptool as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68413/new/ https://reviews.llvm.org/D68413 Files: clang/CMakeLists.txt clang/tools/scan-build/CMakeLists.txt

Re: r373661 - [OPENMP50]Codegen support for scores in context selectors.

Yep, I see. Will fix in couple minutes Best regards, Alexey Bataev 3 окт. 2019 г., в 17:48, Nico Weber написал(а):  Looks like this fails on Windows: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/11207/steps/stage%201%20check/logs/stdio On Thu, Oct 3, 2019 at 4:47 PM

Re: r373661 - [OPENMP50]Codegen support for scores in context selectors.

Yep, I see. Will fix in couple minutes Best regards, Alexey Bataev 3 окт. 2019 г., в 17:48, Nico Weber написал(а):  Looks like this fails on Windows: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/11207/steps/stage%201%20check/logs/stdio On Thu, Oct 3, 2019 at 4:47 PM

Re: r373661 - [OPENMP50]Codegen support for scores in context selectors.

Looks like this fails on Windows: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/11207/steps/stage%201%20check/logs/stdio On Thu, Oct 3, 2019 at 4:47 PM Alexey Bataev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: abataev > Date: Thu Oct 3 13:49:48 2019 > New

r373667 - ASTContext - silence static analyzer getAs<> null dereference warnings. NFCI.

Author: rksimon Date: Thu Oct 3 14:47:42 2019 New Revision: 373667 URL: http://llvm.org/viewvc/llvm-project?rev=373667=rev Log: ASTContext - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but we should be able

Re: r373406 - Use scope qualifiers in Clang's tblgen backends to get useful

On 3 Oct 2019, at 17:22, David Blaikie wrote: (mostly joking) any interest in seeing what it'd take to make Clang/LLVM -Wmissing-prototype clean? (which would also catch the same sort of issues, I think?) Sounds like a nice project for someone else. :) John. On Tue, Oct 1, 2019 at 4:10

r373665 - OverloadCandidate::getNumParams - silence static analyzer getAs null dereference warning. NFCI.

Author: rksimon Date: Thu Oct 3 14:27:02 2019 New Revision: 373665 URL: http://llvm.org/viewvc/llvm-project?rev=373665=rev Log: OverloadCandidate::getNumParams - silence static analyzer getAs null dereference warning. NFCI. The static analyzer is warning about a potential null dereference, but

Re: r373406 - Use scope qualifiers in Clang's tblgen backends to get useful

(mostly joking) any interest in seeing what it'd take to make Clang/LLVM -Wmissing-prototype clean? (which would also catch the same sort of issues, I think?) On Tue, Oct 1, 2019 at 4:10 PM John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rjmccall > Date: Tue Oct 1

[PATCH] D68423: [clang-tools-extra] [cmake] Use add_clang_tool() to install tools

mgorny created this revision. mgorny added reviewers: compnerd, beanz, phosek, tstellar, smeenai, jtsoftware, hokein. Replace add_clang_executable() calls with add_clang_tool() that takes care of creating correct, distribution-friendly install target. While at it, remove redundant install

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge marked 2 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:219 + bool VisitDependentNameTypeLoc(DependentNameTypeLoc L) { +addToken(L.getNameLoc(), HighlightingKind::DependentType); +return true;

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 223090. mibintc added a comment. In the previous review, @rjmccall asked me to redo the existing floating point option documentation before submitting this patch. I got the floating point documentation update committed, and I've worked on this patch more

[PATCH] D68410: [AttrDocs] document always_inline

nickdesaulniers updated this revision to Diff 223088. nickdesaulniers marked 3 inline comments as done. nickdesaulniers added a comment. - add links - remove extra whitespace - rewording, split onto separate lines to ease code review - add spellings to heading Repository: rG LLVM Github

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

boga95 marked 7 inline comments as done. boga95 added a comment. Ping Comment at: clang/test/Analysis/taint-generic.c:393-397 +void testConfigurationFilter3() { + int x = mySource1(); + myFilter3(); + Buffer[x] = 1; // no-warning +} NoQ wrote: > In this

r373661 - [OPENMP50]Codegen support for scores in context selectors.

Author: abataev Date: Thu Oct 3 13:49:48 2019 New Revision: 373661 URL: http://llvm.org/viewvc/llvm-project?rev=373661=rev Log: [OPENMP50]Codegen support for scores in context selectors. If the context selector has associated score and several contexts selectors matches current context, the

[PATCH] D68410: [AttrDocs] document always_inline

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4401 +disabled. Does not guarantee that inline substitution actually occurs. +}]; + let Heading = "always_inline"; It is more than that. This would imply that with optimizations

[PATCH] D68255: [X86] Remove AVX/AVX512 check from validateOperandSize, just always accept 512

rnk added subscribers: ahatanak, void. rnk added a comment. I notice that x86 is the only target for which validateInput/OutputSize are implemented. If you are going to disable these checks, perhaps we should get rid of these methods and leave all these errors to the backend? You could add

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar added a comment. Thanks. Please commit on my behalf when you have a chance. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68415/new/ https://reviews.llvm.org/D68415 ___ cfe-commits mailing list

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

MyDeveloperDay added a comment. understood, ok LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68415/new/ https://reviews.llvm.org/D68415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman added a comment. In D68377#1693490 , @xbolva00 wrote: > It is not very obvious for me what kind of test should be done here. I > would be grateful if you could show me an example in tree. I was thinking of something in CodeGen, like

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar added a comment. If you want spaces in your C++11 initializers and nothing else, then you don't want the `Cpp11BracedListStyle` setting enabled. Turning it off gives you spaces inside without affecting anything else. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

MyDeveloperDay added a comment. what if you have this vector{1, 2, 3}; new int[3]{1, 2, 3}; foo(int f); but want this: vector{ 1, 2, 3 }; new int[3]{ 1, 2, 3 }; foo(int f); wouldn't turning on `SpacesInParentheses: true` now mean you get vector{ 1, 2, 3 }; new int[3]{ 1, 2,

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

mitchell-stellar requested changes to this revision. mitchell-stellar added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2290 +**SpacesAroundConditions** (``bool``) + If ``true``, spaces will be inserted around if/for/while (and similar) conditions.

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar updated this revision to Diff 223077. mitchell-stellar added a comment. Added additional unit tests to verify that the `SpaceInEmptyParentheses` setting is also correctly adhered to. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68415/new/

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 marked an inline comment as done. xbolva00 added a comment. It is not very obvious for me what kind of test should be done here. I would be grateful if you could show me an example in tree. Comment at: include/clang/Basic/Builtins.def:483 BUILTIN(__builtin_memcpy,

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar added a comment. I don't think that's a good idea, considering the fact that braces can mean different things in different contexts, and it would cause trouble for existing clang-format settings. If a hypothetical `SpacesInBraces` were `false` by default, then you could have

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

MyDeveloperDay added a comment. Should we have `SpacesInBraces`? as a first class formatting option, given that we have? SpaceBetweenBraces.SpacesInAngles = true; SpaceBetweenBraces.SpacesInParentheses = true; SpaceBetweenBraces.SpacesInSquareBrackets = true; Repository: rC Clang

[PATCH] D68332: [clang-format] [PR43531] clang-format damages "alternative representations" for operators

mitchell-stellar requested changes to this revision. mitchell-stellar added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/TokenAnnotator.cpp:2892 + if (Left.is(TT_UnaryOperator)) { +// Don't combine the unary operators !~ into

[PATCH] D67847: [Support] make report_fatal_error `abort` instead of `exit`

ychen added a comment. In D67847#1691898 , @jyknight wrote: > The `abort()` function raises SIGABRT, for which the default behavior is to > trigger a coredump. Do we actually want that behavior? > > Either `_exit()` (long available extension, which lld

[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman added a comment. Test cases? Comment at: include/clang/Basic/Builtins.def:483 BUILTIN(__builtin_memcpy, "v*v*vC*z", "nF") +BUILTIN(__builtin_memccpy, "v*v*vC*iz", "nF") BUILTIN(__builtin_memmove, "v*v*vC*z", "nF") GCC doesn't seem to have

[PATCH] D67847: [Support] make report_fatal_error `abort` instead of `exit`

jyknight added a comment. The `abort()` function raises SIGABRT, for which the default behavior is to trigger a coredump. Do we actually want that behavior? Either `_exit()` (long available extension, which lld already uses) or `quick_exit()` (the new C standard way) seem possibly preferable?

[PATCH] D68028: [clang] Add no_builtin attribute

aaron.ballman added a subscriber: rsmith. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:1072 +NoBuiltinAttr * +Sema::mergeNoBuiltinAttr(Sema , Decl *D, const AttributeCommonInfo , + llvm::ArrayRef FunctionNames) {

[PATCH] D67775: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic

aaron.ballman added a comment. In D67775#1691999 , @erik.pilkington wrote: > Ping! Sorry for the delayed review -- thank you for working on clearing this up! Comment at: clang/include/clang/AST/FormatString.h:259 +NoMatch = 0, +

[PATCH] D68410: [AttrDocs] document always_inline

ojeda added a comment. Note that the latest GCC docs (rather than 4.1.2) are at: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html For reference, this was triggered from: https://lore.kernel.org/lkml/cakwvodm_gouedjayxtqctuvdl+9vwvfeofhv06mlmyva75c...@mail.gmail.com/

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar created this revision. mitchell-stellar added reviewers: MyDeveloperDay, reuk, owenpan. mitchell-stellar added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to the clang-format documentation, "Fundamentally, C++11 braced

[PATCH] D67159: [clang] New __attribute__((__clang_arm_mve_alias)).

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: clang/lib/AST/Decl.cpp:3082 +static bool ArmMveAliasValid(unsigned BuiltinID, StringRef AliasName) { + // This will be filled in by Tablegen which isn't written yet + return false;

[PATCH] D67629: [clang-format] [PR43333] Fix C# breaking before function name when using Attributes

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67629/new/ https://reviews.llvm.org/D67629

[PATCH] D68300: [HIP] Use option -nogpulib to disable linking device lib

This revision was automatically updated to reflect the committed changes. Closed by commit rL373649: [HIP] Use option -nogpulib to disable linking device lib (authored by yaxunl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r373649 - [HIP] Use option -nogpulib to disable linking device lib

Author: yaxunl Date: Thu Oct 3 11:59:56 2019 New Revision: 373649 URL: http://llvm.org/viewvc/llvm-project?rev=373649=rev Log: [HIP] Use option -nogpulib to disable linking device lib Differential Revision: https://reviews.llvm.org/D68300 Added: cfe/trunk/test/Driver/hip-no-device-libs.hip

r373648 - Check for qualified function types after substituting into the operand

Author: rsmith Date: Thu Oct 3 11:55:23 2019 New Revision: 373648 URL: http://llvm.org/viewvc/llvm-project?rev=373648=rev Log: Check for qualified function types after substituting into the operand of 'typeid'. This is a rare place where it's valid for a function type to be substituted but not

[PATCH] D67660: [clang-format] [PR43338] C# clang format has space issues betweern C# only keywords

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67660/new/ https://reviews.llvm.org/D67660

[PATCH] D68410: [AttrDocs] document always_inline

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4400 +Hint that inline substitution should be attempted when optimizations are +disabled. Does not guarantee that inline substitution actually occurs. +}]; It may make sense

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

This revision was automatically updated to reflect the committed changes. Closed by commit rL373647: [clang-format] Add ability to wrap braces after multi-line control statements (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D68412: [clang] [cmake] Support LLVM_DISTRIBUTION_COMPONENTS in stand-alone build

mgorny created this revision. mgorny added reviewers: compnerd, tstellar, phosek, beanz, smeenai. https://reviews.llvm.org/D68412 Files: clang/CMakeLists.txt Index: clang/CMakeLists.txt === --- clang/CMakeLists.txt +++

[PATCH] D68413: [clang] [cmake] Add distribution install targets for remaining components

mgorny created this revision. mgorny added reviewers: compnerd, phosek, smeenai, beanz, tstellar. Add install targets as necessary to install bash-autocomplete, scan-build and scan-view via LLVM_DISTRIBUTION_TARGETS. https://reviews.llvm.org/D68413 Files: clang/CMakeLists.txt

[PATCH] D68410: [AttrDocs] document always_inline

lebedev.ri added a reviewer: aaron.ballman. lebedev.ri added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4394-4395 } + + +def AlwaysInlineDocs : Documentation { One too many lines Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D68410: [AttrDocs] document always_inline

jyknight added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4399-4400 + let Content = [{ +Hint that inline substitution should be attempted when optimizations are +disabled. Does not guarantee that inline substitution actually occurs. +}];

r373647 - [clang-format] Add ability to wrap braces after multi-line control statements

Author: paulhoad Date: Thu Oct 3 11:42:31 2019 New Revision: 373647 URL: http://llvm.org/viewvc/llvm-project?rev=373647=rev Log: [clang-format] Add ability to wrap braces after multi-line control statements Summary: Change the BraceWrappingFlags' AfterControlStatement from a bool to an enum

[PATCH] D68410: [AttrDocs] document always_inline

nickdesaulniers created this revision. nickdesaulniers added reviewers: chandlerc, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. GNU documentaion for always_inline: https://gcc.gnu.org/onlinedocs/gcc/Inline.html GNU documentation for function attributes:

[PATCH] D68242: [clang-format] [PR42417] clang-format inserts a space after '->' for operator->() overloading

mitchell-stellar added a comment. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68242/new/ https://reviews.llvm.org/D68242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

mitchell-stellar updated this revision to Diff 223058. mitchell-stellar added a comment. Rebased against master, and also added test case for 'do' statements. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68296/new/ https://reviews.llvm.org/D68296 Files:

r373643 - PR43547: substitute into the type of a non-type template parameter if

Author: rsmith Date: Thu Oct 3 11:24:40 2019 New Revision: 373643 URL: http://llvm.org/viewvc/llvm-project?rev=373643=rev Log: PR43547: substitute into the type of a non-type template parameter if it's instantiation-dependent, even if it's not dependent. There might be a SFINAE check in the

[PATCH] D68394: [HIP] Enable specifying different default gpu arch for HIP/CUDA.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373634: [HIP] Enable specifying different default gpu arch for HIP/CUDA. (authored by hliao, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r373634 - [HIP] Enable specifying different default gpu arch for HIP/CUDA.

Author: hliao Date: Thu Oct 3 10:49:20 2019 New Revision: 373634 URL: http://llvm.org/viewvc/llvm-project?rev=373634=rev Log: [HIP] Enable specifying different default gpu arch for HIP/CUDA. Reviewers: tra, yaxunl Subscribers: cfe-commits Tags: #clang Differential Revision:

[PATCH] D68300: [HIP] Use option -nogpulib to disable linking device lib

ashi1 accepted this revision. ashi1 added a comment. LGTM - Thanks for generalizing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68300/new/ https://reviews.llvm.org/D68300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

edward-jones added a comment. Work in progress because this needs tests (and probably clang-format too). My assumption is that libgcc should be used in preference if it is available. At the moment this either uses libgcc and libgcc's crtbegin/crtend, or the Clang equivalents. Potentially a

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

edward-jones created this revision. edward-jones added a reviewer: asb. Herald added subscribers: cfe-commits, pzheng, simoncook, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, zzheng, MaskRay, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D20561: Warn when taking address of packed member

leonardchan added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. I think I found a false negative with this where if the member is accessed from a packed struct type returned from a function, the warning does not appear: typedef struct { uint8_t a;

[libunwind] r373628 - [libunwind] Adjust libunwind_01.pass.cpp test for ARM EHABI

Author: john.brawn Date: Thu Oct 3 10:01:04 2019 New Revision: 373628 URL: http://llvm.org/viewvc/llvm-project?rev=373628=rev Log: [libunwind] Adjust libunwind_01.pass.cpp test for ARM EHABI ARM EHABI unwinding tables only store the start address of each function, so the last function is

r373626 - DeclBase/DeclCXX/DeclTemplate - silence static analyzer getAs<> null dereference warnings. NFCI.

Author: rksimon Date: Thu Oct 3 09:58:01 2019 New Revision: 373626 URL: http://llvm.org/viewvc/llvm-project?rev=373626=rev Log: DeclBase/DeclCXX/DeclTemplate - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but

[PATCH] D68394: [HIP] Enable specifying different default gpu arch for HIP/CUDA.

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/Driver.cpp:2538 +: CudaActionBuilderBase(C, Args, Inputs, Action::OFK_Cuda) { + DefaultCudaArch = CudaArch::SM_20; +}

r373624 - [OPENMP]Fix emission of the declare target variables in device mode.

Author: abataev Date: Thu Oct 3 09:46:49 2019 New Revision: 373624 URL: http://llvm.org/viewvc/llvm-project?rev=373624=rev Log: [OPENMP]Fix emission of the declare target variables in device mode. Declare target variables must be emitted in device mode, target triples can be empty in this case.

[PATCH] D68300: [HIP] Use option -nogpulib to disable linking device lib

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: include/clang/Driver/Options.td:606 +def flink_builtin_bitcode : Flag<["-"], "flink-builtin-bitcode">, + Flags<[CC1Option]>, HelpText<"Link builtin bitcode for HIP device compilation.">; +def

[PATCH] D68394: [HIP] Enable specifying different default gpu arch for HIP/CUDA.

yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2655 +: CudaActionBuilderBase(C, Args, Inputs, Action::OFK_HIP) { + DefaultCudaArch = CudaArch::GFX600; +} hliao wrote: > Sam, could you let me know which reasonable default

[PATCH] D68300: [HIP] Use option -nogpulib to disable linking device lib

tra added inline comments. Comment at: include/clang/Driver/Options.td:606 +def flink_builtin_bitcode : Flag<["-"], "flink-builtin-bitcode">, + Flags<[CC1Option]>, HelpText<"Link builtin bitcode for HIP device compilation.">; +def fno_link_builtin_bitcode : Flag<["-"],

[PATCH] D68394: [HIP] Enable specifying different default gpu arch for HIP/CUDA.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2538 +: CudaActionBuilderBase(C, Args, Inputs, Action::OFK_Cuda) { + DefaultCudaArch = CudaArch::SM_20; +} tra wrote: > This technically

[PATCH] D68403: [OpenCL] PR43145: preserve addrspace for class accesses

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. PR43145 revealed two places where Clang was attempting to create a bitcast without considering the address space of class types during C++ class codegen.

  1   2   >