[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

Quuxplusone added a comment. Oh, and can you please make sure there are test cases for all the various cases covered in P1155 ? Specifically, I would expect all three of the following test cases to compile successfully. It

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:869 if (E) { -auto NRVOCandidate = this->getCopyElisionCandidate(E->getType(), E, CES_AsIfByStdMove); -if (NRVOCandidate) { - InitializedEntity Entity = -

LLVM buildmaster will be restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in few minutes. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

rtrieu added a comment. In D66046#1696785 , @xbolva00 wrote: > Could this patch solve https://bugs.llvm.org/show_bug.cgi?id=43573? No, but I left some notes on the bug on why negative values are hard and where to fix it. CHANGES SINCE LAST ACTION

[PATCH] D68825: [libTooling] Change Stencil equality to use `toString()`

ymandel updated this revision to Diff 224536. ymandel added a comment. removed `operator==` and updated tests accordingly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68825/new/ https://reviews.llvm.org/D68825 Files:

[PATCH] D68753: [CUDA][HIP} Add a test for constexpr default ctor

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1f8e04eeefe: [CUDA][HIP} Add a test for constexpr default ctor (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D68753?vs=224492=224529#toc

[PATCH] D68832: [tsan,msan] Insert module constructors in a module pass

thakis added a comment. Reverted in r374503. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68832/new/ https://reviews.llvm.org/D68832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r374503 - Revert 374481 "[tsan, msan] Insert module constructors in a module pass"

Author: nico Date: Thu Oct 10 19:44:20 2019 New Revision: 374503 URL: http://llvm.org/viewvc/llvm-project?rev=374503=rev Log: Revert 374481 "[tsan,msan] Insert module constructors in a module pass" CodeGen/sanitizer-module-constructor.c fails on mac and windows, see e.g.

r374502 - [CUDA][HIP} Add a test for constexpr default ctor

Author: yaxunl Date: Thu Oct 10 19:43:28 2019 New Revision: 374502 URL: http://llvm.org/viewvc/llvm-project?rev=374502=rev Log: [CUDA][HIP} Add a test for constexpr default ctor Differential Revision: https://reviews.llvm.org/D68753 Added: cfe/trunk/test/SemaCUDA/constexpr-ctor.cu Added:

[PATCH] D68835: [clang-scan-deps] Add basic support for Clang modules.

dexonsmith added inline comments. Comment at: lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:135 + return llvm::StringSwitch(Ext) +.CasesLower(".c", ".cc", ".cpp", ".c++", ".cxx", true) +.CasesLower(".h", ".hh", ".hpp", ".h++", ".hxx", true)

Re: r374484 - Move most CXXRecordDecl::DefinitionData bit-fields out into a separate

Hi Richard, it's possible that this broke the module build http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/2482/consoleFull#-432653710a1ca8a51-895e-46c6-af87-ce24fa4cd561

r374496 - Fix assertion failure for a cv-qualified array as a non-type template

Author: rsmith Date: Thu Oct 10 18:29:53 2019 New Revision: 374496 URL: http://llvm.org/viewvc/llvm-project?rev=374496=rev Log: Fix assertion failure for a cv-qualified array as a non-type template parameter type. We were both failing to decay the array type to a pointer and failing to remove

[PATCH] D68846: Do the bare minimum to get ClangdXPC.framework building with CMake's Xcode generator

jordan_rose closed this revision. jordan_rose added a comment. Committed in rCTE374494 . Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68846/new/ https://reviews.llvm.org/D68846

[PATCH] D68849: [Parse] Don't speculatively parse an identifier in the wrong context.

efriedma created this revision. efriedma added a reviewer: rsmith. Herald added a project: clang. When we see something like `ihttps://bugs.llvm.org/show_bug.cgi?id=43080 (but not the issues currently marked as "duplicate"; I haven't dug deeply into the causes of those issues). Repository:

[clang-tools-extra] r374494 - Get ClangdXPC.framework building (barely) with CMake's Xcode generator

Author: jrose Date: Thu Oct 10 18:23:56 2019 New Revision: 374494 URL: http://llvm.org/viewvc/llvm-project?rev=374494=rev Log: Get ClangdXPC.framework building (barely) with CMake's Xcode generator The output directories for CMake's Xcode project generator are specific to the configuration, and

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

aaronpuchert added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:869 if (E) { -auto NRVOCandidate = this->getCopyElisionCandidate(E->getType(), E, CES_AsIfByStdMove); -if (NRVOCandidate) { - InitializedEntity Entity = -

[PATCH] D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS.

This revision was automatically updated to reflect the committed changes. vsapsai marked an inline comment as done. Closed by commit rGadb203feda90: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS. (authored by vsapsai). Changed prior to commit:

[PATCH] D68832: [tsan,msan] Insert module constructors in a module pass

thakis added a comment. This fails on Mac and windows http://45.33.8.238/win/247/step_6.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68832/new/ https://reviews.llvm.org/D68832 ___ cfe-commits

[PATCH] D51741: [coro]Pass rvalue reference for named local variable to return_value

aaronpuchert added a comment. Please have a look at D68845 . This should address the issues that we discussed. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51741/new/ https://reviews.llvm.org/D51741

[PATCH] D68846: Do the bare minimum to get ClangdXPC.framework building with CMake's Xcode generator

jordan_rose created this revision. jordan_rose added reviewers: beanz, jkorous. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, dexonsmith, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. The output directories for CMake's Xcode project generator are specific

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

aaronpuchert created this revision. aaronpuchert added reviewers: GorNishanov, modocache, Quuxplusone. Herald added a project: clang. Herald added a subscriber: cfe-commits. aaronpuchert updated this revision to Diff 224513. aaronpuchert added a comment. Also remove FIXME comment. The

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

aaronpuchert updated this revision to Diff 224513. aaronpuchert added a comment. Also remove FIXME comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68845/new/ https://reviews.llvm.org/D68845 Files: clang/lib/Sema/SemaCoroutine.cpp

r374488 - Include whether the destructor is constexpr in -ast-dump output for a

Author: rsmith Date: Thu Oct 10 17:40:08 2019 New Revision: 374488 URL: http://llvm.org/viewvc/llvm-project?rev=374488=rev Log: Include whether the destructor is constexpr in -ast-dump output for a clss. Modified: cfe/trunk/lib/AST/TextNodeDumper.cpp Modified:

[PATCH] D68835: [clang-scan-deps] Add basic support for Clang modules.

Bigcheese updated this revision to Diff 224507. Bigcheese marked 2 inline comments as done. Bigcheese added a comment. Addressed review comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68835/new/ https://reviews.llvm.org/D68835 Files:

r374484 - Move most CXXRecordDecl::DefinitionData bit-fields out into a separate

Author: rsmith Date: Thu Oct 10 17:29:04 2019 New Revision: 374484 URL: http://llvm.org/viewvc/llvm-project?rev=374484=rev Log: Move most CXXRecordDecl::DefinitionData bit-fields out into a separate file. Reduces duplication and thereby reduces the risk that someone will forget to update one of

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

grokos added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u: sdmitriev wrote: > ABataev wrote: > >

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

hliao added a comment. In D68660#1705087 , @thakis wrote: > This makes tests assert on Mac: http://45.33.8.238/mac/1415/step_6.txt please let me know whether that works for you. thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68832: [tsan,msan] Insert module constructors in a module pass

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c72aa232e74: [tsan,msan] Insert module constructors in a module pass (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68832/new/

r374481 - [tsan,msan] Insert module constructors in a module pass

Author: vitalybuka Date: Thu Oct 10 16:49:10 2019 New Revision: 374481 URL: http://llvm.org/viewvc/llvm-project?rev=374481=rev Log: [tsan,msan] Insert module constructors in a module pass Summary: If we insert them from function pass some analysis may be missing or invalid. Fixes PR42877.

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

hliao added a comment. In D68660#1705087 , @thakis wrote: > This makes tests assert on Mac: http://45.33.8.238/mac/1415/step_6.txt I have no access to MacOS but try to fix that in r374478. Maybe that's a good excuse for a MacBook, ;) Repository: rG

[PATCH] D68832: [tsan,msan] Insert module constructors in a module pass

vitalybuka updated this revision to Diff 224501. vitalybuka marked 2 inline comments as done. vitalybuka added a comment. nfc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68832/new/ https://reviews.llvm.org/D68832 Files:

[PATCH] D68753: [CUDA][HIP} Add a test for constexpr default ctor

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Sometimes I wish it would be possible to specify some of the -verify diagnostics in temporal order, as opposed to tying them to locations. I.e. in this case it would be way more useful to see

r374478 - [tooling] Fix assertion on MacOSX.

Author: hliao Date: Thu Oct 10 16:45:20 2019 New Revision: 374478 URL: http://llvm.org/viewvc/llvm-project?rev=374478=rev Log: [tooling] Fix assertion on MacOSX. Modified: cfe/trunk/lib/Tooling/Tooling.cpp Modified: cfe/trunk/lib/Tooling/Tooling.cpp URL:

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

thakis added a comment. This makes tests assert on Mac: http://45.33.8.238/mac/1415/step_6.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68660/new/ https://reviews.llvm.org/D68660 ___ cfe-commits

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ccb39bbd87c: [tooling] Teach Tooling to understand compilation with offloading. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68720: Support -fstack-clash-protection for x86

tstellar added inline comments. Comment at: clang/test/CodeGen/stack-clash-protection.c:3 +// RUN: %clang -target x86_64 -o %t.out %s -fstack-clash-protection && %t.out + +#include There were concerns[1] raised recently about adding clang tests that were

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63932/new/ https://reviews.llvm.org/D63932 ___

r374470 - [tooling] Teach Tooling to understand compilation with offloading.

Author: hliao Date: Thu Oct 10 16:05:55 2019 New Revision: 374470 URL: http://llvm.org/viewvc/llvm-project?rev=374470=rev Log: [tooling] Teach Tooling to understand compilation with offloading. Summary: - So far, we only recognize the host compilation with offloading and skip the offloading

[PATCH] D68838: [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 3

efriedma updated this revision to Diff 224496. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68838/new/ https://reviews.llvm.org/D68838 Files: test/CodeGen/aarch64-v8.2a-neon-intrinsics.c utils/TableGen/NeonEmitter.cpp Index: utils/TableGen/NeonEmitter.cpp

[PATCH] D68823: Fix help message for -ffp-contract

This revision was automatically updated to reflect the committed changes. Closed by commit rGc10a64718ed2: Fix help message for -ffp-contract (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D68823?vs=224436=224497#toc Repository: rG

r374467 - Fix help message for -ffp-contract

Author: yaxunl Date: Thu Oct 10 15:43:00 2019 New Revision: 374467 URL: http://llvm.org/viewvc/llvm-project?rev=374467=rev Log: Fix help message for -ffp-contract Differential Revision: https://reviews.llvm.org/D68823 Modified: cfe/trunk/include/clang/Driver/Options.td Modified:

[PATCH] D68720: Support -fstack-clash-protection for x86

efriedma added inline comments. Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:423 + AbsOffset - CurrentAbsOffset + PageSize); +if (FreeProbeIterator != MBB.end()) { + NumFrameFreeProbe++; Each probe has to

[PATCH] D68753: [CUDA][HIP} Add a test for constexpr default ctor

yaxunl updated this revision to Diff 224492. yaxunl marked an inline comment as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68753/new/ https://reviews.llvm.org/D68753 Files: test/SemaCUDA/constexpr-ctor.cu Index:

[PATCH] D68753: [CUDA][HIP} Add a test for constexpr default ctor

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: test/SemaCUDA/constexpr-ctor.cu:14-27 +template struct B { + T a; + constexpr B() = default; +}; + +template struct C { + T a; tra wrote: > yaxunl wrote: > > tra wrote: > > >

r374465 - PR43629: Fix crash evaluating constexpr placement new on a subobject of

Author: rsmith Date: Thu Oct 10 15:31:17 2019 New Revision: 374465 URL: http://llvm.org/viewvc/llvm-project?rev=374465=rev Log: PR43629: Fix crash evaluating constexpr placement new on a subobject of an out-of-lifetime object. Modified: cfe/trunk/include/clang/Basic/DiagnosticASTKinds.td

[PATCH] D68838: [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 3

rsmith added a comment. Thanks again! In my testing, this is enough to get the clang testsuite to pass with the default changed to `-flax-vector-conversions=integer`. Comment at: test/CodeGen/aarch64-v8.2a-neon-intrinsics.c:149-170 +uint16x4_t test_vcvt_u16_f16 (float16x4_t

[PATCH] D68807: [ClangTidy] Separate tests for infrastructure and checkers

gribozavr added a comment. It would look weird if we have a ton of tests for checkers in a directory, and then a subdirectory for infra tests. Why are we trying to optimize the number of renamed files? I already did the renaming, so we are not saving any work. I think we should optimize for

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

sdmitriev added a subscriber: grokos. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u:

[PATCH] D68823: Fix help message for -ffp-contract

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Driver/Options.td:1148 + " | on (according to FP_CONTRACT pragma) | off (never fuse). Default" + " is 'fast' for CUDA/HIP and 'on' otherwise.">,

[PATCH] D68838: [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 3

efriedma created this revision. efriedma added reviewers: rsmith, SjoerdMeijer. Herald added a subscriber: kristof.beyls. Herald added a project: clang. It's completely impossible to check that I've actually found all the issues, due to the use of macros in arm_neon.h, but hopefully this time

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

ABataev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u: sdmitriev wrote: > ABataev wrote: > >

[PATCH] D68807: [ClangTidy] Separate tests for infrastructure and checkers

lebedev.ri added a comment. Description says: > making it easier to find infrastructure tests > Tests for infrastructure were difficult to find because they were > outnumbered by tests for checkers. So presumably there far fewer infra tests as compared to checker tests, and the issue is

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:174 + /// Global variable that represents BinDesc is returned. + GlobalVariable *createBinDesc(ArrayRef> Bufs) { +// Create external begin/end symbols for the offload

[PATCH] D68832: [tsan,msan] Insert module constructors in a module pass

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. Thanks for finding the root cause of this! Comment at: llvm/lib/Transforms/Instrumentation/ThreadSanitizer.cpp:143 + +static void insertModuleCtor(Module ) { +

[PATCH] D68401: [Hexagon] Fix clang driver to parse -mcpu/-mvXX and -march properly.

bcain accepted this revision. bcain added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68401/new/ https://reviews.llvm.org/D68401 ___ cfe-commits

[PATCH] D68835: [clang-scan-deps] Add basic support for Clang modules.

arphaman added inline comments. Comment at: lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:135 + return llvm::StringSwitch(Ext) +.CasesLower(".c", ".cc", ".cpp", ".c++", ".cxx", true) +.CasesLower(".h", ".hh", ".hpp", ".h++", ".hxx", true)

[PATCH] D68823: Fix help message for -ffp-contract

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: include/clang/Driver/Options.td:1148 + " | on (according to FP_CONTRACT pragma) | off (never fuse). Default" + " is 'fast' for CUDA/HIP and 'on' otherwise.">, Values<"fast,on,off">;

[PATCH] D68807: [ClangTidy] Separate tests for infrastructure and checkers

gribozavr added a comment. Why does the number of moves matter? Git preserves history across moves. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68807/new/ https://reviews.llvm.org/D68807 ___

[PATCH] D68835: [clang-scan-deps] Add basic support for Clang modules.

arphaman added inline comments. Comment at: test/ClangScanDeps/modules.cpp:39 +// CHECK2: modules_cdb_input.cpp +// CHECK2-NEXT: Inputs/module.modulemap +// CHECK2-NEXT: Inputs{{/|\\}}header.h Missing windows path slash thing. Repository: rC Clang CHANGES

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

rsmith added a comment. This seems to be missing a CodeGen test for what IR we generate on an overly-large alignment. (The warning says the alignment is ignored, but I don't see where you're actually doing anything different in that case when generating IR.) Comment at:

[PATCH] D68835: [clang-scan-deps] Add basic support for Clang modules.

Bigcheese created this revision. Bigcheese added a reviewer: arphaman. Herald added subscribers: tschuett, dexonsmith. Herald added a project: clang. This fixes two issues that prevent simple uses of Clang modules from working. - We would previously minimize _every_ file opened by clang, even

[PATCH] D67537: [WIP] [clangd] Client-side support for inactive regions

nridge updated this revision to Diff 224483. nridge added a comment. Updated to reflect changes to server side in D67536 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67537/new/ https://reviews.llvm.org/D67537

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. Ok, I updated the patch to convey the line highlight separately from the token highlights. I did use the simplified approach I mentioned, where I use a single `isInactive` flag. If you'd prefer the more general approach where we send an array of line styles, I can do

Re: [PATCH] D68824: Fix __builtin_assume_aligned with too large values.

Thanks! On the way home for the evening, so I'll fix it up tomorrow. On Oct 10, 2019 2:34 PM, Nico Weber via Phabricator wrote: thakis added a comment. Since you just left IRC, I reverted this in 374456 for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68824/new/

r374457 - Fix some errors in tests that cause them to fail with lax

Author: rsmith Date: Thu Oct 10 14:40:56 2019 New Revision: 374457 URL: http://llvm.org/viewvc/llvm-project?rev=374457=rev Log: Fix some errors in tests that cause them to fail with lax vector conversions disabled. Modified: cfe/trunk/test/CodeGen/aarch64-v8.2a-neon-intrinsics.c

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u: ABataev wrote: > Same question as

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

thakis added a comment. Since you just left IRC, I reverted this in 374456 for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68824/new/ https://reviews.llvm.org/D68824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge updated this revision to Diff 224480. nridge added a comment. Updated to use as isInactive flag on SemanticHighlightingInformation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 Files:

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

thakis added a comment. The new test fails on Windows: -- Testing: 16032 tests, 32 workers -- Testing: 0.. 10.. 20.. 30.. 40.. 50 FAIL: Clang :: Sema/builtin-assume-aligned.c (8862 of 16032) TEST 'Clang :: Sema/builtin-assume-aligned.c' FAILED

[PATCH] D51741: [coro]Pass rvalue reference for named local variable to return_value

aaronpuchert added a comment. @Quuxplusone Thanks for your very helpful comments! > In which case, this patch (D51741 ) itself > fixed this FIXME at least partly, and maybe completely. Maybe this patch > should have removed or amended the FIXME, rather than

r374456 - Revert 374450 "Fix __builtin_assume_aligned with too large values."

Author: nico Date: Thu Oct 10 14:34:32 2019 New Revision: 374456 URL: http://llvm.org/viewvc/llvm-project?rev=374456=rev Log: Revert 374450 "Fix __builtin_assume_aligned with too large values." The test fails on Windows, with error: 'warning' diagnostics expected but not seen: File

Re: r374419 - [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 2.

Getting close now, I think there's just one more problem: vmaxv_f16, vmaxq_f16, vminv_f16, vminq_f16, vmaxnmv_f16, vmaxnmvq_f16, vminnmv_f16, and vminnmvq_f16 all have the wrong parameter type, requiring a lax conversion from vector of signed char to vector of float16_t. You can reproduce that

[PATCH] D68807: [ClangTidy] Separate tests for infrastructure and checkers

lebedev.ri added a comment. That's a lot of moved files. How about *only* moving the infrastructure tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68807/new/ https://reviews.llvm.org/D68807 ___

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

hliao updated this revision to Diff 224476. hliao marked an inline comment as done. hliao added a comment. revice comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68660/new/ https://reviews.llvm.org/D68660 Files:

[PATCH] D29039: [clang-format] Proposal for clang-format -r option

MyDeveloperDay added a comment. In D29039#1704166 , @zturner wrote: > In Windows you just write a Python script to do this, and this works > everywhere, not just on one platform or the other, so bash isn't even > necessary and Python is easy to write so

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:102 + if (isa(A)) { +assert(Actions.size() == 2); +assert(isa(Actions.front())); tra wrote: > Why 2? Will it not be different if

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith updated this revision to Diff 224473. rsmith added a comment. Test fixup. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67678/new/ https://reviews.llvm.org/D67678 Files: docs/CommandGuide/clang.rst docs/ReleaseNotes.rst

r374450 - Fix __builtin_assume_aligned with too large values.

Author: erichkeane Date: Thu Oct 10 14:08:28 2019 New Revision: 374450 URL: http://llvm.org/viewvc/llvm-project?rev=374450=rev Log: Fix __builtin_assume_aligned with too large values. Code to handle __builtin_assume_aligned was allowing larger values, but would convert this to unsigned along the

[PATCH] D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e866e411caa: Add -fgnuc-version= to control __GNUC__ and other GCC macros (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D68055?vs=224155=224472#toc Repository: rG LLVM Github

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. It is not reasonable to make this change on a per-target basis. We should work towards turning lax vector conversions off globally instead. If overload resolution can't distinguish

[PATCH] D68753: [CUDA][HIP} Add a test for constexpr default ctor

tra added inline comments. Comment at: test/SemaCUDA/constexpr-ctor.cu:14-27 +template struct B { + T a; + constexpr B() = default; +}; + +template struct C { + T a; yaxunl wrote: > tra wrote: > > Do we really need three identical templates? If they are

r374449 - Add -fgnuc-version= to control __GNUC__ and other GCC macros

Author: rnk Date: Thu Oct 10 14:04:25 2019 New Revision: 374449 URL: http://llvm.org/viewvc/llvm-project?rev=374449=rev Log: Add -fgnuc-version= to control __GNUC__ and other GCC macros I noticed that compiling on Windows with -fno-ms-compatibility had the side effect of defining __GNUC__, along

[PATCH] D68832: [tsan,msan] Insert module constructors in a module pass

vitalybuka created this revision. vitalybuka added reviewers: eugenis, leonardchan. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. If we insert them from function pass some analysis may be missing or invalid. Fixes PR42877. Repository: rG

[PATCH] D68660: [tooling] Teach Tooling to understand compilation with offloading.

tra added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:102 + if (isa(A)) { +assert(Actions.size() == 2); +assert(isa(Actions.front())); Why 2? Will it not be different if user targeted multiple GPUs? Comment

[PATCH] D68823: Fix help message for -ffp-contract

tra added inline comments. Comment at: include/clang/Driver/Options.td:1148 + " | on (according to FP_CONTRACT pragma) | off (never fuse). Default" + " is 'fast' for CUDA/HIP and 'on' otherwise.">, Values<"fast,on,off">; Could you point me where we set it?

[PATCH] D68736: [MSVC] Automatically add atlmfc include and lib directories as system paths.

This revision was automatically updated to reflect the committed changes. Closed by commit rG79f243296654: [MSVC] Automatically add atlmfc folder to include and libpath. (authored by zturner). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

r374443 - [MSVC] Automatically add atlmfc folder to include and libpath.

Author: zturner Date: Thu Oct 10 13:25:54 2019 New Revision: 374443 URL: http://llvm.org/viewvc/llvm-project?rev=374443=rev Log: [MSVC] Automatically add atlmfc folder to include and libpath. Differential Revision: https://reviews.llvm.org/D68736 Modified:

r374439 - [ScanDeps] clang-format, 80 cols.

Author: mspencer Date: Thu Oct 10 13:19:02 2019 New Revision: 374439 URL: http://llvm.org/viewvc/llvm-project?rev=374439=rev Log: [ScanDeps] clang-format, 80 cols. Modified: cfe/trunk/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp Modified:

r374438 - [OPENMP]Update doc for supported constructs, NFC.

Author: abataev Date: Thu Oct 10 13:15:54 2019 New Revision: 374438 URL: http://llvm.org/viewvc/llvm-project?rev=374438=rev Log: [OPENMP]Update doc for supported constructs, NFC. Modified: cfe/trunk/docs/OpenMPSupport.rst Modified: cfe/trunk/docs/OpenMPSupport.rst URL:

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

erichkeane updated this revision to Diff 224456. erichkeane added a comment. cant use llvm::Value in Sema without some linker issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68824/new/ https://reviews.llvm.org/D68824 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LG, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68824/new/ https://reviews.llvm.org/D68824 ___ cfe-commits mailing

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

erichkeane updated this revision to Diff 224455. erichkeane marked 5 inline comments as done. erichkeane added a comment. Hal's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68824/new/ https://reviews.llvm.org/D68824 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge marked 3 inline comments as done. nridge added a comment. I like how we went from using heuristics, to not using heuristics, to using heuristics again :) But admittedly, the new heuristics are more accurate because they're based on phase 1 lookup results rather than just syntax, so I'm

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge updated this revision to Diff 224453. nridge added a comment. Updated to use heuristics based on OverloadExpr::decl() Also folded VisitUnresolvedLookupExpr and VisitUnresolvedMemberExpr together into a single VisitOverloadExpr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

hfinkel added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2854 +def warn_assume_align_too_big : Warning<"alignments greater than 1 << 29 are " + "unsupported by LLVM">, InGroup; Should this be in the IgnoredAttributes group?

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

erichkeane updated this revision to Diff 224449. erichkeane added a comment. Remove unused code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68824/new/ https://reviews.llvm.org/D68824 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D68825: [libTooling] Change Stencil equality to use `toString()`

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. ymandel edited the summary of this revision. Removes the `isEqual` method from StencilPartInterface and modifies equality to use the string representation returned by the `toString` method for

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

erichkeane created this revision. erichkeane added reviewers: lebedev.ri, hfinkel, joey, jdoerfert. lebedev.ri added a comment. Thanks, i like it. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2058-2073 +/* void CodeGenFunction::EmitAlignmentAssumption(llvm::Value

[PATCH] D68753: [CUDA][HIP} Add a test for constexpr default ctor

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: test/SemaCUDA/constexpr-ctor.cu:14-27 +template struct B { + T a; + constexpr B() = default; +}; + +template struct C { + T a; tra wrote: > Do we really need three identical

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

lebedev.ri added a comment. Thanks, i like it. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2058-2073 +/* void CodeGenFunction::EmitAlignmentAssumption(llvm::Value *PtrValue, QualType Ty, SourceLocation Loc,

  1   2   >