[PATCH] D69697: [WebAssembly] Add experimental SIMD dot product instruction

tlively updated this revision to Diff 227393. tlively added a comment. - Add second argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69697/new/ https://reviews.llvm.org/D69697 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def

LLVM buildmaster will be updated and restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69696: [WebAssembly] SIMD integer min and max instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rGa07019a275cd: [WebAssembly] SIMD integer min and max instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69696/new/

[PATCH] D69697: [WebAssembly] Add experimental SIMD dot product instruction

tlively added a comment. https://github.com/WebAssembly/simd/pull/127 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69697/new/ https://reviews.llvm.org/D69697 ___ cfe-commits mailing list

[clang] c6da9ec - clang: Fix assert on void pointer arithmetic with address_space

Author: Matt Arsenault Date: 2019-10-31T20:07:23-07:00 New Revision: c6da9ec0e90ea8798ecae583bb8d26bdf6b9b79f URL: https://github.com/llvm/llvm-project/commit/c6da9ec0e90ea8798ecae583bb8d26bdf6b9b79f DIFF:

[PATCH] D69666: clang: Fix assert on void pointer arithmetic with address_space

arsenm closed this revision. arsenm added a comment. c6da9ec0e90ea8798ecae583bb8d26bdf6b9b79f CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69666/new/ https://reviews.llvm.org/D69666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69613: [libTooling] Simplify type structure of `Stencil`s.

gribozavr2 added a comment. I see. Some decoupling is desirable, I agree. Maybe move `StencilInterface` and `Stencil` into a separate header that `RewriteRule` can depend on, and then define the library of stencils in another header? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D69625: [libTooling] Support implicit coercions in Stencil's `access` combinator.

gribozavr2 added a comment. > Which idiom do you think we should encourage, then, for text and > range-selectors -- the named combinator or the single-argument cat? That is You are making a very interesting point! It sounds very appealing to me to remove the special `text` and `selection`

[PATCH] D69697: [WebAssembly] Add experimental SIMD dot product instruction

aheejin added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:135 +TARGET_BUILTIN(__builtin_wasm_dot_s_i32x4_i16x8, "V4iV8s", "nc", "simd128") + We talked offline. There should be two arguments :) Repository: rG LLVM Github

[PATCH] D69699: [clang][driver] Add ProfileData to LLVM_LINK_COMPONENTS

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9903ec8979f: [clang][driver] Add ProfileData to LLVM_LINK_COMPONENTS (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69699/new/

[PATCH] D69699: [clang][driver] Add ProfileData to LLVM_LINK_COMPONENTS

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69699/new/ https://reviews.llvm.org/D69699

[PATCH] D69699: [clang][driver] Add ProfileData to LLVM_LINK_COMPONENTS

aheejin created this revision. aheejin added reviewers: vsk, tlively. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM! After D68351

[clang] b9903ec - [clang][driver] Add ProfileData to LLVM_LINK_COMPONENTS

Author: Heejin Ahn Date: 2019-10-31T19:52:41-07:00 New Revision: b9903ec8979fc43f1484e1ee8749c7d18ce90bf0 URL: https://github.com/llvm/llvm-project/commit/b9903ec8979fc43f1484e1ee8749c7d18ce90bf0 DIFF: https://github.com/llvm/llvm-project/commit/b9903ec8979fc43f1484e1ee8749c7d18ce90bf0.diff

[PATCH] D69697: [WebAssembly] Add experimental SIMD dot product instruction

tlively added a comment. This is https://github.com/WebAssembly/simd/pull/127 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69697/new/ https://reviews.llvm.org/D69697 ___ cfe-commits mailing list

[PATCH] D69696: [WebAssembly] SIMD integer min and max instructions

tlively added a comment. In D69696#1729676 , @aheejin wrote: > Is this https://github.com/WebAssembly/simd/pull/27 ? Can you please include > the spec (even if it's still an unmerged PR) in the CL description next time? > LGTM. Yes, that's right. Will

[PATCH] D69696: [WebAssembly] SIMD integer min and max instructions

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. Is this https://github.com/WebAssembly/simd/pull/27 ? Can you please include the spec (even if it's still an unmerged PR) in the CL description next time? LGTM. Repository: rG LLVM

[PATCH] D69678: [CodeGen] Fix invalid llvm.linker.options about pragma detect_mismatch

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb1616ba4726: [CodeGen] Fix invalid llvm.linker.options about pragma detect_mismatch (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bb1616b - [CodeGen] Fix invalid llvm.linker.options about pragma detect_mismatch

Author: Yaxun (Sam) Liu Date: 2019-10-31T22:27:35-04:00 New Revision: bb1616ba47261a0767063e85718d546165972120 URL: https://github.com/llvm/llvm-project/commit/bb1616ba47261a0767063e85718d546165972120 DIFF:

[PATCH] D69625: [libTooling] Support implicit coercions in Stencil's `access` combinator.

ymandel added a comment. In D69625#1729634 , @gribozavr2 wrote: > I fully agree about passing a Stencil to `access`. However whether to call > `makeStencil` inside is an interesting question. On one hand, such implicit > conversions increase the

[PATCH] D69613: [libTooling] Simplify type structure of `Stencil`s.

ymandel marked 8 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Transformer/Stencil.h:154 +/// for more details. +template MatchConsumer stencil(Ts &&... Parts) { + Stencil S = cat(std::forward(Parts)...);

[PATCH] D69697: [WebAssembly] Add experimental SIMD dot product instruction

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. This instruction is not merged to the spec proposal, but we need it to be implemented

[PATCH] D69666: clang: Fix assert on void pointer arithmetic with address_space

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69666/new/ https://reviews.llvm.org/D69666 ___ cfe-commits mailing list

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:389-392 + // The linker_option directives are intended for host compilation. + if (JA.isDeviceOffloading(Action::OFK_Cuda) || +

[PATCH] D69666: clang: Fix assert on void pointer arithmetic with address_space

jdoerfert added a comment. Communication problem: > This attempted to always use the default address space void pointer type > instead of preserving the source address space. Where "This" is the old code. Replace "This" in the commit message with some more descriptive wording and the

[PATCH] D69625: [libTooling] Support implicit coercions in Stencil's `access` combinator.

gribozavr2 added a comment. I fully agree about passing a Stencil to `access`. However whether to call `makeStencil` inside is an interesting question. On one hand, such implicit conversions increase the convenience. On the other, they increase the API surface (more possible argument types),

[PATCH] D69696: [WebAssembly] SIMD integer min and max instructions

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. Introduces a clang builtins and LLVM intrinsics representing integer min/max

[PATCH] D69613: [libTooling] Simplify type structure of `Stencil`s.

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Transformer/Stencil.h:82 +Stencil makeStencil(RangeSelector Selector); +inline Stencil makeStencil(Stencil S) { return S; } ymandel wrote: > gribozavr2 wrote: > > I feel like this should

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Alright then. (Although I don't know whether the redeclaration chain always models that wording in the standard, and what that wording means when we don't have a linear ordering of

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge updated this revision to Diff 227374. nridge marked 3 inline comments as done. nridge added a comment. Addressed some nits and got existing tests to pass Will follow up with new tests in the next update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:469 + auto = DiffedLines.back(); + for (auto Iter = AddedLine.Tokens.begin(); + Iter != AddedLine.Tokens.end();) { hokein wrote: > it took me a while

[PATCH] D68351: [profile] Add a mode to continuously sync counter updates to a file

This revision was automatically updated to reflect the committed changes. Closed by commit rGd889d1efefe9: [profile] Add a mode to continuously sync counter updates to a file (authored by vsk). Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Changed

[PATCH] D69666: clang: Fix assert on void pointer arithmetic with address_space

arsenm added a comment. In D69666#1728946 , @yaxunl wrote: > Is the description reversed? > > This attempts to preserve the source address space instead of always using > the default address space for void pointer type. I don't think so? This now

[PATCH] D69626: Fix Microsoft compatibility handling of commas in nested macro expansions.

epastor added a comment. Thanks, Reid; I'm not 100% sure I've checked all the corner cases either, but this at least seems like a step forward. As a reminder: I don't have commit access. Could someone else commit this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69582: Let clang driver support parallel jobs

aganea added a comment. This is somehow similar to what I was proposing in D52193 . Would you possibly provide tests and/or an example of your usage please? Comment at: clang/lib/Driver/Compilation.cpp:303 +} +std::thread Th(Work); +

Re: [clang] 33a745e - [clang][clang-scan-deps] Add support for extracting full module dependencies.

You could hack it to standardize the yaml output to forward slashes with sed, or clang might wish to do it internally. My current position is that we should pick the path style and slash direction closest to the point at which the path will be emitted. In the past we've tried to make arguments

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6429cdd65ff: Refactor getDeclAtPosition() to use SelectionTree + targetDecl() (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked 12 inline comments as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1978 + DSAStack->getDefaultDMIBAtLevel(Level, OMPC_DEFAULTMAP_scalar) == + DMIB_firstprivate) || DSAStack->hasExplicitDSA(

[PATCH] D69626: Fix Microsoft compatibility handling of commas in nested macro expansions.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Based on the comments it looks like you confirmed this matches MSVC's behavior, at least in this regard. I haven't stared at this deeply to think of all the corner cases, though. To Nico's

[clang-tools-extra] b6429cd - Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

Author: Nathan Ridge Date: 2019-10-31T17:37:27-04:00 New Revision: b6429cdd65ffa28591c5b0da37244ab66d0b1785 URL: https://github.com/llvm/llvm-project/commit/b6429cdd65ffa28591c5b0da37244ab66d0b1785 DIFF: https://github.com/llvm/llvm-project/commit/b6429cdd65ffa28591c5b0da37244ab66d0b1785.diff

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge updated this revision to Diff 227352. nridge marked 12 inline comments as done. nridge added a comment. Address latest comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69237/new/ https://reviews.llvm.org/D69237 Files:

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1133 + DeclRelationSet Relations = + DeclRelation::TemplatePattern | DeclRelation::Alias; + auto Decls = getDeclAtPosition(AST, SourceLocationBeg, Relations); sammccall wrote: >

[PATCH] D69643: [clang][ScanDeps] Fix issue with multiple commands with the same input.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd816d9bdc585: [clang][ScanDeps] Fix issue with multiple commands with the same input. (authored by Bigcheese). Changed prior to commit: https://reviews.llvm.org/D69643?vs=227178=227347#toc Repository:

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev marked an inline comment as done. AntonBikineev added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/TriviallyDestructibleCheck.cpp:45 + isDefaulted(), + unless(anyOf(isFirstDecl(), isVirtual(), +

[clang] d816d9b - [clang][ScanDeps] Fix issue with multiple commands with the same input.

Author: Michael Spencer Date: 2019-10-31T14:22:01-07:00 New Revision: d816d9bdc585bbf77a7a1c47a7199fd9e0c34402 URL: https://github.com/llvm/llvm-project/commit/d816d9bdc585bbf77a7a1c47a7199fd9e0c34402 DIFF:

[clang] 19f1dc7 - Remove unneeded template alias, causes issues with some MSVC version

Author: Reid Kleckner Date: 2019-10-31T14:20:54-07:00 New Revision: 19f1dc7b527eade11dae9425c420cc9f450393b6 URL: https://github.com/llvm/llvm-project/commit/19f1dc7b527eade11dae9425c420cc9f450393b6 DIFF: https://github.com/llvm/llvm-project/commit/19f1dc7b527eade11dae9425c420cc9f450393b6.diff

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:389-392 + // The linker_option directives are intended for host compilation. + if (JA.isDeviceOffloading(Action::OFK_Cuda) || + JA.isDeviceOffloading(Action::OFK_HIP)) +Default = false;

[PATCH] D69678: [CodeGen] Fix invalid llvm.linker.options about pragma detect_mismatch

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Seems reasonable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69678/new/ https://reviews.llvm.org/D69678 ___ cfe-commits mailing

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

yaxunl added a comment. In D57829#1729094 , @tra wrote: > Could you, please, give us a bit more context and provide more info for the > questions @rjmccall and I asked before? > > Is the problem specifically because autolink is not supported on device

[PATCH] D69678: [CodeGen] Fix invalid llvm.linker.options about pragma detect_mismatch

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. When a target does not support pragma detect_mismatch, an llvm.linker.options metadata with an empty entry is created, which causes diagnostic in backend since backend expects name/value pair in llvm.linker.options entries.

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/include/clang/Driver/Options.td:1152 +def frounding_math : Flag<["-"], "frounding-math">, Group, Flags<[CC1Option]>; +def fno_rounding_math : Flag<["-"], "fno-rounding-math">, Group,

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

gribozavr2 added a comment. LGTM modulo the isFirstDeclComment. Will approve after we resolve that discussion. Comment at: clang-tools-extra/clang-tidy/performance/TriviallyDestructibleCheck.cpp:45 + isDefaulted(), + unless(anyOf(isFirstDecl(), isVirtual(),

[PATCH] D69613: [libTooling] Simplify type structure of `Stencil`s.

ymandel marked 5 inline comments as done. ymandel added a comment. Thanks for the review! I agreed w/ all the comments, just responding early w/ those I had further thoughts/questions on. Comment at: clang/include/clang/Tooling/Transformer/Stencil.h:82 +Stencil

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

tra added a comment. Could you, please, give us a bit more context and provide more info for the questions @rjmccall and I asked before? Is the problem specifically because autolink is not supported on device side? Or is disabling autolink just a convoluted way to avoid calling

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

MyDeveloperDay updated this revision to Diff 227317. MyDeveloperDay marked 4 inline comments as done. MyDeveloperDay added a comment. Add additional test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69577/new/ https://reviews.llvm.org/D69577 Files:

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1371 +if (Current.Previous && Current.Previous->is(tok::r_paren) && +Current.startsSequence(tok::arrow, tok::identifier, tok::less)) { + // Find the TemplateCloser.

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:67-70 +// With -std c++14 or earlier (!LangOps.CPlusPlus17), it was sufficient to +// return CtorExpr->getSourceRange(). However, starting with c++17, parsing

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

sammccall added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:955 CurrentToken->Previous->isOneOf(TT_BinaryOperator, TT_UnaryOperator, -tok::comma)) +

[PATCH] D69613: [libTooling] Simplify type structure of `Stencil`s.

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Transformer/Stencil.h:57 + /// Constructs a string representation of the StencilInterfacePart. + /// StencilInterfaceParts generated by the `selection` and `run` functions do + /// not have a unique

[PATCH] D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable()

beanz added a comment. A few comments inline. Comment at: clang/tools/driver/CMakeLists.txt:34 ${tablegen_deps} + SUPPORT_PLUGINS ) This is now a behavior change because you're always passing this. You'll want to bring back the conditional statement

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

gribozavr2 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:67-70 +// With -std c++14 or earlier (!LangOps.CPlusPlus17), it was sufficient to +// return CtorExpr->getSourceRange(). However, starting with c++17, parsing +//

[PATCH] D68923: Don't warn about missing declarations for partial template specializations

aaronpuchert added a comment. Gentle ping. I'm open to suggestions to simplify the condition, but I think templates, partial specializations and instantiations are three different things that we all need to exclude here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69548: Give clang-tidy readability-redundant-string-init a customizable list of string types to fix

gribozavr2 requested changes to this revision. gribozavr2 added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:21 +const char DefaultStringNames[] = "basic_string"; +

[PATCH] D69263: [clangd] Implement cross-file rename.

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:274 +llvm::Expected +renameOutsideFile(const NamedDecl *RenameDecl, llvm::StringRef MainFilePath, + llvm::StringRef

[PATCH] D69673: [clangd] Implement semantic highlightings via findExplicitReferences

merge_guards_bot added a comment. Build result: pass - 59818 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69666: clang: Fix assert on void pointer arithmetic with address_space

yaxunl added a comment. Is the description reversed? This attempts to preserve the source address space instead of always using the default address space for void pointer type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69666/new/ https://reviews.llvm.org/D69666

[PATCH] D69673: [clangd] Implement semantic highlightings via findExplicitReferences

ilya-biryukov created this revision. ilya-biryukov added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. To keep the logic of finding locations of interesting AST nodes in one place. The advantage is better coverage of

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

lichray added a comment. The functionality looks acceptable. Trying to parse the whole thing still looks fragile to me. I expect code owner to take a look at this change. Comment at: clang/lib/Format/TokenAnnotator.cpp:1371 +if (Current.Previous &&

[PATCH] D69657: [AArch64][SVE] Implement several floating-point arithmetic intrinsics

kmclaughlin updated this revision to Diff 227299. kmclaughlin added a comment. - Removed duplicate //AdvSIMD_Pred2VectorArg_Intrinsic// class after rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69657/new/ https://reviews.llvm.org/D69657 Files:

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

rjmccall added a comment. Yes, thanks, looks a lot better. Just a few tweaks now. Comment at: clang/include/clang/Basic/LangOptions.h:348 VersionTuple getOpenCLVersionTuple() const; + }; Spurious change. Comment at:

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev added a comment. > There is no difference in perf for GCC. Yes, but that's because gcc still optimizes the call to noinlined function. In the common scenario which this check addresses (destructor defaulted in .cpp file) gcc is not able to optimize the call. CHANGES SINCE LAST

[PATCH] D69666: clang: Fix assert on void pointer arithmetic with address_space

arsenm created this revision. arsenm added reviewers: yaxunl, jdoerfert, Anastasia. Herald added a subscriber: wdng. This attempted to always use the default address space void pointer type instead of preserving the source address space. https://reviews.llvm.org/D69666 Files:

[PATCH] D69632: [libTooling] Add Stencil constructor.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69632/new/ https://reviews.llvm.org/D69632

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:486 if (UO->getOpcode() == UO_Deref && -UO->getSubExpr()->IgnoreParenCasts()-> - isNullPointerConstant(S.Context,

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 updated this revision to Diff 227286. xbolva00 added a comment. Added testcase with typedefed int. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69664/new/ https://reviews.llvm.org/D69664 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

xbolva00 added a comment. In D69435#1728674 , @AntonBikineev wrote: > BTW, this very contrived benchmark shows 5x: > http://quick-bench.com/sczBi_lVndKut9jOj4UofC0HYew There is no difference in perf for GCC. CHANGES SINCE LAST ACTION

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked 5 inline comments as done. mibintc added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:238 CODEGENOPT(UnsafeFPMath , 1, 0) ///< Allow unsafe floating point optzns. +CODEGENOPT(RoundingFPMath, 1, 0) ///< Rounding floating point

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 created this revision. xbolva00 added reviewers: aaron.ballman, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang should not warn for: test.c:2:12: warning: indirection of non-volatile null pointer will be deleted, not trap [-Wnull-dereference]

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added a comment. I have just updated D69383 . It now defaults to `rv{XLEN}imac` on ELF, rather than `rv{XLEN}gc`. This is to help this multilib issue. In the future, we want to implement MULTILIB_REUSE properly. Hopefully before Clang 10.0.0 is

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 227283. mibintc added a comment. I followed up on some code review remarks from @rjmccall. I dropped the CODEGEN option and fixed some code formatting. I changed the spelling of the enumeration values for RoundingMode and ExceptionMode to match those

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary updated this revision to Diff 227284. lenary added a comment. - More conservative march/mabi defaults on riscv-unknown-elf - Add clang release notes about this change to -march/-mabi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69383/new/

[PATCH] D69649: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "" Parameter

mitchell-stellar added a comment. Never mind, I got it resolved and pushed. Sorry for the noise. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69649/new/ https://reviews.llvm.org/D69649 ___ cfe-commits mailing list

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev added a comment. BTW, this very contrived benchmark shows 5x: http://quick-bench.com/sczBi_lVndKut9jOj4UofC0HYew CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/ https://reviews.llvm.org/D69435 ___ cfe-commits

[PATCH] D69649: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "" Parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d7bd5752648: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial ref… (authored by mitchell-stellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8d7bd57 - [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "" Parameter

Author: Mitchell Balan Date: 2019-10-31T11:08:05-04:00 New Revision: 8d7bd57526486cab9e3daba9934042c405d7946b URL: https://github.com/llvm/llvm-project/commit/8d7bd57526486cab9e3daba9934042c405d7946b DIFF:

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a project: clang. Use of evalCall is replaced by preCall and postCall. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69662 Files:

[PATCH] D69263: [clangd] Implement cross-file rename.

merge_guards_bot added a comment. Build result: pass - 59816 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

sylvestre.ledru added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/ https://reviews.llvm.org/D69435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69649: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "" Parameter

mitchell-stellar added a comment. Thanks. Would you mind committing this on my behalf? It seems I wasn't migrated from SVN access to git access. It may take some time to sort out. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69649/new/

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev added a comment. > Did you see some significant perf improvements for Chromium? I don't see major improvements in browser benchmarks like Speedometer, but in the Blink garbage collector, which queues destructors to be executed later, this change proved to reduce the number of

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein updated this revision to Diff 227278. hokein marked 8 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69263/new/ https://reviews.llvm.org/D69263 Files:

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:219 + // us whether the ref results is completed. + RQuest.Limit = 100; + if (auto ID = getSymbolID(RenameDecl)) ilya-biryukov wrote: > Why do we need to limit the number

[PATCH] D69590: [RISCV] Fix ILP32D lowering for double+double/double+int return types

asb added a comment. Thanks James - won't this still leave problems for structs that need flattening? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69590/new/ https://reviews.llvm.org/D69590 ___

[PATCH] D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema)

ABataev added a comment. What about codegen tests? Comment at: clang/test/OpenMP/target_update_ast_print.cpp:25 + U marr[10][10][10]; +#pragma omp target update to(marr[2][0:2][0:2]) + It seems to me, the tests are not updated. All non-contiguous tests must

[PATCH] D69628: [Clang] Pragma vectorize_width() implies vectorize(enable), take 3

SjoerdMeijer updated this revision to Diff 227273. SjoerdMeijer added a comment. Thanks Michael! - moved the handling of vectorize.enable to 1 place, - that should have also sorted the relative ordering, and duplication of the metadata in some cases, - created a separate file for the new tests,

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

thakis added a comment. Tests are happy again after 1c66d09 , thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68937/new/ https://reviews.llvm.org/D68937

[PATCH] D69624: [clangd] Fix namespace aliases in findExplicitReferences

This revision was automatically updated to reflect the committed changes. ilya-biryukov marked an inline comment as done. Closed by commit rG733777a81662: [clangd] Fix namespace aliases in findExplicitReferences (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D69263: [clangd] Implement cross-file rename.

ilya-biryukov added a comment. Thanks, mostly LG! The only important comment I have left is about limiting the number of references. Others are NITs. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:219 + // us whether the ref results is completed. + RQuest.Limit =

[clang-tools-extra] 733777a - [clangd] Fix namespace aliases in findExplicitReferences

Author: Ilya Biryukov Date: 2019-10-31T13:35:25+01:00 New Revision: 733777a81662c40960e9298bb59da8c39a14f8d5 URL: https://github.com/llvm/llvm-project/commit/733777a81662c40960e9298bb59da8c39a14f8d5 DIFF: https://github.com/llvm/llvm-project/commit/733777a81662c40960e9298bb59da8c39a14f8d5.diff

[clang-tools-extra] 1c66d09 - [clangd] Add fno-delayed-parsing to new define inline tests

Author: Kadir Cetinkaya Date: 2019-10-31T13:22:52+01:00 New Revision: 1c66d09b739a8d9717ba4e9507649bc45ddf7f0d URL: https://github.com/llvm/llvm-project/commit/1c66d09b739a8d9717ba4e9507649bc45ddf7f0d DIFF:

Re: [PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

done. sorry for forgetting about this so soon. On Thu, Oct 31, 2019 at 12:58 PM Nico Weber via Phabricator < revi...@reviews.llvm.org> wrote: > thakis added inline comments. > > > > Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1388 >// results in arbitrary

  1   2   >