[PATCH] D70209: [clangd] Expose value of enumerators to Hover API. (not UI yet)

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:984 }}, + {R"cpp(enum Color { RED, [[GR^EEN]], };)cpp", + [](HoverInfo ) {

[clang] c72aef9 - [clang][IFS][test] Removing -shared, fixing triple: driver-test.c/windows.cpp.

Author: Puyan Lotfi Date: 2019-11-14T02:43:40-05:00 New Revision: c72aef999c3359f4305bf99116be604e16844aab URL: https://github.com/llvm/llvm-project/commit/c72aef999c3359f4305bf99116be604e16844aab DIFF: https://github.com/llvm/llvm-project/commit/c72aef999c3359f4305bf99116be604e16844aab.diff

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

MadCoder updated this revision to Diff 229238. MadCoder marked 2 inline comments as done. MadCoder added a comment. Implemented all the tests @rjmccall wanted (and then some) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69991/new/ https://reviews.llvm.org/D69991 Files:

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

MadCoder marked 3 inline comments as done. MadCoder added inline comments. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:4075 + + if (OMD->isClassMethod()) { +const ObjCInterfaceDecl *OID = dyn_cast(CD); rjmccall wrote: > MadCoder wrote: > > I suspect this

[clang] e782192 - [clang][IFS][test][NFC] Tightening up clang-ifs tests to use -cc1 more often.

Author: Puyan Lotfi Date: 2019-11-14T02:25:22-05:00 New Revision: e782192d5e6540b0cbb957a6b738d98e24c88ee3 URL: https://github.com/llvm/llvm-project/commit/e782192d5e6540b0cbb957a6b738d98e24c88ee3 DIFF: https://github.com/llvm/llvm-project/commit/e782192d5e6540b0cbb957a6b738d98e24c88ee3.diff

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

This revision was automatically updated to reflect the committed changes. Closed by commit rG3db6783d8a7d: Check result of emitStrLen before passing it to CreateGEP (authored by dim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70143/new/

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 created this revision. lh123 added reviewers: sammccall, ilya-biryukov, hokein. lh123 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Add support for .rsp files in

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 229233. jdoerfert added a comment. Adjust paths and test case options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69922/new/ https://reviews.llvm.org/D69922 Files:

[PATCH] D70157: Align branches within 32-Byte boundary

skan added a comment. In D70157#1745128 , @craig.topper wrote: > In D70157#1745127 , @skan wrote: > > > In D70157#1745125 , @craig.topper > > wrote: > > > > > I've

[PATCH] D70157: Align branches within 32-Byte boundary

craig.topper added a comment. In D70157#1745127 , @skan wrote: > In D70157#1745125 , @craig.topper > wrote: > > > I've definitely passed something like > > -Wl,--plugin-opt=-debug-only=isel,dagcombine on the

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

rjmccall added a comment. The symbols probably won't confuse the debugger; after all, the only difference here is that they're actually external. Of course the debugger will need work to support direct methods in general, since they won't be in method tables. CHANGES SINCE LAST ACTION

[PATCH] D70157: Align branches within 32-Byte boundary

skan added a comment. In D70157#1745125 , @craig.topper wrote: > I've definitely passed something like > -Wl,--plugin-opt=-debug-only=isel,dagcombine on the command line before. I don't know how you could pass it succcessfully. It doesn't work for me

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

MadCoder added a comment. In D69991#1744979 , @aprantl wrote: > Is it intentional that the direct method names use the exact same symbol > namespace (`\01-[class message]`) as "real" Objective-C methods? Could that > be a problem? Should we use a

[PATCH] D70157: Align branches within 32-Byte boundary

craig.topper added a comment. I've definitely passed something like -Wl,--plugin-opt=-debug-only=isel,dagcombine on the command line before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new/ https://reviews.llvm.org/D70157

[PATCH] D70219: Make `-fmodule-file==` apply to .pcm file compilations

andrewjcg created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When precompiling a header module, `-fmodule-file=name>=` flags can be used to provide an updated path to a module, which allows modules to be moved from the location they were compiled

[PATCH] D70157: Align branches within 32-Byte boundary

skan marked an inline comment as done. skan added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:88 +SmallVector BranchTypes; +StringRef(Val).split(BranchTypes, '-', -1, false); +for (auto BranchType : BranchTypes) {

[PATCH] D70157: Align branches within 32-Byte boundary

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:88 +SmallVector BranchTypes; +StringRef(Val).split(BranchTypes, '-', -1, false); +for (auto BranchType : BranchTypes) { skan wrote: > craig.topper

[PATCH] D69832: [WebAssembly] -fwasm-exceptions enables reference-types

This revision was automatically updated to reflect the committed changes. Closed by commit rG70ee430c6e45: [WebAssembly] -fwasm-exceptions enables reference-types (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69832/new/

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

Charusso marked an inline comment as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:201-207 +void CERTStrChecker::evalGets(const CallEvent , const CallContext , + CheckerContext ) const { +

[clang] 70ee430 - [WebAssembly] -fwasm-exceptions enables reference-types

Author: Heejin Ahn Date: 2019-11-13T19:44:11-08:00 New Revision: 70ee430c6e45c955051bb6b4437c2d1cad8fecb1 URL: https://github.com/llvm/llvm-project/commit/70ee430c6e45c955051bb6b4437c2d1cad8fecb1 DIFF: https://github.com/llvm/llvm-project/commit/70ee430c6e45c955051bb6b4437c2d1cad8fecb1.diff

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value *Result = Builder.CreateCall(

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value

[PATCH] D70172: [CUDA][HIP] Fix assertion due to dtor check on windows

yaxunl added a comment. sorry I think I misunderstood the meaning of "blocking" so I put it back. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70172/new/ https://reviews.llvm.org/D70172 ___ cfe-commits mailing list

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

NoQ added a subscriber: gribozavr. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:201-207 +void CERTStrChecker::evalGets(const CallEvent , const CallContext , + CheckerContext ) const { + unsigned

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

vsk updated this revision to Diff 229215. vsk added a comment. Don't emit declaration subprograms for functions with reserved names. There may not be much benefit from referencing these functions from call site tags (e.g. instead of relying on call site info to work out the arguments passed to

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

rjmccall added a comment. Could you add tests for the following cases: 1. A direct property that names a getter that is non-direct and explicitly declared in the current interface. 2. #1, but explicitly declared elsewhere, maybe in a super class or in the primary interface. 3. #1 and #2, but

[PATCH] D70157: Align branches within 32-Byte boundary

skan marked an inline comment as done. skan added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:88 +SmallVector BranchTypes; +StringRef(Val).split(BranchTypes, '-', -1, false); +for (auto BranchType : BranchTypes) {

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value *Result = Builder.CreateCall(

[PATCH] D70157: Align branches within 32-Byte boundary

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:88 +SmallVector BranchTypes; +StringRef(Val).split(BranchTypes, '-', -1, false); +for (auto BranchType : BranchTypes) { skan wrote: > chandlerc wrote:

[PATCH] D70157: Align branches within 32-Byte boundary

skan marked an inline comment as done. skan added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:88 +SmallVector BranchTypes; +StringRef(Val).split(BranchTypes, '-', -1, false); +for (auto BranchType : BranchTypes) {

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

vsk added a comment. @dblaikie thanks for chasing that down & the detailed explanation. It's unfortunate that introducing call site info affects the line table. The impact of the change seems somewhat neutral (the additional line 0 locations aren't //wrong//, exactly), so I'm not sure it's

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

aprantl added a comment. Is it intentional that the direct method names use the exact same symbol namespace (`\01-[class message]`) as "real" Objective-C methods? Could that be a problem? Should we use a slightly different naming scheme? CHANGES SINCE LAST ACTION

[PATCH] D69832: [WebAssembly] -fwasm-exceptions enables reference-types

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM, sorry for the delay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69832/new/ https://reviews.llvm.org/D69832

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

dblaikie added subscribers: probinson, echristo. dblaikie added a comment. OK - I believe the issue I'm seeing is an internal issue, a fragile/buggy test case. Please go ahead with this change if (by the sounds of it) all other concerns are addressed. For more rambling context: A test case

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

poelmanc added a comment. In D70165#1744007 , @JonasToth wrote: > LGTM! > Did you check on a real code-base that suffers from the issue, if that works > as expected? Thanks! I have now run it on our real code base and it worked as expected. I lack

[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

poelmanc updated this revision to Diff 229202. poelmanc added a comment. Change to add just one helper function `findNextTokenSkippingComments` to `LexerUtils.h`, requiring no change to `Token::isOneOf`, and properly call it from `UseEqualsDefaultCheck.cpp`. In D70144#1744737

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

Charusso marked 14 inline comments as done. Charusso added a comment. Given that we are having two different projects at first let us create the path-sensitive error-catching + false positive suppression + design of the CERT rules, and when we are fine, we get back to the impossible-to-solve

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh updated this revision to Diff 229200. lildmh added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 Files: include/clang/AST/OpenMPClause.h lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D69958: Improve VFS compatibility on Windows

amccarth updated this revision to Diff 229197. amccarth marked an inline comment as done. amccarth added a comment. Corrected comment about default for case sensitivity. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69958/new/ https://reviews.llvm.org/D69958 Files:

[PATCH] D69958: Improve VFS compatibility on Windows

amccarth marked an inline comment as done. amccarth added a comment. Thanks for the review. In D69958#1744861 , @vsapsai wrote: > There is one issue with a comment, apart of that everything looks good to me. > Looked into replacing slash and backslash

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

jdoerfert added a comment. thx. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70143/new/ https://reviews.llvm.org/D70143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm with the changes to `FindResourceDir`. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:50 + /// compiler path is NOT an absolute path. + std::string

[PATCH] D69958: Improve VFS compatibility on Windows

vsapsai added a comment. There is one issue with a comment, apart of that everything looks good to me. Looked into replacing slash and backslash literals with calls to `llvm::sys::path::get_separator` or `llvm::sys::path::is_separator` but in my attempts failed to improve existing patch.

[clang] 188d92b - [X86] Don't treat mxcsr as a register name when parsing MS inline assembly.

Author: Craig Topper Date: 2019-11-13T15:26:18-08:00 New Revision: 188d92b9470de71532ec58060cd75f913fd68e59 URL: https://github.com/llvm/llvm-project/commit/188d92b9470de71532ec58060cd75f913fd68e59 DIFF: https://github.com/llvm/llvm-project/commit/188d92b9470de71532ec58060cd75f913fd68e59.diff

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:201-207 +void CERTStrChecker::evalGets(const CallEvent , const CallContext , + CheckerContext ) const { + unsigned DestPos = *CallC.DestinationPos; + const

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

dblaikie added inline comments. Comment at: llvm/include/llvm/ADT/SmallVector.h:905 + + const SmallVector =(const std::vector ) { +this->assign(Vec.begin(), Vec.end()); aganea wrote: > dblaikie wrote: > > aganea wrote: > > > rnk wrote: > > > > +@dblaikie,

[PATCH] D69897: Add #pragma clang loop vectorize_assume_alignment(n)

lebedev.ri added a comment. To reword, if `vectorize_assume_alignment(32)` is *NOT* lowered via `CodeGenFunction::EmitAlignmentAssumption()` in clang frontend, but lowered into `LoopAttributes::VectorizeAssumeAlignment`, then once the alignment that was specified does not match reality, there

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul updated this revision to Diff 229192. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69758/new/ https://reviews.llvm.org/D69758 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains/Gnu.h clang/lib/Driver/ToolChains/Hurd.cpp

[PATCH] D70209: [clangd] Expose value of enumerators to Hover API. (not UI yet)

merge_guards_bot added a comment. Build result: pass - 59972 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70143/new/ https://reviews.llvm.org/D70143

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul marked 3 inline comments as done. sthibaul added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2623 + int MaxVersion = 0; + std::string MaxVersionString = ""; + for (llvm::vfs::directory_iterator LI = vfs.dir_begin(base, EC), LE;

[PATCH] D70209: [clangd] Expose value of enumerators to Hover API. (not UI yet)

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is part of https://github.com/clangd/clangd/issues/180. Repository: rG LLVM Github Monorepo

[PATCH] D69897: Add #pragma clang loop vectorize_assume_alignment(n)

m-happy updated this revision to Diff 229190. m-happy added a comment. Updated the syntax as suggested by Michael Kruse, and added functionality to specify the number used for alignment instead of just using 32bits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69832: [WebAssembly] -fwasm-exceptions enables reference-types

aheejin added a comment. pong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69832/new/ https://reviews.llvm.org/D69832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

MadCoder updated this revision to Diff 229183. MadCoder marked 2 inline comments as done. MadCoder added a comment. Beefed up the tests, addressed the `selfValue` related issue. Also rolled back to the `ObjCDeclInterfaceDecl` cast in GenerateDirectMethod as it turns out that all callers pass

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

MadCoder added inline comments. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:4076 + if (OMD->isClassMethod()) { +const ObjCInterfaceDecl *OID = dyn_cast(CD); +Selector SelfSel = GetNullarySelector("self", CGM.getContext()); rjmccall wrote: > When would

[PATCH] D63131: arm64_32: implement the desired ABI for the ILP32 triple.

jfb added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5457 // for AArch64, emit a warning and ignore the flag. Otherwise, add the // proper mllvm flags. + if (Triple.getArch() != llvm::Triple::aarch64 && t.p.northover

[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

JonasToth added a comment. Are you using the lexer-util functions? Maybe i am just to tired, but they seem to be unused. Comment at: clang/include/clang/Lex/Token.h:101 + /// Single argument overload provides base case for recursive template below + bool

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I like this! @gribozavr: It looks like @Charusso has independently implemented what we've talked about before . Do you agree that the

[PATCH] D69958: Improve VFS compatibility on Windows

Bigcheese accepted this revision. Bigcheese added subscribers: JDevlieghere, benlangmuir. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Looking at the blame it would be best if @JDevlieghere @vsapsai or @benlangmuir could take a look also. CHANGES SINCE LAST

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/test/OpenMP/target_defaultmap_messages.cpp:49 + + #pragma omp target defaultmap(tofrom:scalar) defaultmap(to:scalar) // expected-error {{at most one defaultmap clause for each variable-category can appear on the directive}} +

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/test/OpenMP/target_defaultmap_messages.cpp:49 + + #pragma omp target defaultmap(tofrom:scalar) defaultmap(to:scalar) // expected-error {{at most one defaultmap clause for each variable-category can appear on the directive}} +

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

NoQ added a comment. In D69962#1742291 , @Szelethus wrote: > Try to add a non-sanitizer built tablegen: > `-DCLANG_TABLEGEN=/path/to/non/sanitized/clang-tblgen` > `-DLLVM_TABLEGEN=/path/to/non/sanitized/llvm-tblgen` Yay nice! The clang that i built

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/test/OpenMP/target_defaultmap_messages.cpp:49 + + #pragma omp target defaultmap(tofrom:scalar) defaultmap(to:scalar) // expected-error {{at most one defaultmap clause for each

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/test/OpenMP/target_defaultmap_messages.cpp:49 + + #pragma omp target defaultmap(tofrom:scalar) defaultmap(to:scalar) // expected-error {{at most one defaultmap clause for each

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

Tyker updated this revision to Diff 229176. Tyker added a comment. fixed comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70190/new/ https://reviews.llvm.org/D70190 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/TextNodeDumper.h

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

rsmith added a comment. In D68407#1744486 , @leonardchan wrote: > Hi. I think this patch is causing some test failures for us: This is breaking us too, in the same way. The "problem" is that this makes the riscv64 target use the compiler-rt crtbegin /

[clang] aeaddf9 - Revert "[RISCV] Use compiler-rt if no GCC installation detected"

Author: Richard Smith Date: 2019-11-13T13:14:57-08:00 New Revision: aeaddf926a74814aa4f33050cfc12b19f419f1b0 URL: https://github.com/llvm/llvm-project/commit/aeaddf926a74814aa4f33050cfc12b19f419f1b0 DIFF: https://github.com/llvm/llvm-project/commit/aeaddf926a74814aa4f33050cfc12b19f419f1b0.diff

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

dim updated this revision to Diff 229172. dim added a comment. Now `opt` supports `-disable-builtin`, move the test to `llvm/test/Transforms/InstCombine`. Also use code style of nearest preceding constructs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/test/OpenMP/target_defaultmap_messages.cpp:49 + + #pragma omp target defaultmap(tofrom:scalar) defaultmap(to:scalar) // expected-error {{at most one defaultmap clause for each variable-category can appear on the directive}} +

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

Tyker marked an inline comment as done. Tyker added inline comments. Comment at: clang/lib/AST/TextNodeDumper.cpp:1349-1350 + } + OS << " subexpr"; + dumpPointer(D); +} Tyker wrote: > rsmith wrote: > > We shouldn't need this: the address of the declaration is

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:176 + const LocationContext *LCtx = C.getPredecessor()->getLocationContext(); + ConstraintManager = C.getConstraintManager(); + auto *CE = dyn_cast_or_null(Call.getOriginExpr());

[PATCH] D69876: Allow output constraints on "asm goto"

void updated this revision to Diff 229166. void added a comment. Move adjustment before error check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 Files: clang/docs/LanguageExtensions.rst

[PATCH] D69921: [clang-format] refactor the use of the SMDiagnostics in replacement warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rG52980576ee4a: [clang-format] refactor the use of the SMDiagnostics in replacement warnings (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5298057 - [clang-format] refactor the use of the SMDiagnostics in replacement warnings

Author: mydeveloperday Date: 2019-11-13T20:55:44Z New Revision: 52980576ee4a5683aa9a428b76335ed617f142ab URL: https://github.com/llvm/llvm-project/commit/52980576ee4a5683aa9a428b76335ed617f142ab DIFF: https://github.com/llvm/llvm-project/commit/52980576ee4a5683aa9a428b76335ed617f142ab.diff

[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

poelmanc updated this revision to Diff 229161. poelmanc edited the summary of this revision. poelmanc added a comment. Update to add and use new `findNextTokenSkippingComments` and `findNextTokenSkippingKind` utility functions. Since the former calls the latter with just one token type, this

Re: [PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

FWIW, I think it's a lot harder to make this kind of typo-bug if you always (always!) keep all your numbers in number-line order, with all the alligators' mouths opening to the right: return CT_Vector *<*= CT && CT *<*= CT_ForwardList; Some programming languages (not C++) even let you omit

[PATCH] D70203: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A.

merge_guards_bot added a comment. Build result: pass - 59972 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70196: [clang-include-fixer] Skip .rc files when finding symbols

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This seems fine as a workaround, but will obviously only affect include-fixer. I'm wary of embedding it deeper without understanding the problem though. Can you paste the *.rc entry

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

Tyker added inline comments. Comment at: clang/lib/AST/TextNodeDumper.cpp:1349-1350 + } + OS << " subexpr"; + dumpPointer(D); +} rsmith wrote: > We shouldn't need this: the address of the declaration is dumped anyway by > the infrastructure. (If you meant to

[PATCH] D70203: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A.

sammccall created this revision. sammccall added reviewers: kadircet, lh123. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. Semantically they're the same thing, and it's important when the underlying struct is anonymous. There

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

Tyker updated this revision to Diff 229156. Tyker marked 6 inline comments as done. Tyker added a comment. fixed most comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70190/new/ https://reviews.llvm.org/D70190 Files: clang/include/clang/AST/DeclCXX.h

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:201-207 +void CERTStrChecker::evalGets(const CallEvent , const CallContext , + CheckerContext ) const { + unsigned DestPos = *CallC.DestinationPos; +

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

kristina added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2623 + int MaxVersion = 0; + std::string MaxVersionString = ""; + for (llvm::vfs::directory_iterator LI = vfs.dir_begin(base, EC), LE; sthibaul wrote: > kristina wrote: > > No

[PATCH] D68578: [HIP] Fix device stub name

tra added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1099-1108 +auto *FD = const_cast((ND)); +if (auto *TD = cast(FD)->getPrimaryTemplate()) + FD = TD->getTemplatedDecl(); +auto OldDeclName = FD->getDeclName(); +auto NewNameStr =

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

leonardchan added a comment. Hi. I think this patch is causing some test failures for us: FAIL: Clang :: Driver/riscv64-toolchain.c (5479 of 16161) TEST 'Clang :: Driver/riscv64-toolchain.c' FAILED Script: -- : 'RUN: at line 3';

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:201-207 +void CERTStrChecker::evalGets(const CallEvent , const CallContext , + CheckerContext ) const { + unsigned DestPos = *CallC.DestinationPos; +

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

NoQ added a comment. In D69662#1736601 , @balazske wrote: > Anyway the checks that do not use BindExpr (all except the open functions) > could be moved into a PreCall or PostCall callback? Moving from evalCall to PreCall/PostCall has the additional

[PATCH] D70196: [clang-include-fixer] Skip .rc files when finding symbols

rnk created this revision. rnk added reviewers: sammccall, bkramer. Herald added a project: clang. For some reason CMake includes entries for .rc files, but find-all-symbols handles them improperly. See PR43993 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70196 Files:

[PATCH] D70194: [clangd] Ignore more implicit nodes in computing selection.

merge_guards_bot added a comment. Build result: pass - 59972 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69958: Improve VFS compatibility on Windows

amccarth updated this revision to Diff 229144. amccarth marked an inline comment as done. amccarth added a comment. Modified comment per feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69958/new/ https://reviews.llvm.org/D69958 Files: clang/test/Index/index-module-with-vfs.m

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:201-207 +void CERTStrChecker::evalGets(const CallEvent , const CallContext , + CheckerContext ) const { + unsigned DestPos = *CallC.DestinationPos; + const

[PATCH] D69958: Improve VFS compatibility on Windows

amccarth marked 3 inline comments as done. amccarth added a comment. Friendly ping for any VFS experts to comment. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:657 + // slashes to match backslashes (and vice versa). + bool pathComponentMatches(llvm::StringRef

[PATCH] D68578: [HIP] Fix device stub name

yaxunl updated this revision to Diff 229137. yaxunl added a comment. Attempt to prefix the kernel stub name on the fly. If we do not want to create two Decl's during parsing, and do not want to change the mangler, it seems the least invasive way to get the prefixed kernel name is to change it

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

dim added a comment. I submitted D70193 for adding a `-disable-builtin` option to `opt`. Once that is committed, this review can continue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70143/new/

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, looks good subject to some comment fixes + a tiny change to `RecursiveASTVisitor`. Comment at: clang/include/clang/AST/DeclCXX.h:3055 +/// Implicit declartion of

[PATCH] D70194: [clangd] Ignore more implicit nodes in computing selection.

sammccall created this revision. sammccall added reviewers: kadircet, lh123. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The DeclRefExpr for the callee of overloaded `operator()` and `operator[]` are assigned the

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

aganea marked an inline comment as done. aganea added inline comments. Comment at: llvm/include/llvm/ADT/SmallVector.h:905 + + const SmallVector =(const std::vector ) { +this->assign(Vec.begin(), Vec.end()); dblaikie wrote: > aganea wrote: > > rnk wrote: >

[PATCH] D70172: [CUDA][HIP] Fix assertion due to dtor check on windows

rjmccall added a reviewer: rsmith. rjmccall added a subscriber: rsmith. rjmccall added a comment. This seems like the wrong approach; @rsmith should take a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70172/new/ https://reviews.llvm.org/D70172

  1   2   >