[PATCH] D71026: Fix LLVM_ENABLE_MODULES=ON + BUILD_SHARED_LIBS=ON build

arichardson added a comment. In D71026#1769340 , @arphaman wrote: > Is the `Tooling/Transformer` library used by clang-format? The problem might > be solved if the `Tooling/Transformer` library was its own module (just like > Clang_ToolingInclusions).

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

mstorsjo added a comment. This (when reapplied in https://reviews.llvm.org/rG878a24ee244a24c39d1c57e9af2) broke compilation of code that earlier built fine. A reduced example: namespace glslang { class TPoolAllocator { void operator=(TPoolAllocator); }; template class a {

[PATCH] D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD

mgorny added a comment. In D70958#1769589 , @eugenis wrote: > I meant you could define this path in the common lit config as something like > "netbsd_noaslr_prefix" and then set up the %run substitution in > subdirectories. I take that you mean

[PATCH] D70877: [WebAssebmly][MC] Support .import_name/.import_field asm directives

dschuff added inline comments. Comment at: llvm/test/MC/WebAssembly/import-module.s:13 + .import_module foo, bar + .import_name foo, qux + What should happen if there's a directive that refers to a symbol that doesn't exist in the asm file? Repository:

[PATCH] D71049: Remove implicit conversion that promotes half to other larger precision types for fp classification builtins

Jim created this revision. Jim added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. It shouldn't promote half to double or any larger precision types for fp classification builtins. Because fp classification builtins would get incorrect result

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

nathanchance added a comment. > IMO that is misleading indentation. A single space followed by a tab? WTF I guess I will take a look over all of the warnings that cropped up and see if this is the case for all of them. If it is, I will just send patches to fix those (with the justification of

[clang] 93cc9dd - Revert "Properly convert all declaration non-type template arguments when"

Author: David L. Jones Date: 2019-12-04T22:12:15-08:00 New Revision: 93cc982f9e971f382ade6acf6634c5914966 URL: https://github.com/llvm/llvm-project/commit/93cc982f9e971f382ade6acf6634c5914966 DIFF:

[PATCH] D70726: [OpenMP50] Add parallel master construct

cchen added a comment. I've found it: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/1042 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70726/new/ https://reviews.llvm.org/D70726

[PATCH] D70877: [WebAssebmly][MC] Support .import_name/.import_field asm directives

sbc100 added a comment. ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70877/new/ https://reviews.llvm.org/D70877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70726: [OpenMP50] Add parallel master construct

cchen added a comment. How to see the test result on Windows? I've no windows machine to test the compiler. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70726/new/ https://reviews.llvm.org/D70726

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun added a comment. In the meantime, I realized lambdas are actually not that important. Lambdas are only usable in C++, and in C++ one should prefer to use move only RAII wrapper for handles. This reduces the problem into a use after move and we already have a check for that. These

[PATCH] D71043: Exclude bitfield definitions from magic numbers check

0x8000- created this revision. 0x8000- added reviewers: JonasToth, lebedev.ri, aaron.ballman, alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. 0x8000- removed a reviewer: lebedev.ri. 0x8000- edited projects, added clang-tools-extra; removed clang.

[PATCH] D70489: [clangd] Add xref for macro to static index.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9347655a2754: [clangd] Add xref for macro to static index. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70489/new/

[PATCH] D71042: WIP: [DebugInfo] Ensure fallback artificial location is available for cleanups

vsk created this revision. vsk added reviewers: aprantl, dblaikie. When `CodeGenFunction::FinishFunction()` is passed an empty end location the function does not only contain 'simple' return statements, a cleanup which involves a call may be popped. As there is no debug location set (due to the

Buildbot numbers for the week of 11/17/2019 - 11/23/2019

Hello everyone, Below are some buildbot numbers for the week of 11/17/2019 - 11/23/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted in an hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 9347655 - [clangd] Add xref for macro to static index.

Author: Utkarsh Saxena Date: 2019-12-05T04:23:18+01:00 New Revision: 9347655a275456c08222833b11ec699fafbc6de6 URL: https://github.com/llvm/llvm-project/commit/9347655a275456c08222833b11ec699fafbc6de6 DIFF:

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 added a comment. Updated benchmarks: **Before this patch** Loaded Dex from static-index.idx with estimated memory usage 354410880 bytes - number of symbols: 462463 - number of refs: 6361763 - numnber of relations: 20322 **After this patch** Num refs increases by **5.7%**

[PATCH] D71041: [analyzer][discussion] Talk about escapes

NoQ added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_create(0, get_handle_address(), ))

[PATCH] D71041: [analyzer][discussion] Talk about escapes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if

[PATCH] D70791: Workaround for MSVC 16.3.* pre-c++17 type trait linkage

STL_MSFT added a comment. > I would like to revive D66394 to get it > disabled by default soon. As I recently informed @thakis via email, our compiler documentation was incorrect (I've informed the doc team and they're going to publish a fixed article soon).

[PATCH] D70489: [clangd] Add xref for macro to static index.

merge_guards_bot added a comment. Build result: fail - 60403 tests passed, 1 failed and 726 were skipped. failed: LLVM.Bindings/Go/go.test Log files: console-log.txt , CMakeCache.txt

[PATCH] D71041: [analyzer][discussion] Talk about escapes

NoQ added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_create(0, get_handle_address(), ))

[clang] 11d1052 - Properly convert all declaration non-type template arguments when

Author: Richard Smith Date: 2019-12-04T18:55:24-08:00 New Revision: 11d10527852b4d3ed738aa90d8bec0f398160593 URL: https://github.com/llvm/llvm-project/commit/11d10527852b4d3ed738aa90d8bec0f398160593 DIFF: https://github.com/llvm/llvm-project/commit/11d10527852b4d3ed738aa90d8bec0f398160593.diff

[clang] a1d2611 - [c++17] Fix assert / wrong code when passing a noexcept pointer to

Author: Richard Smith Date: 2019-12-04T18:55:23-08:00 New Revision: a1d2611c046efa46cf32a10c9e9a8a7a8a06feba URL: https://github.com/llvm/llvm-project/commit/a1d2611c046efa46cf32a10c9e9a8a7a8a06feba DIFF: https://github.com/llvm/llvm-project/commit/a1d2611c046efa46cf32a10c9e9a8a7a8a06feba.diff

[PATCH] D71041: [analyzer][discussion] Talk about escapes

NoQ added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_create(0, get_handle_address(), ))

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 updated this revision to Diff 232250. usaxena95 marked 5 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70489/new/ https://reviews.llvm.org/D70489 Files:

[PATCH] D71041: [analyzer][discussion] Talk about escapes

xazax.hun marked 7 inline comments as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:211 + // have any pointer to that symbolic region. + if (zx_channel_create(0, get_handle_address(), )) +return; This one and its

[PATCH] D71041: [analyzer][discussion] Talk about escapes

xazax.hun created this revision. xazax.hun added reviewers: NoQ, dcoughlin, Szelethus, baloghadamsoftware, haowei. xazax.hun added a project: clang. Herald added subscribers: cfe-commits, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet. I was running the

[PATCH] D70157: Align branches within 32-Byte boundary

MaskRay added inline comments. Comment at: llvm/lib/MC/MCAssembler.cpp:1014 + unsigned EndAddr = StartAddr + Size; + return StartAddr / BoundarySize != ((EndAddr - 1) / BoundarySize); +} Division is slow. Pass in the power of 2 and use right shift instead.

[PATCH] D70157: Align branches within 32-Byte boundary

MaskRay added a comment. I find another deficiency (infinite loop) with the current approach. Say, there is a `je 0` (0x0F 0x84 0x00 0x00 0x00 0x00) at byte 0x90. (0x90+6)%32 == 0, so it ends on a 32-byte boundary. MF.getMaxPrefixSize() is 4, so the size of MCMachineDependentFragment may vary

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

thakis added a comment. In D69825#1768111 , @arphaman wrote: > @aganea Please disable the new behavior for the Darwin platform. We rely on > the fact that Clang `-cc1` processes crash to report crashes using system's > crash reporting infrastructure.

[PATCH] D70838: [clang][IFS] Ignoring -Xlinker/-Xclang arguments in InterfaceStubs pass for now.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4ef9110b8d10: [clang][IFS] Ignoring -Xlinker/-Xclang arguments in InterfaceStubs pass for now. (authored by plotfi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60499/new/ https://reviews.llvm.org/D60499

[clang] 4ef9110 - [clang][IFS] Ignoring -Xlinker/-Xclang arguments in InterfaceStubs pass for now.

Author: Puyan Lotfi Date: 2019-12-04T20:03:57-05:00 New Revision: 4ef9110b8d1004840d70477382c6bd10fb487fb6 URL: https://github.com/llvm/llvm-project/commit/4ef9110b8d1004840d70477382c6bd10fb487fb6 DIFF: https://github.com/llvm/llvm-project/commit/4ef9110b8d1004840d70477382c6bd10fb487fb6.diff

[PATCH] D69543: [clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

This revision was automatically updated to reflect the committed changes. arphaman marked an inline comment as done. Closed by commit rG27f124445755: [clangd] Add a tweak refactoring to wrap Objective-C string literals in… (authored by arphaman). Changed prior to commit:

[PATCH] D69543: [clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

arphaman marked 2 inline comments as done. arphaman added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.h:80 + const LangOptions () const { +return getASTContext().getLangOpts(); kadircet wrote: > arphaman wrote: > > kadircet wrote: > >

[clang-tools-extra] 27f1244 - [clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

Author: Alex Lorenz Date: 2019-12-04T16:58:12-08:00 New Revision: 27f124445755a80e048a68d2fabbd2fa6f40a723 URL: https://github.com/llvm/llvm-project/commit/27f124445755a80e048a68d2fabbd2fa6f40a723 DIFF: https://github.com/llvm/llvm-project/commit/27f124445755a80e048a68d2fabbd2fa6f40a723.diff

[clang-tools-extra] c0ee022 - [clangd] NFC, add getLangOpts helper to ParsedAST

Author: Alex Lorenz Date: 2019-12-04T16:55:25-08:00 New Revision: c0ee0224c4cf52bc6ba74dec88b30b850deca523 URL: https://github.com/llvm/llvm-project/commit/c0ee0224c4cf52bc6ba74dec88b30b850deca523 DIFF: https://github.com/llvm/llvm-project/commit/c0ee0224c4cf52bc6ba74dec88b30b850deca523.diff

[PATCH] D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang created this revision. akhuang added reviewers: rnk, rsmith. Herald added subscribers: cfe-commits, nhaehnle, jvesely, jholewinski. Herald added a project: clang. This adds parsing of the qualifiers __ptr32, __ptr64, __sptr, and __uptr and lowers them to the corresponding address space

[PATCH] D70157: Align branches within 32-Byte boundary

MaskRay added a comment. I am still trying to understand the patch. Just made some comments about the tests. Comment at: llvm/include/llvm/MC/MCFragment.h:663 + enum SubType : uint8_t { +// BranchPadding - The variable size fragment to insert NOP before branch. +

[clang] 3c50f25 - [analyzer] Fix more ObjC accessor body farms after 2073dd2d.

Author: Artem Dergachev Date: 2019-12-04T16:29:08-08:00 New Revision: 3c50f2544f7a8f0c41f4fc286064abce2d3629b5 URL: https://github.com/llvm/llvm-project/commit/3c50f2544f7a8f0c41f4fc286064abce2d3629b5 DIFF:

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

thakis added a comment. > It appears that only the 1st failure there is the fault of this patch. The > 2nd seems to have come from some openmp patch (that didn't consider dso_local > on windows). > > The first (fpconstrained.cpp) likely just needs the check-lines to NOT > explicitly say the

[PATCH] D70728: [clang][IFS] Adding support for new clang interface stubs decl types.

This revision was automatically updated to reflect the committed changes. Closed by commit rG07e445103e36: [clang][IFS] Adding support for new clang interface stubs decl types. (authored by plotfi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 07e4451 - [clang][IFS] Adding support for new clang interface stubs decl types.

Author: Puyan Lotfi Date: 2019-12-04T19:10:47-05:00 New Revision: 07e445103e363c85ce7313c542dee20b2294fe72 URL: https://github.com/llvm/llvm-project/commit/07e445103e363c85ce7313c542dee20b2294fe72 DIFF: https://github.com/llvm/llvm-project/commit/07e445103e363c85ce7313c542dee20b2294fe72.diff

[PATCH] D70411: [analyzer] CERT: StrChecker: 31.c

NoQ added a comment. In D70411#1769628 , @Charusso wrote: > F10966837: str31-c.tar.gz These reports seem to confirm my point. I took a look at first 5 and in all of them the code does in fact ensure that the buffer

[PATCH] D70411: [analyzer] CERT: StrChecker: 31.c

NoQ added a comment. A while back I had a look into implementing some of the CERT checkers and my vague recollection from these attempts was that it's a bad idea to take CERT examples literally. Most of the CERT rules are explained in an informal natural language and it makes CERT great for

[PATCH] D71000: [AArch64][SVE] Implement intrinsics for non-temporal loads & stores

efriedma added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:6587 + else if (!Size) +Size = MemVT.getStoreSize().getKnownMinSize(); In order for alias analysis to correctly handle a MachineMemOperand, the "Size" of an

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70469/new/ https://reviews.llvm.org/D70469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70172: [CUDA][HIP] Fix assertion due to dtor check on windows

rnk added a comment. In D70172#1746451 , @yaxunl wrote: > We are not using Itanium ABI when we do host compilation of CUDA/HIP on > windows. During the host compilation on windows only MS C++ ABI is used. > > This issue is not due to mixing MS ABI with

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker added a comment. the warning was not affected by -ftabstop. i made a patch that fix this. https://reviews.llvm.org/D71037 and I agree that mixing tabs and space is a horrible idea for many reasons. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69471: [Coverage] Revise format to reduce binary size

vsk reopened this revision. vsk marked an inline comment as done. vsk added a comment. This revision is now accepted and ready to land. I reverted this due to failures on Windows that I did not encounter in local testing. I suspect that there's an error in the coverage parsing logic, as the

[PATCH] D70615: Add an -fno-temp-file flag for compilation

rnk added a comment. +more reviewers This doesn't add any code complexity, we already have the boolean UseTempFile flag, so I think we should do this. I would also point out that right now, in my LLVM build directory on Windows, I have 895 *.obj.tmp files: $ find . -iname '*.obj.tmp' | wc

[PATCH] D70726: [OpenMP50] Add parallel master construct

ABataev reopened this revision. ABataev added a comment. This revision is now accepted and ready to land. Need to fix tests on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70726/new/ https://reviews.llvm.org/D70726

[PATCH] D70726: [OpenMP50] Add parallel master construct

rnk added a comment. One of the new tests doesn't pass on Windows, so I reverted this in rG33f6d465d790ac5c9b949e6bc05127d356212079 . I made an attempt to fix the checks, but it wasn't trivial. Repository: rG LLVM Github

[PATCH] D70764: build: reduce CMake handling for zlib

beanz added a comment. I conferred off-list with @compnerd. He and I talked through my concerns, and I believe this patch is fine as-is, so LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70764/new/ https://reviews.llvm.org/D70764

[PATCH] D70996: Bug 43965 - Value of _MSVC_LANG doesn't match MSVC++ VS2019 /std:c++latest mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c29aed6980d: Bug 43965 - Value of _MSVC_LANG doesnt match MSVC++ VS2019 /std:c++latest mode (authored by Manna, committed by rnk). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] 9c29aed - Bug 43965 - Value of _MSVC_LANG doesn't match MSVC++ VS2019 /std:c++latest mode

Author: Soumi Manna Date: 2019-12-04T14:39:41-08:00 New Revision: 9c29aed6980dce42f2a071db09663c435ac21ad1 URL: https://github.com/llvm/llvm-project/commit/9c29aed6980dce42f2a071db09663c435ac21ad1 DIFF: https://github.com/llvm/llvm-project/commit/9c29aed6980dce42f2a071db09663c435ac21ad1.diff

[PATCH] D71033: [analyzer] CERT: StrChecker: 32.c

Charusso added a comment. Examples generated by CodeChecker from the `curl` project: F10966937: str32-c.tar.gz Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71033/new/ https://reviews.llvm.org/D71033

[PATCH] D71033: [analyzer] CERT: StrChecker: 32.c

Charusso marked an inline comment as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:357 + + // 'strlen(something) + something' is most likely fine. + // FIXME: Use the 'SValVisitor' to catch every such constructs of the

[PATCH] D71033: [analyzer] CERT: StrChecker: 32.c

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. This checker warns on most of the following rules:

[PATCH] D69471: [Coverage] Revise format to reduce binary size

efriedma added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:53-56 +Error E = +zlib::compress(FilenamesStr, CompressedStr, zlib::BestSizeCompression); +if (E) + llvm_unreachable("Unexpected failure in zlib::compress");

[PATCH] D67463: [MS] Warn when shadowing template parameters under -fms-compatibility

tstellar added a comment. In D67463#1769557 , @rnk wrote: > In D67463#1769238 , @tstellar wrote: > > > In D67463#1767919 , @rnk wrote: > > > > > @hans, are we still

[PATCH] D70805: [analyzer] SValHasDescendant: Determine whether the SVal has an SVal descendant

Charusso updated this revision to Diff 232206. Charusso added a comment. - Add back a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70805/new/ https://reviews.llvm.org/D70805 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValHasDescendant.h

[PATCH] D70805: [analyzer] SValHasDescendant: Determine whether the SVal has an SVal descendant

Charusso added a comment. Here is a possible piece of code from the Tidy world: `anyOf(declRefExpr(), hasDescendant(declRefExpr()), integerLiteral(), hasDescendant(integerLiteral()))`, that is why I recommend to allow equality of symbols to prevent boilerplate. CHANGES SINCE LAST ACTION

[PATCH] D70805: [analyzer] SValHasDescendant: Determine whether the SVal has an SVal descendant

Charusso updated this revision to Diff 232203. Charusso edited the summary of this revision. Charusso added a comment. - Add more tests. - Let us specify the descendant as allowing equality of symbols. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70805/new/

[PATCH] D70411: [analyzer] CERT: StrChecker: 31.c

Charusso added a comment. I have picked `curl` as an example, because it has a measurable amount of reports. I still recommend to make this alpha, because the expression-tracking cannot track members, and peoples are using members everywhere. F10966837: str31-c.tar.gz

[PATCH] D70411: [analyzer] CERT: StrChecker: 31.c

Charusso updated this revision to Diff 232198. Charusso added a comment. - Tweaking. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70411/new/ https://reviews.llvm.org/D70411 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D70172: [CUDA][HIP] Fix assertion due to dtor check on windows

yaxunl added inline comments. Comment at: clang/test/SemaCUDA/deleting-dtor.cu:45-46 + +// Only MS has diagnostic since MS requires deleting dtor is emitted when +// vtable is emitted, even though dtor is not defined. +namespace MSEmitDeletingDtor { tra wrote: >

[PATCH] D70172: [CUDA][HIP] Fix assertion due to dtor check on windows

yaxunl updated this revision to Diff 232197. yaxunl marked 2 inline comments as done. yaxunl added a comment. remove unnecessary states added to Sema. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70172/new/ https://reviews.llvm.org/D70172 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D70764: build: reduce CMake handling for zlib

beanz added a comment. @labath sorry for not replying on-list. I've actually been discussing offline with @compnerd. If `llvm-config` is printing an absolute path, I'm concerned about how that will interact with binary package distributions for the llvm-dev packages. Not sure if @tstellar has

[PATCH] D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD

eugenis added a comment. I meant you could define this path in the common lit config as something like "netbsd_noaslr_prefix" and then set up the %run substitution in subdirectories. > PaX ASLR on NetBSD is too aggressive with the layout randomization and we > cannot predict ranges of the heap

Re: Github build status reporting

Hi Alex, Buildbot uses txgithub (https://github.com/tomprince/txgithub) to invoke Github API. Thanks Galina On Tue, Dec 3, 2019 at 12:36 PM Alex L wrote: > Hi Galina, > > Thanks for doing this! I'm curious as to how the buildbot CI communicates > with Github, is the buildbot itself capable

[PATCH] D70693: [scan-build-py] Set of small fixes

NoQ accepted this revision. NoQ added a comment. In D70693#1762137 , @xazax.hun wrote: > So after investigating the effects of this patch, the result is the following: > > Verbose mode (`-v`) that also prints findings to the command line will no > longer

[clang] 6120582 - [OPENMP50]Add support for if clause for simd part in taskloop simd

Author: Alexey Bataev Date: 2019-12-04T15:50:39-05:00 New Revision: 61205821ca20dbf1d9a4dc2c1c590955b249e8ee URL: https://github.com/llvm/llvm-project/commit/61205821ca20dbf1d9a4dc2c1c590955b249e8ee DIFF: https://github.com/llvm/llvm-project/commit/61205821ca20dbf1d9a4dc2c1c590955b249e8ee.diff

[PATCH] D67463: [MS] Warn when shadowing template parameters under -fms-compatibility

rnk added a comment. In D67463#1769238 , @tstellar wrote: > In D67463#1767919 , @rnk wrote: > > > @hans, are we still accepting 9.0.1 patches? I thought we'd already made a > > release candidate. > > > I'm still

[PATCH] D70764: build: reduce CMake handling for zlib

labath added a comment. `/usr/lib/x86_64-linux-gnu/libz.so` is definitely better than `-l/usr/lib/x86_64-linux-gnu/libz.so`, as it's at least a valid link line. It's not completely equivalent, and may not work in all cases -- last time I accidentally changed this, I got about a dozen emails

[PATCH] D70219: Make `-fmodule-file==` apply to .pcm file compilations

andrewjcg updated this revision to Diff 232190. andrewjcg added a comment. rebase onto monorepo and clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70219/new/ https://reviews.llvm.org/D70219 Files:

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

erichkeane added a comment. In D62731#1769532 , @thakis wrote: > The tests fail on Windows, http://45.33.8.238/win/3405/step_6.txt > > Please take a look, and if it takes a while to fix please revert while you > investigte. It appears that only the 1st

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. I reverted it again because build break on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 ___ cfe-commits mailing list

[clang] 5412913 - Revert " Reapply af57dbf12e54 "Add support for options -frounding-math, ftrapping-math, -ffp-model=, and -ffp-exception-behavior=""

Author: Melanie Blower Date: 2019-12-04T12:21:23-08:00 New Revision: 5412913631feef74f7d52c092e947227c1cc7b04 URL: https://github.com/llvm/llvm-project/commit/5412913631feef74f7d52c092e947227c1cc7b04 DIFF:

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

thakis added a comment. The tests fail on Windows, http://45.33.8.238/win/3405/step_6.txt Please take a look, and if it takes a while to fix please revert while you investigte. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/

[clang] 90fce46 - Fix crash-on-invalid-code in lambda constant evaluation.

Author: James Y Knight Date: 2019-12-04T15:12:17-05:00 New Revision: 90fce46fa6c9ccec86f642be0a75da2d0a5b11c1 URL: https://github.com/llvm/llvm-project/commit/90fce46fa6c9ccec86f642be0a75da2d0a5b11c1 DIFF:

[clang] 975a435 - [OPENMP]Update list of implemented features, NFC.

Author: Alexey Bataev Date: 2019-12-04T15:11:19-05:00 New Revision: 975a43512709a9e989dea11d2fefab9212e3a4f4 URL: https://github.com/llvm/llvm-project/commit/975a43512709a9e989dea11d2fefab9212e3a4f4 DIFF: https://github.com/llvm/llvm-project/commit/975a43512709a9e989dea11d2fefab9212e3a4f4.diff

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

merge_guards_bot added a comment. Build result: pass - 60475 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71001: [Clang-Tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

xazax.hun added a comment. This might be a strange argument, but I did see this happen several times at different companies. When a company tries to decide which lint tools to use they are doing an evaluation. Usually, people doing the evaluation are not compiler/static analysis devs. Given

[PATCH] D69223: WDocumentation: Implement the \anchor.

Mordante marked an inline comment as done. Mordante added a comment. Thanks for the review! I recently acquired commit access so I'll commit it after updating the unit test. Comment at: clang/lib/AST/TextNodeDumper.cpp:493 + case comments::InlineCommandComment::RenderAnchor:

[PATCH] D71001: [Clang-Tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

aaron.ballman added a comment. In D71001#1769048 , @gribozavr2 wrote: > In D71001#1769035 , @Eugene.Zelenko > wrote: > > > > ASan can help debug this issue, and more. > > > > This is dynamic analysis, and

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

jkorous added a comment. The use of `xcrun` looks sound to me. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:53 + } + StringRef Path = Buf->get()->getBuffer().trim(); + if (Path.empty()) { The `trim()` is probably safe - just wondering if that

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

merge_guards_bot added a comment. Build result: pass - 60480 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc marked an inline comment as done. mibintc added a comment. I've pushed the updated patch, commit cdbed2dd856c14687efd741c2d8321686102acb8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71012: Also check /Fo when deciding on the .gcna / .gcda filename (PR44208)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/Driver/ToolChains/Clang.cpp:911 // bitcode file in the case of LTO. // FIXME: There should be a simpler way to find the object file for this //

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

ABataev updated this revision to Diff 232184. ABataev added a comment. Restored message + some small improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70973/new/ https://reviews.llvm.org/D70973 Files: clang/include/clang/Basic/Attr.td

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 added a comment. In D70926#1769437 , @MyDeveloperDay wrote: > LGTM > > A little advice as you fix each comment check the "Done" button. > > I notice you are a new user, will you need help landing it? Thanks for the review! And yes I do need

[PATCH] D71001: [Clang-Tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

Eugene.Zelenko added a comment. In D71001#1769429 , @gribozavr2 wrote: > In D71001#1769394 , @Eugene.Zelenko > wrote: > > > With such logic, Clang-tidy is maintenance burden: 368 unaddressed request > > in

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

dblaikie added a comment. I feel like there's something missing about this bug/issue - is there a good explanation/understanding for why does the bug only occur with the two levels of static member inline variable templates & not one? Perhaps there's some existing code that works for simple

[clang] cdbed2d - Reapply af57dbf12e54 "Add support for options -frounding-math, ftrapping-math, -ffp-model=, and -ffp-exception-behavior="

Author: Melanie Blower Date: 2019-12-04T11:32:33-08:00 New Revision: cdbed2dd856c14687efd741c2d8321686102acb8 URL: https://github.com/llvm/llvm-project/commit/cdbed2dd856c14687efd741c2d8321686102acb8 DIFF:

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM A little advice as you fix each comment check the "Done" button. I notice you are a new user, will you need help landing it? Repository: rG LLVM Github Monorepo

[PATCH] D70764: build: reduce CMake handling for zlib

JDevlieghere added a comment. In D70764#1767413 , @compnerd wrote: > In D70764#1767395 , @JDevlieghere > wrote: > > > Having one canonical variable controlling zlib support seems indeed > > desirable. > > > > In

[PATCH] D71001: [Clang-Tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

gribozavr2 added a comment. In D71001#1769394 , @Eugene.Zelenko wrote: > With such logic, Clang-tidy is maintenance burden: 368 unaddressed request in > Bugzilla is very telling. Doesn't that just prove the point that we already have a problem with

  1   2   3   >