[PATCH] D70157: Align branches within 32-Byte boundary

skan added a comment. In D70157#1771771 , @reames wrote: > We uncovered another functional issue with this patch, or at least, the > interaction of this patch and other parts of LLVM. In our support for > STATEPOINT, PATCHPOINT, and STACKMAP we use

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

Charusso closed this revision. Charusso added a comment. Forgotten `amend` of commit message. Commited as: https://github.com/llvm/llvm-project/commit/8d288a0668a574863d52784084ff565c89f7366e Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69181/new/

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

hfinkel added a comment. In D71179#1774487 , @jdoerfert wrote: > In D71179#1774471 , @ABataev wrote: > > > They do this because they have several function definitions with the same > > name. In our case, we have

[PATCH] D70052: [clang-tidy] Add misc-mutating-copy check

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I think it is fine, but please let us wait with the final thoughts from @aaron.ballman. Comment at: clang-tools-extra/clang-tidy/cert/MutatingCopyCheck.cpp:21 +static

[clang] cafc741 - [c++20] Synthesis of defaulted comparison functions.

Author: Richard Smith Date: 2019-12-08T23:21:52-08:00 New Revision: cafc7416baf7eecef8ecaf05802f2f7c0da725c0 URL: https://github.com/llvm/llvm-project/commit/cafc7416baf7eecef8ecaf05802f2f7c0da725c0 DIFF: https://github.com/llvm/llvm-project/commit/cafc7416baf7eecef8ecaf05802f2f7c0da725c0.diff

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

hfinkel added inline comments. Comment at: clang/lib/Headers/openmp_wrappers/__clang_openmp_math_declares.h:17 #if defined(__NVPTX__) && defined(_OPENMP) Should we use a more-specific selector and then get rid of this `__NVPTX__` check?

[clang] 27f5d35 - Fix for build bot failure. For more details see:

Author: Zahira Ammarguellat Date: 2019-12-09T00:50:30-05:00 New Revision: 27f5d35137cb45e60d9988a9b55875883c55023c URL: https://github.com/llvm/llvm-project/commit/27f5d35137cb45e60d9988a9b55875883c55023c DIFF:

[PATCH] D70615: Add an -fno-temp-file flag for compilation

zahen added a comment. In our build system every file access in an "output directory" needs to be accounted for. Until this patch, the random temporary file name has forced us to rely on workarounds that hurt build throughput. I've uploaded example ProcMon dumps of clang-cl.exe file accesses

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert added a comment. In D71179#1774471 , @ABataev wrote: > They do this because they have several function definitions with the same > name. In our case, we have several different functions with different names > and for us no need to worry about

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

ABataev added a comment. In D71179#1774470 , @jdoerfert wrote: > In D71179#1774469 , @ABataev wrote: > > > In D71179#1774448 , @jdoerfert > > wrote: > > > > > In

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert added a comment. In D71179#1774469 , @ABataev wrote: > In D71179#1774448 , @jdoerfert wrote: > > > In D71179#177 , @ABataev wrote: > > > > > I read the spec

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

ABataev added a comment. In D71179#1774448 , @jdoerfert wrote: > In D71179#177 , @ABataev wrote: > > > I read the spec and don't think that we need all this complex stuff for the > > implementation. Yiu need

[PATCH] D64034: [c++] Implement categorizing pointer-to-bool as narrowing conversions

lichray updated this revision to Diff 232752. lichray added a comment. Regenerate the diff in Git, update description, link to paper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64034/new/ https://reviews.llvm.org/D64034 Files:

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert added a comment. In D71179#177 , @ABataev wrote: > I read the spec and don't think that we need all this complex stuff for the > implementation. Yiu need judt to check at the codegen phase if the function > must be emitted or not. We don't

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

ABataev added a comment. I read the spec and don't think that we need all this complex stuff for the implementation. Yiu need judt to check at the codegen phase if the function must be emitted or not. We don't even need to move context checksnfrom codegen, because with the current semantics

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

merge_guards_bot added a comment. Build result: FAILURE - Log files: console-log.txt , CMakeCache.txt Repository: rG

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert marked 4 inline comments as done. jdoerfert added inline comments. Comment at: clang/lib/AST/StmtOpenMP.cpp:2243 } + +// TODO: We have various representations for the same data, it might help to This code was basically only moved, not written for this

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert updated this revision to Diff 232750. jdoerfert added a comment. Add (missing) include. (Worked locally just fine). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71179/new/ https://reviews.llvm.org/D71179 Files:

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

merge_guards_bot added a comment. Build result: FAILURE - Log files: console-log.txt , CMakeCache.txt Repository: rG

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert created this revision. jdoerfert added reviewers: kiranchandramohan, ABataev, RaviNarayanaswamy, gtbercea, grokos, sdmitriev, JonChesterfield, hfinkel, fghanim. Herald added subscribers: s.egerton, guansong, bollu, simoncook, fedor.sergeev, aheejin, rampitec. Herald added a project:

[PATCH] D70594: [clangd] Implement range patching heuristics for cross-file rename.

merge_guards_bot added a comment. Build result: pass - 60605 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70594: [clangd] Implement range patching heuristics for cross-file rename.

hokein updated this revision to Diff 232744. hokein added a comment. some minor fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70594/new/ https://reviews.llvm.org/D70594 Files: clang-tools-extra/clangd/refactor/Rename.cpp

[PATCH] D70594: [clangd] Implement range patching heuristics for cross-file rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:452 + for (int Pos : MatchedIndex) +Mapped.push_back(Lexed[Pos]); + return MatchedCB(std::move(Mapped)); sammccall wrote: > if we're actually evaluating all

[PATCH] D70594: [clangd] Implement range patching heuristics for cross-file rename.

merge_guards_bot added a comment. Build result: pass - 60605 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70594: [clangd] Implement range patching heuristics for cross-file rename.

hokein updated this revision to Diff 232743. hokein marked 21 inline comments as done. hokein added a comment. address reveiw comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70594/new/ https://reviews.llvm.org/D70594 Files:

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

This revision was automatically updated to reflect the committed changes. Closed by commit rG74e6ce2529fa: [Frontend] Allow OpenMP offloading to aarch64 (authored by bryanpkc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/

[clang] 74e6ce2 - [Frontend] Allow OpenMP offloading to aarch64

Author: Bryan Chan Date: 2019-12-08T14:45:16-05:00 New Revision: 74e6ce2529fae2c3318731c6f4f77bfa92eb6eb7 URL: https://github.com/llvm/llvm-project/commit/74e6ce2529fae2c3318731c6f4f77bfa92eb6eb7 DIFF: https://github.com/llvm/llvm-project/commit/74e6ce2529fae2c3318731c6f4f77bfa92eb6eb7.diff

[PATCH] D67052: Add reference type transformation builtins

zoecarver added a comment. @EricWF ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67052/new/ https://reviews.llvm.org/D67052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71142: [Sema] Validate large bitfields

Mordante marked an inline comment as done. Mordante added a comment. In D71142#1774270 , @xbolva00 wrote: > Maybe a bit offtopic, but it would be good to diagnose this case too: > > enum A {a, b, c = 8}; > > struct T { > enum A field : 2; >

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7424 + ParsedAttr ) { + if (CurType->isFunctionType()) { +State.getSema().Diag(Attr.getLoc(),

[PATCH] D67265: [clang-tidy] Magic number checker shouldn't warn on user defined string literals

0x8000- added a comment. Herald added a subscriber: mgehre. @aaron.ballman - can you please review this patch and if you find it acceptable please integrate it? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67265/new/

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7424 + ParsedAttr ) { + if (CurType->isFunctionType()) { +State.getSema().Diag(Attr.getLoc(),

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp:22 +namespace { +Matcher hasAnyListedName(const std::string ) { + const std::vector NameList = Please use static for functions. See LLVM Coding

[clang] a05d7c2 - Fix typo in the AST Matcher Reference doc Closes: #54

Author: Sylvestre Ledru Date: 2019-12-08T16:14:31+01:00 New Revision: a05d7c278ee2a29aec73dbe5316e5cf2a2d190f8 URL: https://github.com/llvm/llvm-project/commit/a05d7c278ee2a29aec73dbe5316e5cf2a2d190f8 DIFF:

[PATCH] D71142: [Sema] Validate large bitfields

xbolva00 added a comment. Maybe a bit offtopic, but it would be good to diagnose this case too: enum A {a, b, c = 8}; struct T { enum A field : 2; }; GCC catches this bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71142/new/

[PATCH] D71142: [Sema] Validate large bitfields

Mordante marked 2 inline comments as done. Mordante added a comment. Further testing revealed the Codegen already has decided the limit. `clang/lib/CodeGen/CGRecordLayout.h:64`: struct CGBitFieldInfo { /// The offset within a contiguous run of bitfields that are represented as /// a

[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

davezarzycki added a comment. Sorry, I had to revert this for breaking things. Please ping me when you have a new patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71154/new/ https://reviews.llvm.org/D71154

[clang] b324902 - Revert "Driver: Don't look for libc++ headers in the install directory on Android."

Author: David Zarzycki Date: 2019-12-08T16:41:46+02:00 New Revision: b32490270b786d2c5ba154e613ee2d5e36ed4197 URL: https://github.com/llvm/llvm-project/commit/b32490270b786d2c5ba154e613ee2d5e36ed4197 DIFF:

[PATCH] D71141: [Wdocumentation] Use C2x/C++14 deprecated attribute

Mordante marked an inline comment as done. Mordante added a comment. Thanks for the review! I'll wait with committing until @gribozavr2 had time to review this patch and D71140 . Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

ztamas added a comment. I run the new check on LLVM codebase with the option CharTypdefsToIgnore = "int8_t". The check produced 12 findings. All findings seem valid use cases, where a char -> integer conversion happens. I had a closer look at some of the catches. Somewhere I see only type

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

ztamas added a comment. I run the new check on LibreOffice codebase with the option CharTypdefsToIgnore = "sal_Int8". The check produced 32 findings. I see 3 false positives which are similar to the DereferenceWithTypdef test case where the code uses sal_Int8 typedef, but the check still

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

ztamas created this revision. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. This check searches for signed char -> integer conversions which might indicate programming error, because of the misinterpretation of char values. A signed char might store the

[PATCH] D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase

merge_guards_bot added a comment. Build result: pass - 60602 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71172: [clang][Tooling] Fix potential UB in ExpandResponseFilesCompilationDatabase

lh123 created this revision. lh123 added reviewers: kadircet, sammccall, hokein. Herald added subscribers: cfe-commits, usaxena95, ilya-biryukov. Herald added a project: clang. `vector::assign` will cause UB at here. fixes: https://github.com/clangd/clangd/issues/223 Repository: rG LLVM

[PATCH] D71111: [Sema] Improve diagnostic about addr spaces for overload candidates

rjmccall added a comment. Hmm. How about: // For the `this` argument candidate function not viable: 'this' object is in '__private' address space, but method expects object in '__global' address space // For pointer arguments candidate function not viable: cannot pass pointer to