[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1778736 , @ABataev wrote: > In D71241#1778717 , @jdoerfert wrote: > > > >> There is no evidence that this is more complicated. By all measures, > > >> this is less complicated

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille added a comment. @george.burgess.iv : up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/ https://reviews.llvm.org/D71082 ___ cfe-commits mailing list

[PATCH] D71300: [clangd] Deduplicate refs from index for cross-file rename.

ilya-biryukov added a comment. The fix itself LGTM. Just a few NITs and this is good to go. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:34 +// Covnert a Range to a Ref. +std::pair toRef(const clangd::Range , +

[PATCH] D71208: CodeGen: Allow annotations on globals in non-zero address space

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. In D71208#1776667 , @nhaehnle wrote: > > My concern is that there's something that's going to blow up or miscompile > > if we start passing in

[PATCH] D71325: [Remarks][Driver] Ask for line tables when remarks are enabled

thegameg created this revision. thegameg added reviewers: JDevlieghere, friss, aprantl. Herald added a project: clang. Serialized remarks contain debug locations for each remark, by storing a file path, a line, and a column. Also, remarks support being embedded in a .dSYM bundle using a

[clang] f7235ac - [cxx_status] Re-add missing cell.

Author: Richard Smith Date: 2019-12-10T19:56:07-08:00 New Revision: f7235ac1d3154d5cd82a9a6bfdfffd050e6f5d05 URL: https://github.com/llvm/llvm-project/commit/f7235ac1d3154d5cd82a9a6bfdfffd050e6f5d05 DIFF: https://github.com/llvm/llvm-project/commit/f7235ac1d3154d5cd82a9a6bfdfffd050e6f5d05.diff

[clang] ffe6129 - [c++20] Implement P1946R0: allow defaulted comparisons to take their

Author: Richard Smith Date: 2019-12-10T19:54:35-08:00 New Revision: ffe612922cb5aa2767c79d47a1b162811a08583f URL: https://github.com/llvm/llvm-project/commit/ffe612922cb5aa2767c79d47a1b162811a08583f DIFF: https://github.com/llvm/llvm-project/commit/ffe612922cb5aa2767c79d47a1b162811a08583f.diff

[PATCH] D70411: [analyzer] CERT: StrChecker: Implementing most of the STR31-C

Charusso added a comment. In D70411#1776460 , @NoQ wrote: > Ok, so, what should the checker warn on? What should be the intended state > machine for this checker? > > We basically have two possible categories of answers to this question: > > - "The

[PATCH] D70411: [analyzer] CERT: StrChecker: Implementing most of the STR31-C

Charusso updated this revision to Diff 233252. Charusso marked 7 inline comments as done. Charusso retitled this revision from "[analyzer] CERT: StrChecker: 31.c" to "[analyzer] CERT: StrChecker: Implementing most of the STR31-C". Charusso edited the summary of this revision. Charusso added a

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao added a comment. In D71227#1778136 , @tra wrote: > I wonder if this patch will help with this case: > > https://godbolt.org/z/X4KdsV > > __device__ float fn(int) { return threadIdx.x; }; > __host__ float fn(float); > > float gvar1 =

[clang] 8e0c9e2 - [c++20] Delete defaulted comparison functions if they would invoke an

Author: Richard Smith Date: 2019-12-10T19:28:30-08:00 New Revision: 8e0c9e21bf5f3e7a427b07e3eaf3bc80d2c74cb6 URL: https://github.com/llvm/llvm-project/commit/8e0c9e21bf5f3e7a427b07e3eaf3bc80d2c74cb6 DIFF: https://github.com/llvm/llvm-project/commit/8e0c9e21bf5f3e7a427b07e3eaf3bc80d2c74cb6.diff

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

compnerd added a comment. Should probably add a check for `__block` variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71301/new/ https://reviews.llvm.org/D71301 ___ cfe-commits mailing list

[PATCH] D71322: [analyzer] CStringChecker: Fix overly eager assumption that memcmp arguments overlap.

NoQ added a comment. > Instead, i conservatively assume that they don't overlap, unless they're > already known to certainly overlap on the current execution path. This loses > a bit of coverage but the lost path is where they do actually overlap. This > path is in my opinion not only rare but

[PATCH] D71322: [analyzer] CStringChecker: Fix overly eager assumption that memcmp arguments overlap.

NoQ updated this revision to Diff 233249. NoQ added a comment. Fair point. Yeah, i wonder what the real difference is :/ Added tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71322/new/ https://reviews.llvm.org/D71322 Files: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp

[PATCH] D71322: [analyzer] CStringChecker: Fix overly eager assumption that memcmp arguments overlap.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Could you write a test for `strcmp` please? I have found out the `evalMemcmp` behaves differently than `evalStrcmp`. However when the `memcmp` is going to be used like `strcmp`/`strncmp`

[PATCH] D71322: [analyzer] CStringChecker: Fix overly eager assumption that memcmp arguments overlap.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. NoQ added a parent revision: D71321:

[PATCH] D71049: Remove implicit conversion that promotes half to other larger precision types for fp classification builtins

Jim added a comment. @uweigand This is fixed by https://reviews.llvm.org/rG9c3966379813c198129c57aa3ebecd68d6af1ebd Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71049/new/ https://reviews.llvm.org/D71049

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

keryell added inline comments. Comment at: clang/lib/Sema/SemaSYCL.cpp:44 + +class KernelBodyTransform : public TreeTransform { +public: Feel free to add more comments in this area up to line 103. Comment at: clang/lib/Sema/SemaSYCL.cpp:417 +

[PATCH] D71321: [analyzer] CStringChecker: Warning text fixes.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Cool, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71321/new/ https://reviews.llvm.org/D71321 ___

Re: [PATCH] D68896: PR43080: Do not build context-sensitive expressions during name classification.

On Tue, 10 Dec 2019 at 13:24, Kian Moniri via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > kianm added a comment. > > Hi, I am still seeing problems with this assertion. Could we please get a > fix? I've posted the reduced test case and reproducible command on this >

[clang] 2e48be0 - Fix mishandling of invalid-but-non-empty nested name specifiers in name

Author: Richard Smith Date: 2019-12-10T17:55:30-08:00 New Revision: 2e48be09b02e6d01b85d31704d768b6d0c751751 URL: https://github.com/llvm/llvm-project/commit/2e48be09b02e6d01b85d31704d768b6d0c751751 DIFF: https://github.com/llvm/llvm-project/commit/2e48be09b02e6d01b85d31704d768b6d0c751751.diff

[PATCH] D66333: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message

NoQ added inline comments. Comment at: cfe/trunk/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:295-297 + OS << "Null pointer argument in call to " << CurrentFunctionDescription + << ' ' << IdxOfArg << llvm::getOrdinalSuffix(IdxOfArg) + << " parameter";

[PATCH] D71321: [analyzer] CStringChecker: Warning text fixes.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. Fixes the problem mentioned in

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

merge_guards_bot added a comment. Build result: FAILURE - Could not check out parent git hash "9a3d576b08c13533597182498ba5e739924f892f". It was not found in the repository. Did you configure the "Parent Revision" in Phabricator properly? Trying to apply the patch to the master branch

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

merge_guards_bot added a comment. Build result: pass - 60692 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1778717 , @jdoerfert wrote: > >> There is no evidence that this is more complicated. By all measures, this > >> is less complicated (see also below). It is also actually doing the right > >> thing when it comes to code

[libunwind] 57fc8ec - Reland "Enable `-funwind-tables` flag when building libunwind"

Author: Sergej Jaskiewicz Date: 2019-12-11T04:27:04+03:00 New Revision: 57fc8ecdbaa7fbb1a13907ca3f7a3cb9f9459d27 URL: https://github.com/llvm/llvm-project/commit/57fc8ecdbaa7fbb1a13907ca3f7a3cb9f9459d27 DIFF:

[clang] bc24014 - [c++20] Implement P1185R2 (as modified by P2002R0).

Author: Richard Smith Date: 2019-12-10T17:24:27-08:00 New Revision: bc24014b9765a454cb5214f4871451a41ffb7d29 URL: https://github.com/llvm/llvm-project/commit/bc24014b9765a454cb5214f4871451a41ffb7d29 DIFF: https://github.com/llvm/llvm-project/commit/bc24014b9765a454cb5214f4871451a41ffb7d29.diff

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert updated this revision to Diff 233238. jdoerfert added a comment. Fix math problem Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71179/new/ https://reviews.llvm.org/D71179 Files: clang/include/clang/AST/Decl.h

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70268/new/ https://reviews.llvm.org/D70268

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. >> There is no evidence that this is more complicated. By all measures, this is >> less complicated (see also below). It is also actually doing the right thing >> when it comes to code emission. Take https://godbolt.org/z/sJiP3B for >> example. The calls are wrong

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

merge_guards_bot added a comment. Build result: FAILURE - Could not check out parent git hash "9a3d576b08c13533597182498ba5e739924f892f". It was not found in the repository. Did you configure the "Parent Revision" in Phabricator properly? Trying to apply the patch to the master branch

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

merge_guards_bot added a comment. Build result: FAILURE - Could not check out parent git hash "9a3d576b08c13533597182498ba5e739924f892f". It was not found in the repository. Did you configure the "Parent Revision" in Phabricator properly? Trying to apply the patch to the master branch

[clang] d5e66f0 - NFC: Get rid of an unused parameter to CGObjCMac::EmitSelectorAddr.

Author: Erik Pilkington Date: 2019-12-10T16:54:48-08:00 New Revision: d5e66f0e060da7f175cedf4f545fb4e13df7707e URL: https://github.com/llvm/llvm-project/commit/d5e66f0e060da7f175cedf4f545fb4e13df7707e DIFF:

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks!! Nothing controversial remains here, right? :) Comment at: clang/include/clang/StaticAnalyzer/Core/CheckerManager.h:91 + /// that the analyzer cannot follow during a

Buildbot numbers for the week of 12/1/2019 - 12/7/2019

Hello everyone, Below are some buildbot numbers for the last week of 12/1/2019 - 12/7/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 11/24/2019 - 11/30/2019

Hello everyone, Below are some buildbot numbers for the week of 11/24/2019 - 11/30/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun updated this revision to Diff 233235. xazax.hun added a comment. - Rebasing after reverting the pre-escaping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71224/new/ https://reviews.llvm.org/D71224 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert updated this revision to Diff 233232. jdoerfert added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Consistent overload based solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71179/new/

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert updated this revision to Diff 233234. jdoerfert added a comment. Diff against TOT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71179/new/ https://reviews.llvm.org/D71179 Files: clang/include/clang/AST/Decl.h

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. There can be another one issue with this solution with inline assembly. I’m not completely sure about it, will try to investigate it tomorrow. I suggest to discuss this solution with Richard Smith (or John McCall). If he/they are ok with this transformation of the AST,

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

Bigcheese updated this revision to Diff 233233. Bigcheese added a comment. Refactored `FullDependencies::getAdditionalCommandLine` and `ModuleDeps::getFullCommandLine` to share code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70268/new/

[PATCH] D71317: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi created this revision. plotfi added reviewers: compnerd, cishida. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Built libdispatch with clang interface stubs. Ran into some block related issues. Basically VarDecl symbols can leak out because I wasn't

[clang] 8434fbb - Revert "[analyzer] Keep track of escaped locals"

Author: Gabor Horvath Date: 2019-12-10T16:42:03-08:00 New Revision: 8434fbbee62e382376a39787785909bd55ae1696 URL: https://github.com/llvm/llvm-project/commit/8434fbbee62e382376a39787785909bd55ae1696 DIFF: https://github.com/llvm/llvm-project/commit/8434fbbee62e382376a39787785909bd55ae1696.diff

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

michele.scandale added a comment. In D62731#1775046 , @mibintc wrote: > In D62731#1773854 , > @michele.scandale wrote: > > > I've noticed you removed the change for `CompilerInvocation.cpp` about the > >

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1778564 , @hfinkel wrote: > In D71241#1778134 , @ABataev wrote: > > > > > > ... > > >> > >> > >>> Also, check how -ast-print works with your solution. It returns different >

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1778564 , @hfinkel wrote: > In D71241#1778134 , @ABataev wrote: > > > > > > ... > > >> > >> > >>> Also, check how -ast-print works with your solution. It returns different >

[PATCH] D70805: [analyzer] SValHasDescendant: Determine whether the SVal has an SVal descendant

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValHasDescendant.h:55 + bool VisitSymbolRegionValue(const SymbolRegionValue *S) { +return Visit(S->getRegion()); + } Arithmetic is indeed easy, but for example

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

NoQ added a comment. What about `__attribute__((acquire_handle("fuchsia")))`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70469/new/ https://reviews.llvm.org/D70469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70320: [Analyzer] [NFC] Iterator Checkers - Separate iterator modeling and the actual checkers

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. > I plan some refactoring but this first patch is meant to be a single > separation of code. Sounds great! Comment at:

[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

void created this revision. void added reviewers: jyknight, nickdesaulniers, hfinkel. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71314 Files: clang/lib/Analysis/UninitializedValues.cpp

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1778134 , @ABataev wrote: > ... >> >> >>> Also, check how -ast-print works with your solution. It returns different >>> result than expected because you're transform the code too early. It is >>> incorrect

[PATCH] D70912: [Analyzer] Iterator Modeling: Print Container Data and Iterator Positions when printing the Program State

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Fantastic, thanks!! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70912/new/ https://reviews.llvm.org/D70912 ___ cfe-commits mailing list

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

steven_wu added inline comments. Comment at: llvm/lib/LTO/LTOBackend.cpp:335 + .Case("bitcode", EmbedBitcodeKind::Embed_Bitcode) + .Case("marker", EmbedBitcodeKind::Embed_Marker) + .Default(~0U);

[PATCH] D70439: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools

NoQ accepted this revision. NoQ added a comment. Thanks!!~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70439/new/ https://reviews.llvm.org/D70439 ___ cfe-commits mailing list

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

ABataev added a comment. In D71179#1778512 , @hfinkel wrote: > In D71179#1776761 , @ABataev wrote: > > > In D71179#1776528 , @hfinkel wrote: > > > > > In D71179#1776491

[PATCH] D70244: [Analyzer] Iterator Checkers: Replace `UnknownVal` in comparison result by a conjured value

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. That's a fair point, these days we always have to account for unknown values. I'm still curious (for science!) about how exactly it came to be in the tests. Repository: rC Clang CHANGES SINCE

[PATCH] D71313: [AST] Split parent map traversal logic into ParentMapContext.h

rnk created this revision. rnk added reviewers: bkramer, klimek, rsmith. Herald added subscribers: lldb-commits, kbarton, mgorny, nemanjai. Herald added projects: clang, LLDB. The only part of ASTContext.h that requires most AST types to be complete is the parent map. Nothing in Clang proper uses

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

hfinkel added a comment. In D71179#1776761 , @ABataev wrote: > In D71179#1776528 , @hfinkel wrote: > > > In D71179#1776491 , @ABataev wrote: > > > > > In D71179#1776487

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

NoQ added a comment. In D71224#1778332 , @xazax.hun wrote: > So basically what I am wonder/worrying about is the following: > The analyzer core will decide that the stack region is escaped and the > checkers has no word about this. Yup, you got me.

Re: [clang] 7f9b513 - Reapply af57dbf12e54 "Add support for options -frounding-math, ftrapping-math, -ffp-model=, and -ffp-exception-behavior="

So you left some debugging code in that I've fixed thusly: "Enclosing function uses fp intrinsics" commit f4a7d5659df7cb56c1baa34a39e9fe2639472741 Author: Eric Christopher Date: Tue Dec 10 15:02:29 2019 -0800 Remove debugging printf and reformat code. On Thu, Dec 5, 2019 at 3:48 AM

[clang] f4a7d56 - Remove debugging printf and reformat code.

Author: Eric Christopher Date: 2019-12-10T15:04:45-08:00 New Revision: f4a7d5659df7cb56c1baa34a39e9fe2639472741 URL: https://github.com/llvm/llvm-project/commit/f4a7d5659df7cb56c1baa34a39e9fe2639472741 DIFF:

[PATCH] D71152: [analyzer] Keep track of escaped locals.

xazax.hun added a comment. Whoops, this one was updated accidentally. Wrong tab :( CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71152/new/ https://reviews.llvm.org/D71152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun updated this revision to Diff 233200. xazax.hun added a comment. - First take on trying to reuse `processPointerEscapedOnBind`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71224/new/ https://reviews.llvm.org/D71224 Files:

[PATCH] D71152: [analyzer] Keep track of escaped locals.

xazax.hun updated this revision to Diff 233198. xazax.hun added a comment. - A first take on trying to reuse `processPointerEscapedOnBind`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71152/new/ https://reviews.llvm.org/D71152 Files:

[PATCH] D71239: [clang-format] Fix ObjC keywords following try/catch getting split.

Bigcheese marked an inline comment as done. Bigcheese added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1849 + } while (FormatTok->is(tok::comment)); +} if (!(FormatTok->isOneOf(tok::kw_catch, Keywords.kw___except,

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun added a comment. I think I found the main problem with the current model, at least for the FuchsiaHandleCheck. Consider the following two snippets: zx_handle_t *get_handle_address(); void escape_store_to_escaped_region01() { zx_handle_t sb; if (zx_channel_create(0,

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun added a comment. In D71224#1778303 , @NoQ wrote: > In D71224#1778284 , @xazax.hun wrote: > > > So I was wondering if we got the default right. Maybe a checker should do > > more work to get the escaping

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

NoQ added a comment. In D71224#1778284 , @xazax.hun wrote: > So I was wondering if we got the default right. Maybe a checker should do > more work to get the escaping rather than more work preventing it? But that's exactly how it works right now(?) If

[PATCH] D71300: [clangd] Deduplicate refs from index for cross-file rename.

merge_guards_bot added a comment. Build result: pass - 60688 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun added a comment. In D71224#1778231 , @NoQ wrote: > In D71224#1778204 , @xazax.hun wrote: > > > I don't think this is a good enough model currently. The problem is that, > > it does not play well with

[PATCH] D71226: Also synthesize _cmd and self for properties

liuliu added a comment. Thanks. Verified in our codebase this patch indeed fixed the crashes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71226/new/ https://reviews.llvm.org/D71226 ___ cfe-commits

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi created this revision. plotfi added reviewers: compnerd, cishida. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Built libdispatch with clang interface stubs. Ran into some block related issues. Basically VarDecl symbols can leak out because I wasn't

[PATCH] D71300: [clangd] Deduplicate refs from index for cross-file rename.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, mgrang, jkorous, MaskRay. Herald added a project: clang. If the index returns duplicated refs, it will trigger the assertion in BuildRenameEdit (we expect the processing

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

NoQ added a comment. In D71224#1778204 , @xazax.hun wrote: > I don't think this is a good enough model currently. The problem is that, it > does not play well with annotations. E.g. the checker can see a symbol > escaping, but it does not have a whole

[PATCH] D70613: Add method to ignore invisible AST nodes

steveire updated this revision to Diff 233183. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70613/new/ https://reviews.llvm.org/D70613 Files: clang/include/clang/AST/ASTNodeTraverser.h

[PATCH] D70613: Add method to ignore invisible AST nodes

steveire marked 10 inline comments as done. steveire added a comment. It wasn't possible to add the `const` because of the return type. Comment at: clang/include/clang/AST/Expr.h:769-770 + /// implicit conversions. + Expr *IgnoreInvisible(); + const Expr *IgnoreInvisible()

[clang] 3e1562e - Debug Info: Strengthen the synthesized-property-cleanup.mm test, NFC

Author: Vedant Kumar Date: 2019-12-10T13:39:22-08:00 New Revision: 3e1562e83339bb1e18fb36a5a2fc629c75f5f239 URL: https://github.com/llvm/llvm-project/commit/3e1562e83339bb1e18fb36a5a2fc629c75f5f239 DIFF: https://github.com/llvm/llvm-project/commit/3e1562e83339bb1e18fb36a5a2fc629c75f5f239.diff

[clang] 02d04d5 - [OPENMP50]Do not mark the function as used if referenced only in declare

Author: Alexey Bataev Date: 2019-12-10T16:30:14-05:00 New Revision: 02d04d569edd39a17f27995565b7b65ac06afb35 URL: https://github.com/llvm/llvm-project/commit/02d04d569edd39a17f27995565b7b65ac06afb35 DIFF: https://github.com/llvm/llvm-project/commit/02d04d569edd39a17f27995565b7b65ac06afb35.diff

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun added a comment. In D71224#1778179 , @NoQ wrote: > In any case, every checker is allowed to make their own decisions about > escaping. Escape on its own is not material, it's all about how the checker > reacts to escapes. Say, it's up to

[PATCH] D68896: PR43080: Do not build context-sensitive expressions during name classification.

kianm added a comment. Hi, I am still seeing problems with this assertion. Could we please get a fix? I've posted the reduced test case and reproducible command on this Phabricator patch. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3bd7cbb - [Remarks][Docs] Enhance documentation for opt-remarks driver options

Author: Francis Visoiu Mistrih Date: 2019-12-10T13:19:49-08:00 New Revision: 3bd7cbb90cdb9cf2ca481107ec66a75d9c885782 URL: https://github.com/llvm/llvm-project/commit/3bd7cbb90cdb9cf2ca481107ec66a75d9c885782 DIFF:

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

NoQ added a comment. In any case, every checker is allowed to make their own decisions about escaping. Escape on its own is not material, it's all about how the checker reacts to escapes. Say, it's up to MallocChecker to decide whether the function may or may not release memory that escapes on

[PATCH] D70613: Add method to ignore invisible AST nodes

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Expr.h:769-770 + /// implicit conversions. + Expr *IgnoreInvisible(); + const Expr *IgnoreInvisible() const { +return const_cast(this)->IgnoreInvisible(); `Invisible` is a bit of an

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker added a comment. now that the issue with uniqueness of expressions is solved. we should be able to keep going on that review @rsmith. https://reviews.llvm.org/D63960 should be i think close to completion. so maybe for testing i could use immediate invocation as a source for ConstantExpr

[clang] 336ac71 - [cxx_status] Fix table layout.

Author: Richard Smith Date: 2019-12-10T13:03:12-08:00 New Revision: 336ac7197eeeb4ab083f7402ec4edbb9b7bb252c URL: https://github.com/llvm/llvm-project/commit/336ac7197eeeb4ab083f7402ec4edbb9b7bb252c DIFF: https://github.com/llvm/llvm-project/commit/336ac7197eeeb4ab083f7402ec4edbb9b7bb252c.diff

[clang] 68009c2 - [c++20] Return type deduction for defaulted three-way comparisons.

Author: Richard Smith Date: 2019-12-10T13:03:12-08:00 New Revision: 68009c245dbe4c420ca06c0fea2a908f918137bb URL: https://github.com/llvm/llvm-project/commit/68009c245dbe4c420ca06c0fea2a908f918137bb DIFF: https://github.com/llvm/llvm-project/commit/68009c245dbe4c420ca06c0fea2a908f918137bb.diff

[PATCH] D71166: Deprecate the hasDefaultArgument matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e315ba2547c: Deprecate the hasDefaultArgument matcher (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D71166?vs=232711=233177#toc Repository: rG LLVM Github Monorepo

[clang] 3e315ba - Deprecate the hasDefaultArgument matcher

Author: Stephen Kelly Date: 2019-12-10T20:48:45Z New Revision: 3e315ba2547cbbfd6055e38bbca03f4d11bacbea URL: https://github.com/llvm/llvm-project/commit/3e315ba2547cbbfd6055e38bbca03f4d11bacbea DIFF: https://github.com/llvm/llvm-project/commit/3e315ba2547cbbfd6055e38bbca03f4d11bacbea.diff

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

tra added a comment. I wonder if this patch will help with this case: https://godbolt.org/z/X4KdsV __device__ float fn(int) { return threadIdx.x; }; __host__ float fn(float); float gvar1 = []()__device__ { return fn(1);} (); // This ends up calling fn(int) on *host* We seem to

[clang] ef94cd1 - [OPENMP50]Add if clause in target simd directive.

Author: Alexey Bataev Date: 2019-12-10T15:33:18-05:00 New Revision: ef94cd1cf81d6e66838e1d7395fdaa6795ec7165 URL: https://github.com/llvm/llvm-project/commit/ef94cd1cf81d6e66838e1d7395fdaa6795ec7165 DIFF: https://github.com/llvm/llvm-project/commit/ef94cd1cf81d6e66838e1d7395fdaa6795ec7165.diff

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1777972 , @jdoerfert wrote: > In D71241#109 , @ABataev wrote: > > > In D71241#1777661 , @jdoerfert > > wrote: > > > > > In

RE: [clang] d82b6ba - Revert "[DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified."

[AMD Official Use Only - Internal Distribution Only] Thank You! Eric for clarifying this. I wasn't sure about this. I don't know why my git script missed that string in commit message, and allowed me to commit it. Any way thanks again. From: Eric Christopher Sent: Wednesday, December 11, 2019

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

tra added a subscriber: rsmith. tra added a comment. Looks good to me overall. I've pinged rsmith@ to double-check that we're covering all possibilities for non-local variable init. Comment at: clang/include/clang/Sema/Sema.h:11037 +

[PATCH] D71141: [Wdocumentation] Use C2x/C++14 deprecated attribute

This revision was automatically updated to reflect the committed changes. Mordante marked 2 inline comments as done. Closed by commit rGb6d386f6f996: [Wdocumentation] Use C2x/C++14 deprecated attribute (authored by Mordante). Changed prior to commit:

[PATCH] D71139: [Wdocumentation] Use the command marker

This revision was automatically updated to reflect the committed changes. Closed by commit rG85fff898bb31: [Wdocumentation] Use the command marker. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71139/new/

[PATCH] D71140: [Wdocumentation] Properly place deprecated attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGb972f2d05e8b: [Wdocumentation] Properly place deprecated attribute (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71140/new/

[PATCH] D71294: [OpenMP] Emit warning message about undefined number of evaluation for atomic update/capture

cchen planned changes to this revision. cchen added a comment. Don't know there is an analysis phase in Clang, I'll investigate later, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71294/new/ https://reviews.llvm.org/D71294

[PATCH] D71224: [analyzer] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:624 +if (const MemRegion *MR = Call.getArgSVal(Arg).getAsRegion()) + if (!MR->hasStackStorage()) +

[clang] 85fff89 - [Wdocumentation] Use the command marker.

Author: Mark de Wever Date: 2019-12-10T21:16:07+01:00 New Revision: 85fff898bb3175693e12536a837c8ad0ec8b2cdd URL: https://github.com/llvm/llvm-project/commit/85fff898bb3175693e12536a837c8ad0ec8b2cdd DIFF: https://github.com/llvm/llvm-project/commit/85fff898bb3175693e12536a837c8ad0ec8b2cdd.diff

  1   2   3   >