[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

mehdi_amini added a comment. > Will it make sense to say "I don't want hyper-threads" ? Not sure I remember correctly, but I believe one motivation behind avoiding "hyper-threads" and other virtual cores was that while they improve slightly the performance, they also increase the peak memory

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

mehdi_amini added a comment. Also: using heavyweight_hardware_concurrency() in the linker but having multiple linker jobs schedules by the build system was another reason (I think LLVM CMake default to 2 parallel link jobs when using ThinLTO for instance). Repository: rG LLVM Github

[PATCH] D71746: Fix the "TypeError: a bytes-like object is required, not 'str'" in exploded-graph-rewriter.py on Python 3.5+

psamolysov added a comment. @NoQ Could you commit, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71746/new/ https://reviews.llvm.org/D71746 ___ cfe-commits mailing list

[PATCH] D71686: Fix false positive in magic number checker

0x8000- marked an inline comment as done. 0x8000- added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-magic-numbers-todo.cpp:9 +{ + if (((int)4) > ProcessSomething(10)) + // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: 4 is a magic

[PATCH] D71686: Fix false positive in magic number checker

0x8000- updated this revision to Diff 234998. 0x8000- added a comment. Add a test file for expected failures CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71686/new/ https://reviews.llvm.org/D71686 Files: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp

[PATCH] D71625: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache file.

andreil99 accepted this revision. andreil99 added a comment. This revision is now accepted and ready to land. Thanks, Vlad! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71625/new/ https://reviews.llvm.org/D71625

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

annita.zhang added a comment. In D70157#1793280 , @reames wrote: > I've gone ahead and landed the patch so that we can iterate in tree. See > commit 14fc20ca62821b5f85582bf76a467d412248c248 >

[clang] bab67ba - fix a doc typo to cycle bots

Author: Nico Weber Date: 2019-12-20T21:39:01-05:00 New Revision: bab67ba6a3c451fbadd6b8b38c5043ef7e316d56 URL: https://github.com/llvm/llvm-project/commit/bab67ba6a3c451fbadd6b8b38c5043ef7e316d56 DIFF: https://github.com/llvm/llvm-project/commit/bab67ba6a3c451fbadd6b8b38c5043ef7e316d56.diff

[PATCH] D71686: Fix false positive in magic number checker

0x8000- marked an inline comment as done. 0x8000- added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp:129 +// expanded class enumeration value. +if (Parent.get()) +

[PATCH] D71791: [CFG] Fix an assertion failure with static initializers

Charusso added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:5923 + if (isa(Cond) || isa(Cond)) return nullptr; What about the following?: ```lang=c if (const auto *E = dyn_cast(StmtElem->getStmt())) return E->IgnoreParens(); return nullptr;

[PATCH] D71791: [CFG] Fix an assertion failure with static initializers

xazax.hun created this revision. xazax.hun added reviewers: Szelethus, NoQ. xazax.hun added a project: clang. Herald added subscribers: cfe-commits, Charusso, gamesh411, dkrupp, rnkovacs. The branches protecting the static initializers have a `DeclStmt` as last `Stmt`. Since it is not an

[PATCH] D43357: [Concepts] Function trailing requires clauses

saar.raz added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2068-2069 if (ParseAsmAttributesAfterDeclarator(D)) return nullptr; rsmith wrote: > We should check with GCC to see which side of the requires-clause they expect > this. > >

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

MaskRay added a comment. In D70157#1793280 , @reames wrote: > I've gone ahead and landed the patch so that we can iterate in tree. See > commit 14fc20ca62821b5f85582bf76a467d412248c248 >

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

leonardchan added a comment. Hi! This seems to be causing some test failures on our bots: https://ci.chromium.org/p/fuchsia/builders/ci/clang-linux-x64/b8893521019883752048 : 'RUN: at line 553'; /b/s/w/ir/k/recipe_cleanup/clangciZYdn/llvm_build_dir/bin/clang -### -target

[PATCH] D71686: Fix false positive in magic number checker

0x8000- marked an inline comment as done. 0x8000- added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp:129 +// expanded class enumeration value. +if (Parent.get()) +

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. @MaskRay I will mail you off-list with one question. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70048/new/ https://reviews.llvm.org/D70048 ___ cfe-commits mailing list

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. Herald added a subscriber: arichardson. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70048/new/ https://reviews.llvm.org/D70048 ___ cfe-commits mailing list

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

efriedma added a comment. > and it seems to involve a lot of AST traversal I was thinking we'd just call into SemaChecking in appropriate places. I guess there's a little AST traversal to figure whether an expression forms an array address. Your idea seems simpler. > remove elements from

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

delcypher added inline comments. Comment at: compiler-rt/lib/ubsan/ubsan_value.cpp:29 +const char *__ubsan::getObjCClassName(ValueHandle Pointer) { +#if defined(__APPLE__) + // We need to query the ObjC runtime for some information, but do not want vsk wrote: >

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions.

riccibruno added a comment. @rsmith Could you take a look at this patch when you have some time? This is the last C++17 sequencing rule which is missing from `SequenceChecker` and is very similar to the other already accepted patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D71463: Implement VectorType conditional operator GNU extension.

erichkeane updated this revision to Diff 234977. erichkeane marked 4 inline comments as done. erichkeane added a comment. @aaron.ballman s comments done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71463/new/ https://reviews.llvm.org/D71463 Files: clang/docs/LanguageExtensions.rst

[PATCH] D71698: [AArch64][SVE] Add intrinsic for non-faulting loads

efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:5333 + // We need a layer of indirection because early machine code passes balk at + // physical register (i.e. FFR) uses that have no previous definition. + let hasSideEffects = 1,

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

poelmanc updated this revision to Diff 234976. poelmanc added a comment. Address most of the feedback, I'll comment individually. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68682/new/ https://reviews.llvm.org/D68682 Files:

[PATCH] D70270: clang-tidy: modernize-use-using uses AST and now supports struct defintions and multiple types in a typedef

poelmanc added a comment. Any further feedback or thoughts on this? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70270/new/ https://reviews.llvm.org/D70270 ___ cfe-commits mailing list

[PATCH] D71463: Implement VectorType conditional operator GNU extension.

erichkeane marked 13 inline comments as done. erichkeane added a comment. New patch coming as soon as my build finishes. Comment at: clang/docs/LanguageExtensions.rst:480 =yes yes yes yes -:? yes --

[PATCH] D71758: [Lexer] Allow UCN for dollar symbol '\u0024' in identifiers when using -fdollars-in-identifiers flag.

rsmith added a comment. This seems reasonable to me, and matches GCC 10's behavior; `$` is not in the basic source character set, so encoding it with a UCN should be permitted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71758/new/

[PATCH] D70689: [analyzer] Fix SARIF column locations

jranieri-grammatech updated this revision to Diff 234971. jranieri-grammatech added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70689/new/ https://reviews.llvm.org/D70689 Files:

[PATCH] D70689: [analyzer] Fix SARIF column locations

jranieri-grammatech marked 4 inline comments as done. jranieri-grammatech added inline comments. Comment at: clang/test/Analysis/diagnostics/sarif-multi-diagnostic-test.c:35-36 +{ + int løçål = 0; + /* ☃ */ return 1 / løçål; // expected-warning {{Division by zero}} +}

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71708/new/ https://reviews.llvm.org/D71708

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru updated this revision to Diff 234972. sylvestre.ledru added a comment. alias => aliases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36051/new/ https://reviews.llvm.org/D36051 Files:

[clang] 0378f3a - Revert "Customize simplified dumping and matching of LambdaExpr"

Author: Stephen Kelly Date: 2019-12-20T21:33:31Z New Revision: 0378f3a90341d990236c44f297b923a32b35fab1 URL: https://github.com/llvm/llvm-project/commit/0378f3a90341d990236c44f297b923a32b35fab1 DIFF: https://github.com/llvm/llvm-project/commit/0378f3a90341d990236c44f297b923a32b35fab1.diff

[PATCH] D71709: Give frontend dump flags consistent names (*-dump instead of dump-*)

herzka updated this revision to Diff 234966. herzka added a comment. Herald added a reviewer: jdoerfert. change flags in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71709/new/ https://reviews.llvm.org/D71709 Files:

[PATCH] D71680: Customize simplified dumping and matching of LambdaExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rG494b1318ca77: Customize simplified dumping and matching of LambdaExpr (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D71680?vs=234636=234968#toc Repository: rG LLVM

[PATCH] D71722: Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot

This revision was automatically updated to reflect the committed changes. Closed by commit rG44b4b833ad76: Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot (authored by aprantl). Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Repository: rG LLVM Github

[PATCH] D71680: Customize simplified dumping and matching of LambdaExpr

thakis added a comment. Looks like this might break tests: http://45.33.8.238/linux/6150/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71680/new/ https://reviews.llvm.org/D71680 ___

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61072 tests passed, 0 failed and 728 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[clang] 494b131 - Customize simplified dumping and matching of LambdaExpr

Author: Stephen Kelly Date: 2019-12-20T21:13:23Z New Revision: 494b1318ca77927e919bbf9a61749a58553d738c URL: https://github.com/llvm/llvm-project/commit/494b1318ca77927e919bbf9a61749a58553d738c DIFF: https://github.com/llvm/llvm-project/commit/494b1318ca77927e919bbf9a61749a58553d738c.diff

[clang] 44b4b83 - Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot

Author: Adrian Prantl Date: 2019-12-20T13:11:17-08:00 New Revision: 44b4b833ad76fc61e43473c581a557f72a4ed8f4 URL: https://github.com/llvm/llvm-project/commit/44b4b833ad76fc61e43473c581a557f72a4ed8f4 DIFF: https://github.com/llvm/llvm-project/commit/44b4b833ad76fc61e43473c581a557f72a4ed8f4.diff

[PATCH] D71463: Implement VectorType conditional operator GNU extension.

aaron.ballman added inline comments. Comment at: clang/docs/LanguageExtensions.rst:480 =yes yes yes yes -:? yes -- -- -- +:?[*]_ yes -- yes --

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev updated this revision to Diff 234950. ABataev added a comment. Removed check for isArrow() + added requested test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71708/new/ https://reviews.llvm.org/D71708 Files:

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

This revision was automatically updated to reflect the committed changes. Closed by commit rG59878ec8092b: [analyzer] Add path notes to FuchsiaHandleCheck. (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D70725?vs=231996=234952#toc Repository: rG LLVM Github

[PATCH] D71686: Fix false positive in magic number checker

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp:129 +// expanded class enumeration value. +if (Parent.get()) + return true;

[PATCH] D70725: [analyzer] Add path notes to FuchsiaHandleCheck

xazax.hun added a comment. Thanks for the reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70725/new/ https://reviews.llvm.org/D70725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

xazax.hun added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70470/new/ https://reviews.llvm.org/D70470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 59878ec - [analyzer] Add path notes to FuchsiaHandleCheck.

Author: Gabor Horvath Date: 2019-12-20T12:40:41-08:00 New Revision: 59878ec8092bef656a71d22261fd3b70651e8318 URL: https://github.com/llvm/llvm-project/commit/59878ec8092bef656a71d22261fd3b70651e8318 DIFF: https://github.com/llvm/llvm-project/commit/59878ec8092bef656a71d22261fd3b70651e8318.diff

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

This revision was automatically updated to reflect the committed changes. xazax.hun marked 2 inline comments as done. Closed by commit rG82923c71efa5: [analyzer] Add Fuchsia Handle checker (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D70470?vs=233691=234948#toc

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

reames added a comment. I've gone ahead and landed the patch so that we can iterate in tree. See commit 14fc20ca62821b5f85582bf76a467d412248c248 . I've also landed a couple of follow up patches to address issues which would

[PATCH] D69876: Allow output constraints on "asm goto"

void marked an inline comment as done. void added inline comments. Comment at: clang/test/CodeGen/asm-goto.c:91 + return 1; +} nickdesaulniers wrote: > Thanks for adding this test. I think it doesn't test that `addr` is > *clobbered* though? The `+` modifier

[clang] 82923c7 - [analyzer] Add Fuchsia Handle checker

Author: Gabor Horvath Date: 2019-12-20T12:33:16-08:00 New Revision: 82923c71efa57600d015dbc281202941d3d64dde URL: https://github.com/llvm/llvm-project/commit/82923c71efa57600d015dbc281202941d3d64dde DIFF: https://github.com/llvm/llvm-project/commit/82923c71efa57600d015dbc281202941d3d64dde.diff

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd567b0ba841d: Avoid unsupported LLD options (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D70700: [WebAssembly] Mangle the argc/argv `main` as `__wasm_argc_argv`

sbc100 added a comment. __wasm_argc_argv -> __main_argc_argv in the title? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70700/new/ https://reviews.llvm.org/D70700 ___ cfe-commits mailing list

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

rjmccall added a comment. Thanks. Could you add some tests that `nontemporal` directives aren't disturbed by either (1) nested `nontemporal` directives or (2) nested directives of some other kind? Comment at: clang/lib/CodeGen/CGExpr.cpp:3952 +

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3952 + CGM.getOpenMPRuntime().isNontemporalDecl(Field)) || + (!E->isArrow() && BaseLV.isNontemporal())) +LV.setNontemporal(/*Value=*/true); rjmccall wrote: >

[clang] d567b0b - Avoid unsupported LLD options

Author: Sid Manning Date: 2019-12-20T14:18:10-06:00 New Revision: d567b0ba841d4b6f4b0d906da350a3bb2b2f769f URL: https://github.com/llvm/llvm-project/commit/d567b0ba841d4b6f4b0d906da350a3bb2b2f769f DIFF: https://github.com/llvm/llvm-project/commit/d567b0ba841d4b6f4b0d906da350a3bb2b2f769f.diff

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev updated this revision to Diff 234943. ABataev added a comment. Fix + rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71708/new/ https://reviews.llvm.org/D71708 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D70700: [WebAssembly] Mangle the argc/argv `main` as `__wasm_argc_argv`

sunfish updated this revision to Diff 234942. sunfish added a comment. To support a transition to the new system, temporarily define a `__main_void` alias for no-argument `main`. This allows libc to detect whether it's calling old-style or new-style main and do the right thing. Repository:

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

rjmccall added a comment. In D69272#1792928 , @sepavloff wrote: > In D69272#1792877 , @kpn wrote: > > > My understanding of this patch is that it only allows the #pragma at the > > top of each function. It doesn't

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. LGTM! Yeah, please update the ASCII-art, it's great and every checker should have it. Comment at: clang/docs/analyzer/checkers.rst:1341 + +Fuchsia Checkers. +

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3952 + CGM.getOpenMPRuntime().isNontemporalDecl(Field)) || + (!E->isArrow() && BaseLV.isNontemporal())) +

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun marked an inline comment as done. xazax.hun added a comment. Thanks for the review! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70469/new/ https://reviews.llvm.org/D70469 ___ cfe-commits mailing list

[PATCH] D71709: Give frontend dump flags consistent names (*-dump instead of dump-*)

herzka added a comment. I worry that repeating all those names in those tests might be noisy. I think I'll switch those to use the new name, but add another test that makes sure both names still work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe17b30a7957: [attributes][analyzer] Add annotations for handles. (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D70469?vs=234341=234940#toc Repository: rG LLVM Github

[clang] fe17b30 - [attributes][analyzer] Add annotations for handles.

Author: Gabor Horvath Date: 2019-12-20T11:47:55-08:00 New Revision: fe17b30a79572f0d50fe78f6a07d5194cbf90860 URL: https://github.com/llvm/llvm-project/commit/fe17b30a79572f0d50fe78f6a07d5194cbf90860 DIFF: https://github.com/llvm/llvm-project/commit/fe17b30a79572f0d50fe78f6a07d5194cbf90860.diff

[PATCH] D71619: [CLANG] Alignment specifier not applied to anonymous structure or union

aaron.ballman closed this revision. aaron.ballman added a comment. In D71619#1791961 , @kamleshbhalui wrote: > removed c++11 from the test. > I do not have commit access, Can someone commit this for me? Thank you for the patch! I've commit on your

[clang] 304d130 - Apply the alignment specifier attribute to anonymous unions and structs.

Author: Kamlesh Kumar Date: 2019-12-20T14:42:37-05:00 New Revision: 304d1304b7bac190b6c9733eb07be284bfc17030 URL: https://github.com/llvm/llvm-project/commit/304d1304b7bac190b6c9733eb07be284bfc17030 DIFF: https://github.com/llvm/llvm-project/commit/304d1304b7bac190b6c9733eb07be284bfc17030.diff

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG14fc20ca6282: Align branches within 32-Byte boundary (NOP padding) (authored by reames). Repository: rG LLVM Github

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

aaron.ballman added a comment. In D65591#1791876 , @rsmith wrote: > Summary of an off-line discussion with Ilya: I think that summary sounds very sensible. Thank you both for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D71680: Customize simplified dumping and matching of LambdaExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some nits. Comment at: clang/include/clang/AST/ASTNodeTraverser.h:134 + + if (isa(S) && Traversal ==

[clang] 03512b2 - [NFC][Driver] Add dummy compiler-rt sanitizer dylibs for Darwin.

Author: Dan Liew Date: 2019-12-20T11:32:21-08:00 New Revision: 03512b267d9abd054d56c6d5fa118e78184cf015 URL: https://github.com/llvm/llvm-project/commit/03512b267d9abd054d56c6d5fa118e78184cf015 DIFF: https://github.com/llvm/llvm-project/commit/03512b267d9abd054d56c6d5fa118e78184cf015.diff

[PATCH] D71746: Fix the "TypeError: a bytes-like object is required, not 'str'" in exploded-graph-rewriter.py on Python 3.5+

NoQ accepted this revision. NoQ edited reviewers, added: NoQ; removed: dergachev.a. NoQ added a comment. Yay, thanks! It does seem to work on python2 after the fix. Do you have commit access or should i commit it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with the nits fixed, thank you! Comment at: clang/include/clang/Basic/Attr.td:3475 + +def AcquireHandle : DeclOrTypeAttr { + let Spellings =

[PATCH] D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a commenting request. Comment at: clang-tools-extra/clang-tidy/utils/LexerUtils.h:95-97 +/// Assuming that ``Range`` spans a CVR-qualified type,

[PATCH] D71612: [analyzer] Add PlacementNewChecker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:32 + const MemRegion *BaseRegion = MRegion->getBaseRegion(); + assert(BaseRegion == Offset.getRegion()); + martong wrote: > This assertion fails on real code quite

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3952 + CGM.getOpenMPRuntime().isNontemporalDecl(Field)) || + (!E->isArrow() && BaseLV.isNontemporal())) +LV.setNontemporal(/*Value=*/true); ABataev wrote: >

[PATCH] D71694: [objc_direct] Tigthen checks for direct methods

This revision was automatically updated to reflect the committed changes. Closed by commit rG42f9d0c0bee3: [objc_direct] Tigthen checks for direct methods (authored by MadCoder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71694/new/

[PATCH] D71778: [RISCV] Add Clang Builtins for Accessing CSRs

lenary created this revision. lenary added reviewers: asb, luismarques. Herald added subscribers: llvm-commits, cfe-commits, apazos, sameer.abuasal, pzheng, s.egerton, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jrtc27,

[clang] 42f9d0c - [objc_direct] Tigthen checks for direct methods

Author: Pierre Habouzit Date: 2019-12-20T10:57:36-08:00 New Revision: 42f9d0c0bee32a1a48a45c039988d27115f30da9 URL: https://github.com/llvm/llvm-project/commit/42f9d0c0bee32a1a48a45c039988d27115f30da9 DIFF:

[PATCH] D69876: Allow output constraints on "asm goto"

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/asm-goto.c:91 + return 1; +} Thanks for adding this test. I think it doesn't test that `addr` is *clobbered* though? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3475 + +def AcquireHandle : DeclOrTypeAttr { + let Spellings = [Clang<"acquire_handle">]; I have no idea whether this is a problem or not (and I'm not certain if you know

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61055 tests passed, 0 failed and 728 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

jdoerfert added a comment. I haven't forgotten about this! With the other two changes to the declare variant going to happen now,as well, I figured we should look at this again from a high-level. My plan now is: 1. Move all of the declare variant context stuff out of clang into the

[PATCH] D71221: [HIP] Add option --gpu-max-threads-per-block=n

tra added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:8067 +unsigned MaxThreadsPerBlock = +IsHIPKernel ? M.getLangOpts().GPUMaxThreadsPerBlock : 256; +std::string AttrVal = std::string("1,") + llvm::utostr(MaxThreadsPerBlock);

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson updated this revision to Diff 234921. arichardson added a comment. - Add documentation for the new alignment builtins Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71499/new/ https://reviews.llvm.org/D71499 Files:

[PATCH] D36051: [clang-tidy] List the checkers with autofix

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:291 + +.. csv-table:: Alias.. + :header: "Name", "Redirect", "Offers fixes", "Severity" Aliases? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61057 tests passed, 0 failed and 728 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru updated this revision to Diff 234918. sylvestre.ledru added a comment. Fix a rst warning + update the clang link "Clang Static Analyzer" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36051/new/ https://reviews.llvm.org/D36051

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

aganea created this revision. aganea added reviewers: mehdi_amini, rnk, tejohnson, russell.gallop, dexonsmith. Herald added subscribers: llvm-commits, cfe-commits, usaxena95, dang, jfb, kadircet, arphaman, steven_wu, jkorous, MaskRay, javed.absar, hiraditya, kristof.beyls, arichardson, emaste.

[PATCH] D71698: [AArch64][SVE] Add intrinsic for non-faulting loads

kmclaughlin added inline comments. Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:5333 + // We need a layer of indirection because early machine code passes balk at + // physical register (i.e. FFR) uses that have no previous definition. + let hasSideEffects = 1,

[PATCH] D71769: [clang-format] C# formatting a class with inheritance followed by an attribute specifier assume its a braces initializer

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f209ccfbe5e: [clang-format] C# formatting a class with inheritance followed by an attribute… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru added a comment. In D36051#1792909 , @whisperity wrote: > I am a little bit conflicted about the //Severity// column. While I know our > people put a great deal of effort into keeping this classification sane, what > was put into

[PATCH] D70073: [ConstExprPreter] Implemented function calls and if statements

nand added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70073/new/ https://reviews.llvm.org/D70073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 2f209cc - [clang-format] C# formatting a class with inheritance followed by an attribute specifier assume its a braces initializer

Author: mydeveloperday Date: 2019-12-20T17:07:00Z New Revision: 2f209ccfbe5e6b33088763b1e022ba876fb0f35c URL: https://github.com/llvm/llvm-project/commit/2f209ccfbe5e6b33088763b1e022ba876fb0f35c DIFF: https://github.com/llvm/llvm-project/commit/2f209ccfbe5e6b33088763b1e022ba876fb0f35c.diff

[PATCH] D71513: [compiler-rt] [test] Disable MPROTECT on two builtin tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG190b9110c23c: [compiler-rt] [test] Disable MPROTECT on two builtin tests (authored by mgorny). Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Repository: rG LLVM Github

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru updated this revision to Diff 234911. sylvestre.ledru added a comment. Add a comment about codechecker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36051/new/ https://reviews.llvm.org/D36051 Files:

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

sepavloff added a comment. In D69272#1792877 , @kpn wrote: > My understanding of this patch is that it only allows the #pragma at the top > of each function. It doesn't allow it in blocks inside the function. So if a > function has a block inside it

[PATCH] D71612: [analyzer] Add PlacementNewChecker

xazax.hun added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:472 +def PlacementNewChecker : Checker<"PlacementNew">, + HelpText<"Check if default placement new is provided with pointers to " + "sufficient storage capacity">,

[PATCH] D36051: [clang-tidy] List the checkers with autofix

whisperity added a comment. I am a little bit conflicted about the //Severity// column. While I know our people put a great deal of effort into keeping this classification sane, what was put into CodeChecker is, at the end of the day, a pretty arbitrary classification. I think RSTs support

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61052 tests passed, 0 failed and 728 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[clang] ff92c56 - [OPENMP]Remove unused OPENMP_MATCH_KIND, NFC.

Author: Alexey Bataev Date: 2019-12-20T11:17:55-05:00 New Revision: ff92c56ef97c62e6350531fd45ec1ad36ed25a3c URL: https://github.com/llvm/llvm-project/commit/ff92c56ef97c62e6350531fd45ec1ad36ed25a3c DIFF: https://github.com/llvm/llvm-project/commit/ff92c56ef97c62e6350531fd45ec1ad36ed25a3c.diff

  1   2   >