[PATCH] D72463: [Driver][X86] Add -malign-branch* and -mbranches-within-32B-boundaries

annita.zhang added a comment. In D72463#1826821 , @MaskRay wrote: > In D72463#1826499 , @annita.zhang > wrote: > > > @MaskRay Did you merge it to LLVM 10 branch? > > > It is included in the release branch. > > `git

[PATCH] D72972: [WebAssembly] Add experimental multivalue calling ABI

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61974 tests passed, 2 failed and 783 were skipped. failed: LLVM.Bindings/Go/go.test failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_sharedtimedmutex_requirements/thread_sharedtimedmutex

[PATCH] D72972: [WebAssembly] Add experimental multivalue calling ABI

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Herald added a project: clang. For now, this ABI simply expands all possible aggregate arguments and returns all possible aggregates directly. This AB

[PATCH] D72940: Add a support for clang tidy to import another configurations files from .clang-tidy

JDevlieghere added a comment. Please upload the diff with full context . This would also need a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72940/new/ https://reviews.llvm.org/D72940 _

Buildbot numbers for the week of 01/05/2020 - 01/11/2020

Hello everyone, Below are some buildbot numbers for the last week of 01/05/2020 - 01/11/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

[PATCH] D72970: clang: Only define OBJC_NEW_PROPERTIES when -x objective-c

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72970/new/ https://reviews.llvm.org/D72970 ___ cfe-commits mailing list cfe-commi

[PATCH] D72970: clang: Only define OBJC_NEW_PROPERTIES when -x objective-c

dexonsmith created this revision. dexonsmith added reviewers: rjmccall, arphaman. Herald added a subscriber: ributzka. Since 2009 (in r63846) we've been `#define`-ing OBJC_NEW_PROPERTIES all the time on Darwin, but this macro only makes sense for `-x objective-c` and `-x objective-c++`. Restrict

[PATCH] D72903: [HIP] use GetProgramPath for executable discovery

DieGoldeneEnte added a comment. If @yaxunl has no objections, could someone merge this as I don't have commit access? Also do we want to also apply this to older versions, since the change is trivial? I confirmed the same problem is in clang 8, 9 and 10 and am certain it is in clang 7, although

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

wristow updated this revision to Diff 238933. wristow added a comment. Updated patch to correct a comment and fix a typo. Regarding the point from @spatel : > This follows the reasoning from the earlier discussion, but after re-reading > the gcc comment in particular, I'm wondering whether this

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

DieGoldeneEnte abandoned this revision. DieGoldeneEnte added a comment. Adding the paths for llvm/lld is not needed, because GetProgramPath is actually also searching in $PATH. This means D72903 already is enough to fix my problem. CHANGES SINCE LAST ACTION

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm closed this revision. arsenm added a comment. a4451d88ee456304c26d552749aea6a7f5154bde CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69878/new/ https://reviews.llvm.org/D69878 __

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

rnk added a comment. `ArmMveAliasValid` is the second slowest function to compile in all of clang, according to ClangBuildAnalyzer: https://reviews.llvm.org/P8185 We shouldn't spend 28 CPU seconds per rebuild on a switch. Please do something to speed it up. Generally, it is best to emit tables

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

xazax.hun added subscribers: phosek, NoQ, haowei, xazax.hun. xazax.hun added a comment. Hi! This patch breaks scan-build-py which parses the output of "-###" to get -cc1 command. There might be other tools with the same problems. Could we either remove `(in-process)` from `CC1Command::Print` or

[PATCH] D65042: [Concept] Placeholder constraints and abbreviated templates

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. I've left some comments suggesting how to rebase this on rGa42fd84cff265b7e9faa3fe42885ee171393e4db ; otherwise, some mino

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61925 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

tstellar updated this revision to Diff 238914. tstellar marked 2 inline comments as done. tstellar added a comment. - Add quotes around ${CMAKE_CURRENT_SOURCE_DIR} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72875/new/ https://reviews.llvm.org/D7

[clang] a42fd84 - Remove redundant CXXScopeSpec from TemplateIdAnnotation.

Author: Richard Smith Date: 2020-01-17T15:47:21-08:00 New Revision: a42fd84cff265b7e9faa3fe42885ee171393e4db URL: https://github.com/llvm/llvm-project/commit/a42fd84cff265b7e9faa3fe42885ee171393e4db DIFF: https://github.com/llvm/llvm-project/commit/a42fd84cff265b7e9faa3fe42885ee171393e4db.diff

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61674 tests passed, 181 failed and 781 were skipped. failed: Clangd.Clangd/background-index.test failed: Clangd.Clangd/code-action-request.test failed: Clangd.Clangd/compile-commands-path-in-initialize.test

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

rjmccall added a comment. Remember that the design is that constrained intrinsics must be used whenever *any* code in the function is constrained. It is not unreasonable that part of the function might be constrained and the rest subject to fast-math; it'd be a shame if the intrinsics couldn't

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

andrew.w.kaylor added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3436 +} + } + cameron.mcinally wrote: > andrew.w.kaylor wrote: > > cameron.mcinally wrote: > > > cameron.mcinally wrote: > > > > cameron.mcinally wrote: > > > > > I don't t

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev updated this revision to Diff 238902. kbobyrev added a comment. I started using TokenBuffer, but I ran into the following issue: when I'm creating `TokenBuffer` and `TokenCollector`, they do not contain any tokens. `Preprocessor` does not seem to have a non-null Lexer instance, `TokenWatc

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. It wouldn't be a bad idea to track that correspondence in the AST just on the general principle that it's useful information (for diagnostics, tooling, etc.) that's otherwise hard to recre

[PATCH] D69740: [profile] Support counter relocation at runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3db13af7e5c: [profile] Support counter relocation at runtime (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D69740?vs=238689&id=238901#toc Repository: rG LLVM Github Monorep

[clang] d3db13a - [profile] Support counter relocation at runtime

Author: Petr Hosek Date: 2020-01-17T15:02:23-08:00 New Revision: d3db13af7e5c01632fbf28149a2d4f9c4841aeba URL: https://github.com/llvm/llvm-project/commit/d3db13af7e5c01632fbf28149a2d4f9c4841aeba DIFF: https://github.com/llvm/llvm-project/commit/d3db13af7e5c01632fbf28149a2d4f9c4841aeba.diff LO

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

delcypher added inline comments. Comment at: llvm/cmake/modules/AddSphinxTarget.cmake:33 + if (NOT ARG_SOURCE_DIR) +set(ARG_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) + endif() @tstellar I'm not 100% sure about this but I think you probably want `${CMAKE_CURR

[PATCH] D69878: Consoldiate internal denormal flushing controls

cameron.mcinally accepted this revision. cameron.mcinally added a comment. LGTM too. Would be good if an expert reviewed the target-specific changes, but they seem safe enough either way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69878/new/ https://reviews.llvm.org/D69878 __

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61925 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

cameron.mcinally added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3436 +} + } + andrew.w.kaylor wrote: > cameron.mcinally wrote: > > cameron.mcinally wrote: > > > cameron.mcinally wrote: > > > > I don't think it's safe to fuse a FMUL and

[PATCH] D72850: [CMake] Use LinuxRemoteTI instead of LinuxLocalTI in CrossWinToARMLinux cmake cache

This revision was automatically updated to reflect the committed changes. Closed by commit rG383ff4eac1db: [CMake] Use LinuxRemoteTI instead of LinuxLocalTI in CrossWinToARMLinux cmake… (authored by broadwaylamb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] 383ff4e - [CMake] Use LinuxRemoteTI instead of LinuxLocalTI in CrossWinToARMLinux cmake cache

Author: Sergej Jaskiewicz Date: 2020-01-18T01:29:09+03:00 New Revision: 383ff4eac1db8313ec522ba3ac0903aaeda7ff63 URL: https://github.com/llvm/llvm-project/commit/383ff4eac1db8313ec522ba3ac0903aaeda7ff63 DIFF: https://github.com/llvm/llvm-project/commit/383ff4eac1db8313ec522ba3ac0903aaeda7ff63.d

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

tstellar updated this revision to Diff 238893. tstellar added a comment. - Fix indentation. - Remove placeholder AttributeReference.rst. The install target was replacing the generated AttributeReference.rst with this which caused the html page to be empty. - Tested with stand-alone clang builds

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:242 +--+--+--+---+ -| misc

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

rsmith updated this revision to Diff 238881. rsmith added a comment. - Explicitly put implicit virtual functions in the right order, rather Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72897/new/ https://reviews.llvm.org/D72897 Files: clang/lib

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

rsmith added a comment. In D72897#1825791 , @rjmccall wrote: > I know that Sema used to have a lot of issues with implicitly declaring > special members, but I also know that that was bound up with how we tracked > special state for the class, and that c

[PATCH] D72890: [xray] Allow instrumenting only function entry and/or only function exit

This revision was automatically updated to reflect the committed changes. Closed by commit rG97ba483026cd: [xray] Allow instrumenting only function entry and/or only function exit (authored by ianlevesque, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D72873: [clang][xray] Add -fxray-ignore-loops option

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d62be244108: [clang][xray] Add -fxray-ignore-loops option (authored by ianlevesque, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D728

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 marked 2 inline comments as done. kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:242 +--+--+--+

[clang] 1d62be2 - [clang][xray] Add -fxray-ignore-loops option

Author: Ian Levesque Date: 2020-01-17T13:32:24-08:00 New Revision: 1d62be244108547558c6d42ddcf2e4a7f3c6dd03 URL: https://github.com/llvm/llvm-project/commit/1d62be244108547558c6d42ddcf2e4a7f3c6dd03 DIFF: https://github.com/llvm/llvm-project/commit/1d62be244108547558c6d42ddcf2e4a7f3c6dd03.diff

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 marked an inline comment as done. kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:194 +--+--+--+

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:240 ++--+--+--+---+ +| misc

[PATCH] D71566: New checks for fortified sprintf

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61975 tests passed, 1 failed and 783 were skipped. failed: LLVM.Bindings/Go/go.test {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your ch

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille updated this revision to Diff 238868. serge-sans-paille added a comment. Update size computation + test case involving null byte inside the format string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71566/new/ https://reviews.l

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 marked 2 inline comments as done. kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:240 ++--+--+--+-

[PATCH] D72890: [xray] Allow instrumenting only function entry and/or only function exit

ianlevesque updated this revision to Diff 238866. ianlevesque added a comment. Add x86 tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72890/new/ https://reviews.llvm.org/D72890 Files: clang/include/clang/Basic/XRayInstr.h clang/include/cl

[PATCH] D71732: Move the sysroot attribute from DIModule to DICompileUnit

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b30370e5bcf: Move the sysroot attribute from DIModule to DICompileUnit (authored by aprantl). Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Changed prior to com

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

fghanim added a comment. No, I don't have commit privileges. I'd appreciate if you'd commit this for me. Thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72304/new/ https://reviews.llvm.org/D72304

[PATCH] D72910: Fix a bug with clang with object destructor, while skipping object initialization - make clang crash

ykfre added a comment. In D72910#1826293 , @dim wrote: > Aha, which version of clang-cl are you using? With the released version of > clang-cl 9.0.1, I get a warning instead of an error: > > cleanup.cpp(15,5): warning: jump from this goto statement to

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

fghanim updated this revision to Diff 238858. fghanim added a comment. Addressing reviewer's comments regarding styling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72304/new/ https://reviews.llvm.org/D72304 Files: clang/lib/CodeGen/CGStmtOpen

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

tra added a comment. Tank you for splitting the patch. For CMake parts @beanz would be the person to make the call. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72806/new/ https://reviews.llvm.org/D72806 ___ cfe-commits mailing list cfe-c

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

denik added a comment. We are hitting the warning in template code with bool and loop like this: "for (const auto& element : value)" where element is bool from template. But not always. When it is bool the warning triggers: error: loop variable 'element' is always a copy because the range of ty

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. This appears to only happen with -fintegrated-cc1, with fno-integrated-cc1 it does not repro. Still looking into this. In D71301#1826928 , @thegameg wrote: > Hi @plotfi, this seems to cause failures with ASAN and UBSAN on green dr

[PATCH] D69878: Consoldiate internal denormal flushing controls

andrew.w.kaylor accepted this revision. andrew.w.kaylor added a comment. This revision is now accepted and ready to land. I don't know if there were other reviewers who haven't commented on how you addressed their concerns, but this looks good to me. Thanks for taking the time to improve our han

[clang] c33ba8c - [OPENMP]Improve debug locations in OpenMP regions.

Author: Alexey Bataev Date: 2020-01-17T14:24:32-05:00 New Revision: c33ba8c15858c0316378caf2667c8feee32dad36 URL: https://github.com/llvm/llvm-project/commit/c33ba8c15858c0316378caf2667c8feee32dad36 DIFF: https://github.com/llvm/llvm-project/commit/c33ba8c15858c0316378caf2667c8feee32dad36.diff

[clang] 90bdb03 - Update clang test.

Author: Alina Sbirlea Date: 2020-01-17T11:08:59-08:00 New Revision: 90bdb037276be43df260af004f620b21645d2617 URL: https://github.com/llvm/llvm-project/commit/90bdb037276be43df260af004f620b21645d2617 DIFF: https://github.com/llvm/llvm-project/commit/90bdb037276be43df260af004f620b21645d2617.diff

[PATCH] D72940: Add a support for clang tidy to import another configurations files from .clang-tidy

ykfre created this revision. ykfre added a reviewer: clang-tools-extra. ykfre added a project: clang-tools-extra. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. add ConfigurationsFilesToImport option - to make it possible to import another configurations files fr

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

evgeny777 added inline comments. Comment at: llvm/test/Transforms/WholeProgramDevirt/import-indir.ll:2 ; Test that we correctly import an indir resolution for type identifier "typeid1". -; RUN: opt -S -wholeprogramdevirt -wholeprogramdevirt-summary-action=import -wholeprogramd

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

jdoerfert added inline comments. Comment at: clang/docs/OpenMPSupport.rst:194 +--+--+--+---+ -| de

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

MaskRay added a comment. Herald added a subscriber: dexonsmith. I think we should not rely too much on the driver emitting object files. There can be many subtle differences (D68897 ). When the -emit-obj output is feed to llvm-nm, the clang cc1 command line sho

[PATCH] D70183: Detect source location overflow due includes

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM, but since we both work at Arm, let's wait a week for other folks to chime in if they have any objections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. Thanks for pinging on this @thegameg. I had been looking at this a day or two ago but got side-tracked. Will take another look. In D71301#1826928 , @thegameg wrote: > Hi @plotfi, this seems to cause failures with ASAN and UBSAN on

[PATCH] D72484: [clang-tidy] Fix check for Abseil internal namespace access

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Comment at: clang-tools-extra/clang-tidy/abseil/NoInternalDependenciesCheck.cpp:43-44 + + if (!LocAtFault.isValid()) +return; + EricWF wrote: > rogeeff wrote: > > aaron.ballman wrot

[PATCH] D72484: [clang-tidy] Fix check for Abseil internal namespace access

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. The weird template test case might is derived from an old failure that I believe was addressed in Clang, but regression tests are fine by me. The macro expansion fix is correct and corre

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

thegameg added a comment. Hi @plotfi, this seems to cause failures with ASAN and UBSAN on green dragon: http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6886/consoleFull The following tests are failing: Clang :: InterfaceStubs/driver-test.c Clang :: InterfaceStubs/driver-test2.c

[PATCH] D68720: Support -fstack-clash-protection for x86

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:31080 + + BuildMI(blockMBB, DL, TII->get(IsLP64 ? X86::SUB64ri32 : X86::SUB32ri), + physSPReg) serge-sans-paille wrote: > craig.topper wrote: > > This uses physSPReg

[clang] d003801 - [InterfaceStubs][test] Add -triple to clang/test/InterfaceStubs/externstatic.c to make it robust

Author: Fangrui Song Date: 2020-01-17T10:32:20-08:00 New Revision: d0038012fd7f91dc81e5a13ffb24f3b43b499fba URL: https://github.com/llvm/llvm-project/commit/d0038012fd7f91dc81e5a13ffb24f3b43b499fba DIFF: https://github.com/llvm/llvm-project/commit/d0038012fd7f91dc81e5a13ffb24f3b43b499fba.diff

[PATCH] D72873: [clang][xray] Add -fxray-ignore-loops option

hiraditya accepted this revision. hiraditya added a comment. This revision is now accepted and ready to land. The test case is in another patch so LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72873/new/ https://reviews.llvm.org/D72873 ___

[PATCH] D72873: [clang][xray] Add -fxray-ignore-loops option

ianlevesque marked an inline comment as done. ianlevesque added inline comments. Comment at: clang/test/CodeGen/xray-ignore-loops.cpp:5 + return 1; +} + hiraditya wrote: > I think we need one more test case of a function having a loop. I'm not opposed but the lo

[PATCH] D72873: [clang][xray] Add -fxray-ignore-loops option

hiraditya added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:821 llvm::itostr(CGM.getCodeGenOpts().XRayInstructionThreshold)); + if (CGM.getCodeGenOpts().XRayIgnoreLoops) { +Fn->addFnAttr("xray-ignore-loops"); we ca

[PATCH] D72786: [clang] Set function attributes on SEH filter functions correctly.

This revision was automatically updated to reflect the committed changes. Closed by commit rGecfd6d3e8418: [clang] Set function attributes on SEH filter functions correctly. (authored by sanwou01). Changed prior to commit: https://reviews.llvm.org/D72786?vs=238431&id=238817#toc Repository: r

[PATCH] D72848: Remove some SVN-specific code.

Eugene.Zelenko added inline comments. Comment at: clang/lib/Basic/Version.cpp:33 #else - StringRef URL(""); + return ""; #endif hans wrote: > Eugene.Zelenko wrote: > > return {} should be better. > Why? I think "" is clearer for a string. It's default non-tri

[clang] ecfd6d3 - [clang] Set function attributes on SEH filter functions correctly.

Author: Sanne Wouda Date: 2020-01-17T18:09:42Z New Revision: ecfd6d3e84185127fb836d6fe62564456be3a9cd URL: https://github.com/llvm/llvm-project/commit/ecfd6d3e84185127fb836d6fe62564456be3a9cd DIFF: https://github.com/llvm/llvm-project/commit/ecfd6d3e84185127fb836d6fe62564456be3a9cd.diff LOG: [

[clang] a9f0025 - Reland "[llvm-nm] Don't report "no symbols" error for files that contain symbols"

Author: Fangrui Song Date: 2020-01-17T10:08:42-08:00 New Revision: a9f0025acd2235dccec51cf42d1e604675639343 URL: https://github.com/llvm/llvm-project/commit/a9f0025acd2235dccec51cf42d1e604675639343 DIFF: https://github.com/llvm/llvm-project/commit/a9f0025acd2235dccec51cf42d1e604675639343.diff

[PATCH] D72867: [clangd] Support renaming designated initializers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61929 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[clang] 932b5d6 - [test] Fix tests after D52810

Author: Fangrui Song Date: 2020-01-17T10:02:56-08:00 New Revision: 932b5d6fcad183a5b1584dffc77c340bf0796efa URL: https://github.com/llvm/llvm-project/commit/932b5d6fcad183a5b1584dffc77c340bf0796efa DIFF: https://github.com/llvm/llvm-project/commit/932b5d6fcad183a5b1584dffc77c340bf0796efa.diff

[clang] 03689fe - [perf-training] Ignore ' (in-process)' prefix from -###

Author: Francis Visoiu Mistrih Date: 2020-01-17T09:38:35-08:00 New Revision: 03689fe97f2377a3b19864de98b5c14b7fbd85ab URL: https://github.com/llvm/llvm-project/commit/03689fe97f2377a3b19864de98b5c14b7fbd85ab DIFF: https://github.com/llvm/llvm-project/commit/03689fe97f2377a3b19864de98b5c14b7fbd8

[clang] 12e4794 - Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot

Author: Adrian Prantl Date: 2020-01-17T09:36:48-08:00 New Revision: 12e479475a896f664fb721f98c2d6805185ac352 URL: https://github.com/llvm/llvm-project/commit/12e479475a896f664fb721f98c2d6805185ac352 DIFF: https://github.com/llvm/llvm-project/commit/12e479475a896f664fb721f98c2d6805185ac352.diff

[PATCH] D72906: [X86] Improve X86 cmpps/cmppd/cmpss/cmpsd intrinsics with strictfp

uweigand added a comment. In D72906#1826122 , @craig.topper wrote: > In D72906#1826061 , @uweigand wrote: > > > > The constrained fcmp intrinsics don't allow the TRUE/FALSE predicates. > > > > Hmm, maybe they shoul

[PATCH] D72463: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries

MaskRay added a comment. In D72463#1826499 , @annita.zhang wrote: > @MaskRay Did you merge it to LLVM 10 branch? It is included in the release branch. `git branch origin/release/10.x --contains 5ca24d09aefaedf8e4148c7fce4b4ab0c4ecc72a # suceeded` R

[PATCH] D72934: [ARM,MVE] Support immediate vbicq,vorrq,vmvnq intrinsics.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, MarkMurrayARM, miyuki, ostannard. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Immediate vmvnq is code-generated as a simple vector constant in IR, and l

[PATCH] D72274: [libTooling] Fix bug in Stencil handling of macro ranges

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9d2bf38e86e: [libTooling] Fix bug in Stencil handling of macro ranges (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72274/new/ https

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

sepavloff added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13129 if (FunctionDecl *F = dyn_cast(CurContext)) { + // If the expression occurs inside an internal global_var_init_function + // then the FunctionDecl is not availble mibint

[clang] b9d2bf3 - [libTooling] Fix bug in Stencil handling of macro ranges

Author: Yitzhak Mandelbaum Date: 2020-01-17T12:11:25-05:00 New Revision: b9d2bf38e86e6dd8a2f188d9a24f546aa67de8af URL: https://github.com/llvm/llvm-project/commit/b9d2bf38e86e6dd8a2f188d9a24f546aa67de8af DIFF: https://github.com/llvm/llvm-project/commit/b9d2bf38e86e6dd8a2f188d9a24f546aa67de8af.

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio created this revision. dnsampaio added reviewers: rsmith, rjmccall. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. This patch resumes the work of D16586 . According to the AAPCS, volatile bit-fields should be accessed

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61855 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

kbobyrev updated this revision to Diff 238791. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72638/new/ https://reviews.llvm.org/D72638 Files: clang-tools-extr

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:882 "10: targets = {ns}\n"}, + // CXX Constructor, destructor and operators. + {R"cpp( hokein wrote: > could we simplify the newly-added test?

[PATCH] D72153: [libTooling] Add function to determine associated text of a declaration.

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Transformer/SourceCode.cpp:128 + // First, lex to the current token (which is the last token of the range that + // we know to be deleted. Then, we process the first token separately from the + // rest based on c

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki added a comment. ping^4 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72274: [libTooling] Fix bug in Stencil handling of macro ranges

ymandel marked an inline comment as done. ymandel added a comment. Thanks for the review! In D72274#1826634 , @gribozavr2 wrote: > In D72274#1826614 , @ymandel wrote: > > > In D72274#1826477

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to make use of the `TokenBuffer`, ran into some difficulties when lexing some files and triggering assertions in the process. Will figure it out and update the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev updated this revision to Diff 238786. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address alsmost all comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72746/new/ https://reviews.llvm.org/D72746 Files: cla

[PATCH] D72274: [libTooling] Fix bug in Stencil handling of macro ranges

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. In D72274#1826614 , @ymandel wrote: > In D72274#1826477 , @gribozavr2 > wrote: > > > The only function

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/Ref.h:36 + // one below. + Implicit = 1 << 3, + All = Declaration | Definition | Reference | Implicit, kadircet wrote: > kadircet wrote: > > instead of doing that, could we rather de-co

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 3 inline comments as done. mibintc added a comment. @sepavloff Thanks a lot for your comments. I added a few replies and I have one question, added inline. Comment at: clang/lib/Parse/ParsePragma.cpp:2522 + IdentifierInfo *II = Tok.getIdentifierInfo(); + Pragm

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

This revision was automatically updated to reflect the committed changes. Closed by commit rG05c7dc664809: [DataFlow] Factor two worklist implementations out (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D72380?vs=238592&id=238785#toc Repository: rG LLVM Github M

[PATCH] D72736: [AIX] Add improved interface for retrieving load module paths

stevewan added a comment. Provided that you have squashed all changes into the latest commit in your branch, `git diff HEAD^ -U1` should emit the context you need. Adjust the number of lines of context accordingly to fit the size of your files. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D72274: [libTooling] Fix bug in Stencil handling of macro ranges

ymandel marked 2 inline comments as done. ymandel added a comment. In D72274#1826477 , @gribozavr2 wrote: > The only functional change that I see in this patch is in > `clang/lib/Tooling/Transformer/Stencil.cpp`. However, I don't understand how > that ch

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

eti-p-doray added a comment. Thank you for checking! I updated the changes to lift the restriction. PTAnL? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72635/new/ https://reviews.llvm.org/D72635 ___ cfe-commits mailing list cfe-commits@lis

[clang] 0406b4f - Renamed traverseDecl to TraverseDecl in a test

Author: Dmitri Gribenko Date: 2020-01-17T17:12:23+01:00 New Revision: 0406b4fab94658381ea58db890b07c1a30ff0ae4 URL: https://github.com/llvm/llvm-project/commit/0406b4fab94658381ea58db890b07c1a30ff0ae4 DIFF: https://github.com/llvm/llvm-project/commit/0406b4fab94658381ea58db890b07c1a30ff0ae4.dif

  1   2   >