[PATCH] D76189: [Fuchsia] Use -ffile-prefix-map

phosek created this revision. phosek added a reviewer: leonardchan. Herald added subscribers: cfe-commits, aprantl, mgorny. Herald added a project: clang. This makes toolchain independent of the path it was built in by rewriting all absolute paths embedded in sources and debug info into relative

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5102 Diag(P.second->getExprLoc(), diag::err_omp_no_dsa_for_variable) << P.first << P.second->getSourceRange(); Diag(DSAStack->getDefaultDSALocation(),

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

jdoerfert updated this revision to Diff 250396. jdoerfert added a comment. Finish changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76184/new/ https://reviews.llvm.org/D76184 Files: clang/include/clang/AST/Attr.h

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

Quuxplusone added a comment. I still think this entire patch is misguided; there's no reason to make the note for `const std::string s; std::move(s)` any longer than the note for `int i; std::move(i)` or `volatile std::string v; std::move(v)`. People should not be using moved-from objects,

[PATCH] D76181: [AVR] Add support for the -mdouble=x flag

MaskRay added a comment. The GCC side commits can be found on https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92055 So it seems that we will have both `-mlong-double-{64,80,128}` (80 is used by x86 fp80) and `-mlong-double={32,64}`... (I actually prefer `=` to `-`) Comment at:

[PATCH] D76186: Fix compatibility for __builtin_stdarg_start

joerg created this revision. The `__builtin_stdarg_start` is the legacy spelling of `__builtin_va_start`. It should behave exactly the same, but for the last 9 years it would behave subtly different for diagnostics. Follow the change from 29ad95b23217 to require custom type checking.

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver added a comment. Herald added a subscriber: danielkiss. There are a lot of different ways we could implement the feature. We may want to only enable it when `-march=native`, or maybe only in the unstable ABI, and maybe we want to support aligned pairs on some architectures. I think

[clang] 19840a3 - Remove an unnecessary explicit 'WarnDiag'; NFC

Author: Aaron Ballman Date: 2020-03-14T17:15:59-04:00 New Revision: 19840a307e6d98017b68b14725c53d1ad89d98f9 URL: https://github.com/llvm/llvm-project/commit/19840a307e6d98017b68b14725c53d1ad89d98f9 DIFF: https://github.com/llvm/llvm-project/commit/19840a307e6d98017b68b14725c53d1ad89d98f9.diff

[clang] dab43c8 - Remove some explicit calls to getName() when printing diagnostics; NFC

Author: Aaron Ballman Date: 2020-03-14T17:01:45-04:00 New Revision: dab43c85920cd80b919265936e319f9583c8b4e8 URL: https://github.com/llvm/llvm-project/commit/dab43c85920cd80b919265936e319f9583c8b4e8 DIFF: https://github.com/llvm/llvm-project/commit/dab43c85920cd80b919265936e319f9583c8b4e8.diff

[clang] eda58ac - Improve the attribute language option interface somewhat; NFCi.

Author: Aaron Ballman Date: 2020-03-14T15:59:14-04:00 New Revision: eda58ac04cfa95298583223ba6779916e4721550 URL: https://github.com/llvm/llvm-project/commit/eda58ac04cfa95298583223ba6779916e4721550 DIFF: https://github.com/llvm/llvm-project/commit/eda58ac04cfa95298583223ba6779916e4721550.diff

[PATCH] D75749: [clang-tidy] extend bugprone-signed-char-misuse check.

ztamas added a comment. In D75749#1912338 , @njames93 wrote: > LGTM > > However, how does this handle cases when the type is written as `char`. They > can be signed/unsigned based on what platform is being targeted. But on a > platform where `char` is

[PATCH] D75749: [clang-tidy] extend bugprone-signed-char-misuse check.

This revision was automatically updated to reflect the committed changes. Closed by commit rG04410c565aa0: [clang-tidy] extend bugprone-signed-char-misuse check. (authored by ztamas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75749/new/

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

jdoerfert abandoned this revision. jdoerfert added a comment. Code is good and usable but no users anymore. If anyone wants to pick this up, feel free! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75210/new/ https://reviews.llvm.org/D75210

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

jdoerfert created this revision. jdoerfert added a reviewer: rnk. Herald added subscribers: guansong, bollu. Herald added a project: clang. See rational here: https://reviews.llvm.org/D76173#1922916 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76184 Files:

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

zinovy.nis updated this revision to Diff 250375. zinovy.nis added a comment. Removed top-level consts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74692/new/ https://reviews.llvm.org/D74692 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp

[PATCH] D76173: [OpenMP][NFC] Minimize memory usage and copying of `OMPTraitInfo`s

jdoerfert added a comment. In D76173#1922916 , @rnk wrote: > lgtm, thanks! > > I also noticed that Parser.h includes OpenMPClause.h just for this class. > OpenMPClause.h is pretty big. It's for this family of related methods: > > /// Parse a property

[clang-tools-extra] 04410c5 - [clang-tidy] extend bugprone-signed-char-misuse check.

Author: Tamás Zolnai Date: 2020-03-14T20:00:00+01:00 New Revision: 04410c565aa08b703ef5d11b454e7fba47163e3c URL: https://github.com/llvm/llvm-project/commit/04410c565aa08b703ef5d11b454e7fba47163e3c DIFF: https://github.com/llvm/llvm-project/commit/04410c565aa08b703ef5d11b454e7fba47163e3c.diff

[PATCH] D76182: [AVR] Support aliases in non-zero address space

aykevl created this revision. aykevl added reviewers: dylanmckay, rsmith, rjmccall. Herald added subscribers: cfe-commits, Jim. Herald added a project: clang. This fixes code like the following on AVR: void foo(void) { } void bar(void) __attribute__((alias("foo"))); Code like this is

[PATCH] D76181: [AVR] Add support for the -mdouble=x flag

aykevl created this revision. aykevl added reviewers: dylanmckay, MaskRay, hfinkel, rnk, rsmith. Herald added subscribers: cfe-commits, Jim. Herald added a project: clang. This flag is used by avr-gcc (starting with v10) to set the width of the double type. The double type is by default

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the `const` nits. You should wait for @Quuxplusone before committing in case there are any additional comments. Comment at:

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

aaron.ballman added a comment. In D75210#1920206 , @jdoerfert wrote: > The reason for this patch is not there anymore. I'm fine with postponing this > patch until there is a user again, thoughts? If we don't have a use for it currently, I think we

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

aaron.ballman added a reviewer: rsmith. aaron.ballman added a subscriber: rsmith. aaron.ballman added a comment. I think this is a reasonable approach (including moving `ParsedAttributesWithRange` into `Sema`), but we should have test coverage for the places where we're now using a range where

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6701-6707 if (!AL.isStmtAttr()) { // Type attributes are handled elsewhere; silently move on. assert(AL.isTypeAttr() && "Non-type attribute not handled"); break; }

[PATCH] D75745: [clang-tidy] Added AllowMissingMoveFunctionsWhenCopyIsDeleted flag to cppcoreguidelines-special-member-functions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75745/new/ https://reviews.llvm.org/D75745

[PATCH] D76173: [OpenMP][NFC] Minimize memory usage and copying of `OMPTraitInfo`s

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! I also noticed that Parser.h includes OpenMPClause.h just for this class. OpenMPClause.h is pretty big. It's for this family of related methods: /// Parse a property kind into \p

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

kkwli0 added a comment. In D75001#1922789 , @jdoerfert wrote: > In D75001#1891284 , @Hahnfeld wrote: > > > In D75001#1887876 , @jdoerfert > > wrote: > > > > > I like this

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

thakis added a comment. This makes clang crash, repro at https://bugs.chromium.org/p/chromium/issues/detail?id=1061533#c4 I'll revert for now. I'm also seeing timeouts and use-after-frees on other bots; maybe they're related (or maybe not). CHANGES SINCE LAST ACTION

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Why reverting this one? Is it a different assertion? The D75036 was the problem with the previous issue reported. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

aprantl added a comment. FYI: See also https://reviews.llvm.org/D76164 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

thakis added a comment. Reduced repro at https://bugs.chromium.org/p/chromium/issues/detail?id=1061533#c7 Scrolling up, it looks like this was reverted yesterday already. I'm confused why this wasn't reverted yesterday; all work I did in bisecting and creducing was a duplicate of what

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 250354. MarcusJohnson91 added a comment. Fixed Format.h comments, and rebased on master. it's perfect on my end now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 Files:

[PATCH] D52773: clang-cl: Add /showFilenames option (PR31957)

asukainori added a comment. I'm sorry to disturb. But I found this option is conflict with -flto. e.g. clang-cl -fuse-ld=lld -flto=thin /showFilenames .\test.cpp will output: clang-cl: warning: argument unused during compilation: '/showFilenames' [-Wunused-command-line-argument]

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

Hahnfeld added a comment. In D75001#1922789 , @jdoerfert wrote: > In D75001#1891284 , @Hahnfeld wrote: > > > In D75001#1887876 , @jdoerfert > > wrote: > > > > > I like this

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:6682 + /// The outermost level of selector sets. + llvm::SmallVector Sets; + jdoerfert wrote: > rnk wrote: > > This is not a good