[clang-tools-extra] 34e39eb - [clangd] Change PreambleOnlyAction with content truncation

2020-05-25 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-05-26T07:37:03+02:00 New Revision: 34e39eb2adc2b3f16c2c2c0607a904ee55705c01 URL: https://github.com/llvm/llvm-project/commit/34e39eb2adc2b3f16c2c2c0607a904ee55705c01 DIFF:

[clang-tools-extra] eeedbd0 - [clangd] Make use of SourceOrder to find first initializer in DefineOutline

2020-05-25 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-05-26T07:32:07+02:00 New Revision: eeedbd033612e105755156023bdeec2fba4eca21 URL: https://github.com/llvm/llvm-project/commit/eeedbd033612e105755156023bdeec2fba4eca21 DIFF:

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

2020-05-25 Thread Konrad Wilhelm Kleine via Phabricator via cfe-commits
kwk updated this revision to Diff 266101. kwk added a comment. - Move comment about FinalizeWithSemicolon into code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80531/new/ https://reviews.llvm.org/D80531 Files:

[clang] d8e0ad9 - [clang][test] fix tests for external assemblers

2020-05-25 Thread Yuanfang Chen via cfe-commits
Author: Yuanfang Chen Date: 2020-05-25T22:14:05-07:00 New Revision: d8e0ad9620c6e626d753a3ae0da6c712e4d400d3 URL: https://github.com/llvm/llvm-project/commit/d8e0ad9620c6e626d753a3ae0da6c712e4d400d3 DIFF: https://github.com/llvm/llvm-project/commit/d8e0ad9620c6e626d753a3ae0da6c712e4d400d3.diff

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

2020-05-25 Thread Konrad Wilhelm Kleine via Phabricator via cfe-commits
kwk added a comment. @Eugene.Zelenko thank you for the review. I've fixed all places that you've mentioned. And have a question about one thing in particular. See inline. Do you by any chance know why `llvm-lit` keeps complaining when I use `[[@LINE-1]]` in my tests as so many other tests do?

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

2020-05-25 Thread Konrad Wilhelm Kleine via Phabricator via cfe-commits
kwk updated this revision to Diff 266100. kwk marked 8 inline comments as done. kwk added a comment. - Make ReplaceDisallowCopyAndAssignMacroCheck only work in C++11 and above - Remove unrelated changes from clang-tools-extra/docs/clang-tidy/checks/list.rst - documentation simplification - Move

[PATCH] D80296: [clangd] Don't traverse the AST within uninteresting files during indexing

2020-05-25 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang/lib/Index/IndexingAction.cpp:142 +ShouldSkipFunctionBody = +[ShouldTraverseDecl(Opts.ShouldTraverseDecl)](const Decl *D) { + return !ShouldTraverseDecl(D);

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

2020-05-25 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM aside from a couple of minor nits. Comment at: clang/lib/Basic/Targets/PPC.cpp:319 .Case("ppc64le", true) +

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

2020-05-25 Thread Amy Kwan via Phabricator via cfe-commits
amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCTargetTransformInfo.cpp:653 // On P7, P8 or P9 we have a cache line size of 128. unsigned Directive = ST->getCPUDirective(); Should this comment be updated to include P10 as well?

[clang] 9d55e4e - Make explicit -fno-semantic-interposition (in -fpic mode) infer dso_local

2020-05-25 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-05-25T20:48:18-07:00 New Revision: 9d55e4ee1367b440bb8402ce3a33d5a8b99aee06 URL: https://github.com/llvm/llvm-project/commit/9d55e4ee1367b440bb8402ce3a33d5a8b99aee06 DIFF: https://github.com/llvm/llvm-project/commit/9d55e4ee1367b440bb8402ce3a33d5a8b99aee06.diff

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

2020-05-25 Thread Nico Weber via Phabricator via cfe-commits
thakis added inline comments. Comment at: clang/test/CodeGenCXX/mangle-ms-auto-templates.cpp:17 + AutoParmTemplate<0> auto_int; + // CHECK: call {{.*}} @"??0?$AutoParmTemplate@$H0A@@@QAE@XZ" + AutoParmTemplate auto_bool; Are you sure this is correct? MSVC

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

2020-05-25 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai updated this revision to Diff 266092. nemanjai added a comment. Remove handling for explicit `_Complex __float128`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80374/new/ https://reviews.llvm.org/D80374 Files:

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

2020-05-25 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai added a comment. The support for `_Complex __float128` in https://reviews.llvm.org/D80533 I will repurpose leave only the addition of the `KF/KC` modes in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80374/new/

[PATCH] D80533: [Clang] Enable _Complex __float

2020-05-25 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai created this revision. nemanjai added reviewers: rjmccall, rsmith, PowerPC. Herald added a subscriber: kbarton. Herald added a project: clang. When I added `__float128` a while ago, I neglected to add support for the complex variant of the type. This patch just adds that. Repository:

[clang] 9a8d7bd - [clang][test] fix tests for external assemblers

2020-05-25 Thread Yuanfang Chen via cfe-commits
Author: Yuanfang Chen Date: 2020-05-25T17:36:28-07:00 New Revision: 9a8d7bd77040a6497233ea10fd866ad9de8bf98c URL: https://github.com/llvm/llvm-project/commit/9a8d7bd77040a6497233ea10fd866ad9de8bf98c DIFF: https://github.com/llvm/llvm-project/commit/9a8d7bd77040a6497233ea10fd866ad9de8bf98c.diff

[PATCH] D80454: [Clang][test] fix tests when using external assembler

2020-05-25 Thread Yuanfang Chen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3a2df3bad07f: [Clang][test] fix tests when using external assembler. (authored by ychen). Changed prior to commit: https://reviews.llvm.org/D80454?vs=265792=266088#toc Repository: rG LLVM Github

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-05-25 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L updated this revision to Diff 266087. Xiangling_L added a comment. Adjust `mangleDynamicDestructor`; Add assertion and FIXME for getUniqueModuleId Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/

[clang] 3a2df3b - [Clang][test] fix tests when using external assembler.

2020-05-25 Thread Yuanfang Chen via cfe-commits
Author: Yuanfang Chen Date: 2020-05-25T16:47:50-07:00 New Revision: 3a2df3bad07f7e5fc22538ad782e08ee55f29e41 URL: https://github.com/llvm/llvm-project/commit/3a2df3bad07f7e5fc22538ad782e08ee55f29e41 DIFF: https://github.com/llvm/llvm-project/commit/3a2df3bad07f7e5fc22538ad782e08ee55f29e41.diff

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

2020-05-25 Thread Benson Chu via Phabricator via cfe-commits
pestctrl updated this revision to Diff 266086. pestctrl added a comment. Rebase on master? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

2020-05-25 Thread Ties Stuij via Phabricator via cfe-commits
stuij updated this revision to Diff 266085. stuij added a comment. add bfloat header test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/ https://reviews.llvm.org/D79708 Files: clang/include/clang/Basic/arm_bf16.td

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

2020-05-25 Thread Matthias Gehre via Phabricator via cfe-commits
mgehre updated this revision to Diff 266083. mgehre marked an inline comment as done. mgehre added a comment. Fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77572/new/ https://reviews.llvm.org/D77572 Files:

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

2020-05-25 Thread Matthias Gehre via Phabricator via cfe-commits
mgehre marked 5 inline comments as done. mgehre added a comment. Aaron, thank you very much for taking the time to review this PR. Comment at: clang-tools-extra/clang-tidy/readability/UseAnyOfAllOfCheck.cpp:61 + hasBody(allOf(hasDescendant(returns(true)), +

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

2020-05-25 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu updated this revision to Diff 266082. zequanwu retitled this revision from "[MS ABI] Add mangled type for template integer argument" to "[MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral ". zequanwu edited the summary of this revision. zequanwu added

[PATCH] D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.

2020-05-25 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added a comment. LGTM with minor comment. Comment at: clang/test/Driver/aix-ld.c:8 -// RUN: --sysroot %S/Inputs/aix_ppc_tree \ -// RUN: | FileCheck --check-prefix=CHECK-LD32 %s //

[PATCH] D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.

2020-05-25 Thread Steven Wan via Phabricator via cfe-commits
stevewan updated this revision to Diff 266081. stevewan added a comment. Pass 'clang-format' checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80532/new/ https://reviews.llvm.org/D80532 Files: clang/test/Driver/aix-ld.c Index:

[PATCH] D79121: Add nomerge statement attribute to clang

2020-05-25 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu closed this revision. zequanwu added a comment. landed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79121/new/ https://reviews.llvm.org/D79121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80404: [OPENMP50]Initial support for use_device_addr clause.

2020-05-25 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 266076. ABataev added a comment. Rebase + cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80404/new/ https://reviews.llvm.org/D80404 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

2020-05-25 Thread Victor Huang via Phabricator via cfe-commits
NeHuang marked an inline comment as done. NeHuang added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:339 if (!(ArchDefs & ArchDefinePwr9) && (ArchDefs & ArchDefinePpcgr) && llvm::find(FeaturesVec, "+float128") != FeaturesVec.end()) {

[PATCH] D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.

2020-05-25 Thread Steven Wan via Phabricator via cfe-commits
stevewan created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. stevewan added reviewers: ZarkoCA, hubert.reinterpretcast, daltenty. stevewan edited the summary of this revision. Based on comments received in D80415

[PATCH] D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.

2020-05-25 Thread Steven Wan via Phabricator via cfe-commits
stevewan updated this revision to Diff 266070. stevewan added a comment. Fix misalignment caused by tab. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80532/new/ https://reviews.llvm.org/D80532 Files: clang/test/Driver/aix-ld.c Index:

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

2020-05-25 Thread Barry Revzin via Phabricator via cfe-commits
BRevzin added inline comments. Comment at: llvm/include/llvm/ADT/DirectedGraph.h:97 + } + friend bool operator!=(const NodeType , const NodeType ) { !(M == N); } jfb wrote: > davidstone wrote: > > Missing `return` >  > > Did this not trigger a diagnostic

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

2020-05-25 Thread Lei Huang via Phabricator via cfe-commits
lei added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:339 if (!(ArchDefs & ArchDefinePwr9) && (ArchDefs & ArchDefinePpcgr) && llvm::find(FeaturesVec, "+float128") != FeaturesVec.end()) { NeHuang wrote: > I think we also need to check

[PATCH] D79961: [PGO] Fix computation of fuction Hash

2020-05-25 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 266072. serge-sans-paille added a comment. Bump the version number to be compatible with existing profdata, in a similar fashion to v1/v2 transition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

2020-05-25 Thread Lei Huang via Phabricator via cfe-commits
lei updated this revision to Diff 266073. lei marked 7 inline comments as done. lei added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/ https://reviews.llvm.org/D80020 Files:

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

2020-05-25 Thread Barry Revzin via Phabricator via cfe-commits
BRevzin updated this revision to Diff 266071. BRevzin marked 2 inline comments as done. BRevzin added a comment. - Explaining the cryptic parentheses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78938/new/ https://reviews.llvm.org/D78938 Files:

[PATCH] D79961: [PGO] Fix computation of fuction Hash

2020-05-25 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. @hans/ @MaskRay I'm starting to wonder if I should bump the version number of the hash function, so that clang could still read profile data generated before that patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/

[PATCH] D80296: [clangd] Don't traverse the AST within uninteresting files during indexing

2020-05-25 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz marked an inline comment as done. adamcz added a comment. I have no objections to landing this as-is, even if it represents a regression for some evil codebases. A possible solution is to iterate through all the includes in a given file (SourceManager knows that already) and if any of

[PATCH] D80499: Remove obsolete ignore*() matcher uses

2020-05-25 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This is *great*, thank you for working on the cleanup! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80499/new/

[PATCH] D79961: [PGO] Fix computation of fuction Hash

2020-05-25 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

2020-05-25 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/ReplaceDisallowCopyAndAssignMacroCheck.h:46 + bool isLanguageVersionSupported(const LangOptions ) const override { +return LangOpts.CPlusPlus; + } I think check

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

2020-05-25 Thread Mariya Podchishchaeva via Phabricator via cfe-commits
Fznamznon updated this revision to Diff 266066. Fznamznon added a comment. Herald added a subscriber: sstefan1. Re-implemented diagnostic itself, now only usages of declarations with unsupported types are diagnosed. Generalized approach between OpenMP and SYCL. Repository: rG LLVM Github

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

2020-05-25 Thread Konrad Wilhelm Kleine via Phabricator via cfe-commits
kwk created this revision. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. This check finds macro expansions of `DISALLOW_COPY_AND_ASSIGN(Type)` and replaces them with a deleted copy constructor and a deleted assignment operator. Before the `delete`

[PATCH] D80528: [clang-format][WIP] Run more stability FormatTests

2020-05-25 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I think this is a noble effort, assuming all the tests pass as far as I'm concerned this LGTM. How about committing all the ones that pass, then work on the others that don't

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

2020-05-25 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79322/new/ https://reviews.llvm.org/D79322

[PATCH] D79961: [PGO] Fix computation of fuction Hash

2020-05-25 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 266064. serge-sans-paille added a comment. Update profile data hash entries due to hash function update, unless the version used is V1, in which case we keep the buggy behavior for backward compatibility. CHANGES SINCE LAST ACTION

[PATCH] D79961: [PGO] Fix computation of fuction Hash

2020-05-25 Thread serge via Phabricator via cfe-commits
serge-sans-paille reopened this revision. serge-sans-paille added a subscriber: bkramer. serge-sans-paille added a comment. This revision is now accepted and ready to land. @bkramer rightfully reverted this, faster than I could patch it :-) Here is the patch though, with the updated test case.

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-05-25 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 266060. bernhardmgruber added a comment. moved C++20 tests to a new file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80514/new/ https://reviews.llvm.org/D80514 Files:

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

2020-05-25 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. (BTW this looks miles better to me, thanks for persistence!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80198/new/ https://reviews.llvm.org/D80198 ___ cfe-commits mailing

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-05-25 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber marked 2 inline comments as done. bernhardmgruber added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type.cpp:550 + +#if __cplusplus > 201703L /* C++2a and later */ + njames93 wrote: >

[PATCH] D80296: [clangd] Don't traverse the AST within uninteresting files during indexing

2020-05-25 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 266059. sammccall marked an inline comment as done. sammccall added a comment. Tweak names, style, comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80296/new/ https://reviews.llvm.org/D80296 Files:

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

2020-05-25 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/test/symbols-modules.test:1 +# Verify that we do not crash and correctly find the definition of a macro that +# was imported from a module and then #undef-ed in preamble. Generally, we prefer

[PATCH] D80296: [clangd] Don't traverse the AST within uninteresting files during indexing

2020-05-25 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 5 inline comments as done. sammccall added a comment. In D80296#2053189 , @adamcz wrote: > Correct me if I'm wrong, but this might lead to a file never being updated in > the index, even after edit, right? > Let's say you have file

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

2020-05-25 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:123 +// Spells directive in \p DirectiveRange while prepending it with \p Prefix. +// Returned string can be used with a #line directive on line \p DirectiveLine > Spells

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

2020-05-25 Thread Marco Elver via Phabricator via cfe-commits
melver updated this revision to Diff 266057. melver added a comment. Add missing -target to sanitize-coverage-bounds test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79628/new/ https://reviews.llvm.org/D79628 Files:

[clang] 2b8d6fa - Revert "[PGO] Fix computation of function Hash"

2020-05-25 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2020-05-25T20:14:28+02:00 New Revision: 2b8d6fa0acacba4dee31ed618a5596414b2279d5 URL: https://github.com/llvm/llvm-project/commit/2b8d6fa0acacba4dee31ed618a5596414b2279d5 DIFF:

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

2020-05-25 Thread Marco Elver via Phabricator via cfe-commits
melver updated this revision to Diff 266054. melver added a comment. -triple -> -target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79628/new/ https://reviews.llvm.org/D79628 Files: clang/lib/Driver/SanitizerArgs.cpp

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

2020-05-25 Thread Steven Wan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5bf2409a4e4d: [AIX] Add -bcdtors:all:0:s to linker to gather static init functions (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

2020-05-25 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-atomic-ops.cu:26 + // CHECK: atomicrmw fsub double* {{.*}} monotonic + return __atomic_fetch_sub(p, 1.0, memory_order_relaxed); +} Nitpick, but this should be `1.0L` to be consistent.

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

2020-05-25 Thread Marco Elver via Phabricator via cfe-commits
melver updated this revision to Diff 266048. melver added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Address failing tests: - Set -triple for test. - Some existing tests now pass under TSAN, and can be enabled. Repository: rG LLVM Github Monorepo

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

2020-05-25 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/AST/Decl.cpp:3169-3175 } else { -if (!getIdentifier()) +const auto *Attr = getAttr(); + +if (!Attr) return 0; +BuiltinID = Attr->getID(); I think this is a bit more clear: ```

[clang] 5bf2409 - [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

2020-05-25 Thread Steven Wan via cfe-commits
Author: stevewan Date: 2020-05-25T13:44:15-04:00 New Revision: 5bf2409a4e4d23018ecffe4eff39988a957e76f7 URL: https://github.com/llvm/llvm-project/commit/5bf2409a4e4d23018ecffe4eff39988a957e76f7 DIFF: https://github.com/llvm/llvm-project/commit/5bf2409a4e4d23018ecffe4eff39988a957e76f7.diff

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

2020-05-25 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 266047. kadircet marked 3 inline comments as done. kadircet added a comment. Instead of re-lexing at use time, put macro identifier on correct column while patching and make use of presumed locations at use time. Repository: rG LLVM Github Monorepo

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

2020-05-25 Thread Ferran Pallarès Roca via Phabricator via cfe-commits
fpallares added a comment. I've added a couple more inline comments. I've also noticed that we aren't emitting the aliases for unmasked instructions, for instance: (input → output) vnot.v v8, v4, v0.t → vnot.v v8, v4, v0.t ​vnot.v v8, v4 → vxor.vi v8, v4, -1 AFAICT RISC-V

[PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

2020-05-25 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. maybe for now we just do if (FormatTok->is(tok::l_square) && !Style.isObjC()) parseSquare(); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80144/new/ https://reviews.llvm.org/D80144

[PATCH] D79961: [PGO] Fix computation of fuction Hash

2020-05-25 Thread Matthew Voss via Phabricator via cfe-commits
ormris added a comment. There's a few test failures related to this change on the PS4 bot. Could you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/68111 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

2020-05-25 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay updated this revision to Diff 266046. MyDeveloperDay added a comment. Handle more cases, Currently on this case is failing, the preprocess lines are causing multiple replacements which means const gets move more than once. verifyFormat("Foo> P;\n#if 0\n#else\n#endif", "Foo

[PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

2020-05-25 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. > I know that we didn't have a test for this in ObjC land, but the regression > seems severe enough to revert this Sure go ahead, that's the process. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80144/new/

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-05-25 Thread Nathan James via Phabricator via cfe-commits
njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type.cpp:550 + +#if __cplusplus > 201703L /* C++2a and later */ + bernhardmgruber wrote: > How do you want to handle these tests which require

[PATCH] D80286: [Analyzer] Allow creation of stack frame for functions without definition

2020-05-25 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware updated this revision to Diff 266036. baloghadamsoftware added a comment. `SVal` explanation changed to //Xth parameter// format. Unit test changed: there is redeclaration after the definition now, all test code in raw string. CHANGES SINCE LAST ACTION

[clang] 3873d0b - Re-commit "[cmake] Allow std::filesystem tests in CrossWinToARMLinux.cmake"

2020-05-25 Thread Sergej Jaskiewicz via cfe-commits
Author: Sergej Jaskiewicz Date: 2020-05-25T19:14:54+03:00 New Revision: 3873d0b3d899bb84a5983450dd2d98006c4527e2 URL: https://github.com/llvm/llvm-project/commit/3873d0b3d899bb84a5983450dd2d98006c4527e2 DIFF:

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

2020-05-25 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz created this revision. adamcz added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. When preamble contains #undef, indexing code finds the matching #define and uses that during

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

2020-05-25 Thread Gabor Marton via Phabricator via cfe-commits
martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:435 + /// If the call returns a C++ record type then the region of its return value + // can be retrieved from its construction context. + Optional

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

2020-05-25 Thread Denys Petrov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGba92b274225f: [analyzer] Improved RangeSet::Negate support of unsigned ranges (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-05-25 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber updated this revision to Diff 266034. bernhardmgruber marked 2 inline comments as done and 2 inline comments as done. bernhardmgruber added a comment. - split code tables in documentation - removed unnecessary return statement CHANGES SINCE LAST ACTION

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-05-25 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:399 - return true; + return; } Eugene.Zelenko wrote: > Non needed. See readability-redundant-control-flow. Thx!

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

2020-05-25 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware added a comment. Alternative approach is D80522 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79704/new/ https://reviews.llvm.org/D79704 ___ cfe-commits mailing list

[PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

2020-05-25 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added a comment. Unfortunately this introduced a bad regression with ObjC method expressions in `if` bodies: if (argc > 5) [obj func:arg]; is now formatted as: if (argc > 5)[obj func:arg] ; It seems that at this stage of processing it would be non-trivial to distinguish

[clang] ba92b27 - [analyzer] Improved RangeSet::Negate support of unsigned ranges

2020-05-25 Thread Denys Petrov via cfe-commits
Author: Denys Petrov Date: 2020-05-25T18:52:22+03:00 New Revision: ba92b274225fc78dc15e8dc0076f71e7a8b5d084 URL: https://github.com/llvm/llvm-project/commit/ba92b274225fc78dc15e8dc0076f71e7a8b5d084 DIFF: https://github.com/llvm/llvm-project/commit/ba92b274225fc78dc15e8dc0076f71e7a8b5d084.diff

[PATCH] D80521: [clangd] Make use of SourceOrder to find first initializer in DefineOutline

2020-05-25 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Constructors can have implicit initializers, this was crashing define outline. Make sure we find the

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

2020-05-25 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus, martong, balazske. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet,

[clang] 7c298c1 - [PGO] Fix computation of function Hash

2020-05-25 Thread via cfe-commits
Author: serge-sans-paille Date: 2020-05-25T17:17:29+02:00 New Revision: 7c298c104bfe725d4315926a656263e8a5ac3054 URL: https://github.com/llvm/llvm-project/commit/7c298c104bfe725d4315926a656263e8a5ac3054 DIFF:

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

2020-05-25 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware added a comment. This is an alternative approach to D79704 . The advantage is that we must not duplicate code everywhere where `VarRegion` (and sometimes also `DeclRegion`) is used. The drawback is that after we implement handling of

[PATCH] D79961: [PGO] Fix computation of fuction Hash

2020-05-25 Thread serge via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7c298c104bfe: [PGO] Fix computation of function Hash (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/

[PATCH] D79493: [AMDGPU] Added 'A' constraint for inline assembler

2020-05-25 Thread Dmitry Preobrazhensky via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3c6c2ecd6efa: [AMDGPU] Added A constraint for inline assembler (authored by dp). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[clang] 3c6c2ec - [AMDGPU] Added 'A' constraint for inline assembler

2020-05-25 Thread Dmitry Preobrazhensky via cfe-commits
Author: Dmitry Preobrazhensky Date: 2020-05-25T17:47:06+03:00 New Revision: 3c6c2ecd6efa393e7a8422d88e5d4ada0970e47e URL: https://github.com/llvm/llvm-project/commit/3c6c2ecd6efa393e7a8422d88e5d4ada0970e47e DIFF:

[PATCH] D80018: [Analyzer][StreamChecker] Added check for "indeterminate file position".

2020-05-25 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:107 + /// This value applies to all error states in ErrorState except FEOF. + /// An EOF+indeterminate state is the same as EOF state. +

[PATCH] D79961: [PGO] Fix computation of fuction Hash

2020-05-25 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 ___

[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

2020-05-25 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 266016. vsavchenko added a comment. Fix SATestBuild Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80517/new/ https://reviews.llvm.org/D80517 Files: clang/utils/analyzer/CmpRuns.py

[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

2020-05-25 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 266015. vsavchenko added a comment. Fix a couple more names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80517/new/ https://reviews.llvm.org/D80517 Files: clang/utils/analyzer/CmpRuns.py Index:

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

2020-05-25 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added a comment. I'm happy with this patch! We found a couple of rough edges: - alignment after `?:` and - new formatting of `_ ? _ ? _ : _ : _` patterns is bad These are illustrated as examples D and E below (A, B and C look good to me). `test.cc` is how I'd expect clang-format to

[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

2020-05-25 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 266014. vsavchenko added a comment. Replace deprecated method call Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80517/new/ https://reviews.llvm.org/D80517 Files: clang/utils/analyzer/CmpRuns.py Index:

[PATCH] D78099: [analyzer][RetainCount] Tie diagnostics to osx.cocoa.RetainCount rather then RetainCountBase, for the most part

2020-05-25 Thread Gabor Marton via Phabricator via cfe-commits
martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LG! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78099/new/ https://reviews.llvm.org/D78099 ___ cfe-commits mailing list

[PATCH] D77474: [analyzer][MallocChecker] Make NewDeleteLeaks depend on DynamicMemoryModeling rather than NewDelete

2020-05-25 Thread Gabor Marton via Phabricator via cfe-commits
martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Looks good. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2024 + if (!ChecksEnabled[CK_MallocChecker] && !ChecksEnabled[CK_NewDeleteChecker]) { +

[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

2020-05-25 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-05-25 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:399 - return true; + return; } Non needed. See readability-redundant-control-flow. Comment at:

[PATCH] D79426: [clangd] Change PreambleOnlyAction with content truncation

2020-05-25 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Preamble.cpp:125 auto ContentsBuffer = llvm::MemoryBuffer::getMemBuffer(Contents); + auto Bounds = +

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

2020-05-25 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Foo> P; // This is needed to trigger the above 'const const' bug above: #if 0 #else #endif produces Foo const const> P; This bug is caused by the way clang-format re-parses the code for each conditional that the preprocessor caused (I actually

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

2020-05-25 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D80079#2049459 , @MyDeveloperDay wrote: > I feel like there might something of a concencus forming.. If I take the time > to redo following the suggestions @sammccall do you think you could live with > it? Yeah, LGTM.

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

2020-05-25 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1378 +**ConstStyle** (``ConstAlignmentStyle``) + Different ways to arrange const. MyDeveloperDay wrote: > aaron.ballman wrote: > > MyDeveloperDay wrote: > > > klimek wrote: > > >

[PATCH] D80296: [clangd] Don't traverse the AST within uninteresting files during indexing

2020-05-25 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz added a comment. Correct me if I'm wrong, but this might lead to a file never being updated in the index, even after edit, right? Let's say you have file a.cpp that includes a.h. a.h has namespace foo { #define EXPAND(foo) whatever #include "b.h" } all nodes from b.h will be inside

  1   2   3   >