[PATCH] D80439: Replace separator in OpenMP variant name mangling.

LukasSommerTu added a comment. @jdoerfert: Can you please commit for me, I do not have commit access. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80439/new/ https://reviews.llvm.org/D80439 ___ cfe-commits mailing list cfe-commits@

[PATCH] D81008: [AST] Record SourceLocation for TypoExpr.

hokein updated this revision to Diff 268068. hokein marked an inline comment as done. hokein added a comment. use a single location. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81008/new/ https://reviews.llvm.org/D81008 Files: clang/include/cl

[PATCH] D80876: [clang] Default to windows response files when running on windows

mstorsjo added a comment. In D80876#2069970 , @sbc100 wrote: > Do you know how gcc handles this case when running on mingw? It uses the gnu/unix quoting style - so that's the case for wanting clang to preserve compatibility with that behaviour. The fac

[clang] bb1d8bf - [X86] Add CLWB to Tremont CPU. Remove CLDEMOTE, MOVDIRI, MOVDIR64B, and WAITPKG to match gcc.

Author: Craig Topper Date: 2020-06-02T22:38:51-07:00 New Revision: bb1d8bf2707bdca89c1f5e719057f1000232ccc3 URL: https://github.com/llvm/llvm-project/commit/bb1d8bf2707bdca89c1f5e719057f1000232ccc3 DIFF: https://github.com/llvm/llvm-project/commit/bb1d8bf2707bdca89c1f5e719057f1000232ccc3.diff

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 268055. Daniel599 added a comment. Added `StringMap::operator!=` and also unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-extra/

[PATCH] D80835: [AIX] Change the default target CPU to power4 for AIX on Power

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:301 +TargetCPUName = "pwr4"; + else if (!T.isOSDarwin()) { +

[PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT

hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added a comment. I believe I have responded to @joerg's comments with rationale to support the current direction. I intend to commit this patch within a week or two. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

hubert.reinterpretcast added inline comments. Comment at: llvm/docs/CodingStandards.rst:1578 +unnecessary and otherwise meaningless code. Braces should be used however +in cases where it significantly improves readability, such as when the single +statement is accompanied by a co

[PATCH] D77168: Add a flag to debug automatic variable initialization

MaskRay added a comment. In D77168#2070049 , @jcai19 wrote: > In D77168#2069783 , @MaskRay wrote: > > > Do we have a mechanism bisecting pragmas? If yes, we can let that tool add > > `#pragma clang attribute push([

[PATCH] D80954: [NFC,MTE] Drop unneeded attribute from test

This revision was automatically updated to reflect the committed changes. Closed by commit rG85fdec988fc5: [NFC,MTE] Drop unneeded attribute from test (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80954/new/ https://reviews

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 added a comment. In D77168#2069783 , @MaskRay wrote: > Do we have a mechanism bisecting pragmas? If yes, we can let that tool add > `#pragma clang attribute push([[clang::uninitialized]], apply_to = variable)` Not that I am aware of unfortunately

[PATCH] D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option

saghir updated this revision to Diff 268031. saghir marked an inline comment as done. saghir removed a reviewer: power-llvm-team. saghir added a comment. Herald added a subscriber: kbarton. Addressed nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] 85fdec9 - [NFC,MTE] Drop unneeded attribute from test

Author: Vitaly Buka Date: 2020-06-02T18:28:45-07:00 New Revision: 85fdec988fc55d56988d57fa88e2b870f6e0e8e9 URL: https://github.com/llvm/llvm-project/commit/85fdec988fc55d56988d57fa88e2b870f6e0e8e9 DIFF: https://github.com/llvm/llvm-project/commit/85fdec988fc55d56988d57fa88e2b870f6e0e8e9.diff L

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2031-2033 + "%select{|member |static member }0%2" + "%select{| of %3| of struct %4| of union %4| of class %4" + "| of structured binding %3}1">, InGroup; I wonder if we

[PATCH] D79959: [SampleFDO] Add use-sample-profile function attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a6c89427c9b: [SampleFDO] Add use-sample-profile function attribute. (authored by wmi). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.ll

[clang] 7a6c894 - [SampleFDO] Add use-sample-profile function attribute.

Author: Wei Mi Date: 2020-06-02T17:23:17-07:00 New Revision: 7a6c89427c9babc8e4a69e8a2b61bbf4a4b80c56 URL: https://github.com/llvm/llvm-project/commit/7a6c89427c9babc8e4a69e8a2b61bbf4a4b80c56 DIFF: https://github.com/llvm/llvm-project/commit/7a6c89427c9babc8e4a69e8a2b61bbf4a4b80c56.diff LOG: [

[PATCH] D80876: [clang] Default to windows response files when running on windows

sbc100 added a comment. Do you know how gcc handles this case when running on mingw? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80876/new/ https://reviews.llvm.org/D80876 ___ cfe-commits mailing lis

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

jdoerfert added a comment. In D79744#2069786 , @arsenm wrote: > In D79744#2069774 , @arsenm wrote: > > > I think this is converging to adding a new IR attribute that essentially > > just provides the pointee type f

[PATCH] D80771: [MTE] Convert StackSafety into analysis

This revision was automatically updated to reflect the committed changes. Closed by commit rG232d348c6eff: [MTE] Convert StackSafety into analysis (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80771/new/ https://reviews.llv

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rG8eda71616fec: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80828/new

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

nickdesaulniers added a comment. thanks homies, committed as https://github.com/llvm/llvm-project/commit/8eda71616fecd098cbd7d2447859c8ac1315966f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80828/new/ https://reviews.llvm.org/D80828 _

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2069435 , @ABataev wrote: > In D79972#2069366 , @cchen wrote: > > > In D79972#2069358 , @ABataev wrote: > > > > > In D79972#2069322

RE: [PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

The test failed 7-8 times in a row on the same build machine and then started passing for about 10 runs, and then started failing again for 4 more runs, after which we disabled it. The configuration is nothing special, simply a Release+Asserts build on Windows. We tried to reproduce it by hand o

[clang] 232d348 - [MTE] Convert StackSafety into analysis

Author: Vitaly Buka Date: 2020-06-02T16:08:14-07:00 New Revision: 232d348c6eff8493fc016b1ea8a99db0e5620d81 URL: https://github.com/llvm/llvm-project/commit/232d348c6eff8493fc016b1ea8a99db0e5620d81 DIFF: https://github.com/llvm/llvm-project/commit/232d348c6eff8493fc016b1ea8a99db0e5620d81.diff L

[clang] 39fa431 - [Analyzer][NFC] Fix markup in WebKit checkers documentation

Author: Jan Korous Date: 2020-06-02T16:04:23-07:00 New Revision: 39fa431c8ccad45de9ec67e8681da923d0cd28c7 URL: https://github.com/llvm/llvm-project/commit/39fa431c8ccad45de9ec67e8681da923d0cd28c7 DIFF: https://github.com/llvm/llvm-project/commit/39fa431c8ccad45de9ec67e8681da923d0cd28c7.diff LO

[clang] 8eda716 - [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

Author: Nick Desaulniers Date: 2020-06-02T15:54:14-07:00 New Revision: 8eda71616fecd098cbd7d2447859c8ac1315966f URL: https://github.com/llvm/llvm-project/commit/8eda71616fecd098cbd7d2447859c8ac1315966f DIFF: https://github.com/llvm/llvm-project/commit/8eda71616fecd098cbd7d2447859c8ac1315966f.di

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. The change description says something about PWD (which makes me worried about build determinism, like amccarth), but I don't see anything about that in the diff. The diff as-is looks fine to me with hans's comment about duplication resolved in some form. Please don't ad

[PATCH] D80954: [NFC,MTE] Drop unneeded attribute from test

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80954/new/ https://reviews.llvm.org/D80954 _

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:21 +// FIXME: Add any more builtin variadics that shouldn't trigger this +static constexpr StringRef AllowedVariadics[] = { njames93 wrote: >

[PATCH] D81040: Split syntax tree tests into more granular ones

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr2 added reviewers: hlopko, eduucaldas. Doing so allows us to increase test coverage by removing unnecessary language restrictions. Repository: rG LLVM Github Monorepo https://revie

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 268009. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/C

[PATCH] D81041: Use existing path sep style in clang::FileManager::FixupRelativePath

ctetreau created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ctetreau added reviewers: efriedma, apazos, zzheng, dexonsmith, rnk. Modify clang::FileManager::FixupRelativePath to use the existing path separator style, if one exists. Prior to this change, if

[PATCH] D80877: [clang-tidy] Added MacroDefiniton docs for readability-identifier-naming

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! We can add the `ObjCIVar` docs in a future patch if someone has the expertise there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. Is there any feedback? thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

tentzen added a comment. Hi, does this look good? or is there any other concern? thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77982/new/ https://reviews.llvm.org/D77982 ___ cfe-commits mailing

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 268002. nickdesaulniers added a comment. - handle non top level decls, add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files: clang/docs/ClangComman

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

arsenm added a comment. In D79744#2069774 , @arsenm wrote: > I think this is converging to adding a new IR attribute that essentially just > provides the pointee type for ABI purposes. I guess my name ideas for this > would be "indirect", "value", "memo

[PATCH] D77168: Add a flag to debug automatic variable initialization

MaskRay added a comment. Do we have a mechanism bisecting pragmas? If yes, we can let that tool add `#pragma clang attribute push([[clang::uninitialized]], apply_to = variable)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77168/new/ https://revi

[PATCH] D74746: [clang][doxygen] Fix -Wdocumentation warning for tag typedefs

chrish_ericsson_atx added a comment. I reported this issue back in November, as https://bugs.llvm.org/show_bug.cgi?id=44143. This change fixes the bug -- I'll mark it as such. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74746/new/ https://revi

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79721/new/ https://reviews.llvm.org/D79721 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D81037: [OPENMP]Fix PR46170: partial mapping for array sections of data members.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81037/new/ https://reviews.llvm.org/D81037 __

[PATCH] D79052: [clang codegen] Fix alignment of "Address" for incomplete array pointer.

efriedma updated this revision to Diff 267999. efriedma added a comment. This should work correctly, now, I think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79052/new/ https://reviews.llvm.org/D79052 Files: clang/lib/CodeGen/CodeGenModule.cp

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

arsenm added a comment. In D79744#2069620 , @rjmccall wrote: > In D79744#2069324 , @arsenm wrote: > > > In D79744#2050498 , @rjmccall > > wrote: > > > > > > For the purpose

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

jdoerfert marked an inline comment as done. jdoerfert added a comment. I tried to determine why we don't emit such calls for c++11 and stdc++ but I was not successful :( Tracking back from the emission lead to the generic expression codegen without any (obvious) check of the runtime library or s

[PATCH] D81037: [OPENMP]Fix PR46170: partial mapping for array sections of data members.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the quick fix! I

[PATCH] D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator

curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:981 consumeToken(); +if (CurrentToken->is(tok::comma) && +CurrentToken->Previous->isNot(tok::kw_operator)) Shouldn't you check `CurrentToken` for not bein

[PATCH] D80950: [clang-format] [PR44542,38872] String << String always get a forced newline.

curdeius added a comment. The change seems to me technically sound, but I'm not sure of the scope of its effects. There might be users that rely on this behaviour. On the other hand, adding an option to keep the old behaviour doesn't seem appropriate, and personally I consider the old behaviour

[PATCH] D80961: WIP: Ignore template instantiations if not in AsIs mode

steveire added a comment. In D80961#2068902 , @aaron.ballman wrote: > My experience with clang-tidy has been that template instantiations are a > double-edged sword. The instantiation is the only place at which you have > sufficient information to perfo

[PATCH] D79052: [clang codegen] Fix alignment of "Address" for incomplete array pointer.

efriedma updated this revision to Diff 267994. efriedma added a comment. "Address" the review comments. Not really happy with this, but not sure what else to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79052/new/ https://reviews.llvm.org/D7

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 added a comment. @jfb Does the current implementation look good? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77168/new/ https://reviews.llvm.org/D77168 ___ cfe-commits mailing list cfe

[PATCH] D80961: WIP: Ignore template instantiations if not in AsIs mode

steveire added a comment. In D80961#2067638 , @gribozavr2 wrote: > If IgnoreUnlessSpelledInSource is indeed for novice users (and not to be > strictly interpreted as "it does what it says") we should think about whether > it more useful to ignore instant

[PATCH] D79052: [clang codegen] Fix alignment of "Address" for incomplete array pointer.

efriedma planned changes to this revision. efriedma added a comment. Hang on, I submitted this too early. Need to look a bit more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79052/new/ https://reviews.llvm.org/D79052

[PATCH] D80961: WIP: Ignore template instantiations if not in AsIs mode

steveire added a comment. In D80961#2068865 , @ymandel wrote: > Thank you for bringing up this issue. I think it highlights an underlying > problem -- editing templates is quite difficult -- that neither setting will > address, as Dmitri expanded on abov

cfe-commits@lists.llvm.org

miyuki added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16160 } case WebAssembly::BI__builtin_wasm_narrow_s_i8x16_i16x8: case WebAssembly::BI__builtin_wasm_narrow_u_i8x16_i16x8: miyuki wrote: > This chunk does not belong to the patch Oo

[clang] 1643799 - Undo removal of test for dr777.

Author: Richard Smith Date: 2020-06-02T14:19:42-07:00 New Revision: 16437992cac249f6fe1efd392d20e3469b47e39e URL: https://github.com/llvm/llvm-project/commit/16437992cac249f6fe1efd392d20e3469b47e39e DIFF: https://github.com/llvm/llvm-project/commit/16437992cac249f6fe1efd392d20e3469b47e39e.diff

[PATCH] D80876: [clang] Default to windows response files when running on windows

mstorsjo added a subscriber: mati865. mstorsjo added a comment. In D80876#2069418 , @sbc100 wrote: > If we want want to have the default on windows be dependent on mingw vs > not-mingw then we should do it across the board so it applies to llvm-ar, > lld

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5317 /// EmitTopLevelDecl - Emit code for a single top level declaration. void CodeGenModule::EmitTopLevelDecl(Decl *D) { // Ignore depend

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk added a comment. In D80531#2069383 , @njames93 wrote: > LGTM with 2 small nits, but I'd still give a few days see if anyone else > wants to weight in. I'm okay with this but I'd like to understand when it's time to wait for others? Only when a patc

[PATCH] D80660: clang: Add support for relative linker paths with -fuse-ld

keith updated this revision to Diff 267991. keith added a comment. Fix test on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80660/new/ https://reviews.llvm.org/D80660 Files: clang/lib/Driver/ToolChain.cpp clang/test/Driver/fuse-ld.c

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

efriedma accepted this revision. efriedma added a comment. LGTM. For non-Android, I think it makes sense to align with gcc as much as possible. > This is mostly > for legacy/compatibility reasons, and the 2019 Q4 revision of the ARM > AAPCS looks to standardize r11 as the frame pointer for aa

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

rjmccall added a comment. In D79744#2069324 , @arsenm wrote: > In D79744#2050498 , @rjmccall wrote: > > > > For the purpose here, only the callee exists. This is essentially a > > > freestanding function, the entry

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

psmith accepted this revision. psmith added a comment. LGTM from an Arm person now that the Android changes have been made. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:22 #include "InputInfo.h" +#include "MSP430.h" #include "PS4CPU.h" nickdesaulniers wr

[clang] b5f2c4e - PR23029 / C++ DR2233: Allow expanded parameter packs to follow

Author: Richard Smith Date: 2020-06-02T13:48:59-07:00 New Revision: b5f2c4e45b8d54063051e6955cef0bbb7b6ab0f8 URL: https://github.com/llvm/llvm-project/commit/b5f2c4e45b8d54063051e6955cef0bbb7b6ab0f8 DIFF: https://github.com/llvm/llvm-project/commit/b5f2c4e45b8d54063051e6955cef0bbb7b6ab0f8.diff

[PATCH] D80883: [Driver] Add multiclass OptInFlag and OptOutFlag to simplify boolean option definition

This revision was automatically updated to reflect the committed changes. Closed by commit rG7694b571d9fd: [Driver] Add multiclass OptInFlag and OptOutFlag to simplify boolean option… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D80900: [clangd] Use different FS in PreambleThread

kadircet added a comment. In D80900#2066327 , @sammccall wrote: > TL;DR: I think there are three viable paths that we should consider: > A) minimal change: put the FSProvider in ParseInputs > B) this patch, but with more documentation and safety > C) fi

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 267970. nickdesaulniers added a comment. - add documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:10695 +// Truncate to prevent a DUP with an over wide constant +SDValue Trunc = DAG.getNode(ISD::TRUNCATE, DL, EltTy, Dup->getOperand(0)); + It's not legal to gene

[PATCH] D80931: AMDGPU: Fix clang side null pointer value for private

dyung added a comment. Matt, this change to the test was causing a failure in the upstream PS4 linux bot here: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/68593 I put in a fix for the test to unbreak the bot in 086be9fb20489540e6228a6d9eb4afad533202fa <

[clang] 26cb706 - [NFC][ASTMatchers] StringRef-ify and Twine-ify ASTMatchers tests.

Author: Nathan James Date: 2020-06-02T21:20:58+01:00 New Revision: 26cb70683bd4ffa49d94a8dad5ecfda549a673b0 URL: https://github.com/llvm/llvm-project/commit/26cb70683bd4ffa49d94a8dad5ecfda549a673b0 DIFF: https://github.com/llvm/llvm-project/commit/26cb70683bd4ffa49d94a8dad5ecfda549a673b0.diff

[clang] 7694b57 - [Driver] Add multiclass OptInFlag and OptOutFlag to simplify boolean option definition

Author: Fangrui Song Date: 2020-06-02T13:22:12-07:00 New Revision: 7694b571d9fd6a8a6c96af1e7995068f7066f6f1 URL: https://github.com/llvm/llvm-project/commit/7694b571d9fd6a8a6c96af1e7995068f7066f6f1 DIFF: https://github.com/llvm/llvm-project/commit/7694b571d9fd6a8a6c96af1e7995068f7066f6f1.diff

Re: [PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

thanks for letting me know. it is annoying that the test is flaky, but I don't see that flakiness on any other buildbot I've access to. Is there any chance that you are running in a custom build configuration that I can try to repro the failure? Also what's the falkiness ratio? On Tue, Jun 2, 202

[clang] 086be9f - Fix test on PS4 linux bot.

Author: Douglas Yung Date: 2020-06-02T20:17:02Z New Revision: 086be9fb20489540e6228a6d9eb4afad533202fa URL: https://github.com/llvm/llvm-project/commit/086be9fb20489540e6228a6d9eb4afad533202fa DIFF: https://github.com/llvm/llvm-project/commit/086be9fb20489540e6228a6d9eb4afad533202fa.diff LOG:

[PATCH] D81017: [Analyzer][WebKit] Check record definition is available in NoUncountedMembers checker

This revision was automatically updated to reflect the committed changes. Closed by commit rGd61ad660503d: [Analyzer][WebKit] Check record definition is available in NoUncountedMembers… (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:768 Opts.DebugFwdTemplateParams = Args.hasArg(OPT_debug_forward_template_params); + Opts.DebugUnusedTypes = Args.hasArg(OPT_eliminate_unused_debug_types_fno); Opts.EmbedSource = Ar

[clang] d61ad66 - [Analyzer][WebKit] Check record definition is available in NoUncountedMembers checker

Author: Jan Korous Date: 2020-06-02T13:10:36-07:00 New Revision: d61ad660503d2e0c7ba9981ba6526ae0c2f3b7cc URL: https://github.com/llvm/llvm-project/commit/d61ad660503d2e0c7ba9981ba6526ae0c2f3b7cc DIFF: https://github.com/llvm/llvm-project/commit/d61ad660503d2e0c7ba9981ba6526ae0c2f3b7cc.diff LO

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk added a comment. Done. Comment at: clang-tools-extra/clang-tidy/modernize/ReplaceDisallowCopyAndAssignMacroCheck.h:52 + + const std::string getMacroName() const { return MacroName; } + njames93 wrote: > Return by reference here. Yeah, that makes sense. St

[PATCH] D80968: [WebAssembly] Improve macro hygiene in wasm_simd128.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG237be3404b44: [WebAssembly] Improve macro hygiene in wasm_simd128.h (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80968/new/ https://

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:676 + Value v = vals[vd]; + if (isUninitialized(v)) +handler.handleConstRefUseOfUninitVariable(vd, getUninitUse(ex, vd, v)); Ma

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk updated this revision to Diff 267960. kwk marked 4 inline comments as done. kwk added a comment. - Return macro name by reference - Add colon to paragraph showing code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80531/new/ https://reviews.llv

[PATCH] D80903: [analyzer] Ignore calculated indices of <= 0 in VLASizeChecker

Szelethus accepted this revision. Szelethus added a comment. LGTM! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80903/new/ https://reviews.llvm.org/D80903 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D80876: [clang] Default to windows response files when running on windows

sbc100 added a comment. The problem I ran into regarding the quoting style differences was trying to refer to filenames that contains single quote characters: Here is our test case that I've currently disabled on windows pending the resolution of this issue: https://github.com/emscripten-core/e

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea marked an inline comment as done. aganea added a comment. In D80833#2069246 , @amccarth wrote: > Does the full path to the tool end up only in the object file, or does this > make it all the way to the final executable or library? The `LF_BUILDIN

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D79972#2069366 , @cchen wrote: > In D79972#2069358 , @ABataev wrote: > > > In D79972#2069322 , @cchen wrote: > > > > > In D79972#2068976

[PATCH] D80883: [Driver] Add multiclass OptInFlag and OptOutFlag to simplify boolean option definition

echristo accepted this revision. echristo added a comment. This looks good to me. Might want to open a project around migrating everything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80883/new/ https://reviews.llvm.org/D80883

[PATCH] D80876: [clang] Default to windows response files when running on windows

sbc100 added a comment. If we want want to have the default on windows be dependent on mingw vs not-mingw then we should do it across the board so it applies to llvm-ar, lld, and other tools. Right now I don't think any of those other tools have any special mingw handling. Would it make sense

[clang] 237be34 - [WebAssembly] Improve macro hygiene in wasm_simd128.h

Author: Thomas Lively Date: 2020-06-02T12:55:06-07:00 New Revision: 237be3404b448637ec3b36f8992434193c5bc64c URL: https://github.com/llvm/llvm-project/commit/237be3404b448637ec3b36f8992434193c5bc64c DIFF: https://github.com/llvm/llvm-project/commit/237be3404b448637ec3b36f8992434193c5bc64c.diff

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM with 2 small nits, but I'd still give a few days see if anyone else wants to weight in. Comment at: clang-tools-extra/clang-tidy/modernize/ReplaceDisallowCopyAndAs

[PATCH] D77866: [analyzer][CallAndMessage] Add checker options for each bug category

NoQ added a comment. > While this sounds really good for basic use cases I think it quickly becomes > unmanageable for power users. It's strictly better than the current situation because nothing prevents us from keeping the existing checker names as a subset of tags (i.e., #core/#core.CallAnd

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2069358 , @ABataev wrote: > In D79972#2069322 , @cchen wrote: > > > In D79972#2068976 , @ABataev wrote: > > > > > Still: Did you think about

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D79972#2069322 , @cchen wrote: > In D79972#2068976 , @ABataev wrote: > > > Still: Did you think about implementing it in the compiler instead of the > > runtime? > > > I'm not sure I und

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl updated this revision to Diff 267950. pestctrl added a comment. Copy pasted error messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

arsenm added a comment. In D79744#2050498 , @rjmccall wrote: > > For the purpose here, only the callee exists. This is essentially a > > freestanding function, the entry point to the program. > > I'm definitely not going to let you add a new "generic" arg

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl updated this revision to Diff 267947. pestctrl added a comment. Copy pasted error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2068976 , @ABataev wrote: > Still: Did you think about implementing it in the compiler instead of the > runtime? I'm not sure I understand your question, which part of code are you asking? The main work compiler needs to

[PATCH] D80925: Fix compiler crash when an expression parsed in the tentative parsing and must be claimed in the another evaluation context.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f7269b6773d (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80925/new/ https://reviews.llvm.org/D80925 Files: clang/include/clang/Ba

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

MaskRay added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:676 + Value v = vals[vd]; + if (isUninitialized(v)) +handler.handleConstRefUseOfUninitVariable(vd, getUninitUse(ex, vd, v)); This should use isAlwaysUninit. I fixed it in

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

MaskRay added a subscriber: olista01. MaskRay added a comment. In D80828#2069287 , @nickdesaulniers wrote: > May I please have a non-Googler to review+(accept|reject) the revision? I guess @olista01 is an inactive account. Changed to @ostannard Reposi

[PATCH] D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive

ABataev added a comment. Must be fixed in 2f7269b6773de2750f9cd1417ef5f21cd6cf7a91 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80590/new/ https://reviews.llvm.org/D80590 __

[clang] 2f7269b - Fix compiler crash when an expression parsed in the tentative parsing and must be claimed in the another evaluation context.

Author: Alexey Bataev Date: 2020-06-02T14:27:33-04:00 New Revision: 2f7269b6773de2750f9cd1417ef5f21cd6cf7a91 URL: https://github.com/llvm/llvm-project/commit/2f7269b6773de2750f9cd1417ef5f21cd6cf7a91 DIFF: https://github.com/llvm/llvm-project/commit/2f7269b6773de2750f9cd1417ef5f21cd6cf7a91.diff

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

nickdesaulniers added a comment. May I please have a non-Googler to review+(accept|reject) the revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80828/new/ https://reviews.llvm.org/D80828 ___ cfe

  1   2   3   >