[PATCH] D86000: Add an unsigned shift base sanitizer

lebedev.ri added a comment. Release notes missing. I think the canonical way to silence it (via masking?) should be at least mentioned. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3872-3884 llvm::Value *BitsShiftedOff = Builder.CreateLShr( Ops.LHS, Builder

[PATCH] D86682: [SyntaxTree][NFC][Style] Functions start with lowercase

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86682 Files: clang/lib/Tooling/Syntax/BuildTree.cpp Index: clang/lib/Tooling/

[PATCH] D86679: [SyntaxTree][NFC] Append "get" to syntax Nodes accessor names

eduucaldas added a reviewer: gribozavr2. eduucaldas added a comment. It's worth noting that accessors in the base APIs don't follow this rule. Should we refactor them as well? In this patch? Examples: class Arena { public: const SourceManager &sourceManager() const { return SourceMgr; }

[PATCH] D86679: [SyntaxTree][NFC] Append "get" to syntax Nodes accessor names

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86679 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syn

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

tejohnson updated this revision to Diff 288191. tejohnson added a comment. Remove unnecessary check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85948/new/ https://reviews.llvm.org/D85948 Files: clang/include/clang/Basic/CodeGenOptions.def cl

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

tejohnson added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HeapProfiler.cpp:563 +return false; + if (!ClDebugFunc.empty() && ClDebugFunc == F.getName()) +return false; MaskRay wrote: > `ClDebugFunc != F.getName()` Your suggestion do

[PATCH] D86514: Correctly parse LateParsedTemplates in case of multiple dependent modules

gargvaibhav64 added a comment. Thanks. I incorporated all the changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86514/new/ https://reviews.llvm.org/D86514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D86514: Correctly parse LateParsedTemplates in case of multiple dependent modules

gargvaibhav64 updated this revision to Diff 288186. gargvaibhav64 marked 5 inline comments as done. gargvaibhav64 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86514/new/ https://reviews.llvm.org/D86514 Files: clang/include/clang/Serialization/ASTRe

[clang] a45ccc9 - Default to -fuse-init-array on OpenBSD.

Author: Brad Smith Date: 2020-08-27T01:12:16-04:00 New Revision: a45ccc983b51330fd49c8526fe4770e40eeab708 URL: https://github.com/llvm/llvm-project/commit/a45ccc983b51330fd49c8526fe4770e40eeab708 DIFF: https://github.com/llvm/llvm-project/commit/a45ccc983b51330fd49c8526fe4770e40eeab708.diff LO

[PATCH] D82609: [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76b0f99ea854: [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang (authored by amyk). Changed prior to commit: https:/

[clang] 76b0f99 - [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

Author: Amy Kwan Date: 2020-08-26T23:14:34-05:00 New Revision: 76b0f99ea854185c9866b0ab0f006137ba28e09e URL: https://github.com/llvm/llvm-project/commit/76b0f99ea854185c9866b0ab0f006137ba28e09e DIFF: https://github.com/llvm/llvm-project/commit/76b0f99ea854185c9866b0ab0f006137ba28e09e.diff LOG:

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

modimo added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:522 FPM.addPass(createFunctionToLoopPassAdaptor( - std::move(LPM2), /*UseMemorySSA=*/false, DebugLogging)); + std::move(LPM2), /*UseMemorySSA=*/false, /*UseBlockFrequencyInfo=*/true, + Deb

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

modimo updated this revision to Diff 288172. modimo added a comment. Remove usage need for BFI in LPM2 and set unswitching to preserve lazy BPI/BFI so it can remain in the same loop pass as LICM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86156/new/ https://reviews.llvm.org/D86156 F

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

snehasish added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1030 +/// recursive return edges vs. indirect branches. The format of the metadata is +/// described as follows: 1st bit (LSB): set if this is a return block (return +/// or tail call). 2nd bi

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl added inline comments. Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:58 +unsigned MachineBasicBlock::getBBAddrMapMetadata() const { + const TargetInstrInfo *TII = getParent()->getSubtarget().getInstrInfo(); snehasish wrote: > I think this method o

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 288158. rahmanl marked 4 inline comments as done. rahmanl added a comment. Address Snehasish's comments. - Move getBBAddrMetadata to AsmPrinter as a static function in AsmPrinter - Remove unnecessary IR instructions in basic-block-sections-labels.ll Reposit

[PATCH] D86671: Add new IdentifierNamingCheck::CaseType, CT_HungarianNotion, supporting naming check with Hungarian Notion.

dougpuob created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. dougpuob requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86671 Files: clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.cpp cl

[PATCH] D86668: Fix Calling Convention of __float128 and long double(128bits) in i386

yubing created this revision. yubing added reviewers: craig.topper, LuoYuanke, LiuChen3. Herald added a project: clang. Herald added a subscriber: cfe-commits. yubing requested review of this revision. This patch make __float128/long double(128bits) passed on the stack with 16-byte alignment, ac

[libunwind] 3071d5f - [libunwind] Factor out getInfoFromFdeCie. NFCI.

Author: Ryan Prichard Date: 2020-08-26T18:22:06-07:00 New Revision: 3071d5ffba2337174f95f984bc1603a2be8b797d URL: https://github.com/llvm/llvm-project/commit/3071d5ffba2337174f95f984bc1603a2be8b797d DIFF: https://github.com/llvm/llvm-project/commit/3071d5ffba2337174f95f984bc1603a2be8b797d.diff

[libunwind] 7a45759 - [libunwind] Minor fixes in libunwind

Author: Ryan Prichard Date: 2020-08-26T18:22:03-07:00 New Revision: 7a457593efecc8f3e806cd3d022c480bc80d4fbb URL: https://github.com/llvm/llvm-project/commit/7a457593efecc8f3e806cd3d022c480bc80d4fbb DIFF: https://github.com/llvm/llvm-project/commit/7a457593efecc8f3e806cd3d022c480bc80d4fbb.diff

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

hoy added a comment. In D86193#2240596 , @wmi wrote: > In D86193#2240502 , @hoy wrote: > >> In D86193#2240353 , @wmi wrote: >> There are some optimizations such as if-co

[PATCH] D39937: [Sema] Improve diagnostics for const- and ref-qualified member functions

aaronpuchert added inline comments. Comment at: test/CXX/over/over.match/over.match.funcs/p4-0x.cpp:22-24 + void lvalue() &; // expected-note 2 {{'lvalue' declared here}} + void const_lvalue() const&; + void rvalue() &&; // expected-note {{'rvalue' declared here}}

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

vvereschaka added a comment. Hi @hokein, sorry, but looks like your changes break one of libc++ tests on ARM cross toolchain build on Windows: `libc++::function_type_default_deleter.fail.cpp` Here is the first failed build: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/945 I

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

wmi added a comment. In D86193#2240502 , @hoy wrote: > In D86193#2240353 , @wmi wrote: > >>> There are some optimizations such as if-convert, tail call elimination, >>> that were initially blocked by the pseudo pro

[PATCH] D85176: [Coverage] Enable emitting gap area between macros

zequanwu reopened this revision. zequanwu added a comment. This revision is now accepted and ready to land. Here is a repro of crash caused by this change. int k, l; #define m(e) e##e void p() { int kk,ll; if (k) m(k); else l = m(l); } `SM.getExpansLoc(AfterLoc)`

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

asbirlea added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:522 FPM.addPass(createFunctionToLoopPassAdaptor( - std::move(LPM2), /*UseMemorySSA=*/false, DebugLogging)); + std::move(LPM2), /*UseMemorySSA=*/false, /*UseBlockFrequencyInfo=*/true, + D

[PATCH] D86000: Add an unsigned shift base sanitizer

jfb updated this revision to Diff 288133. jfb added a comment. Re-upload with full context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86000/new/ https://reviews.llvm.org/D86000 Files: clang/docs/UndefinedBehaviorSanitizer.rst clang/include

[PATCH] D86000: Add an unsigned shift base sanitizer

jfb updated this revision to Diff 288132. jfb added a comment. As Vedant suggested, make it part of 'integer' sanitizer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86000/new/ https://reviews.llvm.org/D86000 Files: clang/include/clang/Basic/Sa

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

hoy added a comment. In D86193#2240353 , @wmi wrote: >> There are some optimizations such as if-convert, tail call elimination, that >> were initially blocked by the pseudo probe intrinsic but is now unblocked by >> fixes included in this change. With th

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay added a comment. Ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85474/new/ https://reviews.llvm.org/D85474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a comment. In D79279#2235085 , @rsmith wrote: > Thanks, I'm happy with this approach. > > If I understand correctly, the primary (perhaps sole) purpose of > `__builtin_memcpy_sized` is to provide a primitive from which an atomic > operation can

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb updated this revision to Diff 288131. jfb marked 12 inline comments as done. jfb added a comment. Address Richard's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 Files: clang/docs/Language

[clang] 2d13693 - [X86] Update release notes for -mtune support.

Author: Craig Topper Date: 2020-08-26T16:16:56-07:00 New Revision: 2d13693bfce9b6c2c706f3ea6745ab3fdfa517e1 URL: https://github.com/llvm/llvm-project/commit/2d13693bfce9b6c2c706f3ea6745ab3fdfa517e1 DIFF: https://github.com/llvm/llvm-project/commit/2d13693bfce9b6c2c706f3ea6745ab3fdfa517e1.diff

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

MaskRay accepted this revision. MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HeapProfiler.cpp:563 +return false; + if (!ClDebugFunc.empty() && ClDebugFunc == F.getName()) +return false; `ClDebugFunc != F.getName()` Rep

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

modimo added a comment. In D86156#2231710 , @nikic wrote: > This change adds three PDT calculations to the standard pipeline. Please try > to avoid the PDT calculations if PGO is not used, possibly by using LazyBPI. Good catch, changed to use LazyBFI whi

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

modimo updated this revision to Diff 288125. modimo added a comment. Change to LazyBFI for legacy pass manager to prevent rebuilding the post-dominator tree CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86156/new/ https://reviews.llvm.org/D86156 Files: clang/test/CodeGen/thinlto-dis

[PATCH] D86169: Initial support for letting plugins perform custom parsing of attribute arguments.

jonathan.protzenko added a comment. > I'm hoping we can devise a way to not require the entity being attributed to > be passed when parsing the attribute That sounds nice. My only concern with this proposal is to make sure this doesn't rule out the interesting use-cases I was mentioning, like t

[PATCH] D84603: Thread safety analysis: More consistent warning message

aaronpuchert added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:1644 if (!LDat) { - Analyzer->Handler.handleMutexNotHeld("", D, POK, Cp.toString(), - LK_Shared, Loc); + Analyzer->Handler.handleMutexNotHe

[PATCH] D86488: [X86] Default to -mtune=generic unless -march is passed to the driver. Add TuneCPU to the AST serialization

This revision was automatically updated to reflect the committed changes. Closed by commit rG71f3169e1bae: [X86] Default to -mtune=generic unless -march is passed to the driver. Add… (authored by craig.topper). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] 71f3169 - [X86] Default to -mtune=generic unless -march is passed to the driver. Add TuneCPU to the AST serialization

Author: Craig Topper Date: 2020-08-26T14:52:03-07:00 New Revision: 71f3169e1baeff262583b35ef88f8fb6df7be85e URL: https://github.com/llvm/llvm-project/commit/71f3169e1baeff262583b35ef88f8fb6df7be85e DIFF: https://github.com/llvm/llvm-project/commit/71f3169e1baeff262583b35ef88f8fb6df7be85e.diff

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

wmi added a comment. > There are some optimizations such as if-convert, tail call elimination, that > were initially blocked by the pseudo probe intrinsic but is now unblocked by > fixes included in this change. With the current change we do not see perf > degradation out of SPEC and one of our

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

snehasish added inline comments. Comment at: clang/docs/UsersManual.rst:1706 + its own unique section. With the "labels" value, normal sections are emitted, + but a ".bb_addr_map" section is emitted which would include address offsets + for each basic block in the program, rel

[PATCH] D86101: [AArch64][SVE] Add missing debug info for ACLE types.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86101/new/ https://reviews.llvm.org/D86101 ___ cfe-commits mailing list cfe-commits

[PATCH] D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl

shafik created this revision. shafik added reviewers: martong, teemperor. Herald added a subscriber: rnkovacs. shafik requested review of this revision. When we fixed `ImportDeclContext(...)` in D71378 to make sure we complete each `FieldDecl` of a `RecordDecl`

[PATCH] D86514: Correctly parse LateParsedTemplates in case of multiple dependent modules

rsmith added inline comments. Comment at: clang/include/clang/Serialization/ASTReader.h:903-905 // A list of late parsed template function data. SmallVector LateParsedTemplates; Given the changes below, we shouldn't need this any more, and can instead use

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

Bdragon28 added inline comments. Comment at: clang/lib/Basic/Targets.cpp:361-362 return new LinuxTargetInfo(Triple, Opts); +case llvm::Triple::FreeBSD: + return new FreeBSDTargetInfo(Triple, Opts); case llvm::Triple::NetBSD: Bdragon28 wrote:

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

Bdragon28 added inline comments. Comment at: clang/lib/Basic/Targets.cpp:361-362 return new LinuxTargetInfo(Triple, Opts); +case llvm::Triple::FreeBSD: + return new FreeBSDTargetInfo(Triple, Opts); case llvm::Triple::NetBSD: emaste wrote: > L

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 288105. rahmanl added a comment. Fix failing clang test which used to check for the old ".bb_info" name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/ https://reviews.llvm.org/D85408 Files: clang/

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 288104. rahmanl edited the summary of this revision. rahmanl added a comment. Fix failing clang test which used to check for the old ".bb_info" name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/ htt

[PATCH] D86373: [analyzer] Add modeling for unique_ptr move constructor

vrnithinkumar marked an inline comment as done. vrnithinkumar added a comment. In D86373#2231605 , @NoQ wrote: > This is easier than D86293 because there's > no old value in the freshly constructed smart pointer, right? I

[PATCH] D82609: [PowerPC] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82609/new/ https://reviews.llvm.org/D82609 __

[PATCH] D86373: [analyzer] Add modeling for unique_ptr move constructor

vrnithinkumar marked an inline comment as done. vrnithinkumar added inline comments. Comment at: clang/test/Analysis/smart-ptr.cpp:295 + P->foo(); // No warning. +} NoQ wrote: > vrnithinkumar wrote: > > I was trying to test the below code. > > ``` > > void foo_

[PATCH] D86373: [analyzer] Add modeling for unique_ptr move constructor

vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:456 if (BR.isInteresting(ThisRegion) && IsArgValNull) { -OS << "Null pointer value move-assigned to "; +OS << "A null pointer value is moved

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

nickdesaulniers added a comment. Sorry! Thanks for fixing up OpenSSL! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69925/new/ https://reviews.llvm.org/D69925 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D86373: [analyzer] Add modeling for unique_ptr move constructor

vrnithinkumar updated this revision to Diff 288101. vrnithinkumar added a comment. - Refactoring to reuse common duplicated code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86373/new/ https://reviews.llvm.org/D86373 Files: clang/lib/StaticAnal

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_info section, instead of emitting special unary-encoded symbols.

rahmanl created this revision. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. rahmanl updated this revision to Diff 285826. rahmanl added a comment. rahmanl updated this revision to Diff 285828. rahmanl updated this revision to Diff 285830. Herald added a project:

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

emaste added a comment. It looks like this conflicts with OpenSSL's compiler version check - https://svnweb.freebsd.org/changeset/base/364822 - https://lists.freebsd.org/pipermail/svn-src-all/2020-August/201804.html We've fixed it in FreeBSD and the change "should" happen upstream, but somethin

[PATCH] D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:2479-2483 +/// Declaration of functions visible in clang::CodeGen namespace, to +/// be used by target specific specializations of CGOpenMPRuntimeGPU. + +Fie

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

leonardchan added inline comments. Comment at: llvm/include/llvm/IR/FixedPointBuilder.h:171-172 +// lossless, except for overflow to infinity which is unlikely. +return B.CreateFMul(Result, +ConstantFP::get(DstTy, std::pow(2, -(int)SrcSema.getScale(; + }

[PATCH] D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN

saiislam updated this revision to Diff 288072. saiislam added a comment. 1. Reformarting 2. Comments 3. Reduced scope of specialized PrePostActionTy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86097/new/ https://reviews.llvm.org/D86097 Files:

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

miyuki updated this revision to Diff 288068. miyuki edited the summary of this revision. miyuki set the repository for this revision to rG LLVM Github Monorepo. miyuki added a comment. Herald added a subscriber: wenlei. 1. Also update bfdot 2. Add auto-upgrade for old intrinsics Repository: rG

[PATCH] D86649: Fix for assertion failure on PR46865

Sunil_Srivastava created this revision. Sunil_Srivastava added reviewers: rsmith, erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. Sunil_Srivastava requested review of this revision. This is a proposed fix for the crash of PR46865. Repository: rG LLVM Github M

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante added a comment. In D86559#2239013 , @aaron.ballman wrote: > I'd like to understand your reasoning for ignore + diagnose as opposed to > count attrs (+ optionally diagnose) or other strategies. I can see pros and > cons to basically anything we

[PATCH] D86488: [X86] Default to -mtune=generic unless -march is passed to the driver. Add TuneCPU to the AST serialization

craig.topper added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:395 CHECK_TARGET_OPT(CPU, "target CPU"); +CHECK_TARGET_OPT(TuneCPU, "tune CPU"); + } erichkeane wrote: > What does this string do? Does there have to be a test for it

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

zequanwu added inline comments. Comment at: clang/test/SemaCXX/ms_no_dynamic_cast.cpp:1 +// RUN: %clang_cl %s /GR- -fsyntax-only 2>&1 | FileCheck %s + hans wrote: > When using %clang_cl, the source file should always come after a "--", > otherwise if for example

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

zequanwu updated this revision to Diff 288062. zequanwu marked 3 inline comments as done. zequanwu added a comment. Address cmments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86369/new/ https://reviews.llvm.org/D86369 Files: clang/include/cl

[PATCH] D86169: Initial support for letting plugins perform custom parsing of attribute arguments.

aaron.ballman added a comment. In D86169#2236457 , @jonathan.protzenko wrote: > Thanks for the review! > > Regarding Declarator: I briefly mentioned something related in the details > section... actually maybe you can tell me what's the best approach her

[PATCH] D86488: [X86] Default to -mtune=generic unless -march is passed to the driver. Add TuneCPU to the AST serialization

erichkeane added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:395 CHECK_TARGET_OPT(CPU, "target CPU"); +CHECK_TARGET_OPT(TuneCPU, "tune CPU"); + } What does this string do? Does there have to be a test for it? CHANGES SINCE LAST

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

Mordante marked 4 inline comments as done. Mordante added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1726 + } + }]; +} aaron.ballman wrote: > Something else we should document is what our behavior is when the attribute > is not immediat

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

vrnithinkumar marked 2 inline comments as done. vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:483 +llvm::raw_ostream &OS) { + BR.markInteresting(T

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG19e883fc5988: [SVE] Remove calls to VectorType::getNumElements from clang (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82582/new/ h

[clang] 19e883f - [SVE] Remove calls to VectorType::getNumElements from clang

Author: Christopher Tetreault Date: 2020-08-26T11:12:26-07:00 New Revision: 19e883fc59887e98a49ec03557ad2b6bc5537e03 URL: https://github.com/llvm/llvm-project/commit/19e883fc59887e98a49ec03557ad2b6bc5537e03 DIFF: https://github.com/llvm/llvm-project/commit/19e883fc59887e98a49ec03557ad2b6bc5537e

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

vrnithinkumar updated this revision to Diff 288048. vrnithinkumar marked an inline comment as done. vrnithinkumar added a comment. - Removing unnecessary notetags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86027/new/ https://reviews.llvm.org/D8

[clang] eed0af6 - [clang] Exclude invalid destructors from lookups.

Author: Adam Czachorowski Date: 2020-08-26T19:29:30+02:00 New Revision: eed0af6179ca4fe9e60121e0829ed8d3849b1ce5 URL: https://github.com/llvm/llvm-project/commit/eed0af6179ca4fe9e60121e0829ed8d3849b1ce5 DIFF: https://github.com/llvm/llvm-project/commit/eed0af6179ca4fe9e60121e0829ed8d3849b1ce5.d

[PATCH] D86624: [clang] Exclude invalid destructors from lookups.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeed0af6179ca: [clang] Exclude invalid destructors from lookups. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D86376: [HIP] Simplify kernel launching

tra added a comment. In D86376#2239391 , @yaxunl wrote: > For example, in HIP program, there is a kernel `void foo(int*)`. If a C++ > program wants to launch it, the desirable way is > > void foo(int*); > hipLaunchKernel(foo, grids, blocks, args, shme

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

MaskRay added inline comments. Comment at: clang/test/Preprocessor/init-zos.c:4 + +// S390X-ZOS-GNUXX:#define _EXT 1 +// S390X-ZOS:#define _LONG_LONG 1 --match-full-lines is different from --match-full-lines --strict-whitespace. You can freely add leading and t

[PATCH] D86636: [SyntaxTree] Refactor `NodeRole`s

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:156 // Roles specific to particular node kinds. - OperatorExpression_operatorToken, - UnaryOperatorExp

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski added a comment. @andwar is my Phabricator alter-ego. Apologies for the confusion - I had my Arcanist misconfigured. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86089/new/ https://reviews.llvm.org/D86089 _

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

andwar updated this revision to Diff 288018. andwar added a comment. - Canonicalised FLANG_BUILD_NEW_DRIVER in flang/test/CMakeLists.txt and updated the LIT config scripts accordingly - Implemented proper handling of `-emit-obj` (via diagnostics) in CompilerInvocation.cpp - Removed members from

[PATCH] D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc3d4743277b: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API (authored by eduucaldas). Repository: rG LLVM Github Monorepo

[clang] dc3d474 - [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API

Author: Eduardo Caldas Date: 2020-08-26T16:46:19Z New Revision: dc3d4743277b47c0bc8cddbeb4b5e265252ee304 URL: https://github.com/llvm/llvm-project/commit/dc3d4743277b47c0bc8cddbeb4b5e265252ee304 DIFF: https://github.com/llvm/llvm-project/commit/dc3d4743277b47c0bc8cddbeb4b5e265252ee304.diff LOG

[clang] ed07e1f - [SystemZ/ZOS] Add header file to encapsulate use of

Author: Kai Nacke Date: 2020-08-26T12:44:30-04:00 New Revision: ed07e1fe0ffdb2c1dbff26ff4cf7558e0c419737 URL: https://github.com/llvm/llvm-project/commit/ed07e1fe0ffdb2c1dbff26ff4cf7558e0c419737 DIFF: https://github.com/llvm/llvm-project/commit/ed07e1fe0ffdb2c1dbff26ff4cf7558e0c419737.diff LOG

[PATCH] D83472: [SystemZ/ZOS] Add header file to encapsulate use of

This revision was automatically updated to reflect the committed changes. Closed by commit rGed07e1fe0ffd: [SystemZ/ZOS] Add header file to encapsulate use of (authored by Kai). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://

[PATCH] D86581: [clang-format] Handle shifts within conditions

Saldivarcher added a comment. MyDeveloperDay, I added your tests. Sorry to step on your toes, I didn't know there was a patch open for this already :(. Yeah, JakeMerdichAMD, it's kinda tough to handle those types of cases without some sort of parsing. I'm glad you're working on that, and my cod

[PATCH] D86581: [clang-format] Handle shifts within conditions

Saldivarcher updated this revision to Diff 288013. Saldivarcher added a comment. Added some more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86581/new/ https://reviews.llvm.org/D86581 Files: clang/lib/Format/TokenAnnotator.cpp clang/u

[PATCH] D85431: [analyzer] Implement a new checker ThreadPrimitivesChecker

ASDenysPetrov abandoned this revision. ASDenysPetrov added a comment. Guys! I've moved my work to PthreadLockChecker https://reviews.llvm.org/D85984. You are welcome to look at it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85431/new/ https://reviews.llvm.org/D85431 ___

[PATCH] D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API

eduucaldas updated this revision to Diff 288010. eduucaldas added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86600/new/ https://reviews.llvm.org/D86600 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/

[PATCH] D86376: [HIP] Improve kernel launching latency

yaxunl added a comment. In D86376#2236704 , @tra wrote: > > It's still suspiciously high. AFAICT, config/push/pull is just an std::vector > push/pop. It should not take *that* long. Few function calls should not lead > to microseconds of overhead, o

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski added a comment. @CarolineConcatto - thank you for working on this! @all, thank you for your reviews, this is much appreciated! While Carol is away, I'll try my best to address all the outstanding comments. I will also update the patch accordingly. I've identified a few small issues

[PATCH] D85485: Fix quiet mode in git-clang-format

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG294e1900f281: Fix quiet mode in git-clang-format (authored by Gvald, committed by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES

[clang] 294e190 - Fix quiet mode in git-clang-format

Author: Gi Vald Date: 2020-08-26T18:15:52+02:00 New Revision: 294e1900f281f35aff0362232225e85c2e551e55 URL: https://github.com/llvm/llvm-project/commit/294e1900f281f35aff0362232225e85c2e551e55 DIFF: https://github.com/llvm/llvm-project/commit/294e1900f281f35aff0362232225e85c2e551e55.diff LOG:

[PATCH] D85736: [Sema][AArch64] Support arm_sve_vector_bits attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. Comment at: clang/include/clang/AST/Type.h:3228 +SveFixedLengthDataVector, +/// is AArch64 SVE fixed-length predicate v

[PATCH] D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock

ASDenysPetrov updated this revision to Diff 287997. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. Added support of: - std::timed_mutex - std::recursive_timed_mutex - std::shared_mutex - std::shared_timed_mutex CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D84603: Thread safety analysis: More consistent warning message

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:1644 if (!LDat) { - Analyzer->Handler.handleMutexNotHeld("", D, POK, Cp.toString(), - LK_Shared, Loc); + Analyzer->Handler.handleMutexNotH

[PATCH] D77219: UBSan ␇ runtime

jfb abandoned this revision. jfb added a comment. Herald added a subscriber: dang. I don't think the world is ready for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77219/new/ https://reviews.llvm.org/D77219

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

ebevhan created this revision. ebevhan added reviewers: leonardchan, rjmccall. Herald added subscribers: llvm-commits, cfe-commits, bjope. Herald added projects: clang, LLVM. ebevhan requested review of this revision. The patch adds the required methods to FixedPointBuilder for converting between

[PATCH] D86631: [Fixed Point] Add fixed-point to floating point cast types and consteval.

ebevhan created this revision. ebevhan added reviewers: leonardchan, rjmccall. Herald added subscribers: bjope, martong. Herald added a project: clang. ebevhan requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86631 Files: clang/include/clang/AS

[PATCH] D86622: Fix failing tests after VCTOOLSDIR change

aganea added a comment. I've pushed one more fix: rG33ce275fc156c8b015acfad918937028b2cc235c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86622/new/ https://reviews.llvm.org/D8

[clang] 33ce275 - [Clang] Fix tests following rG087047144210

Author: Alexandre Ganea Date: 2020-08-26T11:32:46-04:00 New Revision: 33ce275fc156c8b015acfad918937028b2cc235c URL: https://github.com/llvm/llvm-project/commit/33ce275fc156c8b015acfad918937028b2cc235c DIFF: https://github.com/llvm/llvm-project/commit/33ce275fc156c8b015acfad918937028b2cc235c.dif

  1   2   >