[PATCH] D89490: Introduce __attribute__((darwin_abi))

mstorsjo added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.h:876 SDValue LowerAAPCS_VASTART(SDValue Op, SelectionDAG &DAG) const; + SDValue LowerAAPCSFromDarwin_VASTART(SDValue Op, SelectionDAG &DAG) const; SDValue LowerDarwin_VASTART(SDValue O

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added inline comments. Comment at: llvm/lib/AsmParser/LLParser.cpp:2147 +CC = CallingConv::Tail; +break; case lltok::kw_cc: { Again here this "big" diff is a result of clang-format. We can see that "kw_aarch64_sve_vector_pcs" has been "clang-f

[PATCH] D89360: Treat constant contexts as being in the default rounding mode.

sepavloff added a comment. Probably there is an issue with code generation. The source: constexpr float func_01(float x, float y) { return x + y; } float V1 = func_01(1.0F, 0x0.01p0F); compiled with '-frounding-math' must produce dynamic initializer. It however is evaluated at

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet updated this revision to Diff 298548. aguinet added a comment. Fix one clang-tidy warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89490/new/ https://reviews.llvm.org/D89490 Files: clang/include/clang-c/Index.h clang/include/clang

[PATCH] D89490: Introduce __attribute__((darwin_abi))

mstorsjo added inline comments. Comment at: llvm/lib/IR/AsmWriter.cpp:379 +Out << "aarch64_darwincc"; +break; case CallingConv::SPIR_FUNC: Out << "spir_func"; break; aguinet wrote: > mstorsjo wrote: > > The new code here has a different indentation

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added inline comments. Comment at: llvm/lib/IR/AsmWriter.cpp:379 +Out << "aarch64_darwincc"; +break; case CallingConv::SPIR_FUNC: Out << "spir_func"; break; mstorsjo wrote: > The new code here has a different indentation than the rest; the

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:52 AllowedTypes( utils::options::parseStringList(Options.get("AllowedTypes", ""))) {} flx wrote: > lebedev.ri wrote: > >

[PATCH] D89025: [RISCV] Add -mtune support

This revision was automatically updated to reflect the committed changes. Closed by commit rGcfa7094e49cf: [RISCV] Add -mtune support (authored by Kito Cheng ). Herald added a subscriber: NickHung. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] cfa7094 - [RISCV] Add -mtune support

Author: Kito Cheng Date: 2020-10-16T13:55:08+08:00 New Revision: cfa7094e49cfb7e37a84c0aa57c85c64c0581d17 URL: https://github.com/llvm/llvm-project/commit/cfa7094e49cfb7e37a84c0aa57c85c64c0581d17 DIFF: https://github.com/llvm/llvm-project/commit/cfa7094e49cfb7e37a84c0aa57c85c64c0581d17.diff LO

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 298546. LuoYuanke added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/clang/Basic/BuiltinsX86_64.def clang/lib/Headers/am

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

rsmith marked 3 inline comments as done. rsmith added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5939 +ElemTy = TryToFixInvalidVariablyModifiedType(ElemTy, Context, + SizeIsNegative, Oversized); +if (ElemTy.isN

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-copy-initialization.cpp:409 + +namespace std { + Could you add a

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

catskul added a comment. In D14484#2246171 , @FStefanni wrote: > Hi to all, > > I am also interested to this option, since match my personal style, but more > important, in my experience, this kind of formatting is very used. > I hope it will be implement

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

efriedma added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2278 ArraySize, &SizeVal, Diagnoser, - (S.LangOpts.GNUMode || S.LangOpts.OpenCL) ? Sema::AllowFold -: Sema::NoFold); + S.LangOpts.OpenCL ? Sema

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

efriedma added a comment. Also update the documentation? See https://clang.llvm.org/docs/UsersManual.html#differences-between-various-standard-modes . Comment at: clang/lib/Sema/SemaDecl.cpp:5939 +ElemTy = TryToFixInvalidVariablyModifiedType(ElemTy, Context, +

[PATCH] D89372: [OpenCL] Remove unused extensions

jvesely added a comment. In D89372#2332997 , @Anastasia wrote: > In D89372#2332853 , @jvesely wrote: > >> `cl_khr_byte_addressable_stores` changes language semantics. without it, >> pointer dereferences of types sm

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

rsmith created this revision. rsmith added a reviewer: eli.friedman. Herald added a project: clang. rsmith requested review of this revision. Old GCC used to aggressively fold VLAs to constant-bound arrays at block scope in GNU mode. That's non-conforming, and more modern versions of GCC only do t

[clang-tools-extra] cc175c2 - Support ObjC in IncludeInserter

Author: Alexander Kornienko Date: 2020-10-16T04:12:32+02:00 New Revision: cc175c2cc8e638462bab74e0781e06f9b6eb5017 URL: https://github.com/llvm/llvm-project/commit/cc175c2cc8e638462bab74e0781e06f9b6eb5017 DIFF: https://github.com/llvm/llvm-project/commit/cc175c2cc8e638462bab74e0781e06f9b6eb5017

[PATCH] D89276: Support ObjC in IncludeInserter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc175c2cc8e6: Support ObjC in IncludeInserter (authored by alexfh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D89441: RFC: Potential fixes to function-instrument=xray-never

ianlevesque updated this revision to Diff 298534. ianlevesque added a comment. Apply the fix in XRayInstrumentation, add test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89441/new/ https://reviews.llvm.org/D89441 Files: llvm/lib/CodeGen

[PATCH] D89488: FileManager: Shrink FileEntryRef to the size of a pointer

dexonsmith updated this revision to Diff 298530. dexonsmith retitled this revision from "WIP: FileManager: Shrink FileEntryRef to the size of a pointer" to "FileManager: Shrink FileEntryRef to the size of a pointer". dexonsmith added a comment. Rebase on top of https://reviews.llvm.org/D89521 to

[PATCH] D89521: FileManager: Reorder declarations of FileEntry and FileEntryRef, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. This reduces noise in a future patch, but shouldn't change anything otherwise. https://reviews.llvm.org/D89521 Files: clang/include/clang

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

rsmith created this revision. rsmith added reviewers: Anastasia, bader, yaxunl. Herald added subscribers: kerbowa, nhaehnle, jvesely. Herald added a project: clang. rsmith requested review of this revision. Permitting non-standards-driven "do the best you can" constant-folding of array bounds is p

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a comment. In D89177#2332675 , @beanz wrote: > In D89177#2332627 , @ldionne wrote: > >> That isn't what I meant. It's entirely okay for the runtimes to be driven >> via `AddExternalProject` like the r

[clang] fc031d2 - Switch the default of VerifyIntegerConstantExpression from constant

Author: Richard Smith Date: 2020-10-15T16:58:47-07:00 New Revision: fc031d29bea856f2b91a250fd81c5f9fb79dbe07 URL: https://github.com/llvm/llvm-project/commit/fc031d29bea856f2b91a250fd81c5f9fb79dbe07 DIFF: https://github.com/llvm/llvm-project/commit/fc031d29bea856f2b91a250fd81c5f9fb79dbe07.diff

[PATCH] D89484: [AMDGPU][HIP] Switch default DWARF version to 5

t-tye accepted this revision. t-tye added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89484/new/ https://reviews.llvm.org/D89484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89488: WIP: FileManager: Shrink FileEntryRef to the size of a pointer

dexonsmith updated this revision to Diff 298517. dexonsmith added a comment. Peeled off the clangd change into https://reviews.llvm.org/D89514 and rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89488/new/ https://reviews.llvm.org/D89488 Files: clang/include/clang/Basic/FileMa

[PATCH] D89514: clangd: Stop calling FileEntryRef::FileEntryRef

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added subscribers: usaxena95, ributzka, kadircet. dexonsmith requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. In `ReplayPreamble::replay`, use `getFileRef` instead of `getFile`, and

[PATCH] D89488: WIP: FileManager: Shrink FileEntryRef to the size of a pointer

dexonsmith updated this revision to Diff 298508. dexonsmith added a comment. Removing some noise from the patch that I missed in the last update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89488/new/ https://reviews.llvm.org/D89488 Files: clang-tools-extra/clangd/ParsedAST.cpp c

[clang] 273c299 - [PM/CC1] Add -f[no-]split-cold-code CC1 option to toggle splitting

Author: Vedant Kumar Date: 2020-10-15T23:13:33Z New Revision: 273c299d5d649a0222fbde03c9a41e41913751b4 URL: https://github.com/llvm/llvm-project/commit/273c299d5d649a0222fbde03c9a41e41913751b4 DIFF: https://github.com/llvm/llvm-project/commit/273c299d5d649a0222fbde03c9a41e41913751b4.diff LOG:

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG273c299d5d64: [PM/CC1] Add -f[no-]split-cold-code CC1 option to toggle splitting (authored by vsk, committed by compnerd). Repository: rG LLVM Git

[PATCH] D89508: SourceManager: getFileEntryRefForID => getNonBuiltinFilenameForID, NFC

dexonsmith added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:729-730 if (const SrcMgr::SLocEntry *Entry = getSLocEntryForFile(FID)) if (auto *Content = Entry->getFile().getContentCache()) if (Content && Content->OrigEntry) +return Entry->

[PATCH] D89488: WIP: FileManager: Shrink FileEntryRef to the size of a pointer

dexonsmith updated this revision to Diff 298503. dexonsmith added a comment. Rebased on top of https://reviews.llvm.org/D89508. Still some things to split apart, but the bug is fixed and this is a fair bit smaller. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89488/new/ https://review

[PATCH] D74130: [clang] fix consteval call in default arguments

rsmith added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2928 + SmallVectorImpl &ParamInfo, + SourceLocation &EllipsisLoc, bool InConstantConstext = false); void ParseBracketDeclarator(Declarator &D); Comment a

[PATCH] D89407: [clang-tidy] Add scoped enum constants to identifier naming check

Eugene.Zelenko added a comment. I think will be good idea to add test for suffix/prefix too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89407/new/ https://reviews.llvm.org/D89407 ___ cfe-commits maili

[PATCH] D89488: WIP: FileManager: Shrink FileEntryRef to the size of a pointer

dexonsmith added a comment. In D89488#2332998 , @dexonsmith wrote: > I'd still appreciate feedback on the direction, but > `clang/test/ClangScanDeps/modules-full.cpp` is failing (getting > `""` listed twice under `"file-deps"` for each translation unit)

[PATCH] D89508: SourceManager: getFileEntryRefForID => getNonBuiltinFilenameForID, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, Bigcheese. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. `SourceManager::getFileEntryRefForID`'s remaining callers just want the filename component, which is coming from the `FileInfo`. Rep

[PATCH] D89507: SourceManager: Change SourceManager::isMainFile to take a FileEntry, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. `SourceManager::isMainFile` does not use the filename, so it doesn't need the full `FileEntryRef`; in fact, it's misleading to take the name b

[PATCH] D89503: SourceManager: Factor out helpers for common SLocEntry lookup pattern, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Add helpers `getSLocEntryOrNull`, which handles the `Invalid` logic around `getSLocEntry`, and `getSLocEntryForFile`, which also checks for

[clang] 5a33859 - [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

Author: Fangrui Song Date: 2020-10-15T15:14:38-07:00 New Revision: 5a338599fbaa805587227779bde0a9986cb4646d URL: https://github.com/llvm/llvm-project/commit/5a338599fbaa805587227779bde0a9986cb4646d DIFF: https://github.com/llvm/llvm-project/commit/5a338599fbaa805587227779bde0a9986cb4646d.diff

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a338599fbaa: [CGBuiltin] Respect asm labels and redefine_extname for builtins with… (authored by MaskRay). Repository: rG LLVM Github Monorepo C

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

MaskRay updated this revision to Diff 298480. MaskRay edited the summary of this revision. MaskRay added a comment. Add an example about inconsistency. Elaborate on the limitation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88712/new/ https://re

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

MaskRay added a comment. In D88712#2333294 , @rsmith wrote: > If the answer is that we consider (2) to be incorrect, but that this is only > a partial step in that direction, I think that's fine -- that's enough that > we can know where the bug is if / w

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek added a comment. In D85802#2333247 , @rsmith wrote: > In D85802#2333105 , @leonardchan > wrote: > >> In D85802#2332895 , @phosek wrote: >> >>> In D85802#2332808

[clang] 5fbab40 - [MS] Apply `inreg` to AArch64 sret parms on instance methods

Author: Reid Kleckner Date: 2020-10-15T14:54:42-07:00 New Revision: 5fbab4025eb57b12f2842ab188ff07a110708e1d URL: https://github.com/llvm/llvm-project/commit/5fbab4025eb57b12f2842ab188ff07a110708e1d DIFF: https://github.com/llvm/llvm-project/commit/5fbab4025eb57b12f2842ab188ff07a110708e1d.diff

[PATCH] D89362: [MS] Apply `inreg` to AArch64 sret parms on instance methods

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5fbab4025eb5: [MS] Apply `inreg` to AArch64 sret parms on instance methods (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D74130: [clang] fix consteval call in default arguements

keryell added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:16329 + /// If we can't handle immediate invocations yet. add them to the outer scope. + /// This occurs for default argument of lambdas as we can't know if the lambda Repository: r

[PATCH] D89362: [MS] Apply `inreg` to AArch64 sret parms on instance methods

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Makes a lot more sense now. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89362/new/ https://reviews.llvm.org/D89362

[PATCH] D89362: [MS] Apply `inreg` to AArch64 sret parms on instance methods

rnk updated this revision to Diff 298473. rnk added a comment. - simplify some more Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89362/new/ https://reviews.llvm.org/D89362 Files: clang/lib/CodeGen/MicrosoftCXXABI.cpp clang/test/CodeGenCXX/mic

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. If the answer is that we consider (2) to be incorrect, but that this is only a partial step in that direction, I think that's fine -- that's enough that we can know where the bug is if / when

[PATCH] D89498: HeaderSearch: Simplify use of FileEntryRef in HeaderSearch::LookupFile, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Simplify `HeaderSearch::LookupFile`. Instead of deconstructing a `FileEntryRef` into a name and `FileEntry` and then rebuilding it later, use

[clang] e384e94 - Revert "[HIP] Change default --gpu-max-threads-per-block value to 1024"

Author: Yaxun (Sam) Liu Date: 2020-10-15T17:25:55-04:00 New Revision: e384e94fbe7c1d5c89fcdde33ffda04e9802c2ce URL: https://github.com/llvm/llvm-project/commit/e384e94fbe7c1d5c89fcdde33ffda04e9802c2ce DIFF: https://github.com/llvm/llvm-project/commit/e384e94fbe7c1d5c89fcdde33ffda04e9802c2ce.dif

[clang] 79829a4 - Revert "[clang] Add -fc++-abi= flag for specifying which C++ ABI to use"

Author: Leonard Chan Date: 2020-10-15T14:24:38-07:00 New Revision: 79829a47040512fe54001db839ac59146ca55aec URL: https://github.com/llvm/llvm-project/commit/79829a47040512fe54001db839ac59146ca55aec DIFF: https://github.com/llvm/llvm-project/commit/79829a47040512fe54001db839ac59146ca55aec.diff

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

rsmith added a comment. In D85802#2333105 , @leonardchan wrote: > In D85802#2332895 , @phosek wrote: > >> In D85802#2332808 , @rnk wrote: >> >>> Would "f[no-]fuchsia-c++-abi-

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI and add clang and llvm option

Xiangling_L added a comment. I am wondering can we split the option related changes to a separate patch for reviews? That would make current patch a bit easier to review and faster to be committed as two small pieces. If it's possible, I am thinking we can try to split it up to the following tw

[PATCH] D89446: [WebAssembly] Prototype i8x16.popcnt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tlively marked an inline comment as done. Closed by commit rG1992e30c2d75: [WebAssembly] Prototype i8x16.popcnt (authored by tlively). Repository: rG LLVM Github Mon

[clang] 1992e30 - [WebAssembly] Prototype i8x16.popcnt

Author: Thomas Lively Date: 2020-10-15T21:18:22Z New Revision: 1992e30c2d751f6f1f6ad5190f84e37dece04f7f URL: https://github.com/llvm/llvm-project/commit/1992e30c2d751f6f1f6ad5190f84e37dece04f7f DIFF: https://github.com/llvm/llvm-project/commit/1992e30c2d751f6f1f6ad5190f84e37dece04f7f.diff LOG:

[PATCH] D89496: [Format/ObjC] Correctly handle base class with lightweight generics and protocol

benhamilton created this revision. benhamilton added reviewers: sammccall, MyDeveloperDay. Herald added a project: clang. Herald added a subscriber: cfe-commits. benhamilton requested review of this revision. ClangFormat does not correctly handle an Objective-C interface declaration with both ligh

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet updated this revision to Diff 298461. aguinet added a comment. Update format + llvm tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89490/new/ https://reviews.llvm.org/D89490 Files: clang/include/clang-c/Index.h clang/include/clang

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

kadircet updated this revision to Diff 298460. kadircet added a comment. - As discussed offline moving with compact version of the output, while preserving names starting with an `_` to be leaves. This is also ready for an implementation-wise review now. Repository: rG LLVM Github Monorepo

[clang] 65cb4fd - [libTooling] Change `after` range-selector to operate only on source ranges

Author: Yitzhak Mandelbaum Date: 2020-10-15T20:58:30Z New Revision: 65cb4fdd69f43b6c39a8e4ca27b509284b11d807 URL: https://github.com/llvm/llvm-project/commit/65cb4fdd69f43b6c39a8e4ca27b509284b11d807 DIFF: https://github.com/llvm/llvm-project/commit/65cb4fdd69f43b6c39a8e4ca27b509284b11d807.diff

[PATCH] D89468: [libTooling] Change `after` range-selector to operate only on source ranges

This revision was automatically updated to reflect the committed changes. Closed by commit rG65cb4fdd69f4: [libTooling] Change `after` range-selector to operate only on source ranges (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

fhahn added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:1096 static_cast(Tok.getAnnotationValue()); - IdentifierInfo *PragmaNameInfo = Info->PragmaName.getIdentifierInfo(); nit: unrelated change? Comment at: clang/lib

[PATCH] D89446: [WebAssembly] Prototype i8x16.popcnt

tlively marked an inline comment as done. tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:117 +TARGET_BUILTIN(__builtin_wasm_popcnt, "V16ScV16Sc", "nc", "simd128") + aheejin wrote: > - Even if there's only one vector

[PATCH] D89446: [WebAssembly] Prototype i8x16.popcnt

tlively updated this revision to Diff 298457. tlively added a comment. - Update builtin function name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89446/new/ https://reviews.llvm.org/D89446 Files: clang/include/clang/Basic/BuiltinsWebAssembly.d

[clang] 68f116a - PR47864: Fix assertion in pointer-to-member emission if there are

Author: Richard Smith Date: 2020-10-15T13:51:51-07:00 New Revision: 68f116aa23434b577743307c487b2edf037fca4c URL: https://github.com/llvm/llvm-project/commit/68f116aa23434b577743307c487b2edf037fca4c DIFF: https://github.com/llvm/llvm-project/commit/68f116aa23434b577743307c487b2edf037fca4c.diff

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

MaskRay added a subscriber: zatrazz. MaskRay added a comment. In D88712#2333030 , @rsmith wrote: > I worry that we're chasing after the implementation details of GCC here. It > seems self-contradictory to say all three of these things at once: > > 1. The

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added a comment. In D89490#2333073 , @mstorsjo wrote: > I see that the llvm side of the patch lacks tests? Sorry I forgot to add them indeed... I will push a patch with these. About the formatting, git clang-format HEAD~1 did this, and it looks b

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

joerg added a comment. Disabling builtin handling when `asm` is enabled would be a major annoyance for NetBSD. The interaction between symbol renaming and TLI is complicated. There are cases where it would make perfect sense and others were it would be harmful. Example of the latter is the way

[PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

rsmith added inline comments. Comment at: cfe/trunk/lib/Sema/SemaType.cpp:2067 + S.LangOpts.GNUMode || + S.LangOpts.OpenCL).isInvalid(); } This looks wrong to me. The OpenCL rule

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. In D85802#2332895 , @phosek wrote: > In D85802#2332808 , @rnk wrote: > >> Would "f[no-]fuchsia-c++-abi-extensions" (or shorter, -ffuchsia-c++-abi) do >> the trick? I know it doesn't map

[PATCH] D89490: Introduce __attribute__((darwin_abi))

mstorsjo added a comment. I see that the llvm side of the patch lacks tests? Comment at: llvm/lib/IR/AsmWriter.cpp:379 +Out << "aarch64_darwincc"; +break; case CallingConv::SPIR_FUNC: Out << "spir_func"; break; The new code here has a different i

[clang] d1beb95 - [AMDGPU] gfx1032 target

Author: Stanislav Mekhanoshin Date: 2020-10-15T12:41:18-07:00 New Revision: d1beb95d1241ec50bdf19db351d273374a146a4a URL: https://github.com/llvm/llvm-project/commit/d1beb95d1241ec50bdf19db351d273374a146a4a DIFF: https://github.com/llvm/llvm-project/commit/d1beb95d1241ec50bdf19db351d273374a146a

[PATCH] D89484: [AMDGPU][HIP] Switch default DWARF version to 5

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89484/new/ https://reviews.llvm.org/D89484 _

[clang] 3f738d1 - Reland "[WebAssembly] v128.load{8,16,32,64}_lane instructions"

Author: Thomas Lively Date: 2020-10-15T19:32:34Z New Revision: 3f738d1f5e2d657993a51ca3fe56585268025d89 URL: https://github.com/llvm/llvm-project/commit/3f738d1f5e2d657993a51ca3fe56585268025d89 DIFF: https://github.com/llvm/llvm-project/commit/3f738d1f5e2d657993a51ca3fe56585268025d89.diff LOG:

[PATCH] D89475: [SemaObjC] Fix composite pointer type calculation for `void*` and pointer to lifetime qualified ObjC pointer type

This revision was automatically updated to reflect the committed changes. Closed by commit rG351317167e2b: [SemaObjC] Fix composite pointer type calculation for `void*` and pointer to… (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 3513171 - [SemaObjC] Fix composite pointer type calculation for `void*` and pointer to lifetime qualified ObjC pointer type

Author: Erik Pilkington Date: 2020-10-15T15:21:01-04:00 New Revision: 351317167e2b28aad03f8e45e0ed0acbbff18c61 URL: https://github.com/llvm/llvm-project/commit/351317167e2b28aad03f8e45e0ed0acbbff18c61 DIFF: https://github.com/llvm/llvm-project/commit/351317167e2b28aad03f8e45e0ed0acbbff18c61.dif

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

rsmith added a comment. I worry that we're chasing after the implementation details of GCC here. It seems self-contradictory to say all three of these things at once: 1. The frontend function `foo` has known, builtin semantics X. (Eg, we'll use those semantics in the frontend.) 2. The symbol `f

[PATCH] D89445: clang/Basic: Remove ContentCache::getRawBuffer, NFC

dexonsmith updated this revision to Diff 298434. dexonsmith added a comment. Fix a compile error (I forgot to run `check-clang-tools` before). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89445/new/ https://reviews.llvm.org/D89445 Files: clang-tools-extra/clang-tidy/ExpandModularHea

[PATCH] D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN

saiislam marked 3 inline comments as done. saiislam added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.cpp:175 + +void CGOpenMPRuntimeAMDGCN::emitSPMDKernelWrapper( +const OMPExecutableDirective &D, StringRef ParentName, JonChesterfiel

[PATCH] D89488: WIP: FileManager: Shrink FileEntryRef to the size of a pointer

dexonsmith planned changes to this revision. dexonsmith added a comment. I'd still appreciate feedback on the direction, but `clang/test/ClangScanDeps/modules-full.cpp` is failing (getting `""` listed twice under `"file-deps"` for each translation unit) so I'm marking this as needing changes.

[PATCH] D89372: [OpenCL] Remove unused extensions

Anastasia added a comment. In D89372#2332853 , @jvesely wrote: > `cl_khr_byte_addressable_stores` changes language semantics. without it, > pointer dereferences of types smaller than 32 bits are illegal. Ok, does it mean that we are missing to diagnose t

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet created this revision. aguinet added reviewers: t.p.northover, mstorsjo, thegameg. Herald added subscribers: llvm-commits, cfe-commits, arphaman, dexonsmith, steven_wu, hiraditya, kristof.beyls, krytarowski. Herald added a reviewer: aaron.ballman. Herald added projects: clang, LLVM. aguine

[PATCH] D89276: Support ObjC in IncludeInserter

alexfh accepted this revision. alexfh added a comment. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

vsk accepted this revision. vsk added a comment. Thank you! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D89488: WIP: FileManager: Shrink FileEntryRef to the size of a pointer

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added subscribers: usaxena95, ributzka, kadircet. dexonsmith requested review of this revision. This is a WIP patch to shrink FileEntryRef to the size of a pointer, posting for early feedback in case someone has some.

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek added a comment. In D85802#2332808 , @rnk wrote: > Would "f[no-]fuchsia-c++-abi-extensions" (or shorter, -ffuchsia-c++-abi) do > the trick? I know it doesn't map well onto our current internal option > representation, but I don't think the interna

[PATCH] D89453: Fix hidden-redecls.m test for some environments

kschwarz added a comment. Yes, I'll commit it tomorrow, thanks for the review @akyrtzi! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89453/new/ https://reviews.llvm.org/D89453 ___ cfe-commits mailing li

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

compnerd updated this revision to Diff 298425. compnerd added a comment. Herald added a subscriber: arichardson. Passes locally now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265 Files: clang/include/cla

[PATCH] D89360: Treat constant contexts as being in the default rounding mode.

sepavloff added a comment. As C++ case is much more complicated and we need a ruleset based on essential properties rather than implementation viewpoint, I am convinced that the solution based on manifestly constant-evaluated property is the best. Thank you for the discussion! Repository: r

[PATCH] D88498: [FPEnv] Apply dynamic rounding to function body only

sepavloff added a comment. Actually this solution also behaves wrong in some cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88498/new/ https://reviews.llvm.org/D88498 ___ cfe-commits mailing list c

[PATCH] D89372: [OpenCL] Remove unused extensions

jvesely added a comment. `cl_khr_byte_addressable_stores` changes language semantics. without it, pointer dereferences of types smaller than 32 bits are illegal. Even if all clang targets support this the macro should still be defined for backward compatibility. it would be useful if the commit

[PATCH] D89297: [clangd] Add a TestWorkspace utility

kadircet added a comment. This looks like a useful infra to have indeed, we currently don't have an easy way to setup a testcase that would require interactions between multiple files (e.g. a workspace), as you've noticed while working on callhierarchy tests (sorry for that). A couple of sugge

[PATCH] D89478: AMDGPU: Make sure both cc1 and cc1as process -m[no-]code-object-v3

This revision was automatically updated to reflect the committed changes. Closed by commit rG67f189e93ce3: Make sure both cc1 and cc1as process -m[no-]code-object-v3 (authored by kzhuravl). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorep

[clang] 67f189e - Make sure both cc1 and cc1as process -m[no-]code-object-v3

Author: Konstantin Zhuravlyov Date: 2020-10-15T14:03:26-04:00 New Revision: 67f189e93ce3c25db74697551a77831a72b34929 URL: https://github.com/llvm/llvm-project/commit/67f189e93ce3c25db74697551a77831a72b34929 DIFF: https://github.com/llvm/llvm-project/commit/67f189e93ce3c25db74697551a77831a72b349

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas updated this revision to Diff 298420. eduucaldas added a comment. Linting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88106/new/ https://reviews.llvm.org/D88106 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/lib/Tooling/Sy

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

rnk added a comment. Would "f[no-]fuchsia-c++-abi-extensions" (or shorter, -ffuchsia-c++-abi) do the trick? I know it doesn't map well onto our current internal option representation, but I don't think the internal representation is particularly good. I'd rather limit the user-visible driver in

[PATCH] D89475: [SemaObjC] Fix composite pointer type calculation for `void*` and pointer to lifetime qualified ObjC pointer type

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89475/new/ https://reviews.llvm.org/D89475 ___ cfe-commits mailing list cfe-commits

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

rjmccall added inline comments. Comment at: clang/include/clang/Basic/PartialDiagnostic.h:66 +return *this; + } + yaxunl wrote: > rjmccall wrote: > > Why are these template operators necessary? The LHS of the `<<` should > > convert to a base reference typ

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek added a comment. In D85802#2332766 , @rnk wrote: > In D85802#2331403 , @leonardchan > wrote: > >> Perhaps we can add some mechanism in Clang that determines which ABIs are >> supported for specific platform

  1   2   >