[clang] ddb0101 - Revert "[analyzer] RetainCountChecker: Add a suppression for OSSymbols."

Author: Artem Dergachev Date: 2021-02-09T23:44:33-08:00 New Revision: ddb01010b275c68deb7340ec32e0d1beaa9bbf13 URL: https://github.com/llvm/llvm-project/commit/ddb01010b275c68deb7340ec32e0d1beaa9bbf13 DIFF: https://github.com/llvm/llvm-project/commit/ddb01010b275c68deb7340ec32e0d1beaa9bbf13.dif

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:97 +/// `std::vector::iterator::difference_type` aka `ptrdiff_t`). +/// Therefore, the distance function will be +/// [&](size_t &Result) { Result = __end - __begin; } jdenny wr

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder added a comment. In D95536#2552258 , @aaron.ballman wrote: > In D95536#2551332 , @tbaeder wrote: > >> Any update on this? > > Thank you for the patch! Do you have some motivating examples of when this > wo

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

dyung added a comment. It also failed on the PS4 linux bot: http://lab.llvm.org:8014/#/builders/125/builds/125 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ https://reviews.llvm.org/D95915 __

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

tbaeder added a comment. Looks like this broke the tests because `-stdlib` is not a thing on Windows? Would passing a linux `-target x86_64-linux-gnu` be an appropriate fix for the tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ h

[PATCH] D90457: [clang][driver] Set LTO mode based on input files

tbaeder added a comment. I don't think `.bc` files are affected by this patch since they aren't `types::TY_Object` files, but I might misremember. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90457/new/ https://reviews.llvm.org/D90457 __

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6439b52088b: [clang][driver] Only warn once about invalid library values (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ ht

[clang] a6439b5 - [clang][driver] Only warn once about invalid library values

Author: Timm Bäder Date: 2021-02-10T06:19:52+01:00 New Revision: a6439b52088b1d58d8e7aa9891c9011648710593 URL: https://github.com/llvm/llvm-project/commit/a6439b52088b1d58d8e7aa9891c9011648710593 DIFF: https://github.com/llvm/llvm-project/commit/a6439b52088b1d58d8e7aa9891c9011648710593.diff LO

[PATCH] D96360: [CMake] Delete LLVM_RUNTIME_BUILD_ID_LINK_TARGETS

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96360/new/ https://reviews.llvm.org/D96360 ___ c

[PATCH] D93003: [libunwind][ELF] Hide unw_getcontext with LIBUNWIND_HIDE_SYMBOLS

rprichard added a subscriber: emaste. rprichard added a comment. emaste: Just a heads up in case FreeBSD is affected. FWIW, I noticed that libgcc_eh.a on FreeBSD 12.1 doesn't hide the `_Unwind_*` or `unw_*` symbols. The build system

[PATCH] D94476: [analyzer] Implement conversion from Clang diagnostics to PathDiagnostics.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Herald added a subscriber: nullptr.cpp. LGTM! As a side note, are we aware of anyone that uses short messages instead of the full length one? Comment at: clang/lib/An

[PATCH] D93003: [libunwind][ELF] Hide unw_getcontext with LIBUNWIND_HIDE_SYMBOLS

rprichard added inline comments. Comment at: libunwind/src/assembly.h:82 .globl SYMBOL_NAME(aliasname) SEPARATOR \ - WEAK_SYMBOL(aliasname) SEPARATOR \ + EXPORT_SYMBOL(SYMBOL_NAME(aliasname))

[PATCH] D93003: [libunwind][ELF] Hide unw_getcontext with LIBUNWIND_HIDE_SYMBOLS

rprichard updated this revision to Diff 322574. rprichard edited the summary of this revision. rprichard added a comment. Restore Mach-O alias fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93003/new/ https://reviews.llvm.org/D93003 Files:

[PATCH] D93222: [analyzer] Introduce MacroExpansionContext to libAnalysis

Szelethus added inline comments. Comment at: clang/include/clang/Analysis/MacroExpansionContext.h:105 + using MacroExpansionText = SmallString<40>; + using ExpansionMap = llvm::DenseMap; + using ExpansionRangeMap = llvm::DenseMap; Hmm, I'm by no means an exper

[PATCH] D93224: [analyzer] Use the MacroExpansionContext for macro expansions in plists

Szelethus accepted this revision. Szelethus added a comment. Herald added a subscriber: nullptr.cpp. Happy to see this mess go. It was obvious even after the first few hurdles that it wouldn't work out in the long term. Comment at: clang/test/Analysis/plist-macros-with-expansi

[clang] 66ac53f - [clang][cli] Fix gcc "enumeral and non-enumeral type in conditional expression" warning (NFC)

Author: Yang Fan Date: 2021-02-10T11:15:39+08:00 New Revision: 66ac53fe319be932d31ef96bdca34ad2b897cf04 URL: https://github.com/llvm/llvm-project/commit/66ac53fe319be932d31ef96bdca34ad2b897cf04 DIFF: https://github.com/llvm/llvm-project/commit/66ac53fe319be932d31ef96bdca34ad2b897cf04.diff LOG:

[PATCH] D93223: [analyzer] Create MacroExpansionContext member in AnalysisConsumer

Szelethus accepted this revision. Szelethus added a comment. Herald added a subscriber: nullptr.cpp. My no1. thought is that I wish the new functionality you're implementing was in the interface of the `Preprocessor`. I found, and still find it so hard to believe that you couldn't just retrieve

[PATCH] D93222: [analyzer] Introduce MacroExpansionContext to libAnalysis

Szelethus accepted this revision. Szelethus added a comment. Herald added a subscriber: nullptr.cpp. This is amazing. We longed for a sensible implementation for this for a long time. Really liking the unit tests as well! There are a number of inlines you didn't mark as done but seem to have ad

[PATCH] D96163: [analyzer] Add 12.0.0. release notes

Szelethus updated this revision to Diff 322550. Szelethus added a comment. Fix'd! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96163/new/ https://reviews.llvm.org/D96163 Files: clang/docs/ReleaseNotes.rst clang/docs/analyzer/checkers.rst Index: clang/docs/analyzer/checkers.rst =

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdenny added a comment. In D94973#2547383 , @jdoerfert wrote: > I have a single last comment/request. @jdenny I'll take it you finish the > review and accept as you see fit. @jdoerfert, if you've already reviewed everything and want to accept so this ca

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

pengfei commandeered this revision. pengfei edited reviewers, added: RKSimon; removed: pengfei. pengfei added a comment. @RKSimon Sure, with pleasure😊 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93179/new/ https://reviews.llvm.org/D93179 ___

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

rsanthir.quic added a comment. This is the second of three patches to address the following: https://bugs.llvm.org/show_bug.cgi?id=47828 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96381/new/ https://reviews.llvm.org/D96381 _

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

xiangzhangllvm added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:211-212 +IRBuilderBase &B, DomTreeUpdater &DTU, +LoopInfo &LI, Value *Row, Value *Col, +

[PATCH] D37538: [libc++] Remove problematic ADL in container implementations.

Quuxplusone added a comment. Everything in this PR is obsolete and/or fixed at this point, //except// for the change to , which as Eric said, fixes the lower-hanging fruit but sadly can't "ADL-proof" it completely. (Grepping for "ADL" in the git history of `libcxx/include/` will turn up a lot o

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

rsanthir.quic created this revision. rsanthir.quic added reviewers: apazos, t.p.northover, labrinea, pbarrio. Herald added subscribers: danielkiss, hiraditya, kristof.beyls. rsanthir.quic requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D96367: Partially Revert "scan-view: Remove Reporter.py and associated AppleScript files"

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok no problem! I'll try to find time to clean this up properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96367/new/ https://reviews.llvm.org/D96

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

MaskRay added a comment. Making -stdlib=libc++ not affect linker option for `-static` and `-static-pie` looks good to me, for the GNU toolchain. They are expected to pass `-lc++ -lc++abi` if they use separate `libc++abi.a`. Just specifying `-lc++abi` does not work with GNU ld and gold anyway. It

[PATCH] D86376: [HIP] Emit kernel symbol

yaxunl added a comment. In D86376#2552524 , @tra wrote: > In D86376#2552419 , @yaxunl wrote: > >> For triple chevron with kernel name, it is not needed. We only need >> indirection for a triple chevron with a funct

[PATCH] D96376: [CodeComplete] Member completion: heuristically resolve some dependent base exprs

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Today, inside a template, you can get completion for: F

[PATCH] D86376: [HIP] Emit kernel symbol

tra added a comment. In D86376#2552419 , @yaxunl wrote: > For triple chevron with kernel name, it is not needed. We only need > indirection for a triple chevron with a function pointer, in which case we do > not know its stub function at compile time. Th

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! One more more comment inline. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4534-4547 + InputKind DashX = FrontendOpts.DashX; + if (DashX.getFormat()

[PATCH] D96323: [clang][cli] NFC: Remove intermediate command line parsing functions

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96323/new/ https://reviews.llvm.org/D96323

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

ldionne added a comment. I think the root cause of the push back you're getting is that this is normally handled by vendors when they decide how they're going to ship libc++ on their platform or in their toolchain. For example, on Apple platforms, we ship `libc++.dylib`, and we make sure to re

[PATCH] D86376: [HIP] Emit kernel symbol

yaxunl added a comment. In D86376#2552066 , @tra wrote: > In D86376#2551298 , @yaxunl wrote: > >> Actually there is one issue with this approach. >> >> HIP have API's to launch kernels, which accept kernel as functi

[PATCH] D96274: [clang][cli] Generate and round-trip Diagnostic options

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! In D96274#2551206 , @probinson wrote: > I don't claim to be very familiar with this area but "round-trip" and "test" > would make me thi

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

rjmccall added a comment. The ultimate code-generation consequences of this feature aren't very generic, so we shouldn't let ourselves get caught up designing an extremely general feature that ultimately either doesn't do what we need it to do or doesn't actually work for any of the generalizat

[PATCH] D96328: [Clang, NewPM] Add KMSan support

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96328/new/ https://reviews.llvm.org/D96328 ___

[PATCH] D96367: Partially Revert "scan-view: Remove Reporter.py and associated AppleScript files"

tstellar created this revision. Herald added a subscriber: mgorny. tstellar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts some of commit dbb01536f6f49fa428f170e34466072ef439b3e9

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

dexonsmith added a comment. I have a couple of suggestions below to add to the mix (but I don't feel strongly about either of them, just adding them for consideration). In D92808#2552100 , @ahatanak wrote: > define void @test() { > %r = call i8* @f

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Please regroup tests and add release notes. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:1126 + + EXPECT_EQ(UnwrappedLines, Style.Short

[clang] d5d8c52 - PR48545: Access check the inherited constructor, not the inheriting

Author: Richard Smith Date: 2021-02-09T13:27:55-08:00 New Revision: d5d8c529abe65ce55c24b0333842bb31746a8bf8 URL: https://github.com/llvm/llvm-project/commit/d5d8c529abe65ce55c24b0333842bb31746a8bf8 DIFF: https://github.com/llvm/llvm-project/commit/d5d8c529abe65ce55c24b0333842bb31746a8bf8.diff

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:89 +#define BUILTIN(ID, TYPE, ATTRS) \ + {"__builtin_rvv_" #ID, TYPE, ATTRS, nullptr, ALL_LANGUAGES, nullptr}, +#include "clang/Basic/BuiltinsRISCV.de

[PATCH] D95536: [clang][sema] Note decl location on missing member

aaron.ballman added a comment. In D95536#2551332 , @tbaeder wrote: > Any update on this? Thank you for the patch! Do you have some motivating examples of when this would really add clarity to the diagnostic? I'm not opposed to the patch per se, but I'm

[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan updated this revision to Diff 322479. abhina.sreeskantharajan added a comment. Remove ARCMigrate change in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96363/new/ https://reviews.llvm.org/D96363 Files: clang/

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj updated this revision to Diff 322477. timwoj added a comment. Added release note entry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://reviews.llvm.org/D94500 Files: clang/docs/ReleaseNotes.rst clang/lib/Format/Unwrappe

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

HazardyKnusperkeks added a comment. Apart from my comments, this looks good to me and I really wonder why it hasn't been pushed. (I would directly use it!) Comment at: clang/include/clang/Format/Format.h:2821 MaxEmptyLinesToKeep == R.MaxEmptyLinesToKeep && +

[PATCH] D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics

rsanthir.quic updated this revision to Diff 322470. rsanthir.quic added a comment. Updated test name and checks performed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95655/new/ https://reviews.llvm.org/D95655 Files: clang/include/clang/Basic/arm_neon.td clang/lib/CodeGen/CGBuilti

[PATCH] D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

yaxunl marked 6 inline comments as done. yaxunl added a comment. In D85223#2551894 , @JonChesterfield wrote: > This works around the limitations of the binary format nvptx and amdgpu are > using in the compiler. It's the wrong place in the stack to fix i

[PATCH] D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics

t.p.northover added inline comments. Comment at: clang/test/CodeGen/aarch64-neon-sm4-sm3.c:5 + +// RUN: not %clang_cc1 -triple aarch64-linux-gnu -target-feature +neon \ +// RUN: -S -emit-llvm -o - %s 2>&1 | FileCheck --check-prefix=CHECK-NO-CRYPTO %s apazos wrot

[PATCH] D77811: [clangd] Implement semanticTokens modifiers

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:136 +// Whether D is const in a loose sense (should it be highlighted as such?) +bool isConst(const Decl *D) { + if (llvm::isa(D) || llvm::isa(D)) nridge wrote: > sammcca

[PATCH] D77811: [clangd] Implement semanticTokens modifiers

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:136 +// Whether D is const in a loose sense (should it be highlighted as such?) +bool isConst(const Decl *D) { + if (llvm::isa(D) || llvm::isa(D)) sammccall wrote: > nrid

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper

ldionne abandoned this revision. ldionne added a comment. Closing as this is superseded by D92725 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40259/new/ https://reviews.llvm.org/D40259 _

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper

ldionne commandeered this revision. ldionne added a reviewer: K-ballo. ldionne added a comment. Herald added a subscriber: jkorous. This is superseded by D92725 , so I'm going to commandeer and abandon this to clear up the review queue. Thanks for your contributi

[PATCH] D95706: [clangd] Expose more dependent-name detail via semanticTokens

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG59c1139d3ee1: [clangd] Expose more dependent-name detail via semanticTokens (authored by sammccall). Cha

[clang-tools-extra] 59c1139 - [clangd] Expose more dependent-name detail via semanticTokens

Author: Sam McCall Date: 2021-02-09T20:40:59+01:00 New Revision: 59c1139d3ee127a2049de5c711f81d46d8ec4e41 URL: https://github.com/llvm/llvm-project/commit/59c1139d3ee127a2049de5c711f81d46d8ec4e41 DIFF: https://github.com/llvm/llvm-project/commit/59c1139d3ee127a2049de5c711f81d46d8ec4e41.diff LO

[PATCH] D95701: [clangd] Add semanticTokens modifiers for function/class/file/global scope

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:82 + FileScope, + GlobalScope, + sammccall wrote: > nridge wrote: > > Would it make sense to call this `NamespaceScope` instead? > > > > I understand it's "global" in the

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak added a comment. This patch causes opt to crash when the following IR is compiled: $ cat test.ll @g0 = global i8 zeroinitializer, align 1 define internal i8* @foo() { ret i8* @g0 } define void @test() { %r = call i8* @foo() [ "clang.arc.rv"(i64 1) ] call void (

[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan created this revision. Herald added a reviewer: JDevlieghere. abhina.sreeskantharajan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is a continuation of https://reviews.llvm.org/D67696. The f

[PATCH] D95706: [clangd] Expose more dependent-name detail via semanticTokens

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:78 Abstract, + DependentName, sammccall wrote: > nridge wrote: > > Just `Dependent` might be enough > AFAICS the current implementation is closer to "dependent name" t

[PATCH] D86376: [HIP] Emit kernel symbol

tra added a comment. In D86376#2551298 , @yaxunl wrote: > Actually there is one issue with this approach. > > HIP have API's to launch kernels, which accept kernel as function pointer > argument. Currently when taking address of kernel, we get the stub fu

[PATCH] D96161: [OpenCL] Fix printing of types with signed prefix in arg info metadata

Anastasia added a comment. The clarification to the spec: https://github.com/KhronosGroup/OpenCL-Docs/pull/558 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96161/new/ https://reviews.llvm.org/D96161 __

[PATCH] D96360: [CMake] Delete LLVM_RUNTIME_BUILD_ID_LINK_TARGETS

MaskRay created this revision. MaskRay added reviewers: beanz, phosek, smeenai. Herald added a subscriber: mgorny. Herald added a reviewer: alexshap. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed. status change, see last message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88645/new/ https://reviews.llvm.org/D88645 __

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

jdoerfert reopened this revision. jdoerfert added a comment. This revision is now accepted and ready to land. The lang ref needs to reflect the new type https://llvm.org/docs/LangRef.html#llvm-var-annotation-intrinsic Please also review the auto-upgrade patch for this: https://reviews.llvm.org/D

[PATCH] D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics

apazos added inline comments. Comment at: clang/test/CodeGen/aarch64-neon-sm4-sm3-invalid.c:8 + +void test_range_check_vsm3tt1a(uint32x4_t a, uint32x4_t b, uint32x4_t c) { + // CHECK-RANGE: error: argument value 5 is outside the valid range [0, 3] Consider renam

[clang] 2aa01cc - [CUDA, NVPTX] Allow targeting sm_86 GPUs.

Author: Artem Belevich Date: 2021-02-09T11:01:10-08:00 New Revision: 2aa01ccec30109fbcc65934c5d7c8907793e0660 URL: https://github.com/llvm/llvm-project/commit/2aa01ccec30109fbcc65934c5d7c8907793e0660 DIFF: https://github.com/llvm/llvm-project/commit/2aa01ccec30109fbcc65934c5d7c8907793e0660.diff

[PATCH] D95974: [CUDA, NVPTX] Allow targeting sm_86 GPUs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2aa01ccec301: [CUDA, NVPTX] Allow targeting sm_86 GPUs. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

tra added a comment. What breaks existing abstractions is that we produce N ELF objects from a single TU and the meaning of `static` becomes fuzzy. On one hand, we don't want that static symbol to be visible across objects on the same target, at the same time we do want it to be visible across

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

malharJ updated this revision to Diff 322445. malharJ added a comment. This update removes the dependence of (emitting) vectorize_predicate metadata on whether vectorization is disabled (via vectorize(disable) or vector_width(1)) or not. This means that vectorize_predicate loop metadata is emitt

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ https://reviews.llvm.org/D95915 ___ cfe-commits mailing list cfe-co

[PATCH] D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

JonChesterfield accepted this revision. JonChesterfield added a comment. This works around the limitations of the binary format nvptx and amdgpu are using in the compiler. It's the wrong place in the stack to fix it - we could introduce another symbol table in the binary to capture the per-tu-be

[PATCH] D96285: [clang][Arm] Fix handling of -Wa,-implicit-it=

nickdesaulniers updated this revision to Diff 322439. nickdesaulniers marked 2 inline comments as done. nickdesaulniers added a comment. - address code review comments, add moar tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96285/new/ https:/

[PATCH] D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with new test nits. @JonChesterfield -- are you OK with the patch? Comment at: clang/test/CodeGenCUDA/device-var-linkage.cu:40 // NORDC-DAG: @_ZL3sv1 = dso_local addrspace(1

[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

hoy accepted this revision. hoy added a comment. This revision is now accepted and ready to land. Thanks for fixing these issues! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96354/new/ https://reviews.llvm.org/D96354 __

[PATCH] D96355: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with optionally considering differently qualified types mixable

whisperity created this revision. whisperity added reviewers: aaron.ballman, alexfh, hokein, njames93. whisperity added projects: clang, clang-tools-extra. Herald added subscribers: nullptr.cpp, rnkovacs, xazax.hun. whisperity requested review of this revision. Herald added a subscriber: cfe-commit

[PATCH] D95736: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics

whisperity updated this revision to Diff 322431. whisperity marked 6 inline comments as done. whisperity added a comment. Herald added a subscriber: nullptr.cpp. - **NFC** Code style, formatting, wording, etc. changes as per review comments. - **NFC** Removed a stale FIXME Repository: rG LLVM

[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

JonChesterfield added a comment. Using one option for both targets seems great - if both have put the devicertl in the same folder. Which I suppose they might not have. Maybe keep it separate for one, one for nvptx and one for amdgcn, and hope for a common 'device' later. Repository: rG LLV

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak added a comment. It looks like there is a pre-existing bug in `replaceUsesOfNonProtoConstant` where the operand bundles of all call sites are accumulated into `newBundles`. This will be fixed if its declaration is moved into the loop body. Also, we found another case of deadargelim cha

[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

probinson created this revision. probinson added reviewers: hoy, wmi. probinson requested review of this revision. Herald added a project: clang. After D93264 , using both -fdebug-info-for-profiling and -fpseudo-probe-for-profiling will cause the compiler to cras

[PATCH] D96353: [clangd] Use ML Code completion ranking as default.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Also treat Keywords separately as they are n

[PATCH] D90457: [clang][driver] Set LTO mode based on input files

MaskRay added a comment. In D90457#2551698 , @tbaeder wrote: > Hey @MaskRay, have you thought about this some more? Or is it too much magic > and you'd rather reject it altogether? Yes, it should be rejected. I've seen cases where people want `clang -c a

[PATCH] D90646: [clang] Add warning when `-include-pch` is passed multiple times

keith added a comment. Yea seems like a reasonable request, looking through the uses nothing immediately pops out as being not supporting multiple PCHs but I guess before I went down that path I'd want someone who knew the code better to agree on that Repository: rG LLVM Github Monorepo CHA

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

tbaeder added a comment. Is this good to go now? Or still something left? @yaxunl? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ https://reviews.llvm.org/D95915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D90457: [clang][driver] Set LTO mode based on input files

tbaeder added a comment. Hey @MaskRay, have you thought about this some more? Or is it too much magic and you'd rather reject it altogether? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90457/new/ https://reviews.llvm.org/D90457

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

tbaeder added a comment. In D96070#2546330 , @MaskRay wrote: > we cannot control `(optional -lc++abi/-lcxxrt/others)`, which is depended by > the installation configuration (e.g. > LIBCXX_STATICALLY_LINK_ABI_IN_STATIC_LIBRARY, or libc++.a as a linker scr

[PATCH] D95706: [clangd] Expose more dependent-name detail via semanticTokens

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:239 + auto Result = Priority1 > Priority2 ? Tokens[0] : Tokens[1]; + Result.Modifiers = Tokens[0].Modifiers | Tokens[1].Modifiers; + retur

[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

tianshilei1992 requested changes to this revision. tianshilei1992 added a comment. This revision now requires changes to proceed. In D96248#2551503 , @JonChesterfield wrote: > @tianshilei1992 @jdoerfert can we agree on 'libomptarget-device-bc-path' > bei

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov updated this revision to Diff 322422. ASDenysPetrov added a comment. Updated. Unlinked parent revision D95799 from the stack. Made corresponding changes in this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96090/new/ https://revie

[PATCH] D90646: [clang] Add warning when `-include-pch` is passed multiple times

kastiglione added a comment. Is there any reason that `-include-pch` shouldn't follow the precedent of `-include`, which can be used multiple times? If not, then the end goal should be to support multiple uses, but in the mean time a warning is helpful. Repository: rG LLVM Github Monorepo C

[PATCH] D95701: [clangd] Add semanticTokens modifiers for function/class/file/global scope

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:379 + // ExternalLinkage threshold could be tweaked, e.g. module-visible as global. + // Avoid caching linkage if it may change after enclosing code completion. + if (hasUnstableLink

[PATCH] D95701: [clangd] Add semanticTokens modifiers for function/class/file/global scope

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 5 inline comments as done. Closed by commit rG46cc7ce35ade: [clangd] Add semanticTokens modifiers for function/class/file/global scope (authored by sam

[clang-tools-extra] 46cc7ce - [clangd] Add semanticTokens modifiers for function/class/file/global scope

Author: Sam McCall Date: 2021-02-09T17:57:36+01:00 New Revision: 46cc7ce35ade2d0b3b49301fbf8135c1eca5b048 URL: https://github.com/llvm/llvm-project/commit/46cc7ce35ade2d0b3b49301fbf8135c1eca5b048 DIFF: https://github.com/llvm/llvm-project/commit/46cc7ce35ade2d0b3b49301fbf8135c1eca5b048.diff LO

[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

JonChesterfield added a comment. Some background discussion about the diagnostic. This change means people using nvptx, where the library cannot be found, will now be advised to use libomptarget-device-bc-path instead of libomptarget-nvptx-bc-path. If they use libomptarget-nvptx-bc-path anyway,

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

thakis added a comment. Here's a reduced repro: thakis@thakis:~/src/llvm-project$ cat GREYAssertDefaultConfiguration-9e1f3b.reduced.m inline id a() {} void b() { a(); a(); } thakis@thakis:~/src/llvm-project$ out/gn/bin/clang -cc1 -cc1 -triple arm64-apple-ios12.2.0 -Oz -fobjc-a

[clang] de1966e - Revert "[ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly"

Author: Nico Weber Date: 2021-02-09T11:06:32-05:00 New Revision: de1966e5427985163f8e816834b3a0564b5e24cd URL: https://github.com/llvm/llvm-project/commit/de1966e5427985163f8e816834b3a0564b5e24cd DIFF: https://github.com/llvm/llvm-project/commit/de1966e5427985163f8e816834b3a0564b5e24cd.diff LO

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

Anastasia added a comment. @svenvh We haven't looked into address spaces in details when adding this. I wonder what behavior would make sense for new/delete? Do we plan to allow new/delete in named address spaces or only in generic? It might be more helpful to allow named address spaces since g

[PATCH] D96347: Include function return type in JSON AST dumps.

rokups created this revision. rokups requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For some reason return type was not included. Even though it is present in full type dump, it is not good enough as C++ types can get quite complex. Beside

[PATCH] D96262: [clang][index] report references from unreslovedLookupExpr.

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. Thanks. LG. Couple of comments about adding tests to clangd as well. Comment at: clang/test/Index/Core/index-dependent-source.cpp:233 +// CHECK: [[@LINE-1]]:3 | functio

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

thakis added a comment. This makes clang assert for some inputs. See https://bugs.chromium.org/p/chromium/issues/detail?id=1175886#c10 for a repro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808 _

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

khchen added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:89 +#define BUILTIN(ID, TYPE, ATTRS) \ + {"__builtin_rvv_" #ID, TYPE, ATTRS, nullptr, ALL_LANGUAGES, nullptr}, +#include "clang/Basic/BuiltinsRISCV.def" ---

  1   2   >