[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ychen updated this revision to Diff 338431. ychen added a comment. Fix comment. Ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100739/new/ https://reviews.llvm.org/D100739 Files: clang/docs/LanguageExtensions.rst

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ychen updated this revision to Diff 338430. ychen added a comment. fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100739/new/ https://reviews.llvm.org/D100739 Files: clang/docs/LanguageExtensions.rst

[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)

ychen created this revision. ychen added reviewers: rjmccall, lxfind, ChuanqiXu. Herald added a subscriber: hiraditya. ychen requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. Herald added projects: clang, LLVM. This is an alternative to D97915

[PATCH] D100448: [RISCV][Clang] Add RVV AMO builtins

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM. Please remove the ASM check in upstream patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100448/new/

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield updated this revision to Diff 338423. mbenfield added a comment. Fixed misfirings reported by aeubanks and added tests for those cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581 Files:

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

dblaikie added a comment. In D100567#2697415 , @yonghong-song wrote: > To answer one of your questions above, if there is a function definition > before, dyn_cast(...) will return nullptr. I tried starting > from "Value" class and found dyn_cast to

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. In D100581#2693131 , @xbolva00 wrote: >>> These warnings are not enabled by any other flags. This is different from >>> gcc, where -Wunused-but-set-variable is enabled by -Wextra in combination >>> with either -Wunused or

[PATCH] D100448: [RISCV][Clang] Add RVV AMO builtins

arcbbb updated this revision to Diff 338419. arcbbb added a comment. re-formatted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100448/new/ https://reviews.llvm.org/D100448 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D99158: [RISCV][WIP] Implement intrinsics for P extension

Jim added a comment. In D99158#2695125 , @craig.topper wrote: > Also can you please explain the vector codegen plan at a high level? Do you > intend to support auto vectorization or just using vector_size in C? Currently, it just supports vector type

[PATCH] D100448: [RISCV][Clang] Add RVV AMO builtins

arcbbb updated this revision to Diff 338416. arcbbb marked 3 inline comments as done. arcbbb added a comment. Addressed @khchen's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100448/new/ https://reviews.llvm.org/D100448 Files:

[PATCH] D99158: [RISCV][WIP] Implement intrinsics for P extension

Jim updated this revision to Diff 338414. Jim added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99158/new/ https://reviews.llvm.org/D99158 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

HsiangKai added a comment. In D100611#2697055 , @khchen wrote: > Look good to me. > BTW, we also need to update the document > > later. `AttributeReference.html` will be

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

HsiangKai updated this revision to Diff 338411. HsiangKai added a comment. Update document. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/ https://reviews.llvm.org/D100611 Files: clang/include/clang/Basic/Attr.td

[PATCH] D100615: [RISCV][Driver] Make the ordering of CmdArgs consistent between RISCV::Linker and baremetal::Linker

This revision was automatically updated to reflect the committed changes. Closed by commit rG27edaee84e3e: [RISCV][Driver] Make the ordering of CmdArgs consistent between RISCV::Linker… (authored by arcbbb). Changed prior to commit: https://reviews.llvm.org/D100615?vs=338004=338410#toc

[clang] 27edaee - [RISCV][Driver] Make the ordering of CmdArgs consistent between RISCV::Linker and baremetal::Linker

Author: ShihPo Hung Date: 2021-04-18T19:05:20-07:00 New Revision: 27edaee84e3ea4d160f742db0b4a04e236c4e26e URL: https://github.com/llvm/llvm-project/commit/27edaee84e3ea4d160f742db0b4a04e236c4e26e DIFF: https://github.com/llvm/llvm-project/commit/27edaee84e3ea4d160f742db0b4a04e236c4e26e.diff

[clang-tools-extra] 8969762 - [clangd][test] Fix build error of FeatureModulesTests

Author: Pan, Tao Date: 2021-04-19T08:56:07+08:00 New Revision: 8969762fb1cf3b05adef5d6158b080548a9363e2 URL: https://github.com/llvm/llvm-project/commit/8969762fb1cf3b05adef5d6158b080548a9363e2 DIFF: https://github.com/llvm/llvm-project/commit/8969762fb1cf3b05adef5d6158b080548a9363e2.diff

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

aybassiouny updated this revision to Diff 338403. aybassiouny edited the summary of this revision. aybassiouny added a comment. After rechecking, turns out `AllowShortLambdasOnASingleLine` and `BeforeLambdaBody` both need to be turned on in order for the regression to be expressed, this affects

[PATCH] D100282: [Coroutines] Set presplit attribute in Clang instead of CoroEarly pass

lxfind added a comment. This broke MLIR tests. It seems that MLIR tests depend on CoroEarly to be able to annotate coroutine function properly based on the intrinsics. Given that, I am now convinced we shouldn't set the attribute in the frontend. Instead we should simply move CoroEarly to

[clang] 5faba87 - Revert "[Coroutines] Set presplit attribute in Clang instead of CoroEarly pass"

Author: Xun Li Date: 2021-04-18T17:22:28-07:00 New Revision: 5faba87938779c595f2b4e40f933bae6571bc421 URL: https://github.com/llvm/llvm-project/commit/5faba87938779c595f2b4e40f933bae6571bc421 DIFF: https://github.com/llvm/llvm-project/commit/5faba87938779c595f2b4e40f933bae6571bc421.diff LOG:

[PATCH] D100733: [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`

mizvekov added a comment. In D100733#2697537 , @aaronpuchert wrote: > The change seems to be correct, but I'm wondering if `x.getValueKind() == > VK_*Value` doesn't have one advantage over `x.is*Value()`: it's obvious that > this is exclusive with the

[PATCH] D100733: [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`

aaronpuchert added a comment. The change seems to be correct, but I'm wondering if `x.getValueKind() == VK_*Value` doesn't have one advantage over `x.is*Value()`: it's obvious that this is exclusive with the other values. Especially with `isRValue()` it might not be so obvious, because Clang

[clang] fa6b54c - [Coroutines] Set presplit attribute in Clang instead of CoroEarly pass

Author: Xun Li Date: 2021-04-18T15:41:09-07:00 New Revision: fa6b54c44ab1d5f579304eadb7ac8bd7e72d0e77 URL: https://github.com/llvm/llvm-project/commit/fa6b54c44ab1d5f579304eadb7ac8bd7e72d0e77 DIFF: https://github.com/llvm/llvm-project/commit/fa6b54c44ab1d5f579304eadb7ac8bd7e72d0e77.diff LOG:

[clang] c0211e8 - Revert "[Coroutines] Move CoroEarly pass to before AlwaysInliner"

Author: Xun Li Date: 2021-04-18T15:38:19-07:00 New Revision: c0211e8d7d0b797fd11543c3d3f9fecf3b2069cf URL: https://github.com/llvm/llvm-project/commit/c0211e8d7d0b797fd11543c3d3f9fecf3b2069cf DIFF: https://github.com/llvm/llvm-project/commit/c0211e8d7d0b797fd11543c3d3f9fecf3b2069cf.diff LOG:

[PATCH] D100712: [AST] Add NestedNameSpecifierLoc accessors to node introspection

steveire added inline comments. Comment at: clang/unittests/Introspection/IntrospectionTest.cpp:280 STRING_LOCATION_STDPAIR(MethodDecl, getTypeSpecStartLoc()) })); // clang-format on njames93 wrote: > I'm not entirely sure on the case, but the windows bot

[clang] 2b50f5a - [Coroutines] Move CoroEarly pass to before AlwaysInliner

Author: Xun Li Date: 2021-04-18T14:54:04-07:00 New Revision: 2b50f5a4343f8fb06acaa5c36355bcf58092c9cd URL: https://github.com/llvm/llvm-project/commit/2b50f5a4343f8fb06acaa5c36355bcf58092c9cd DIFF: https://github.com/llvm/llvm-project/commit/2b50f5a4343f8fb06acaa5c36355bcf58092c9cd.diff LOG:

[PATCH] D100282: [Coroutines] Set presplit attribute in Clang instead of CoroEarly pass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b50f5a4343f: [Coroutines] Move CoroEarly pass to before AlwaysInliner (authored by lxfind). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D100727: [clang-format] Correctly apply AllowShortIfStatementsOnASingleLine: Always to else branch.

curdeius added a comment. In D100727#2697419 , @HazardyKnusperkeks wrote: > How is > > if (a) return; > else > return; > > formatted with the different options? Do you have something specific in mind? > And from the documentation I think it

[PATCH] D100733: [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`

mizvekov created this revision. Herald added a subscriber: lxfind. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Matheus Izvekov Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100733 Files:

[PATCH] D100713: [clang] NFC: refactor usage of getDecltypeForParenthesizedExpr and getValueKind

mizvekov updated this revision to Diff 338393. mizvekov added a comment. Split 'getValueKind' cleanup into a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100713/new/ https://reviews.llvm.org/D100713 Files:

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

Qix- added a comment. I'm not sure exactly how to continue after the last few comments - what should the approach be for this patch? Or are these things we can shoot for in later patches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99861/new/

[PATCH] D100719: [Introspection] Dont emit json if unchanged.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb75db85f231: [Introspection] Dont emit json if unchanged. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100719/new/

[clang] db75db8 - [Introspection] Dont emit json if unchanged.

Author: Nathan James Date: 2021-04-18T20:22:09+01:00 New Revision: db75db85f231bf194912c3b0dd918f2bc497d603 URL: https://github.com/llvm/llvm-project/commit/db75db85f231bf194912c3b0dd918f2bc497d603 DIFF: https://github.com/llvm/llvm-project/commit/db75db85f231bf194912c3b0dd918f2bc497d603.diff

[PATCH] D100712: [AST] Add NestedNameSpecifierLoc accessors to node introspection

njames93 added inline comments. Comment at: clang/unittests/Introspection/IntrospectionTest.cpp:280 STRING_LOCATION_STDPAIR(MethodDecl, getTypeSpecStartLoc()) })); // clang-format on I'm not entirely sure on the case, but the windows bot is giving a [[

[PATCH] D100727: [clang-format] Correctly apply AllowShortIfStatementsOnASingleLine: Always to else branch.

HazardyKnusperkeks added a comment. How is if (a) return; else return; formatted with the different options? And from the documentation I think it was intended that only `if` is short, never the `else`. So I think it behaves correctly, nevertheless I think it should be possible, but

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

yonghong-song added a comment. To answer one of your questions above, if there is a function definition before, dyn_cast(...) will return nullptr. I tried starting from "Value" class and found dyn_cast to llvm::ConstantExpr will result in a non-null object, but I did not trace down further

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

yonghong-song added a comment. In D100567#2697412 , @dblaikie wrote: > In D100567#2696095 , @yonghong-song > wrote: > >> Sorry, I know what is the segfault now after some debugging. It is because >> `auto *Fn =

[PATCH] D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested

dblaikie added a comment. In D100567#2696095 , @yonghong-song wrote: > Sorry, I know what is the segfault now after some debugging. It is because > `auto *Fn = dyn_cast(LV.getPointer(*this));` is a NULL > pointer after there is a definition before

[PATCH] D100415: [Coroutines] Split coroutine during CoroEarly into an init and ramp function

lxfind added inline comments. Comment at: llvm/lib/Transforms/Coroutines/CoroSplit.cpp:2231 // coroutine. struct CoroSplitLegacy : public CallGraphSCCPass { static char ID; // Pass identification, replacement for typeid ChuanqiXu wrote: > I am not familiar

[PATCH] D100712: [AST] Add NestedNameSpecifierLoc accessors to node introspection

steveire added inline comments. Comment at: clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py:57 InstanceDecoration = "*" -if CladeName == "TypeLoc": +if CladeName == "TypeLoc" or CladeName == "NestedNameSpecifierLoc": InstanceDecoration =

[PATCH] D100723: [AST] Fix comparison to of SourceRanges in container

steveire added inline comments. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:47 std::pair const ) const { - if (!LHS.first.isValid() || !RHS.first.isValid()) -return false; njames93 wrote: > Maybe we should assert the ranges (or locations) are

[PATCH] D100727: [clang-format] Correctly apply AllowShortIfStatementsOnASingleLine: Always to else branch.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a bug reported on Discord #clang-format

[PATCH] D100723: [AST] Fix comparison to of SourceRanges in container

njames93 added inline comments. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:47 std::pair const ) const { - if (!LHS.first.isValid() || !RHS.first.isValid()) -return false; Maybe we should assert the ranges (or locations) are valid before

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

yaxunl updated this revision to Diff 338379. yaxunl marked 3 inline comments as done. yaxunl edited the summary of this revision. yaxunl added a comment. Revised by Matt's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77013/new/ https://reviews.llvm.org/D77013 Files:

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Herald added subscribers: jansvoboda11, dexonsmith, dang. Comment at: clang/include/clang/Basic/CodeGenOptions.def:399 +/// Whether to emit IEEE754-2008 NaN compliant instructions if available (AMDGPU

[PATCH] D100638: [AST][Introspection] Avoid creating temporary strings when comparing LocationCalls.

steveire added a comment. Your implementation is getting very complicated and it requires many comments. Also, if we get to this point in the execution of `RangeLessThan::operator()`, you're creating and populating two vectors for every two elements contained. I know it's `llvm::SmallVector`

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. @teemperor, could you take another look at this patch -- I believe most of your concerns are addressed now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 ___

[clang] d4528cb - [clang] Fix cross compiling clang for windows after 141945f950e2f3f

Author: Martin Storsjö Date: 2021-04-18T15:56:18+03:00 New Revision: d4528cbb0e703ee17ee6fb4abe72b7246ccb38f1 URL: https://github.com/llvm/llvm-project/commit/d4528cbb0e703ee17ee6fb4abe72b7246ccb38f1 DIFF:

[PATCH] D100723: [AST] Fix comparison to of SourceRanges in container

steveire created this revision. steveire added a reviewer: njames93. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100723 Files:

[PATCH] D100719: [Introspection] Dont emit json if unchanged.

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. Great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100719/new/ https://reviews.llvm.org/D100719

[PATCH] D100720: [AST] Update introspection API to use const-ref for copyable types

steveire created this revision. steveire added a reviewer: njames93. Herald added a subscriber: mgorny. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100720

[PATCH] D100712: [AST] Add NestedNameSpecifierLoc accessors to node introspection

njames93 added inline comments. Comment at: clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py:57 InstanceDecoration = "*" -if CladeName == "TypeLoc": +if CladeName == "TypeLoc" or CladeName == "NestedNameSpecifierLoc": InstanceDecoration =

[PATCH] D100719: [Introspection] Dont emit json if unchanged.

njames93 created this revision. njames93 added a reviewer: steveire. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Saves running the generate inc script in the, somewhat common, case where the json file doesn't need changing.

[PATCH] D100658: [RISCV] Apply __clang_riscv_builtin_alias to overloaded builtins.

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100658/new/ https://reviews.llvm.org/D100658

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

khchen added a comment. Look good to me. BTW, we also need to update the document later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/

[clang] a0898f0 - [AST][Introspection][NFC] Remove unnecessary temporary strings.

Author: Nathan James Date: 2021-04-18T09:25:19+01:00 New Revision: a0898f0cecc78be913e885cfba727bd4d9c49aaf URL: https://github.com/llvm/llvm-project/commit/a0898f0cecc78be913e885cfba727bd4d9c49aaf DIFF: https://github.com/llvm/llvm-project/commit/a0898f0cecc78be913e885cfba727bd4d9c49aaf.diff

[PATCH] D100638: [AST][Introspection] Avoid creating temporary strings when comparing LocationCalls.

njames93 updated this revision to Diff 338356. njames93 added a comment. Rebase and remove Args from comparison. Add quick check for skippig common prefix calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100638/new/