[PATCH] D105462: [X86] Add CRC32 feature.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:159 + // Enable CRC32 if SSE4.2 is enabled. + // NOTE: In conformance with GCC behavior, CRC32 is still available even if + // it's explicitly disabled. This doesn't seem to be

[PATCH] D106370: [Analyzer][solver][NFC] Add explanatory comments to trivial eq classes

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I understood this comment! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106370/new/ https://reviews.llvm.org/D106370

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

NoQ added a comment. Yes, I think this should work. You're invalidating less regions than a normal destructor invalidation would have caused (eg., you're not touching globals). One way to emulate that precisely would be to construct a `CallEvent` for the destructor and invoke

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4577-4583 + // If we have a complex type and the base type is smaller than 8 bytes, + // the ABI calls for the real and imaginary parts to be right-adjusted + // in separate

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

junparser updated this revision to Diff 360352. junparser added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106333/new/ https://reviews.llvm.org/D106333 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D106111: opencl-c.h: add initial CL 3.0 conditionals for atomic operations.

airlied updated this revision to Diff 360349. airlied added a comment. add conditional around memory_order_seq_cst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106111/new/ https://reviews.llvm.org/D106111 Files:

[PATCH] D106416: [analyzer] Fix build dependency issues for SATest

manas created this revision. Herald added subscribers: steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: teemperor. manas requested review of this revision. Herald added a project: clang. Herald

[PATCH] D106340: [Clang][RISCV] Add half-precision FP for vle16/vse16.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG89ce6449024d: [Clang][RISCV] Add half-precision FP for vle16/vse16. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 89ce644 - [Clang][RISCV] Add half-precision FP for vle16/vse16.

Author: Hsiangkai Wang Date: 2021-07-21T09:55:21+08:00 New Revision: 89ce6449024d2b288b825e815ab5cc11faf04d22 URL: https://github.com/llvm/llvm-project/commit/89ce6449024d2b288b825e815ab5cc11faf04d22 DIFF:

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:406 +// architecture that doesn't allow stack tagging we will still load the +// analysis. +// This is so we don't need to plumb TargetTriple all the way to here.

[PATCH] D98710: [clang-tidy] New feature --skip-headers, part 1, setTraversalScope

chh updated this revision to Diff 360339. chh edited the summary of this revision. chh added a comment. Add bugprone-forward-declaration-namespace-header.cpp test to show that MatchFinder-based checks can also depend on header Decls. CHANGES SINCE LAST ACTION

[PATCH] D98709: [clang-tidy] New feature --skip-headers, part 1, skip Decls

chh updated this revision to Diff 360336. chh edited the summary of this revision. chh added a comment. Add bugprone-forward-declaration-namespace-header.cpp test; fix some coding style warnings. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98709/new/ https://reviews.llvm.org/D98709

[PATCH] D105462: [X86] Add CRC32 feature.

tianqing updated this revision to Diff 360338. tianqing added a comment. Herald added a subscriber: jfb. Instead of using ImpliedFeatures, manually enable CRC32 in presence of SSE4.2. This should mimic GCC better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX

hubert.reinterpretcast added a comment. LGTM with minor nit; thanks. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5140 +A->render(Args, CmdArgs); +} else D.Diag(diag::err_drv_invalid_argument_to_option) Add braces to the `else` block

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added inline comments. Comment at: clang/test/Frontend/backend-attribute-error-warning.c:29 + duplicate_errors(); // expected-error {{call to 'duplicate_errors' declared with attribute error: two}} + // TODO: why is this a warning not an error +

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

aaronpuchert added a reviewer: aaron.ballman. aaronpuchert added a subscriber: aaron.ballman. aaronpuchert added a comment. Let's add @aaron.ballman to get a third opinion. The discussion is meandering a bit, but you should understand the gist from the first comments or the bug report. The

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

aaronpuchert added a comment. In D101566#2891972 , @dblaikie wrote: > For Rafael - probably because he didn't look at all the cases the warning > does catch & see that it's pretty much entirely no use Right, he didn't suggest this particular fix but

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3823 + +def Warning : Attr { + let Spellings = [GCC<"warning">]; aaron.ballman wrote: > nickdesaulniers wrote: > > aaron.ballman wrote: > > > Given that the only functional

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers updated this revision to Diff 360324. nickdesaulniers marked 4 inline comments as done. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - merge ErrorAttr with WarningAttr - fix dumb short circuit bug - rename diag group - handle multiple

[PATCH] D106410: [PowerPC] Emit error for Altivec vector initializations when -faltivec-src-compat=gcc is specified

amyk created this revision. amyk added reviewers: PowerPC, nemanjai, stefanp. amyk added projects: PowerPC, LLVM, clang. Herald added a subscriber: shchenz. amyk requested review of this revision. Under the `-faltivec-src-compat=gcc` option, AltiVec vector initialization should be treated as if

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:77 + // references from inline assembly. + std::string Alias = ".set \"" + OldName + "\",\"" + NewName + "\"\n"; + ExportM.appendModuleInlineAsm(Alias);

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb updated this revision to Diff 360317. cjdb marked an inline comment as done. cjdb added a comment. - renames test files so they better describe intention - replaces `SmallVector` with `SetVector` - replaces `std::accumulate` with `llvm::interleave` Repository: rG LLVM Github Monorepo

[PATCH] D106409: [PowerPC] Add diagnostic for out of range values for vec_cts,vec_ctf

ZarkoCA created this revision. ZarkoCA added reviewers: bmahjour, nemanjai, jsji, PowerPC. Herald added subscribers: shchenz, kbarton. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LLVM (llc) will crash when a user specifies a

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

Conanap added a comment. issue should be fixed now; pushed with this: https://reviews.llvm.org/D106130#change-PZi4uueeCg9i (I just had to move the test files into the `PowerPC` folder). Will continue to monitor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2fd1520247de: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins (authored by Conanap). Changed prior to commit:

[clang] 2fd1520 - [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

Author: Albion Fung Date: 2021-07-20T17:51:00-05:00 New Revision: 2fd1520247de6ba1679e7288e3678fb7f8ca2183 URL: https://github.com/llvm/llvm-project/commit/2fd1520247de6ba1679e7288e3678fb7f8ca2183 DIFF: https://github.com/llvm/llvm-project/commit/2fd1520247de6ba1679e7288e3678fb7f8ca2183.diff

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:77 + // references from inline assembly. + std::string Alias = ".set \"" + OldName + "\",\"" + NewName + "\"\n"; + ExportM.appendModuleInlineAsm(Alias);

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

dblaikie added a comment. In D101566#2891923 , @aaronpuchert wrote: > In D101566#2891764 , @dblaikie > wrote: > >> This patch is still conflating two things - effectively removing an existing >> warning (which

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

jroelofs added a comment. I moved a couple of new tests from this patch from CodeGen -> CodeGen/PowerPC so they don't fail when the PPC backend isn't built: f6769b663a0d4432b5e00e0c03904a5dfba7b077 Repository: rG LLVM

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

aaronpuchert added a subscriber: dfaure-kdab. aaronpuchert added a comment. In D101566#2891764 , @dblaikie wrote: > This patch is still conflating two things - effectively removing an existing > warning (which I agree with) and adding a new one (which I

[PATCH] D105273: [analyzer] Introduce range-based reasoning for subtraction operator

manas added a comment. Here is the proof using Z3: https://gist.github.com/weirdsmiley/8a35a0e1f55f310e3566cbd47555491a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105273/new/ https://reviews.llvm.org/D105273

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added a comment. Here is the proof of correctness of the algorithm using Z3: https://gist.github.com/weirdsmiley/ad6a9dbf3370e96d29f9e90068931d25 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103440/new/ https://reviews.llvm.org/D103440

[PATCH] D106401: [CUDA, MemCpyOpt] Add a flag to force-enable memcpyopt and use it for CUDA.

tra updated this revision to Diff 360293. tra edited the summary of this revision. tra added a comment. Fixed the option name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106401/new/ https://reviews.llvm.org/D106401 Files:

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:612 +static_assert(is_same::value); + +} // namespace unevaluated cor3ntin wrote: > aaron.ballman wrote: > > Here's an interesting test case: > > ``` > > #include > > > > struct

[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM (one comment in the test), although it'd be good to get someone more involved in lib/CodeGen to take a quick look / sign off (ideally someone that knows the use case for

[clang] 5f55761 - [clang] Fix the capitalization of the DarwinSDKInfoTest unittest filename to avoid case-sensitive FS build errors

Author: Alex Lorenz Date: 2021-07-20T14:53:08-07:00 New Revision: 5f557616c6b13adbe244b3583459a926628c3466 URL: https://github.com/llvm/llvm-project/commit/5f557616c6b13adbe244b3583459a926628c3466 DIFF: https://github.com/llvm/llvm-project/commit/5f557616c6b13adbe244b3583459a926628c3466.diff

[PATCH] D106401: [CUDA, MemCpyOpt] Add a flag to force-enable memcpyopt and use it for CUDA.

tra created this revision. tra added reviewers: nikic, fhahn. Herald added subscribers: bixia, hiraditya, yaxunl. tra requested review of this revision. Herald added projects: clang, LLVM. Attempt to enable MemCpyOpt unconditionally in D104801 uncovered the

[PATCH] D106400: [WebAssembly] Codegen for v128.load{32,64}_zero

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur added a comment. In D104601#2831746 , @dblaikie wrote: > but for my money this seems pretty problematic - will make quoted text in > compiler diagnostics weird/difficult to read, etc. FWIW, clang has a line length limit of 4096

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

Conanap added a comment. I'm aware of the getting target issue; the fix will be up soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105946/new/ https://reviews.llvm.org/D105946 ___ cfe-commits

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

dblaikie added a comment. In D101566#2891699 , @aaronpuchert wrote: > @dblaikie, does https://bugs.llvm.org/show_bug.cgi?id=18733#c17 or the > following comment change anything about your position? No, not really. This patch is still conflating two

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

rnk added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:77 + // references from inline assembly. + std::string Alias = ".set \"" + OldName + "\",\"" + NewName + "\"\n"; + ExportM.appendModuleInlineAsm(Alias);

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur updated this revision to Diff 360278. Meinersbur added a comment. - Rename -felide-unnecessary-whitespace to -fminimize-whitespace - Add -fminimize-whitespace only vlid to be used to docs - Adjust some code comments - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D106303: [clang] fix oops: enable implicit moves in MSVC compatibility mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d68ecafd6ad: [clang] fix oops: enable implicit moves in MSVC compatibility mode (authored by mizvekov). Repository: rG LLVM Github Monorepo

[clang] 1d68eca - [clang] fix oops: enable implicit moves in MSVC compatibility mode

Author: Matheus Izvekov Date: 2021-07-20T23:32:05+02:00 New Revision: 1d68ecafd6ad9ba8857c78e567abbc58810329c1 URL: https://github.com/llvm/llvm-project/commit/1d68ecafd6ad9ba8857c78e567abbc58810329c1 DIFF:

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb added a comment. In D106394#2891647 , @zoecarver wrote: > Can't wait to start using this! (Note: this is not a full review, just some > thoughts.) > > Do you have a test case where > > // private: header one > *exists* > > // private:

[PATCH] D105958: [clang][darwin] add support for version remapping to the Darwin SDK Info class

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG808bbc2c4702: [clang][darwin] Add support for macOS - Mac Catalyst (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 808bbc2 - [clang][darwin] Add support for macOS -> Mac Catalyst

Author: Alex Lorenz Date: 2021-07-20T14:25:33-07:00 New Revision: 808bbc2c47028ff5c2cc0bf7a1d5140adec9202a URL: https://github.com/llvm/llvm-project/commit/808bbc2c47028ff5c2cc0bf7a1d5140adec9202a DIFF: https://github.com/llvm/llvm-project/commit/808bbc2c47028ff5c2cc0bf7a1d5140adec9202a.diff

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

aaronpuchert added a comment. @dblaikie, does https://bugs.llvm.org/show_bug.cgi?id=18733#c17 change anything about your position? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101566/new/ https://reviews.llvm.org/D101566

[PATCH] D106361: [clang-tidy] Fix crash and handle AttributedTypes in 'bugprone-easily-swappable-parameters'

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:476-477 + +QualType NewCoreType = CoreType; +NewCoreType.addFastQualifiers(Quals.getFastQualifiers()); +

[PATCH] D106361: [clang-tidy] Fix crash and handle AttributedTypes in 'bugprone-easily-swappable-parameters'

whisperity added a comment. In D106361#2890458 , @aaron.ballman wrote: > The rename from `CommonType` to `CoreType` could probably be done as a > separate NFC to make the review a bit easier, if we decide that's a good > terminology switch. I'm not

[PATCH] D106361: [clang-tidy] Fix crash and handle AttributedTypes in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 360269. whisperity marked 4 inline comments as done. whisperity added a comment. - Remove orthogonal/half-baked changes. - Fix a mistake in the logic changing only a temporary state. - Add a missing //FIXME//. Repository: rG LLVM Github Monorepo

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:77 + // references from inline assembly. + std::string Alias = ".set \"" + OldName + "\",\"" + NewName + "\"\n"; + ExportM.appendModuleInlineAsm(Alias);

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added a comment. In D93769#2891552 , @MaskRay wrote: > In D93769#2891549 , @mibintc wrote: > >> In D93769#2891545 , @MaskRay wrote: >> >>> This breaks

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:77 + // references from inline assembly. + std::string Alias = ".set \"" + OldName + "\",\"" + NewName + "\"\n"; + ExportM.appendModuleInlineAsm(Alias);

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

efriedma added a comment. Can you add a helper somewhere for the `BT->getKind() == BuiltinType::SveBool ? getLangOpts().ArmSveVectorBits / getCharWidth() : getLangOpts().ArmSveVectorBits)` pattern? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106340: [Clang][RISCV] Add half-precision FP for vle16/vse16.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106340/new/ https://reviews.llvm.org/D106340

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen updated this revision to Diff 360267. samitolvanen added a comment. Folded in D106392 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104058/new/ https://reviews.llvm.org/D104058 Files:

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

zoecarver added a comment. Can't wait to start using this! (Note: this is not a full review, just some thoughts.) Do you have a test case where // private: header one *exists* // private: header two #include<__header_one.h> // public: header three #include<__header_two.h> I

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 360261. quinnp added a comment. Rebasing to ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3434ac9e3902: [PowerPC] Store, load, move from and to registers related builtins (authored by Conanap). Changed prior to commit:

[clang] 3434ac9 - [PowerPC] Store, load, move from and to registers related builtins

Author: Albion Fung Date: 2021-07-20T15:46:14-05:00 New Revision: 3434ac9e39026ae19870a3356d744649dc85777e URL: https://github.com/llvm/llvm-project/commit/3434ac9e39026ae19870a3356d744649dc85777e DIFF: https://github.com/llvm/llvm-project/commit/3434ac9e39026ae19870a3356d744649dc85777e.diff

[clang] d48ad35 - Revert "[CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend #pragma float_control similarly"

Author: Melanie Blower Date: 2021-07-20T16:40:55-04:00 New Revision: d48ad358b1e84698f1070cec50c7586b78865265 URL: https://github.com/llvm/llvm-project/commit/d48ad358b1e84698f1070cec50c7586b78865265 DIFF:

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen added a comment. In D104058#2891551 , @morehouse wrote: > This patch broke the sanitizer-windows bot: > https://lab.llvm.org/buildbot/#/builders/127/builds/14257 > > Failed Tests (4): > cfi-devirt-lld-thinlto-x86_64 ::

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added inline comments. Comment at: clang/test/Preprocessor/predefined-flteval-macro.c:332 +// RUN: %clang_cc1 -std=c11 -ffreestanding -triple=riscv64 -fsyntax-only %s +// RUN: %clang_cc1 -std=c11 -ffreestanding -triple=riscv64-unknown-linux -fsyntax-only %s +#ifndef

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

MaskRay added a comment. In D93769#2891549 , @mibintc wrote: > In D93769#2891545 , @MaskRay wrote: > >> This breaks `clang/test/Index/preamble-reparse-changed-module.m` >> >>

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

morehouse added a comment. This patch broke the sanitizer-windows bot: https://lab.llvm.org/buildbot/#/builders/127/builds/14257 Failed Tests (4): cfi-devirt-lld-thinlto-x86_64 :: anon-namespace.cpp cfi-devirt-lld-thinlto-x86_64 :: simple-pass.cpp

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added a comment. In D93769#2891545 , @MaskRay wrote: > This breaks `clang/test/Index/preamble-reparse-changed-module.m` > > http://45.33.8.238/linux/51638/step_7.txt I saw this fail on console when i do "ninja check-clang" but when I run each

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

MaskRay added inline comments. Comment at: clang/test/Preprocessor/predefined-flteval-macro.c:332 +// RUN: %clang_cc1 -std=c11 -ffreestanding -triple=riscv64 -fsyntax-only %s +// RUN: %clang_cc1 -std=c11 -ffreestanding -triple=riscv64-unknown-linux -fsyntax-only %s +#ifndef

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb added inline comments. Comment at: clang/lib/Lex/PPLexerChange.cpp:437 + diag::pp_pragma_include_instead_system_reserved) +<< Filename << 2 << ('{' + Aliases + '}'); + } I wasn't able to work out how to escape braces inside

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

MaskRay added a comment. This breaks `clang/test/Index/preamble-reparse-changed-module.m` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93769/new/ https://reviews.llvm.org/D93769 ___ cfe-commits mailing

[clang] 05a6d74 - [clang] NFC, move DarwinSDKInfo to lib/Basic

Author: Alex Lorenz Date: 2021-07-20T13:22:48-07:00 New Revision: 05a6d74c4845221907e25971937242b72489ef55 URL: https://github.com/llvm/llvm-project/commit/05a6d74c4845221907e25971937242b72489ef55 DIFF: https://github.com/llvm/llvm-project/commit/05a6d74c4845221907e25971937242b72489ef55.diff

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb created this revision. cjdb added reviewers: aaron.ballman, rsmith, gbiv, dblaikie, cor3ntin. Herald added a reviewer: george.burgess.iv. Herald added subscribers: usaxena95, kadircet. cjdb requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA created this revision. ZarkoCA added reviewers: cebowleratibm, sfertile, PowerPC. Herald added subscribers: shchenz, kbarton, nemanjai. ZarkoCA requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Remove the previous

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce8024e8ff76: [CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend… (authored by mibintc). Repository: rG LLVM Github

[clang] ce8024e - [CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend #pragma float_control similarly

Author: Melanie Blower Date: 2021-07-20T16:02:09-04:00 New Revision: ce8024e8ff76e7be8b9ffa1a39d1dc9310bf74c7 URL: https://github.com/llvm/llvm-project/commit/ce8024e8ff76e7be8b9ffa1a39d1dc9310bf74c7 DIFF:

[PATCH] D105052: [clang][darwin] add support for Mac Catalyst availability

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8262a383bc6: [clang][darwin] add support for Mac Catalyst availability (authored by arphaman). Herald added a project: clang. Repository: rG

[clang] a8262a3 - [clang][darwin] add support for Mac Catalyst availability

Author: Alex Lorenz Date: 2021-07-20T12:51:57-07:00 New Revision: a8262a383bc627cef3de78e60bbbedb788157a50 URL: https://github.com/llvm/llvm-project/commit/a8262a383bc627cef3de78e60bbbedb788157a50 DIFF: https://github.com/llvm/llvm-project/commit/a8262a383bc627cef3de78e60bbbedb788157a50.diff

Re: [clang] 4ace600 - [OpaquePtr] Remove uses of CreateStructGEP() without element type

On Tue, Jul 20, 2021 at 11:52 AM Nikita Popov wrote: > On Tue, Jul 20, 2021 at 8:27 PM David Blaikie wrote: > >> Any chance some of this series of patches could have test coverage >> included? (like small clang test cases that exercise only a narrow part of >> the codegen & works with

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:612 +static_assert(is_same::value); + +} // namespace unevaluated aaron.ballman wrote: > Here's an interesting test case: > ``` > #include > > struct S { > virtual void f(); >

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin updated this revision to Diff 360235. cor3ntin added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106302/new/ https://reviews.llvm.org/D106302 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D105926: [PowerPC] Extra test case for LDARX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a7711f33a04: [PowerPC] Extra test case for LDARX (authored by Conanap). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

aaron.ballman added a comment. The changes LGTM, but I'd appreciate additional sign-off from someone with more expertise in this area. @rjmccall, can you take a look to see if it addresses your concerns? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106303: [clang] fix oops: enable implicit moves in MSVC compatibility mode

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Oops! Good catch, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106303/new/ https://reviews.llvm.org/D106303

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

mibintc updated this revision to Diff 360225. mibintc added a comment. Removed use of auto, and used different capitalization for local var name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102343/new/ https://reviews.llvm.org/D102343 Files:

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Decl.h:1993 const DeclarationNameInfo , QualType T, - TypeSourceInfo *TInfo, StorageClass S, bool isInlineSpecified, - ConstexprSpecKind ConstexprKind, +

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:603 + +long f(); //expected-note {{declared here}} +auto consteval g(auto a) { Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:608 + +auto e = g(f());

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

mibintc marked an inline comment as done. mibintc added a comment. Question for Aaron Comment at: clang/include/clang/AST/Decl.h:1993 const DeclarationNameInfo , QualType T, - TypeSourceInfo *TInfo, StorageClass S, bool isInlineSpecified, -

[PATCH] D106074: [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX.

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106074/new/ https://reviews.llvm.org/D106074 ___ cfe-commits mailing

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

dblaikie added a comment. In D106084#2890469 , @probinson wrote: >> (hence the renaming of "limited" a long time ago to "standalone-debug" to >> create a policy/philosophy around what goes in each category). > > Sorry, what? I thought

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

mibintc updated this revision to Diff 360222. mibintc added a comment. Partially respond to @aaron.ballman 's review by refactoring a change into a separate commit, but I'll push back on another request, I'll add that reply inline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

Re: [clang] 4ace600 - [OpaquePtr] Remove uses of CreateStructGEP() without element type

Any chance some of this series of patches could have test coverage included? (like small clang test cases that exercise only a narrow part of the codegen & works with force-opaque-pointers due to these changes?) On Sat, Jul 17, 2021 at 9:48 AM Nikita Popov via cfe-commits <

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD added a comment. This is a minimal model of destructors in smart-ptr. Other than the need to probably model the destructor of the pointee, is there anything else to do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 360218. RedDocMD added a comment. Minimal modelling of destructor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files:

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha added inline comments. Comment at: clang/docs/MatrixTypes.rst:271 +- +An empty value of a matrix type M can be initialised using this syntax: + SaurabhJha wrote: > fhahn wrote: > > is there a reason we need to allow 'empty'

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha added inline comments. Comment at: clang/docs/MatrixTypes.rst:271 +- +An empty value of a matrix type M can be initialised using this syntax: + fhahn wrote: > is there a reason we need to allow 'empty' initialisation? What does it

[PATCH] D106100: [clang-scan-deps] ignore top-level module dependencies that aren't actually imported

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc68f247275ee: [clang-scan-deps] ignore top-level module dependencies that arent actually… (authored by arphaman). Herald added a project: clang.

[clang] c68f247 - [clang-scan-deps] ignore top-level module dependencies that aren't actually imported

Author: Alex Lorenz Date: 2021-07-20T11:11:28-07:00 New Revision: c68f247275eed94a4f4b97ad53b4d599acfd181a URL: https://github.com/llvm/llvm-project/commit/c68f247275eed94a4f4b97ad53b4d599acfd181a DIFF: https://github.com/llvm/llvm-project/commit/c68f247275eed94a4f4b97ad53b4d599acfd181a.diff

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a762f93f816: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL… (authored by NeHuang). Repository: rG LLVM Github

[clang] 1a762f9 - [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

Author: Victor Huang Date: 2021-07-20T13:06:22-05:00 New Revision: 1a762f93f81640768dc9e9d933780fff32cfa639 URL: https://github.com/llvm/llvm-project/commit/1a762f93f81640768dc9e9d933780fff32cfa639 DIFF: https://github.com/llvm/llvm-project/commit/1a762f93f81640768dc9e9d933780fff32cfa639.diff

  1   2   3   >