[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

waltl updated this revision to Diff 372056. waltl added a comment. Added driver flags, and tests for them Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243 Files:

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

zhouyizhou added a comment. Hi, I have no write access to LLVM, can you commit D109408 for me? Thanks a lot Zhouyi Zhou Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109408/new/ https://reviews.llvm.org/D109408

[PATCH] D109461: [clang][darwin] Add support for --emit-static-lib

keith added reviewers: ashi1, tra, yaxunl. keith added a comment. Since you all were involved in adding this feature in the beginning I'd appreciate a review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109461/new/

[PATCH] D101037: [clang-tidy] Change shebang from python to python3

keith added a comment. @hokein any plans to land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101037/new/ https://reviews.llvm.org/D101037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109638: [CSSPGO] Truncate stack samples with invalid return address.

hoy updated this revision to Diff 372042. hoy edited the summary of this revision. hoy added a comment. Updating D109638 : [CSSPGO] Truncate stack samples with invalid return address. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 372041. keith added a comment. Handle all cases by passing relative path to ExternalFS first Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 Files:

[PATCH] D109638: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy created this revision. Herald added subscribers: modimo, wenlei, hiraditya. hoy requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Pseudo probe instrumentation was missing from O0 build. It is needed in cases where some

[PATCH] D108045: [clangd] Fix clangd crash when including a header

qdelacru updated this revision to Diff 372005. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108045/new/ https://reviews.llvm.org/D108045 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/clangd/Preamble.cpp

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. Can you add a driver test, which tests both `-fobjc-avoid-heapify-local-blocks` and `-fno-objc-avoid-heapify-local-blocks`? Other than that, LGTM. Repository: rG LLVM Github Monorepo

[PATCH] D91944: OpenMP 5.0 metadirective

cchen updated this revision to Diff 372038. cchen added a comment. Remove debug info and spaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files: clang/include/clang-c/Index.h

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

waltl updated this revision to Diff 372035. waltl added a comment. Trivial cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D91944: OpenMP 5.0 metadirective

cchen updated this revision to Diff 372034. cchen added a comment. Remove redundant file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files: clang/include/clang-c/Index.h

[PATCH] D91944: OpenMP 5.0 metadirective

cchen updated this revision to Diff 372032. cchen added a comment. Herald added a reviewer: sscalpone. [OpenMP 5.0] metadirective This patch supports OpenMP 5.0 metadirective features. It is implemented keeping the OpenMP 5.1 features like dynamic user condition in mind. A new function,

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

waltl updated this revision to Diff 372031. waltl edited the summary of this revision. waltl added a comment. Merge arc-blocks-avoid-heapify.m into arc-blocks.m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

jdoerfert added a comment. Cool! We certainly need more tests but the design you came up with is certainly nicer than what I had in mind. One thing I wanted to do though is keep track of the constructs in the OpenMPIRBuilder instead. So move the /// Vector of declare variant construct

[PATCH] D109127: Fix python 2-vs-3 issues in add_new_check.py and rename_check.py

mattbeardsley added a comment. Thanks! I don't have commit access, I was just reading here what to do: > Prior to obtaining commit access, it is common practice to request that > someone with commit access commits on your

[PATCH] D109582: [clang-format] Restrict the special handling for K C to C/C++

This revision was automatically updated to reflect the committed changes. Closed by commit rG3205dd3d59b3: [clang-format] Restrict the special handling for KR C to C/C++ (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3205dd3 - [clang-format] Restrict the special handling for K C to C/C++

Author: owenca Date: 2021-09-10T15:51:35-07:00 New Revision: 3205dd3d59b3cc36f96b7eff6387de8d2f42825f URL: https://github.com/llvm/llvm-project/commit/3205dd3d59b3cc36f96b7eff6387de8d2f42825f DIFF: https://github.com/llvm/llvm-project/commit/3205dd3d59b3cc36f96b7eff6387de8d2f42825f.diff LOG:

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen added inline comments. Comment at: clang/test/OpenMP/declare_variant_construct_codegen_1.c:23 +#define N 100 + +void p_vxv(int *v1, int *v2, int *v3, int n); This test is from sollve test suite:

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:2346 - VMI.ConstructTraits.push_back(Selector.Properties.front().Kind); + // VMI.ConstructTraits.push_back(Selector.Properties.front().Kind); } I'm now removing this line

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen created this revision. cchen added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. cchen requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch supports construct trait set selector by using the

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu added a comment. In D91944#2990234 , @cchen wrote: > @alokmishra.besu do you mind if I push the patch for solving those assertions > with rebase? The patch does not change the logic in your program and I've > made sure that the tests

[PATCH] D106674: Runtime for Interop directive

RaviNarayanaswamy added inline comments. Comment at: openmp/libomptarget/src/interop.cpp:198-201 + if (interop_type == kmp_interop_type_tasksync) { +__kmpc_omp_wait_deps(loc_ref, gtid, ndeps, dep_list, ndeps_noalias, + noalias_dep_list); + }

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29b44ca896e7: [OpenMP] Add flag for setting debug in the offloading device (authored by jhuber6). Changed prior to commit:

[clang] 29b44ca - [OpenMP] Add flag for setting debug in the offloading device

Author: Joseph Huber Date: 2021-09-10T18:19:19-04:00 New Revision: 29b44ca896e7c5d9fef20f3660cbe5eb321b91ea URL: https://github.com/llvm/llvm-project/commit/29b44ca896e7c5d9fef20f3660cbe5eb321b91ea DIFF: https://github.com/llvm/llvm-project/commit/29b44ca896e7c5d9fef20f3660cbe5eb321b91ea.diff

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:8194 +if (seen.insert(M).second) { + S.addMethodToGlobalList(, M); +} manmanren wrote: > Does it make sense to check for duplication inside addMethodToGlobalList, as >

[PATCH] D109632: [clang] de-duplicate methods from AST files

manmanren added a comment. This looks good to me in general. Since it should not change functionality, it may not be possible to write a test case. Manman Comment at: clang/lib/Serialization/ASTReader.cpp:8194 +if (seen.insert(M).second) { +

[PATCH] D108243: Revert "Avoid needlessly copying a block to the heap when a block literal"

waltl added a comment. In D108243#2995476 , @ahatanak wrote: > Do you need `arc-blocks-avoid-heapify.m`? It seems like the other tests > already cover all the cases we care about. You're right much of it is redundant, but test10a() and test10b() are

[PATCH] D108243: Revert "Avoid needlessly copying a block to the heap when a block literal"

waltl updated this revision to Diff 372017. waltl added a comment. Delete redundant tests in arc-blocks-avoid-heapify.m. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243 Files:

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109544/new/ https://reviews.llvm.org/D109544

[PATCH] D106674: Runtime for Interop directive

jdoerfert added inline comments. Comment at: openmp/libomptarget/src/interop.cpp:198-201 + if (interop_type == kmp_interop_type_tasksync) { +__kmpc_omp_wait_deps(loc_ref, gtid, ndeps, dep_list, ndeps_noalias, + noalias_dep_list); + }

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz created this revision. rmaz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This diff will de-duplicate methods read from AST files before inserting them in to a global method pool list. When reading ObjCMethodDecl from AST files we

[PATCH] D108243: Revert "Avoid needlessly copying a block to the heap when a block literal"

ahatanak added a comment. Do you need `arc-blocks-avoid-heapify.m`? It seems like the other tests already cover all the cases we care about. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243

[PATCH] D106674: Runtime for Interop directive

RaviNarayanaswamy added inline comments. Comment at: openmp/libomptarget/src/interop.cpp:198-201 + if (interop_type == kmp_interop_type_tasksync) { +__kmpc_omp_wait_deps(loc_ref, gtid, ndeps, dep_list, ndeps_noalias, + noalias_dep_list); + }

[PATCH] D109621: [clang][Driver] Default to loading clang.cfg if config file not specified

Arfrever added inline comments. Comment at: clang/docs/UsersManual.rst:877 For example, if the Clang executable is named `armv7l-clang` (it may be a symbolic link to `clang`), then Clang will search for file `armv7l.cfg` in the +directories mentioned above. If the executable

[PATCH] D109506: [RFC] Print current request context along with the stack trance in clangd

sammccall added a comment. Well, thanks for such a well-thought-out patch :-) I have to admit my first reaction was terror, but this seems solid to me. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:1381 + auto = llvm::errs(); + OS << "Signalled during AST

[PATCH] D109609: [C++4OpenCL] Add support for multiple address spaced destructors

Anastasia added a comment. > The feature is also C++ for OpenCL specific to let the fast path remain when > not utilizing the > address spaces, as this new implementation will be slower than the bitfields > that C++ currently > uses, but I hope this can also be optimized in the future if it

[PATCH] D109118: [AArch64][SVE][InstCombine] Canonicalize aarch64_sve_dup_x intrinsic to IR splat operation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98c37247d81d: [AArch64][SVE][InstCombine] Canonicalize aarch64_sve_dup_x intrinsic to IR… (authored by mnadeem). Herald added a project: clang.

[PATCH] D109625: [compiler-rt] Ensure LIT_TEST_DEP targets are actually built

leonardchan created this revision. leonardchan added a reviewer: phosek. Herald added subscribers: mgorny, dberris. leonardchan requested review of this revision. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. When building compiler-rt via runtimes, many tests fail

[PATCH] D109158: [clang][deps] Test diagnostic options are being respected

jansvoboda11 added a comment. In D109158#2995095 , @supergrecko wrote: > Hi, are these test cases supposed to be under /llvm in the monorepo? Right > now they are at a new path, /llvm/clang/test/... which doesn't look right. You're right, thanks.

[clang] 285ec53 - [clang][deps] Move tests to the Clang subdirectory

Author: Jan Svoboda Date: 2021-09-10T21:36:49+02:00 New Revision: 285ec53730ce6dfecd2a4288388e6ba4f2bd17e4 URL: https://github.com/llvm/llvm-project/commit/285ec53730ce6dfecd2a4288388e6ba4f2bd17e4 DIFF: https://github.com/llvm/llvm-project/commit/285ec53730ce6dfecd2a4288388e6ba4f2bd17e4.diff

[PATCH] D108958: [OpenMP] Make CUDA math library functions SPMD amenable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf28e710db720: [OpenMP] Make CUDA math library functions SPMD amenable (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] f28e710 - [OpenMP] Make CUDA math library functions SPMD amenable

Author: Joseph Huber Date: 2021-09-10T14:52:45-04:00 New Revision: f28e710db720a913f4b508a9dc43f25e81629e72 URL: https://github.com/llvm/llvm-project/commit/f28e710db720a913f4b508a9dc43f25e81629e72 DIFF: https://github.com/llvm/llvm-project/commit/f28e710db720a913f4b508a9dc43f25e81629e72.diff

[PATCH] D109621: [clang][Driver] Default to loading clang.cfg if config file not specified

asymptotically created this revision. asymptotically added reviewers: rsmith, sepavloff. asymptotically added a project: clang. asymptotically requested review of this revision. Herald added a subscriber: cfe-commits. If a configuration file is not supplied (either via the driver name or through

[PATCH] D106674: Runtime for Interop directive

jdoerfert added inline comments. Comment at: openmp/libomptarget/src/interop.cpp:198-201 + if (interop_type == kmp_interop_type_tasksync) { +__kmpc_omp_wait_deps(loc_ref, gtid, ndeps, dep_list, ndeps_noalias, + noalias_dep_list); + }

[PATCH] D99901: [Driver][test] Test intended target only

thakis added inline comments. Comment at: clang/test/Driver/nostdincxx.cpp:4 // RUN: not %clangxx -nostdlibinc %s 2>&1 | FileCheck %s -// RUN: not %clangxx -fsyntax-only -nostdinc -nostdinc++ %s 2>&1 | FileCheck /dev/null --implicit-check-not=-Wunused-command-line-argument +//

[clang] 23f256f - [clang] Fix typo in test from a723310b4

Author: Nico Weber Date: 2021-09-10T14:16:45-04:00 New Revision: 23f256f2b19843fa08f83dce43bab362e8ce2235 URL: https://github.com/llvm/llvm-project/commit/23f256f2b19843fa08f83dce43bab362e8ce2235 DIFF: https://github.com/llvm/llvm-project/commit/23f256f2b19843fa08f83dce43bab362e8ce2235.diff

[PATCH] D109158: [clang][deps] Test diagnostic options are being respected

supergrecko added a comment. Hi, are these test cases supposed to be under /llvm in the monorepo? Right now they are at a new path, /llvm/clang/test/... which doesn't look right. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109158/new/

[clang] f3c2094 - [clang] `aligned_alloc` allocation function specifies alignment in first arg, manifest that knowledge

Author: Roman Lebedev Date: 2021-09-10T20:49:29+03:00 New Revision: f3c2094d8c112f40923ef45953f66c4b2ecb6d01 URL: https://github.com/llvm/llvm-project/commit/f3c2094d8c112f40923ef45953f66c4b2ecb6d01 DIFF: https://github.com/llvm/llvm-project/commit/f3c2094d8c112f40923ef45953f66c4b2ecb6d01.diff

[clang] 85ba583 - [NFCI][clang] Move allocation alignment manifestation for malloc-like into Sema from Codegen

Author: Roman Lebedev Date: 2021-09-10T20:49:28+03:00 New Revision: 85ba583eba1902c386a55f5565f3c721bd6bcb23 URL: https://github.com/llvm/llvm-project/commit/85ba583eba1902c386a55f5565f3c721bd6bcb23 DIFF: https://github.com/llvm/llvm-project/commit/85ba583eba1902c386a55f5565f3c721bd6bcb23.diff

[clang] 50d7ecc - [NFC][clang] Improve test coverage for alignment manifestation on aligned allocation functions

Author: Roman Lebedev Date: 2021-09-10T20:49:28+03:00 New Revision: 50d7ecc560b27d258c921abe39211926d46fbcff URL: https://github.com/llvm/llvm-project/commit/50d7ecc560b27d258c921abe39211926d46fbcff DIFF: https://github.com/llvm/llvm-project/commit/50d7ecc560b27d258c921abe39211926d46fbcff.diff

[PATCH] D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units

kamaub updated this revision to Diff 371954. kamaub added a comment. The condition for failing semantic chequing on mma builtins was incorrect, updating this patch to correctly check the semantics and associated testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

wmi accepted this revision. wmi added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109531/new/ https://reviews.llvm.org/D109531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109315: [clang] Check unsupported types in expressions

Fznamznon accepted this revision. Fznamznon added a comment. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109315/new/ https://reviews.llvm.org/D109315 ___ cfe-commits mailing list

[PATCH] D105937: [OpenMP] Encode `omp [...] assume[...]` assumptions with `omp[x]` prefix

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45e8e084921b: [OpenMP] Encode `omp [...] assume[...]` assumptions with `omp[x]` prefix (authored by jdoerfert). Changed prior to commit:

[clang] 45e8e08 - [OpenMP] Encode `omp [...] assume[...]` assumptions with `omp[x]` prefix

Author: Johannes Doerfert Date: 2021-09-10T12:08:52-05:00 New Revision: 45e8e084921b99ca36131d7f90359c70c4e1a25c URL: https://github.com/llvm/llvm-project/commit/45e8e084921b99ca36131d7f90359c70c4e1a25c DIFF:

[PATCH] D87118: Add an explicit toggle for the static analyzer in clang-tidy

arichardson added inline comments. Comment at: clang/lib/CMakeLists.txt:24 add_subdirectory(IndexSerialization) -if(CLANG_ENABLE_STATIC_ANALYZER) - add_subdirectory(StaticAnalyzer) arichardson wrote: > thakis wrote: > > hans wrote: > > > Why does removing the

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam updated this revision to Diff 371946. saiislam marked an inline comment as done. saiislam added a comment. Added documentation and other fixes suggested by reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/

[PATCH] D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source

arichardson created this revision. arichardson added reviewers: thakis, hans, tstellar. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, mgorny. arichardson requested review of this revision. Herald added projects:

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy updated this revision to Diff 371942. hoy added a comment. Updating D109531 : [CSSPGO] Enable pseudo probe instrumentation in O0 mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109531/new/

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy added a comment. In D109531#2994823 , @wmi wrote: > In D109531#2993484 , @hoy wrote: > >> In D109531#2993394 , @wmi wrote: >> >>> In D109531#2992721

[PATCH] D109506: [RFC] Print current request context along with the stack trance in clangd

0x1eaf added inline comments. Comment at: clang-tools-extra/clangd/support/ThreadSignalHandler.cpp:22 + ThreadSignalHandlerCallback *Callback = CurrentCallback.get(); + // TODO: ignore non thread local signals like SIGTERM + if (Callback) {

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

wmi added a comment. In D109531#2993484 , @hoy wrote: > In D109531#2993394 , @wmi wrote: > >> In D109531#2992721 , @hoy wrote: >> >>> In D109531#2992702

[PATCH] D87118: Add an explicit toggle for the static analyzer in clang-tidy

arichardson added inline comments. Herald added subscribers: manas, steakhal. Herald added a project: clang-tools-extra. Comment at: clang/lib/CMakeLists.txt:24 add_subdirectory(IndexSerialization) -if(CLANG_ENABLE_STATIC_ANALYZER) - add_subdirectory(StaticAnalyzer)

[PATCH] D109609: [C++4OpenCL] Add support for multiple address spaced destructors

olestrohm created this revision. olestrohm added reviewers: Anastasia, svenvh, rjmccall. olestrohm added a project: clang. Herald added subscribers: ldrumm, yaxunl. olestrohm requested review of this revision. Herald added a subscriber: cfe-commits. This patch aims to add initial support for

[PATCH] D109608: [clang][ASTImporter] Generic attribute import handling (first step).

balazske created this revision. Herald added subscribers: whisperity, martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

spupyrev added a comment. In D109531#2993394 , @wmi wrote: > In D109531#2992721 , @hoy wrote: > >> In D109531#2992702 , @wenlei wrote: >> >>> The change makes sense given

[PATCH] D109607: [X86][WIP] Refactor GetSSETypeAtOffset

pengfei created this revision. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109607 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D109361: [clang][Driver] Pick the last --driver-mode in case of multiple ones

hans added a comment. In D109361#2986687 , @hans wrote: > Thanks! I tried this locally and it fixes the issue I mentioned on D109361 > Corection: it fixes the issue that that I mentioned on D106789

[PATCH] D109315: [clang] Check unsupported types in expressions

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, let's wait for @Fznamznon though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109315/new/ https://reviews.llvm.org/D109315

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp:159 +// Note: This pointer has type 'const MemRegion *' +REGISTER_TRAIT_WITH_PROGRAMSTATE(EnvPtrRegion, const void *) + martong wrote: > Why is it `const

[PATCH] D109506: [RFC] Print current request context along with the stack trance in clangd

0x1eaf added a comment. Thank you for such a prompt and thorough review! Please consider all the comments I haven't replied to acknowledged and I'm going to resolve the issues with the next update. Comment at: clang-tools-extra/clangd/JSONTransport.cpp:117 + OS <<

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

ZarkoCA added inline comments. Comment at: clang/test/Driver/aix-toolchain-include.cpp:31 +// CHECK-INTERNAL-INCLUDE: "-isysroot" "[[SYSROOT:[^"]+]]" +// CHECK-INTERNAL-INCLUDE-CXX: "-internal-isystem" "[[SYSROOT]]/opt/IBM/openxlCSDK/include/c++/v1" +//

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

saghir updated this revision to Diff 371919. saghir added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109126/new/ https://reviews.llvm.org/D109126 Files: clang/test/CodeGen/builtins-ppc-pair-mma.c

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:233 +if (Opts.HIP && Opts.CUDAIsDevice) + // Enable address space mapping from HIP to SPIR-V. + // See comment on the SPIRDefIsGenMap table. My guess is that this is not

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in bader

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

martong added a comment. Nice work! Comment at: clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp:159 +// Note: This pointer has type 'const MemRegion *' +REGISTER_TRAIT_WITH_PROGRAMSTATE(EnvPtrRegion, const void *) + Why is it `const void *`? Why

[PATCH] D109366: [OpenCL] Tests C++ for OpenCL version macros

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109366/new/ https://reviews.llvm.org/D109366 ___ cfe-commits mailing

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks. Please, address suggested test simplifications in the final commit if applicable. I am also not sure if more types should be tested from the data layout... but my guess

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/spirv32_target.cl:12 +kernel void foo(global long *arg) { + int res1[sizeof(my_st) == 12 ? 1 : -1]; + int res2[sizeof(void *) == 4 ? 1 : -1]; linjamaki wrote: > Anastasia wrote: > > Are

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

jhuber6 updated this revision to Diff 371914. jhuber6 added a comment. Adding constant to `llvm.used`. This is most likely easier than dealing with weak external linkage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109544/new/

[PATCH] D109315: [clang] Check unsupported types in expressions

asavonic updated this revision to Diff 371912. asavonic added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109315/new/ https://reviews.llvm.org/D109315 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D109592: [clang-offload-bundler] Fix compatibility testing for non-assert builds

This revision was automatically updated to reflect the committed changes. saiislam marked an inline comment as done. Closed by commit rG4a25c3fb6194: [clang-offload-bundler] Fix compatibility testing for non-assert builds (authored by saiislam). Changed prior to commit:

[clang] 4a25c3f - [clang-offload-bundler] Fix compatibility testing for non-assert builds

Author: Saiyedul Islam Date: 2021-09-10T18:57:03+05:30 New Revision: 4a25c3fb61942c629907ae50462087c3fbb8703a URL: https://github.com/llvm/llvm-project/commit/4a25c3fb61942c629907ae50462087c3fbb8703a DIFF:

[PATCH] D109541: Increase expected line number for ExtDebugInfo.cpp

Jake-Egan updated this revision to Diff 371908. Jake-Egan added a comment. Added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109541/new/ https://reviews.llvm.org/D109541 Files: clang/test/Modules/ExtDebugInfo.cpp Index:

[PATCH] D109592: [clang-offload-bundler] Fix compatibility testing for non-assert builds

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM with one minor Comment at: clang/test/Driver/clang-offload-bundler-asserts-on.c:6 + +// RUN: %clang -O0 -target %itanium_abi_triple %s -c -o %t.o +// RUN: echo

[PATCH] D109158: [clang][deps] Test diagnostic options are being respected

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7afabc2e4e86: [clang][deps] Test diagnostic options are being respected (authored by jansvoboda11). Herald added a project: LLVM. Herald added a

[clang] 993f60a - [clang][deps] Sanitize both instances of DiagnosticOptions

Author: Jan Svoboda Date: 2021-09-10T14:47:21+02:00 New Revision: 993f60ae32de001ac9ac1ff512f2adf339e265c8 URL: https://github.com/llvm/llvm-project/commit/993f60ae32de001ac9ac1ff512f2adf339e265c8 DIFF: https://github.com/llvm/llvm-project/commit/993f60ae32de001ac9ac1ff512f2adf339e265c8.diff

[PATCH] D109592: [clang-offload-bundler] Fix compatibility testing for non-assert builds

saiislam updated this revision to Diff 371895. saiislam added a comment. Moved debug-only based tests to a separate file which requires "asserts". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109592/new/ https://reviews.llvm.org/D109592 Files:

[PATCH] D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units

kamaub created this revision. kamaub added reviewers: PowerPC, nemanjai, lei, saghir, stefanp. Herald added subscribers: steven.zhang, shchenz, kbarton. kamaub requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch allows the use

[PATCH] D109592: [clang-offload-bundler] Fix compatibility testing for non-assert builds

RKSimon added a comment. Could you keep the test coverage by splitting off the debug tests into another file with a "REQUIRES: assert" lit tag? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109592/new/ https://reviews.llvm.org/D109592

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

martong added a comment. > And about `checkDeadSymbols`, I get your point, but I am interested why > checker has different behavior on these two examples: > > a1 int main(int argc, char **argv, char *envp[]) { > a2 putenv((char*) "NAME=VALUE"); // envp invalidated > a3 envp[0]; //

[clang] fbe00c6 - [OpenCL][Docs] Update OpenCL 3.0 status info.

Author: Anastasia Stulova Date: 2021-09-10T13:07:07+01:00 New Revision: fbe00c6874f1f0c496d64933a1a899448b2a URL: https://github.com/llvm/llvm-project/commit/fbe00c6874f1f0c496d64933a1a899448b2a DIFF:

[PATCH] D108974: [clang][tooling] Properly initialize DiagnosticsEngine for cc1 command-line construction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8dc76ab7995b: [clang][tooling] Properly initialize DiagnosticsEngine for cc1 command-line… (authored by jansvoboda11). Repository: rG LLVM Github

[clang] 8dc76ab - [clang][tooling] Properly initialize DiagnosticsEngine for cc1 command-line construction

Author: Jan Svoboda Date: 2021-09-10T13:54:24+02:00 New Revision: 8dc76ab7995b6dbc50dd9472f95c40484396b90e URL: https://github.com/llvm/llvm-project/commit/8dc76ab7995b6dbc50dd9472f95c40484396b90e DIFF: https://github.com/llvm/llvm-project/commit/8dc76ab7995b6dbc50dd9472f95c40484396b90e.diff

[PATCH] D108982: [clang][deps] Use correct DiagnosticOptions for command-line handling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e760b590261: [clang][deps] Use correct DiagnosticOptions for command-line handling (authored by jansvoboda11). Changed prior to commit:

[clang] 1e760b5 - [clang][deps] Use correct DiagnosticOptions for command-line handling

Author: Jan Svoboda Date: 2021-09-10T13:44:35+02:00 New Revision: 1e760b5902615c38079948f31a96724a88a75dd8 URL: https://github.com/llvm/llvm-project/commit/1e760b5902615c38079948f31a96724a88a75dd8 DIFF: https://github.com/llvm/llvm-project/commit/1e760b5902615c38079948f31a96724a88a75dd8.diff

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki updated this revision to Diff 371877. linjamaki added a comment. Enable HIP-to-SPIR-V address space mapping only for SPIR-V targets. Patch now depends on D109144 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108976: [clang][tooling] Accept custom diagnostic options in ToolInvocation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe08911e17b2b: [clang][tooling] Accept custom diagnostic options in ToolInvocation (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[clang] e08911e - [clang][tooling] Accept custom diagnostic options in ToolInvocation

Author: Jan Svoboda Date: 2021-09-10T13:31:17+02:00 New Revision: e08911e17b2bf7030a587bbf158e6a4fe0164f38 URL: https://github.com/llvm/llvm-project/commit/e08911e17b2bf7030a587bbf158e6a4fe0164f38 DIFF: https://github.com/llvm/llvm-project/commit/e08911e17b2bf7030a587bbf158e6a4fe0164f38.diff

  1   2   >