[PATCH] D115573: [Clang][OpenMP] Return error ahead of time if there are multiple mutex clauses in atomic directive

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Currently if there are multiple

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 updated this revision to Diff 393656. tianshilei1992 added a comment. rebase and remove unnecessary changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 Files:

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

rnk added a subscriber: mstorsjo. rnk added a comment. I seem to recall assuming that Windows `long double` was 64-bits in many, many places. Unfortunately, I have no idea where that could've happened. Something that comes to mind immediately is the MSVC name mangler. I don't think that's a

[PATCH] D94355: [Passes] Add relative lookup table converter pass

gulfem added inline comments. Comment at: llvm/lib/Transforms/Utils/RelLookupTableConverter.cpp:132 + // Place new instruction sequence after GEP. + Builder.SetInsertPoint(GEP); + Value *Index = GEP->getOperand(2); jrtc27 wrote: > This line causes the bug

[clang] cdd5fb6 - [NFC][Clang] clang-format -i clang/lib/Sema/SemaOpenMP.cpp

Author: Shilei Tian Date: 2021-12-10T22:05:25-05:00 New Revision: cdd5fb6e19c81c1a9c1eac22e7ac48d5b33abc3d URL: https://github.com/llvm/llvm-project/commit/cdd5fb6e19c81c1a9c1eac22e7ac48d5b33abc3d DIFF: https://github.com/llvm/llvm-project/commit/cdd5fb6e19c81c1a9c1eac22e7ac48d5b33abc3d.diff

[PATCH] D115567: [Sema] Add FixIt when a C++ out-of-line method has extra/missing const

sammccall created this revision. sammccall added a reviewer: hokein. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D115567 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

schittir updated this revision to Diff 393642. schittir marked an inline comment as done. schittir added a comment. 1. Removed returnNullTBAA() method 2. Add NO-TBAA check-prefix to the test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320

[clang-tools-extra] ac431fc - [clangd] ... and mark a new test as -fno-ms-compatibility too

Author: Sam McCall Date: 2021-12-11T02:41:39+01:00 New Revision: ac431fc2cdf1457a286d86be57c0771ce42c0965 URL: https://github.com/llvm/llvm-project/commit/ac431fc2cdf1457a286d86be57c0771ce42c0965 DIFF: https://github.com/llvm/llvm-project/commit/ac431fc2cdf1457a286d86be57c0771ce42c0965.diff

[clang] 30fc88b - Revert "Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM"""

Author: Med Ismail Bennani Date: 2021-12-10T17:33:54-08:00 New Revision: 30fc88bf1dc15a72e2d9809d28019d386b7a7cc0 URL: https://github.com/llvm/llvm-project/commit/30fc88bf1dc15a72e2d9809d28019d386b7a7cc0 DIFF:

[clang-tools-extra] 1a68c14 - [clangd] Restore -fno-ms-compatibility to tests

Author: Sam McCall Date: 2021-12-11T02:31:26+01:00 New Revision: 1a68c14b577fd1b1ebfd6a064dd5faeda07042aa URL: https://github.com/llvm/llvm-project/commit/1a68c14b577fd1b1ebfd6a064dd5faeda07042aa DIFF: https://github.com/llvm/llvm-project/commit/1a68c14b577fd1b1ebfd6a064dd5faeda07042aa.diff

[PATCH] D114095: [clang][lex] Include tracking: simplify and move to preprocessor

vsapsai added a comment. Thanks for measuring the .pcm impact! And I appreciate including the trunk baseline. The results aren't exactly the same I've seen before, so please forgive me my suspiciousness. When you mention > current trunk with this patch do you mean "just this D114095

[PATCH] D115484: [clangd] Include-fixer: handle more "incomplete type" diags, clean up tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rGc25ea488a39a: [clangd] Include-fixer: handle more incomplete type diags. (authored by sammccall).

[clang-tools-extra] c25ea48 - [clangd] Include-fixer: handle more "incomplete type" diags.

Author: Sam McCall Date: 2021-12-11T01:46:35+01:00 New Revision: c25ea488a39a090d43c0fd6dd68fdc26dc563708 URL: https://github.com/llvm/llvm-project/commit/c25ea488a39a090d43c0fd6dd68fdc26dc563708 DIFF: https://github.com/llvm/llvm-project/commit/c25ea488a39a090d43c0fd6dd68fdc26dc563708.diff

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 updated this revision to Diff 393634. tianshilei1992 added a comment. continue to remove more unrelated code changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 Files:

[clang-tools-extra] a8bf389 - [clangd] Clean up some include-fixer tests. NFC

Author: Sam McCall Date: 2021-12-11T01:31:03+01:00 New Revision: a8bf389f41465415fa9088609956dfd3e153e9cf URL: https://github.com/llvm/llvm-project/commit/a8bf389f41465415fa9088609956dfd3e153e9cf DIFF: https://github.com/llvm/llvm-project/commit/a8bf389f41465415fa9088609956dfd3e153e9cf.diff

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 updated this revision to Diff 393633. tianshilei1992 added a comment. further remove code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 Files: clang/include/clang/AST/OpenMPClause.h

Re: [clang] 9791b58 - [C++20 Modules] Don't create global module fragment for extern linkage declaration in GMF already

On Wed, 8 Dec 2021 at 21:56, Chuanqi Xu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Chuanqi Xu > Date: 2021-12-09T13:55:15+08:00 > New Revision: 9791b589516b644a6273607b46a9c6661993d667 > > URL: >

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

nickdesaulniers updated this revision to Diff 393630. nickdesaulniers added a comment. - fix typo in release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115471/new/ https://reviews.llvm.org/D115471 Files: clang/docs/ReleaseNotes.rst

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 updated this revision to Diff 393629. tianshilei1992 added a comment. remove useless code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

tianshilei1992 added a comment. I created a patch D115561 for parser. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102449/new/ https://reviews.llvm.org/D102449 ___

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev, carlo.bertolli. Herald added subscribers: arphaman, guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects:

[PATCH] D94355: [Passes] Add relative lookup table converter pass

jrtc27 added inline comments. Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:395 +/// in 64-bit achitectures where 32-bit offsets might not be enough. +if (TM.getCodeModel() == CodeModel::Medium || +TM.getCodeModel() == CodeModel::Large)

[PATCH] D113146: [Sema] Fix the assertion in Sema::ActOnDependentMemberExpr

ychen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113146/new/ https://reviews.llvm.org/D113146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94355: [Passes] Add relative lookup table converter pass

jrtc27 added inline comments. Comment at: llvm/lib/Transforms/Utils/RelLookupTableConverter.cpp:132 + // Place new instruction sequence after GEP. + Builder.SetInsertPoint(GEP); + Value *Index = GEP->getOperand(2); This line causes the bug seen in bind. In

[clang] 7c004c2 - Revert "[asan] Add support for disable_sanitizer_instrumentation attribute"

Author: Andrew Browne Date: 2021-12-10T14:33:38-08:00 New Revision: 7c004c2bc999186884a343989b523dacef02cda9 URL: https://github.com/llvm/llvm-project/commit/7c004c2bc999186884a343989b523dacef02cda9 DIFF: https://github.com/llvm/llvm-project/commit/7c004c2bc999186884a343989b523dacef02cda9.diff

[PATCH] D115544: Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM""

Ericson2314 added a comment. Sorry for this new build failure. I think I found the culprit and fixed it with https://reviews.llvm.org/D115553 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115544/new/ https://reviews.llvm.org/D115544

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

danalbert accepted this revision. danalbert added a comment. This revision is now accepted and ready to land. LGTM once the comments are addressed. (I'd also approve the alternative approach discussed in the thread of searching each older API level directory, but have no preference one way or

[PATCH] D115544: Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM""

Ericson2314 added a comment. I see a build failure in https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ and think I know how to fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115544/new/ https://reviews.llvm.org/D115544

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

rjmccall added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:14583 if (Second && Second->getObjectKind() == OK_ObjCProperty) { ExprResult Result = SemaRef.CheckPlaceholderExpr(Second); rnk wrote: > This is also pseudo object handling code

[PATCH] D94355: [Passes] Add relative lookup table converter pass

dim added subscribers: emaste, jrtc27, dim. dim added a comment. FWIW, this commit turned out to break the FreeBSD dns/bind916 port, see https://bugs.freebsd.org/259921. The short story is that the bind9 code on and after this line:

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

nickdesaulniers updated this revision to Diff 393577. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - note this semantic change in the release notes, add links to GCC docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115544: Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM""

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG492de35df443: Revert Revert Use `GNUInstallDirs` to support custom installation dirs. (authored by Ericson2314). Repository: rG LLVM Github

[clang] 492de35 - Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM""

Author: John Ericson Date: 2021-12-10T20:59:43Z New Revision: 492de35df443d5f31480173d5f1274c7835cd3d8 URL: https://github.com/llvm/llvm-project/commit/492de35df443d5f31480173d5f1274c7835cd3d8 DIFF: https://github.com/llvm/llvm-project/commit/492de35df443d5f31480173d5f1274c7835cd3d8.diff LOG:

[PATCH] D115544: Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM""

Ericson2314 added a comment. This pre-merge build failure is in the ASAN tests and thus seems entirely unrelated, so I cam going to land this is and watch careful as instructed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115544/new/

[PATCH] D112761: cfi-icall: Add -fsanitize-cfi-promotion-aliases

samitolvanen abandoned this revision. samitolvanen added a comment. See https://reviews.llvm.org/D113613. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112761/new/ https://reviews.llvm.org/D112761 ___

[clang] 17414b6 - Fix shared build of unittests.

Author: Michael Liao Date: 2021-12-10T15:33:56-05:00 New Revision: 17414b61245dcd3ae96c447762e8f776856a733c URL: https://github.com/llvm/llvm-project/commit/17414b61245dcd3ae96c447762e8f776856a733c DIFF: https://github.com/llvm/llvm-project/commit/17414b61245dcd3ae96c447762e8f776856a733c.diff

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

yaxunl added a comment. In D110549#3185409 , @linjamaki wrote: > Assuming this patch is ready to land. @yaxunl, Could you please commit this > patch to the LLVM for us. Thanks. I will test it with our internal CI, then commit it. Repository: rG

[PATCH] D115503: [DebugInfo] emit DW_AT_accessibility attribute for class/struct/union types.

dblaikie added a comment. Generally sounds OK to me - this should be submitted as two separate patches. The LLVM part first, followed by the Clang part (since they can be separated they should be, and I guess the order doesn't matter too much (since the new IR that Clang's generating won't be

[PATCH] D115544: Revert "Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM""

Ericson2314 created this revision. Herald added subscribers: ormris, jvesely, steven_wu, hiraditya, mgorny. Ericson2314 requested review of this revision. Herald added projects: clang, LLDB, OpenMP, LLVM. Herald added subscribers: llvm-commits, openmp-commits, lldb-commits, cfe-commits. This

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

Anastasia added inline comments. Comment at: clang/docs/UsersManual.rst:3559 +by the OpenCL driver that support SPIR-V consumption or it can be compiled further +by offline SPIR-V consumer tools. + Btw do we want to say anything about the limitations of

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam updated this revision to Diff 393532. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 Files: clang/include/clang/AST/CXXRecordDeclDefinitionBits.def clang/include/clang/AST/DeclCXX.h clang/include/clang/Basic/Attr.td

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna updated this revision to Diff 393531. luna added a comment. Remove verbose attributes from test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115492/new/ https://reviews.llvm.org/D115492 Files:

[PATCH] D112915: [clang][modules] Track included files per submodule

jansvoboda11 added a comment. In D112915#3141417 , @vsapsai wrote: > I think AST format for `IncludedFiles` was discussed here, so I'll continue > here though the bulk of implementation is in D114095 > now. Have you

[PATCH] D114095: [clang][lex] Include tracking: simplify and move to preprocessor

jansvoboda11 added a comment. In D114095#3160103 , @vsapsai wrote: > I've mentioned it in D112915 as we've > discussed the stored data format there. But my concern was that bitvector > packing might be not the most

[PATCH] D115355: Fix build failure with GCC 11 in C++20 mode

dexonsmith accepted this revision. dexonsmith added a comment. LGTM too. Comment at: clang/lib/AST/ASTImporter.cpp:8400-8403 + AttrArgImporter(const AttrArgImporter &) = delete; + AttrArgImporter(AttrArgImporter &&) = default; AttrArgImporter =(const AttrArgImporter &) =

[PATCH] D105555: [RISCV][Clang] Compute the default target-abi if it's empty.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57b5f4b2ecc6: [RISCV][Clang] Compute the default target-abi if its empty. (authored by khchen). Changed prior to commit:

[clang] 57b5f4b - [RISCV][Clang] Compute the default target-abi if it's empty.

Author: Zakk Chen Date: 2021-12-10T08:54:23-08:00 New Revision: 57b5f4b2ecc6aeed5328086aa533d706adb008d1 URL: https://github.com/llvm/llvm-project/commit/57b5f4b2ecc6aeed5328086aa533d706adb008d1 DIFF: https://github.com/llvm/llvm-project/commit/57b5f4b2ecc6aeed5328086aa533d706adb008d1.diff

Re: [PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

Sounds good to me. Thanks for pushing on this! On Wed, Dec 8, 2021 at 4:47 AM Salman Javed via Phabricator < revi...@reviews.llvm.org> wrote: > salman-javed-nz added a comment. > > Hi, just giving a progress update. This is just a early heads-up - no > action needed from you at this stage. > > I

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

ymandel updated this revision to Diff 393513. ymandel added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. renames the `testing` namespace to `test` cleans up the code the implementation of `operator<<` for dataflow state. Repository: rG LLVM Github

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Great! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115168/new/ https://reviews.llvm.org/D115168 ___ cfe-commits mailing list

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a399bf4b3aa: [analyzer] Implemented RangeSet::Factory::unite

[clang] 6a399bf - [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

Author: Denys Petrov Date: 2021-12-10T18:48:02+02:00 New Revision: 6a399bf4b3aa32a87fb04dd1deb05f0066810a05 URL: https://github.com/llvm/llvm-project/commit/6a399bf4b3aa32a87fb04dd1deb05f0066810a05 DIFF: https://github.com/llvm/llvm-project/commit/6a399bf4b3aa32a87fb04dd1deb05f0066810a05.diff

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov updated this revision to Diff 393509. ASDenysPetrov added a comment. Fixed code formatting in the unit test file according to remarks. Ready to load. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 Files:

[PATCH] D115484: [clangd] Include-fixer: handle more "incomplete type" diags, clean up tests

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeFixer.cpp:75 + /* + There are many "incomplete type" diagnostics! + They are almost all Sema diagnostics with "incomplete" in the name. have you considered updating these

[clang] 78ff12d - Revert "[clang][dataflow] Add framework for testing analyses."

Author: Nico Weber Date: 2021-12-10T11:06:40-05:00 New Revision: 78ff12da1115abcaf4cbf50b605a197011505646 URL: https://github.com/llvm/llvm-project/commit/78ff12da1115abcaf4cbf50b605a197011505646 DIFF: https://github.com/llvm/llvm-project/commit/78ff12da1115abcaf4cbf50b605a197011505646.diff

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! I agree according to the OpenCL programming model attributes `internal spir_kernel` together on the same function create a contradiction because kernel functions are expected to

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

thakis added a comment. Looks like this breaks building on Windows: http://45.33.8.238/win/50614/step_4.txt Please take a look! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115341/new/ https://reviews.llvm.org/D115341

[PATCH] D115346: [clang][deps] Squash caches for original and minimized files

jansvoboda11 marked 3 inline comments as done. jansvoboda11 added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:106-108 + std::unique_ptr OriginalContents; + std::unique_ptr MinimizedContents;

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

svenvh created this revision. svenvh added reviewers: Anastasia, yaxunl. svenvh added a project: clang. Herald added a subscriber: ldrumm. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. All kernels can be called from the host as per the SPIR_KERNEL calling

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a40df638181: [clang][dataflow] Add framework for testing analyses. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 5a40df6 - [clang][dataflow] Add framework for testing analyses.

Author: Yitzhak Mandelbaum Date: 2021-12-10T15:24:12Z New Revision: 5a40df6381819b38df66e4b6eaa02e7140e07a0c URL: https://github.com/llvm/llvm-project/commit/5a40df6381819b38df66e4b6eaa02e7140e07a0c DIFF: https://github.com/llvm/llvm-project/commit/5a40df6381819b38df66e4b6eaa02e7140e07a0c.diff

[PATCH] D114703: [AArch64] Use Feature for A53 Erratum 835769 Fix

This revision was automatically updated to reflect the committed changes. Closed by commit rG52faad83c9f8: [AArch64] Use Feature for A53 Erratum 835769 Fix (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114703/new/

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

ymandel updated this revision to Diff 393477. ymandel added a comment. Remove the SFINAE guard and add `operator<<` for `NoopLattice` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115341/new/ https://reviews.llvm.org/D115341 Files:

[PATCH] D115521: [Templight] Don't return string for name for unnamed template parameters

Szelethus created this revision. Szelethus added reviewers: sabel83, xazax.hun, rsmith, whisperity, martong, mikael-s-persson, mclow.lists. Szelethus added a project: clang. Herald added subscribers: steakhal, gamesh411, dkrupp, rnkovacs. Szelethus requested review of this revision. Herald added

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

MyDeveloperDay updated this revision to Diff 393474. MyDeveloperDay added a comment. Thank @HazardyKnusperkeks you got me over the line, I was able to escape the `[` but not the `]` so I used your trick there "R\"(([\\[A-Za-z0-9_{}#<>%:;.?*+/^&\\$|~!=,'\\-]|])*)\\(" Add unit tests to cover

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki added a comment. Assuming this patch is ready to land. @yaxunl, Could you please commit this patch to the LLVM for us. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM! --- > The problem is these methods yield SymbolSlabs, and the symbols within them > are frozen/const. There's no provision to "just tweak some bitfield" - we'd > have to

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:47-48 +template () + << std::declval())> +std::ostream <<(std::ostream , This SFINAE guard doesn't work on some platforms, as

[clang] 28d3976 - Revert "[clang][dataflow] Add framework for testing analyses."

Author: Yitzhak Mandelbaum Date: 2021-12-10T14:27:15Z New Revision: 28d3976819c9d0921c6118c3f8fee9297380ddae URL: https://github.com/llvm/llvm-project/commit/28d3976819c9d0921c6118c3f8fee9297380ddae DIFF: https://github.com/llvm/llvm-project/commit/28d3976819c9d0921c6118c3f8fee9297380ddae.diff

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

erichkeane added a comment. In D114639#3183244 , @Meinersbur wrote: > ping? > > @erichkeane Since you are pushing for upgrade the gcc/clang requirement as > well, would you take care of that? I was looking into the patch to do so, but I don't have a

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

HazardyKnusperkeks added a comment. In D115168#3185199 , @MyDeveloperDay wrote: > Add support for | but still can't get [] to work in the regex (checked the > unit tests for Support/Regex and its not clear if its supported) How about

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki updated this revision to Diff 393465. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Driver/Driver.cpp

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47d526d67e3c: [clang][dataflow] Add framework for testing analyses. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 47d526d - [clang][dataflow] Add framework for testing analyses.

Author: Yitzhak Mandelbaum Date: 2021-12-10T14:00:36Z New Revision: 47d526d67e3cc66771eed1d0b607226a4fb9a5b5 URL: https://github.com/llvm/llvm-project/commit/47d526d67e3cc66771eed1d0b607226a4fb9a5b5 DIFF: https://github.com/llvm/llvm-project/commit/47d526d67e3cc66771eed1d0b607226a4fb9a5b5.diff

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

ymandel updated this revision to Diff 393460. ymandel added a comment. add missing build dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115341/new/ https://reviews.llvm.org/D115341 Files:

[PATCH] D115355: Fix build failure with GCC 11 in C++20 mode

Godin added a comment. Thank you for the review @shafik ! As a note: this change is similar to the https://reviews.llvm.org/rG95d0d8e9e9d10da3cfa503fbba405e740aea3cc1 by @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115355/new/

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

danielkiss added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:372 + if (Arch.empty()) +return true; + I'd play safe and return false here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 77e9d36 - [clang][dataflow] Fix build breakage from commit 8dcaf3aa0bf25508700a7452ed963c1487221dfd

Author: Yitzhak Mandelbaum Date: 2021-12-10T12:55:48Z New Revision: 77e9d36a785ab12f3840c522fd357575929df92c URL: https://github.com/llvm/llvm-project/commit/77e9d36a785ab12f3840c522fd357575929df92c DIFF: https://github.com/llvm/llvm-project/commit/77e9d36a785ab12f3840c522fd357575929df92c.diff

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 added a comment. @mib Can you help me reproduce? I ran cmake -G Ninja .. -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_INSTALL_PREFIX="$HOME/tmp/out" -DLLDB_TEST_USER_ARGS="--arch;x86_64;--build-dir;$HOME/tmp/out/lldb-test-build.noindex;-t;--env;TERM=vt100"

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

MyDeveloperDay updated this revision to Diff 393448. MyDeveloperDay added a comment. Add support for | but still can't get [] to work in the regex (checked the unit tests for Support/Regex and its not clear if its supported) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115168/new/

[PATCH] D115235: [clang][dataflow] Implement a basic algorithm for dataflow analysis

thakis added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/CMakeLists.txt:1 +set(LLVM_LINK_COMPONENTS + Support sgatev wrote: > ymandel wrote: > > Why create a new sub directory? From what I've seen elsewhere, it seems > > uncommon. I'm

[PATCH] D115510: [clang][OpenMP][DebugInfo] Debug support for variables in shared clause of OpenMP task construct

alok created this revision. alok added reviewers: aprantl, djtodoro, jdoerfert, jini.susan.george. alok added a project: debug-info. Herald added subscribers: guansong, yaxunl. alok requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang.

[PATCH] D115442: [clangd] Provide documentation as MarkupContent in signaturehelp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3606a3375d2: [clangd] Provide documentation as MarkupContent in signaturehelp (authored by kadircet). Repository: rG LLVM Github Monorepo

[clang-tools-extra] d3606a3 - [clangd] Provide documentation as MarkupContent in signaturehelp

Author: Kadir Cetinkaya Date: 2021-12-10T12:58:08+01:00 New Revision: d3606a3375d258c67c061a97901faca53c4032da URL: https://github.com/llvm/llvm-project/commit/d3606a3375d258c67c061a97901faca53c4032da DIFF:

[PATCH] D115507: Add PACBTI-M support to LLVM release notes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfbf489cd1b4b: Add PACBTI-M support to LLVM release notes. (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115442: [clangd] Provide documentation as MarkupContent in signaturehelp

kadircet updated this revision to Diff 393438. kadircet marked 2 inline comments as done. kadircet added a comment. - Drop extra tests - Move capability closer to others Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115442/new/

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

brunodf requested review of this revision. brunodf added a comment. A stage2 build (outside of the buildloops) is now working correctly. Pinging for new review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111639/new/

[PATCH] D115507: Add PACBTI-M support to LLVM release notes.

vhscampos accepted this revision. vhscampos added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115507/new/ https://reviews.llvm.org/D115507

[PATCH] D115507: Add PACBTI-M support to LLVM release notes.

stuij updated this revision to Diff 393434. stuij added a comment. removed accidentally included Clang release notes draft Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115507/new/ https://reviews.llvm.org/D115507 Files:

[PATCH] D115507: Add PACBTI-M support to LLVM release notes.

stuij created this revision. stuij requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Clang release note changes will be added once the last PACBTI-M command line patch lands. Repository: rG LLVM Github Monorepo

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b554920f11c: [asan] Add support for disable_sanitizer_instrumentation attribute (authored by glider). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2b55492 - [asan] Add support for disable_sanitizer_instrumentation attribute

Author: Alexander Potapenko Date: 2021-12-10T12:17:26+01:00 New Revision: 2b554920f11c8b763cd9ed9003f4e19b919b8e1f URL: https://github.com/llvm/llvm-project/commit/2b554920f11c8b763cd9ed9003f4e19b919b8e1f DIFF:

[PATCH] D115503: [DebugInfo] emit DW_AT_accessibility attribute for class/struct/union types.

Esme created this revision. Esme added reviewers: shchenz, probinson, dblaikie, jhenderson, aprantl, PowerPC. Herald added a subscriber: hiraditya. Esme requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch emits

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra created this revision. amilendra added reviewers: chill, vhscampos. Herald added a subscriber: kristof.beyls. Herald added a reviewer: aaron.ballman. amilendra requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Branch protection in

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

krisb added a comment. @rtrieu, thank you for looking at this! Do you have any comments about the rest of the patch? Do you think it makes sense? Comment at: clang/test/Modules/odr_hash.cpp:4288 S s; +// expected-error@first.h:* {{'ParameterTest::S::Foo' has different

[PATCH] D115235: [clang][dataflow] Implement a basic algorithm for dataflow analysis

This revision was automatically updated to reflect the committed changes. Closed by commit rG8dcaf3aa0bf2: [clang][dataflow] Implement a basic algorithm for dataflow analysis (authored by sgatev, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8dcaf3a - [clang][dataflow] Implement a basic algorithm for dataflow analysis

Author: Stanislav Gatev Date: 2021-12-10T11:44:49+01:00 New Revision: 8dcaf3aa0bf25508700a7452ed963c1487221dfd URL: https://github.com/llvm/llvm-project/commit/8dcaf3aa0bf25508700a7452ed963c1487221dfd DIFF:

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

jeroen.dobbelaere added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2511 +return LValue::MakeAddr(Addr, T, getContext(), LValueBaseInfo(Source), +CGM.returnNullTBAA()); + } Looking at how a 'null tbaa'is

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna updated this revision to Diff 393392. luna added a comment. Revert unit test that shouldn't be affected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115492/new/ https://reviews.llvm.org/D115492 Files:

[PATCH] D114569: [PowerPC] Require htm feature for HTM builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3cd0635e15a: [PowerPC] Require htm feature for HTM builtins (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   >