[PATCH] D115231: [Clang] Add __builtin_reduce_xor

junaire updated this revision to Diff 395791. junaire added a comment. - rebase to main. - rename `PrepareBuiltinReduceMathOneArg` to `prepareBuiltinReduceMathOneArgCall`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/

[PATCH] D116098: [C++20] [Modules] Mark imported module as imported if not exported

ChuanqiXu updated this revision to Diff 395789. ChuanqiXu added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116098/new/ https://reviews.llvm.org/D116098 Files: clang/lib/Sema/SemaModule.cpp clang/test/Modules/module-transtive-instantiation.cpp Index:

[clang] 9effb6f - [NFC] Use %clang_cc instead of %clang in c++20 module tests

Author: Chuanqi Xu Date: 2021-12-22T11:50:47+08:00 New Revision: 9effb6f81620058b57316401807b23db99e1682d URL: https://github.com/llvm/llvm-project/commit/9effb6f81620058b57316401807b23db99e1682d DIFF: https://github.com/llvm/llvm-project/commit/9effb6f81620058b57316401807b23db99e1682d.diff

[PATCH] D116097: [NFC] [C++20] [Modules] Add tests for template instantiation in transitive imported module

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG759f3e297c07: [NFC] [C++20] [Modules] Add tests for template instantiation in transitively… (authored by ChuanqiXu). Repository: rG LLVM Github

[clang] 759f3e2 - [NFC] [C++20] [Modules] Add tests for template instantiation in transitively imported module

Author: Chuanqi Xu Date: 2021-12-22T11:09:41+08:00 New Revision: 759f3e297c072165d044a3ac6fa3fc2f30df86ab URL: https://github.com/llvm/llvm-project/commit/759f3e297c072165d044a3ac6fa3fc2f30df86ab DIFF: https://github.com/llvm/llvm-project/commit/759f3e297c072165d044a3ac6fa3fc2f30df86ab.diff

[PATCH] D116097: [NFC] [C++20] [Modules] Add tests for template instantiation in transitive imported module

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Now the windows tests passed, this should be good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116097/new/ https://reviews.llvm.org/D116097

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added a comment. In D102669#3199270 , @steakhal wrote: > We shouldn't skip mac targets. I CC ASTImporter folks, they probably have an > M1 . I am not intended to ignore this problem triggered on M1

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

shchenz added inline comments. Comment at: clang/test/ASTMerge/anonymous-fields/test.cpp:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/anonymous-fields1.cpp Do we still need this? `-emit-obj` is already excluded?

[PATCH] D116090: [X86][MS-InlineAsm] Use exact conditions to recognize MS global variables

pengfei added a comment. In D116090#3205828 , @skan wrote: > Thank you for the fix! LGTM Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116090/new/ https://reviews.llvm.org/D116090

[PATCH] D116097: [NFC] [C++20] [Modules] Add tests for template instantiation in transitive imported module

ChuanqiXu updated this revision to Diff 395784. ChuanqiXu added a comment. Update command line CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116097/new/ https://reviews.llvm.org/D116097 Files: clang/test/Modules/Inputs/module-transtive-instantiation/Templ.cppm

[PATCH] D116137: [clang-tidy] Remove dead plugin code

mattbeardsley created this revision. mattbeardsley added reviewers: thakis, hans. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. mattbeardsley requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a

[PATCH] D116090: [X86][MS-InlineAsm] Use exact conditions to recognize MS global variables

skan accepted this revision. skan added a comment. This revision is now accepted and ready to land. Thank you for the fix! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116090/new/ https://reviews.llvm.org/D116090

[PATCH] D113530: [wip] [analyzer] support use-after-free checking with parameter annotation

chrisdangelo added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1405 -void MallocChecker::checkOwnershipAttr(const CallEvent , - CheckerContext ) const { +static const FunctionDecl

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9f6e09b850a: [clang-format][NFC] Handle wrapping after = in mustBreakBefore() (authored by owenpan). Changed prior to commit:

[clang] b9f6e09 - [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

Author: Owen Pan Date: 2021-12-21T16:42:52-08:00 New Revision: b9f6e09b850acf2ade04f22fa423e7cc0f075e62 URL: https://github.com/llvm/llvm-project/commit/b9f6e09b850acf2ade04f22fa423e7cc0f075e62 DIFF: https://github.com/llvm/llvm-project/commit/b9f6e09b850acf2ade04f22fa423e7cc0f075e62.diff

[clang] a282ea4 - Reland - [CodeView] Emit S_OBJNAME record

Author: Alexandre Ganea Date: 2021-12-21T19:02:14-05:00 New Revision: a282ea4898efe2b2e57a93b44e90c9e497520cfb URL: https://github.com/llvm/llvm-project/commit/a282ea4898efe2b2e57a93b44e90c9e497520cfb DIFF:

[clang] 5bb5142 - Revert [CodeView] Emit S_OBJNAME record

Author: Alexandre Ganea Date: 2021-12-21T19:02:14-05:00 New Revision: 5bb5142e80c9c6eb1a948d6d2ff4834e4e69741f URL: https://github.com/llvm/llvm-project/commit/5bb5142e80c9c6eb1a948d6d2ff4834e4e69741f DIFF:

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

nickdesaulniers added inline comments. Comment at: llvm/test/tools/llvm-diff/callbr.ll:28-29 entry: - callbr void asm sideeffect "", "X,X,~{dirflag},~{fpsr},~{flags}"(i8* blockaddress(@foo, %t_no), i8* blockaddress(@foo, %return)) + callbr void asm sideeffect "",

[PATCH] D116011: [Clang] Own the CommandLineArgs in CodeGenOptions

aganea marked an inline comment as done. aganea added inline comments. Comment at: clang/lib/Driver/Job.cpp:390-392 Argv.push_back(nullptr); + Argv.pop_back(); // The terminating null element shall not be part of the + // slice (main() behavior).

[PATCH] D116011: [Clang] Own the CommandLineArgs in CodeGenOptions

aganea marked an inline comment as done. aganea added inline comments. Comment at: clang/lib/Driver/Job.cpp:390-392 Argv.push_back(nullptr); + Argv.pop_back(); // The terminating null element shall not be part of the + // slice (main() behavior).

[PATCH] D116128: [clang][driver] Warn when '-mno-outline-atomics' is used with a non-AArch64 triple

nathanchance added inline comments. Comment at: clang/test/Driver/x86-outline-atomics.c:1-7 +// RUN: %clang -target x86_64 -moutline-atomics -S %s -### 2>&1 | FileCheck %s -check-prefix=CHECK-OUTLINE-ATOMICS +// CHECK-OUTLINE-ATOMICS: warning: 'x86_64' does not support

[PATCH] D116011: [Clang] Own the CommandLineArgs in CodeGenOptions

aheejin added inline comments. Comment at: clang/lib/Driver/Job.cpp:390-392 Argv.push_back(nullptr); + Argv.pop_back(); // The terminating null element shall not be part of the + // slice (main() behavior). If we push `nullptr` and then pop

[PATCH] D116128: [clang][driver] Warn when '-mno-outline-atomics' is used with a non-AArch64 triple

nickdesaulniers accepted this revision. nickdesaulniers added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/x86-outline-atomics.c:1-7 +// RUN: %clang -target x86_64 -moutline-atomics -S %s -### 2>&1 | FileCheck %s

[PATCH] D116011: [Clang] Own the CommandLineArgs in CodeGenOptions

aganea added inline comments. Comment at: clang/lib/Driver/Job.cpp:391 Argv.push_back(nullptr); + Argv.pop_back(); // The terminating null element shall not be part of the + // slice (main() behavior). I changed this to match the behavior

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

void accepted this revision. void added a comment. This revision is now accepted and ready to land. Approved with one change. Comment at: llvm/test/tools/llvm-diff/callbr.ll:28-29 entry: - callbr void asm sideeffect "", "X,X,~{dirflag},~{fpsr},~{flags}"(i8*

[PATCH] D116011: [Clang] Own the CommandLineArgs in CodeGenOptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd26520f6f787: [Clang] Own the CommandLineArgs in CodeGenOptions (authored by aganea). Changed prior to commit:

[clang] d26520f - [Clang] Own the CommandLineArgs in CodeGenOptions

Author: Alexandre Ganea Date: 2021-12-21T17:41:35-05:00 New Revision: d26520f6f78785b0c4c296a8a992f2adb656c6ec URL: https://github.com/llvm/llvm-project/commit/d26520f6f78785b0c4c296a8a992f2adb656c6ec DIFF:

[PATCH] D116110: Introduce the AttributeMask class

dexonsmith added a comment. In D116110#3205416 , @nikic wrote: > This looks good to me, but I'd recommend waiting a bit before landing in case > there's further input, as this is a non-trivial API change. (Maybe valuable to start a quick thread on

[PATCH] D116128: [clang][driver] Warn when '-mno-outline-atomics' is used with a non-AArch64 triple

nathanchance added a comment. If there are more qualified people to review and accept this, please add them, I was unsure of who else to add. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116128/new/ https://reviews.llvm.org/D116128

[PATCH] D116128: [clang][driver] Warn when '-mno-outline-atomics' is used with a non-AArch64 triple

nathanchance created this revision. nathanchance added reviewers: melver, nickdesaulniers, t.p.northover. Herald added subscribers: pengfei, kristof.beyls. nathanchance requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Linux kernel has a

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Good that you renamed the method. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115967/new/ https://reviews.llvm.org/D115967 ___ cfe-commits mailing list

[PATCH] D116022: [clang][dataflow] Add support for terminating virtual destructors

xazax.hun added a comment. In D116022#3205478 , @gribozavr2 wrote: >> How resilient is this pattern matching? > > Possibly it is not very robust. However it is very important for a certain > style of precondition verification macros used by various

[PATCH] D116022: [clang][dataflow] Add support for terminating virtual destructors

gribozavr2 added a comment. > How resilient is this pattern matching? Possibly it is not very robust. However it is very important for a certain style of precondition verification macros used by various Google projects. I can't find an exact open source copy, but they are generally similar to

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

salman-javed-nz added a comment. Updated the review's edit permissions. Sorry about that, @kadircet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116085/new/ https://reviews.llvm.org/D116085 ___

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

void added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:826 +// it as potentially uninitialized for those cases where it's used on +// an indirect path, where it's not guaranteed to be defined. vals[VD] = MayUninitialized;

[PATCH] D116022: [clang][dataflow] Add support for terminating virtual destructors

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h:50 + std::unique_ptr Cfg; + llvm::DenseMap StmtToBlock; +}; xazax.hun wrote: > There is a special class for this at

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

void accepted this revision. void added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/LanguageExtensions.rst:1474 +When using tied-outputs (ie. outputs that are inputs and outputs, not just +outputs) with the `+r` constraint, there is

[PATCH] D113530: [wip] [analyzer] support use-after-free checking with parameter annotation

NoQ added a comment. I'm really glad it actually works! > We are interested in deprecating the use of function based ownership > attributes in favor of using function parameter annotations. This change does > not currently provide deprecation warnings. Do we also need to convert

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

qiongsiwu1 added subscribers: bmahjour, anhtuyen, qiongsiwu1. qiongsiwu1 added a comment. Hi everyone! We are encountering crashes in some of our `altivec` test cases due to this change. `clang` crashes when we have an instance of a `struct` or `union` type, and we assign the result of a unary

[PATCH] D116110: Introduce the AttributeMask class

nikic added a reviewer: aeubanks. nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. This looks good to me, but I'd recommend waiting a bit before landing in case there's further input, as this is a non-trivial API change. I think separating

[PATCH] D113530: [wip] [analyzer] support use-after-free checking with parameter annotation

chrisdangelo updated this revision to Diff 395734. chrisdangelo added a comment. This change includes clang-format edits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113530/new/ https://reviews.llvm.org/D113530 Files: clang/include/clang/Basic/Attr.td

[PATCH] D115429: [Clang] Implement the rest of __builtin_elementwise_* functions.

fhahn added a comment. In D115429#3201713 , @junaire wrote: > Hi, @aaron.ballman I'm sorry for not updating the patch in time because I'm > preparing for my school final exam :-( > One thing I want to mention is that `__builtin_elementwise_roundeven`

[PATCH] D116113: Add LLDB synthetic child and summary scripts for llvm::SmallVector, llvm::Optional, llvm::ErrorOr and llvm::Expected.

wallace added a comment. thanks for doing this. Just a few minor comments and i think this is good to go Comment at: clang/utils/ClangDataFormat.py:215-218 +if self.hasVal: +result = self.value.GetIndexOfChildWithName(name) +return None if

[PATCH] D113530: [wip] [analyzer] support use-after-free checking with parameter annotation

chrisdangelo updated this revision to Diff 395726. chrisdangelo edited the summary of this revision. chrisdangelo added a comment. This change removes the previous ownership_takes_param work. This change augments the existing Ownership attribute so that it is now applicable to function

[PATCH] D116048: [clang][CodeGen][UBSan] VLA size checking for unsigned integer parameter

rjmccall added a comment. Thanks, patch basically looks good. Minor requests and an observation for possible follow-up work. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2247 // Otherwise, evaluate and record it. - if (const Expr *size = vat->getSizeExpr())

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth updated this revision to Diff 395727. paulkirth added a comment. - [misexpect] Add missing tests and modify diagnostic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/ https://reviews.llvm.org/D115907 Files:

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan marked an inline comment as done. Jake-Egan added inline comments. Comment at: clang/test/ClangScanDeps/modules-full-by-mod-name.cpp:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: rm -rf %t.dir shchenz wrote: > Jake-Egan wrote: > > jsji wrote: > > >

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 395724. Jake-Egan added a comment. Added `-fintegrated-as` option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 Files:

[PATCH] D115804: [CodeGen] use saturating FP casts when compiling with "no-strict-float-cast-overflow"

kpn added a comment. In D115804#3202479 , @sepavloff wrote: > In D115804#3201681 , @spatel wrote: > >> In D115804#3201044 , @craig.topper >> wrote: >> >>> What's the

[PATCH] D115021: [funcatts] Rewrite callsite operand handling in memory access inference

reames abandoned this revision. reames added a comment. This has been replaced by a series of smaller patches implementing individual parts. The last of which - parameter attributes on indirect calls - is out for review as D116118 . Repository: rG LLVM

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille updated this revision to Diff 395713. serge-sans-paille added a comment. Remove `empty()` method and only keep `hasAttributes` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm.org/D116110 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D115021: [funcatts] Rewrite callsite operand handling in memory access inference

reames added a comment. D115961 and D115964 were the next two pieces of this, both have now landed. The last bit is honoring call site parameter attributes on indirect calls outside the SCC. I'll post that separately and

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

MaskRay added a comment. In D116016#3203005 , @nemanjai wrote: > We should not be emitting the attribute in modules that do not have any use > of `long double`. Right, otherwise it would be a bit unfortunate that a library not using long double has to

[clang] cd407f6 - [Clang] Fix build by restricting debug-info-objname.cpp test to x86.

Author: Alexandre Ganea Date: 2021-12-21T12:22:25-05:00 New Revision: cd407f6e52b09cce2bef24c74b7f36fedc94991b URL: https://github.com/llvm/llvm-project/commit/cd407f6e52b09cce2bef24c74b7f36fedc94991b DIFF:

[PATCH] D116110: Introduce the AttributeMask class

nikic added inline comments. Comment at: llvm/include/llvm/IR/Attributes.h:992 + bool empty() const { return Attrs.none(); } + bool hasAttributes() const { return !TargetDepAttrs.empty() && Attrs.any(); } +}; Shouldn't this be `||`? Comment

[clang] 00ec441 - [Clang] debug-info-objname.cpp test: explictly encode a x86 target when using %clang_cl to avoid falling back to a native CPU triple.

Author: Alexandre Ganea Date: 2021-12-21T11:54:19-05:00 New Revision: 00ec441253048f5e30540ea26bb0a28c42a5fc18 URL: https://github.com/llvm/llvm-project/commit/00ec441253048f5e30540ea26bb0a28c42a5fc18 DIFF:

[clang] 450dddd - [clang-format] Remove unnecessary qualifications. NFC.

Author: Marek Kurdej Date: 2021-12-21T17:53:42+01:00 New Revision: 450cb769b680cd3547877f5d64d40cde16ba URL: https://github.com/llvm/llvm-project/commit/450cb769b680cd3547877f5d64d40cde16ba DIFF: https://github.com/llvm/llvm-project/commit/450cb769b680cd3547877f5d64d40cde16ba.diff

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments. Comment at: llvm/include/llvm/IR/Attributes.h:993 + + bool empty() const { return Attrs.none(); } + bool hasAttributes() const { return TargetDepAttrs.empty() && Attrs.none(); }

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille updated this revision to Diff 395694. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm.org/D116110 Files: clang/lib/CodeGen/CodeGenModule.cpp llvm/include/llvm/IR/Argument.h llvm/include/llvm/IR/Attributes.h

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille updated this revision to Diff 395692. serge-sans-paille added a comment. Herald added subscribers: foad, kerbowa, nhaehnle, jvesely, arsenm. remvove useless assert, update comment, fix build CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

davrec added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IdenticalExprChecker.cpp:372 +} + /// Determines whether two statement trees are identical regarding davrec wrote: > I would strongly support turning these functions into methods of

[PATCH] D116113: Add LLDB synthetic child and summary scripts for llvm::SmallVector, llvm::Optional, llvm::ErrorOr and llvm::Expected.

clayborg created this revision. clayborg added reviewers: labath, teemperor, aprantl. Herald added subscribers: usaxena95, arphaman. clayborg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows us to see the contents of the

[PATCH] D112073: [PowerPC] Emit warning when SP is clobbered by asm

quinnp updated this revision to Diff 395687. quinnp added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adressing review comments. Added register alias "sp" for the register "r1". Added a front end testcase to test the location information and all of the

[clang-tools-extra] 1a92952 - [clangd] Return error for textdocument/outgoingCalls rather than success

Author: Kadir Cetinkaya Date: 2021-12-21T17:06:59+01:00 New Revision: 1a929525e86a20d0b3455a400d0dbed40b325a13 URL: https://github.com/llvm/llvm-project/commit/1a929525e86a20d0b3455a400d0dbed40b325a13 DIFF:

[clang] 36ea986 - [clang-format] Remove unnecessary qualifications. NFC.

Author: Marek Kurdej Date: 2021-12-21T17:02:26+01:00 New Revision: 36ea9861e3b58a715434cc2ec5ee2ebf7053bbc9 URL: https://github.com/llvm/llvm-project/commit/36ea9861e3b58a715434cc2ec5ee2ebf7053bbc9 DIFF: https://github.com/llvm/llvm-project/commit/36ea9861e3b58a715434cc2ec5ee2ebf7053bbc9.diff

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf44e3fbadd15: [CodeView] Emit S_OBJNAME record (authored by aganea). Changed prior to commit:

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

arsenm added a comment. In D109885#3203444 , @JonChesterfield wrote: > In D109885#3203412 , @arsenm wrote: > >> We should have versioned libraries and well defined ABI breaks. The build >> should know what

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

JonChesterfield added a comment. In D109885#3203412 , @arsenm wrote: > We should have versioned libraries and well defined ABI breaks. The build > should know what runtime versions it requires and account when searching If we're playing that game, ROCm

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

arsenm added a comment. In D109885#3202213 , @JonChesterfield wrote: > In D109885#3198375 , @arsenm wrote: > >> In D109885#3198340 , >> @JonChesterfield wrote: >> >>>

[PATCH] D116110: Introduce the AttributeMask class

nikic added a comment. Pre-merge checks also report a build failure in llvm/lib/Target/AMDGPU/AMDGPURewriteOutArguments.cpp:360. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm.org/D116110 ___ cfe-commits

[PATCH] D114966: [clang][deps] Split stat and file content caches

jansvoboda11 updated this revision to Diff 395684. jansvoboda11 added a comment. Erase filenames in temporary `Stat` objects, use `UniqueID` as shard key where appropriate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114966/new/

[PATCH] D114966: [clang][deps] Split stat and file content caches

jansvoboda11 added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:359-360 + findSharedEntryByUID(llvm::vfs::Status Stat) const { +return SharedCache.getShard(Stat.getName()) +

[PATCH] D116049: [clang-format] Fix SplitEmptyRecord affecting SplitEmptyFunction.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07fe45130546: [clang-format] Fix SplitEmptyRecord affecting SplitEmptyFunction. (authored by curdeius). Changed prior to commit:

[clang] 07fe451 - [clang-format] Fix SplitEmptyRecord affecting SplitEmptyFunction.

Author: Marek Kurdej Date: 2021-12-21T16:54:19+01:00 New Revision: 07fe45130546001632e1a6005922c58154e72fe9 URL: https://github.com/llvm/llvm-project/commit/07fe45130546001632e1a6005922c58154e72fe9 DIFF: https://github.com/llvm/llvm-project/commit/07fe45130546001632e1a6005922c58154e72fe9.diff

[PATCH] D116110: Introduce the AttributeMask class

nikic added inline comments. Comment at: llvm/include/llvm/IR/Attributes.h:956 +assert(Attribute::isEnumAttrKind(Val) && + "Adding integer/type attribute without an argument!"); +Attrs[Val] = true; This assert doesn't make sense to me.

[clang] abd1cbf - [Clang] Disable debug-info-objname.cpp test on Unix until I sort out the issue.

Author: Alexandre Ganea Date: 2021-12-21T10:32:43-05:00 New Revision: abd1cbf5e543f0f114d2742e109ead7d7ddbf9c4 URL: https://github.com/llvm/llvm-project/commit/abd1cbf5e543f0f114d2742e109ead7d7ddbf9c4 DIFF:

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille updated this revision to Diff 395677. serge-sans-paille added a comment. Minor nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm.org/D116110 Files: clang/lib/CodeGen/CodeGenModule.cpp llvm/include/llvm/IR/Argument.h

[PATCH] D116029: [clang][NFC] Refactor coroutine_traits lookup

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4de2a4d5905: [clang][NFC] Refactor coroutine_traits lookup (authored by urnathan). Herald added a project: clang. Herald added a subscriber:

[clang] d4de2a4 - [clang][NFC] Refactor coroutine_traits lookup

Author: Nathan Sidwell Date: 2021-12-21T10:29:01-05:00 New Revision: d4de2a4d5905beb0602a615593daf003378ddb64 URL: https://github.com/llvm/llvm-project/commit/d4de2a4d5905beb0602a615593daf003378ddb64 DIFF:

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille created this revision. serge-sans-paille added reviewers: nikic, rnk. Herald added subscribers: ormris, dexonsmith, jdoerfert, hiraditya. serge-sans-paille requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

Re: [PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

Hi Salman, it looks like patch doesn't have edit access for anyone but you. I had drafted some comments but can't hit the submit button. I think you can go to https://reviews.llvm.org/differential/revision/edit/116085/ and change the `Editable By` field to `All Users` On Tue, Dec 21, 2021 at 8:45

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

fhahn added a comment. In D115231#3197112 , @junaire wrote: > Thanks for accepting this patch! I would appreciate it if someone is willing > to commit this for me since I don't have commit access ;D > > You can use: > Jun Zhang > j...@junz.org It

[clang] a995cda - [CodeGen] Avoid more pointer element type accesses

Author: Nikita Popov Date: 2021-12-21T15:52:18+01:00 New Revision: a995cdab190895382448555b7072a50151768534 URL: https://github.com/llvm/llvm-project/commit/a995cdab190895382448555b7072a50151768534 DIFF: https://github.com/llvm/llvm-project/commit/a995cdab190895382448555b7072a50151768534.diff

[clang] f44e3fb - [CodeView] Emit S_OBJNAME record

Author: Alexandre Ganea Date: 2021-12-21T09:26:36-05:00 New Revision: f44e3fbadd15bc851c6e3c2a40ddf5f0a502151a URL: https://github.com/llvm/llvm-project/commit/f44e3fbadd15bc851c6e3c2a40ddf5f0a502151a DIFF:

[PATCH] D116068: [NFC][Clang] Move function implementation of `OpenMPAtomicUpdateChecker` into anonymous namespace

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116068/new/ https://reviews.llvm.org/D116068

[clang] 142e79b - [clang-format] NFC use recently added Style.isJavaScript()

Author: mydeveloperday Date: 2021-12-21T14:24:12Z New Revision: 142e79b8681bae42bebf3eef97fdaa30ce707c67 URL: https://github.com/llvm/llvm-project/commit/142e79b8681bae42bebf3eef97fdaa30ce707c67 DIFF: https://github.com/llvm/llvm-project/commit/142e79b8681bae42bebf3eef97fdaa30ce707c67.diff

[PATCH] D115990: AlignConsecutiveDeclarations not working for 'const' keyword in JavsScript

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e28b86cc629: AlignConsecutiveDeclarations not working for const keyword in JavsScript (authored by MyDeveloperDay). Changed prior to commit:

[clang] 6e28b86 - AlignConsecutiveDeclarations not working for 'const' keyword in JavsScript

Author: mydeveloperday Date: 2021-12-21T13:57:43Z New Revision: 6e28b86cc629c351b1f5d238146af1b6f7ceb785 URL: https://github.com/llvm/llvm-project/commit/6e28b86cc629c351b1f5d238146af1b6f7ceb785 DIFF: https://github.com/llvm/llvm-project/commit/6e28b86cc629c351b1f5d238146af1b6f7ceb785.diff

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

davrec added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp:59 + RTy->getCanonicalTypeUnqualified(); + + // FIXME: We should probably check the other kinds of nested name specifiers. steakhal wrote: >

[PATCH] D116049: [clang-format] Fix SplitEmptyRecord affecting SplitEmptyFunction.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, less the clang-format oddities Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116049/new/ https://reviews.llvm.org/D116049

[clang] 9a05a7b - [CodeGen] Accept Address in CreateLaunderInvariantGroup

Author: Nikita Popov Date: 2021-12-21T14:43:20+01:00 New Revision: 9a05a7b00ccdbd9edee309834901c619beee8d36 URL: https://github.com/llvm/llvm-project/commit/9a05a7b00ccdbd9edee309834901c619beee8d36 DIFF: https://github.com/llvm/llvm-project/commit/9a05a7b00ccdbd9edee309834901c619beee8d36.diff

[PATCH] D111047: CUDA/HIP: Allow __int128 on the host side

linjamaki added a comment. This patch should be ready to land. @tra, could you please commit it to the LLVM for us? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111047/new/ https://reviews.llvm.org/D111047

[clang-tools-extra] 6f1a501 - [clangd] Fix typo in test. NFC

Author: Sam McCall Date: 2021-12-21T14:17:25+01:00 New Revision: 6f1a501fddaef72fdc4c7bcccedce0307d111ffb URL: https://github.com/llvm/llvm-project/commit/6f1a501fddaef72fdc4c7bcccedce0307d111ffb DIFF: https://github.com/llvm/llvm-project/commit/6f1a501fddaef72fdc4c7bcccedce0307d111ffb.diff

[clang] e751d97 - [CodeGen] Avoid some pointer element type accesses

Author: Nikita Popov Date: 2021-12-21T14:16:28+01:00 New Revision: e751d97863fb48b7dd844e48c0ba564f6970b726 URL: https://github.com/llvm/llvm-project/commit/e751d97863fb48b7dd844e48c0ba564f6970b726 DIFF: https://github.com/llvm/llvm-project/commit/e751d97863fb48b7dd844e48c0ba564f6970b726.diff

[PATCH] D111047: CUDA/HIP: Allow __int128 on the host side

linjamaki updated this revision to Diff 395649. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111047/new/ https://reviews.llvm.org/D111047 Files: clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaType.cpp

[PATCH] D116098: [C++20] [Coroutines] Mark imported module as imported if not exported

ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, aaron.ballman, urnathan, iains. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. The intention of this patch is described in the title. I met the problem in

[PATCH] D116097: [NFC] [C++20] [Modules] Add tests for template instantiation in transitive imported module

ChuanqiXu created this revision. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds two test about template class instantiation in transitively imported module. They are used as pre-commit tests for successive

[PATCH] D115856: [syntax][pseudo] Introduce the spec C++ grammar.

sammccall added inline comments. Comment at: clang/lib/Tooling/Syntax/Pseudo/cxx.bnf:12 +# - attributes are omitted, which will be handled as comments; +# - we don't allow nullable non-terminal symbols (except translation-unit). +#There are few nullable non-terminals in

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen added a comment. I agree that reusing existing parser logic for this would be preferable, but as @aaron.ballman mentions `Parser::ParseSimpleExpressionList` does not give us the parameter pack expansion parsing we need. We could potentially unify it with the logic from

[PATCH] D114790: [syntax][pseudo] Add grammar facilities for the pseudo-parser

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Grammar.h:52 +// Terminal IDs correspond to the clang TokenKind enum. +using SymbolID = uint16_t; +// SymbolID is only 12 bits wide. If we want strong types, we could use

  1   2   >