[PATCH] D116022: [clang][dataflow] Add support for noreturn destructor calls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5c5d8912e07: [clang][dataflow] Add support for noreturn destructor calls (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES

[clang] b5c5d89 - [clang][dataflow] Add support for noreturn destructor calls

Author: Stanislav Gatev Date: 2021-12-28T07:04:39Z New Revision: b5c5d8912e07218e3a6a0f8d1d9f7b436046c5bc URL: https://github.com/llvm/llvm-project/commit/b5c5d8912e07218e3a6a0f8d1d9f7b436046c5bc DIFF: https://github.com/llvm/llvm-project/commit/b5c5d8912e07218e3a6a0f8d1d9f7b436046c5bc.diff

[PATCH] D116329: [clang-check] Adjust argument adjusters for clang-check to strip options blocking the static analyzer

OikawaKirie created this revision. OikawaKirie added reviewers: kbobyrev, sammccall, labath. OikawaKirie added a project: clang. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. OikawaKirie requested review of this revision. Herald

[PATCH] D116328: [ast-matchers] Add hasSubstmt() traversal matcher for caseStmt(), defaultStmt()

LegalizeAdulthood added a comment. I think while implementing this I got a little confused as to whether or not it was a narrowing or traversal matcher. It feels like a traversal matcher to me. If someone would confirm my reasoning, I'd appreciate it. That means I should probably move the

[PATCH] D116328: [ast-matchers] Add hasSubstmt() traversal matcher for caseStmt(), defaultStmt()

LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: klimek. LegalizeAdulthood requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously if you wanted to match the statement associated with a case or default block,

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

achieveartificialintelligence added a comment. I'll finish the rest of code, if this patch is acceptable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 396373. achieveartificialintelligence added a comment. Update Part of Zfinx Codes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files:

[clang] 6c335b1 - [clang] Remove unused "using" (NFC)

Author: Kazu Hirata Date: 2021-12-27T20:48:21-08:00 New Revision: 6c335b1a452f48c563bc503c81af297803885b59 URL: https://github.com/llvm/llvm-project/commit/6c335b1a452f48c563bc503c81af297803885b59 DIFF: https://github.com/llvm/llvm-project/commit/6c335b1a452f48c563bc503c81af297803885b59.diff

[PATCH] D116326: [CodeCompletion] Signature help for aggregate initialization.

sammccall created this revision. sammccall added reviewers: kadircet, usaxena95. Herald added a subscriber: arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. The "parameter list" is the

[PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

sammccall updated this revision to Diff 396362. sammccall added a comment. Fix clangd tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116317/new/ https://reviews.llvm.org/D116317 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

avogelsgesang added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:4003 +**TemplateArgumentKeyword** (``TemplateArgumentStyle``) :versionbadge:`clang-format 14` + Keyword to use for template arguments (``class`` or ``typename``)

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

avogelsgesang updated this revision to Diff 396361. avogelsgesang marked 4 inline comments as done. avogelsgesang added a comment. Thank you for the quick review, @HazardyKnusperkeks! I addressed most of your comments by fixing my code. In two cases, I think there was a misunderstanding and I

[PATCH] D116314: [Clangfmt] Add style to separate definition blocks

ksyx updated this revision to Diff 396358. ksyx marked an inline comment as done. ksyx added a comment. - Change bool type of the option to enum type - Generate empty line for enum block Testfile: // test.cpp #include #include #include struct Foo { int a,b,c; }; namespace

[PATCH] D116325: [X86] Add missing CET intrinsics support

pengfei added a comment. Checked we won't raise uninitialized warning, so LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116325/new/ https://reviews.llvm.org/D116325 ___ cfe-commits mailing list

[PATCH] D116325: [X86] Add missing CET intrinsics support

FreddyYe created this revision. Herald added a subscriber: pengfei. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These two intrinsics are documented o SDM and intrinsic guide. Repository: rG LLVM Github Monorepo

[PATCH] D116314: [Clangfmt] Add style to separate definition blocks

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/Format.cpp:1197 LLVMStyle.ReferenceAlignment = FormatStyle::RAS_Pointer; + LLVMStyle.SeparateDefinitionBlocks

[clang] 0c9a4da - [ASTMatchers] Simplify string comparisons (NFC)

Author: Kazu Hirata Date: 2021-12-27T15:32:51-08:00 New Revision: 0c9a4da497c44d2c88b22ee52868fe37359c7a76 URL: https://github.com/llvm/llvm-project/commit/0c9a4da497c44d2c88b22ee52868fe37359c7a76 DIFF: https://github.com/llvm/llvm-project/commit/0c9a4da497c44d2c88b22ee52868fe37359c7a76.diff

[PATCH] D116314: [Clangfmt] Add style to separate definition blocks

ksyx updated this revision to Diff 396344. ksyx added a comment. Fix missing colon in sample/test code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[PATCH] D115888: [Attributor][Fix] Add alignment return attribute to HeapToStack

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38fc89623b3e: [Attributor][Fix] Add alignment return attribute to

[PATCH] D101070: Make `llvm_install_symlink` robust with respect to absolute dirs.

Ericson2314 updated this revision to Diff 396339. Ericson2314 added a comment. Herald added a project: Flang. 1. Updating D101070 : Make `llvm_install_symlink` robust with respect to absolute dirs. # 2. Enter a brief description of the changes included in this

[PATCH] D116318: [clang-format][NFC] Fix a bug in getPreviousToken() in the parser

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, curdeius. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

sammccall updated this revision to Diff 396325. sammccall edited the summary of this revision. sammccall added a comment. Herald added subscribers: JDevlieghere, ilya-biryukov. Revert some unintended changes, clean up tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

sammccall updated this revision to Diff 396324. sammccall added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix lldb build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116317/new/

[PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

sammccall created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Implementation is based on the "expected type" as used for

[PATCH] D115888: [Attributor][Fix] Add alignment return attribute to HeapToStack

jdoerfert added a comment. Still LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115888/new/ https://reviews.llvm.org/D115888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115971: [OpenMP][FIX] Change globalization alignment to 16

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, partial fix for the problem and fixmes describing what needs to be done next. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116314: [Clangfmt] Add style to separate definition blocks

ksyx added inline comments. Comment at: clang/lib/Format/Format.cpp:1197 LLVMStyle.ReferenceAlignment = FormatStyle::RAS_Pointer; + LLVMStyle.SeparateDefinitionBlocks = true; LLVMStyle.ShortNamespaceLines = 1; ksyx wrote: > Not so sure about this as it

[PATCH] D116314: [Clangfmt] Add style to separate definition blocks

ksyx added inline comments. Comment at: clang/lib/Format/Format.cpp:1197 LLVMStyle.ReferenceAlignment = FormatStyle::RAS_Pointer; + LLVMStyle.SeparateDefinitionBlocks = true; LLVMStyle.ShortNamespaceLines = 1; Not so sure about this as it would break some

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, curdeius, sammccall, aaron.ballman, krasimir. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. See

[PATCH] D116314: [Clangfmt] Add style to separate definition blocks

ksyx updated this revision to Diff 396321. ksyx added a comment. Apply clang-format suggestions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[PATCH] D116314: [Clangfmt] Add style to separate definition blocks

ksyx added a comment. Test code: // test.cpp #include #include #include struct Foo { int a,b,c; }; namespace Ns { class Bar { public: struct Foobar { int a; int b; }; private: int t; int method1() { // Intentional test for

[PATCH] D116314: [Clangfmt] Add style to separate definition blocks

ksyx created this revision. ksyx added a reviewer: MyDeveloperDay. ksyx added projects: clang-format, clang. ksyx requested review of this revision. Herald added a subscriber: cfe-commits. This commit resolves GitHub issue #45895 (Bugzilla

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

GPery updated this revision to Diff 396317. GPery edited the summary of this revision. GPery added a comment. Add a unit test and initialisation in LLVMStyle Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116170/new/

[PATCH] D115790: [Coroutines] Set presplit attribute in Clang and mlir

ChuanqiXu updated this revision to Diff 396254. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115790/new/ https://reviews.llvm.org/D115790 Files: clang/lib/CodeGen/CGCoroutine.cpp clang/test/CodeGenCoroutines/coro-always-inline.cpp

[PATCH] D115790: [Coroutines] Set presplit attribute in Clang and mlir

ezhulenev accepted this revision. ezhulenev added inline comments. Comment at: mlir/lib/Dialect/Async/Transforms/AsyncToAsyncRuntime.cpp:201 + StringAttr::get(ctx, "0")})})); + CoroMachinery machinery; nit: builder has an

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

zixuan-wu updated this revision to Diff 396148. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115921/new/ https://reviews.llvm.org/D115921 Files: clang/lib/Basic/Targets/RISCV.cpp clang/lib/Driver/ToolChains/Arch/RISCV.cpp clang/test/Driver/riscv-arch-version.c

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

zixuan-wu added inline comments. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:33 + bool operator!=(const RISCVExtensionVersion ) const { +return !operator==(Version); + } craig.topper wrote: > Use `!(*this == Version)` Good taste.

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

zixuan-wu updated this revision to Diff 396147. zixuan-wu edited the summary of this revision. zixuan-wu added a comment. Address all comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115921/new/ https://reviews.llvm.org/D115921 Files: clang/lib/Basic/Targets/RISCV.cpp

[PATCH] D116283: Added an option to add a space between operator overloading and opening parentheses in clang-format

rajatbajpai updated this revision to Diff 396314. rajatbajpai added a comment. Fixed the patch file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116283/new/ https://reviews.llvm.org/D116283 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

aganea created this revision. aganea added reviewers: mstorsjo, amccarth, hans. aganea requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. When building LLVM with Clang 13.0 on Windows, I see a bunch of `-Wnon-virtual-dtor`

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

zwliew added inline comments. Comment at: clang/lib/Format/Format.cpp:3276 + // Check for explicit config filename + if (StyleName.startswith_insensitive("file:")) { +auto StyleNameFile = StyleName.substr(5); HazardyKnusperkeks wrote: > zwliew wrote: > >

[PATCH] D116283: Added an option to add a space between operator overloading and opening parentheses in clang-format

rajatbajpai updated this revision to Diff 396302. rajatbajpai added a comment. Incorporated review comments. Changelog: 1. Using unit test case instead of lit test case. 2. Placed the option according to alphabetical order. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

zwliew added inline comments. Comment at: clang/lib/Format/Format.cpp:3067 + if (!ChildFormatTextToApply.empty()) { +assert(ChildFormatTextToApply.size() == 1); + HazardyKnusperkeks wrote: > zwliew wrote: > > Is there a reason behind limiting the number of

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3393 if (!ChildFormatTextToApply.empty()) { assert(ChildFormatTextToApply.size() == 1); zwliew wrote: > Is there a reason for this to be limited to 1? I came across this

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3067 + if (!ChildFormatTextToApply.empty()) { +assert(ChildFormatTextToApply.size() == 1); + zwliew wrote: > Is there a

[clang] 3e65861 - [CodeGen] Avoid one more pointer element type access

Author: Nikita Popov Date: 2021-12-27T12:58:22+01:00 New Revision: 3e6586113157c164d39120139c14295058e88ccb URL: https://github.com/llvm/llvm-project/commit/3e6586113157c164d39120139c14295058e88ccb DIFF: https://github.com/llvm/llvm-project/commit/3e6586113157c164d39120139c14295058e88ccb.diff

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

HazardyKnusperkeks added a comment. Nice change, some small notes from me. Comment at: clang/docs/ClangFormatStyleOptions.rst:4003 +**TemplateArgumentKeyword** (``TemplateArgumentStyle``) :versionbadge:`clang-format 14` + Keyword to use for template arguments (``class`` or

[PATCH] D116283: Added an option to add a space between operator overloading and opening parentheses in clang-format

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3383 +///true: false: +///void operator++ (int a); vs.void operator++(int +///a); Please put

[clang] 1f07a4a - [CodeGen] Avoid more pointer element type accesses

Author: Nikita Popov Date: 2021-12-27T12:00:22+01:00 New Revision: 1f07a4a5699b73582461880e716e6692cbe3d6a6 URL: https://github.com/llvm/llvm-project/commit/1f07a4a5699b73582461880e716e6692cbe3d6a6 DIFF: https://github.com/llvm/llvm-project/commit/1f07a4a5699b73582461880e716e6692cbe3d6a6.diff

[PATCH] D116271: [Docs] Document C++ for OpenCL 2021 support in clang

Topotuna added a comment. Overall, I think that adjustments are accurate. Suggested a couple of small edits Comment at: clang/docs/OpenCLSupport.rst:28-29 -For general issues and bugs with OpenCL in clang refer to `Bugzilla

[PATCH] D110155: [OpenCL] Allow optional __generic in __remove_address_space utility

Topotuna closed this revision. Topotuna added a comment. Closed by commit: rGb5fef6dbfd6b4c84d61155fd2221064bcc1ecdcf CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110155/new/ https://reviews.llvm.org/D110155

[clang] b5fef6d - [OpenCL] Allow optional __generic in __remove_address_space utility

Author: Justas Janickas Date: 2021-12-27T08:39:21Z New Revision: b5fef6dbfd6b4c84d61155fd2221064bcc1ecdcf URL: https://github.com/llvm/llvm-project/commit/b5fef6dbfd6b4c84d61155fd2221064bcc1ecdcf DIFF: https://github.com/llvm/llvm-project/commit/b5fef6dbfd6b4c84d61155fd2221064bcc1ecdcf.diff