[PATCH] D117129: [clang-tidy] Extract Class IncluderClangTidyCheck

njames93 added a comment. In D117129#3246610 , @LegalizeAdulthood wrote: > In D117129#3246403 , @njames93 > wrote: > >> > > I pushed the functionality down into ClangTidyCheck > instead of introducing an

[PATCH] D117129: [clang-tidy] Extract Class IncluderClangTidyCheck

LegalizeAdulthood added a comment. In D117129#3246403 , @njames93 wrote: > There is a hurdle to overcome with this, Currently each check can have its > own include style - which doesn't really make sense. Hopefully people > actually just use the global

[PATCH] D117129: [clang-tidy] Extract Class IncluderClangTidyCheck

LegalizeAdulthood updated this revision to Diff 400352. LegalizeAdulthood added a comment. Eliminate an intermediate class and move the IncludeInserter functionality into ClangTidyCheck with an enum to indicate opt-in to use of the IncludeInserter. CHANGES SINCE LAST ACTION

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. OK I split out D117417 , D117418 , D117419 , and D117420 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117419: [clang][cmake] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 created this revision. Herald added subscribers: arphaman, whisperity, mgorny. Ericson2314 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. I am breaking apart D99484 so the

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 reopened this revision. Ericson2314 added a comment. This revision is now accepted and ready to land. Will try to break up the pathc further for better troubleshooting, but keeping this open to track progress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[libunwind] da77db5 - Revert "[cmake] Use `GNUInstallDirs` to support custom installation dirs."

Author: John Ericson Date: 2022-01-16T05:48:30Z New Revision: da77db58d7629a3bfea1a0053aa9c29764b0bc2b URL: https://github.com/llvm/llvm-project/commit/da77db58d7629a3bfea1a0053aa9c29764b0bc2b DIFF: https://github.com/llvm/llvm-project/commit/da77db58d7629a3bfea1a0053aa9c29764b0bc2b.diff LOG:

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a678f807200: [cmake] Use `GNUInstallDirs` to support custom installation dirs. (authored by Ericson2314). Repository: rG LLVM Github Monorepo

[libunwind] 4a678f8 - [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Author: John Ericson Date: 2022-01-16T05:33:07Z New Revision: 4a678f8072004eff9214c1a4e1836a14abb69535 URL: https://github.com/llvm/llvm-project/commit/4a678f8072004eff9214c1a4e1836a14abb69535 DIFF: https://github.com/llvm/llvm-project/commit/4a678f8072004eff9214c1a4e1836a14abb69535.diff LOG:

[PATCH] D117398: [clang-format] Fix bug in parsing `operator<` with template

pjessesco updated this revision to Diff 400341. pjessesco added a comment. Fix to pass unittest CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117398/new/ https://reviews.llvm.org/D117398 Files: clang/lib/Format/FormatTokenLexer.cpp clang/lib/Format/TokenAnnotator.cpp

[PATCH] D117416: Handle C variables with name that matches c++ access specifier

psigillito added a comment. Sorry, this is my first time using Phabricator. I am not sure if it matters that .arclint is changed in this review, it is not part of my commit. This issue only appears to impact the accessSpecifier keywords. For example, a c variable declared with the name

[PATCH] D117416: Handle C variables with name that matches c++ access specifier

psigillito created this revision. psigillito requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D117416 Files: .arclint clang/lib/Format/FormatToken.h

[PATCH] D117415: Handle C variables with name that matches c++ access specifier

psigillito created this revision. psigillito requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D117415 Files: .arclint clang/lib/Format/FormatToken.h

[PATCH] D117414: [clang-format] Add return code to git-clang-format

owenpan created this revision. owenpan added a reviewer: MyDeveloperDay. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://github.com/llvm/llvm-project/issues/53220 Repository: rG

[PATCH] D117391: [AST] Ignore implicit nodes in CastExpr::getConversionFunction

davrec accepted this revision. davrec added a comment. This revision is now accepted and ready to land. Looks good, thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117391/new/ https://reviews.llvm.org/D117391

[PATCH] D117129: [clang-tidy] Extract Class IncluderClangTidyCheck

njames93 added a comment. In D117129#3239514 , @LegalizeAdulthood wrote: > In D117129#3239143 , @njames93 > wrote: > >> My proposed idea was putting the `IncludeInserter` instance >> inside the

[PATCH] D117362: [OpenMP] Remove hidden visibility for declare target variables

jhuber6 updated this revision to Diff 400328. jhuber6 added a comment. Updating again, wasn't handling static variables declared in a record context properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117362/new/

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

nathanchance added a comment. In D105169#3246378 , @nlopes wrote: > In D105169#3244624 , @nathanchance > wrote: > >> I can reduce all of these down for you and/or I can start an email thread >> with the

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 400325. cor3ntin added a comment. run clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/docs/ReleaseNotes.rst

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

nlopes added a comment. In D105169#3244624 , @nathanchance wrote: > I can reduce all of these down for you and/or I can start an email thread > with the `objtool` maintainers to see if there is a way to fix or avoid these > warnings on the `objtool`

[PATCH] D117407: [clang] Add include path for cppwinrt on Windows SDK 10.0.17134+

saschanaz created this revision. saschanaz added a reviewer: hans. saschanaz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes https://github.com/llvm/llvm-project/issues/53112 by adding cppwinrt to the include path when the SDK

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin added a comment. In D111400#3243826 , @aaron.ballman wrote: > In D111400#3172097 , @cor3ntin > wrote: > >> Regression compared to the status quo: >> This code no longer warns (as noted by Hubert above)

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 400317. cor3ntin added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/docs/ReleaseNotes.rst

[clang] c63a317 - [AttrBuilder] Remove ctor accepting AttributeList and Index

Author: Nikita Popov Date: 2022-01-15T22:39:31+01:00 New Revision: c63a3175c2947e8c1a2d3bbe16a8586600705c54 URL: https://github.com/llvm/llvm-project/commit/c63a3175c2947e8c1a2d3bbe16a8586600705c54 DIFF: https://github.com/llvm/llvm-project/commit/c63a3175c2947e8c1a2d3bbe16a8586600705c54.diff

LLVM build master will be restarted shortly

Hello, LLVM build master will be restarted shortly. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D117271: [AArch64] clang support for Armv8.8/9.3 MOPS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc84b8be516bc: [AArch64] clang support for Armv8.8/9.3 MOPS (authored by pratlucas, committed by tyb0807). Repository: rG LLVM Github Monorepo

[clang] c84b8be - [AArch64] clang support for Armv8.8/9.3 MOPS

Author: Lucas Prates Date: 2022-01-15T19:52:30Z New Revision: c84b8be516bcc4d021ff804169d58a7b3104e050 URL: https://github.com/llvm/llvm-project/commit/c84b8be516bcc4d021ff804169d58a7b3104e050 DIFF: https://github.com/llvm/llvm-project/commit/c84b8be516bcc4d021ff804169d58a7b3104e050.diff LOG:

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

eopXD marked an inline comment as not done. eopXD added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:184 Builder.defineMacro("__riscv_v_min_vlen", Twine(MinVLen)); +Builder.defineMacro("__riscv_v_max_eew", Twine(MaxEew)); +

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:184 Builder.defineMacro("__riscv_v_min_vlen", Twine(MinVLen)); +Builder.defineMacro("__riscv_v_max_eew", Twine(MaxEew)); +Builder.defineMacro("__riscv_v_max_eew_fp", Twine(MaxEewFp));

[PATCH] D116478: [clang-tidy] A semicolon-separated list of the names of functions or methods to be considered as not having side-effects

zinovy.nis updated this revision to Diff 400303. zinovy.nis marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116478/new/ https://reviews.llvm.org/D116478 Files: clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp

[PATCH] D116478: [clang-tidy] A comma-separated list of the names of functions or methods to be considered as not having side-effects

zinovy.nis marked 4 inline comments as done. zinovy.nis added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp:57-60 if (const auto *FuncDecl = CExpr->getDirectCallee()) { if (FuncDecl->getDeclName().isIdentifier() && -

[PATCH] D116478: [clang-tidy] A comma-separated list of the names of functions or methods to be considered as not having side-effects

zinovy.nis updated this revision to Diff 400301. zinovy.nis added a comment. - Support regexp for list of ignored functions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116478/new/ https://reviews.llvm.org/D116478 Files:

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 400296. JonasToth added a comment. - fix: adjust unit test for new array-pointer condition in range-based for loops Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 400293. JonasToth added a comment. - fix release note ordering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files:

[PATCH] D117362: [OpenMP] Remove hidden visibility for declare target variables

jhuber6 updated this revision to Diff 400292. jhuber6 added a comment. Changing method to use an early exit, previously visibility would still be hidden for some constructs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117362/new/

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 400291. JonasToth marked an inline comment as done. JonasToth added a comment. - improve documentation a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files:

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth marked an inline comment as done. JonasToth added a comment. addressed all outstanding review comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-const-correctness-transform-values.cpp:107-108 + int *np_local3[2] = {_local0[0],

[PATCH] D117398: [clang-format] Fix bug in parsing `operator<` with template

pjessesco updated this revision to Diff 400290. pjessesco added a comment. Add deleted newline in `FormatTest.cpp` by mistake CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117398/new/ https://reviews.llvm.org/D117398 Files: clang/lib/Format/FormatTokenLexer.cpp

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 400288. JonasToth marked 2 inline comments as done. JonasToth added a comment. - Merge branch 'main' into feature_rebase_const_transform_20210808 - fix: address other review comments - remove one false positive with pointers in a range-based for loop on

[PATCH] D117398: [clang-format] Fix bug in parsing `operator<` with template

pjessesco created this revision. pjessesco requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://github.com/llvm/llvm-project/issues/44601 This patch handles a bug when parsing a below example code : template class S; template

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

eopXD marked 7 inline comments as done. eopXD added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:184 Builder.defineMacro("__riscv_v_min_vlen", Twine(MinVLen)); +Builder.defineMacro("__riscv_v_max_eew", Twine(MaxEew)); +

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.h:31 +WarnPointersAsValues(Options.get("WarnPointersAsValues", 0)), +TransformValues(Options.get("TransformValues", 1)), +

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 400280. JonasToth marked 10 inline comments as done. JonasToth added a comment. - Merge branch 'main' into feature_rebase_const_transform_20210808 - fix: fixes for most review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117205: [clang-tidy] Support custom fix hint for cppcoreguidelines-pro-bounds-constant-array-index

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp:26 +utils::IncludeSorter::IS_LLVM)), + FixHint(Options.get("FixHint", "gsl::at()")) {}

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

njames93 added a comment. Herald added a subscriber: carlosgalvezp. Sorry its been so long, How does this handle cases where the variable contains resources. Like a vector being used in a loop where you don't want to release its memory between each iteration. void foo(){ std::vector

[PATCH] D95046: [clangd] Add option to use dirty file contents when building preambles.

njames93 added a comment. @sammccall What else is needed for this to go in? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95046/new/ https://reviews.llvm.org/D95046 ___ cfe-commits mailing list

[PATCH] D95046: [clangd] Add option to use dirty file contents when building preambles.

njames93 updated this revision to Diff 400267. njames93 added a comment. Herald added a project: clang-tools-extra. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95046/new/ https://reviews.llvm.org/D95046 Files:

[PATCH] D117306: [clang-tidy] Add new check 'shared-ptr-array-mismatch'.

njames93 added a comment. How does this check play with the `modernize-make-shared` check? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117306/new/ https://reviews.llvm.org/D117306 ___ cfe-commits

[PATCH] D117391: [AST] Ignore implicit nodes in CastExpr::getConversionFunction

kimgr added a comment. Oh yeah, this closes bug https://github.com/llvm/llvm-project/issues/53044. Do I mention that in the commit message/patch summary? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117391/new/ https://reviews.llvm.org/D117391

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

njames93 updated this revision to Diff 400266. njames93 added a comment. Add support for array access `Arr[I * JExtent + J]` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116875/new/ https://reviews.llvm.org/D116875 Files:

[PATCH] D117391: [AST] Ignore implicit nodes in CastExpr::getConversionFunction

kimgr created this revision. kimgr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Under -std=c++20 with use of consteval, the subexpression hierarchy sometimes contains ConstantExpr nodes that getConversionFunction did not expect.

[PATCH] D117390: [AST] Reformat CastExpr unittest suite

kimgr created this revision. kimgr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In preparation for adding new tests. No functional change. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D117390 Files:

[PATCH] D117380: [RISCV] [Clang] Add attra for crc32_d/crc32c_d

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8123e2ed7490: [RISCV][Clang] Add attrs to crc32_d/crc32c_d (authored by Chenbing.Zheng, committed by benshi001). Repository: rG LLVM Github

[clang] 8123e2e - [RISCV][Clang] Add attrs to crc32_d/crc32c_d

Author: Chenbing.Zheng Date: 2022-01-15T08:40:09Z New Revision: 8123e2ed7490440693ed69d00618aa4f13e70b50 URL: https://github.com/llvm/llvm-project/commit/8123e2ed7490440693ed69d00618aa4f13e70b50 DIFF: https://github.com/llvm/llvm-project/commit/8123e2ed7490440693ed69d00618aa4f13e70b50.diff

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 400256. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files:

[PATCH] D117380: [RISCV] [Clang] Add attra for crc32_d/crc32c_d

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117380/new/ https://reviews.llvm.org/D117380