[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu updated this revision to Diff 415006. zixuan-wu added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121445/new/ https://reviews.llvm.org/D121445 Files:

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith updated this revision to Diff 415004. keith added a comment. Replace \w with . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/ https://reviews.llvm.org/D111579 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc24b3db45c7d: [clang-format] Add option to align compound assignments like `+=` (authored by sstwcw). Changed prior to commit:

[PATCH] D120361: [clang-format] Extract doc for entire configuration structs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93b5505b456f: [clang-format] Extract doc for entire configuration structs (authored by sstwcw). Herald added a project: All. Repository: rG LLVM

[clang] c24b3db - [clang-format] Add option to align compound assignments like `+=`

Author: sstwcw Date: 2022-03-14T04:41:40Z New Revision: c24b3db45c7d0f08b423308723cd2e678a0cb7f1 URL: https://github.com/llvm/llvm-project/commit/c24b3db45c7d0f08b423308723cd2e678a0cb7f1 DIFF: https://github.com/llvm/llvm-project/commit/c24b3db45c7d0f08b423308723cd2e678a0cb7f1.diff LOG:

[clang] 93b5505 - [clang-format] Extract doc for entire configuration structs

Author: sstwcw Date: 2022-03-14T04:41:40Z New Revision: 93b5505b456f75ff33be20402b0317cbb2131a66 URL: https://github.com/llvm/llvm-project/commit/93b5505b456f75ff33be20402b0317cbb2131a66 DIFF: https://github.com/llvm/llvm-project/commit/93b5505b456f75ff33be20402b0317cbb2131a66.diff LOG:

[PATCH] D121559: [clang-format] Fix crash on asm block with label

owenpan added a comment. This patch also fixed 4 out of 6 of the same assertion failures on the .c files under `clang/test`. The remaining two are: 1. Analysis/inline-plist.c (#54367 ) 2. Sema/attr-external-source-symbol.c (54368

[PATCH] D121177: [modules] Merge equivalent extensions and diagnose ivar redeclarations for extensions loaded from different modules.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. OK, if it is prohibited. It looks good to me. Please wait for a few days before landing in case there are other comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

ChuanqiXu added a comment. It lacks tests. This is not NFC, right? --- I am a little bit confused for the intuition. Couldn't we just import the pre-processed header? What's the problem? Could you elaborate on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added inline comments. Comment at: clang/test/Driver/csky-arch.c:26 + +// RUN: %clang -target csky-unknown-elf -march=csky -### %s \ +// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=CSKY %s rengolin wrote: > I don't think this is doing what you

[PATCH] D121097: [C++20][Modules][HU 3/5] Emit module macros for header units.

ChuanqiXu added a comment. Maybe it's worth to add a test from: http://eel.is/c++draft/cpp.import#8 Comment at: clang/include/clang/Serialization/ASTWriter.h:127-128 + /// The module is a header unit. + bool IsHeaderUnit = false; + I think the member is

[PATCH] D121345: [RISCV] Add +experimental-zvfh extension to cover half types in vectors.

kito-cheng added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:727 + if (Exts.count("zvfh") && !Exts.count("zfh") && !Exts.count("zhinx")) +return createStringError( Zvfh require `Zfhmin` rather than `Zfh` Spec: `The Zvfh extension

[PATCH] D111457: [test] Add lit helper for windows paths

keith added a comment. Herald added a project: All. @compnerd can you re-review here? I think I covered your feedback, let me know! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith updated this revision to Diff 414976. keith added a comment. Herald added a project: All. Remove variables from test expectations This didn't work out because of the double vs single slash of the expansions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added inline comments. Comment at: clang/lib/Basic/Targets/CSKY.cpp:43 + Builder.defineMacro("__CSKYABI__", ABI == "abiv2" ? "2" : "1"); + Builder.defineMacro("__cskyabi__", ABI == "abiv2" ? "2" : "1"); + DavidSpickett wrote: > Any need to handle

[PATCH] D100692: clang-tidy: discover binaries in build dir

keith updated this revision to Diff 414975. keith added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100692/new/ https://reviews.llvm.org/D100692 Files: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py Index:

[PATCH] D121096: [C++20][Modules][HU 2/5] Support searching Header Units in user or system search paths.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM except we should remove the dead error emitting. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2796-2797 +// not intended to be a module map or header

[PATCH] D121095: [C++20][Modules][HU 1/5] Introduce header units as a module type.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM with suggested changes. Comment at: clang/include/clang/Sema/Sema.h:2978-2980 + /// The parser has begun a translation unit to be compiled as a C++20 + ///

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

phosek added a comment. In D121175#3372056 , @condy wrote: > IMHO, it's the duty of build systems. CMake provides > `check_cxx_compiler_flag` to report unknown options. That's only true for build systems that perform configure time checks like CMake,

[PATCH] D109977: LLVM Driver Multicall tool

phosek added a comment. Another potential future improvement is error reporting for subcommands: $ ./bin/llvm clang llvm: error: no input files $ ./bin/clang clang-15: error: no input files Ideally, the multicall tool would produce the same error message.

[PATCH] D121559: [clang-format] Fix crash on asm block with label

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:829 OpeningBrace.setType(TT_DictLiteral); +if (Style.isJavaScript()) + OpeningBrace.overwriteFixedType(TT_DictLiteral);

[PATCH] D111400: [Clang] Implement P2242R3

hubert.reinterpretcast added inline comments. Comment at: clang/test/CXX/dcl.dcl/dcl.spec/dcl.constexpr/p3-2b.cpp:16 +} + +constexpr int f(int x) { Add a `NonLiteral` case and a case with a labelled statement and no `goto`? Comment at:

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

abrachet marked an inline comment as done. abrachet added a comment. In D121560#3378181 , @MaskRay wrote: >> This patch adds an example for -static-libcxx and -nostdlib. > > We have -static-libstdc++ but not -static-libc++. (D53238 >

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

abrachet updated this revision to Diff 414965. abrachet edited the summary of this revision. abrachet added a comment. Update example to have multiple options in NoArgUnusedWith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121560/new/ https://reviews.llvm.org/D121560 Files:

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

MaskRay added a comment. > This patch adds an example for -static-libcxx and -nostdlib. We have -static-libstdc++ but not -static-libc++. (D53238 attempts to add `-static` and name it `-static=c++stdlib`) > NoArgUnusedWith can be used for options which

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

abrachet created this revision. abrachet added reviewers: MaskRay, thakis. Herald added subscribers: ormris, dang, usaxena95, kadircet, rupprecht, arphaman, steven_wu, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: JDevlieghere. Herald added a reviewer: alexander-shaposhnikov.

[PATCH] D121512: [Support] Change zlib::compress to return void

joerg added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121512/new/ https://reviews.llvm.org/D121512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D112019#3378031 , @MyDeveloperDay wrote: > In D112019#3378024 , > @HazardyKnusperkeks wrote: > >> Why limit to macros, could it

[PATCH] D121558: [clang-format][NFC] Left renamed to OpeningBrace...

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121558/new/ https://reviews.llvm.org/D121558

[PATCH] D121550: [clang-format] Fix crash on invalid requires expression

curdeius added a comment. LGTM. And thanks for splitting the patch. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:335 + + // Invalid Code, but we don't want to crash. See http://llvm.org/PR54350. + Tokens = annotate("bool r10 = requires (struct new_struct { int

[clang] 0570af1 - [clang-format] Fix incorrect assertion on macro definitions with keyword class.

Author: Marek Kurdej Date: 2022-03-13T22:17:48+01:00 New Revision: 0570af17585d98be0c12f6760118eb94071d9c26 URL: https://github.com/llvm/llvm-project/commit/0570af17585d98be0c12f6760118eb94071d9c26 DIFF: https://github.com/llvm/llvm-project/commit/0570af17585d98be0c12f6760118eb94071d9c26.diff

[PATCH] D121559: [clang-format] Fix crash on asm block with label

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D121558: [clang-format][NFC] Left renamed to OpeningBrace...

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D121557: [clang-format][NFC] Rename Left to OpeningParen...

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121557/new/ https://reviews.llvm.org/D121557

[PATCH] D121550: [clang-format] Fix crash on invalid requires expression

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:215 +assert(CurrentToken->Previous && "Unknown previous token"); +FormatToken = *CurrentToken->Previous; +assert(OpeningParen.is(tok::l_paren)); curdeius

[PATCH] D121550: [clang-format] Fix crash on invalid requires expression

HazardyKnusperkeks updated this revision to Diff 414956. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. Split rename and bug fix CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121550/new/ https://reviews.llvm.org/D121550 Files:

[PATCH] D121557: [clang-format][NFC] Rename Left to OpeningParen...

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D121456: [clang-format] Correctly format variable templates.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa140b7104fda: [clang-format] Correctly format variable templates. (authored by curdeius). Changed prior to commit: https://reviews.llvm.org/D121456?vs=414634=414954#toc Repository: rG LLVM Github

[clang] a140b71 - [clang-format] Correctly format variable templates.

Author: Marek Kurdej Date: 2022-03-13T22:00:17+01:00 New Revision: a140b7104fdae0d9eff5b18efbc784754e0ca274 URL: https://github.com/llvm/llvm-project/commit/a140b7104fdae0d9eff5b18efbc784754e0ca274 DIFF: https://github.com/llvm/llvm-project/commit/a140b7104fdae0d9eff5b18efbc784754e0ca274.diff

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

This revision was automatically updated to reflect the committed changes. Closed by commit rG36d13d3f8adb: [clang-format] Add space to comments starting with #. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121451/new/

[clang] 36d13d3 - [clang-format] Add space to comments starting with '#'.

Author: Marek Kurdej Date: 2022-03-13T21:56:22+01:00 New Revision: 36d13d3f8adb3d1a6bae71370afa23d11a94dc78 URL: https://github.com/llvm/llvm-project/commit/36d13d3f8adb3d1a6bae71370afa23d11a94dc78 DIFF: https://github.com/llvm/llvm-project/commit/36d13d3f8adb3d1a6bae71370afa23d11a94dc78.diff

[PATCH] D121450: [clang-format] Handle attributes before case label.

This revision was automatically updated to reflect the committed changes. curdeius marked 2 inline comments as done. Closed by commit rG596fa2d90044: [clang-format] Handle attributes before case label. (authored by curdeius). Changed prior to commit:

[clang] 596fa2d - [clang-format] Handle attributes before case label.

Author: Marek Kurdej Date: 2022-03-13T21:53:40+01:00 New Revision: 596fa2d90044841c33b9a0e6b17406c2a45077a2 URL: https://github.com/llvm/llvm-project/commit/596fa2d90044841c33b9a0e6b17406c2a45077a2 DIFF: https://github.com/llvm/llvm-project/commit/596fa2d90044841c33b9a0e6b17406c2a45077a2.diff

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added reviewers: jfb, connorkuehl, rsmith, timpugh. void added subscribers: connorkuehl, Dan, xbolva00, shawnl, dexonsmith, daloni, hintonda, riccibruno, vlad.tsyrklevich, ebevhan, kees, pcc, nickdesaulniers. void added a comment. This is a soft reworking of @connorkuehl's work in

[PATCH] D121556: [randstruct] Add randomize structure layout support

void created this revision. Herald added subscribers: dang, jdoerfert, mgorny. Herald added a reviewer: aaron.ballman. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Randstruct feature is a

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

MyDeveloperDay added a comment. In D112019#3378024 , @HazardyKnusperkeks wrote: > Why limit to macros, could it be a member of AlignConsecutiveStyle and apply > to the other stuff as well? I personally don't have a use case other than the resource.h

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

MyDeveloperDay updated this revision to Diff 414950. MyDeveloperDay marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112019/new/ https://reviews.llvm.org/D112019 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

HazardyKnusperkeks added a comment. Why limit to macros, could it be a member of AlignConsecutiveStyle and apply to the other stuff as well? Comment at: clang/include/clang/Format/Format.h:256 + /// \endcode + /// \version 14 + unsigned AlignConsecutiveMacrosMinWidth;

[PATCH] D121549: Define ABI breaking class members correctly

mehdi_amini added inline comments. Comment at: mlir/lib/Target/SPIRV/Deserialization/Deserializer.h:601 + // TODO: place logger under #if LLVM_ENABLE_ABI_BREAKING_CHECKS #ifndef NDEBUG This is a private header (you're in the `lib` directory and not in the

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

curdeius accepted this revision. curdeius added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112019/new/ https://reviews.llvm.org/D112019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121550: [clang-format] Fix crash on invalid requires expression

curdeius accepted this revision. curdeius added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:215 +assert(CurrentToken->Previous && "Unknown previous token"); +FormatToken = *CurrentToken->Previous; +

[PATCH] D121373: [clang-tidy][docs] Fix wrong url in DontModifyStdNamespaceCheck

This revision was automatically updated to reflect the committed changes. Closed by commit rG665879b9e7d1: [clang-tidy][docs] Fix wrong url in DontModifyStdNamespaceCheck (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121372: [clang-tidy][docs][NFC] Update URL and docs of PostfixOperatorCheck

This revision was automatically updated to reflect the committed changes. Closed by commit rGd321f0992684: [clang-tidy][docs][NFC] Update URL and docs of PostfixOperatorCheck (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121214: [clang-tidy][docs][NFC] Refer to the CERT rule in bugprone-shared-ptr-array-mismatch docs

This revision was automatically updated to reflect the committed changes. Closed by commit rG200e7a847012: [clang-tidy][docs][NFC] Refer to the CERT rule in bugprone-shared-ptr-array… (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 665879b - [clang-tidy][docs] Fix wrong url in DontModifyStdNamespaceCheck

Author: Balazs Benics Date: 2022-03-13T17:51:00+01:00 New Revision: 665879b9e7d1bc1b3a329b152d27225d7c975ca3 URL: https://github.com/llvm/llvm-project/commit/665879b9e7d1bc1b3a329b152d27225d7c975ca3 DIFF: https://github.com/llvm/llvm-project/commit/665879b9e7d1bc1b3a329b152d27225d7c975ca3.diff

[clang-tools-extra] d321f09 - [clang-tidy][docs][NFC] Update URL and docs of PostfixOperatorCheck

Author: Balazs Benics Date: 2022-03-13T17:51:00+01:00 New Revision: d321f0992684b0dad255fe2d9bb14523a685c5c4 URL: https://github.com/llvm/llvm-project/commit/d321f0992684b0dad255fe2d9bb14523a685c5c4 DIFF: https://github.com/llvm/llvm-project/commit/d321f0992684b0dad255fe2d9bb14523a685c5c4.diff

[clang-tools-extra] 200e7a8 - [clang-tidy][docs][NFC] Refer to the CERT rule in bugprone-shared-ptr-array-mismatch docs

Author: Balazs Benics Date: 2022-03-13T17:51:00+01:00 New Revision: 200e7a84701257afe80fd0b168fef78cf29aa523 URL: https://github.com/llvm/llvm-project/commit/200e7a84701257afe80fd0b168fef78cf29aa523 DIFF: https://github.com/llvm/llvm-project/commit/200e7a84701257afe80fd0b168fef78cf29aa523.diff

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

MyDeveloperDay updated this revision to Diff 414938. MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. Herald added a project: All. Address review comments and update for current trunk (up the first supported version in the documentation) CHANGES SINCE LAST

[PATCH] D120610: [DebugInfo] Include DW_TAG_skeleton_unit when looking for parent UnitDie

ayermolo added a comment. @wenlei Thanks for digging in to this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120610/new/ https://reviews.llvm.org/D120610 ___ cfe-commits mailing list

[PATCH] D121550: [clang-format] Fix crash on invalid requires expression

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:424-425 - if (CurrentToken->is(tok::l_brace)) -Left->setType(TT_Unknown); // Not TT_ObjCBlockLParen + if (CurrentToken->is(tok::l_brace) &&

[PATCH] D121550: [clang-format] Fix crash on invalid requires expression

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, curdeius, MyDeveloperDay. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D121549: Define ABI breaking class members correctly

kovdan01 updated this revision to Diff 414929. kovdan01 added a comment. Fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121549/new/ https://reviews.llvm.org/D121549 Files: clang/lib/Sema/TypeLocBuilder.cpp clang/lib/Sema/TypeLocBuilder.h

[PATCH] D121549: Define ABI breaking class members correctly

kovdan01 created this revision. kovdan01 added reviewers: dexonsmith, craig.topper. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, ThomasRaoux, msifontes, ecnelises, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik,

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

HazardyKnusperkeks added a comment. You either get commit access https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access or ask someone of us to push it for you. In the latter case we need a name and mail for the commit. I recommend the former, especially if you want to contribute