[PATCH] D123155: [analyzer] Expose Taint.h to plugins

steakhal accepted this revision. steakhal added a comment. LGTM. Please note that we dont guarantee abi nor api compatibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123155/new/ https://reviews.llvm.org/D123155

[PATCH] D122885: [clang] Draft: Implement P1703R1

ChuanqiXu added a comment. In D122885#3431618 , @tbaeder wrote: > What patches are you talking about exactly? I mean D121588 D121589 D121590

[PATCH] D123182: [Concepts] Fix issue #53640

royjacobson updated this revision to Diff 420708. royjacobson added a comment. Fixed missing doc for new argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 Files: clang/docs/ReleaseNotes.rst

[PATCH] D123182: [Concepts] Fix issue #53640

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Constraints were used for overload resolution tie breaking even when it was not allowed because the functions had

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added a comment. In D121445#3431569 , @dyung wrote: > Hi, one of the tests you added. csky-toolchain.c seems to be failing on a > Windows build bot, and from a quick look, it appears to be a path separator > issue. Can you take a look? > >

[PATCH] D122885: [clang] Draft: Implement P1703R1

tbaeder added a comment. What patches are you talking about exactly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122885/new/ https://reviews.llvm.org/D122885 ___ cfe-commits mailing list

[PATCH] D122841: [analyzer] Consider all addrspaces in null dereference check

NoQ added a comment. I looked up the history. I believe this refers to https://clang.llvm.org/docs/LanguageExtensions.html#memory-references-to-specified-segments: > Annotating a pointer with address space #256 causes it to be code generated > relative to the X86 GS segment register, address

[PATCH] D123100: [Support/Hash functions] Change the `final()` and `result()` of the hashing functions to return an array of bytes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG330268ba346b: [Support/Hash functions] Change the `final()` and `result()` of the hashing… (authored by akyrtzi). Repository: rG LLVM Github

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

rjmccall added a comment. In D116203#3430332 , @aaron.ballman wrote: > In D116203#3425512 , @cjdb wrote: > >> I've noticed that libstdc++ has `using __remove_cv = typename >> remove_cv::type`, which causes

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ added a comment. I think interestingness definitely requires more work. In particular, in null dereference from `getenv()`, the note should be unprunable. But we can't control prunability dynamically yet, so it requires a bit more work. So I think this patch is ok to go and I'll hopefully

[PATCH] D122285: [analyzer] Add path note tags to standard library function summaries.

NoQ updated this revision to Diff 420701. NoQ added a comment. - Eliminate notes on known paths. - Add some documentation for the new class. - Mostly moved from existing documentation for the entire summary class. - Fix incorrect assessment that Exploded Graph is a tree. It's not even

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

dyung added a comment. Hi, one of the tests you added. csky-toolchain.c seems to be failing on a Windows build bot, and from a quick look, it appears to be a path separator issue. Can you take a look? https://lab.llvm.org/buildbot/#/builders/216/builds/2452 Repository: rG LLVM Github

[clang] 9906d38 - [NFC][CSKY] Fix the test error in toolchain case in windows by add UNSUPPORTED: system-windows

Author: Zi Xuan Wu Date: 2022-04-06T12:18:54+08:00 New Revision: 9906d38252d112894f304ba1b4fbdcd2cc93ab19 URL: https://github.com/llvm/llvm-project/commit/9906d38252d112894f304ba1b4fbdcd2cc93ab19 DIFF: https://github.com/llvm/llvm-project/commit/9906d38252d112894f304ba1b4fbdcd2cc93ab19.diff

[PATCH] D122981: [Clang] Diagnose incomplete return/param types only when function is not deleted

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14461 if (!ResultType->isDependentType() && !ResultType->isVoidType() && - !FD->isInvalidDecl() && + !FD->isInvalidDecl() && !FnDeleted && RequireCompleteType(FD->getLocation(),

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97e496054a37: [Clang][CSKY] Add the CSKY target and compiler driver (authored by zixuan-wu). Changed prior to commit:

[clang] 97e4960 - [Clang][CSKY] Add the CSKY target and compiler driver

Author: Zi Xuan Wu Date: 2022-04-06T11:37:37+08:00 New Revision: 97e496054a378131227262109c856f89b288c309 URL: https://github.com/llvm/llvm-project/commit/97e496054a378131227262109c856f89b288c309 DIFF: https://github.com/llvm/llvm-project/commit/97e496054a378131227262109c856f89b288c309.diff

[PATCH] D119544: Deferred Concept Instantiation Implementation

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:489 + // Attn Reviewers: we need to do this for the function constraints for + // comparison of constraints to work, but do we also need to do it for + // CheckInstantiatedFunctionConstraints? That

[PATCH] D122981: [Clang] Diagnose incomplete return/param types only when function is not deleted

rZhBoYao marked 2 inline comments as done. rZhBoYao added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1339 bool Delete = false; SourceLocation KWLoc; I'm thinking should we merge `FnDeleted` and `Deleted` into one variable or leave it as

[PATCH] D123100: [Support/Hash functions] Change the `final()` and `result()` of the hashing functions to return an array of bytes

dexonsmith accepted this revision. dexonsmith added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123100/new/ https://reviews.llvm.org/D123100 ___ cfe-commits mailing list

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

dexonsmith added a comment. In D122766#3429552 , @hans wrote: >> My feeling is that the default behavior on Windows needs to be to use >> backslashes and not forward slashes. > > Okay, how would folks feel about always canonicalizing `__FILE__` etc. to

[PATCH] D123155: [analyzer] Expose Taint.h to plugins

NoQ accepted this revision. NoQ added a comment. Looks good. I never intended taint to be inaccessible from plugins. Probably there are other headers in `lib/StaticAnalyzer/Checkers` that deserve the same treatment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121375: [clang] NFC, move the utility function CompilerInvocation::setLangDefaults to LangOptions.h

dexonsmith added a comment. In D121375#3429023 , @sammccall wrote: > I only see one usage in-tree (and one more in clspv). And migration is very > easy. I think you should do it all in this commit. Nice, agreed, no need to split up.

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb389354b2857: [Clang][PowerPC] Add max/min intrinsics to Clang and PPC backend (authored by tingwang). Repository: rG LLVM Github Monorepo

[clang] b389354 - [Clang][PowerPC] Add max/min intrinsics to Clang and PPC backend

Author: Ting Wang Date: 2022-04-05T22:43:48-04:00 New Revision: b389354b285744f700fd9372c8707fa056d7cb37 URL: https://github.com/llvm/llvm-project/commit/b389354b285744f700fd9372c8707fa056d7cb37 DIFF: https://github.com/llvm/llvm-project/commit/b389354b285744f700fd9372c8707fa056d7cb37.diff

[PATCH] D122885: [clang] Draft: Implement P1703R1

ChuanqiXu added a comment. BTW, I think it is helpful to add @iains's patches as parent versions to avoid conflicting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122885/new/ https://reviews.llvm.org/D122885

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

lkail updated this revision to Diff 420687. lkail added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122377/new/ https://reviews.llvm.org/D122377 Files: clang/lib/Basic/Targets/PPC.cpp

[PATCH] D122981: [Clang] Diagnose incomplete return/param types only when function is not deleted

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14457 // The return type of a function definition must be complete - // (C99 6.9.1p3, C++ [dcl.fct]p6). + // unless the function is deleted + // (C99 6.9.1p3, C++ [dcl.fct.def.general]p2).

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

lkail added a comment. In D122377#3428533 , @hubert.reinterpretcast wrote: > I am not sure that the choice of `isOSBinFormatELF` to (afaik) primarily > scope this change from affecting AIX (where we know the library calls are not > implemented to be

[clang] bcf8f21 - Revert "[InstrProfiling] No runtime hook for unused funcs"

Author: Gulfem Savrun Yeniceri Date: 2022-04-06T01:41:44Z New Revision: bcf8f2188bd53b2874bcd142960d22f3334e2051 URL: https://github.com/llvm/llvm-project/commit/bcf8f2188bd53b2874bcd142960d22f3334e2051 DIFF:

[PATCH] D123144: FileManager: std::map => BumpPtrAllocator + DenseMap of pointers

dexonsmith added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:318 FileEntryRef ReturnedRef(*NamedFileEnt); - if (UFE.isValid()) { // Already have an entry with this inode, return it. + if (ReusingEntry) { // Already have an entry with this inode, return it.

[PATCH] D123144: FileManager: std::map => BumpPtrAllocator + DenseMap of pointers

dexonsmith added a comment. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123144/new/ https://reviews.llvm.org/D123144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119609: [Clang][Sema] Prohibit statement expression in the default argument

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a4d388c7fa4: [Clang][Sema] Prohibit statement expression in the default argument (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8a4d388 - [Clang][Sema] Prohibit statement expression in the default argument

Author: Jun Zhang Date: 2022-04-06T09:28:20+08:00 New Revision: 8a4d388c7fa47fa50076babecc38757009dbc987 URL: https://github.com/llvm/llvm-project/commit/8a4d388c7fa47fa50076babecc38757009dbc987 DIFF: https://github.com/llvm/llvm-project/commit/8a4d388c7fa47fa50076babecc38757009dbc987.diff

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

bnbarham updated this revision to Diff 420678. bnbarham added a comment. Added a potential plan to remove the FileManager hacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123104/new/ https://reviews.llvm.org/D123104 Files:

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

bnbarham added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:758 + bool IsSystemHeaderDir, + StringRef FileName = ""); dexonsmith wrote: > benlangmuir wrote: > > This

[PATCH] D123167: [HLSL] Pointers are unsupported in HLSL

beanz created this revision. beanz added reviewers: aaron.ballman, MaskRay, kuhar, rnk, rsmith. Herald added a subscriber: StephenFan. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. HLSL does not support

[PATCH] D123104: [Modules] Use looked-up filename when looking for module maps

dexonsmith added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:758 + bool IsSystemHeaderDir, + StringRef FileName = ""); benlangmuir wrote: > This parameter could use a

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121757/new/ https://reviews.llvm.org/D121757

[PATCH] D119609: [Clang][Sema] Prohibit statement expression in the default argument

junaire updated this revision to Diff 420664. junaire edited the summary of this revision. junaire added a comment. - Add release note. - re-wrap line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119609/new/ https://reviews.llvm.org/D119609

[PATCH] D122958: [clang] Corrections for target_clones multiversion functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5531abaf7158: [clang] Corrections for target_clones multiversion functions. (authored by tahonermann). Repository: rG LLVM Github Monorepo

[PATCH] D122957: [clang] NFC: Preparation for merging code to emit target and target_clones resolvers.

This revision was automatically updated to reflect the committed changes. Closed by commit rG40af8df6fe64: [clang] NFC: Preparation for merging code to emit target and target_clones… (authored by tahonermann). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122956: [clang] NFC: Simplify the interface to CodeGenModule::GetOrCreateMultiVersionResolver().

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ace0100aec3: [clang] NFC: Simplify the interface to CodeGenModule… (authored by tahonermann). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122956/new/

[clang] 5531aba - [clang] Corrections for target_clones multiversion functions.

Author: Tom Honermann Date: 2022-04-05T19:50:22-04:00 New Revision: 5531abaf7158652bf7411937781780e9f6358ecf URL: https://github.com/llvm/llvm-project/commit/5531abaf7158652bf7411937781780e9f6358ecf DIFF: https://github.com/llvm/llvm-project/commit/5531abaf7158652bf7411937781780e9f6358ecf.diff

[PATCH] D122955: [clang] NFC: Enhance comments in CodeGen for multiversion function support.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tahonermann marked an inline comment as done. Closed by commit rGbed5ee3f4ba2: [clang] NFC: Enhance comments in CodeGen for multiversion function support. (authored by

[clang] 40af8df - [clang] NFC: Preparation for merging code to emit target and target_clones resolvers.

Author: Tom Honermann Date: 2022-04-05T19:50:22-04:00 New Revision: 40af8df6fe642749f9ac5486822c2bd5cc587ab7 URL: https://github.com/llvm/llvm-project/commit/40af8df6fe642749f9ac5486822c2bd5cc587ab7 DIFF: https://github.com/llvm/llvm-project/commit/40af8df6fe642749f9ac5486822c2bd5cc587ab7.diff

[clang] 0ace010 - [clang] NFC: Simplify the interface to CodeGenModule::GetOrCreateMultiVersionResolver().

Author: Tom Honermann Date: 2022-04-05T19:50:22-04:00 New Revision: 0ace0100aec31bdff7e856df806cca18d8faabd7 URL: https://github.com/llvm/llvm-project/commit/0ace0100aec31bdff7e856df806cca18d8faabd7 DIFF: https://github.com/llvm/llvm-project/commit/0ace0100aec31bdff7e856df806cca18d8faabd7.diff

[clang] bed5ee3 - [clang] NFC: Enhance comments in CodeGen for multiversion function support.

Author: Tom Honermann Date: 2022-04-05T19:50:22-04:00 New Revision: bed5ee3f4ba2406658760ec4029ed222c6213ff7 URL: https://github.com/llvm/llvm-project/commit/bed5ee3f4ba2406658760ec4029ed222c6213ff7 DIFF: https://github.com/llvm/llvm-project/commit/bed5ee3f4ba2406658760ec4029ed222c6213ff7.diff

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

sstwcw updated this revision to Diff 420653. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121757/new/ https://reviews.llvm.org/D121757 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/lib/Format/UnwrappedLineParser.h Index:

[PATCH] D123155: [analyzer] Expose Taint.h to plugins

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. The changes look good to me but please wait at least one more reviewer before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

sstwcw updated this revision to Diff 420652. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121757/new/ https://reviews.llvm.org/D121757 Files: clang/lib/Format/FormatToken.h clang/lib/Format/TokenAnnotator.cpp

[PATCH] D123155: [analyzer] Expose Taint.h to plugins

xazax.hun added reviewers: NoQ, steakhal, Szelethus, martong, xazax.hun. xazax.hun added a comment. Herald added a subscriber: rnkovacs. Adding some reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123155/new/

[PATCH] D122953: [clang] Emit target_clones resolver functions as COMDAT.

tahonermann closed this revision. tahonermann added a comment. Closing per commit 7c53fc4fe1308f5b2a7527d14ea41fabb18109b8 (I failed to add "Differential Revision" to the commit message). Repository: rG

[PATCH] D122952: [clang] NFC: Extend comdat validation in target multiversion function tests.

tahonermann closed this revision. tahonermann added a comment. Closing per commit 3531a4fa3b7038d43ac20f56871da88aa25bf53d (I failed to add "Differential Revision" to the commit message). Repository: rG

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

joaomoreira added inline comments. Comment at: clang/test/CodeGen/X86/x86-cf-protection.c:4 // RUN: %clang -target i386-unknown-unknown -x c -E -dM -o - -fcf-protection=full %s | FileCheck %s --check-prefix=FULL +// RUN: %clang -target i386-unknown-unknown -o - -emit-llvm -S

[PATCH] D123103: Revert "[VFS] RedirectingFileSystem only replace path if not already mapped"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf65b0b5dcfeb: Revert [VFS] RedirectingFileSystem only replace path if not already mapped (authored by bnbarham). Changed prior to commit:

[clang] f65b0b5 - Revert "[VFS] RedirectingFileSystem only replace path if not already mapped"

Author: Ben Barham Date: 2022-04-05T14:24:40-07:00 New Revision: f65b0b5dcfeb04e9e6794b32a075432ce3de1ccd URL: https://github.com/llvm/llvm-project/commit/f65b0b5dcfeb04e9e6794b32a075432ce3de1ccd DIFF: https://github.com/llvm/llvm-project/commit/f65b0b5dcfeb04e9e6794b32a075432ce3de1ccd.diff

[PATCH] D122691: [clang][Sema] Add flag to LookupName to force C/ObjC codepath

plotfi added subscribers: rjmccall, plotfi. plotfi added a comment. @rjmccall would you be able to review this patch? What do you think of this approach? This change is to support C++-Interop on the Swift side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1e08544 - [PS4] Fix header search list

Author: Paul Robinson Date: 2022-04-05T14:14:13-07:00 New Revision: 1e085448b36db240c9068c8c4e4cb12d4d7093cb URL: https://github.com/llvm/llvm-project/commit/1e085448b36db240c9068c8c4e4cb12d4d7093cb DIFF: https://github.com/llvm/llvm-project/commit/1e085448b36db240c9068c8c4e4cb12d4d7093cb.diff

[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

aaron.ballman added a comment. In D123074#3430789 , @AaronSiddharthaMondal wrote: > Ahh I didn't know that. After fixing my settings it is now linked correctly. > No need to revert. I'm glad that worked for you! > Thanks a lot for the help! Any

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

aaron.ballman added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:3462 - case 'u': // Identifier (uber) or C11/C++11 UTF-8 or UTF-16 string literal + // Identifer (e.g., uber), or + // UTF-8 (C2x/C++17) or UTF-16 (C11/C++11) character literal, or

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

ggeorgakoudis added a comment. In D120573#3415517 , @abidmalikwaterloo wrote: > Are you going to work on it? Just confirming. I am working on D122255 > . The code generation part for the dynamic > condition is useful.

[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

AaronSiddharthaMondal added a comment. Ahh I didn't know that. After fixing my settings it is now linked correctly. No need to revert. Thanks a lot for the help! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123074/new/

[PATCH] D123049: Emit OpenCL metadata when targeting SPIR-V

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG15a1769631ff: Emit OpenCL metadata when targeting SPIR-V (authored by shangwuyao). Repository: rG LLVM Github Monorepo

[clang] 15a1769 - Emit OpenCL metadata when targeting SPIR-V

Author: Shangwu Yao Date: 2022-04-05T20:58:32Z New Revision: 15a1769631ff0b2b3e830b03e51ae5f54f08a0ab URL: https://github.com/llvm/llvm-project/commit/15a1769631ff0b2b3e830b03e51ae5f54f08a0ab DIFF: https://github.com/llvm/llvm-project/commit/15a1769631ff0b2b3e830b03e51ae5f54f08a0ab.diff LOG:

[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

aaron.ballman added a comment. In D123074#3430705 , @AaronSiddharthaMondal wrote: > @aaron.ballman There may have been something wrong with the commit. On GitHub > it does not link to my user account. Would it be possible to change that? > The github

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

aaron.ballman added a comment. In D122874#3430672 , @philnik wrote: >> And if `[[msvc::no_unique_address]]` and `[[no_unique_address]]` (when >> eventually implemented) in MSVC have a different ABI impact, will we will >> leave

[PATCH] D122529: [ASTMatchers] Output currently matching node on crash

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4ad3c3891e5: Reland [ASTMatchers] Output currently matching node on crash (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122529/new/

[clang] b4ad3c3 - Reland "[ASTMatchers] Output currently matching node on crash"

Author: Nathan James Date: 2022-04-05T21:47:16+01:00 New Revision: b4ad3c3891e550b04db3aca73e1f34007e94eaa8 URL: https://github.com/llvm/llvm-project/commit/b4ad3c3891e550b04db3aca73e1f34007e94eaa8 DIFF: https://github.com/llvm/llvm-project/commit/b4ad3c3891e550b04db3aca73e1f34007e94eaa8.diff

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

erichkeane added a comment. In D122983#3427518 , @xbolva00 wrote: > Could you please check that https://github.com/llvm/llvm-test-suite is > buildable with your patch? Aaron wasn't able to get this working on his system, but I was. I ended up

[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

AaronSiddharthaMondal added a comment. @aaron.ballman There may have been something wrong with the commit. On GitHub it does not link to my user account. Would it be possible to change that? The github name is aaronmondal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex

beanz updated this revision to Diff 420620. beanz added a comment. Updates based on feedback from @aaron.ballman. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122699/new/ https://reviews.llvm.org/D122699 Files:

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

tahonermann added a comment. This looks pretty good to me. I added a few comments. I mostly just reviewed the lexer related code; I didn't dive into the name matching code. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:130-131 def

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

philnik added a subscriber: ldionne. philnik added a comment. > And if `[[msvc::no_unique_address]]` and `[[no_unique_address]]` (when > eventually implemented) in MSVC have a different ABI impact, will we will > leave `__attribute__((no_unique_address))` alone so it won't break ABI? I think

[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

aaron.ballman closed this revision. aaron.ballman added a comment. In D123074#3430623 , @AaronSiddharthaMondal wrote: > In D123074#3430355 , @aaron.ballman > wrote: > >> In D123074#3430351

[clang-tools-extra] 04b42c9 - Fix typo in new -config-file option

Author: Aaron Siddhartha Mondal Date: 2022-04-05T16:28:49-04:00 New Revision: 04b42c99f62216263662d1033fa9b3e12c65563e URL: https://github.com/llvm/llvm-project/commit/04b42c99f62216263662d1033fa9b3e12c65563e DIFF:

[PATCH] D123155: [analyzer] Expose Taint.h to plugins

tomrittervg created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. tomrittervg requested review of this revision. Herald added a

[PATCH] D122064: [clang-format][docs] Fix incorrect 'clang-format 11' option markers

kuzkry added a comment. Kind reminder, please deliver this revision. I don't have write access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122064/new/ https://reviews.llvm.org/D122064 ___ cfe-commits

[PATCH] D123148: [clang][extract-api] Process only APIs declared in inputs

zixuw added inline comments. Comment at: clang/test/ExtractAPI/known_files_only.c:20 +// Let's make sure we aren't pulling in symbols from complex.h +#include +double complex build_complex(double real, double imaginary); I would just include another header

[PATCH] D122955: [clang] NFC: Enhance comments in CodeGen for multiversion function support.

erichkeane accepted this revision. erichkeane added a comment. Still LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122955/new/ https://reviews.llvm.org/D122955 ___ cfe-commits mailing list

[PATCH] D122958: [clang] Corrections for target_clones multiversion functions.

erichkeane accepted this revision. erichkeane added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122958/new/ https://reviews.llvm.org/D122958 ___ cfe-commits mailing list

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

aaron.ballman added a comment. In D122874#3422489 , @philnik wrote: > In D122874#3422263 , @aaron.ballman > wrote: > >> I'm not opposed, but this does muddy the waters about the target-specific >> nature of the

[PATCH] D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option

AaronSiddharthaMondal added a comment. In D123074#3430355 , @aaron.ballman wrote: > In D123074#3430351 , @aaron.ballman > wrote: > >> LGTM, thank you for the fix! > > If you need me to commit on your behalf,

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman updated this revision to Diff 420612. aaron.ballman added a comment. Rebase; NFC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983/new/ https://reviews.llvm.org/D122983 Files: clang-tools-extra/clangd/IncludeFixer.cpp clang-tools-extra/clangd/ParsedAST.cpp

[PATCH] D123113: [Flang] Add `INTENT` for non-dummy arguments extension

klausler added a comment. What is going on here? I don't understand. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123113/new/ https://reviews.llvm.org/D123113 ___ cfe-commits mailing list

[PATCH] D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:47-48 // Note TableGen depends on the order above. Do not add or change the order // without adding related code to TableGen/ClangAttrEmitter.cpp. ///

[PATCH] D123113: [Flang] Add `INTENT` for non-dummy arguments extension

ekieri added reviewers: klausler, PeteSteinfeld. ekieri added a comment. Herald added a reviewer: awarzynski. Hi! Thanks for this patch, and for your interest in contributing to Flang! I will leave it to somebody more experienced to accept the patch -- I am not familiar with this extension, and

[PATCH] D122760: [OpenMP] Add OpenMP variant extension to keep the unmangled name

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3062 +if (auto *A = Global->getAttr()) + VariantGlobalsEmitted.insert(A->getFunction()); } jhuber6 wrote: > jdoerfert wrote: > > This looks like you now disable the

[PATCH] D123065: [clang-tidy] support --load in clang-tidy-diff.py/run-clang-tidy.py

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D123065#3427382 , @bernhardmgruber wrote: > I did not base this revision on my latest main >

[PATCH] D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex

beanz marked an inline comment as done. beanz added a comment. Thank you! Will update shortly. Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:47-48 // Note TableGen depends on the order above. Do not add or change the order // without adding related

[PATCH] D122760: [OpenMP] Add OpenMP variant extension to keep the unmangled name

jhuber6 updated this revision to Diff 420608. jhuber6 added a comment. Make suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122760/new/ https://reviews.llvm.org/D122760 Files: clang/include/clang/Basic/Attr.td

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

beanz added inline comments. Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:43 +return false; + if (!Version.getMinor()) +return false; python3kgae wrote: > beanz wrote: > > Do we need to verify this or can we just assume if there is no minor > >

[PATCH] D122760: [OpenMP] Add OpenMP variant extension to keep the unmangled name

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3062 +if (auto *A = Global->getAttr()) + VariantGlobalsEmitted.insert(A->getFunction()); } jdoerfert wrote: > This looks like you

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8550-8556 + case ParsedAttr::AT_RandomizeLayout: +handleSimpleAttribute(S, D, AL); +break; + case ParsedAttr::AT_NoRandomizeLayout: +// Drop the "randomize_layout" attribute if it's on the

[clang] 7c53fc4 - [clang] Emit target_clones resolver functions as COMDAT.

Author: Tom Honermann Date: 2022-04-05T15:34:35-04:00 New Revision: 7c53fc4fe1308f5b2a7527d14ea41fabb18109b8 URL: https://github.com/llvm/llvm-project/commit/7c53fc4fe1308f5b2a7527d14ea41fabb18109b8 DIFF: https://github.com/llvm/llvm-project/commit/7c53fc4fe1308f5b2a7527d14ea41fabb18109b8.diff

[clang] 3531a4f - [clang] NFC: Extend comdat validation in target multiversion function tests.

Author: Tom Honermann Date: 2022-04-05T15:34:35-04:00 New Revision: 3531a4fa3b7038d43ac20f56871da88aa25bf53d URL: https://github.com/llvm/llvm-project/commit/3531a4fa3b7038d43ac20f56871da88aa25bf53d DIFF: https://github.com/llvm/llvm-project/commit/3531a4fa3b7038d43ac20f56871da88aa25bf53d.diff

[PATCH] D122760: [OpenMP] Add OpenMP variant extension to keep the unmangled name

jdoerfert added a comment. There is no documentation of the extension and attribute. See also below. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1459 + if (auto *A = ND->getAttr()) +ND = A->getFunction(); std::string MangledName = getMangledNameImpl(*this, GD, ND);

[PATCH] D123019: [clang][extract-api] Add support for typedefs

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:611 + + (*Typedef)["type"] = Record.UnderlyingType.USR; + Curious: where does this come from the format spec? Is this required/correctly populated? I see a

[PATCH] D122760: [OpenMP] Add OpenMP variant extension to keep the unmangled name

jhuber6 updated this revision to Diff 420604. jhuber6 added a comment. Updating to stop erroring if a function with the same mangled error exists, but is never emitted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122760/new/

[PATCH] D123148: [clang][extract-api] Process only APIs declared in inputs

cishida added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:66 +// Check if we have looked up this particular file entry previously instead +// of querying the preprocessor for externsal sources. +if (UnknownFileEntries.count(File))

[PATCH] D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09f33a430b72: [AMDGPU][OpenCL] Remove printf and hostcall diagnostic (authored by scott.linder). Changed prior to commit:

  1   2   3   >